[INFO] fetching crate pnacl-build-helper 1.4.11...
[INFO] linting pnacl-build-helper-1.4.11 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate pnacl-build-helper 1.4.11 into /workspace/builds/worker-5-tc1/source
[INFO] started tweaking crates.io crate pnacl-build-helper 1.4.11
[INFO] finished tweaking crates.io crate pnacl-build-helper 1.4.11
[INFO] tweaked toml for crates.io crate pnacl-build-helper 1.4.11 written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate pnacl-build-helper 1.4.11 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 16 packages to latest compatible versions
[INFO] [stderr]       Adding walkdir v1.0.7 (available: v2.5.0)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 3c042a212afd18ab6f12827a961e466b85dc06f239a93b193dd8517997ca4a68
[INFO] running `Command { std: "docker" "start" "-a" "3c042a212afd18ab6f12827a961e466b85dc06f239a93b193dd8517997ca4a68", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "3c042a212afd18ab6f12827a961e466b85dc06f239a93b193dd8517997ca4a68", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3c042a212afd18ab6f12827a961e466b85dc06f239a93b193dd8517997ca4a68", kill_on_drop: false }`
[INFO] [stdout] 3c042a212afd18ab6f12827a961e466b85dc06f239a93b193dd8517997ca4a68
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] b3e13fba845154b25bdc9b816f36fac3e9680382febd4487f194dbb43ef2f4d7
[INFO] running `Command { std: "docker" "start" "-a" "b3e13fba845154b25bdc9b816f36fac3e9680382febd4487f194dbb43ef2f4d7", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking remove_dir_all v0.5.3
[INFO] [stderr]     Checking same-file v0.1.3
[INFO] [stderr]     Checking tempdir v0.3.7
[INFO] [stderr]     Checking walkdir v1.0.7
[INFO] [stderr]     Checking pnacl-build-helper v1.4.11 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unexpected `cfg` condition value: `nacl`
[INFO] [stdout]    --> src/lib.rs:244:11
[INFO] [stdout]     |
[INFO] [stdout] 244 | #[cfg(not(target_os = "nacl"))]
[INFO] [stdout]     |           ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: expected values for `target_os` are: `aix`, `amdhsa`, `android`, `cuda`, `cygwin`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `helenos`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `lynxos178`, `macos`, `managarm`, `motor`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `psx`, `qurt`, `redox`, `rtems`, `solaris`, and `solid_asp3` and 14 more
[INFO] [stdout]     = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
[INFO] [stdout]     = note: `#[warn(unexpected_cfgs)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unexpected `cfg` condition value: `nacl`
[INFO] [stdout]    --> src/lib.rs:273:7
[INFO] [stdout]     |
[INFO] [stdout] 273 | #[cfg(target_os = "nacl")]
[INFO] [stdout]     |       ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: expected values for `target_os` are: `aix`, `amdhsa`, `android`, `cuda`, `cygwin`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `helenos`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `lynxos178`, `macos`, `managarm`, `motor`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `psx`, `qurt`, `redox`, `rtems`, `solaris`, and `solid_asp3` and 14 more
[INFO] [stdout]     = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unexpected `cfg` condition value: `nacl`
[INFO] [stdout]    --> src/lib.rs:276:11
[INFO] [stdout]     |
[INFO] [stdout] 276 | #[cfg(not(target_os = "nacl"))]
[INFO] [stdout]     |           ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: expected values for `target_os` are: `aix`, `amdhsa`, `android`, `cuda`, `cygwin`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `helenos`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `lynxos178`, `macos`, `managarm`, `motor`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `psx`, `qurt`, `redox`, `rtems`, `solaris`, and `solid_asp3` and 14 more
[INFO] [stdout]     = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unexpected `cfg` condition value: `nacl`
[INFO] [stdout]    --> src/lib.rs:302:7
[INFO] [stdout]     |
[INFO] [stdout] 302 | #[cfg(target_os = "nacl")]
[INFO] [stdout]     |       ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: expected values for `target_os` are: `aix`, `amdhsa`, `android`, `cuda`, `cygwin`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `helenos`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `lynxos178`, `macos`, `managarm`, `motor`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `psx`, `qurt`, `redox`, `rtems`, `solaris`, and `solid_asp3` and 14 more
[INFO] [stdout]     = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:228:17
[INFO] [stdout]     |
[INFO] [stdout] 228 |                 cc: cc,
[INFO] [stdout]     |                 ^^^^^^ help: replace it with: `cc`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:229:17
[INFO] [stdout]     |
[INFO] [stdout] 229 |                 cxx: cxx,
[INFO] [stdout]     |                 ^^^^^^^^ help: replace it with: `cxx`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:230:17
[INFO] [stdout]     |
[INFO] [stdout] 230 |                 ar: ar,
[INFO] [stdout]     |                 ^^^^^^ help: replace it with: `ar`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:231:17
[INFO] [stdout]     |
[INFO] [stdout] 231 |                 ranlib: ranlib,
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^ help: replace it with: `ranlib`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:346:13
[INFO] [stdout]     |
[INFO] [stdout] 346 |             tools: tools,
[INFO] [stdout]     |             ^^^^^^^^^^^^ help: replace it with: `tools`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:347:13
[INFO] [stdout]     |
[INFO] [stdout] 347 |             args:  args,
[INFO] [stdout]     |             ^^^^^^^^^^^ help: replace it with: `args`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:376:13
[INFO] [stdout]     |
[INFO] [stdout] 376 |             src_dir: src_dir,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `src_dir`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unexpected `cfg` condition value: `nacl`
[INFO] [stdout]    --> src/lib.rs:244:11
[INFO] [stdout]     |
[INFO] [stdout] 244 | #[cfg(not(target_os = "nacl"))]
[INFO] [stdout]     |           ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: expected values for `target_os` are: `aix`, `amdhsa`, `android`, `cuda`, `cygwin`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `helenos`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `lynxos178`, `macos`, `managarm`, `motor`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `psx`, `qurt`, `redox`, `rtems`, `solaris`, and `solid_asp3` and 14 more
[INFO] [stdout]     = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
[INFO] [stdout]     = note: `#[warn(unexpected_cfgs)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unexpected `cfg` condition value: `nacl`
[INFO] [stdout]    --> src/lib.rs:273:7
[INFO] [stdout]     |
[INFO] [stdout] 273 | #[cfg(target_os = "nacl")]
[INFO] [stdout]     |       ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: expected values for `target_os` are: `aix`, `amdhsa`, `android`, `cuda`, `cygwin`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `helenos`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `lynxos178`, `macos`, `managarm`, `motor`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `psx`, `qurt`, `redox`, `rtems`, `solaris`, and `solid_asp3` and 14 more
[INFO] [stdout]     = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unexpected `cfg` condition value: `nacl`
[INFO] [stdout]    --> src/lib.rs:276:11
[INFO] [stdout]     |
[INFO] [stdout] 276 | #[cfg(not(target_os = "nacl"))]
[INFO] [stdout]     |           ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: expected values for `target_os` are: `aix`, `amdhsa`, `android`, `cuda`, `cygwin`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `helenos`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `lynxos178`, `macos`, `managarm`, `motor`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `psx`, `qurt`, `redox`, `rtems`, `solaris`, and `solid_asp3` and 14 more
[INFO] [stdout]     = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unexpected `cfg` condition value: `nacl`
[INFO] [stdout]    --> src/lib.rs:302:7
[INFO] [stdout]     |
[INFO] [stdout] 302 | #[cfg(target_os = "nacl")]
[INFO] [stdout]     |       ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: expected values for `target_os` are: `aix`, `amdhsa`, `android`, `cuda`, `cygwin`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `helenos`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `lynxos178`, `macos`, `managarm`, `motor`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `psx`, `qurt`, `redox`, `rtems`, `solaris`, and `solid_asp3` and 14 more
[INFO] [stdout]     = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:228:17
[INFO] [stdout]     |
[INFO] [stdout] 228 |                 cc: cc,
[INFO] [stdout]     |                 ^^^^^^ help: replace it with: `cc`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:229:17
[INFO] [stdout]     |
[INFO] [stdout] 229 |                 cxx: cxx,
[INFO] [stdout]     |                 ^^^^^^^^ help: replace it with: `cxx`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:230:17
[INFO] [stdout]     |
[INFO] [stdout] 230 |                 ar: ar,
[INFO] [stdout]     |                 ^^^^^^ help: replace it with: `ar`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:231:17
[INFO] [stdout]     |
[INFO] [stdout] 231 |                 ranlib: ranlib,
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^ help: replace it with: `ranlib`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:346:13
[INFO] [stdout]     |
[INFO] [stdout] 346 |             tools: tools,
[INFO] [stdout]     |             ^^^^^^^^^^^^ help: replace it with: `tools`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:347:13
[INFO] [stdout]     |
[INFO] [stdout] 347 |             args:  args,
[INFO] [stdout]     |             ^^^^^^^^^^^ help: replace it with: `args`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:376:13
[INFO] [stdout]     |
[INFO] [stdout] 376 |             src_dir: src_dir,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `src_dir`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `std::slice::<impl [T]>::connect`: renamed to join
[INFO] [stdout]   --> src/lib.rs:89:14
[INFO] [stdout]    |
[INFO] [stdout] 89 |             .connect("_");
[INFO] [stdout]    |              ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] help: replace the use of the deprecated method
[INFO] [stdout]    |
[INFO] [stdout] 89 -             .connect("_");
[INFO] [stdout] 89 +             .join("_");
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `std::slice::<impl [T]>::connect`: renamed to join
[INFO] [stdout]   --> src/lib.rs:89:14
[INFO] [stdout]    |
[INFO] [stdout] 89 |             .connect("_");
[INFO] [stdout]    |              ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] help: replace the use of the deprecated method
[INFO] [stdout]    |
[INFO] [stdout] 89 -             .connect("_");
[INFO] [stdout] 89 +             .join("_");
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you don't need to add `&` to all patterns
[INFO] [stdout]   --> src/lib.rs:25:17
[INFO] [stdout]    |
[INFO] [stdout] 25 |           let s = match self {
[INFO] [stdout]    |  _________________^
[INFO] [stdout] 26 | |             &NaClMode::Portable => "le32",
[INFO] [stdout] 27 | |             &NaClMode::Native(s) => s,
[INFO] [stdout] 28 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stdout]    = note: `#[warn(clippy::match_ref_pats)]` on by default
[INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stdout]    |
[INFO] [stdout] 25 ~         let s = match *self {
[INFO] [stdout] 26 ~             NaClMode::Portable => "le32",
[INFO] [stdout] 27 ~             NaClMode::Native(s) => s,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you don't need to add `&` to all patterns
[INFO] [stdout]   --> src/lib.rs:25:17
[INFO] [stdout]    |
[INFO] [stdout] 25 |           let s = match self {
[INFO] [stdout]    |  _________________^
[INFO] [stdout] 26 | |             &NaClMode::Portable => "le32",
[INFO] [stdout] 27 | |             &NaClMode::Native(s) => s,
[INFO] [stdout] 28 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stdout]    = note: `#[warn(clippy::match_ref_pats)]` on by default
[INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stdout]    |
[INFO] [stdout] 25 ~         let s = match *self {
[INFO] [stdout] 26 ~             NaClMode::Portable => "le32",
[INFO] [stdout] 27 ~             NaClMode::Native(s) => s,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `mode` after checking its variant with `is_none`
[INFO] [stdout]    --> src/lib.rs:175:24
[INFO] [stdout]     |
[INFO] [stdout] 165 |         if mode.is_none() {
[INFO] [stdout]     |         ----------------- help: try: `if let Some(<item>) = mode`
[INFO] [stdout] ...
[INFO] [stdout] 175 |             let mode = mode.unwrap();
[INFO] [stdout]     |                        ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant slicing of the whole range
[INFO] [stdout]    --> src/lib.rs:169:35
[INFO] [stdout]     |
[INFO] [stdout] 169 |                 cc: non_nacl::gcc(&target[..]),
[INFO] [stdout]     |                                   ^^^^^^^^^^^ help: use the original value instead: `target`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
[INFO] [stdout]     = note: `#[warn(clippy::redundant_slicing)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant slicing of the whole range
[INFO] [stdout]    --> src/lib.rs:170:36
[INFO] [stdout]     |
[INFO] [stdout] 170 |                 cxx: non_nacl::gxx(&target[..]),
[INFO] [stdout]     |                                    ^^^^^^^^^^^ help: use the original value instead: `target`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant slicing of the whole range
[INFO] [stdout]    --> src/lib.rs:171:34
[INFO] [stdout]     |
[INFO] [stdout] 171 |                 ar: non_nacl::ar(&target[..]),
[INFO] [stdout]     |                                  ^^^^^^^^^^^ help: use the original value instead: `target`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant slicing of the whole range
[INFO] [stdout]    --> src/lib.rs:172:42
[INFO] [stdout]     |
[INFO] [stdout] 172 |                 ranlib: non_nacl::ranlib(&target[..]),
[INFO] [stdout]     |                                          ^^^^^^^^^^^ help: use the original value instead: `target`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `mode` after checking its variant with `is_none`
[INFO] [stdout]    --> src/lib.rs:175:24
[INFO] [stdout]     |
[INFO] [stdout] 165 |         if mode.is_none() {
[INFO] [stdout]     |         ----------------- help: try: `if let Some(<item>) = mode`
[INFO] [stdout] ...
[INFO] [stdout] 175 |             let mode = mode.unwrap();
[INFO] [stdout]     |                        ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant slicing of the whole range
[INFO] [stdout]    --> src/lib.rs:169:35
[INFO] [stdout]     |
[INFO] [stdout] 169 |                 cc: non_nacl::gcc(&target[..]),
[INFO] [stdout]     |                                   ^^^^^^^^^^^ help: use the original value instead: `target`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
[INFO] [stdout]     = note: `#[warn(clippy::redundant_slicing)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant slicing of the whole range
[INFO] [stdout]    --> src/lib.rs:170:36
[INFO] [stdout]     |
[INFO] [stdout] 170 |                 cxx: non_nacl::gxx(&target[..]),
[INFO] [stdout]     |                                    ^^^^^^^^^^^ help: use the original value instead: `target`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant slicing of the whole range
[INFO] [stdout]    --> src/lib.rs:171:34
[INFO] [stdout]     |
[INFO] [stdout] 171 |                 ar: non_nacl::ar(&target[..]),
[INFO] [stdout]     |                                  ^^^^^^^^^^^ help: use the original value instead: `target`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant slicing of the whole range
[INFO] [stdout]    --> src/lib.rs:172:42
[INFO] [stdout]     |
[INFO] [stdout] 172 |                 ranlib: non_nacl::ranlib(&target[..]),
[INFO] [stdout]     |                                          ^^^^^^^^^^^ help: use the original value instead: `target`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference
[INFO] [stdout]    --> src/lib.rs:348:48
[INFO] [stdout]     |
[INFO] [stdout] 348 |             built_libs: built_libs.iter().map(|&(ref p, ref l): &(PathBuf, String)| {
[INFO] [stdout]     |                                                ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrowed_reference)]` on by default
[INFO] [stdout] help: try removing the `&` and `ref` parts
[INFO] [stdout]     |
[INFO] [stdout] 348 -             built_libs: built_libs.iter().map(|&(ref p, ref l): &(PathBuf, String)| {
[INFO] [stdout] 348 +             built_libs: built_libs.iter().map(|(p, l): &(PathBuf, String)| {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/lib.rs:384:29
[INFO] [stdout]     |
[INFO] [stdout] 384 |             .unwrap_or_else(|| VecDeque::new() );
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `VecDeque::new`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:433:20
[INFO] [stdout]     |
[INFO] [stdout] 433 |                 if !files.is_ok() { continue; }
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^ help: try: `files.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:439:24
[INFO] [stdout]     |
[INFO] [stdout] 439 |                     if !stat.is_ok() { continue; }
[INFO] [stdout]     |                        ^^^^^^^^^^^^^ help: try: `stat.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:400:13
[INFO] [stdout]     |
[INFO] [stdout] 400 |             return self.fresh.get().unwrap();
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 400 -             return self.fresh.get().unwrap();
[INFO] [stdout] 400 +             self.fresh.get().unwrap()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:457:13
[INFO] [stdout]     |
[INFO] [stdout] 457 |             return self.fresh.get().unwrap();
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 457 -             return self.fresh.get().unwrap();
[INFO] [stdout] 457 +             self.fresh.get().unwrap()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference
[INFO] [stdout]    --> src/lib.rs:406:23
[INFO] [stdout]     |
[INFO] [stdout] 406 |                 .map(|&(ref p, ref s)| (p, s.split(':').next().expect("invalid extern lib spec?")) )
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stdout] help: try removing the `&` and `ref` parts
[INFO] [stdout]     |
[INFO] [stdout] 406 -                 .map(|&(ref p, ref s)| (p, s.split(':').next().expect("invalid extern lib spec?")) )
[INFO] [stdout] 406 +                 .map(|(p, s)| (p, s.split(':').next().expect("invalid extern lib spec?")) )
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of a legacy numeric method
[INFO] [stdout]    --> src/lib.rs:411:39
[INFO] [stdout]     |
[INFO] [stdout] 411 |             let mut oldest_lib: i64 = i64::max_value();
[INFO] [stdout]     |                                       ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]     = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] help: use the associated constant instead
[INFO] [stdout]     |
[INFO] [stdout] 411 -             let mut oldest_lib: i64 = i64::max_value();
[INFO] [stdout] 411 +             let mut oldest_lib: i64 = i64::MAX;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:432:38
[INFO] [stdout]     |
[INFO] [stdout] 432 |                 let files = read_dir(&dir);
[INFO] [stdout]     |                                      ^^^^ help: change this to: `dir`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/lib.rs:455:13
[INFO] [stdout]     |
[INFO] [stdout] 455 |             println!("");
[INFO] [stdout]     |             ^^^^^^^^^--^
[INFO] [stdout]     |                      |
[INFO] [stdout]     |                      help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]     = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/lib.rs:456:13
[INFO] [stdout]     |
[INFO] [stdout] 456 |             println!("");
[INFO] [stdout]     |             ^^^^^^^^^--^
[INFO] [stdout]     |                      |
[INFO] [stdout]     |                      help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference
[INFO] [stdout]    --> src/lib.rs:348:48
[INFO] [stdout]     |
[INFO] [stdout] 348 |             built_libs: built_libs.iter().map(|&(ref p, ref l): &(PathBuf, String)| {
[INFO] [stdout]     |                                                ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrowed_reference)]` on by default
[INFO] [stdout] help: try removing the `&` and `ref` parts
[INFO] [stdout]     |
[INFO] [stdout] 348 -             built_libs: built_libs.iter().map(|&(ref p, ref l): &(PathBuf, String)| {
[INFO] [stdout] 348 +             built_libs: built_libs.iter().map(|(p, l): &(PathBuf, String)| {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/lib.rs:384:29
[INFO] [stdout]     |
[INFO] [stdout] 384 |             .unwrap_or_else(|| VecDeque::new() );
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `VecDeque::new`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:433:20
[INFO] [stdout]     |
[INFO] [stdout] 433 |                 if !files.is_ok() { continue; }
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^ help: try: `files.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:439:24
[INFO] [stdout]     |
[INFO] [stdout] 439 |                     if !stat.is_ok() { continue; }
[INFO] [stdout]     |                        ^^^^^^^^^^^^^ help: try: `stat.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:400:13
[INFO] [stdout]     |
[INFO] [stdout] 400 |             return self.fresh.get().unwrap();
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 400 -             return self.fresh.get().unwrap();
[INFO] [stdout] 400 +             self.fresh.get().unwrap()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:457:13
[INFO] [stdout]     |
[INFO] [stdout] 457 |             return self.fresh.get().unwrap();
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 457 -             return self.fresh.get().unwrap();
[INFO] [stdout] 457 +             self.fresh.get().unwrap()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference
[INFO] [stdout]    --> src/lib.rs:406:23
[INFO] [stdout]     |
[INFO] [stdout] 406 |                 .map(|&(ref p, ref s)| (p, s.split(':').next().expect("invalid extern lib spec?")) )
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stdout] help: try removing the `&` and `ref` parts
[INFO] [stdout]     |
[INFO] [stdout] 406 -                 .map(|&(ref p, ref s)| (p, s.split(':').next().expect("invalid extern lib spec?")) )
[INFO] [stdout] 406 +                 .map(|(p, s)| (p, s.split(':').next().expect("invalid extern lib spec?")) )
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of a legacy numeric method
[INFO] [stdout]    --> src/lib.rs:411:39
[INFO] [stdout]     |
[INFO] [stdout] 411 |             let mut oldest_lib: i64 = i64::max_value();
[INFO] [stdout]     |                                       ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]     = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] help: use the associated constant instead
[INFO] [stdout]     |
[INFO] [stdout] 411 -             let mut oldest_lib: i64 = i64::max_value();
[INFO] [stdout] 411 +             let mut oldest_lib: i64 = i64::MAX;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/lib.rs:489:9
[INFO] [stdout]     |
[INFO] [stdout] 489 |         println!("");
[INFO] [stdout]     |         ^^^^^^^^^--^
[INFO] [stdout]     |                  |
[INFO] [stdout]     |                  help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/lib.rs:490:9
[INFO] [stdout]     |
[INFO] [stdout] 490 |         println!("");
[INFO] [stdout]     |         ^^^^^^^^^--^
[INFO] [stdout]     |                  |
[INFO] [stdout]     |                  help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:432:38
[INFO] [stdout]     |
[INFO] [stdout] 432 |                 let files = read_dir(&dir);
[INFO] [stdout]     |                                      ^^^^ help: change this to: `dir`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:503:40
[INFO] [stdout]     |
[INFO] [stdout] 503 |             let mut cmd = Command::new(&make_prog);
[INFO] [stdout]     |                                        ^^^^^^^^^^ help: change this to: `make_prog`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:511:52
[INFO] [stdout]     |
[INFO] [stdout] 511 |                         let mut cmd = Command::new(&make_prog);
[INFO] [stdout]     |                                                    ^^^^^^^^^^ help: change this to: `make_prog`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/lib.rs:524:13
[INFO] [stdout]     |
[INFO] [stdout] 524 |             println!("");
[INFO] [stdout]     |             ^^^^^^^^^--^
[INFO] [stdout]     |                      |
[INFO] [stdout]     |                      help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/lib.rs:455:13
[INFO] [stdout]     |
[INFO] [stdout] 455 |             println!("");
[INFO] [stdout]     |             ^^^^^^^^^--^
[INFO] [stdout]     |                      |
[INFO] [stdout]     |                      help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]     = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/lib.rs:525:13
[INFO] [stdout]     |
[INFO] [stdout] 525 |             println!("");
[INFO] [stdout]     |             ^^^^^^^^^--^
[INFO] [stdout]     |                      |
[INFO] [stdout]     |                      help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/lib.rs:456:13
[INFO] [stdout]     |
[INFO] [stdout] 456 |             println!("");
[INFO] [stdout]     |             ^^^^^^^^^--^
[INFO] [stdout]     |                      |
[INFO] [stdout]     |                      help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/lib.rs:489:9
[INFO] [stdout]     |
[INFO] [stdout] 489 |         println!("");
[INFO] [stdout]     |         ^^^^^^^^^--^
[INFO] [stdout]     |                  |
[INFO] [stdout]     |                  help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/lib.rs:490:9
[INFO] [stdout]     |
[INFO] [stdout] 490 |         println!("");
[INFO] [stdout]     |         ^^^^^^^^^--^
[INFO] [stdout]     |                  |
[INFO] [stdout]     |                  help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:503:40
[INFO] [stdout]     |
[INFO] [stdout] 503 |             let mut cmd = Command::new(&make_prog);
[INFO] [stdout]     |                                        ^^^^^^^^^^ help: change this to: `make_prog`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/lib.rs:611:9
[INFO] [stdout]     |
[INFO] [stdout] 611 | /         match target {
[INFO] [stdout] 612 | |             Some(NaClMode::Portable) => {
[INFO] [stdout] 613 | |                 a.push(format!("-I{}/include/pnacl", sdk.display()))
[INFO] [stdout] ...   |
[INFO] [stdout] 616 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 611 ~         if let Some(NaClMode::Portable) = target {
[INFO] [stdout] 612 +             a.push(format!("-I{}/include/pnacl", sdk.display()))
[INFO] [stdout] 613 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:511:52
[INFO] [stdout]     |
[INFO] [stdout] 511 |                         let mut cmd = Command::new(&make_prog);
[INFO] [stdout]     |                                                    ^^^^^^^^^^ help: change this to: `make_prog`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/lib.rs:524:13
[INFO] [stdout]     |
[INFO] [stdout] 524 |             println!("");
[INFO] [stdout]     |             ^^^^^^^^^--^
[INFO] [stdout]     |                      |
[INFO] [stdout]     |                      help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/lib.rs:525:13
[INFO] [stdout]     |
[INFO] [stdout] 525 |             println!("");
[INFO] [stdout]     |             ^^^^^^^^^--^
[INFO] [stdout]     |                      |
[INFO] [stdout]     |                      help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/lib.rs:611:9
[INFO] [stdout]     |
[INFO] [stdout] 611 | /         match target {
[INFO] [stdout] 612 | |             Some(NaClMode::Portable) => {
[INFO] [stdout] 613 | |                 a.push(format!("-I{}/include/pnacl", sdk.display()))
[INFO] [stdout] ...   |
[INFO] [stdout] 616 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 611 ~         if let Some(NaClMode::Portable) = target {
[INFO] [stdout] 612 +             a.push(format!("-I{}/include/pnacl", sdk.display()))
[INFO] [stdout] 613 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.77s
[INFO] running `Command { std: "docker" "inspect" "b3e13fba845154b25bdc9b816f36fac3e9680382febd4487f194dbb43ef2f4d7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "b3e13fba845154b25bdc9b816f36fac3e9680382febd4487f194dbb43ef2f4d7", kill_on_drop: false }`
[INFO] [stdout] b3e13fba845154b25bdc9b816f36fac3e9680382febd4487f194dbb43ef2f4d7