[INFO] fetching crate pmgr 0.3.1... [INFO] linting pmgr-0.3.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pmgr 0.3.1 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate pmgr 0.3.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate pmgr 0.3.1 [INFO] tweaked toml for crates.io crate pmgr 0.3.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pmgr 0.3.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate pmgr 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unicode-bidi v0.3.17 [INFO] [stderr] Downloaded clap v4.5.19 [INFO] [stderr] Downloaded clap_complete v4.5.33 [INFO] [stderr] Downloaded clap_builder v4.5.19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 53c201ff949939cf6160762f0583b554b0f7305b216339d2de330d2c1cbd9c27 [INFO] running `Command { std: "docker" "start" "-a" "53c201ff949939cf6160762f0583b554b0f7305b216339d2de330d2c1cbd9c27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53c201ff949939cf6160762f0583b554b0f7305b216339d2de330d2c1cbd9c27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53c201ff949939cf6160762f0583b554b0f7305b216339d2de330d2c1cbd9c27", kill_on_drop: false }` [INFO] [stdout] 53c201ff949939cf6160762f0583b554b0f7305b216339d2de330d2c1cbd9c27 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 000f89aaaab43db7ae9a810cb418ac81c7b42111068ce4a8e77a3d7edea490b0 [INFO] running `Command { std: "docker" "start" "-a" "000f89aaaab43db7ae9a810cb418ac81c7b42111068ce4a8e77a3d7edea490b0", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking unicode-bidi v0.3.17 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking clap_builder v4.5.19 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking clap v4.5.19 [INFO] [stderr] Checking clap_complete v4.5.33 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking pmgr v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `unwrap` on `self.group_name` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/list.rs:26:31 [INFO] [stdout] | [INFO] [stdout] 25 | if self.group_name.is_some() && !self.all { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 26 | let group_name = &self.group_name.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.group_name` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/list.rs:26:31 [INFO] [stdout] | [INFO] [stdout] 25 | if self.group_name.is_some() && !self.all { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 26 | let group_name = &self.group_name.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.group_name` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/task.rs:252:30 [INFO] [stdout] | [INFO] [stdout] 251 | if self.group_name.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = self.group_name` [INFO] [stdout] 252 | let group_name = self.group_name.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/commands/mod.rs:81:18 [INFO] [stdout] | [INFO] [stdout] 81 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.group_name` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/task.rs:252:30 [INFO] [stdout] | [INFO] [stdout] 251 | if self.group_name.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = self.group_name` [INFO] [stdout] 252 | let group_name = self.group_name.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ProjectInformation` [INFO] [stdout] --> src/data/mod.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | / pub fn new() -> Self { [INFO] [stdout] 99 | | ProjectInformation { [INFO] [stdout] 100 | | title: None, [INFO] [stdout] 101 | | description: None, [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 97 + impl Default for ProjectInformation { [INFO] [stdout] 98 + fn default() -> Self { [INFO] [stdout] 99 + Self::new() [INFO] [stdout] 100 + } [INFO] [stdout] 101 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/commands/mod.rs:81:18 [INFO] [stdout] | [INFO] [stdout] 81 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ProjectInformation` [INFO] [stdout] --> src/data/mod.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | / pub fn new() -> Self { [INFO] [stdout] 99 | | ProjectInformation { [INFO] [stdout] 100 | | title: None, [INFO] [stdout] 101 | | description: None, [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 97 + impl Default for ProjectInformation { [INFO] [stdout] 98 + fn default() -> Self { [INFO] [stdout] 99 + Self::new() [INFO] [stdout] 100 + } [INFO] [stdout] 101 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> tests/remove.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use common; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> tests/delete.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use common; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> tests/watch.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use common; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> tests/create.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use common; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> tests/task.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use common; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> tests/add.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use common; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> tests/check.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use common; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> tests/check.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | / match utils::check_data(file_name) { [INFO] [stdout] 17 | | Ok(data) => panic!("Data shouldn't exist, exists at: {:?}", data), [INFO] [stdout] 18 | | Err(_) => (), [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ help: try: `if let Ok(data) = utils::check_data(file_name) { panic!("Data shouldn't exist, exists at: {:?}", data) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> tests/init.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use common; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/init.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | if !fs::metadata(file_name).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(file_name).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.88s [INFO] running `Command { std: "docker" "inspect" "000f89aaaab43db7ae9a810cb418ac81c7b42111068ce4a8e77a3d7edea490b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "000f89aaaab43db7ae9a810cb418ac81c7b42111068ce4a8e77a3d7edea490b0", kill_on_drop: false }` [INFO] [stdout] 000f89aaaab43db7ae9a810cb418ac81c7b42111068ce4a8e77a3d7edea490b0