[INFO] fetching crate pi_rust 0.1.2... [INFO] linting pi_rust-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pi_rust 0.1.2 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate pi_rust 0.1.2 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate pi_rust 0.1.2 [INFO] tweaked toml for crates.io crate pi_rust 0.1.2 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pi_rust 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate pi_rust 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded borsh-derive v1.5.5 [INFO] [stderr] Downloaded stellar-base v0.6.0 [INFO] [stderr] Downloaded xdr-rs-serialize v0.3.1 [INFO] [stderr] Downloaded xdr-rs-serialize-derive v0.3.1 [INFO] [stderr] Downloaded borsh v1.5.5 [INFO] [stderr] Downloaded uuid v1.15.1 [INFO] [stderr] Downloaded rust_decimal v1.36.0 [INFO] [stderr] Downloaded rustix v1.0.0 [INFO] [stderr] Downloaded nacl v0.5.3 [INFO] [stderr] Downloaded sodiumoxide v0.2.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bab6fd17d60da6ea7886d1fc7cf21bc4370528348b7ce890acefdd1c79441e21 [INFO] running `Command { std: "docker" "start" "-a" "bab6fd17d60da6ea7886d1fc7cf21bc4370528348b7ce890acefdd1c79441e21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bab6fd17d60da6ea7886d1fc7cf21bc4370528348b7ce890acefdd1c79441e21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bab6fd17d60da6ea7886d1fc7cf21bc4370528348b7ce890acefdd1c79441e21", kill_on_drop: false }` [INFO] [stdout] bab6fd17d60da6ea7886d1fc7cf21bc4370528348b7ce890acefdd1c79441e21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6b3b45e1e742c0beacdf7743b353af2a4968ba328eb1105a37ace52b25c0f16e [INFO] running `Command { std: "docker" "start" "-a" "6b3b45e1e742c0beacdf7743b353af2a4968ba328eb1105a37ace52b25c0f16e", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.14.0 [INFO] [stderr] Compiling openssl-sys v0.9.106 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Compiling ring v0.17.13 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling syn v2.0.99 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking log v0.4.26 [INFO] [stderr] Checking indexmap v2.7.1 [INFO] [stderr] Compiling libsodium-sys v0.2.7 [INFO] [stderr] Compiling crc16 v0.4.0 [INFO] [stderr] Compiling rustls v0.23.23 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling anyhow v1.0.97 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking chrono v0.4.40 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking webpki-roots v0.26.8 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking base32 v0.4.0 [INFO] [stderr] Checking nacl v0.5.3 [INFO] [stderr] Checking data-encoding v2.8.0 [INFO] [stderr] Checking xdr-rs-serialize v0.3.1 [INFO] [stderr] Compiling openssl v0.10.71 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling xdr-rs-serialize-derive v0.3.1 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling serde_derive v1.0.218 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking serde v1.0.218 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking h2 v0.4.8 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking ureq v2.12.1 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.12 [INFO] [stderr] Checking sodiumoxide v0.2.7 [INFO] [stderr] Checking stellar-base v0.6.0 [INFO] [stderr] Checking pi_rust v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | options: options, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | options: options, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `OfferLinks` is never constructed [INFO] [stdout] --> src/stellar_sdk/types/offer.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct OfferLinks { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:52:23 [INFO] [stdout] | [INFO] [stdout] 52 | let options = opts.unwrap_or_else(|| ServerOptions { [INFO] [stdout] | _______________________^ [INFO] [stdout] 53 | | allow_http: Some(false), [INFO] [stdout] 54 | | app_name: None, [INFO] [stdout] 55 | | app_version: None, [INFO] [stdout] 56 | | auth_token: None, [INFO] [stdout] 57 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 52 ~ let options = opts.unwrap_or(ServerOptions { [INFO] [stdout] 53 + allow_http: Some(false), [INFO] [stdout] 54 + app_name: None, [INFO] [stdout] 55 + app_version: None, [INFO] [stdout] 56 + auth_token: None, [INFO] [stdout] 57 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:196:33 [INFO] [stdout] | [INFO] [stdout] 196 | pub fn strict_receive_paths<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] 197 | &'a self, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 201 | ) -> StrictReceiveCallBuilder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 196 ~ pub fn strict_receive_paths( [INFO] [stdout] 197 ~ &self, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 249 | if !current_server_time.is_none() && is_retry == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_server_time.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `current_server_time` after checking its variant with `is_none` [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:252:27 [INFO] [stdout] | [INFO] [stdout] 249 | if !current_server_time.is_none() && is_retry == false { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 252 | max_time: current_server_time.unwrap() + seconds, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:249:46 [INFO] [stdout] | [INFO] [stdout] 249 | if !current_server_time.is_none() && is_retry == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `!is_retry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:254:19 [INFO] [stdout] | [INFO] [stdout] 254 | } else if is_retry == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `is_retry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `PublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:423:31 [INFO] [stdout] | [INFO] [stdout] 423 | .with_destination(destination.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `PublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:437:34 [INFO] [stdout] | [INFO] [stdout] 437 | Transaction::builder(source_keypair.public_key().clone(), sequence, MIN_BASE_FEE) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source_keypair.public_key()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:443:25 [INFO] [stdout] | [INFO] [stdout] 443 | let _ = tx.sign(&source_keypair.as_ref(), &Network::new_test()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `source_keypair.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:446:9 [INFO] [stdout] | [INFO] [stdout] 446 | assert_eq!(response.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 446 - assert_eq!(response.is_ok(), true); [INFO] [stdout] 446 + assert!(response.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `OfferLinks` is never constructed [INFO] [stdout] --> src/stellar_sdk/types/offer.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct OfferLinks { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/stellar_sdk/keypair.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 126 | / let stellar_base_keypair = SodiumKeyPair::from_secret_seed(&secret_key) [INFO] [stdout] 127 | | .expect("Failed to convert to generate stellar_base::KeyPair from the secret seed"); [INFO] [stdout] | |________________________________________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 128 | stellar_base_keypair [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 126 ~ [INFO] [stdout] 127 ~ SodiumKeyPair::from_secret_seed(&secret_key) [INFO] [stdout] 128 + .expect("Failed to convert to generate stellar_base::KeyPair from the secret seed") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/stellar_sdk/keypair.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 136 | / let stellar_sdk_keypair = Keypair::from_secret_key(&secret_key) [INFO] [stdout] 137 | | .expect("Failed to convert to generate stellar_sdk::Keypair from the secret seed"); [INFO] [stdout] | |_______________________________________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 138 | stellar_sdk_keypair [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 136 ~ [INFO] [stdout] 137 ~ Keypair::from_secret_key(&secret_key) [INFO] [stdout] 138 + .expect("Failed to convert to generate stellar_sdk::Keypair from the secret seed") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/stellar_sdk/keypair.rs:135:34 [INFO] [stdout] | [INFO] [stdout] 135 | let secret_key: String = secret_key_struct.secret_seed().into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `secret_key_struct.secret_seed()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/stellar_sdk/str_key.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / impl ToString for VersionBytes { [INFO] [stdout] 17 | | fn to_string(&self) -> String { [INFO] [stdout] 18 | | match self { [INFO] [stdout] 19 | | VersionBytes::Ed25519PublicKey => String::from("ed25519PublicKey"), [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/stellar_sdk/str_key.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | impl Into for VersionBytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 29 ~ impl From for u8 { [INFO] [stdout] 30 ~ fn from(val: VersionBytes) -> Self { [INFO] [stdout] 31 ~ match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `encode_check` doesn't need a mutable reference [INFO] [stdout] --> src/stellar_sdk/str_key.rs:249:13 [INFO] [stdout] | [INFO] [stdout] 249 | / &mut [ [INFO] [stdout] 250 | | 91u8, 49, 118, 218, 79, 232, 118, 216, 114, 82, 9, 175, 17, 217, 95, 50, 155, 52, [INFO] [stdout] 251 | | 15, 112, 137, 99, 101, 172, 40, 104, 207, 154, 154, 33, 113, 92, [INFO] [stdout] 252 | | ], [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 249 - &mut [ [INFO] [stdout] 249 + &[ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:52:23 [INFO] [stdout] | [INFO] [stdout] 52 | let options = opts.unwrap_or_else(|| ServerOptions { [INFO] [stdout] | _______________________^ [INFO] [stdout] 53 | | allow_http: Some(false), [INFO] [stdout] 54 | | app_name: None, [INFO] [stdout] 55 | | app_version: None, [INFO] [stdout] 56 | | auth_token: None, [INFO] [stdout] 57 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 52 ~ let options = opts.unwrap_or(ServerOptions { [INFO] [stdout] 53 + allow_http: Some(false), [INFO] [stdout] 54 + app_name: None, [INFO] [stdout] 55 + app_version: None, [INFO] [stdout] 56 + auth_token: None, [INFO] [stdout] 57 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:196:33 [INFO] [stdout] | [INFO] [stdout] 196 | pub fn strict_receive_paths<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] 197 | &'a self, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 201 | ) -> StrictReceiveCallBuilder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 196 ~ pub fn strict_receive_paths( [INFO] [stdout] 197 ~ &self, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 249 | if !current_server_time.is_none() && is_retry == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_server_time.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `current_server_time` after checking its variant with `is_none` [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:252:27 [INFO] [stdout] | [INFO] [stdout] 249 | if !current_server_time.is_none() && is_retry == false { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 252 | max_time: current_server_time.unwrap() + seconds, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:249:46 [INFO] [stdout] | [INFO] [stdout] 249 | if !current_server_time.is_none() && is_retry == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `!is_retry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:254:19 [INFO] [stdout] | [INFO] [stdout] 254 | } else if is_retry == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `is_retry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/stellar_sdk/types/asset.rs:71:1 [INFO] [stdout] | [INFO] [stdout] 71 | / impl ToString for Asset { [INFO] [stdout] 72 | | fn to_string(&self) -> String { [INFO] [stdout] 73 | | if self.2 { [INFO] [stdout] 74 | | return String::from("native"); [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/stellar_sdk/keypair.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 126 | / let stellar_base_keypair = SodiumKeyPair::from_secret_seed(&secret_key) [INFO] [stdout] 127 | | .expect("Failed to convert to generate stellar_base::KeyPair from the secret seed"); [INFO] [stdout] | |________________________________________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 128 | stellar_base_keypair [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 126 ~ [INFO] [stdout] 127 ~ SodiumKeyPair::from_secret_seed(&secret_key) [INFO] [stdout] 128 + .expect("Failed to convert to generate stellar_base::KeyPair from the secret seed") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/stellar_sdk/keypair.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 136 | / let stellar_sdk_keypair = Keypair::from_secret_key(&secret_key) [INFO] [stdout] 137 | | .expect("Failed to convert to generate stellar_sdk::Keypair from the secret seed"); [INFO] [stdout] | |_______________________________________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 138 | stellar_sdk_keypair [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 136 ~ [INFO] [stdout] 137 ~ Keypair::from_secret_key(&secret_key) [INFO] [stdout] 138 + .expect("Failed to convert to generate stellar_sdk::Keypair from the secret seed") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/stellar_sdk/keypair.rs:135:34 [INFO] [stdout] | [INFO] [stdout] 135 | let secret_key: String = secret_key_struct.secret_seed().into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `secret_key_struct.secret_seed()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/stellar_sdk/str_key.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / impl ToString for VersionBytes { [INFO] [stdout] 17 | | fn to_string(&self) -> String { [INFO] [stdout] 18 | | match self { [INFO] [stdout] 19 | | VersionBytes::Ed25519PublicKey => String::from("ed25519PublicKey"), [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/stellar_sdk/str_key.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | impl Into for VersionBytes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 29 ~ impl From for u8 { [INFO] [stdout] 30 ~ fn from(val: VersionBytes) -> Self { [INFO] [stdout] 31 ~ match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/stellar_sdk/types/asset.rs:71:1 [INFO] [stdout] | [INFO] [stdout] 71 | / impl ToString for Asset { [INFO] [stdout] 72 | | fn to_string(&self) -> String { [INFO] [stdout] 73 | | if self.2 { [INFO] [stdout] 74 | | return String::from("native"); [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/stellar_sdk/utils/direction.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / impl ToString for Direction { [INFO] [stdout] 8 | | fn to_string(&self) -> String { [INFO] [stdout] 9 | | match self { [INFO] [stdout] 10 | | Direction::Asc => String::from("asc"), [INFO] [stdout] ... | [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/stellar_sdk/utils/request.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn req(url: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ureq::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `response` after checking its variant with `is_ok` [INFO] [stdout] --> src/stellar_sdk/utils/request.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 14 | if response.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = response` [INFO] [stdout] 15 | let response_unwrapped = response.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:240:5 [INFO] [stdout] | [INFO] [stdout] 234 | / let client = Client::builder() [INFO] [stdout] 235 | | .default_headers(headers) [INFO] [stdout] 236 | | .timeout(std::time::Duration::from_secs(20)) [INFO] [stdout] 237 | | .build() [INFO] [stdout] 238 | | .unwrap(); [INFO] [stdout] | |__________________- unnecessary `let` binding [INFO] [stdout] 239 | [INFO] [stdout] 240 | client [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 234 ~ [INFO] [stdout] 235 | [INFO] [stdout] 236 ~ Client::builder() [INFO] [stdout] 237 + .default_headers(headers) [INFO] [stdout] 238 + .timeout(std::time::Duration::from_secs(20)) [INFO] [stdout] 239 + .build() [INFO] [stdout] 240 + .unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | / return Ok(PiNetwork { [INFO] [stdout] 271 | | api_key, [INFO] [stdout] 272 | | my_key_pair, [INFO] [stdout] 273 | | network_passphrase, [INFO] [stdout] 274 | | current_payment: None, [INFO] [stdout] 275 | | reqwest_options: options, [INFO] [stdout] 276 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 ~ Ok(PiNetwork { [INFO] [stdout] 271 + api_key, [INFO] [stdout] 272 + my_key_pair, [INFO] [stdout] 273 + network_passphrase, [INFO] [stdout] 274 + current_payment: None, [INFO] [stdout] 275 + reqwest_options: options, [INFO] [stdout] 276 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:278:23 [INFO] [stdout] | [INFO] [stdout] 278 | Err(e) => return Err(PiError::Message(format!("{:?}", e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 278 - Err(e) => return Err(PiError::Message(format!("{:?}", e))), [INFO] [stdout] 278 + Err(e) => Err(PiError::Message(format!("{:?}", e))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:326:26 [INFO] [stdout] | [INFO] [stdout] 326 | let amount = payment.amount.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `payment.amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:525:9 [INFO] [stdout] | [INFO] [stdout] 521 | / let server_url = match network { [INFO] [stdout] 522 | | NetworkPassphrase::PiNetwork => "Pi Network".to_string(), [INFO] [stdout] 523 | | NetworkPassphrase::PiTestnet => "Pi Testnet".to_string(), [INFO] [stdout] 524 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 525 | server_url [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 521 ~ [INFO] [stdout] 522 ~ match network { [INFO] [stdout] 523 + NetworkPassphrase::PiNetwork => "Pi Network".to_string(), [INFO] [stdout] 524 + NetworkPassphrase::PiTestnet => "Pi Testnet".to_string(), [INFO] [stdout] 525 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `PublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:570:50 [INFO] [stdout] | [INFO] [stdout] 570 | let source_account_muxed: MuxedAccount = source_account_public_key.clone().into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source_account_public_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:586:13 [INFO] [stdout] | [INFO] [stdout] 586 | &source_account_keypair.as_ref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `source_account_keypair.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn accounts(&self) -> AccountCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 86 | pub fn accounts(&self) -> AccountCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn transactions(&self) -> TransactionCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 100 | pub fn transactions(&self) -> TransactionCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:114:20 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn ledgers(&self) -> LedgerCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 114 | pub fn ledgers(&self) -> LedgerCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:128:19 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn offers(&self) -> OfferCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 128 | pub fn offers(&self) -> OfferCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:142:23 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn operations(&self) -> OperationCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 142 | pub fn operations(&self) -> OperationCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:159:28 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn liquidity_pools(&self) -> LiquidityPoolCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 159 | pub fn liquidity_pools(&self) -> LiquidityPoolCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:179:31 [INFO] [stdout] | [INFO] [stdout] 179 | pub fn claimable_balances(&self) -> ClaimableBalanceCallbuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 179 | pub fn claimable_balances(&self) -> ClaimableBalanceCallbuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:188:10 [INFO] [stdout] | [INFO] [stdout] 184 | &'a self, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 185 | base: &'a Asset, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 186 | counter: &'a Asset, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 187 | resolution: &'a str, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 188 | ) -> TradeAggregationCallBuilder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 188 | ) -> TradeAggregationCallBuilder<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:192:24 [INFO] [stdout] | [INFO] [stdout] 192 | pub fn order_books(&self, selling: Asset, buying: Asset) -> OrderBookCallBuilder { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 192 | pub fn order_books(&self, selling: Asset, buying: Asset) -> OrderBookCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:201:10 [INFO] [stdout] | [INFO] [stdout] 197 | &'a self, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] ... [INFO] [stdout] 201 | ) -> StrictReceiveCallBuilder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 201 | ) -> StrictReceiveCallBuilder<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:210:10 [INFO] [stdout] | [INFO] [stdout] 206 | &'a self, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 207 | destination: &StrictPathSource, [INFO] [stdout] 208 | source_asset: &'a Asset, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 209 | source_amount: &'a str, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 210 | ) -> StrictSendCallBuilder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 210 | ) -> StrictSendCallBuilder<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:214:19 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn trades(&self) -> TradeCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 214 | pub fn trades(&self) -> TradeCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:218:21 [INFO] [stdout] | [INFO] [stdout] 218 | pub fn payments(&self) -> PaymentCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 218 | pub fn payments(&self) -> PaymentCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:222:19 [INFO] [stdout] | [INFO] [stdout] 222 | pub fn assets(&self) -> AssetCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 222 | pub fn assets(&self) -> AssetCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 284 | pub fn effects(&self) -> EffectCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 284 | pub fn effects(&self) -> EffectCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/stellar_sdk/utils/direction.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / impl ToString for Direction { [INFO] [stdout] 8 | | fn to_string(&self) -> String { [INFO] [stdout] 9 | | match self { [INFO] [stdout] 10 | | Direction::Asc => String::from("asc"), [INFO] [stdout] ... | [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/stellar_sdk/utils/request.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn req(url: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ureq::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `response` after checking its variant with `is_ok` [INFO] [stdout] --> src/stellar_sdk/utils/request.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 14 | if response.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = response` [INFO] [stdout] 15 | let response_unwrapped = response.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:240:5 [INFO] [stdout] | [INFO] [stdout] 234 | / let client = Client::builder() [INFO] [stdout] 235 | | .default_headers(headers) [INFO] [stdout] 236 | | .timeout(std::time::Duration::from_secs(20)) [INFO] [stdout] 237 | | .build() [INFO] [stdout] 238 | | .unwrap(); [INFO] [stdout] | |__________________- unnecessary `let` binding [INFO] [stdout] 239 | [INFO] [stdout] 240 | client [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 234 ~ [INFO] [stdout] 235 | [INFO] [stdout] 236 ~ Client::builder() [INFO] [stdout] 237 + .default_headers(headers) [INFO] [stdout] 238 + .timeout(std::time::Duration::from_secs(20)) [INFO] [stdout] 239 + .build() [INFO] [stdout] 240 + .unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | / return Ok(PiNetwork { [INFO] [stdout] 271 | | api_key, [INFO] [stdout] 272 | | my_key_pair, [INFO] [stdout] 273 | | network_passphrase, [INFO] [stdout] 274 | | current_payment: None, [INFO] [stdout] 275 | | reqwest_options: options, [INFO] [stdout] 276 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 ~ Ok(PiNetwork { [INFO] [stdout] 271 + api_key, [INFO] [stdout] 272 + my_key_pair, [INFO] [stdout] 273 + network_passphrase, [INFO] [stdout] 274 + current_payment: None, [INFO] [stdout] 275 + reqwest_options: options, [INFO] [stdout] 276 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:278:23 [INFO] [stdout] | [INFO] [stdout] 278 | Err(e) => return Err(PiError::Message(format!("{:?}", e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 278 - Err(e) => return Err(PiError::Message(format!("{:?}", e))), [INFO] [stdout] 278 + Err(e) => Err(PiError::Message(format!("{:?}", e))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:326:26 [INFO] [stdout] | [INFO] [stdout] 326 | let amount = payment.amount.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `payment.amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:525:9 [INFO] [stdout] | [INFO] [stdout] 521 | / let server_url = match network { [INFO] [stdout] 522 | | NetworkPassphrase::PiNetwork => "Pi Network".to_string(), [INFO] [stdout] 523 | | NetworkPassphrase::PiTestnet => "Pi Testnet".to_string(), [INFO] [stdout] 524 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 525 | server_url [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 521 ~ [INFO] [stdout] 522 ~ match network { [INFO] [stdout] 523 + NetworkPassphrase::PiNetwork => "Pi Network".to_string(), [INFO] [stdout] 524 + NetworkPassphrase::PiTestnet => "Pi Testnet".to_string(), [INFO] [stdout] 525 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `PublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:570:50 [INFO] [stdout] | [INFO] [stdout] 570 | let source_account_muxed: MuxedAccount = source_account_public_key.clone().into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source_account_public_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:586:13 [INFO] [stdout] | [INFO] [stdout] 586 | &source_account_keypair.as_ref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `source_account_keypair.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn accounts(&self) -> AccountCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 86 | pub fn accounts(&self) -> AccountCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn transactions(&self) -> TransactionCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 100 | pub fn transactions(&self) -> TransactionCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:114:20 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn ledgers(&self) -> LedgerCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 114 | pub fn ledgers(&self) -> LedgerCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:128:19 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn offers(&self) -> OfferCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 128 | pub fn offers(&self) -> OfferCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:142:23 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn operations(&self) -> OperationCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 142 | pub fn operations(&self) -> OperationCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:159:28 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn liquidity_pools(&self) -> LiquidityPoolCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 159 | pub fn liquidity_pools(&self) -> LiquidityPoolCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:179:31 [INFO] [stdout] | [INFO] [stdout] 179 | pub fn claimable_balances(&self) -> ClaimableBalanceCallbuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 179 | pub fn claimable_balances(&self) -> ClaimableBalanceCallbuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:188:10 [INFO] [stdout] | [INFO] [stdout] 184 | &'a self, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 185 | base: &'a Asset, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 186 | counter: &'a Asset, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 187 | resolution: &'a str, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 188 | ) -> TradeAggregationCallBuilder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 188 | ) -> TradeAggregationCallBuilder<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:192:24 [INFO] [stdout] | [INFO] [stdout] 192 | pub fn order_books(&self, selling: Asset, buying: Asset) -> OrderBookCallBuilder { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 192 | pub fn order_books(&self, selling: Asset, buying: Asset) -> OrderBookCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:201:10 [INFO] [stdout] | [INFO] [stdout] 197 | &'a self, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] ... [INFO] [stdout] 201 | ) -> StrictReceiveCallBuilder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 201 | ) -> StrictReceiveCallBuilder<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:210:10 [INFO] [stdout] | [INFO] [stdout] 206 | &'a self, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 207 | destination: &StrictPathSource, [INFO] [stdout] 208 | source_asset: &'a Asset, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 209 | source_amount: &'a str, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 210 | ) -> StrictSendCallBuilder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 210 | ) -> StrictSendCallBuilder<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:214:19 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn trades(&self) -> TradeCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 214 | pub fn trades(&self) -> TradeCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:218:21 [INFO] [stdout] | [INFO] [stdout] 218 | pub fn payments(&self) -> PaymentCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 218 | pub fn payments(&self) -> PaymentCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:222:19 [INFO] [stdout] | [INFO] [stdout] 222 | pub fn assets(&self) -> AssetCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 222 | pub fn assets(&self) -> AssetCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stellar_sdk/endpoints/server.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 284 | pub fn effects(&self) -> EffectCallBuilder { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 284 | pub fn effects(&self) -> EffectCallBuilder<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/test.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | assert_eq!(true, result_ok.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 79 - assert_eq!(true, result_ok.is_ok()); [INFO] [stdout] 79 + assert!(result_ok.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/test.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | assert_eq!(true, result_err_not_s.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 80 - assert_eq!(true, result_err_not_s.is_err()); [INFO] [stdout] 80 + assert!(result_err_not_s.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/test.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | assert_eq!(true, result_err_too_long.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 81 - assert_eq!(true, result_err_too_long.is_err()); [INFO] [stdout] 81 + assert!(result_err_too_long.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/test.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | assert_eq!(true, result_err_too_short.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 82 - assert_eq!(true, result_err_too_short.is_err()); [INFO] [stdout] 82 + assert!(result_err_too_short.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 36s [INFO] running `Command { std: "docker" "inspect" "6b3b45e1e742c0beacdf7743b353af2a4968ba328eb1105a37ace52b25c0f16e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b3b45e1e742c0beacdf7743b353af2a4968ba328eb1105a37ace52b25c0f16e", kill_on_drop: false }` [INFO] [stdout] 6b3b45e1e742c0beacdf7743b353af2a4968ba328eb1105a37ace52b25c0f16e