[INFO] fetching crate phylodm 3.2.0... [INFO] linting phylodm-3.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate phylodm 3.2.0 into /workspace/builds/worker-2-tc1/source [INFO] removed /workspace/builds/worker-2-tc1/source/.cargo/config.toml [INFO] started tweaking crates.io crate phylodm 3.2.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate phylodm 3.2.0 [INFO] tweaked toml for crates.io crate phylodm 3.2.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate phylodm 3.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate phylodm 3.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded getopt v1.1.7 [INFO] [stderr] Downloaded pyo3-macros-backend v0.21.2 [INFO] [stderr] Downloaded random_color v0.8.0 [INFO] [stderr] Downloaded pyo3-macros v0.21.2 [INFO] [stderr] Downloaded pyo3-build-config v0.21.2 [INFO] [stderr] Downloaded pyo3-ffi v0.21.2 [INFO] [stderr] Downloaded numpy v0.21.0 [INFO] [stderr] Downloaded pyo3 v0.21.2 [INFO] [stderr] Downloaded light_phylogeny v2.4.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c1b882cd5e9db27451a67679f2a67bd7db949ee8e5fbfe3fad7ecb71e08183e [INFO] running `Command { std: "docker" "start" "-a" "2c1b882cd5e9db27451a67679f2a67bd7db949ee8e5fbfe3fad7ecb71e08183e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c1b882cd5e9db27451a67679f2a67bd7db949ee8e5fbfe3fad7ecb71e08183e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c1b882cd5e9db27451a67679f2a67bd7db949ee8e5fbfe3fad7ecb71e08183e", kill_on_drop: false }` [INFO] [stdout] 2c1b882cd5e9db27451a67679f2a67bd7db949ee8e5fbfe3fad7ecb71e08183e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb06aaccb7bd5a64a0a990f16cf8c86fae172b5e81cfce228a2255b2b839692d [INFO] running `Command { std: "docker" "start" "-a" "bb06aaccb7bd5a64a0a990f16cf8c86fae172b5e81cfce228a2255b2b839692d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.87 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking getopt v1.1.7 [INFO] [stderr] Checking roxmltree v0.19.0 [INFO] [stderr] Checking svg v0.15.1 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking regex v1.11.0 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking random_color v0.8.0 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking light_phylogeny v2.4.1 [INFO] [stderr] Checking phylodm v3.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary use of `get(&depth).is_none()` [INFO] [stdout] --> src/pdm.rs:82:32 [INFO] [stdout] | [INFO] [stdout] 82 | if self.nodes_at_depth.get(&depth).is_none() { [INFO] [stdout] | --------------------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.nodes_at_depth.contains_key(&depth)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pdm.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | return Ok(self.nodes.last().unwrap().id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return Ok(self.nodes.last().unwrap().id); [INFO] [stdout] 130 + Ok(self.nodes.last().unwrap().id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pdm.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | return self.nodes.last().unwrap().id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return self.nodes.last().unwrap().id; [INFO] [stdout] 137 + self.nodes.last().unwrap().id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/pdm.rs:260:18 [INFO] [stdout] | [INFO] [stdout] 260 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&NodeDepth(0)).is_none()` [INFO] [stdout] --> src/pdm.rs:270:27 [INFO] [stdout] | [INFO] [stdout] 270 | if nodes_at_depth.get(&NodeDepth(0)).is_none() { [INFO] [stdout] | ---------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!nodes_at_depth.contains_key(&NodeDepth(0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&depth).is_none()` [INFO] [stdout] --> src/pdm.rs:82:32 [INFO] [stdout] | [INFO] [stdout] 82 | if self.nodes_at_depth.get(&depth).is_none() { [INFO] [stdout] | --------------------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.nodes_at_depth.contains_key(&depth)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `child_node.desc_distances` after checking its variant with `is_some` [INFO] [stdout] --> src/pdm.rs:311:25 [INFO] [stdout] | [INFO] [stdout] 309 | if child_node.desc_distances.is_some() { [INFO] [stdout] | -------------------------------------- help: try: `if let Some() = &child_node.desc_distances` [INFO] [stdout] 310 | let mut new_desc_distances = [INFO] [stdout] 311 | child_node.desc_distances.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pdm.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | return Ok(self.nodes.last().unwrap().id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return Ok(self.nodes.last().unwrap().id); [INFO] [stdout] 130 + Ok(self.nodes.last().unwrap().id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pdm.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | return self.nodes.last().unwrap().id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return self.nodes.last().unwrap().id; [INFO] [stdout] 137 + self.nodes.last().unwrap().id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `children_idxs` [INFO] [stdout] --> src/pdm.rs:385:22 [INFO] [stdout] | [INFO] [stdout] 385 | for j in 0..i { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 385 - for j in 0..i { [INFO] [stdout] 385 + for in children_idxs.iter().take(i) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/pdm.rs:260:18 [INFO] [stdout] | [INFO] [stdout] 260 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&NodeDepth(0)).is_none()` [INFO] [stdout] --> src/pdm.rs:270:27 [INFO] [stdout] | [INFO] [stdout] 270 | if nodes_at_depth.get(&NodeDepth(0)).is_none() { [INFO] [stdout] | ---------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!nodes_at_depth.contains_key(&NodeDepth(0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cur_node.parent` after checking its variant with `is_some` [INFO] [stdout] --> src/pdm.rs:487:35 [INFO] [stdout] | [INFO] [stdout] 486 | if cur_node.parent.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = cur_node.parent` [INFO] [stdout] 487 | let parent_node = cur_node.parent.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `child_node.desc_distances` after checking its variant with `is_some` [INFO] [stdout] --> src/pdm.rs:311:25 [INFO] [stdout] | [INFO] [stdout] 309 | if child_node.desc_distances.is_some() { [INFO] [stdout] | -------------------------------------- help: try: `if let Some() = &child_node.desc_distances` [INFO] [stdout] 310 | let mut new_desc_distances = [INFO] [stdout] 311 | child_node.desc_distances.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pdm.rs:540:13 [INFO] [stdout] | [INFO] [stdout] 540 | !self.row_vec.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.row_vec.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pdm.rs:547:9 [INFO] [stdout] | [INFO] [stdout] 547 | return if norm { dist / self.length().0 } else { dist }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 547 - return if norm { dist / self.length().0 } else { dist }; [INFO] [stdout] 547 + if norm { dist / self.length().0 } else { dist } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pdm.rs:556:13 [INFO] [stdout] | [INFO] [stdout] 556 | !self.row_vec.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.row_vec.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `leaf.taxon` after checking its variant with `is_some` [INFO] [stdout] --> src/pdm.rs:574:26 [INFO] [stdout] | [INFO] [stdout] 573 | if leaf.taxon.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &leaf.taxon` [INFO] [stdout] 574 | out.push(leaf.taxon.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `children_idxs` [INFO] [stdout] --> src/pdm.rs:385:22 [INFO] [stdout] | [INFO] [stdout] 385 | for j in 0..i { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 385 - for j in 0..i { [INFO] [stdout] 385 + for in children_idxs.iter().take(i) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cur_node.parent` after checking its variant with `is_some` [INFO] [stdout] --> src/pdm.rs:487:35 [INFO] [stdout] | [INFO] [stdout] 486 | if cur_node.parent.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = cur_node.parent` [INFO] [stdout] 487 | let parent_node = cur_node.parent.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pdm.rs:540:13 [INFO] [stdout] | [INFO] [stdout] 540 | !self.row_vec.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.row_vec.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pdm.rs:547:9 [INFO] [stdout] | [INFO] [stdout] 547 | return if norm { dist / self.length().0 } else { dist }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 547 - return if norm { dist / self.length().0 } else { dist }; [INFO] [stdout] 547 + if norm { dist / self.length().0 } else { dist } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pdm.rs:556:13 [INFO] [stdout] | [INFO] [stdout] 556 | !self.row_vec.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.row_vec.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `leaf.taxon` after checking its variant with `is_some` [INFO] [stdout] --> src/pdm.rs:574:26 [INFO] [stdout] | [INFO] [stdout] 573 | if leaf.taxon.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &leaf.taxon` [INFO] [stdout] 574 | out.push(leaf.taxon.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.77s [INFO] running `Command { std: "docker" "inspect" "bb06aaccb7bd5a64a0a990f16cf8c86fae172b5e81cfce228a2255b2b839692d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb06aaccb7bd5a64a0a990f16cf8c86fae172b5e81cfce228a2255b2b839692d", kill_on_drop: false }` [INFO] [stdout] bb06aaccb7bd5a64a0a990f16cf8c86fae172b5e81cfce228a2255b2b839692d