[INFO] fetching crate phone 0.1.2... [INFO] linting phone-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate phone 0.1.2 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate phone 0.1.2 [INFO] finished tweaking crates.io crate phone 0.1.2 [INFO] tweaked toml for crates.io crate phone 0.1.2 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate phone 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 65c0e01a7a19fe3b9f48256fa982192674782c865f8c76151d204f3f4fdf6e9f [INFO] running `Command { std: "docker" "start" "-a" "65c0e01a7a19fe3b9f48256fa982192674782c865f8c76151d204f3f4fdf6e9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "65c0e01a7a19fe3b9f48256fa982192674782c865f8c76151d204f3f4fdf6e9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65c0e01a7a19fe3b9f48256fa982192674782c865f8c76151d204f3f4fdf6e9f", kill_on_drop: false }` [INFO] [stdout] 65c0e01a7a19fe3b9f48256fa982192674782c865f8c76151d204f3f4fdf6e9f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a73d316098c73aee698dbe0a415d060e8fc252019e31cc567a096dc40db9d465 [INFO] running `Command { std: "docker" "start" "-a" "a73d316098c73aee698dbe0a415d060e8fc252019e31cc567a096dc40db9d465", kill_on_drop: false }` [INFO] [stderr] Checking phone v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | if i < &48 && i !=&43 || i > &57 && i != &43{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 7 - if i < &48 && i !=&43 || i > &57 && i != &43{ [INFO] [stdout] 7 + if !(i == &43 || i >= &48 && i <= &57){ [INFO] [stdout] | [INFO] [stdout] 7 - if i < &48 && i !=&43 || i > &57 && i != &43{ [INFO] [stdout] 7 + if (i > &57 || i < &48) && i !=&43{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | / if pos != None{ [INFO] [stdout] 15 | | if count > 1 || pos.unwrap() != 0{ [INFO] [stdout] 16 | | return false; [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 14 ~ if pos != None [INFO] [stdout] 15 ~ && (count > 1 || pos.unwrap() != 0){ [INFO] [stdout] 16 | return false; [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/lib.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | if pos != None{ [INFO] [stdout] | ^^^^^^^^^^^ help: use `Option::is_some()` instead: `pos.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | if i < &48 && i !=&43 || i > &57 && i != &43{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 7 - if i < &48 && i !=&43 || i > &57 && i != &43{ [INFO] [stdout] 7 + if !(i == &43 || i >= &48 && i <= &57){ [INFO] [stdout] | [INFO] [stdout] 7 - if i < &48 && i !=&43 || i > &57 && i != &43{ [INFO] [stdout] 7 + if (i > &57 || i < &48) && i !=&43{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | / if pos != None{ [INFO] [stdout] 15 | | if count > 1 || pos.unwrap() != 0{ [INFO] [stdout] 16 | | return false; [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 14 ~ if pos != None [INFO] [stdout] 15 ~ && (count > 1 || pos.unwrap() != 0){ [INFO] [stdout] 16 | return false; [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/lib.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | if pos != None{ [INFO] [stdout] | ^^^^^^^^^^^ help: use `Option::is_some()` instead: `pos.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.15s [INFO] running `Command { std: "docker" "inspect" "a73d316098c73aee698dbe0a415d060e8fc252019e31cc567a096dc40db9d465", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a73d316098c73aee698dbe0a415d060e8fc252019e31cc567a096dc40db9d465", kill_on_drop: false }` [INFO] [stdout] a73d316098c73aee698dbe0a415d060e8fc252019e31cc567a096dc40db9d465