[INFO] fetching crate pgwire 0.38.0... [INFO] linting pgwire-0.38.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pgwire 0.38.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate pgwire 0.38.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate pgwire 0.38.0 [INFO] tweaked toml for crates.io crate pgwire 0.38.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pgwire 0.38.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate pgwire 0.38.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lazy-regex v3.5.1 [INFO] [stderr] Downloaded x509-certificate v0.25.0 [INFO] [stderr] Downloaded bcder v0.7.6 [INFO] [stderr] Downloaded lazy-regex-proc_macros v3.5.1 [INFO] [stderr] Downloaded smol_str v0.3.5 [INFO] [stderr] Downloaded derive_utils v0.11.2 [INFO] [stderr] Downloaded iter-enum v1.2.0 [INFO] [stderr] Downloaded gluesql-macros v0.19.0 [INFO] [stderr] Downloaded gluesql v0.19.0 [INFO] [stderr] Downloaded gluesql-utils v0.19.0 [INFO] [stderr] Downloaded jsonwebtoken v10.2.0 [INFO] [stderr] Downloaded postgis v0.9.0 [INFO] [stderr] Downloaded pg_interval_2 v0.5.2 [INFO] [stderr] Downloaded find-crate v0.6.3 [INFO] [stderr] Downloaded futures-enum v0.1.17 [INFO] [stderr] Downloaded gluesql_memory_storage v0.19.0 [INFO] [stderr] Downloaded aws-lc-rs v1.15.3 [INFO] [stderr] Downloaded sqlparser v0.52.0 [INFO] [stderr] Downloaded gluesql-core v0.19.0 [INFO] [stderr] Downloaded aws-lc-sys v0.36.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3cc953641e22c64a6f268ae21c9f4ca3d273f58a1eb6e6c7fdbec19211f5c936 [INFO] running `Command { std: "docker" "start" "-a" "3cc953641e22c64a6f268ae21c9f4ca3d273f58a1eb6e6c7fdbec19211f5c936", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3cc953641e22c64a6f268ae21c9f4ca3d273f58a1eb6e6c7fdbec19211f5c936", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3cc953641e22c64a6f268ae21c9f4ca3d273f58a1eb6e6c7fdbec19211f5c936", kill_on_drop: false }` [INFO] [stdout] 3cc953641e22c64a6f268ae21c9f4ca3d273f58a1eb6e6c7fdbec19211f5c936 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 14b53272aee7d22d4d61548c68e4100a83046ceb1c4bf9a46bf70e0b56c4c4c2 [INFO] running `Command { std: "docker" "start" "-a" "14b53272aee7d22d4d61548c68e4100a83046ceb1c4bf9a46bf70e0b56c4c4c2", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling zeroize_derive v1.4.3 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling aws-lc-sys v0.36.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling zmij v1.0.16 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Compiling aws-lc-rs v1.15.3 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking unicode-properties v0.1.4 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Checking postgres-protocol v0.6.10 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling bigdecimal v0.4.10 [INFO] [stderr] Compiling rust_decimal v1.40.0 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Compiling im v15.1.0 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Compiling find-crate v0.6.3 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking postgres-types v0.2.12 [INFO] [stderr] Compiling derive_utils v0.15.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking rand_core v0.10.0 [INFO] [stderr] Compiling getrandom v0.4.1 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Compiling time-core v0.1.7 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Compiling time-macros v0.2.25 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling libsqlite3-sys v0.36.0 [INFO] [stderr] Compiling iter-enum v1.2.0 [INFO] [stderr] Compiling derive_utils v0.11.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking sqlparser v0.52.0 [INFO] [stderr] Checking gluesql-utils v0.19.0 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking pem v3.0.6 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking siphasher v1.0.1 [INFO] [stderr] Checking cpufeatures v0.3.0 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking time v0.3.45 [INFO] [stderr] Checking chacha20 v0.10.0 [INFO] [stderr] Compiling futures-enum v0.1.17 [INFO] [stderr] Checking phf_shared v0.12.1 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.5.1 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking bcder v0.7.6 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking regex-lite v0.1.8 [INFO] [stderr] Compiling chrono-tz v0.10.4 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking lazy-regex v3.5.1 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking num-bigint-dig v0.8.6 [INFO] [stderr] Compiling gluesql-macros v0.19.0 [INFO] [stderr] Checking simple_asn1 v0.6.3 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking rand v0.10.0 [INFO] [stderr] Checking phf v0.12.1 [INFO] [stderr] Checking pg_interval_2 v0.5.2 [INFO] [stderr] Checking x509-certificate v0.25.0 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking hashlink v0.11.0 [INFO] [stderr] Compiling derive-new v0.7.0 [INFO] [stderr] Checking md5 v0.8.0 [INFO] [stderr] Checking smol_str v0.3.5 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking rsa v0.9.10 [INFO] [stderr] Checking rusqlite v0.38.0 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking jsonwebtoken v10.2.0 [INFO] [stderr] Checking gluesql-core v0.19.0 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking pgwire v0.38.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking reqwest v0.13.1 [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/api/results.rs:511:25 [INFO] [stdout] | [INFO] [stdout] 511 | b if byte == delimiter.as_bytes()[0] => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/types/from_sql_text.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | / if input.eq_ignore_ascii_case(b"true") || input.eq_ignore_ascii_case(b"t") { [INFO] [stdout] 60 | | return Ok(true); [INFO] [stdout] 61 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 58 ~ b't' [INFO] [stdout] 59 ~ if (input.eq_ignore_ascii_case(b"true") || input.eq_ignore_ascii_case(b"t")) => { [INFO] [stdout] 60 | return Ok(true); [INFO] [stdout] 61 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/types/from_sql_text.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | / if input.eq_ignore_ascii_case(b"false") || input.eq_ignore_ascii_case(b"f") { [INFO] [stdout] 65 | | return Ok(false); [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ b'f' [INFO] [stdout] 64 ~ if (input.eq_ignore_ascii_case(b"false") || input.eq_ignore_ascii_case(b"f")) => { [INFO] [stdout] 65 | return Ok(false); [INFO] [stdout] 66 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/types/from_sql_text.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | / if input.eq_ignore_ascii_case(b"yes") || input.eq_ignore_ascii_case(b"y") { [INFO] [stdout] 72 | | return Ok(true); [INFO] [stdout] 73 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 70 ~ b'y' [INFO] [stdout] 71 ~ if (input.eq_ignore_ascii_case(b"yes") || input.eq_ignore_ascii_case(b"y")) => { [INFO] [stdout] 72 | return Ok(true); [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/types/from_sql_text.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | / if input.eq_ignore_ascii_case(b"no") || input.eq_ignore_ascii_case(b"n") { [INFO] [stdout] 77 | | return Ok(false); [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 75 ~ b'n' [INFO] [stdout] 76 ~ if (input.eq_ignore_ascii_case(b"no") || input.eq_ignore_ascii_case(b"n")) => { [INFO] [stdout] 77 | return Ok(false); [INFO] [stdout] 78 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/types/from_sql_text.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | / if len == 1 { [INFO] [stdout] 96 | | return Ok(true); [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 94 ~ b'1' [INFO] [stdout] 95 ~ if len == 1 => { [INFO] [stdout] 96 | return Ok(true); [INFO] [stdout] 97 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/types/from_sql_text.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | / if len == 1 { [INFO] [stdout] 101 | | return Ok(false); [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 99 ~ b'0' [INFO] [stdout] 100 ~ if len == 1 => { [INFO] [stdout] 101 | return Ok(false); [INFO] [stdout] 102 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking gluesql_memory_storage v0.19.0 [INFO] [stderr] Checking gluesql v0.19.0 [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/api/results.rs:511:25 [INFO] [stdout] | [INFO] [stdout] 511 | b if byte == delimiter.as_bytes()[0] => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/format/date_style.rs:291:9 [INFO] [stdout] | [INFO] [stdout] 291 | format_option.date_style = "ISO".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { date_style: "ISO".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/format/date_style.rs:290:9 [INFO] [stdout] | [INFO] [stdout] 290 | let mut format_option = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/format/date_style.rs:341:9 [INFO] [stdout] | [INFO] [stdout] 341 | format_options.date_style = "SQL, DMY".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { date_style: "SQL, DMY".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/format/date_style.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | let mut format_options = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/format/date_style.rs:381:9 [INFO] [stdout] | [INFO] [stdout] 381 | format_options.date_style = "german".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { date_style: "german".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/format/date_style.rs:380:9 [INFO] [stdout] | [INFO] [stdout] 380 | let mut format_options = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/format/date_style.rs:400:9 [INFO] [stdout] | [INFO] [stdout] 400 | format_options.date_style = "postgres, DMY".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { date_style: "postgres, DMY".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/format/date_style.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | let mut format_options = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/format/date_style.rs:418:9 [INFO] [stdout] | [INFO] [stdout] 418 | format_options.date_style = "ISO".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { date_style: "ISO".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/format/date_style.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 417 | let mut format_options = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/format/date_style.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 435 | format_options.date_style = "postgres".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { date_style: "postgres".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/format/date_style.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 434 | let mut format_options = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/format/date_style.rs:454:9 [INFO] [stdout] | [INFO] [stdout] 454 | format_options.date_style = "postgres, DMY".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { date_style: "postgres, DMY".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/format/date_style.rs:453:9 [INFO] [stdout] | [INFO] [stdout] 453 | let mut format_options = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/format/interval_style.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | format_options.interval_style = "postgres_verbose".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { interval_style: "postgres_verbose".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/format/interval_style.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | let mut format_options = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/types/from_sql_text.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | / if input.eq_ignore_ascii_case(b"true") || input.eq_ignore_ascii_case(b"t") { [INFO] [stdout] 60 | | return Ok(true); [INFO] [stdout] 61 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 58 ~ b't' [INFO] [stdout] 59 ~ if (input.eq_ignore_ascii_case(b"true") || input.eq_ignore_ascii_case(b"t")) => { [INFO] [stdout] 60 | return Ok(true); [INFO] [stdout] 61 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/types/from_sql_text.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | / if input.eq_ignore_ascii_case(b"false") || input.eq_ignore_ascii_case(b"f") { [INFO] [stdout] 65 | | return Ok(false); [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ b'f' [INFO] [stdout] 64 ~ if (input.eq_ignore_ascii_case(b"false") || input.eq_ignore_ascii_case(b"f")) => { [INFO] [stdout] 65 | return Ok(false); [INFO] [stdout] 66 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/types/from_sql_text.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | / if input.eq_ignore_ascii_case(b"yes") || input.eq_ignore_ascii_case(b"y") { [INFO] [stdout] 72 | | return Ok(true); [INFO] [stdout] 73 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 70 ~ b'y' [INFO] [stdout] 71 ~ if (input.eq_ignore_ascii_case(b"yes") || input.eq_ignore_ascii_case(b"y")) => { [INFO] [stdout] 72 | return Ok(true); [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/types/from_sql_text.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | / if input.eq_ignore_ascii_case(b"no") || input.eq_ignore_ascii_case(b"n") { [INFO] [stdout] 77 | | return Ok(false); [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 75 ~ b'n' [INFO] [stdout] 76 ~ if (input.eq_ignore_ascii_case(b"no") || input.eq_ignore_ascii_case(b"n")) => { [INFO] [stdout] 77 | return Ok(false); [INFO] [stdout] 78 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/types/from_sql_text.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | / if len == 1 { [INFO] [stdout] 96 | | return Ok(true); [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 94 ~ b'1' [INFO] [stdout] 95 ~ if len == 1 => { [INFO] [stdout] 96 | return Ok(true); [INFO] [stdout] 97 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/types/from_sql_text.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | / if len == 1 { [INFO] [stdout] 101 | | return Ok(false); [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 99 ~ b'0' [INFO] [stdout] 100 ~ if len == 1 => { [INFO] [stdout] 101 | return Ok(false); [INFO] [stdout] 102 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: approximate value of `f{32, 64}::consts::PI` found [INFO] [stdout] --> src/types/mod.rs:133:37 [INFO] [stdout] | [INFO] [stdout] 133 | test_roundtrip_float!(f32, -3.14, &Type::FLOAT4); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the constant directly [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stdout] = note: `#[deny(clippy::approx_constant)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: approximate value of `f{32, 64}::consts::PI` found [INFO] [stdout] --> src/types/mod.rs:137:37 [INFO] [stdout] | [INFO] [stdout] 137 | test_roundtrip_float!(f64, -3.14159265359, &Type::FLOAT8); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the constant directly [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/mod.rs:526:9 [INFO] [stdout] | [INFO] [stdout] 526 | format_options.interval_style = "iso_8601".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { interval_style: "iso_8601".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/mod.rs:525:9 [INFO] [stdout] | [INFO] [stdout] 525 | let mut format_options = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/mod.rs:589:9 [INFO] [stdout] | [INFO] [stdout] 589 | format_options.interval_style = "postgres_verbose".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { interval_style: "postgres_verbose".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/mod.rs:588:9 [INFO] [stdout] | [INFO] [stdout] 588 | let mut format_options = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/mod.rs:710:9 [INFO] [stdout] | [INFO] [stdout] 710 | format_options.interval_style = "iso_8601".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { interval_style: "iso_8601".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/mod.rs:709:9 [INFO] [stdout] | [INFO] [stdout] 709 | let mut format_options = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/mod.rs:738:9 [INFO] [stdout] | [INFO] [stdout] 738 | format_options.interval_style = "postgres_verbose".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { interval_style: "postgres_verbose".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/mod.rs:737:9 [INFO] [stdout] | [INFO] [stdout] 737 | let mut format_options = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/types/mod.rs:770:9 [INFO] [stdout] | [INFO] [stdout] 770 | format_options.interval_style = "postgres".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `types::format::FormatOptions { interval_style: "postgres".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/types/mod.rs:767:9 [INFO] [stdout] | [INFO] [stdout] 767 | let mut format_options = FormatOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pgwire` (lib test) due to 2 previous errors; 20 warnings emitted [INFO] running `Command { std: "docker" "inspect" "14b53272aee7d22d4d61548c68e4100a83046ceb1c4bf9a46bf70e0b56c4c4c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14b53272aee7d22d4d61548c68e4100a83046ceb1c4bf9a46bf70e0b56c4c4c2", kill_on_drop: false }` [INFO] [stdout] 14b53272aee7d22d4d61548c68e4100a83046ceb1c4bf9a46bf70e0b56c4c4c2