[INFO] fetching crate pgmt 0.4.5... [INFO] linting pgmt-0.4.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pgmt 0.4.5 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate pgmt 0.4.5 [INFO] finished tweaking crates.io crate pgmt 0.4.5 [INFO] tweaked toml for crates.io crate pgmt 0.4.5 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pgmt 0.4.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate pgmt 0.4.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded expectrl v0.7.1 [INFO] [stderr] Downloaded conpty v0.5.1 [INFO] [stderr] Downloaded ptyprocess v0.4.1 [INFO] [stderr] Downloaded bollard v0.20.1 [INFO] [stderr] Downloaded bollard-stubs v1.52.1-rc.29.1.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c7e58a886c2db2cac414f5a5d3c06e5ba35010c72e074125b5e3ded24413c13 [INFO] running `Command { std: "docker" "start" "-a" "8c7e58a886c2db2cac414f5a5d3c06e5ba35010c72e074125b5e3ded24413c13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c7e58a886c2db2cac414f5a5d3c06e5ba35010c72e074125b5e3ded24413c13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c7e58a886c2db2cac414f5a5d3c06e5ba35010c72e074125b5e3ded24413c13", kill_on_drop: false }` [INFO] [stdout] 8c7e58a886c2db2cac414f5a5d3c06e5ba35010c72e074125b5e3ded24413c13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ee34763beda6b6e0cafd4614b4275cb100c92ad7a560f6435cf6b9a69152df1c [INFO] running `Command { std: "docker" "start" "-a" "ee34763beda6b6e0cafd4614b4275cb100c92ad7a560f6435cf6b9a69152df1c", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.116 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling pin-project-lite v0.2.16 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Compiling futures-util v0.3.32 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling futures-channel v0.3.32 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking webpki-roots v1.0.6 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Compiling whoami v1.6.1 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking rustix v1.1.3 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling toml_parser v1.0.9+spec-1.1.0 [INFO] [stderr] Compiling chrono v0.4.43 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling anyhow v1.0.101 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Compiling regex-syntax v0.8.9 [INFO] [stderr] Compiling rstest_macros v0.26.1 [INFO] [stderr] Checking fixedbitset v0.5.7 [INFO] [stderr] Checking clap_builder v4.5.58 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Checking predicates-core v1.0.10 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking ring v0.17.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking getrandom v0.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Compiling tokio v1.49.0 [INFO] [stderr] Checking tempfile v3.25.0 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking console v0.16.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking shell-words v1.1.1 [INFO] [stderr] Checking uuid v1.21.0 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking petgraph v0.8.3 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Checking md5 v0.8.0 [INFO] [stderr] Compiling assert_cmd v2.1.2 [INFO] [stderr] Checking dialoguer v0.12.0 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking predicates-tree v1.0.13 [INFO] [stderr] Checking predicates v3.1.4 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking insta v1.46.3 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling yoke v0.8.1 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Compiling zerovec v0.11.5 [INFO] [stderr] Compiling zerotrie v0.2.3 [INFO] [stderr] Checking clap v4.5.58 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling tokio-stream v0.1.18 [INFO] [stderr] Checking ptyprocess v0.4.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking expectrl v0.7.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking bollard-stubs v1.52.1-rc.29.1.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Compiling parking_lot v0.12.5 [INFO] [stderr] Compiling icu_normalizer v2.1.1 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking rstest v0.26.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling sqlx-core v0.8.6 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Compiling sqlx-postgres v0.8.6 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking hyperlocal v0.9.1 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking bollard v0.20.1 [INFO] [stderr] Checking pgmt v0.4.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/baseline.rs:168:5 [INFO] [stdout] | [INFO] [stdout] 168 | baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 168 - baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 168 + baselines.sort_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/baseline.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 229 - baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 229 + baselines.sort_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/init/import/database.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 198 | schema_info.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 198 - schema_info.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 198 + schema_info.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `port.public_port` after checking its variant with `is_some` [INFO] [stdout] --> src/docker/mod.rs:637:35 [INFO] [stdout] | [INFO] [stdout] 633 | if port.private_port == 5432 && port.public_port.is_some() { [INFO] [stdout] | -------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 637 | port: port.public_port.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/baseline.rs:168:5 [INFO] [stdout] | [INFO] [stdout] 168 | baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 168 - baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 168 + baselines.sort_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/baseline.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 229 - baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 229 + baselines.sort_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/init/import/database.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 198 | schema_info.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 198 - schema_info.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 198 + schema_info.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `port.public_port` after checking its variant with `is_some` [INFO] [stdout] --> src/docker/mod.rs:637:35 [INFO] [stdout] | [INFO] [stdout] 633 | if port.private_port == 5432 && port.public_port.is_some() { [INFO] [stdout] | -------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 637 | port: port.public_port.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/baseline.rs:168:5 [INFO] [stdout] | [INFO] [stdout] 168 | baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 168 - baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 168 + baselines.sort_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/baseline.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 229 - baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 229 + baselines.sort_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/init/import/database.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 198 | schema_info.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 198 - schema_info.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 198 + schema_info.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/baseline.rs:168:5 [INFO] [stdout] | [INFO] [stdout] 168 | baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 168 - baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 168 + baselines.sort_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/baseline.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 229 - baselines.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 229 + baselines.sort_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/init/import/database.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 198 | schema_info.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 198 - schema_info.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 198 + schema_info.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `port.public_port` after checking its variant with `is_some` [INFO] [stdout] --> src/docker/mod.rs:637:35 [INFO] [stdout] | [INFO] [stdout] 633 | if port.private_port == 5432 && port.public_port.is_some() { [INFO] [stdout] | -------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 637 | port: port.public_port.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `port.public_port` after checking its variant with `is_some` [INFO] [stdout] --> src/docker/mod.rs:637:35 [INFO] [stdout] | [INFO] [stdout] 633 | if port.private_port == 5432 && port.public_port.is_some() { [INFO] [stdout] | -------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 637 | port: port.public_port.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 44s [INFO] running `Command { std: "docker" "inspect" "ee34763beda6b6e0cafd4614b4275cb100c92ad7a560f6435cf6b9a69152df1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee34763beda6b6e0cafd4614b4275cb100c92ad7a560f6435cf6b9a69152df1c", kill_on_drop: false }` [INFO] [stdout] ee34763beda6b6e0cafd4614b4275cb100c92ad7a560f6435cf6b9a69152df1c