[INFO] fetching crate pg_interval_2 0.5.2... [INFO] linting pg_interval_2-0.5.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pg_interval_2 0.5.2 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate pg_interval_2 0.5.2 [INFO] finished tweaking crates.io crate pg_interval_2 0.5.2 [INFO] tweaked toml for crates.io crate pg_interval_2 0.5.2 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pg_interval_2 0.5.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate pg_interval_2 0.5.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e667e6e9d9342c9c200707583d28f8eb04b5377780139b39c1137f7addce9ae [INFO] running `Command { std: "docker" "start" "-a" "6e667e6e9d9342c9c200707583d28f8eb04b5377780139b39c1137f7addce9ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e667e6e9d9342c9c200707583d28f8eb04b5377780139b39c1137f7addce9ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e667e6e9d9342c9c200707583d28f8eb04b5377780139b39c1137f7addce9ae", kill_on_drop: false }` [INFO] [stdout] 6e667e6e9d9342c9c200707583d28f8eb04b5377780139b39c1137f7addce9ae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 14b4137f87bc341700a874257bbe281201c7a5eaf137d6e35179ae2011a3dcc0 [INFO] running `Command { std: "docker" "start" "-a" "14b4137f87bc341700a874257bbe281201c7a5eaf137d6e35179ae2011a3dcc0", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy v0.8.33 [INFO] [stderr] Checking unicode-properties v0.1.4 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking postgres-protocol v0.6.10 [INFO] [stderr] Checking postgres-types v0.2.12 [INFO] [stderr] Checking pg_interval_2 v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/integrations/duration.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | new_dur = new_dur - Duration::hours(hours); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_dur -= Duration::hours(hours)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/integrations/duration.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | new_dur = new_dur - Duration::minutes(minutes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_dur -= Duration::minutes(minutes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/integrations/duration.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | if days > (i32::max_value() as i64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 19 - if days > (i32::max_value() as i64) { [INFO] [stdout] 19 + if days > (i32::MAX as i64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/integrations/duration.rs:20:41 [INFO] [stdout] | [INFO] [stdout] 20 | let overflow_days = days - (i32::max_value() as i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 20 - let overflow_days = days - (i32::max_value() as i64); [INFO] [stdout] 20 + let overflow_days = days - (i32::MAX as i64); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/iso_8601.rs:46:32 [INFO] [stdout] | [INFO] [stdout] 46 | year_interval.push_str(&*day_interval); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `&day_interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/iso_8601.rs:47:32 [INFO] [stdout] | [INFO] [stdout] 47 | year_interval.push_str(&*time_interval); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `&time_interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/postgres.rs:65:40 [INFO] [stdout] | [INFO] [stdout] 65 | year_interval.push_str(&*format!("{} {} ", self.years, get_year_suffix(self.years))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!("{} {} ", self.years, get_year_suffix(self.years))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/postgres.rs:68:40 [INFO] [stdout] | [INFO] [stdout] 68 | year_interval.push_str(&*format!( [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 69 | | "{} {} ", [INFO] [stdout] 70 | | self.months, [INFO] [stdout] 71 | | get_mon_suffix(self.months) [INFO] [stdout] 72 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 ~ year_interval.push_str(&format!( [INFO] [stdout] 69 + "{} {} ", [INFO] [stdout] 70 + self.months, [INFO] [stdout] 71 + get_mon_suffix(self.months) [INFO] [stdout] 72 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/postgres.rs:75:32 [INFO] [stdout] | [INFO] [stdout] 75 | year_interval.push_str(&*day_interval); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `&day_interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/postgres.rs:76:32 [INFO] [stdout] | [INFO] [stdout] 76 | year_interval.push_str(&*time_interval); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `&time_interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/postgres.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | / &*(sign [INFO] [stdout] 91 | | + &hours [INFO] [stdout] 92 | | + ":" [INFO] [stdout] 93 | | + &super::pad_i64(self.minutes) [INFO] [stdout] 94 | | + ":" [INFO] [stdout] 95 | | + &super::pad_i64(self.seconds)), [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 90 ~ &(sign [INFO] [stdout] 91 + + &hours [INFO] [stdout] 92 + + ":" [INFO] [stdout] 93 + + &super::pad_i64(self.minutes) [INFO] [stdout] 94 + + ":" [INFO] [stdout] 95 ~ + &super::pad_i64(self.seconds)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/postgres.rs:98:40 [INFO] [stdout] | [INFO] [stdout] 98 | time_interval.push_str(&*format!(".{:06}", super::safe_abs_u64(self.microseconds))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!(".{:06}", super::safe_abs_u64(self.microseconds))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interval_fmt/sql.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | !(has_negative && has_positive) && !(has_year_month && has_day_time); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(has_negative && has_positive || has_year_month && has_day_time)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/interval_fmt/mod.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | let max = i64::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 10 - let max = i64::max_value(); [INFO] [stdout] 10 + let max = i64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i64::abs()` to u64 [INFO] [stdout] --> src/interval_fmt/mod.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | num.abs() as u64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `num.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/interval_fmt/mod.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 25 | let max = i32::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 25 - let max = i32::max_value(); [INFO] [stdout] 25 + let max = i32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i32::abs()` to u32 [INFO] [stdout] --> src/interval_fmt/mod.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | num.abs() as u32 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `num.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interval_fmt/mod.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return format!("{:02}", num); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return format!("{:02}", num); [INFO] [stdout] 44 + format!("{:02}", num) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/interval_norm.rs:13:6 [INFO] [stdout] | [INFO] [stdout] 13 | impl<'a> From<&'a Interval> for IntervalNorm { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 13 - impl<'a> From<&'a Interval> for IntervalNorm { [INFO] [stdout] 13 + impl From<&Interval> for IntervalNorm { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/interval_parse/iso_8601.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | if iso_str.rfind('P').map_or(false, |v| v == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use a standard comparison instead [INFO] [stdout] | [INFO] [stdout] 20 - if iso_str.rfind('P').map_or(false, |v| v == 1) { [INFO] [stdout] 20 + if iso_str.rfind('P') == Some(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/interval_parse/iso_8601.rs:107:8 [INFO] [stdout] | [INFO] [stdout] 107 | if val.is_digit(10) || is_first_char || is_period_char { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `val.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/interval_parse/iso_8601.rs:119:20 [INFO] [stdout] | [INFO] [stdout] 119 | if parse_num > i32::max_value() as f64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 119 - if parse_num > i32::max_value() as f64 { [INFO] [stdout] 119 + if parse_num > i32::MAX as f64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/interval_parse/postgres.rs:270:18 [INFO] [stdout] | [INFO] [stdout] 270 | fn consume_token<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 274 | delim_list: &mut Vec<&'a str>, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 270 ~ fn consume_token( [INFO] [stdout] 271 | interval: &mut IntervalNorm, [INFO] [stdout] 272 | val: f64, [INFO] [stdout] 273 | delim: String, [INFO] [stdout] 274 ~ delim_list: &mut Vec<&str>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/integrations/duration.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | new_dur = new_dur - Duration::hours(hours); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_dur -= Duration::hours(hours)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/integrations/duration.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | new_dur = new_dur - Duration::minutes(minutes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_dur -= Duration::minutes(minutes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/integrations/duration.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | if days > (i32::max_value() as i64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 19 - if days > (i32::max_value() as i64) { [INFO] [stdout] 19 + if days > (i32::MAX as i64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/integrations/duration.rs:20:41 [INFO] [stdout] | [INFO] [stdout] 20 | let overflow_days = days - (i32::max_value() as i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 20 - let overflow_days = days - (i32::max_value() as i64); [INFO] [stdout] 20 + let overflow_days = days - (i32::MAX as i64); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/iso_8601.rs:46:32 [INFO] [stdout] | [INFO] [stdout] 46 | year_interval.push_str(&*day_interval); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `&day_interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/iso_8601.rs:47:32 [INFO] [stdout] | [INFO] [stdout] 47 | year_interval.push_str(&*time_interval); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `&time_interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/postgres.rs:65:40 [INFO] [stdout] | [INFO] [stdout] 65 | year_interval.push_str(&*format!("{} {} ", self.years, get_year_suffix(self.years))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!("{} {} ", self.years, get_year_suffix(self.years))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/postgres.rs:68:40 [INFO] [stdout] | [INFO] [stdout] 68 | year_interval.push_str(&*format!( [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 69 | | "{} {} ", [INFO] [stdout] 70 | | self.months, [INFO] [stdout] 71 | | get_mon_suffix(self.months) [INFO] [stdout] 72 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 ~ year_interval.push_str(&format!( [INFO] [stdout] 69 + "{} {} ", [INFO] [stdout] 70 + self.months, [INFO] [stdout] 71 + get_mon_suffix(self.months) [INFO] [stdout] 72 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/postgres.rs:75:32 [INFO] [stdout] | [INFO] [stdout] 75 | year_interval.push_str(&*day_interval); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `&day_interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/postgres.rs:76:32 [INFO] [stdout] | [INFO] [stdout] 76 | year_interval.push_str(&*time_interval); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `&time_interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/postgres.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | / &*(sign [INFO] [stdout] 91 | | + &hours [INFO] [stdout] 92 | | + ":" [INFO] [stdout] 93 | | + &super::pad_i64(self.minutes) [INFO] [stdout] 94 | | + ":" [INFO] [stdout] 95 | | + &super::pad_i64(self.seconds)), [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 90 ~ &(sign [INFO] [stdout] 91 + + &hours [INFO] [stdout] 92 + + ":" [INFO] [stdout] 93 + + &super::pad_i64(self.minutes) [INFO] [stdout] 94 + + ":" [INFO] [stdout] 95 ~ + &super::pad_i64(self.seconds)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/interval_fmt/postgres.rs:98:40 [INFO] [stdout] | [INFO] [stdout] 98 | time_interval.push_str(&*format!(".{:06}", super::safe_abs_u64(self.microseconds))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!(".{:06}", super::safe_abs_u64(self.microseconds))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interval_fmt/sql.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | !(has_negative && has_positive) && !(has_year_month && has_day_time); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(has_negative && has_positive || has_year_month && has_day_time)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/interval_fmt/mod.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | let max = i64::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 10 - let max = i64::max_value(); [INFO] [stdout] 10 + let max = i64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i64::abs()` to u64 [INFO] [stdout] --> src/interval_fmt/mod.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | num.abs() as u64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `num.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/interval_fmt/mod.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 25 | let max = i32::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 25 - let max = i32::max_value(); [INFO] [stdout] 25 + let max = i32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i32::abs()` to u32 [INFO] [stdout] --> src/interval_fmt/mod.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | num.abs() as u32 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `num.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interval_fmt/mod.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return format!("{:02}", num); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return format!("{:02}", num); [INFO] [stdout] 44 + format!("{:02}", num) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/interval_fmt/mod.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | let min = i32::min_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 53 - let min = i32::min_value(); [INFO] [stdout] 53 + let min = i32::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/interval_fmt/mod.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 61 | let min = i64::min_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 61 - let min = i64::min_value(); [INFO] [stdout] 61 + let min = i64::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/interval_norm.rs:13:6 [INFO] [stdout] | [INFO] [stdout] 13 | impl<'a> From<&'a Interval> for IntervalNorm { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 13 - impl<'a> From<&'a Interval> for IntervalNorm { [INFO] [stdout] 13 + impl From<&Interval> for IntervalNorm { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/interval_parse/iso_8601.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | if iso_str.rfind('P').map_or(false, |v| v == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use a standard comparison instead [INFO] [stdout] | [INFO] [stdout] 20 - if iso_str.rfind('P').map_or(false, |v| v == 1) { [INFO] [stdout] 20 + if iso_str.rfind('P') == Some(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/interval_parse/iso_8601.rs:107:8 [INFO] [stdout] | [INFO] [stdout] 107 | if val.is_digit(10) || is_first_char || is_period_char { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `val.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/interval_parse/iso_8601.rs:119:20 [INFO] [stdout] | [INFO] [stdout] 119 | if parse_num > i32::max_value() as f64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 119 - if parse_num > i32::max_value() as f64 { [INFO] [stdout] 119 + if parse_num > i32::MAX as f64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/interval_parse/iso_8601.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 260 | assert_eq!(interval.is_err(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 260 - assert_eq!(interval.is_err(), true); [INFO] [stdout] 260 + assert!(interval.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/interval_parse/iso_8601.rs:266:9 [INFO] [stdout] | [INFO] [stdout] 266 | assert_eq!(interval.is_err(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 266 - assert_eq!(interval.is_err(), true); [INFO] [stdout] 266 + assert!(interval.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/interval_parse/iso_8601.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | assert_eq!(interval.is_err(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 272 - assert_eq!(interval.is_err(), true); [INFO] [stdout] 272 + assert!(interval.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/interval_parse/postgres.rs:270:18 [INFO] [stdout] | [INFO] [stdout] 270 | fn consume_token<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 274 | delim_list: &mut Vec<&'a str>, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 270 ~ fn consume_token( [INFO] [stdout] 271 | interval: &mut IntervalNorm, [INFO] [stdout] 272 | val: f64, [INFO] [stdout] 273 | delim: String, [INFO] [stdout] 274 ~ delim_list: &mut Vec<&str>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/interval_parse/postgres.rs:509:9 [INFO] [stdout] | [INFO] [stdout] 509 | assert_eq!(interval.is_err(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 509 - assert_eq!(interval.is_err(), true); [INFO] [stdout] 509 + assert!(interval.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/interval_parse/postgres.rs:515:9 [INFO] [stdout] | [INFO] [stdout] 515 | assert_eq!(interval.is_err(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 515 - assert_eq!(interval.is_err(), true); [INFO] [stdout] 515 + assert!(interval.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/interval_parse/postgres.rs:521:9 [INFO] [stdout] | [INFO] [stdout] 521 | assert_eq!(interval.is_err(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 521 - assert_eq!(interval.is_err(), true); [INFO] [stdout] 521 + assert!(interval.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/interval_parse/postgres.rs:548:9 [INFO] [stdout] | [INFO] [stdout] 548 | assert_eq!(interval.is_err(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 548 - assert_eq!(interval.is_err(), true); [INFO] [stdout] 548 + assert!(interval.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/interval_parse/postgres.rs:1020:9 [INFO] [stdout] | [INFO] [stdout] 1020 | assert_eq!(interval.is_err(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1020 - assert_eq!(interval.is_err(), true); [INFO] [stdout] 1020 + assert!(interval.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Interval` which implements the `Copy` trait [INFO] [stdout] --> src/pg_interval.rs:64:29 [INFO] [stdout] | [INFO] [stdout] 64 | let test_interval = interval.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/pg_interval_add.rs:99:42 [INFO] [stdout] | [INFO] [stdout] 99 | let interval_add = Interval::new(i32::max_value(), 1, 12); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 99 - let interval_add = Interval::new(i32::max_value(), 1, 12); [INFO] [stdout] 99 + let interval_add = Interval::new(i32::MAX, 1, 12); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/pg_interval_add.rs:113:42 [INFO] [stdout] | [INFO] [stdout] 113 | let interval = Interval::new(13, i32::max_value(), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 113 - let interval = Interval::new(13, i32::max_value(), 0); [INFO] [stdout] 113 + let interval = Interval::new(13, i32::MAX, 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/pg_interval_add.rs:135:54 [INFO] [stdout] | [INFO] [stdout] 135 | let result = interval.checked_add_year_month(i32::max_value(), 32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 135 - let result = interval.checked_add_year_month(i32::max_value(), 32); [INFO] [stdout] 135 + let result = interval.checked_add_year_month(i32::MAX, 32); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/pg_interval_sub.rs:107:42 [INFO] [stdout] | [INFO] [stdout] 107 | let interval = Interval::new(13, i32::min_value(), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 107 - let interval = Interval::new(13, i32::min_value(), 0); [INFO] [stdout] 107 + let interval = Interval::new(13, i32::MIN, 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/pg_interval_sub.rs:131:54 [INFO] [stdout] | [INFO] [stdout] 131 | let result = interval.checked_sub_year_month(i32::min_value(), 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 131 - let result = interval.checked_sub_year_month(i32::min_value(), 1); [INFO] [stdout] 131 + let result = interval.checked_sub_year_month(i32::MIN, 1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/pg_interval_sub.rs:154:42 [INFO] [stdout] | [INFO] [stdout] 154 | let interval_sub = Interval::new(i32::max_value(), 0, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 154 - let interval_sub = Interval::new(i32::max_value(), 0, 0); [INFO] [stdout] 154 + let interval_sub = Interval::new(i32::MAX, 0, 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.05s [INFO] running `Command { std: "docker" "inspect" "14b4137f87bc341700a874257bbe281201c7a5eaf137d6e35179ae2011a3dcc0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14b4137f87bc341700a874257bbe281201c7a5eaf137d6e35179ae2011a3dcc0", kill_on_drop: false }` [INFO] [stdout] 14b4137f87bc341700a874257bbe281201c7a5eaf137d6e35179ae2011a3dcc0