[INFO] fetching crate pg2parquet 0.2.2... [INFO] linting pg2parquet-0.2.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pg2parquet 0.2.2 into /workspace/builds/worker-1-tc1/source [INFO] removed /workspace/builds/worker-1-tc1/source/.cargo/config.toml [INFO] started tweaking crates.io crate pg2parquet 0.2.2 [INFO] finished tweaking crates.io crate pg2parquet 0.2.2 [INFO] tweaked toml for crates.io crate pg2parquet 0.2.2 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pg2parquet 0.2.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate pg2parquet 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tinyvec v1.8.1 [INFO] [stderr] Downloaded cpufeatures v0.2.16 [INFO] [stderr] Downloaded rtoolbox v0.0.2 [INFO] [stderr] Downloaded integer-encoding v3.0.4 [INFO] [stderr] Downloaded roff v0.2.2 [INFO] [stderr] Downloaded clap_mangen v0.2.29 [INFO] [stderr] Downloaded seq-macro v0.3.5 [INFO] [stderr] Downloaded clap_complete_nushell v4.5.8 [INFO] [stderr] Downloaded clap_complete v4.5.58 [INFO] [stderr] Downloaded bigdecimal v0.4.7 [INFO] [stderr] Downloaded flate2 v1.0.35 [INFO] [stderr] Downloaded libm v0.2.11 [INFO] [stderr] Downloaded cc v1.2.10 [INFO] [stderr] Downloaded clap v4.5.26 [INFO] [stderr] Downloaded clap_builder v4.5.26 [INFO] [stderr] Downloaded brotli-decompressor v4.0.1 [INFO] [stderr] Downloaded serde_json v1.0.135 [INFO] [stderr] Downloaded thrift v0.17.0 [INFO] [stderr] Downloaded chrono v0.4.39 [INFO] [stderr] Downloaded rustc-serialize v0.3.25 [INFO] [stderr] Downloaded geo-types v0.7.15 [INFO] [stderr] Downloaded crc32fast v1.4.2 [INFO] [stderr] Downloaded rustix v0.38.43 [INFO] [stderr] Downloaded lz4_flex v0.11.3 [INFO] [stderr] Downloaded bigdecimal v0.3.1 [INFO] [stderr] Downloaded async-trait v0.1.85 [INFO] [stderr] Downloaded whoami v1.5.2 [INFO] [stderr] Downloaded unicode-properties v0.1.3 [INFO] [stderr] Downloaded uuid v1.12.0 [INFO] [stderr] Downloaded zstd-safe v7.2.1 [INFO] [stderr] Downloaded zstd v0.13.2 [INFO] [stderr] Downloaded postgres v0.19.9 [INFO] [stderr] Downloaded jobserver v0.1.32 [INFO] [stderr] Downloaded postgres-types v0.2.8 [INFO] [stderr] Downloaded tokio-postgres v0.7.12 [INFO] [stderr] Downloaded postgres-protocol v0.6.7 [INFO] [stderr] Downloaded jemallocator v0.5.4 [INFO] [stderr] Downloaded postgres-native-tls v0.5.0 [INFO] [stderr] Downloaded rpassword v7.3.1 [INFO] [stderr] Downloaded ordered-float v2.10.1 [INFO] [stderr] Downloaded num v0.4.3 [INFO] [stderr] Downloaded pg_bigdecimal v0.1.5 [INFO] [stderr] Downloaded parquet v54.2.1 [INFO] [stderr] Downloaded pgvector v0.4.0 [INFO] [stderr] Downloaded jemalloc-sys v0.5.4+5.3.0-patched [INFO] [stderr] Downloaded eui48 v1.1.0 [INFO] [stderr] Downloaded zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Downloaded brotli v7.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 92d29cb6c9a410dc9f3e8f87d3ad70e1911c6148e01a00aacf3f70c42e7376d6 [INFO] running `Command { std: "docker" "start" "-a" "92d29cb6c9a410dc9f3e8f87d3ad70e1911c6148e01a00aacf3f70c42e7376d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "92d29cb6c9a410dc9f3e8f87d3ad70e1911c6148e01a00aacf3f70c42e7376d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92d29cb6c9a410dc9f3e8f87d3ad70e1911c6148e01a00aacf3f70c42e7376d6", kill_on_drop: false }` [INFO] [stdout] 92d29cb6c9a410dc9f3e8f87d3ad70e1911c6148e01a00aacf3f70c42e7376d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 429f03b4d85e0c07c12938fa723981347cd68ff9dab07210e6f7a481a7b4ddce [INFO] running `Command { std: "docker" "start" "-a" "429f03b4d85e0c07c12938fa723981347cd68ff9dab07210e6f7a481a7b4ddce", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking bytes v1.9.0 [INFO] [stderr] Checking tinyvec v1.8.1 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking unicode-properties v0.1.3 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Compiling serde_json v1.0.135 [INFO] [stderr] Checking unicode-bidi v0.3.18 [INFO] [stderr] Checking cpufeatures v0.2.16 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking itoa v1.0.14 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking log v0.4.25 [INFO] [stderr] Checking siphasher v1.0.1 [INFO] [stderr] Checking uuid v1.12.0 [INFO] [stderr] Compiling openssl v0.10.68 [INFO] [stderr] Checking whoami v1.5.2 [INFO] [stderr] Checking phf_shared v0.11.3 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking bitflags v2.8.0 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Compiling syn v2.0.96 [INFO] [stderr] Compiling cc v1.2.10 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking miniz_oxide v0.8.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Compiling bigdecimal v0.4.7 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking geo-types v0.7.15 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Checking clap_builder v4.5.26 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking thrift v0.17.0 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking rtoolbox v0.0.2 [INFO] [stderr] Compiling seq-macro v0.3.5 [INFO] [stderr] Checking rpassword v7.3.1 [INFO] [stderr] Checking brotli v7.0.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling openssl-sys v0.9.104 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling jemalloc-sys v0.5.4+5.3.0-patched [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking bigdecimal v0.3.1 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling async-trait v0.1.85 [INFO] [stderr] Compiling clap_derive v4.5.24 [INFO] [stderr] Checking eui48 v1.1.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap v4.5.26 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking parquet v54.2.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking postgres-protocol v0.6.7 [INFO] [stderr] Checking postgres-types v0.2.8 [INFO] [stderr] Checking pgvector v0.4.0 [INFO] [stderr] Checking tokio-postgres v0.7.12 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking postgres v0.19.9 [INFO] [stderr] Checking postgres-native-tls v0.5.0 [INFO] [stderr] Checking pg_bigdecimal v0.1.5 [INFO] [stderr] Checking jemallocator v0.5.4 [INFO] [stderr] Checking pg2parquet v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/parquetinfo.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use parquet; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/parquetinfo.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use parquet; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgresutils.rs:12:6 [INFO] [stdout] | [INFO] [stdout] 12 | / match row.get::>(i) { [INFO] [stdout] 13 | | Some(v) => [INFO] [stdout] 14 | | return format!("{}={:?}", column.name(), v), [INFO] [stdout] 15 | | None => () [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(v) = row.get::>(i) { return format!("{}={:?}", column.name(), v) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgresutils.rs:19:6 [INFO] [stdout] | [INFO] [stdout] 19 | / match row.get::>(i) { [INFO] [stdout] 20 | | Some(v) => [INFO] [stdout] 21 | | return format!("{}={:?}", column.name(), v), [INFO] [stdout] 22 | | None => () [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(v) = row.get::>(i) { return format!("{}={:?}", column.name(), v) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgresutils.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 26 | / match row.get::>(i) { [INFO] [stdout] 27 | | Some(v) => [INFO] [stdout] 28 | | return format!("{}={:?}", column.name(), v), [INFO] [stdout] 29 | | None => () [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(v) = row.get::>(i) { return format!("{}={:?}", column.name(), v) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgresutils.rs:33:6 [INFO] [stdout] | [INFO] [stdout] 33 | / match row.get::>(i) { [INFO] [stdout] 34 | | Some(v) => [INFO] [stdout] 35 | | return format!("{}={:?}", column.name(), v), [INFO] [stdout] 36 | | None => () [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(v) = row.get::>(i) { return format!("{}={:?}", column.name(), v) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgresutils.rs:40:6 [INFO] [stdout] | [INFO] [stdout] 40 | / match row.get::>(i) { [INFO] [stdout] 41 | | Some(v) => [INFO] [stdout] 42 | | return format!("{}={:?}", column.name(), v), [INFO] [stdout] 43 | | None => () [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(v) = row.get::>(i) { return format!("{}={:?}", column.name(), v) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/myfrom.rs:93:6 [INFO] [stdout] | [INFO] [stdout] 93 | impl<'a> MyFrom for ByteArray { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/myfrom.rs:99:6 [INFO] [stdout] | [INFO] [stdout] 99 | impl<'a> MyFrom for ByteArray { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/myfrom.rs:105:6 [INFO] [stdout] | [INFO] [stdout] 105 | impl<'a> MyFrom for FixedLenByteArray { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/myfrom.rs:111:6 [INFO] [stdout] | [INFO] [stdout] 111 | impl<'a> MyFrom for i64 { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/myfrom.rs:118:6 [INFO] [stdout] | [INFO] [stdout] 118 | impl<'a> MyFrom for ByteArray { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/myfrom.rs:124:6 [INFO] [stdout] | [INFO] [stdout] 124 | impl<'a> MyFrom for ByteArray { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/level_index.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | parent: Some(&self) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/level_index.rs:113:3 [INFO] [stdout] | [INFO] [stdout] 113 | return self.indexes.len() as i16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return self.indexes.len() as i16; [INFO] [stdout] 113 + self.indexes.len() as i16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parquetinfo.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 111 | f.write_str(&s) [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parquetinfo.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 117 | f.write_str(&s) [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgresutils.rs:12:6 [INFO] [stdout] | [INFO] [stdout] 12 | / match row.get::>(i) { [INFO] [stdout] 13 | | Some(v) => [INFO] [stdout] 14 | | return format!("{}={:?}", column.name(), v), [INFO] [stdout] 15 | | None => () [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(v) = row.get::>(i) { return format!("{}={:?}", column.name(), v) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/parquetinfo.rs:129:3 [INFO] [stdout] | [INFO] [stdout] 129 | / match lt { [INFO] [stdout] 130 | | _ => { [INFO] [stdout] 131 | | write!(f, "{:x?}", self.data()) [INFO] [stdout] 132 | | } [INFO] [stdout] 133 | | } [INFO] [stdout] | |_________^ help: consider using the match body instead: `write!(f, "{:x?}", self.data())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgresutils.rs:19:6 [INFO] [stdout] | [INFO] [stdout] 19 | / match row.get::>(i) { [INFO] [stdout] 20 | | Some(v) => [INFO] [stdout] 21 | | return format!("{}={:?}", column.name(), v), [INFO] [stdout] 22 | | None => () [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(v) = row.get::>(i) { return format!("{}={:?}", column.name(), v) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgresutils.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 26 | / match row.get::>(i) { [INFO] [stdout] 27 | | Some(v) => [INFO] [stdout] 28 | | return format!("{}={:?}", column.name(), v), [INFO] [stdout] 29 | | None => () [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(v) = row.get::>(i) { return format!("{}={:?}", column.name(), v) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgresutils.rs:33:6 [INFO] [stdout] | [INFO] [stdout] 33 | / match row.get::>(i) { [INFO] [stdout] 34 | | Some(v) => [INFO] [stdout] 35 | | return format!("{}={:?}", column.name(), v), [INFO] [stdout] 36 | | None => () [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(v) = row.get::>(i) { return format!("{}={:?}", column.name(), v) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgresutils.rs:40:6 [INFO] [stdout] | [INFO] [stdout] 40 | / match row.get::>(i) { [INFO] [stdout] 41 | | Some(v) => [INFO] [stdout] 42 | | return format!("{}={:?}", column.name(), v), [INFO] [stdout] 43 | | None => () [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(v) = row.get::>(i) { return format!("{}={:?}", column.name(), v) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/playground.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 16 | let file = fs::File::create(&file_path).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/parquet_writer.rs:1:92 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{borrow::Cow, cell::RefCell, fmt::Display, io::Write, mem, os, rc::Rc, sync::Arc, usize}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/myfrom.rs:93:6 [INFO] [stdout] | [INFO] [stdout] 93 | impl<'a> MyFrom for ByteArray { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/myfrom.rs:99:6 [INFO] [stdout] | [INFO] [stdout] 99 | impl<'a> MyFrom for ByteArray { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/myfrom.rs:105:6 [INFO] [stdout] | [INFO] [stdout] 105 | impl<'a> MyFrom for FixedLenByteArray { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/myfrom.rs:111:6 [INFO] [stdout] | [INFO] [stdout] 111 | impl<'a> MyFrom for i64 { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/myfrom.rs:118:6 [INFO] [stdout] | [INFO] [stdout] 118 | impl<'a> MyFrom for ByteArray { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/myfrom.rs:124:6 [INFO] [stdout] | [INFO] [stdout] 124 | impl<'a> MyFrom for ByteArray { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/parquet_writer.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | if !self.quiet && self.stats.rows % 256 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.stats.rows.is_multiple_of(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/level_index.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | parent: Some(&self) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/parquet_writer.rs:111:37 [INFO] [stdout] | [INFO] [stdout] 111 | let mut last_index = result.find(|c| c == '.' || c == 'e').unwrap_or(result.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['.', 'e']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/level_index.rs:113:3 [INFO] [stdout] | [INFO] [stdout] 113 | return self.indexes.len() as i16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return self.indexes.len() as i16; [INFO] [stdout] 113 + self.indexes.len() as i16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/parquet_writer.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 156 | self.flush_group().map_err(|e| e)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove the call to `map_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parquetinfo.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 111 | f.write_str(&s) [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parquetinfo.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 117 | f.write_str(&s) [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/parquetinfo.rs:129:3 [INFO] [stdout] | [INFO] [stdout] 129 | / match lt { [INFO] [stdout] 130 | | _ => { [INFO] [stdout] 131 | | write!(f, "{:x?}", self.data()) [INFO] [stdout] 132 | | } [INFO] [stdout] 133 | | } [INFO] [stdout] | |_________^ help: consider using the match body instead: `write!(f, "{:x?}", self.data())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/playground.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 16 | let file = fs::File::create(&file_path).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/postgres_cloner.rs:137:44 [INFO] [stdout] | [INFO] [stdout] 137 | let password = rpassword::prompt_password(&format!("Password for user {}: ", user)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Password for user {}: ", user)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/parquet_writer.rs:1:92 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{borrow::Cow, cell::RefCell, fmt::Display, io::Write, mem, os, rc::Rc, sync::Arc, usize}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/postgres_cloner.rs:174:92 [INFO] [stdout] | [INFO] [stdout] 174 | let connector = builder.build().map_err(|e| format!("Creating TLS connector failed: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/postgres_cloner.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 267 | } else if !config.get_password().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.get_password().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/parquet_writer.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | if !self.quiet && self.stats.rows % 256 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.stats.rows.is_multiple_of(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/parquet_writer.rs:111:37 [INFO] [stdout] | [INFO] [stdout] 111 | let mut last_index = result.find(|c| c == '.' || c == 'e').unwrap_or(result.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['.', 'e']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/postgres_cloner.rs:272:19 [INFO] [stdout] | [INFO] [stdout] 272 | config.password(&read_password(config.get_user().unwrap())?.trim()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `read_password(config.get_user().unwrap())?.trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/postgres_cloner.rs:285:51 [INFO] [stdout] | [INFO] [stdout] 285 | (None, Some(_)) | (Some(_), None) => return Err(format!("Options ssl-client-cert and ssl-client-key must both be specified.")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Options ssl-client-cert and ssl-client-key must both be specified.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/postgres_cloner.rs:322:2 [INFO] [stdout] | [INFO] [stdout] 322 | Ok(row_writer.close()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 322 - Ok(row_writer.close()?) [INFO] [stdout] 322 + row_writer.close() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/parquet_writer.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 156 | self.flush_group().map_err(|e| e)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove the call to `map_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/postgres_cloner.rs:137:44 [INFO] [stdout] | [INFO] [stdout] 137 | let password = rpassword::prompt_password(&format!("Password for user {}: ", user)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Password for user {}: ", user)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/postgres_cloner.rs:407:20 [INFO] [stdout] | [INFO] [stdout] 407 | fn map_schema_root<'a>(row: &[Column], s: &SchemaSettings) -> Result>, String> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/postgres_cloner.rs:174:92 [INFO] [stdout] | [INFO] [stdout] 174 | let connector = builder.build().map_err(|e| format!("Creating TLS connector failed: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/postgres_cloner.rs:471:65 [INFO] [stdout] | [INFO] [stdout] 471 | let array_appender = create_array_appender(element_appender, &c, plain_schema); [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/postgres_cloner.rs:472:64 [INFO] [stdout] | [INFO] [stdout] 472 | let dim_appender = create_array_dim_appender::(&c); [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/postgres_cloner.rs:473:71 [INFO] [stdout] | [INFO] [stdout] 473 | let lb_appender = create_array_lower_bound_appender::(&c); [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/postgres_cloner.rs:501:3 [INFO] [stdout] | [INFO] [stdout] 501 | &Kind::Range(ref element_type) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 501 - &Kind::Range(ref element_type) => { [INFO] [stdout] 501 + Kind::Range(element_type) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/postgres_cloner.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 267 | } else if !config.get_password().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.get_password().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/postgres_cloner.rs:272:19 [INFO] [stdout] | [INFO] [stdout] 272 | config.password(&read_password(config.get_user().unwrap())?.trim()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `read_password(config.get_user().unwrap())?.trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/postgres_cloner.rs:541:3 [INFO] [stdout] | [INFO] [stdout] 541 | &Kind::Composite(ref fields) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 541 - &Kind::Composite(ref fields) => { [INFO] [stdout] 541 + Kind::Composite(fields) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/postgres_cloner.rs:543:25 [INFO] [stdout] | [INFO] [stdout] 543 | for (i, f) in fields.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/postgres_cloner.rs:285:51 [INFO] [stdout] | [INFO] [stdout] 285 | (None, Some(_)) | (Some(_), None) => return Err(format!("Options ssl-client-cert and ssl-client-key must both be specified.")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Options ssl-client-cert and ssl-client-key must both be specified.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/postgres_cloner.rs:322:2 [INFO] [stdout] | [INFO] [stdout] 322 | Ok(row_writer.close()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 322 - Ok(row_writer.close()?) [INFO] [stdout] 322 + row_writer.close() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/postgres_cloner.rs:618:120 [INFO] [stdout] | [INFO] [stdout] 618 | ...uid), None, |v| MyFrom::my_from(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `MyFrom::my_from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/postgres_cloner.rs:625:109 [INFO] [stdout] | [INFO] [stdout] 625 | ...None, None, |v| MyFrom::my_from(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `MyFrom::my_from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/postgres_cloner.rs:637:128 [INFO] [stdout] | [INFO] [stdout] 637 | ...:INTERVAL), |v| MyFrom::my_from(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `MyFrom::my_from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/postgres_cloner.rs:692:57 [INFO] [stdout] | [INFO] [stdout] 692 | (Box::new(wrap_pg_row_reader::(&c, array_appender)), schema) [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/postgres_cloner.rs:407:20 [INFO] [stdout] | [INFO] [stdout] 407 | fn map_schema_root<'a>(row: &[Column], s: &SchemaSettings) -> Result>, String> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgres_cloner.rs:803:2 [INFO] [stdout] | [INFO] [stdout] 803 | / match length { [INFO] [stdout] 804 | | Some(l) => { [INFO] [stdout] 805 | | t = t.with_length(l); [INFO] [stdout] 806 | | }, [INFO] [stdout] 807 | | _ => {} [INFO] [stdout] 808 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 803 ~ if let Some(l) = length { [INFO] [stdout] 804 ~ t = t.with_length(l); [INFO] [stdout] 805 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgres_cloner.rs:810:2 [INFO] [stdout] | [INFO] [stdout] 810 | / match &logical_type { [INFO] [stdout] 811 | | Some(LogicalType::Decimal { scale, precision }) => { [INFO] [stdout] 812 | | t = t.with_precision(*precision).with_scale(*scale); [INFO] [stdout] 813 | | }, [INFO] [stdout] 814 | | _ => {} [INFO] [stdout] 815 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 810 ~ if let Some(LogicalType::Decimal { scale, precision }) = &logical_type { [INFO] [stdout] 811 ~ t = t.with_precision(*precision).with_scale(*scale); [INFO] [stdout] 812 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `x.dims` after checking its variant with `is_some` [INFO] [stdout] --> src/postgres_cloner.rs:854:6 [INFO] [stdout] | [INFO] [stdout] 850 | if warn_on_multidim && x.dims.is_some() && !warned.load(Ordering::Relaxed) { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 854 | x.dims.as_ref().unwrap().len(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/postgres_cloner.rs:471:65 [INFO] [stdout] | [INFO] [stdout] 471 | let array_appender = create_array_appender(element_appender, &c, plain_schema); [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `x.dims` after checking its variant with `is_some` [INFO] [stdout] --> src/postgres_cloner.rs:855:6 [INFO] [stdout] | [INFO] [stdout] 850 | if warn_on_multidim && x.dims.is_some() && !warned.load(Ordering::Relaxed) { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 855 | x.dims.as_ref().unwrap().iter().map(|x| x.to_string()).collect::>().join("x"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/postgres_cloner.rs:850:3 [INFO] [stdout] | [INFO] [stdout] 850 | / ... if warn_on_multidim && x.dims.is_some() && !warned.load(Ordering::Relaxed) { [INFO] [stdout] 851 | | ... if !warned.fetch_or(true, Ordering::SeqCst) { [INFO] [stdout] 852 | | ... eprintln!("Warning: Column {} contains a {}-dimensional array which will be flattened in Parquet (i.e. {} -> {}). U... [INFO] [stdout] 853 | | ... col_clone.full_name(), [INFO] [stdout] ... | [INFO] [stdout] 859 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 850 ~ if warn_on_multidim && x.dims.is_some() && !warned.load(Ordering::Relaxed) [INFO] [stdout] 851 ~ && !warned.fetch_or(true, Ordering::SeqCst) { [INFO] [stdout] 852 | eprintln!("Warning: Column {} contains a {}-dimensional array which will be flattened in Parquet (i.e. {} -> {}). Use --array-handling=dimensions, include another column with the PostgreSQL array dimensions.", [INFO] [stdout] ... [INFO] [stdout] 857 | ) [INFO] [stdout] 858 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/postgres_cloner.rs:472:64 [INFO] [stdout] | [INFO] [stdout] 472 | let dim_appender = create_array_dim_appender::(&c); [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/postgres_cloner.rs:473:71 [INFO] [stdout] | [INFO] [stdout] 473 | let lb_appender = create_array_lower_bound_appender::(&c); [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/postgres_cloner.rs:875:28 [INFO] [stdout] | [INFO] [stdout] 875 | .unwrap_or_else(|| if x.data.len() == 0 { Vec::new() } else { vec![Some(x.data.len() as i32)] }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/postgres_cloner.rs:887:11 [INFO] [stdout] | [INFO] [stdout] 887 | _ if x.data.len() == 0 => Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/postgres_cloner.rs:501:3 [INFO] [stdout] | [INFO] [stdout] 501 | &Kind::Range(ref element_type) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 501 - &Kind::Range(ref element_type) => { [INFO] [stdout] 501 + Kind::Range(element_type) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/postgres_cloner.rs:541:3 [INFO] [stdout] | [INFO] [stdout] 541 | &Kind::Composite(ref fields) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 541 - &Kind::Composite(ref fields) => { [INFO] [stdout] 541 + Kind::Composite(fields) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/postgres_cloner.rs:543:25 [INFO] [stdout] | [INFO] [stdout] 543 | for (i, f) in fields.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/postgres_cloner.rs:933:11 [INFO] [stdout] | [INFO] [stdout] 933 | assert!(self.is_array == false, "Parquet does not support nested arrays"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.is_array` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pg_custom_types.rs:10:2 [INFO] [stdout] | [INFO] [stdout] 10 | return i32::from_be_bytes(x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return i32::from_be_bytes(x); [INFO] [stdout] 10 + i32::from_be_bytes(x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/pg_custom_types.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | debug_assert!(match ty.kind() { Kind::Enum(_) => true, _ => false }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 20 - debug_assert!(match ty.kind() { Kind::Enum(_) => true, _ => false }); [INFO] [stdout] 20 + debug_assert!(matches!(ty.kind(), Kind::Enum(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/pg_custom_types.rs:26:3 [INFO] [stdout] | [INFO] [stdout] 26 | / match ty.kind() { [INFO] [stdout] 27 | | Kind::Enum(_) => true, [INFO] [stdout] 28 | | _ => false [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 26 - match ty.kind() { [INFO] [stdout] 27 - Kind::Enum(_) => true, [INFO] [stdout] 28 - _ => false [INFO] [stdout] 29 - } [INFO] [stdout] 26 + matches!(ty.kind(), Kind::Enum(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/pg_custom_types.rs:40:3 [INFO] [stdout] | [INFO] [stdout] 40 | / match ty.kind() { [INFO] [stdout] 41 | | Kind::Array(_) => panic!("Nooo {}", ty), [INFO] [stdout] 42 | | _ => {} [INFO] [stdout] 43 | | }; [INFO] [stdout] | |_________^ help: try: `if let Kind::Array(_) = ty.kind() { panic!("Nooo {}", ty) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/postgres_cloner.rs:618:120 [INFO] [stdout] | [INFO] [stdout] 618 | ...uid), None, |v| MyFrom::my_from(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `MyFrom::my_from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/postgres_cloner.rs:625:109 [INFO] [stdout] | [INFO] [stdout] 625 | ...None, None, |v| MyFrom::my_from(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `MyFrom::my_from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/postgres_cloner.rs:637:128 [INFO] [stdout] | [INFO] [stdout] 637 | ...:INTERVAL), |v| MyFrom::my_from(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `MyFrom::my_from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/pg_custom_types.rs:156:3 [INFO] [stdout] | [INFO] [stdout] 156 | / match ty.kind() { [INFO] [stdout] 157 | | Kind::Range(_) => true, [INFO] [stdout] 158 | | _ => false [INFO] [stdout] 159 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 156 - match ty.kind() { [INFO] [stdout] 157 - Kind::Range(_) => true, [INFO] [stdout] 158 - _ => false [INFO] [stdout] 159 - } [INFO] [stdout] 156 + matches!(ty.kind(), Kind::Range(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/postgres_cloner.rs:692:57 [INFO] [stdout] | [INFO] [stdout] 692 | (Box::new(wrap_pg_row_reader::(&c, array_appender)), schema) [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `field_i` is only used to index `fields` [INFO] [stdout] --> src/pg_custom_types.rs:184:18 [INFO] [stdout] | [INFO] [stdout] 184 | for field_i in 0..num_cols { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 184 - for field_i in 0..num_cols { [INFO] [stdout] 184 + for in fields.iter().take(num_cols) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/pg_custom_types.rs:208:3 [INFO] [stdout] | [INFO] [stdout] 208 | / match ty.kind() { [INFO] [stdout] 209 | | Kind::Composite(_) => true, [INFO] [stdout] 210 | | _ => false [INFO] [stdout] 211 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 208 - match ty.kind() { [INFO] [stdout] 209 - Kind::Composite(_) => true, [INFO] [stdout] 210 - _ => false [INFO] [stdout] 211 - } [INFO] [stdout] 208 + matches!(ty.kind(), Kind::Composite(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/pg_custom_types.rs:244:6 [INFO] [stdout] | [INFO] [stdout] 244 | impl<'b> PgAbstractRow for PgRawRange { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgres_cloner.rs:803:2 [INFO] [stdout] | [INFO] [stdout] 803 | / match length { [INFO] [stdout] 804 | | Some(l) => { [INFO] [stdout] 805 | | t = t.with_length(l); [INFO] [stdout] 806 | | }, [INFO] [stdout] 807 | | _ => {} [INFO] [stdout] 808 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 803 ~ if let Some(l) = length { [INFO] [stdout] 804 ~ t = t.with_length(l); [INFO] [stdout] 805 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/postgres_cloner.rs:810:2 [INFO] [stdout] | [INFO] [stdout] 810 | / match &logical_type { [INFO] [stdout] 811 | | Some(LogicalType::Decimal { scale, precision }) => { [INFO] [stdout] 812 | | t = t.with_precision(*precision).with_scale(*scale); [INFO] [stdout] 813 | | }, [INFO] [stdout] 814 | | _ => {} [INFO] [stdout] 815 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 810 ~ if let Some(LogicalType::Decimal { scale, precision }) = &logical_type { [INFO] [stdout] 811 ~ t = t.with_precision(*precision).with_scale(*scale); [INFO] [stdout] 812 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/pg_custom_types.rs:302:25 [INFO] [stdout] | [INFO] [stdout] 302 | T::from_sql(&self.ty, &self.value).unwrap() [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `self.value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `x.dims` after checking its variant with `is_some` [INFO] [stdout] --> src/postgres_cloner.rs:854:6 [INFO] [stdout] | [INFO] [stdout] 850 | if warn_on_multidim && x.dims.is_some() && !warned.load(Ordering::Relaxed) { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 854 | x.dims.as_ref().unwrap().len(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `x.dims` after checking its variant with `is_some` [INFO] [stdout] --> src/postgres_cloner.rs:855:6 [INFO] [stdout] | [INFO] [stdout] 850 | if warn_on_multidim && x.dims.is_some() && !warned.load(Ordering::Relaxed) { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 855 | x.dims.as_ref().unwrap().iter().map(|x| x.to_string()).collect::>().join("x"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/postgres_cloner.rs:850:3 [INFO] [stdout] | [INFO] [stdout] 850 | / ... if warn_on_multidim && x.dims.is_some() && !warned.load(Ordering::Relaxed) { [INFO] [stdout] 851 | | ... if !warned.fetch_or(true, Ordering::SeqCst) { [INFO] [stdout] 852 | | ... eprintln!("Warning: Column {} contains a {}-dimensional array which will be flattened in Parquet (i.e. {} -> {}). U... [INFO] [stdout] 853 | | ... col_clone.full_name(), [INFO] [stdout] ... | [INFO] [stdout] 859 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 850 ~ if warn_on_multidim && x.dims.is_some() && !warned.load(Ordering::Relaxed) [INFO] [stdout] 851 ~ && !warned.fetch_or(true, Ordering::SeqCst) { [INFO] [stdout] 852 | eprintln!("Warning: Column {} contains a {}-dimensional array which will be flattened in Parquet (i.e. {} -> {}). Use --array-handling=dimensions, include another column with the PostgreSQL array dimensions.", [INFO] [stdout] ... [INFO] [stdout] 857 | ) [INFO] [stdout] 858 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/postgres_cloner.rs:875:28 [INFO] [stdout] | [INFO] [stdout] 875 | .unwrap_or_else(|| if x.data.len() == 0 { Vec::new() } else { vec![Some(x.data.len() as i32)] }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/postgres_cloner.rs:887:11 [INFO] [stdout] | [INFO] [stdout] 887 | _ if x.data.len() == 0 => Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/datatypes/money.rs:13:36 [INFO] [stdout] | [INFO] [stdout] 13 | let amount = BigEndian::read_i64(&raw); [INFO] [stdout] | ^^^^ help: change this to: `raw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/postgres_cloner.rs:933:11 [INFO] [stdout] | [INFO] [stdout] 933 | assert!(self.is_array == false, "Parquet does not support nested arrays"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.is_array` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pg_custom_types.rs:10:2 [INFO] [stdout] | [INFO] [stdout] 10 | return i32::from_be_bytes(x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return i32::from_be_bytes(x); [INFO] [stdout] 10 + i32::from_be_bytes(x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/pg_custom_types.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | debug_assert!(match ty.kind() { Kind::Enum(_) => true, _ => false }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 20 - debug_assert!(match ty.kind() { Kind::Enum(_) => true, _ => false }); [INFO] [stdout] 20 + debug_assert!(matches!(ty.kind(), Kind::Enum(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/pg_custom_types.rs:26:3 [INFO] [stdout] | [INFO] [stdout] 26 | / match ty.kind() { [INFO] [stdout] 27 | | Kind::Enum(_) => true, [INFO] [stdout] 28 | | _ => false [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 26 - match ty.kind() { [INFO] [stdout] 27 - Kind::Enum(_) => true, [INFO] [stdout] 28 - _ => false [INFO] [stdout] 29 - } [INFO] [stdout] 26 + matches!(ty.kind(), Kind::Enum(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/pg_custom_types.rs:40:3 [INFO] [stdout] | [INFO] [stdout] 40 | / match ty.kind() { [INFO] [stdout] 41 | | Kind::Array(_) => panic!("Nooo {}", ty), [INFO] [stdout] 42 | | _ => {} [INFO] [stdout] 43 | | }; [INFO] [stdout] | |_________^ help: try: `if let Kind::Array(_) = ty.kind() { panic!("Nooo {}", ty) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/datatypes/pgvector.rs:55:6 [INFO] [stdout] | [INFO] [stdout] 55 | impl<'a> IntoIterator for PgF32Vector { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/pg_custom_types.rs:156:3 [INFO] [stdout] | [INFO] [stdout] 156 | / match ty.kind() { [INFO] [stdout] 157 | | Kind::Range(_) => true, [INFO] [stdout] 158 | | _ => false [INFO] [stdout] 159 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 156 - match ty.kind() { [INFO] [stdout] 157 - Kind::Range(_) => true, [INFO] [stdout] 158 - _ => false [INFO] [stdout] 159 - } [INFO] [stdout] 156 + matches!(ty.kind(), Kind::Range(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `field_i` is only used to index `fields` [INFO] [stdout] --> src/pg_custom_types.rs:184:18 [INFO] [stdout] | [INFO] [stdout] 184 | for field_i in 0..num_cols { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 184 - for field_i in 0..num_cols { [INFO] [stdout] 184 + for in fields.iter().take(num_cols) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/appenders/interface.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 10 | fn write_columns<'b>(&mut self, column_i: usize, next_col: &mut dyn DynamicSerializedWriter) -> Result<(), String>; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/pg_custom_types.rs:208:3 [INFO] [stdout] | [INFO] [stdout] 208 | / match ty.kind() { [INFO] [stdout] 209 | | Kind::Composite(_) => true, [INFO] [stdout] 210 | | _ => false [INFO] [stdout] 211 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 208 - match ty.kind() { [INFO] [stdout] 209 - Kind::Composite(_) => true, [INFO] [stdout] 210 - _ => false [INFO] [stdout] 211 - } [INFO] [stdout] 208 + matches!(ty.kind(), Kind::Composite(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/pg_custom_types.rs:244:6 [INFO] [stdout] | [INFO] [stdout] 244 | impl<'b> PgAbstractRow for PgRawRange { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/appenders/interface.rs:60:80 [INFO] [stdout] | [INFO] [stdout] 60 | fn next_column(&mut self, callback: &mut dyn FnMut(SerializedColumnWriter<'_>) -> ()) -> parquet::errors::Result; [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/appenders/interface.rs:65:10 [INFO] [stdout] | [INFO] [stdout] 65 | impl<'a, 'b, W: Write + Send> DynamicSerializedWriter for DynamicSerializedWriterImpl<'a, W> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/appenders/interface.rs:66:80 [INFO] [stdout] | [INFO] [stdout] 66 | fn next_column(&mut self, callback: &mut dyn FnMut(SerializedColumnWriter<'_>) -> ()) -> parquet::errors::Result { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/pg_custom_types.rs:302:25 [INFO] [stdout] | [INFO] [stdout] 302 | T::from_sql(&self.ty, &self.value).unwrap() [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `self.value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `error` after checking its variant with `is_some` [INFO] [stdout] --> src/appenders/generic.rs:95:66 [INFO] [stdout] | [INFO] [stdout] 93 | if error.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = error` [INFO] [stdout] 94 | let col_name = col_descriptor.map(|(desc, _, _)| desc.path().string()).unwrap_or_else(|| format!("column[{}]", column_i)); [INFO] [stdout] 95 | return Err(format!("Couldn't write data of {}: {}", col_name, error.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/datatypes/money.rs:13:36 [INFO] [stdout] | [INFO] [stdout] 13 | let amount = BigEndian::read_i64(&raw); [INFO] [stdout] | ^^^^ help: change this to: `raw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference [INFO] [stdout] --> src/appenders/array.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 60 | fn as_option(self) -> Option; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/appenders/array.rs:73:6 [INFO] [stdout] | [INFO] [stdout] 73 | impl<'a, TPg: Clone, TInner, TArray: Clone, TItem> ColumnAppender for ArrayColumnAppender [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/appenders/array.rs:83:56 [INFO] [stdout] | [INFO] [stdout] 83 | for (_index, value) in array.into_owned().into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 83 - for (_index, value) in array.into_owned().into_iter().enumerate() { [INFO] [stdout] 83 + for value in array.into_owned().into_iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/appenders/array.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | / match value.as_option() { [INFO] [stdout] 89 | | Some(value) => { [INFO] [stdout] 90 | | bytes_written += self.inner.copy_value(&nested_ri, Cow::Owned(value))?; [INFO] [stdout] 91 | | nested_ri.inc(); [INFO] [stdout] 92 | | }, [INFO] [stdout] 93 | | None => { }// skip [INFO] [stdout] 94 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 88 ~ if let Some(value) = value.as_option() { [INFO] [stdout] 89 ~ bytes_written += self.inner.copy_value(&nested_ri, Cow::Owned(value))?; [INFO] [stdout] 90 ~ nested_ri.inc(); [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/datatypes/pgvector.rs:55:6 [INFO] [stdout] | [INFO] [stdout] 55 | impl<'a> IntoIterator for PgF32Vector { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/appenders/interface.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 10 | fn write_columns<'b>(&mut self, column_i: usize, next_col: &mut dyn DynamicSerializedWriter) -> Result<(), String>; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/appenders/interface.rs:60:80 [INFO] [stdout] | [INFO] [stdout] 60 | fn next_column(&mut self, callback: &mut dyn FnMut(SerializedColumnWriter<'_>) -> ()) -> parquet::errors::Result; [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/appenders/interface.rs:65:10 [INFO] [stdout] | [INFO] [stdout] 65 | impl<'a, 'b, W: Write + Send> DynamicSerializedWriter for DynamicSerializedWriterImpl<'a, W> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/appenders/interface.rs:66:80 [INFO] [stdout] | [INFO] [stdout] 66 | fn next_column(&mut self, callback: &mut dyn FnMut(SerializedColumnWriter<'_>) -> ()) -> parquet::errors::Result { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `error` after checking its variant with `is_some` [INFO] [stdout] --> src/appenders/generic.rs:95:66 [INFO] [stdout] | [INFO] [stdout] 93 | if error.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = error` [INFO] [stdout] 94 | let col_name = col_descriptor.map(|(desc, _, _)| desc.path().string()).unwrap_or_else(|| format!("column[{}]", column_i)); [INFO] [stdout] 95 | return Err(format!("Couldn't write data of {}: {}", col_name, error.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/appenders/byte_array.rs:82:6 [INFO] [stdout] | [INFO] [stdout] 82 | if self.offsets.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.offsets.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `error` after checking its variant with `is_some` [INFO] [stdout] --> src/appenders/byte_array.rs:135:74 [INFO] [stdout] | [INFO] [stdout] 134 | if error.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = error` [INFO] [stdout] 135 | return Err(format!("Couldn't write data of column[{}]: {}", column_i, error.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/appenders/byte_array.rs:178:2 [INFO] [stdout] | [INFO] [stdout] 170 | / let a = ByteArrayColumnAppender::new(max_dl, max_rl, move |row: &TRow, buffer: &mut Vec| { [INFO] [stdout] 171 | | if let Some(value) = row.ab_get::>(column_index) { [INFO] [stdout] 172 | | buffer.extend_from_slice(value.value); [INFO] [stdout] 173 | | Some(value.value.len()) [INFO] [stdout] ... | [INFO] [stdout] 177 | | }); [INFO] [stdout] | |_______- unnecessary `let` binding [INFO] [stdout] 178 | a [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 170 ~ [INFO] [stdout] 171 ~ ByteArrayColumnAppender::new(max_dl, max_rl, move |row: &TRow, buffer: &mut Vec| { [INFO] [stdout] 172 ~ if let Some(value) = row.ab_get::>(column_index) { [INFO] [stdout] 173 ~ buffer.extend_from_slice(value.value); [INFO] [stdout] 174 ~ Some(value.value.len()) [INFO] [stdout] 175 ~ } else { [INFO] [stdout] 176 ~ None [INFO] [stdout] 177 ~ } [INFO] [stdout] 178 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference [INFO] [stdout] --> src/appenders/array.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 60 | fn as_option(self) -> Option; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/appenders/array.rs:73:6 [INFO] [stdout] | [INFO] [stdout] 73 | impl<'a, TPg: Clone, TInner, TArray: Clone, TItem> ColumnAppender for ArrayColumnAppender [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/appenders/byte_array.rs:195:2 [INFO] [stdout] | [INFO] [stdout] 182 | / let a = ByteArrayColumnAppender::new(max_dl, max_rl, move |row: &TRow, buffer: &mut Vec| { [INFO] [stdout] 183 | | if let Some(value) = row.ab_get::>(column_index) { [INFO] [stdout] 184 | | [INFO] [stdout] 185 | | debug_assert_eq!(value.ty, postgres::types::Type::JSONB); [INFO] [stdout] ... | [INFO] [stdout] 194 | | }); [INFO] [stdout] | |_______- unnecessary `let` binding [INFO] [stdout] 195 | a [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 182 ~ [INFO] [stdout] 183 ~ ByteArrayColumnAppender::new(max_dl, max_rl, move |row: &TRow, buffer: &mut Vec| { [INFO] [stdout] 184 ~ if let Some(value) = row.ab_get::>(column_index) { [INFO] [stdout] 185 + [INFO] [stdout] 186 ~ debug_assert_eq!(value.ty, postgres::types::Type::JSONB); [INFO] [stdout] 187 ~ let mut data = value.value; [INFO] [stdout] 188 ~ let version = data.read_i32::().unwrap(); [INFO] [stdout] 189 ~ assert_eq!(version, 1); [INFO] [stdout] 190 ~ buffer.extend_from_slice(data); [INFO] [stdout] 191 ~ Some(value.value.len()) [INFO] [stdout] 192 ~ } else { [INFO] [stdout] 193 ~ None [INFO] [stdout] 194 ~ } [INFO] [stdout] 195 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/appenders/array.rs:83:56 [INFO] [stdout] | [INFO] [stdout] 83 | for (_index, value) in array.into_owned().into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 83 - for (_index, value) in array.into_owned().into_iter().enumerate() { [INFO] [stdout] 83 + for value in array.into_owned().into_iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/appenders/array.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | / match value.as_option() { [INFO] [stdout] 89 | | Some(value) => { [INFO] [stdout] 90 | | bytes_written += self.inner.copy_value(&nested_ri, Cow::Owned(value))?; [INFO] [stdout] 91 | | nested_ri.inc(); [INFO] [stdout] 92 | | }, [INFO] [stdout] 93 | | None => { }// skip [INFO] [stdout] 94 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 88 ~ if let Some(value) = value.as_option() { [INFO] [stdout] 89 ~ bytes_written += self.inner.copy_value(&nested_ri, Cow::Owned(value))?; [INFO] [stdout] 90 ~ nested_ri.inc(); [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/main.rs:34:1 [INFO] [stdout] | [INFO] [stdout] 34 | / enum CliCommand { [INFO] [stdout] 35 | | /// Dumps something from a parquet file [INFO] [stdout] 36 | | #[command(arg_required_else_help = true, hide = true)] [INFO] [stdout] 37 | | ParquetInfo(ParquetInfoArgs), [INFO] [stdout] | | ---------------------------- the second-largest variant contains at least 24 bytes [INFO] [stdout] ... | [INFO] [stdout] 45 | | Export(ExportArgs) [INFO] [stdout] | | ------------------ the largest variant contains at least 304 bytes [INFO] [stdout] 46 | | } [INFO] [stdout] | |_^ the entire enum is at least 304 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 45 - Export(ExportArgs) [INFO] [stdout] 45 + Export(Box) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/appenders/byte_array.rs:82:6 [INFO] [stdout] | [INFO] [stdout] 82 | if self.offsets.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.offsets.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `error` after checking its variant with `is_some` [INFO] [stdout] --> src/appenders/byte_array.rs:135:74 [INFO] [stdout] | [INFO] [stdout] 134 | if error.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = error` [INFO] [stdout] 135 | return Err(format!("Couldn't write data of column[{}]: {}", column_i, error.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/appenders/byte_array.rs:178:2 [INFO] [stdout] | [INFO] [stdout] 170 | / let a = ByteArrayColumnAppender::new(max_dl, max_rl, move |row: &TRow, buffer: &mut Vec| { [INFO] [stdout] 171 | | if let Some(value) = row.ab_get::>(column_index) { [INFO] [stdout] 172 | | buffer.extend_from_slice(value.value); [INFO] [stdout] 173 | | Some(value.value.len()) [INFO] [stdout] ... | [INFO] [stdout] 177 | | }); [INFO] [stdout] | |_______- unnecessary `let` binding [INFO] [stdout] 178 | a [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 170 ~ [INFO] [stdout] 171 ~ ByteArrayColumnAppender::new(max_dl, max_rl, move |row: &TRow, buffer: &mut Vec| { [INFO] [stdout] 172 ~ if let Some(value) = row.ab_get::>(column_index) { [INFO] [stdout] 173 ~ buffer.extend_from_slice(value.value); [INFO] [stdout] 174 ~ Some(value.value.len()) [INFO] [stdout] 175 ~ } else { [INFO] [stdout] 176 ~ None [INFO] [stdout] 177 ~ } [INFO] [stdout] 178 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/appenders/byte_array.rs:195:2 [INFO] [stdout] | [INFO] [stdout] 182 | / let a = ByteArrayColumnAppender::new(max_dl, max_rl, move |row: &TRow, buffer: &mut Vec| { [INFO] [stdout] 183 | | if let Some(value) = row.ab_get::>(column_index) { [INFO] [stdout] 184 | | [INFO] [stdout] 185 | | debug_assert_eq!(value.ty, postgres::types::Type::JSONB); [INFO] [stdout] ... | [INFO] [stdout] 194 | | }); [INFO] [stdout] | |_______- unnecessary `let` binding [INFO] [stdout] 195 | a [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 182 ~ [INFO] [stdout] 183 ~ ByteArrayColumnAppender::new(max_dl, max_rl, move |row: &TRow, buffer: &mut Vec| { [INFO] [stdout] 184 ~ if let Some(value) = row.ab_get::>(column_index) { [INFO] [stdout] 185 + [INFO] [stdout] 186 ~ debug_assert_eq!(value.ty, postgres::types::Type::JSONB); [INFO] [stdout] 187 ~ let mut data = value.value; [INFO] [stdout] 188 ~ let version = data.read_i32::().unwrap(); [INFO] [stdout] 189 ~ assert_eq!(version, 1); [INFO] [stdout] 190 ~ buffer.extend_from_slice(data); [INFO] [stdout] 191 ~ Some(value.value.len()) [INFO] [stdout] 192 ~ } else { [INFO] [stdout] 193 ~ None [INFO] [stdout] 194 ~ } [INFO] [stdout] 195 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/main.rs:34:1 [INFO] [stdout] | [INFO] [stdout] 34 | / enum CliCommand { [INFO] [stdout] 35 | | /// Dumps something from a parquet file [INFO] [stdout] 36 | | #[command(arg_required_else_help = true, hide = true)] [INFO] [stdout] 37 | | ParquetInfo(ParquetInfoArgs), [INFO] [stdout] | | ---------------------------- the second-largest variant contains at least 24 bytes [INFO] [stdout] ... | [INFO] [stdout] 45 | | Export(ExportArgs) [INFO] [stdout] | | ------------------ the largest variant contains at least 304 bytes [INFO] [stdout] 46 | | } [INFO] [stdout] | |_^ the entire enum is at least 304 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 45 - Export(ExportArgs) [INFO] [stdout] 45 + Export(Box) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/main.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | /// [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] = note: `#[warn(clippy::empty_docs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/main.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | /// [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] = note: `#[warn(clippy::empty_docs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:48:3 [INFO] [stdout] | [INFO] [stdout] 48 | &vec![1, 0, 2], [INFO] [stdout] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 0, 2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | Some(&vec![1, 0, 1]), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 0, 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:56:3 [INFO] [stdout] | [INFO] [stdout] 56 | &vec![ 1, 2, 3, 4, 10, 0, 0], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3, 4, 10, 0, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 57 | Some(&vec![2, 2, 2, 2, 2, 1, 0]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[2, 2, 2, 2, 2, 1, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 58 | Some(&vec![0, 1, 1, 1, 0, 1, 0]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 1, 1, 1, 0, 1, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:65:3 [INFO] [stdout] | [INFO] [stdout] 65 | &vec![ now_ms, 0, 0], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[now_ms, 0, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 66 | Some(&vec![2, 1, 0]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[2, 1, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:48:3 [INFO] [stdout] | [INFO] [stdout] 48 | &vec![1, 0, 2], [INFO] [stdout] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 0, 2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | Some(&vec![1, 0, 1]), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 0, 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:56:3 [INFO] [stdout] | [INFO] [stdout] 56 | &vec![ 1, 2, 3, 4, 10, 0, 0], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3, 4, 10, 0, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 57 | Some(&vec![2, 2, 2, 2, 2, 1, 0]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[2, 2, 2, 2, 2, 1, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 58 | Some(&vec![0, 1, 1, 1, 0, 1, 0]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 1, 1, 1, 0, 1, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:65:3 [INFO] [stdout] | [INFO] [stdout] 65 | &vec![ now_ms, 0, 0], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[now_ms, 0, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/playground.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 66 | Some(&vec![2, 1, 0]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[2, 1, 0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 09s [INFO] running `Command { std: "docker" "inspect" "429f03b4d85e0c07c12938fa723981347cd68ff9dab07210e6f7a481a7b4ddce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "429f03b4d85e0c07c12938fa723981347cd68ff9dab07210e6f7a481a7b4ddce", kill_on_drop: false }` [INFO] [stdout] 429f03b4d85e0c07c12938fa723981347cd68ff9dab07210e6f7a481a7b4ddce