[INFO] fetching crate pergola 0.9.0... [INFO] linting pergola-0.9.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pergola 0.9.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate pergola 0.9.0 [INFO] finished tweaking crates.io crate pergola 0.9.0 [INFO] tweaked toml for crates.io crate pergola 0.9.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pergola 0.9.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 101 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.9.1) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.9.1) [INFO] [stderr] Adding proptest v0.9.6 (available: v1.10.0) [INFO] [stderr] Adding quickcheck v0.9.2 (available: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quickcheck v0.9.2 [INFO] [stderr] Downloaded rusty-fork v0.2.2 [INFO] [stderr] Downloaded proptest v0.9.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26477e0b36a6f2ce96e8b8f3d7974e83dbf4cbdde71f2ef86ce153cd53054197 [INFO] running `Command { std: "docker" "start" "-a" "26477e0b36a6f2ce96e8b8f3d7974e83dbf4cbdde71f2ef86ce153cd53054197", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26477e0b36a6f2ce96e8b8f3d7974e83dbf4cbdde71f2ef86ce153cd53054197", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26477e0b36a6f2ce96e8b8f3d7974e83dbf4cbdde71f2ef86ce153cd53054197", kill_on_drop: false }` [INFO] [stdout] 26477e0b36a6f2ce96e8b8f3d7974e83dbf4cbdde71f2ef86ce153cd53054197 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42505bf2d911a1a5b88cbd23e4bc78e1fabb113f6bab2ccb2ebaf61924cc5924 [INFO] running `Command { std: "docker" "start" "-a" "42505bf2d911a1a5b88cbd23e4bc78e1fabb113f6bab2ccb2ebaf61924cc5924", kill_on_drop: false }` [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling im-rc v15.1.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking tempfile v3.27.0 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rusty-fork v0.2.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking quickcheck v0.9.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking im v15.1.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking proptest v0.9.6 [INFO] [stderr] Checking pergola v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/latticedef.rs:50:1 [INFO] [stdout] | [INFO] [stdout] 50 | / /// [`LatticeDef`]s trivially anyways, so this isn't much of a burden. [INFO] [stdout] 51 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 56 | pub trait DefTraits: Debug + Ord + Clone + Hash + Default + Serialize + DeserializeOwned {} [INFO] [stdout] | ------------------- the comment documents this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document trait `DefTraits` then comment it out [INFO] [stdout] | [INFO] [stdout] 33 ~ // /// [`DefTraits`] is used to constrain [`LatticeDef`]s and also type parameters [INFO] [stdout] 34 ~ // /// of structs that implement [`LatticeDef`]. This requires some explaining. [INFO] [stdout] 35 ~ // /// [INFO] [stdout] 36 ~ // /// A `LatticeDef` is typically just a unit-struct with no content aside from [INFO] [stdout] 37 ~ // /// `PhantomData` -- it's essentially a module to be used as a parameter to a [INFO] [stdout] 38 ~ // /// `LatticeElt` -- so it doesn't obviously make sense to constrain them at all. [INFO] [stdout] 39 ~ // /// [INFO] [stdout] 40 ~ // /// But: since [`LatticeDef`]s wind up as type parameters for a variety of [INFO] [stdout] 41 ~ // /// structs in client libraries (that themselves contain [`LatticeElt`]s that [INFO] [stdout] 42 ~ // /// use those [`LatticeDef`]s), any attempt to derive standard traits on such [INFO] [stdout] 43 ~ // /// _structs_ will bump into a [bug in [INFO] [stdout] 44 ~ // /// derive](https://github.com/rust-lang/rust/issues/26925) which prevents [INFO] [stdout] 45 ~ // /// derived impls from working right if a struct's type parameters don't [INFO] [stdout] 46 ~ // /// themselves implement the derived traits. [INFO] [stdout] 47 ~ // /// [INFO] [stdout] 48 ~ // /// So to keep derive working downstream, we insist all [`LatticeDef`]s provide [INFO] [stdout] 49 ~ // /// most standard derivable traits. Impls for them can be derived _on_ the [INFO] [stdout] 50 ~ // /// [`LatticeDef`]s trivially anyways, so this isn't much of a burden. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/latticedef.rs:77:1 [INFO] [stdout] | [INFO] [stdout] 77 | / /// ones). [INFO] [stdout] 78 | | [INFO] [stdout] | |_^ [INFO] [stdout] 79 | #[cfg(feature = "serde")] [INFO] [stdout] 80 | pub trait ValTraits: Debug + Eq + Clone + Hash + Default + Serialize + DeserializeOwned {} [INFO] [stdout] | ------------------- the comment documents this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/latticeelt.rs:34:1 [INFO] [stdout] | [INFO] [stdout] 34 | / /// to the functions of the parameter `LatticeDef`. [INFO] [stdout] 35 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub struct LatticeElt { [INFO] [stdout] | --------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/latticedef.rs:824:17 [INFO] [stdout] | [INFO] [stdout] 824 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 824 - return None; [INFO] [stdout] 824 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:810:31 [INFO] [stdout] | [INFO] [stdout] 810 | match (la.partial_cmp(&ra), lb.partial_cmp(&rb)) { [INFO] [stdout] | ^^^ help: change this to: `ra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:810:52 [INFO] [stdout] | [INFO] [stdout] 810 | match (la.partial_cmp(&ra), lb.partial_cmp(&rb)) { [INFO] [stdout] | ^^^ help: change this to: `rb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/latticedef.rs:881:17 [INFO] [stdout] | [INFO] [stdout] 881 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 881 - return None; [INFO] [stdout] 881 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:862:28 [INFO] [stdout] | [INFO] [stdout] 862 | la.partial_cmp(&ra), [INFO] [stdout] | ^^^ help: change this to: `ra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:863:28 [INFO] [stdout] | [INFO] [stdout] 863 | lb.partial_cmp(&rb), [INFO] [stdout] | ^^^ help: change this to: `rb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:864:28 [INFO] [stdout] | [INFO] [stdout] 864 | lc.partial_cmp(&rc), [INFO] [stdout] | ^^^ help: change this to: `rc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/latticedef.rs:949:17 [INFO] [stdout] | [INFO] [stdout] 949 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 949 - return None; [INFO] [stdout] 949 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:927:28 [INFO] [stdout] | [INFO] [stdout] 927 | la.partial_cmp(&ra), [INFO] [stdout] | ^^^ help: change this to: `ra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:928:28 [INFO] [stdout] | [INFO] [stdout] 928 | lb.partial_cmp(&rb), [INFO] [stdout] | ^^^ help: change this to: `rb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:929:28 [INFO] [stdout] | [INFO] [stdout] 929 | lc.partial_cmp(&rc), [INFO] [stdout] | ^^^ help: change this to: `rc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:930:28 [INFO] [stdout] | [INFO] [stdout] 930 | ld.partial_cmp(&rd), [INFO] [stdout] | ^^^ help: change this to: `rd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/latticedef.rs:1035:17 [INFO] [stdout] | [INFO] [stdout] 1035 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1035 - return None; [INFO] [stdout] 1035 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:1006:28 [INFO] [stdout] | [INFO] [stdout] 1006 | la.partial_cmp(&ra), [INFO] [stdout] | ^^^ help: change this to: `ra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:1007:28 [INFO] [stdout] | [INFO] [stdout] 1007 | lb.partial_cmp(&rb), [INFO] [stdout] | ^^^ help: change this to: `rb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:1008:28 [INFO] [stdout] | [INFO] [stdout] 1008 | lc.partial_cmp(&rc), [INFO] [stdout] | ^^^ help: change this to: `rc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:1009:28 [INFO] [stdout] | [INFO] [stdout] 1009 | ld.partial_cmp(&rd), [INFO] [stdout] | ^^^ help: change this to: `rd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:1010:28 [INFO] [stdout] | [INFO] [stdout] 1010 | le.partial_cmp(&re), [INFO] [stdout] | ^^^ help: change this to: `re` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'lhs [INFO] [stdout] --> src/latticeelt.rs:82:6 [INFO] [stdout] | [INFO] [stdout] 82 | impl<'lhs, 'rhs, D: LatticeDef> Add<&'rhs LatticeElt> for &'lhs LatticeElt { [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 82 - impl<'lhs, 'rhs, D: LatticeDef> Add<&'rhs LatticeElt> for &'lhs LatticeElt { [INFO] [stdout] 82 + impl<'rhs, D: LatticeDef> Add<&'rhs LatticeElt> for &LatticeElt { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/latticedef.rs:50:1 [INFO] [stdout] | [INFO] [stdout] 50 | / /// [`LatticeDef`]s trivially anyways, so this isn't much of a burden. [INFO] [stdout] 51 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 56 | pub trait DefTraits: Debug + Ord + Clone + Hash + Default + Serialize + DeserializeOwned {} [INFO] [stdout] | ------------------- the comment documents this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document trait `DefTraits` then comment it out [INFO] [stdout] | [INFO] [stdout] 33 ~ // /// [`DefTraits`] is used to constrain [`LatticeDef`]s and also type parameters [INFO] [stdout] 34 ~ // /// of structs that implement [`LatticeDef`]. This requires some explaining. [INFO] [stdout] 35 ~ // /// [INFO] [stdout] 36 ~ // /// A `LatticeDef` is typically just a unit-struct with no content aside from [INFO] [stdout] 37 ~ // /// `PhantomData` -- it's essentially a module to be used as a parameter to a [INFO] [stdout] 38 ~ // /// `LatticeElt` -- so it doesn't obviously make sense to constrain them at all. [INFO] [stdout] 39 ~ // /// [INFO] [stdout] 40 ~ // /// But: since [`LatticeDef`]s wind up as type parameters for a variety of [INFO] [stdout] 41 ~ // /// structs in client libraries (that themselves contain [`LatticeElt`]s that [INFO] [stdout] 42 ~ // /// use those [`LatticeDef`]s), any attempt to derive standard traits on such [INFO] [stdout] 43 ~ // /// _structs_ will bump into a [bug in [INFO] [stdout] 44 ~ // /// derive](https://github.com/rust-lang/rust/issues/26925) which prevents [INFO] [stdout] 45 ~ // /// derived impls from working right if a struct's type parameters don't [INFO] [stdout] 46 ~ // /// themselves implement the derived traits. [INFO] [stdout] 47 ~ // /// [INFO] [stdout] 48 ~ // /// So to keep derive working downstream, we insist all [`LatticeDef`]s provide [INFO] [stdout] 49 ~ // /// most standard derivable traits. Impls for them can be derived _on_ the [INFO] [stdout] 50 ~ // /// [`LatticeDef`]s trivially anyways, so this isn't much of a burden. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/latticedef.rs:77:1 [INFO] [stdout] | [INFO] [stdout] 77 | / /// ones). [INFO] [stdout] 78 | | [INFO] [stdout] | |_^ [INFO] [stdout] 79 | #[cfg(feature = "serde")] [INFO] [stdout] 80 | pub trait ValTraits: Debug + Eq + Clone + Hash + Default + Serialize + DeserializeOwned {} [INFO] [stdout] | ------------------- the comment documents this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/latticeelt.rs:34:1 [INFO] [stdout] | [INFO] [stdout] 34 | / /// to the functions of the parameter `LatticeDef`. [INFO] [stdout] 35 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub struct LatticeElt { [INFO] [stdout] | --------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/proptests.rs:22:15 [INFO] [stdout] | [INFO] [stdout] 22 | fn prop_assoc( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 29 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/proptests.rs:51:14 [INFO] [stdout] | [INFO] [stdout] 51 | fn prop_comm( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 57 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/proptests.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 77 | fn prop_idem(case: &str, a: &LatticeElt) -> Result<(), TestCaseError> [INFO] [stdout] | ^ [INFO] [stdout] 78 | where [INFO] [stdout] 79 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/proptests.rs:94:14 [INFO] [stdout] | [INFO] [stdout] 94 | fn prop_unit(case: &str, a: &LatticeElt) -> Result<(), TestCaseError> [INFO] [stdout] | ^ [INFO] [stdout] 95 | where [INFO] [stdout] 96 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/proptests.rs:112:23 [INFO] [stdout] | [INFO] [stdout] 112 | fn prop_induced_order( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 118 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/proptests.rs:126:13 [INFO] [stdout] | [INFO] [stdout] 126 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/proptests.rs:151:20 [INFO] [stdout] | [INFO] [stdout] 151 | fn prop_order_refl(case: &str, a: &LatticeElt) -> Result<(), TestCaseError> [INFO] [stdout] | ^ [INFO] [stdout] 152 | where [INFO] [stdout] 153 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/proptests.rs:168:24 [INFO] [stdout] | [INFO] [stdout] 168 | fn prop_order_antisymm( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 174 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/proptests.rs:190:21 [INFO] [stdout] | [INFO] [stdout] 190 | fn prop_order_trans( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 197 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/proptests.rs:214:14 [INFO] [stdout] | [INFO] [stdout] 214 | fn all_props( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 221 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/quickchecks.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | fn join_assoc(a: LatticeElt, b: LatticeElt, c: LatticeElt) -> bool [INFO] [stdout] | ^ [INFO] [stdout] 16 | where [INFO] [stdout] 17 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/quickchecks.rs:37:14 [INFO] [stdout] | [INFO] [stdout] 37 | fn join_comm(a: LatticeElt, b: LatticeElt) -> bool [INFO] [stdout] | ^ [INFO] [stdout] 38 | where [INFO] [stdout] 39 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/quickchecks.rs:57:14 [INFO] [stdout] | [INFO] [stdout] 57 | fn join_idem(a: LatticeElt) -> bool [INFO] [stdout] | ^ [INFO] [stdout] 58 | where [INFO] [stdout] 59 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/quickchecks.rs:71:14 [INFO] [stdout] | [INFO] [stdout] 71 | fn join_unit(a: LatticeElt) -> bool [INFO] [stdout] | ^ [INFO] [stdout] 72 | where [INFO] [stdout] 73 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/quickchecks.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 85 | fn join_order(a: LatticeElt, b: LatticeElt) -> bool [INFO] [stdout] | ^ [INFO] [stdout] 86 | where [INFO] [stdout] 87 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/quickchecks.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | fn quickcheck_props() [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 132 | D: Debug, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/latticedef.rs:824:17 [INFO] [stdout] | [INFO] [stdout] 824 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 824 - return None; [INFO] [stdout] 824 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:810:31 [INFO] [stdout] | [INFO] [stdout] 810 | match (la.partial_cmp(&ra), lb.partial_cmp(&rb)) { [INFO] [stdout] | ^^^ help: change this to: `ra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:810:52 [INFO] [stdout] | [INFO] [stdout] 810 | match (la.partial_cmp(&ra), lb.partial_cmp(&rb)) { [INFO] [stdout] | ^^^ help: change this to: `rb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/latticedef.rs:881:17 [INFO] [stdout] | [INFO] [stdout] 881 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 881 - return None; [INFO] [stdout] 881 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:862:28 [INFO] [stdout] | [INFO] [stdout] 862 | la.partial_cmp(&ra), [INFO] [stdout] | ^^^ help: change this to: `ra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:863:28 [INFO] [stdout] | [INFO] [stdout] 863 | lb.partial_cmp(&rb), [INFO] [stdout] | ^^^ help: change this to: `rb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:864:28 [INFO] [stdout] | [INFO] [stdout] 864 | lc.partial_cmp(&rc), [INFO] [stdout] | ^^^ help: change this to: `rc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/latticedef.rs:949:17 [INFO] [stdout] | [INFO] [stdout] 949 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 949 - return None; [INFO] [stdout] 949 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:927:28 [INFO] [stdout] | [INFO] [stdout] 927 | la.partial_cmp(&ra), [INFO] [stdout] | ^^^ help: change this to: `ra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:928:28 [INFO] [stdout] | [INFO] [stdout] 928 | lb.partial_cmp(&rb), [INFO] [stdout] | ^^^ help: change this to: `rb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:929:28 [INFO] [stdout] | [INFO] [stdout] 929 | lc.partial_cmp(&rc), [INFO] [stdout] | ^^^ help: change this to: `rc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:930:28 [INFO] [stdout] | [INFO] [stdout] 930 | ld.partial_cmp(&rd), [INFO] [stdout] | ^^^ help: change this to: `rd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/latticedef.rs:1035:17 [INFO] [stdout] | [INFO] [stdout] 1035 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1035 - return None; [INFO] [stdout] 1035 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:1006:28 [INFO] [stdout] | [INFO] [stdout] 1006 | la.partial_cmp(&ra), [INFO] [stdout] | ^^^ help: change this to: `ra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:1007:28 [INFO] [stdout] | [INFO] [stdout] 1007 | lb.partial_cmp(&rb), [INFO] [stdout] | ^^^ help: change this to: `rb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:1008:28 [INFO] [stdout] | [INFO] [stdout] 1008 | lc.partial_cmp(&rc), [INFO] [stdout] | ^^^ help: change this to: `rc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:1009:28 [INFO] [stdout] | [INFO] [stdout] 1009 | ld.partial_cmp(&rd), [INFO] [stdout] | ^^^ help: change this to: `rd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/latticedef.rs:1010:28 [INFO] [stdout] | [INFO] [stdout] 1010 | le.partial_cmp(&re), [INFO] [stdout] | ^^^ help: change this to: `re` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'lhs [INFO] [stdout] --> src/latticeelt.rs:82:6 [INFO] [stdout] | [INFO] [stdout] 82 | impl<'lhs, 'rhs, D: LatticeDef> Add<&'rhs LatticeElt> for &'lhs LatticeElt { [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 82 - impl<'lhs, 'rhs, D: LatticeDef> Add<&'rhs LatticeElt> for &'lhs LatticeElt { [INFO] [stdout] 82 + impl<'rhs, D: LatticeDef> Add<&'rhs LatticeElt> for &LatticeElt { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:225:22 [INFO] [stdout] | [INFO] [stdout] 225 | prop_assoc(case, &a, &b, &c)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:225:26 [INFO] [stdout] | [INFO] [stdout] 225 | prop_assoc(case, &a, &b, &c)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:225:30 [INFO] [stdout] | [INFO] [stdout] 225 | prop_assoc(case, &a, &b, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:227:21 [INFO] [stdout] | [INFO] [stdout] 227 | prop_comm(case, &a, &b)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:227:25 [INFO] [stdout] | [INFO] [stdout] 227 | prop_comm(case, &a, &b)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:228:21 [INFO] [stdout] | [INFO] [stdout] 228 | prop_comm(case, &a, &c)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:228:25 [INFO] [stdout] | [INFO] [stdout] 228 | prop_comm(case, &a, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:229:21 [INFO] [stdout] | [INFO] [stdout] 229 | prop_comm(case, &b, &c)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:229:25 [INFO] [stdout] | [INFO] [stdout] 229 | prop_comm(case, &b, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:231:21 [INFO] [stdout] | [INFO] [stdout] 231 | prop_unit(case, &a)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:232:21 [INFO] [stdout] | [INFO] [stdout] 232 | prop_unit(case, &b)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:233:21 [INFO] [stdout] | [INFO] [stdout] 233 | prop_unit(case, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:235:21 [INFO] [stdout] | [INFO] [stdout] 235 | prop_idem(case, &a)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:236:21 [INFO] [stdout] | [INFO] [stdout] 236 | prop_idem(case, &b)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:237:21 [INFO] [stdout] | [INFO] [stdout] 237 | prop_idem(case, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:239:30 [INFO] [stdout] | [INFO] [stdout] 239 | prop_induced_order(case, &a, &b)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:239:34 [INFO] [stdout] | [INFO] [stdout] 239 | prop_induced_order(case, &a, &b)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:240:30 [INFO] [stdout] | [INFO] [stdout] 240 | prop_induced_order(case, &a, &c)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:240:34 [INFO] [stdout] | [INFO] [stdout] 240 | prop_induced_order(case, &a, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:241:30 [INFO] [stdout] | [INFO] [stdout] 241 | prop_induced_order(case, &b, &c)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:241:34 [INFO] [stdout] | [INFO] [stdout] 241 | prop_induced_order(case, &b, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:243:27 [INFO] [stdout] | [INFO] [stdout] 243 | prop_order_refl(case, &a)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:244:27 [INFO] [stdout] | [INFO] [stdout] 244 | prop_order_refl(case, &b)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:245:27 [INFO] [stdout] | [INFO] [stdout] 245 | prop_order_refl(case, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:247:31 [INFO] [stdout] | [INFO] [stdout] 247 | prop_order_antisymm(case, &a, &b)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:247:35 [INFO] [stdout] | [INFO] [stdout] 247 | prop_order_antisymm(case, &a, &b)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:248:31 [INFO] [stdout] | [INFO] [stdout] 248 | prop_order_antisymm(case, &a, &c)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:248:35 [INFO] [stdout] | [INFO] [stdout] 248 | prop_order_antisymm(case, &a, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:249:31 [INFO] [stdout] | [INFO] [stdout] 249 | prop_order_antisymm(case, &b, &c)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:249:35 [INFO] [stdout] | [INFO] [stdout] 249 | prop_order_antisymm(case, &b, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:250:31 [INFO] [stdout] | [INFO] [stdout] 250 | prop_order_antisymm(case, &a, &a)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:250:35 [INFO] [stdout] | [INFO] [stdout] 250 | prop_order_antisymm(case, &a, &a)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:251:31 [INFO] [stdout] | [INFO] [stdout] 251 | prop_order_antisymm(case, &b, &b)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:251:35 [INFO] [stdout] | [INFO] [stdout] 251 | prop_order_antisymm(case, &b, &b)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:252:31 [INFO] [stdout] | [INFO] [stdout] 252 | prop_order_antisymm(case, &c, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:252:35 [INFO] [stdout] | [INFO] [stdout] 252 | prop_order_antisymm(case, &c, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:254:28 [INFO] [stdout] | [INFO] [stdout] 254 | prop_order_trans(case, &a, &b, &c)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:254:32 [INFO] [stdout] | [INFO] [stdout] 254 | prop_order_trans(case, &a, &b, &c)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:254:36 [INFO] [stdout] | [INFO] [stdout] 254 | prop_order_trans(case, &a, &b, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:255:28 [INFO] [stdout] | [INFO] [stdout] 255 | prop_order_trans(case, &a, &c, &b)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:255:32 [INFO] [stdout] | [INFO] [stdout] 255 | prop_order_trans(case, &a, &c, &b)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:255:36 [INFO] [stdout] | [INFO] [stdout] 255 | prop_order_trans(case, &a, &c, &b)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:256:28 [INFO] [stdout] | [INFO] [stdout] 256 | prop_order_trans(case, &b, &a, &c)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:256:32 [INFO] [stdout] | [INFO] [stdout] 256 | prop_order_trans(case, &b, &a, &c)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:256:36 [INFO] [stdout] | [INFO] [stdout] 256 | prop_order_trans(case, &b, &a, &c)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:257:28 [INFO] [stdout] | [INFO] [stdout] 257 | prop_order_trans(case, &b, &c, &a)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:257:32 [INFO] [stdout] | [INFO] [stdout] 257 | prop_order_trans(case, &b, &c, &a)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:257:36 [INFO] [stdout] | [INFO] [stdout] 257 | prop_order_trans(case, &b, &c, &a)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:258:28 [INFO] [stdout] | [INFO] [stdout] 258 | prop_order_trans(case, &c, &b, &a)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:258:32 [INFO] [stdout] | [INFO] [stdout] 258 | prop_order_trans(case, &c, &b, &a)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:258:36 [INFO] [stdout] | [INFO] [stdout] 258 | prop_order_trans(case, &c, &b, &a)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:259:28 [INFO] [stdout] | [INFO] [stdout] 259 | prop_order_trans(case, &c, &a, &b)?; [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:259:32 [INFO] [stdout] | [INFO] [stdout] 259 | prop_order_trans(case, &c, &a, &b)?; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/proptests.rs:259:36 [INFO] [stdout] | [INFO] [stdout] 259 | prop_order_trans(case, &c, &a, &b)?; [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/proptests.rs:325:24 [INFO] [stdout] | [INFO] [stdout] 325 | (E{value:a.map(|x| BitSetWrapper(x))}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple struct itself: `BitSetWrapper` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/proptests.rs:326:24 [INFO] [stdout] | [INFO] [stdout] 326 | E{value:b.map(|x| BitSetWrapper(x))}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple struct itself: `BitSetWrapper` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/proptests.rs:327:24 [INFO] [stdout] | [INFO] [stdout] 327 | E{value:c.map(|x| BitSetWrapper(x))}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple struct itself: `BitSetWrapper` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/proptests.rs:369:19 [INFO] [stdout] | [INFO] [stdout] 369 | tmp.entry(k.clone()) [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `LatticeElt>` which implements the `Copy` trait [INFO] [stdout] --> src/proptests.rs:371:24 [INFO] [stdout] | [INFO] [stdout] 371 | .or_insert(v.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/manualtests.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | assert!(!(singleton <= empty)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(singleton > empty)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.82s [INFO] running `Command { std: "docker" "inspect" "42505bf2d911a1a5b88cbd23e4bc78e1fabb113f6bab2ccb2ebaf61924cc5924", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42505bf2d911a1a5b88cbd23e4bc78e1fabb113f6bab2ccb2ebaf61924cc5924", kill_on_drop: false }` [INFO] [stdout] 42505bf2d911a1a5b88cbd23e4bc78e1fabb113f6bab2ccb2ebaf61924cc5924