[INFO] fetching crate pep440 0.2.0...
[INFO] linting pep440-0.2.0 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate pep440 0.2.0 into /workspace/builds/worker-3-tc1/source
[INFO] started tweaking crates.io crate pep440 0.2.0
[INFO] finished tweaking crates.io crate pep440 0.2.0
[INFO] tweaked toml for crates.io crate pep440 0.2.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate pep440 0.2.0 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 6 packages to latest compatible versions
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 55a724fb6346bd2ea628f4f16eb2a5b1abf49fac3a0989654954220a775118d7
[INFO] running `Command { std: "docker" "start" "-a" "55a724fb6346bd2ea628f4f16eb2a5b1abf49fac3a0989654954220a775118d7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "55a724fb6346bd2ea628f4f16eb2a5b1abf49fac3a0989654954220a775118d7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "55a724fb6346bd2ea628f4f16eb2a5b1abf49fac3a0989654954220a775118d7", kill_on_drop: false }`
[INFO] [stdout] 55a724fb6346bd2ea628f4f16eb2a5b1abf49fac3a0989654954220a775118d7
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c6620a4cc927626251292e9cfe0db1a48fb0009c75c151409df536f2ad7c3112
[INFO] running `Command { std: "docker" "start" "-a" "c6620a4cc927626251292e9cfe0db1a48fb0009c75c151409df536f2ad7c3112", kill_on_drop: false }`
[INFO] [stderr]     Checking pep440 v0.2.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:151:29
[INFO] [stdout]     |
[INFO] [stdout] 151 |                       None => match captures.name("post_l") {
[INFO] [stdout]     |  _____________________________^
[INFO] [stdout] 152 | |                         // "1.2.3.post" -- default 0 in this case
[INFO] [stdout] 153 | |                         Some(_) => Some(0),
[INFO] [stdout] 154 | |                         None => None
[INFO] [stdout] 155 | |                     }
[INFO] [stdout]     | |_____________________^ help: try: `captures.name("post_l").map(|_| 0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:151:29
[INFO] [stdout]     |
[INFO] [stdout] 151 |                       None => match captures.name("post_l") {
[INFO] [stdout]     |  _____________________________^
[INFO] [stdout] 152 | |                         // "1.2.3.post" -- default 0 in this case
[INFO] [stdout] 153 | |                         Some(_) => Some(0),
[INFO] [stdout] 154 | |                         None => None
[INFO] [stdout] 155 | |                     }
[INFO] [stdout]     | |_____________________^ help: try: `captures.name("post_l").map(|_| 0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/lib.rs:452:16
[INFO] [stdout]     |
[INFO] [stdout] 452 |     fn cmp_key(&self) -> CmpKey {
[INFO] [stdout]     |                ^^^^^     ^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                |
[INFO] [stdout]     |                the lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 452 |     fn cmp_key(&self) -> CmpKey<'_> {
[INFO] [stdout]     |                                ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/lib.rs:452:16
[INFO] [stdout]     |
[INFO] [stdout] 452 |     fn cmp_key(&self) -> CmpKey {
[INFO] [stdout]     |                ^^^^^     ^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                |
[INFO] [stdout]     |                the lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 452 |     fn cmp_key(&self) -> CmpKey<'_> {
[INFO] [stdout]     |                                ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> tests/test_comparison.rs:15:9
[INFO] [stdout]    |
[INFO] [stdout] 15 |         return 0;
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 15 -         return 0;
[INFO] [stdout] 15 +         0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `split.get(0)`
[INFO] [stdout]   --> tests/test_comparison.rs:39:17
[INFO] [stdout]    |
[INFO] [stdout] 39 |         let x = split.get(0).expect("Malformed input");
[INFO] [stdout]    |                 ^^^^^^^^^^^^ help: try: `split.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]    = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function call inside of `expect`
[INFO] [stdout]   --> tests/test_comparison.rs:43:39
[INFO] [stdout]    |
[INFO] [stdout] 43 |         let x_ver = Version::parse(x).expect(&format!("Could not parse LHS version: {}", x));
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Could not parse LHS version: {}", x))`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stdout]    = note: `#[warn(clippy::expect_fun_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function call inside of `expect`
[INFO] [stdout]   --> tests/test_comparison.rs:44:39
[INFO] [stdout]    |
[INFO] [stdout] 44 |         let y_ver = Version::parse(y).expect(&format!("Could not parse RHS version: {}", y));
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Could not parse RHS version: {}", y))`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you don't need to add `&` to all patterns
[INFO] [stdout]   --> tests/test_comparison.rs:46:9
[INFO] [stdout]    |
[INFO] [stdout] 46 | /         match op {
[INFO] [stdout] 47 | |             &">" => assert!(x_ver > y_ver, "Failed: {} > {}", x_ver, y_ver),
[INFO] [stdout] 48 | |             &">=" => assert!(x_ver >= y_ver, "Failed: {} >= {}", x_ver, y_ver),
[INFO] [stdout] 49 | |             &"<" => assert!(x_ver < y_ver, "Failed: {} < {}", x_ver, y_ver),
[INFO] [stdout] ...  |
[INFO] [stdout] 65 | |             _ => panic!("Operator did not make sense: {}", op),
[INFO] [stdout] 66 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stdout]    = note: `#[warn(clippy::match_ref_pats)]` on by default
[INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stdout]    |
[INFO] [stdout] 46 ~         match *op {
[INFO] [stdout] 47 ~             ">" => assert!(x_ver > y_ver, "Failed: {} > {}", x_ver, y_ver),
[INFO] [stdout] 48 ~             ">=" => assert!(x_ver >= y_ver, "Failed: {} >= {}", x_ver, y_ver),
[INFO] [stdout] 49 ~             "<" => assert!(x_ver < y_ver, "Failed: {} < {}", x_ver, y_ver),
[INFO] [stdout] 50 ~             "<=" => assert!(x_ver <= y_ver, "Failed: {} <= {}", x_ver, y_ver),
[INFO] [stdout] 51 ~             "==" => {
[INFO] [stdout] 52 |                 assert!(&x_ver == &y_ver, "Failed: {} == {}", x_ver, y_ver);
[INFO] [stdout] ...
[INFO] [stdout] 57 |             },
[INFO] [stdout] 58 ~             "!=" => {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needlessly taken reference of both operands
[INFO] [stdout]   --> tests/test_comparison.rs:52:25
[INFO] [stdout]    |
[INFO] [stdout] 52 |                 assert!(&x_ver == &y_ver, "Failed: {} == {}", x_ver, y_ver);
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stdout]    = note: `#[warn(clippy::op_ref)]` on by default
[INFO] [stdout] help: use the values directly
[INFO] [stdout]    |
[INFO] [stdout] 52 -                 assert!(&x_ver == &y_ver, "Failed: {} == {}", x_ver, y_ver);
[INFO] [stdout] 52 +                 assert!(x_ver == y_ver, "Failed: {} == {}", x_ver, y_ver);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> tests/test_comparison.rs:87:17
[INFO] [stdout]    |
[INFO] [stdout] 87 |         assert!(!(a_ver != b_ver));
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^ help: try: `(a_ver == b_ver)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> tests/test_comparison.rs:88:17
[INFO] [stdout]    |
[INFO] [stdout] 88 |         assert!(!(a_ver < b_ver));
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^ help: try: `(a_ver >= b_ver)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> tests/test_comparison.rs:89:17
[INFO] [stdout]    |
[INFO] [stdout] 89 |         assert!(!(a_ver > b_ver));
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^ help: try: `(a_ver <= b_ver)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.36s
[INFO] running `Command { std: "docker" "inspect" "c6620a4cc927626251292e9cfe0db1a48fb0009c75c151409df536f2ad7c3112", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c6620a4cc927626251292e9cfe0db1a48fb0009c75c151409df536f2ad7c3112", kill_on_drop: false }`
[INFO] [stdout] c6620a4cc927626251292e9cfe0db1a48fb0009c75c151409df536f2ad7c3112