[INFO] fetching crate pcp-mutex 0.2.0... [INFO] linting pcp-mutex-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pcp-mutex 0.2.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate pcp-mutex 0.2.0 [INFO] finished tweaking crates.io crate pcp-mutex 0.2.0 [INFO] tweaked toml for crates.io crate pcp-mutex 0.2.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pcp-mutex 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate pcp-mutex 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded linux-futex v0.1.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6361245f0403d3aa64f4fd8a828602422319557cc47c991864133000393075ea [INFO] running `Command { std: "docker" "start" "-a" "6361245f0403d3aa64f4fd8a828602422319557cc47c991864133000393075ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6361245f0403d3aa64f4fd8a828602422319557cc47c991864133000393075ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6361245f0403d3aa64f4fd8a828602422319557cc47c991864133000393075ea", kill_on_drop: false }` [INFO] [stdout] 6361245f0403d3aa64f4fd8a828602422319557cc47c991864133000393075ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d10e47fc36a4fa8c99ee5f0c00830d9ed37925bc629e7c3fcd32d31adf814140 [INFO] running `Command { std: "docker" "start" "-a" "d10e47fc36a4fa8c99ee5f0c00830d9ed37925bc629e7c3fcd32d31adf814140", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Checking linux-futex v0.1.1 [INFO] [stderr] Checking pcp-mutex v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/lib.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 47 | _non_send: PhantomData::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 47 - _non_send: PhantomData::default(), [INFO] [stdout] 47 + _non_send: PhantomData, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 134 | group: &self, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:208:15 [INFO] [stdout] | [INFO] [stdout] 208 | while !BLOCKED_LOCKER.futex.lock_pi().is_ok() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `BLOCKED_LOCKER.futex.lock_pi().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:224:11 [INFO] [stdout] | [INFO] [stdout] 224 | while !ptr [INFO] [stdout] | ___________^ [INFO] [stdout] 225 | | .compare_exchange(blocked_ptr, highest_ptr, Release, Relaxed) [INFO] [stdout] 226 | | .is_ok() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 224 ~ while ptr [INFO] [stdout] 225 + .compare_exchange(blocked_ptr, highest_ptr, Release, Relaxed).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a reference to a pointer [INFO] [stdout] --> src/lib.rs:211:32 [INFO] [stdout] | [INFO] [stdout] 211 | let blocked_ptr = unsafe { core::mem::transmute(&*BLOCKED_LOCKER) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*BLOCKED_LOCKER as *const PcpMutexLock as *mut PcpMutexLock` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] = note: `#[warn(clippy::useless_transmute)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:287:31 [INFO] [stdout] | [INFO] [stdout] 287 | while !self.lock.futex.lock_pi().is_ok() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.lock.futex.lock_pi().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:362:23 [INFO] [stdout] | [INFO] [stdout] 362 | while !highest.futex.lock_pi().is_ok() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `highest.futex.lock_pi().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/lib.rs:260:44 [INFO] [stdout] | [INFO] [stdout] 260 | let self_ptr = unsafe { core::mem::transmute(Arc::as_ptr(&self.lock)) }; [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<*const PcpMutexLock, *mut PcpMutexLock>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/lib.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 47 | _non_send: PhantomData::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 47 - _non_send: PhantomData::default(), [INFO] [stdout] 47 + _non_send: PhantomData, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 134 | group: &self, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:208:15 [INFO] [stdout] | [INFO] [stdout] 208 | while !BLOCKED_LOCKER.futex.lock_pi().is_ok() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `BLOCKED_LOCKER.futex.lock_pi().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:224:11 [INFO] [stdout] | [INFO] [stdout] 224 | while !ptr [INFO] [stdout] | ___________^ [INFO] [stdout] 225 | | .compare_exchange(blocked_ptr, highest_ptr, Release, Relaxed) [INFO] [stdout] 226 | | .is_ok() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 224 ~ while ptr [INFO] [stdout] 225 + .compare_exchange(blocked_ptr, highest_ptr, Release, Relaxed).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a reference to a pointer [INFO] [stdout] --> src/lib.rs:211:32 [INFO] [stdout] | [INFO] [stdout] 211 | let blocked_ptr = unsafe { core::mem::transmute(&*BLOCKED_LOCKER) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*BLOCKED_LOCKER as *const PcpMutexLock as *mut PcpMutexLock` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] = note: `#[warn(clippy::useless_transmute)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:287:31 [INFO] [stdout] | [INFO] [stdout] 287 | while !self.lock.futex.lock_pi().is_ok() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.lock.futex.lock_pi().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:362:23 [INFO] [stdout] | [INFO] [stdout] 362 | while !highest.futex.lock_pi().is_ok() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `highest.futex.lock_pi().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/lib.rs:260:44 [INFO] [stdout] | [INFO] [stdout] 260 | let self_ptr = unsafe { core::mem::transmute(Arc::as_ptr(&self.lock)) }; [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<*const PcpMutexLock, *mut PcpMutexLock>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.40s [INFO] running `Command { std: "docker" "inspect" "d10e47fc36a4fa8c99ee5f0c00830d9ed37925bc629e7c3fcd32d31adf814140", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d10e47fc36a4fa8c99ee5f0c00830d9ed37925bc629e7c3fcd32d31adf814140", kill_on_drop: false }` [INFO] [stdout] d10e47fc36a4fa8c99ee5f0c00830d9ed37925bc629e7c3fcd32d31adf814140