[INFO] fetching crate pathmut 0.8.0... [INFO] linting pathmut-0.8.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pathmut 0.8.0 into /workspace/builds/worker-7-tc1/source [INFO] removed /workspace/builds/worker-7-tc1/source/rust-toolchain.toml [INFO] started tweaking crates.io crate pathmut 0.8.0 [INFO] finished tweaking crates.io crate pathmut 0.8.0 [INFO] tweaked toml for crates.io crate pathmut 0.8.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pathmut 0.8.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate pathmut 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rstest_reuse v0.7.0 [INFO] [stderr] Downloaded typed-path v0.10.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ece670809ddea0612372b862231b9d5edc7ce7f05caee26d538c75c600c16280 [INFO] running `Command { std: "docker" "start" "-a" "ece670809ddea0612372b862231b9d5edc7ce7f05caee26d538c75c600c16280", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ece670809ddea0612372b862231b9d5edc7ce7f05caee26d538c75c600c16280", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ece670809ddea0612372b862231b9d5edc7ce7f05caee26d538c75c600c16280", kill_on_drop: false }` [INFO] [stdout] ece670809ddea0612372b862231b9d5edc7ce7f05caee26d538c75c600c16280 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 43965d02454ffb8fc888e976ef6b27f2eaab50c6be5d16a620eb965047bb7043 [INFO] running `Command { std: "docker" "start" "-a" "43965d02454ffb8fc888e976ef6b27f2eaab50c6be5d16a620eb965047bb7043", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling zerocopy v0.8.33 [INFO] [stderr] Compiling toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Compiling rstest_macros v0.26.1 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Compiling assert_cmd v2.1.2 [INFO] [stderr] Checking typed-path v0.10.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling getrandom v0.2.17 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking terminal_size v0.4.3 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Compiling rstest_reuse v0.7.0 [INFO] [stderr] Checking pathmut v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/path.rs:776:17 [INFO] [stdout] | [INFO] [stdout] 776 | / if !self.segments.is_empty() { [INFO] [stdout] 777 | | self.segments.last_mut().unwrap().set_extension(new_value); [INFO] [stdout] 778 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 775 ~ (Extension, _) [INFO] [stdout] 776 ~ if !self.segments.is_empty() => { [INFO] [stdout] 777 | self.segments.last_mut().unwrap().set_extension(new_value); [INFO] [stdout] 778 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/path.rs:781:17 [INFO] [stdout] | [INFO] [stdout] 781 | / if !self.segments.is_empty() { [INFO] [stdout] 782 | | self.segments.last_mut().unwrap().set_stem(new_value); [INFO] [stdout] 783 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 780 ~ (Stem, _) [INFO] [stdout] 781 ~ if !self.segments.is_empty() => { [INFO] [stdout] 782 | self.segments.last_mut().unwrap().set_stem(new_value); [INFO] [stdout] 783 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/path.rs:789:17 [INFO] [stdout] | [INFO] [stdout] 789 | / if !self.segments.is_empty() { [INFO] [stdout] 790 | | self.segments.last_mut().unwrap().set_prefix(new_value); [INFO] [stdout] 791 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 788 ~ (FilePrefix, _) [INFO] [stdout] 789 ~ if !self.segments.is_empty() => { [INFO] [stdout] 790 | self.segments.last_mut().unwrap().set_prefix(new_value); [INFO] [stdout] 791 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iter_intersperse` is declared but not used [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(iter_intersperse)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:195:57 [INFO] [stdout] | [INFO] [stdout] 195 | ... || path.is_windows() && path.get(Component::Disk).len() > 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!path.get(Component::Disk).is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:199:57 [INFO] [stdout] | [INFO] [stdout] 199 | ... || path.is_windows() && path.get(Component::Disk).len() > 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!path.get(Component::Disk).is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:202:29 [INFO] [stdout] | [INFO] [stdout] 202 | / ... !path.serialize().starts_with('/') [INFO] [stdout] 203 | | ... && !(path.is_windows() && path.get(Component::Disk).len() > 0) [INFO] [stdout] | |________________________________________________________________________________________^ help: try: `!(path.serialize().starts_with('/') || path.is_windows() && path.get(Component::Disk).len() > 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:203:59 [INFO] [stdout] | [INFO] [stdout] 203 | ... && !(path.is_windows() && path.get(Component::Disk).len() > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!path.get(Component::Disk).is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 206 | / ... !path.serialize().starts_with('/') [INFO] [stdout] 207 | | ... && !(path.is_windows() && path.get(Component::Disk).len() > 0) [INFO] [stdout] | |________________________________________________________________________________________^ help: try: `!(path.serialize().starts_with('/') || path.is_windows() && path.get(Component::Disk).len() > 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:207:59 [INFO] [stdout] | [INFO] [stdout] 207 | ... && !(path.is_windows() && path.get(Component::Disk).len() > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!path.get(Component::Disk).is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rstest v0.26.1 [INFO] [stdout] warning: use of deprecated associated function `assert_cmd::Command::cargo_bin`: incompatible with a custom cargo build-dir, see instead `cargo::cargo_bin_cmd!` [INFO] [stdout] --> src/main.rs:333:18 [INFO] [stdout] | [INFO] [stdout] 333 | Command::cargo_bin("pathmut").unwrap().args(args).assert() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `assert_cmd::Command::cargo_bin`: incompatible with a custom cargo build-dir, see instead `cargo::cargo_bin_cmd!` [INFO] [stdout] --> src/main.rs:337:31 [INFO] [stdout] | [INFO] [stdout] 337 | let output = Command::cargo_bin("pathmut") [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `assert_cmd::Command::cargo_bin`: incompatible with a custom cargo build-dir, see instead `cargo::cargo_bin_cmd!` [INFO] [stdout] --> src/main.rs:686:18 [INFO] [stdout] | [INFO] [stdout] 686 | Command::cargo_bin("pathmut") [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:195:57 [INFO] [stdout] | [INFO] [stdout] 195 | ... || path.is_windows() && path.get(Component::Disk).len() > 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!path.get(Component::Disk).is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:199:57 [INFO] [stdout] | [INFO] [stdout] 199 | ... || path.is_windows() && path.get(Component::Disk).len() > 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!path.get(Component::Disk).is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:202:29 [INFO] [stdout] | [INFO] [stdout] 202 | / ... !path.serialize().starts_with('/') [INFO] [stdout] 203 | | ... && !(path.is_windows() && path.get(Component::Disk).len() > 0) [INFO] [stdout] | |________________________________________________________________________________________^ help: try: `!(path.serialize().starts_with('/') || path.is_windows() && path.get(Component::Disk).len() > 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:203:59 [INFO] [stdout] | [INFO] [stdout] 203 | ... && !(path.is_windows() && path.get(Component::Disk).len() > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!path.get(Component::Disk).is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 206 | / ... !path.serialize().starts_with('/') [INFO] [stdout] 207 | | ... && !(path.is_windows() && path.get(Component::Disk).len() > 0) [INFO] [stdout] | |________________________________________________________________________________________^ help: try: `!(path.serialize().starts_with('/') || path.is_windows() && path.get(Component::Disk).len() > 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:207:59 [INFO] [stdout] | [INFO] [stdout] 207 | ... && !(path.is_windows() && path.get(Component::Disk).len() > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!path.get(Component::Disk).is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/path.rs:776:17 [INFO] [stdout] | [INFO] [stdout] 776 | / if !self.segments.is_empty() { [INFO] [stdout] 777 | | self.segments.last_mut().unwrap().set_extension(new_value); [INFO] [stdout] 778 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 775 ~ (Extension, _) [INFO] [stdout] 776 ~ if !self.segments.is_empty() => { [INFO] [stdout] 777 | self.segments.last_mut().unwrap().set_extension(new_value); [INFO] [stdout] 778 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/path.rs:781:17 [INFO] [stdout] | [INFO] [stdout] 781 | / if !self.segments.is_empty() { [INFO] [stdout] 782 | | self.segments.last_mut().unwrap().set_stem(new_value); [INFO] [stdout] 783 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 780 ~ (Stem, _) [INFO] [stdout] 781 ~ if !self.segments.is_empty() => { [INFO] [stdout] 782 | self.segments.last_mut().unwrap().set_stem(new_value); [INFO] [stdout] 783 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/path.rs:789:17 [INFO] [stdout] | [INFO] [stdout] 789 | / if !self.segments.is_empty() { [INFO] [stdout] 790 | | self.segments.last_mut().unwrap().set_prefix(new_value); [INFO] [stdout] 791 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 788 ~ (FilePrefix, _) [INFO] [stdout] 789 ~ if !self.segments.is_empty() => { [INFO] [stdout] 790 | self.segments.last_mut().unwrap().set_prefix(new_value); [INFO] [stdout] 791 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iter_intersperse` is declared but not used [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(iter_intersperse)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.62s [INFO] running `Command { std: "docker" "inspect" "43965d02454ffb8fc888e976ef6b27f2eaab50c6be5d16a620eb965047bb7043", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43965d02454ffb8fc888e976ef6b27f2eaab50c6be5d16a620eb965047bb7043", kill_on_drop: false }` [INFO] [stdout] 43965d02454ffb8fc888e976ef6b27f2eaab50c6be5d16a620eb965047bb7043