[INFO] fetching crate patch-release-me 0.6.5... [INFO] linting patch-release-me-0.6.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate patch-release-me 0.6.5 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate patch-release-me 0.6.5 [INFO] finished tweaking crates.io crate patch-release-me 0.6.5 [INFO] tweaked toml for crates.io crate patch-release-me 0.6.5 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate patch-release-me 0.6.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate patch-release-me 0.6.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 87f5c4dc9a185c02a5031950b5f38099867d5332e2ad6c5199d9d41857d0a9ff [INFO] running `Command { std: "docker" "start" "-a" "87f5c4dc9a185c02a5031950b5f38099867d5332e2ad6c5199d9d41857d0a9ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "87f5c4dc9a185c02a5031950b5f38099867d5332e2ad6c5199d9d41857d0a9ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87f5c4dc9a185c02a5031950b5f38099867d5332e2ad6c5199d9d41857d0a9ff", kill_on_drop: false }` [INFO] [stdout] 87f5c4dc9a185c02a5031950b5f38099867d5332e2ad6c5199d9d41857d0a9ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b775713d6c9737c6f77ab5acd5cc33882e6133671421a0660d691e05450e53f2 [INFO] running `Command { std: "docker" "start" "-a" "b775713d6c9737c6f77ab5acd5cc33882e6133671421a0660d691e05450e53f2", kill_on_drop: false }` [INFO] [stderr] Compiling portable-atomic v1.13.1 [INFO] [stderr] Checking console v0.16.2 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling syn v2.0.116 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Checking jiff v0.2.20 [INFO] [stderr] Checking unit-prefix v0.5.2 [INFO] [stderr] Checking semver v1.0.27 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking dialoguer v0.12.0 [INFO] [stderr] Checking indicatif v0.18.4 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking patch-release-me v0.6.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:125:23 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn load(root: &PathBuf, path: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 125 - pub fn load(root: &PathBuf, path: &PathBuf) -> Result { [INFO] [stdout] 125 + pub fn load(root: &Path, path: &PathBuf) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/defaults.rs:20:41 [INFO] [stdout] | [INFO] [stdout] 20 | Ok(serde_yaml::from_str::(&DEFAULTS)?) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `DEFAULTS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interactive.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !config.version.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.version.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/interactive.rs:111:30 [INFO] [stdout] | [INFO] [stdout] 111 | .filter_map(|(i, &ref lang)| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 111 - .filter_map(|(i, &ref lang)| { [INFO] [stdout] 111 + .filter_map(|(i, lang)| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:125:23 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn load(root: &PathBuf, path: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 125 - pub fn load(root: &PathBuf, path: &PathBuf) -> Result { [INFO] [stdout] 125 + pub fn load(root: &Path, path: &PathBuf) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/defaults.rs:20:41 [INFO] [stdout] | [INFO] [stdout] 20 | Ok(serde_yaml::from_str::(&DEFAULTS)?) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `DEFAULTS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interactive.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !config.version.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.version.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/interactive.rs:111:30 [INFO] [stdout] | [INFO] [stdout] 111 | .filter_map(|(i, &ref lang)| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 111 - .filter_map(|(i, &ref lang)| { [INFO] [stdout] 111 + .filter_map(|(i, lang)| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.02s [INFO] running `Command { std: "docker" "inspect" "b775713d6c9737c6f77ab5acd5cc33882e6133671421a0660d691e05450e53f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b775713d6c9737c6f77ab5acd5cc33882e6133671421a0660d691e05450e53f2", kill_on_drop: false }` [INFO] [stdout] b775713d6c9737c6f77ab5acd5cc33882e6133671421a0660d691e05450e53f2