[INFO] fetching crate pash 0.3.0... [INFO] linting pash-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pash 0.3.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate pash 0.3.0 [INFO] finished tweaking crates.io crate pash 0.3.0 [INFO] tweaked toml for crates.io crate pash 0.3.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pash 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate pash 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anyhow v1.0.40 [INFO] [stderr] Downloaded syn v1.0.70 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c81e0e2e20305250b7ab4d605cd0f4986063a04e69b625b645db8229db908f8a [INFO] running `Command { std: "docker" "start" "-a" "c81e0e2e20305250b7ab4d605cd0f4986063a04e69b625b645db8229db908f8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c81e0e2e20305250b7ab4d605cd0f4986063a04e69b625b645db8229db908f8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c81e0e2e20305250b7ab4d605cd0f4986063a04e69b625b645db8229db908f8a", kill_on_drop: false }` [INFO] [stdout] c81e0e2e20305250b7ab4d605cd0f4986063a04e69b625b645db8229db908f8a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 314cb7b35feed751a9076267a66bb951c7aa961fedac26c2ccaeec872287d49b [INFO] running `Command { std: "docker" "start" "-a" "314cb7b35feed751a9076267a66bb951c7aa961fedac26c2ccaeec872287d49b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling syn v1.0.70 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking pash v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/files/edit.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / pub fn default() -> Result { [INFO] [stdout] 25 | | let paths_list = FilePaths::default().context("Failed to fetch default paths")?; [INFO] [stdout] 26 | | let config_file = fs::OpenOptions::new() [INFO] [stdout] 27 | | .read(true) [INFO] [stdout] ... | [INFO] [stdout] 39 | | }) [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/files/view.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 44 | && !(line [INFO] [stdout] | ____________________^ [INFO] [stdout] 45 | | .chars() [INFO] [stdout] 46 | | .nth(0) [INFO] [stdout] 47 | | .context("Failed to get first character of line")? [INFO] [stdout] 48 | | == '[') [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 44 ~ && (line [INFO] [stdout] 45 + .chars() [INFO] [stdout] 46 + .nth(0) [INFO] [stdout] 47 + .context("Failed to get first character of line")? != '[') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/files/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn default() -> Result { [INFO] [stdout] 23 | | #[cfg(target_os = "linux")] [INFO] [stdout] 24 | | let folder_path: String = format!( [INFO] [stdout] 25 | | "{}/.config/pash", [INFO] [stdout] ... | [INFO] [stdout] 41 | | }) [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/files/edit.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / pub fn default() -> Result { [INFO] [stdout] 25 | | let paths_list = FilePaths::default().context("Failed to fetch default paths")?; [INFO] [stdout] 26 | | let config_file = fs::OpenOptions::new() [INFO] [stdout] 27 | | .read(true) [INFO] [stdout] ... | [INFO] [stdout] 39 | | }) [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/files/view.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 44 | && !(line [INFO] [stdout] | ____________________^ [INFO] [stdout] 45 | | .chars() [INFO] [stdout] 46 | | .nth(0) [INFO] [stdout] 47 | | .context("Failed to get first character of line")? [INFO] [stdout] 48 | | == '[') [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 44 ~ && (line [INFO] [stdout] 45 + .chars() [INFO] [stdout] 46 + .nth(0) [INFO] [stdout] 47 + .context("Failed to get first character of line")? != '[') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/files/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn default() -> Result { [INFO] [stdout] 23 | | #[cfg(target_os = "linux")] [INFO] [stdout] 24 | | let folder_path: String = format!( [INFO] [stdout] 25 | | "{}/.config/pash", [INFO] [stdout] ... | [INFO] [stdout] 41 | | }) [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.38s [INFO] running `Command { std: "docker" "inspect" "314cb7b35feed751a9076267a66bb951c7aa961fedac26c2ccaeec872287d49b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "314cb7b35feed751a9076267a66bb951c7aa961fedac26c2ccaeec872287d49b", kill_on_drop: false }` [INFO] [stdout] 314cb7b35feed751a9076267a66bb951c7aa961fedac26c2ccaeec872287d49b