[INFO] fetching crate partners 0.2.1... [INFO] linting partners-0.2.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate partners 0.2.1 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate partners 0.2.1 [INFO] finished tweaking crates.io crate partners 0.2.1 [INFO] tweaked toml for crates.io crate partners 0.2.1 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate partners 0.2.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 39 packages to latest compatible versions [INFO] [stderr] Adding clap v2.34.0 (available: v4.6.0) [INFO] [stderr] Adding derive-error v0.0.3 (available: v0.0.5) [INFO] [stderr] Adding docopt v0.6.86 (available: v1.1.1) [INFO] [stderr] Adding termion v1.5.6 (available: v4.0.6) [INFO] [stderr] Adding xdg v2.5.2 (available: v3.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded strsim v0.5.2 [INFO] [stderr] Downloaded case v0.1.0 [INFO] [stderr] Downloaded derive-error v0.0.3 [INFO] [stderr] Downloaded docopt v0.6.86 [INFO] [stderr] Downloaded yaml-rust v0.3.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 622acec52424df8fab764b75cdba4cdfddc3020c366a7fde4e5952843c93f308 [INFO] running `Command { std: "docker" "start" "-a" "622acec52424df8fab764b75cdba4cdfddc3020c366a7fde4e5952843c93f308", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "622acec52424df8fab764b75cdba4cdfddc3020c366a7fde4e5952843c93f308", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "622acec52424df8fab764b75cdba4cdfddc3020c366a7fde4e5952843c93f308", kill_on_drop: false }` [INFO] [stdout] 622acec52424df8fab764b75cdba4cdfddc3020c366a7fde4e5952843c93f308 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c54e7a161c506b27feb90b12ebdd623efd9dc2f29572ff00124564180c418011 [INFO] running `Command { std: "docker" "start" "-a" "c54e7a161c506b27feb90b12ebdd623efd9dc2f29572ff00124564180c418011", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Compiling case v0.1.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.5.2 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling derive-error v0.0.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking docopt v0.6.86 [INFO] [stderr] Checking partners v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git.rs:105:25 [INFO] [stdout] | [INFO] [stdout] 105 | Ok(Author { nick: nick, name: name, email: email }) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `nick` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git.rs:105:37 [INFO] [stdout] | [INFO] [stdout] 105 | Ok(Author { nick: nick, name: name, email: email }) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git.rs:105:49 [INFO] [stdout] | [INFO] [stdout] 105 | Ok(Author { nick: nick, name: name, email: email }) [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 130 | Ok(Author { nick: nick, name: name, email: email }) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `nick` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git.rs:130:33 [INFO] [stdout] | [INFO] [stdout] 130 | Ok(Author { nick: nick, name: name, email: email }) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git.rs:130:45 [INFO] [stdout] | [INFO] [stdout] 130 | Ok(Author { nick: nick, name: name, email: email }) [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/author_selection.rs:17:34 [INFO] [stdout] | [INFO] [stdout] 17 | Ok(AuthorSelection { config: config, authors: authors }) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/author_selection.rs:17:50 [INFO] [stdout] | [INFO] [stdout] 17 | Ok(AuthorSelection { config: config, authors: authors }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `authors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/add.rs:12:27 [INFO] [stdout] | [INFO] [stdout] 12 | let author = Author { nick: nick, name: name, email: email }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `nick` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/add.rs:12:39 [INFO] [stdout] | [INFO] [stdout] 12 | let author = Author { nick: nick, name: name, email: email }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/add.rs:12:51 [INFO] [stdout] | [INFO] [stdout] 12 | let author = Author { nick: nick, name: name, email: email }; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/initial.rs:42:35 [INFO] [stdout] | [INFO] [stdout] 42 | let author = Author { nick: nick, name: name, email: email }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `nick` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/initial.rs:42:47 [INFO] [stdout] | [INFO] [stdout] 42 | let author = Author { nick: nick, name: name, email: email }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/initial.rs:42:59 [INFO] [stdout] | [INFO] [stdout] 42 | let author = Author { nick: nick, name: name, email: email }; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git.rs:105:25 [INFO] [stdout] | [INFO] [stdout] 105 | Ok(Author { nick: nick, name: name, email: email }) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `nick` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git.rs:105:37 [INFO] [stdout] | [INFO] [stdout] 105 | Ok(Author { nick: nick, name: name, email: email }) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git.rs:105:49 [INFO] [stdout] | [INFO] [stdout] 105 | Ok(Author { nick: nick, name: name, email: email }) [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 130 | Ok(Author { nick: nick, name: name, email: email }) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `nick` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git.rs:130:33 [INFO] [stdout] | [INFO] [stdout] 130 | Ok(Author { nick: nick, name: name, email: email }) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/git.rs:130:45 [INFO] [stdout] | [INFO] [stdout] 130 | Ok(Author { nick: nick, name: name, email: email }) [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/author_selection.rs:17:34 [INFO] [stdout] | [INFO] [stdout] 17 | Ok(AuthorSelection { config: config, authors: authors }) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/author_selection.rs:17:50 [INFO] [stdout] | [INFO] [stdout] 17 | Ok(AuthorSelection { config: config, authors: authors }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `authors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/add.rs:12:27 [INFO] [stdout] | [INFO] [stdout] 12 | let author = Author { nick: nick, name: name, email: email }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `nick` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/add.rs:12:39 [INFO] [stdout] | [INFO] [stdout] 12 | let author = Author { nick: nick, name: name, email: email }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/add.rs:12:51 [INFO] [stdout] | [INFO] [stdout] 12 | let author = Author { nick: nick, name: name, email: email }; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/initial.rs:42:35 [INFO] [stdout] | [INFO] [stdout] 42 | let author = Author { nick: nick, name: name, email: email }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `nick` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/initial.rs:42:47 [INFO] [stdout] | [INFO] [stdout] 42 | let author = Author { nick: nick, name: name, email: email }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/initial.rs:42:59 [INFO] [stdout] | [INFO] [stdout] 42 | let author = Author { nick: nick, name: name, email: email }; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/git.rs:134:69 [INFO] [stdout] | [INFO] [stdout] 134 | self.authors().ok().and_then(|val| val.into_iter().find(|a| &a.nick == nick)) [INFO] [stdout] | -------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `a.nick` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/git.rs:153:16 [INFO] [stdout] | [INFO] [stdout] 153 | if let Ok(_) = self.find_authors(&[nick]) { [INFO] [stdout] | -------^^^^^----------------------------- help: try: `if self.find_authors(&[nick]).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/author.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | / impl PartialOrd for Author { [INFO] [stdout] 18 | | fn partial_cmp(&self, other: &Author) -> Option { [INFO] [stdout] 19 | | self.nick.partial_cmp(&other.nick) [INFO] [stdout] 20 | | } [INFO] [stdout] 21 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 18 - fn partial_cmp(&self, other: &Author) -> Option { [INFO] [stdout] 19 - self.nick.partial_cmp(&other.nick) [INFO] [stdout] 20 - } [INFO] [stdout] 18 + fn partial_cmp(&self, other: &Author) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/author_selection.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | if authors.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `authors.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/commands/add.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn add<'a>(partners_config: &'a Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 7 - pub fn add<'a>(partners_config: &'a Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] 7 + pub fn add(partners_config: &Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/commands/current.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn current<'a>(_partners_config: &'a Config, _matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 5 - pub fn current<'a>(_partners_config: &'a Config, _matches: &ArgMatches) -> Result<()> { [INFO] [stdout] 5 + pub fn current(_partners_config: &Config, _matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/commands/delete.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn delete<'a>(partners_config: &'a Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 5 - pub fn delete<'a>(partners_config: &'a Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] 5 + pub fn delete(partners_config: &Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/initial.rs:16:41 [INFO] [stdout] | [INFO] [stdout] 16 | helpers::create_config_file(&config_path)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `config_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/commands/list.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn list<'a>(partners_config: &'a Config, _matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 5 - pub fn list<'a>(partners_config: &'a Config, _matches: &ArgMatches) -> Result<()> { [INFO] [stdout] 5 + pub fn list(partners_config: &Config, _matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/commands/set.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn set<'a>(partners_config: &'a Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 5 - pub fn set<'a>(partners_config: &'a Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] 5 + pub fn set(partners_config: &Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | Ok(line == "" || line == "y" || line == "y") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 - Ok(line == "" || line == "y" || line == "y") [INFO] [stdout] 18 + Ok(!(line != "" && line != "y")) [INFO] [stdout] | [INFO] [stdout] 18 - Ok(line == "" || line == "y" || line == "y") [INFO] [stdout] 18 + Ok(line == "" || line == "y") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/helpers.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | Ok(line == "" || line == "y" || line == "y") [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/helpers.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if value == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/helpers.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | writeln!(file, "")?; [INFO] [stdout] | ^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/commands/initial.rs:9:29 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn initial(config_path: &Path) -> Result { [INFO] [stdout] | ^^^^^ ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 9 | pub fn initial(config_path: &Path) -> Result> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/git.rs:134:69 [INFO] [stdout] | [INFO] [stdout] 134 | self.authors().ok().and_then(|val| val.into_iter().find(|a| &a.nick == nick)) [INFO] [stdout] | -------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `a.nick` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/git.rs:153:16 [INFO] [stdout] | [INFO] [stdout] 153 | if let Ok(_) = self.find_authors(&[nick]) { [INFO] [stdout] | -------^^^^^----------------------------- help: try: `if self.find_authors(&[nick]).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/author.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | / impl PartialOrd for Author { [INFO] [stdout] 18 | | fn partial_cmp(&self, other: &Author) -> Option { [INFO] [stdout] 19 | | self.nick.partial_cmp(&other.nick) [INFO] [stdout] 20 | | } [INFO] [stdout] 21 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 18 - fn partial_cmp(&self, other: &Author) -> Option { [INFO] [stdout] 19 - self.nick.partial_cmp(&other.nick) [INFO] [stdout] 20 - } [INFO] [stdout] 18 + fn partial_cmp(&self, other: &Author) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/author_selection.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | if authors.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `authors.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/commands/add.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn add<'a>(partners_config: &'a Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 7 - pub fn add<'a>(partners_config: &'a Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] 7 + pub fn add(partners_config: &Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/commands/current.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn current<'a>(_partners_config: &'a Config, _matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 5 - pub fn current<'a>(_partners_config: &'a Config, _matches: &ArgMatches) -> Result<()> { [INFO] [stdout] 5 + pub fn current(_partners_config: &Config, _matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/commands/delete.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn delete<'a>(partners_config: &'a Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 5 - pub fn delete<'a>(partners_config: &'a Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] 5 + pub fn delete(partners_config: &Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/initial.rs:16:41 [INFO] [stdout] | [INFO] [stdout] 16 | helpers::create_config_file(&config_path)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `config_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/commands/list.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn list<'a>(partners_config: &'a Config, _matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 5 - pub fn list<'a>(partners_config: &'a Config, _matches: &ArgMatches) -> Result<()> { [INFO] [stdout] 5 + pub fn list(partners_config: &Config, _matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/commands/set.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn set<'a>(partners_config: &'a Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 5 - pub fn set<'a>(partners_config: &'a Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] 5 + pub fn set(partners_config: &Config, matches: &ArgMatches) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | Ok(line == "" || line == "y" || line == "y") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 - Ok(line == "" || line == "y" || line == "y") [INFO] [stdout] 18 + Ok(!(line != "" && line != "y")) [INFO] [stdout] | [INFO] [stdout] 18 - Ok(line == "" || line == "y" || line == "y") [INFO] [stdout] 18 + Ok(line == "" || line == "y") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/helpers.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | Ok(line == "" || line == "y" || line == "y") [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/helpers.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if value == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/helpers.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | writeln!(file, "")?; [INFO] [stdout] | ^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/commands/initial.rs:9:29 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn initial(config_path: &Path) -> Result { [INFO] [stdout] | ^^^^^ ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 9 | pub fn initial(config_path: &Path) -> Result> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.86s [INFO] running `Command { std: "docker" "inspect" "c54e7a161c506b27feb90b12ebdd623efd9dc2f29572ff00124564180c418011", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c54e7a161c506b27feb90b12ebdd623efd9dc2f29572ff00124564180c418011", kill_on_drop: false }` [INFO] [stdout] c54e7a161c506b27feb90b12ebdd623efd9dc2f29572ff00124564180c418011