[INFO] fetching crate parserc 0.12.7... [INFO] linting parserc-0.12.7 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate parserc 0.12.7 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate parserc 0.12.7 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate parserc 0.12.7 [INFO] tweaked toml for crates.io crate parserc 0.12.7 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate parserc 0.12.7 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate parserc 0.12.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded parserc-derive v0.12.7 [INFO] [stderr] Downloaded sourcespan v0.12.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e1c9f7907c3dc4c47190fa37f8672ff2d60a00292233d53c6b4b3822081eda8c [INFO] running `Command { std: "docker" "start" "-a" "e1c9f7907c3dc4c47190fa37f8672ff2d60a00292233d53c6b4b3822081eda8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e1c9f7907c3dc4c47190fa37f8672ff2d60a00292233d53c6b4b3822081eda8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1c9f7907c3dc4c47190fa37f8672ff2d60a00292233d53c6b4b3822081eda8c", kill_on_drop: false }` [INFO] [stdout] e1c9f7907c3dc4c47190fa37f8672ff2d60a00292233d53c6b4b3822081eda8c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 44ac75b41ba86490b82b45bddb38bf6f2c52b33ea0f0ce2ef301881e3661c87c [INFO] running `Command { std: "docker" "start" "-a" "44ac75b41ba86490b82b45bddb38bf6f2c52b33ea0f0ce2ef301881e3661c87c", kill_on_drop: false }` [INFO] [stderr] Compiling convert_case v0.8.0 [INFO] [stderr] Compiling syn v2.0.110 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling parserc-derive v0.12.7 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking sourcespan v0.12.7 [INFO] [stderr] Checking parserc v0.12.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `Length` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/input.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / pub trait Length { [INFO] [stdout] 25 | | /// Returns item length. [INFO] [stdout] 26 | | fn len(&self) -> usize; [INFO] [stdout] 27 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Item` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/input.rs:48:1 [INFO] [stdout] | [INFO] [stdout] 48 | / pub trait Item: PartialEq + Clone + Copy + Debug { [INFO] [stdout] 49 | | fn len(&self) -> usize; [INFO] [stdout] 50 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Length` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/input.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / pub trait Length { [INFO] [stdout] 25 | | /// Returns item length. [INFO] [stdout] 26 | | fn len(&self) -> usize; [INFO] [stdout] 27 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Item` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/input.rs:48:1 [INFO] [stdout] | [INFO] [stdout] 48 | / pub trait Item: PartialEq + Clone + Copy + Debug { [INFO] [stdout] 49 | | fn len(&self) -> usize; [INFO] [stdout] 50 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 63 | self.map(|v| Box::new(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Box::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/c.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | / loop { [INFO] [stdout] 102 | | if let Some(next) = iter.next() { [INFO] [stdout] 103 | | if !(cond)(next) { [INFO] [stdout] 104 | | break; [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(next) = iter.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/c.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | while let Some(next) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/c.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | while let Some(next) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/c.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | while let Some(next) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/syntax.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | Ok(Self::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 61 - Ok(Self::default()) [INFO] [stdout] 61 + Ok(Self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/syntax.rs:276:27 [INFO] [stdout] | [INFO] [stdout] 276 | if len < LOWER || !(len < HIGHER) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(len >= HIGHER)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 63 | self.map(|v| Box::new(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Box::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/c.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | / loop { [INFO] [stdout] 102 | | if let Some(next) = iter.next() { [INFO] [stdout] 103 | | if !(cond)(next) { [INFO] [stdout] 104 | | break; [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(next) = iter.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/c.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | while let Some(next) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/c.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | while let Some(next) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/c.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | while let Some(next) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/syntax.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | Ok(Self::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 61 - Ok(Self::default()) [INFO] [stdout] 61 + Ok(Self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/syntax.rs:276:27 [INFO] [stdout] | [INFO] [stdout] 276 | if len < LOWER || !(len < HIGHER) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(len >= HIGHER)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.74s [INFO] running `Command { std: "docker" "inspect" "44ac75b41ba86490b82b45bddb38bf6f2c52b33ea0f0ce2ef301881e3661c87c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "44ac75b41ba86490b82b45bddb38bf6f2c52b33ea0f0ce2ef301881e3661c87c", kill_on_drop: false }` [INFO] [stdout] 44ac75b41ba86490b82b45bddb38bf6f2c52b33ea0f0ce2ef301881e3661c87c