[INFO] fetching crate parse-fmt-str 2.0.0... [INFO] linting parse-fmt-str-2.0.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate parse-fmt-str 2.0.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate parse-fmt-str 2.0.0 [INFO] finished tweaking crates.io crate parse-fmt-str 2.0.0 [INFO] tweaked toml for crates.io crate parse-fmt-str 2.0.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate parse-fmt-str 2.0.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding nom v7.1.3 (available: v8.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 443f0a8a558442d1130fc78dd51ae69bd4be3ee9b847c51a2ea6131d1a745c10 [INFO] running `Command { std: "docker" "start" "-a" "443f0a8a558442d1130fc78dd51ae69bd4be3ee9b847c51a2ea6131d1a745c10", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "443f0a8a558442d1130fc78dd51ae69bd4be3ee9b847c51a2ea6131d1a745c10", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "443f0a8a558442d1130fc78dd51ae69bd4be3ee9b847c51a2ea6131d1a745c10", kill_on_drop: false }` [INFO] [stdout] 443f0a8a558442d1130fc78dd51ae69bd4be3ee9b847c51a2ea6131d1a745c10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad33aef72ecdb62112c354679ba358f973fc18bb8a233130d31e7e56f462eda5 [INFO] running `Command { std: "docker" "start" "-a" "ad33aef72ecdb62112c354679ba358f973fc18bb8a233130d31e7e56f462eda5", kill_on_drop: false }` [INFO] [stderr] Checking parse-fmt-str v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return Ok((input, out)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return Ok((input, out)); [INFO] [stdout] 53 + Ok((input, out)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/lib.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / input [INFO] [stdout] 37 | | .chars() [INFO] [stdout] 38 | | .nth(0) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] help: try calling `.next()` instead of `.nth(0)` [INFO] [stdout] | [INFO] [stdout] 36 ~ input [INFO] [stdout] 37 + .chars().next() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `input` [INFO] [stdout] --> src/lib.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 130 | let input = input; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `input` is initially defined here [INFO] [stdout] --> src/lib.rs:129:42 [INFO] [stdout] | [INFO] [stdout] 129 | let (input, percision) = if let (input, Some(_)) = opt(tag("."))(input)? { [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 216 | if !part1.is_err() || !part2.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `part1.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:216:31 [INFO] [stdout] | [INFO] [stdout] 216 | if !part1.is_err() || !part2.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `part2.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return Ok((input, out)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return Ok((input, out)); [INFO] [stdout] 53 + Ok((input, out)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/lib.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / input [INFO] [stdout] 37 | | .chars() [INFO] [stdout] 38 | | .nth(0) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] help: try calling `.next()` instead of `.nth(0)` [INFO] [stdout] | [INFO] [stdout] 36 ~ input [INFO] [stdout] 37 + .chars().next() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `input` [INFO] [stdout] --> src/lib.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 130 | let input = input; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `input` is initially defined here [INFO] [stdout] --> src/lib.rs:129:42 [INFO] [stdout] | [INFO] [stdout] 129 | let (input, percision) = if let (input, Some(_)) = opt(tag("."))(input)? { [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 216 | if !part1.is_err() || !part2.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `part1.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:216:31 [INFO] [stdout] | [INFO] [stdout] 216 | if !part1.is_err() || !part2.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `part2.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> tests/tests.rs:81:21 [INFO] [stdout] | [INFO] [stdout] 81 | / match param { [INFO] [stdout] 82 | | Argument::Identifier(wide) => wide == "wide", [INFO] [stdout] 83 | | _ => false, [INFO] [stdout] 84 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> tests/tests.rs:80:34 [INFO] [stdout] | [INFO] [stdout] 80 | Count::Parameter(param) => { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 81 | match param { [INFO] [stdout] 82 | Argument::Identifier(wide) => wide == "wide", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.46s [INFO] running `Command { std: "docker" "inspect" "ad33aef72ecdb62112c354679ba358f973fc18bb8a233130d31e7e56f462eda5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad33aef72ecdb62112c354679ba358f973fc18bb8a233130d31e7e56f462eda5", kill_on_drop: false }` [INFO] [stdout] ad33aef72ecdb62112c354679ba358f973fc18bb8a233130d31e7e56f462eda5