[INFO] fetching crate paho-mqtt 0.13.3... [INFO] linting paho-mqtt-0.13.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate paho-mqtt 0.13.3 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate paho-mqtt 0.13.3 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate paho-mqtt 0.13.3 [INFO] tweaked toml for crates.io crate paho-mqtt 0.13.3 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate paho-mqtt 0.13.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate paho-mqtt 0.13.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded errno v0.3.5 [INFO] [stderr] Downloaded ctrlc v3.4.1 [INFO] [stderr] Downloaded shlex v1.2.0 [INFO] [stderr] Downloaded blocking v1.4.1 [INFO] [stderr] Downloaded futures-timer v3.0.2 [INFO] [stderr] Downloaded async-executor v1.6.0 [INFO] [stderr] Downloaded async-task v4.5.0 [INFO] [stderr] Downloaded serde_derive v1.0.189 [INFO] [stderr] Downloaded serde v1.0.189 [INFO] [stderr] Downloaded clang-sys v1.6.1 [INFO] [stderr] Downloaded winnow v0.6.24 [INFO] [stderr] Downloaded value-bag v1.10.0 [INFO] [stderr] Downloaded bindgen v0.64.0 [INFO] [stderr] Downloaded bitflags v2.4.1 [INFO] [stderr] Downloaded aho-corasick v1.1.2 [INFO] [stderr] Downloaded regex v1.10.2 [INFO] [stderr] Downloaded nix v0.27.1 [INFO] [stderr] Downloaded rustix v0.37.26 [INFO] [stderr] Downloaded regex-syntax v0.8.2 [INFO] [stderr] Downloaded rustix v0.38.20 [INFO] [stderr] Downloaded regex-automata v0.4.3 [INFO] [stderr] Downloaded linux-raw-sys v0.4.10 [INFO] [stderr] Downloaded paho-mqtt-sys v0.10.2 [INFO] [stderr] Downloaded openssl-src v300.1.5+3.1.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09a49b93bd22314c291cac66ecbf26850bf846a129fdf5e74b9846e62f275e35 [INFO] running `Command { std: "docker" "start" "-a" "09a49b93bd22314c291cac66ecbf26850bf846a129fdf5e74b9846e62f275e35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09a49b93bd22314c291cac66ecbf26850bf846a129fdf5e74b9846e62f275e35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09a49b93bd22314c291cac66ecbf26850bf846a129fdf5e74b9846e62f275e35", kill_on_drop: false }` [INFO] [stdout] 09a49b93bd22314c291cac66ecbf26850bf846a129fdf5e74b9846e62f275e35 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 07e4edc6a87d2c946bb236485ff9399ef8b56db3c6748a577b4a838e47c2fa3e [INFO] running `Command { std: "docker" "start" "-a" "07e4edc6a87d2c946bb236485ff9399ef8b56db3c6748a577b4a838e47c2fa3e", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking value-bag v1.10.0 [INFO] [stderr] Compiling serde v1.0.189 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling rustix v0.37.26 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking async-task v4.5.0 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking log v0.4.25 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking winnow v0.6.24 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking concurrent-queue v2.3.0 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking futures-timer v3.0.2 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Checking indexmap v2.7.1 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking blocking v1.4.1 [INFO] [stderr] Checking async-executor v1.6.0 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling openssl-sys v0.9.93 [INFO] [stderr] Compiling paho-mqtt-sys v0.10.2 [INFO] [stderr] Checking ctrlc v3.4.1 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Checking async-global-executor v2.3.1 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking env_logger v0.11.6 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking paho-mqtt v0.13.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/macros.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / /// Return an error from a function. [INFO] [stdout] 27 | | [INFO] [stdout] | |_^ [INFO] [stdout] 28 | macro_rules! bail { [INFO] [stdout] | ----------------- the comment documents this macro definition [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 26 - /// Return an error from a function. [INFO] [stdout] 26 + //! Return an error from a function. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/topic_matcher.rs:199:1 [INFO] [stdout] | [INFO] [stdout] 199 | / /// [INFO] [stdout] 200 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 217 | pub struct TopicMatcher { [INFO] [stdout] | ----------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 200 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/macros.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / /// Return an error from a function. [INFO] [stdout] 27 | | [INFO] [stdout] | |_^ [INFO] [stdout] 28 | macro_rules! bail { [INFO] [stdout] | ----------------- the comment documents this macro definition [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 26 - /// Return an error from a function. [INFO] [stdout] 26 + //! Return an error from a function. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/topic_matcher.rs:199:1 [INFO] [stdout] | [INFO] [stdout] 199 | / /// [INFO] [stdout] 200 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 217 | pub struct TopicMatcher { [INFO] [stdout] | ----------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 200 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/async_client.rs:444:9 [INFO] [stdout] | [INFO] [stdout] 444 | /// default options are used. [INFO] [stdout] | ^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/async_client.rs:628:9 [INFO] [stdout] | [INFO] [stdout] 628 | /// function or a closure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/async_client.rs:662:9 [INFO] [stdout] | [INFO] [stdout] 662 | /// function or a closure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/async_client.rs:708:9 [INFO] [stdout] | [INFO] [stdout] 708 | /// function or a closure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/async_client.rs:742:9 [INFO] [stdout] | [INFO] [stdout] 742 | /// function or a closure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/topic_matcher.rs:262:20 [INFO] [stdout] | [INFO] [stdout] 262 | curr = match curr.children.get(field) { [INFO] [stdout] | ____________________^ [INFO] [stdout] 263 | | Some(node) => node, [INFO] [stdout] 264 | | None => return None, [INFO] [stdout] 265 | | }; [INFO] [stdout] | |_____________^ help: try instead: `curr.children.get(field)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/topic_matcher.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | curr = match curr.children.get_mut(field) { [INFO] [stdout] | ____________________^ [INFO] [stdout] 277 | | Some(node) => node, [INFO] [stdout] 278 | | None => return None, [INFO] [stdout] 279 | | }; [INFO] [stdout] | |_____________^ help: try instead: `curr.children.get_mut(field)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/topic_matcher.rs:293:20 [INFO] [stdout] | [INFO] [stdout] 293 | curr = match curr.children.get_mut(field) { [INFO] [stdout] | ____________________^ [INFO] [stdout] 294 | | Some(node) => node, [INFO] [stdout] 295 | | None => return None, [INFO] [stdout] 296 | | }; [INFO] [stdout] | |_____________^ help: try instead: `curr.children.get_mut(field)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/properties.rs:979:17 [INFO] [stdout] | [INFO] [stdout] 979 | pub fn iter(&self, code: PropertyCode) -> PropertyIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 979 | pub fn iter(&self, code: PropertyCode) -> PropertyIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/properties.rs:1047:22 [INFO] [stdout] | [INFO] [stdout] 1047 | pub fn user_iter(&self) -> StringPairIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1047 | pub fn user_iter(&self) -> StringPairIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/topic_matcher.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | fn iter(&self) -> NodeIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 108 | fn iter(&self) -> NodeIter<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/topic_matcher.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | fn iter_mut(&mut self) -> NodeIterMut { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 118 | fn iter_mut(&mut self) -> NodeIterMut<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/topic_matcher.rs:313:17 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn iter(&self) -> NodeIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 313 | pub fn iter(&self) -> NodeIter<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/topic_matcher.rs:318:21 [INFO] [stdout] | [INFO] [stdout] 318 | pub fn iter_mut(&mut self) -> NodeIterMut { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 318 | pub fn iter_mut(&mut self) -> NodeIterMut<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/async_client.rs:444:9 [INFO] [stdout] | [INFO] [stdout] 444 | /// default options are used. [INFO] [stdout] | ^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/async_client.rs:628:9 [INFO] [stdout] | [INFO] [stdout] 628 | /// function or a closure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/async_client.rs:662:9 [INFO] [stdout] | [INFO] [stdout] 662 | /// function or a closure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/async_client.rs:708:9 [INFO] [stdout] | [INFO] [stdout] 708 | /// function or a closure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/async_client.rs:742:9 [INFO] [stdout] | [INFO] [stdout] 742 | /// function or a closure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/async_client.rs:1425:9 [INFO] [stdout] | [INFO] [stdout] 1425 | let _ = thr.join().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 1425 - let _ = thr.join().unwrap(); [INFO] [stdout] 1425 + thr.join().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/async_client.rs:1444:9 [INFO] [stdout] | [INFO] [stdout] 1444 | let _ = thr.join().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 1444 - let _ = thr.join().unwrap(); [INFO] [stdout] 1444 + thr.join().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/client.rs:349:9 [INFO] [stdout] | [INFO] [stdout] 349 | let _ = thr.join().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 349 - let _ = thr.join().unwrap(); [INFO] [stdout] 349 + thr.join().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/client.rs:368:9 [INFO] [stdout] | [INFO] [stdout] 368 | let _ = thr.join().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 368 - let _ = thr.join().unwrap(); [INFO] [stdout] 368 + thr.join().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/connect_options.rs:778:17 [INFO] [stdout] | [INFO] [stdout] 778 | for (i, ref svr) in servers.iter().enumerate() { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 778 - for (i, ref svr) in servers.iter().enumerate() { [INFO] [stdout] 778 + for (i, svr) in servers.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/connect_options.rs:1040:9 [INFO] [stdout] | [INFO] [stdout] 1040 | let _ = thr.join().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 1040 - let _ = thr.join().unwrap(); [INFO] [stdout] 1040 + thr.join().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/disconnect_options.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | let _ = thr.join().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 196 - let _ = thr.join().unwrap(); [INFO] [stdout] 196 + thr.join().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/response_options.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | let _ = unsafe { Token::from_raw(inner) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/response_options.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | let _ = unsafe { Token::from_raw(inner) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/response_options.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 257 | let _ = unsafe { Token::from_raw(inner) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/response_options.rs:291:9 [INFO] [stdout] | [INFO] [stdout] 291 | let _ = unsafe { Token::from_raw(inner) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/properties.rs:1163:17 [INFO] [stdout] | [INFO] [stdout] 1163 | assert!(!prop.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `prop.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/message.rs:551:9 [INFO] [stdout] | [INFO] [stdout] 551 | let _ = thr.join().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 551 - let _ = thr.join().unwrap(); [INFO] [stdout] 551 + thr.join().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/topic_matcher.rs:262:20 [INFO] [stdout] | [INFO] [stdout] 262 | curr = match curr.children.get(field) { [INFO] [stdout] | ____________________^ [INFO] [stdout] 263 | | Some(node) => node, [INFO] [stdout] 264 | | None => return None, [INFO] [stdout] 265 | | }; [INFO] [stdout] | |_____________^ help: try instead: `curr.children.get(field)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/topic_matcher.rs:276:20 [INFO] [stdout] | [INFO] [stdout] 276 | curr = match curr.children.get_mut(field) { [INFO] [stdout] | ____________________^ [INFO] [stdout] 277 | | Some(node) => node, [INFO] [stdout] 278 | | None => return None, [INFO] [stdout] 279 | | }; [INFO] [stdout] | |_____________^ help: try instead: `curr.children.get_mut(field)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/topic_matcher.rs:293:20 [INFO] [stdout] | [INFO] [stdout] 293 | curr = match curr.children.get_mut(field) { [INFO] [stdout] | ____________________^ [INFO] [stdout] 294 | | Some(node) => node, [INFO] [stdout] 295 | | None => return None, [INFO] [stdout] 296 | | }; [INFO] [stdout] | |_____________^ help: try instead: `curr.children.get_mut(field)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/properties.rs:979:17 [INFO] [stdout] | [INFO] [stdout] 979 | pub fn iter(&self, code: PropertyCode) -> PropertyIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 979 | pub fn iter(&self, code: PropertyCode) -> PropertyIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/properties.rs:1047:22 [INFO] [stdout] | [INFO] [stdout] 1047 | pub fn user_iter(&self) -> StringPairIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1047 | pub fn user_iter(&self) -> StringPairIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/topic_matcher.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | fn iter(&self) -> NodeIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 108 | fn iter(&self) -> NodeIter<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/topic_matcher.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | fn iter_mut(&mut self) -> NodeIterMut { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 118 | fn iter_mut(&mut self) -> NodeIterMut<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/topic_matcher.rs:313:17 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn iter(&self) -> NodeIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 313 | pub fn iter(&self) -> NodeIter<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/topic_matcher.rs:318:21 [INFO] [stdout] | [INFO] [stdout] 318 | pub fn iter_mut(&mut self) -> NodeIterMut { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 318 | pub fn iter_mut(&mut self) -> NodeIterMut<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.30s [INFO] running `Command { std: "docker" "inspect" "07e4edc6a87d2c946bb236485ff9399ef8b56db3c6748a577b4a838e47c2fa3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07e4edc6a87d2c946bb236485ff9399ef8b56db3c6748a577b4a838e47c2fa3e", kill_on_drop: false }` [INFO] [stdout] 07e4edc6a87d2c946bb236485ff9399ef8b56db3c6748a577b4a838e47c2fa3e