[INFO] fetching crate p2panda-auth 0.5.2... [INFO] linting p2panda-auth-0.5.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate p2panda-auth 0.5.2 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate p2panda-auth 0.5.2 [INFO] finished tweaking crates.io crate p2panda-auth 0.5.2 [INFO] tweaked toml for crates.io crate p2panda-auth 0.5.2 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate p2panda-auth 0.5.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate p2panda-auth 0.5.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b8e622cb6bb9e245bf783d004fbdb3cf94c15824cf2a81ce1dd034147c1c02ef [INFO] running `Command { std: "docker" "start" "-a" "b8e622cb6bb9e245bf783d004fbdb3cf94c15824cf2a81ce1dd034147c1c02ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b8e622cb6bb9e245bf783d004fbdb3cf94c15824cf2a81ce1dd034147c1c02ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8e622cb6bb9e245bf783d004fbdb3cf94c15824cf2a81ce1dd034147c1c02ef", kill_on_drop: false }` [INFO] [stdout] b8e622cb6bb9e245bf783d004fbdb3cf94c15824cf2a81ce1dd034147c1c02ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f0bb3884be500b375be1ae7157ef3b12b9199315ede077dcf7a348fea9707879 [INFO] running `Command { std: "docker" "start" "-a" "f0bb3884be500b375be1ae7157ef3b12b9199315ede077dcf7a348fea9707879", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.115 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling getrandom v0.3.2 [INFO] [stderr] Compiling zerocopy v0.8.24 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking fixedbitset v0.5.7 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking petgraph v0.8.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking p2panda-auth v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/group/crdt/mod.rs:513:17 [INFO] [stdout] | [INFO] [stdout] 513 | / if member.is_group() && access.is_manage() { [INFO] [stdout] 514 | | return Err(GroupCrdtError::ManagerGroupsNotAllowed(member.id())); [INFO] [stdout] 515 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 512 ~ GroupAction::Add { member, access } | GroupAction::Promote { member, access } [INFO] [stdout] 513 ~ if member.is_group() && access.is_manage() => { [INFO] [stdout] 514 | return Err(GroupCrdtError::ManagerGroupsNotAllowed(member.id())); [INFO] [stdout] 515 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/access.rs:197:17 [INFO] [stdout] | [INFO] [stdout] 197 | assert!(!(private_access >= public_access)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(private_access < public_access)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/access.rs:198:17 [INFO] [stdout] | [INFO] [stdout] 198 | assert!(!(private_access <= public_access)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(private_access > public_access)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/group/crdt/mod.rs:513:17 [INFO] [stdout] | [INFO] [stdout] 513 | / if member.is_group() && access.is_manage() { [INFO] [stdout] 514 | | return Err(GroupCrdtError::ManagerGroupsNotAllowed(member.id())); [INFO] [stdout] 515 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 512 ~ GroupAction::Add { member, access } | GroupAction::Promote { member, access } [INFO] [stdout] 513 ~ if member.is_group() && access.is_manage() => { [INFO] [stdout] 514 | return Err(GroupCrdtError::ManagerGroupsNotAllowed(member.id())); [INFO] [stdout] 515 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/group/crdt/mod.rs:1494:51 [INFO] [stdout] | [INFO] [stdout] 1494 | for (_, y) in [y_iv_a, y_iv_b].into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 1494 - for (_, y) in [y_iv_a, y_iv_b].into_iter().enumerate() { [INFO] [stdout] 1494 + for y in [y_iv_a, y_iv_b].into_iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/group/display.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | members.sort_by(|(id_a, _), (id_b, _)| id_a.cmp(id_b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 272 - members.sort_by(|(id_a, _), (id_b, _)| id_a.cmp(id_b)); [INFO] [stdout] 272 + members.sort_by_key(|(id_a, _)| *id_a); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.96s [INFO] running `Command { std: "docker" "inspect" "f0bb3884be500b375be1ae7157ef3b12b9199315ede077dcf7a348fea9707879", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0bb3884be500b375be1ae7157ef3b12b9199315ede077dcf7a348fea9707879", kill_on_drop: false }` [INFO] [stdout] f0bb3884be500b375be1ae7157ef3b12b9199315ede077dcf7a348fea9707879