[INFO] fetching crate oxidate-fsm 0.1.0... [INFO] linting oxidate-fsm-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate oxidate-fsm 0.1.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate oxidate-fsm 0.1.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate oxidate-fsm 0.1.0 [INFO] tweaked toml for crates.io crate oxidate-fsm 0.1.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate oxidate-fsm 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate oxidate-fsm 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded egui_extras v0.29.1 [INFO] [stderr] Downloaded imagesize v0.12.0 [INFO] [stderr] Downloaded usvg-tree v0.37.0 [INFO] [stderr] Downloaded rctree v0.5.0 [INFO] [stderr] Downloaded ehttp v0.5.0 [INFO] [stderr] Downloaded usvg v0.37.0 [INFO] [stderr] Downloaded immutable-chunkmap v2.1.2 [INFO] [stderr] Downloaded roxmltree v0.19.0 [INFO] [stderr] Downloaded calloop v0.14.3 [INFO] [stderr] Downloaded usvg-parser v0.37.0 [INFO] [stderr] Downloaded webbrowser v1.0.6 [INFO] [stderr] Downloaded resvg v0.37.0 [INFO] [stderr] Downloaded mime_guess2 v2.3.1 [INFO] [stderr] Downloaded svgtypes v0.13.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d766947ebb9e0622c490549991b532fb80eeaa1d15cf164884b7755aa91ef251 [INFO] running `Command { std: "docker" "start" "-a" "d766947ebb9e0622c490549991b532fb80eeaa1d15cf164884b7755aa91ef251", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d766947ebb9e0622c490549991b532fb80eeaa1d15cf164884b7755aa91ef251", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d766947ebb9e0622c490549991b532fb80eeaa1d15cf164884b7755aa91ef251", kill_on_drop: false }` [INFO] [stdout] d766947ebb9e0622c490549991b532fb80eeaa1d15cf164884b7755aa91ef251 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9ab891ba7812af80b1889c8dc2d77514e6e608a3a92da291a7448e301a823a70 [INFO] running `Command { std: "docker" "start" "-a" "9ab891ba7812af80b1889c8dc2d77514e6e608a3a92da291a7448e301a823a70", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Compiling find-msvc-tools v0.1.7 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling wayland-sys v0.31.8 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling quick-xml v0.38.4 [INFO] [stderr] Compiling wayland-client v0.31.12 [INFO] [stderr] Checking endi v1.1.1 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling cc v1.2.52 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Compiling xml-rs v0.8.28 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking accesskit v0.16.3 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking immutable-chunkmap v2.1.2 [INFO] [stderr] Checking kurbo v0.9.5 [INFO] [stderr] Compiling wayland-scanner v0.31.8 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking async-fs v2.2.0 [INFO] [stderr] Checking epaint_default_fonts v0.29.1 [INFO] [stderr] Compiling wayland-backend v0.3.12 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking svgtypes v0.13.0 [INFO] [stderr] Checking accesskit_consumer v0.24.3 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Checking rctree v0.5.0 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Compiling phf v0.11.3 [INFO] [stderr] Checking webpki-roots v1.0.5 [INFO] [stderr] Compiling glutin v0.32.3 [INFO] [stderr] Checking simplecss v0.2.2 [INFO] [stderr] Checking imagesize v0.12.0 [INFO] [stderr] Checking data-url v0.3.2 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Checking roxmltree v0.19.0 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Compiling mime_guess2 v2.3.1 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Compiling zmij v1.0.12 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking xmlwriter v0.1.0 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Compiling rfd v0.14.1 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking jiff v0.2.18 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Compiling pest_generator v2.8.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling pest_derive v2.8.5 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking emath v0.29.1 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking usvg-tree v0.37.0 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking ecolor v0.29.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking usvg-parser v0.37.0 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking epaint v0.29.1 [INFO] [stderr] Checking usvg v0.37.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking resvg v0.37.0 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Compiling enumflags2 v0.7.12 [INFO] [stderr] Compiling quick-xml v0.30.0 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Compiling zvariant v4.2.0 [INFO] [stderr] Checking egui v0.29.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking ureq v2.12.1 [INFO] [stderr] Checking webbrowser v1.0.6 [INFO] [stderr] Compiling zbus_names v3.0.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking ehttp v0.5.0 [INFO] [stderr] Compiling zbus_xml v4.0.0 [INFO] [stderr] Compiling zbus-lockstep v0.4.4 [INFO] [stderr] Checking egui_glow v0.29.1 [INFO] [stderr] Checking egui_extras v0.29.1 [INFO] [stderr] Compiling zbus-lockstep-macros v0.4.4 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.10 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking atspi-common v0.6.0 [INFO] [stderr] Checking ashpd v0.8.1 [INFO] [stderr] Checking atspi-proxies v0.6.0 [INFO] [stderr] Checking accesskit_atspi_common v0.9.3 [INFO] [stderr] Checking atspi-connection v0.6.0 [INFO] [stderr] Checking atspi v0.22.0 [INFO] [stderr] Checking accesskit_unix v0.12.3 [INFO] [stderr] Checking accesskit_winit v0.22.4 [INFO] [stderr] Checking egui-winit v0.29.1 [INFO] [stderr] Checking eframe v0.29.1 [INFO] [stderr] Checking oxidate-fsm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser/mod.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | let mut inner_iter = inner.into_inner(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser/mod.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | let mut inner_iter = inner.into_inner(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / match item.as_rule() { [INFO] [stdout] 65 | | Rule::fsm_body => { [INFO] [stdout] 66 | | parse_fsm_body(item, &mut fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 ~ if item.as_rule() == Rule::fsm_body { [INFO] [stdout] 65 + parse_fsm_body(item, &mut fsm)?; [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / match item.as_rule() { [INFO] [stdout] 78 | | Rule::fsm_item => { [INFO] [stdout] 79 | | parse_fsm_item(item, fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 77 ~ if item.as_rule() == Rule::fsm_item { [INFO] [stdout] 78 + parse_fsm_item(item, fsm)?; [INFO] [stdout] 79 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser/mod.rs:126:13 [INFO] [stdout] | [INFO] [stdout] 126 | / if transition.source != "[*]" && !transition.source.starts_with("<<") { [INFO] [stdout] 127 | | if !fsm.states.iter().any(|s| s.name == transition.source) { [INFO] [stdout] 128 | | fsm.states [INFO] [stdout] 129 | | .push(State::new(&transition.source, StateType::Simple)); [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 126 ~ if transition.source != "[*]" && !transition.source.starts_with("<<") [INFO] [stdout] 127 ~ && !fsm.states.iter().any(|s| s.name == transition.source) { [INFO] [stdout] 128 | fsm.states [INFO] [stdout] 129 | .push(State::new(&transition.source, StateType::Simple)); [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser/mod.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | / if transition.target != "[*]" && !transition.target.starts_with("<<") { [INFO] [stdout] 133 | | if !fsm.states.iter().any(|s| s.name == transition.target) { [INFO] [stdout] 134 | | fsm.states [INFO] [stdout] 135 | | .push(State::new(&transition.target, StateType::Simple)); [INFO] [stdout] 136 | | } [INFO] [stdout] 137 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ if transition.target != "[*]" && !transition.target.starts_with("<<") [INFO] [stdout] 133 ~ && !fsm.states.iter().any(|s| s.name == transition.target) { [INFO] [stdout] 134 | fsm.states [INFO] [stdout] 135 | .push(State::new(&transition.target, StateType::Simple)); [INFO] [stdout] 136 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | / match item.as_rule() { [INFO] [stdout] 385 | | Rule::state_body_item => { [INFO] [stdout] 386 | | parse_state_body_item(item, state)?; [INFO] [stdout] ... | [INFO] [stdout] 389 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 384 ~ if item.as_rule() == Rule::state_body_item { [INFO] [stdout] 385 + parse_state_body_item(item, state)?; [INFO] [stdout] 386 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | / match item.as_rule() { [INFO] [stdout] 404 | | Rule::fsm_item => { [INFO] [stdout] 405 | | if let Some(ref mut sub_fsm) = state.sub_fsm { [INFO] [stdout] 406 | | parse_fsm_item(item, sub_fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 409 | | _ => {} [INFO] [stdout] 410 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 403 ~ if item.as_rule() == Rule::fsm_item { [INFO] [stdout] 404 + if let Some(ref mut sub_fsm) = state.sub_fsm { [INFO] [stdout] 405 + parse_fsm_item(item, sub_fsm)?; [INFO] [stdout] 406 + } [INFO] [stdout] 407 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/codegen/mod.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | / impl Default for CodegenTarget { [INFO] [stdout] 59 | | fn default() -> Self { [INFO] [stdout] 60 | | Self::Standard [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Default)] [INFO] [stdout] 25 | pub enum CodegenTarget { [INFO] [stdout] 26 | /// Standard Rust (std) - MIT licensed [INFO] [stdout] 27 ~ #[default] [INFO] [stdout] 28 ~ Standard, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / match item.as_rule() { [INFO] [stdout] 65 | | Rule::fsm_body => { [INFO] [stdout] 66 | | parse_fsm_body(item, &mut fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 ~ if item.as_rule() == Rule::fsm_body { [INFO] [stdout] 65 + parse_fsm_body(item, &mut fsm)?; [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / match item.as_rule() { [INFO] [stdout] 78 | | Rule::fsm_item => { [INFO] [stdout] 79 | | parse_fsm_item(item, fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 77 ~ if item.as_rule() == Rule::fsm_item { [INFO] [stdout] 78 + parse_fsm_item(item, fsm)?; [INFO] [stdout] 79 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/codegen/mod.rs:205:20 [INFO] [stdout] | [INFO] [stdout] 205 | code.push_str(&format!(" Self {{\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" Self {\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser/mod.rs:126:13 [INFO] [stdout] | [INFO] [stdout] 126 | / if transition.source != "[*]" && !transition.source.starts_with("<<") { [INFO] [stdout] 127 | | if !fsm.states.iter().any(|s| s.name == transition.source) { [INFO] [stdout] 128 | | fsm.states [INFO] [stdout] 129 | | .push(State::new(&transition.source, StateType::Simple)); [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 126 ~ if transition.source != "[*]" && !transition.source.starts_with("<<") [INFO] [stdout] 127 ~ && !fsm.states.iter().any(|s| s.name == transition.source) { [INFO] [stdout] 128 | fsm.states [INFO] [stdout] 129 | .push(State::new(&transition.source, StateType::Simple)); [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser/mod.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | / if transition.target != "[*]" && !transition.target.starts_with("<<") { [INFO] [stdout] 133 | | if !fsm.states.iter().any(|s| s.name == transition.target) { [INFO] [stdout] 134 | | fsm.states [INFO] [stdout] 135 | | .push(State::new(&transition.target, StateType::Simple)); [INFO] [stdout] 136 | | } [INFO] [stdout] 137 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ if transition.target != "[*]" && !transition.target.starts_with("<<") [INFO] [stdout] 133 ~ && !fsm.states.iter().any(|s| s.name == transition.target) { [INFO] [stdout] 134 | fsm.states [INFO] [stdout] 135 | .push(State::new(&transition.target, StateType::Simple)); [INFO] [stdout] 136 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/codegen/mod.rs:374:12 [INFO] [stdout] | [INFO] [stdout] 374 | result.replace(' ', "_").replace('-', "_") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace([' ', '-'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | / match item.as_rule() { [INFO] [stdout] 385 | | Rule::state_body_item => { [INFO] [stdout] 386 | | parse_state_body_item(item, state)?; [INFO] [stdout] ... | [INFO] [stdout] 389 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 384 ~ if item.as_rule() == Rule::state_body_item { [INFO] [stdout] 385 + parse_state_body_item(item, state)?; [INFO] [stdout] 386 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | / match item.as_rule() { [INFO] [stdout] 404 | | Rule::fsm_item => { [INFO] [stdout] 405 | | if let Some(ref mut sub_fsm) = state.sub_fsm { [INFO] [stdout] 406 | | parse_fsm_item(item, sub_fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 409 | | _ => {} [INFO] [stdout] 410 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 403 ~ if item.as_rule() == Rule::fsm_item { [INFO] [stdout] 404 + if let Some(ref mut sub_fsm) = state.sub_fsm { [INFO] [stdout] 405 + parse_fsm_item(item, sub_fsm)?; [INFO] [stdout] 406 + } [INFO] [stdout] 407 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/codegen/mod.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | / impl Default for CodegenTarget { [INFO] [stdout] 59 | | fn default() -> Self { [INFO] [stdout] 60 | | Self::Standard [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Default)] [INFO] [stdout] 25 | pub enum CodegenTarget { [INFO] [stdout] 26 | /// Standard Rust (std) - MIT licensed [INFO] [stdout] 27 ~ #[default] [INFO] [stdout] 28 ~ Standard, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/codegen/mod.rs:205:20 [INFO] [stdout] | [INFO] [stdout] 205 | code.push_str(&format!(" Self {{\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" Self {\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/codegen/mod.rs:374:12 [INFO] [stdout] | [INFO] [stdout] 374 | result.replace(' ', "_").replace('-', "_") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace([' ', '-'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> examples/functional_test.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | _ => false, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> examples/functional_test.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 73 | (TrafficLightState::Red, TrafficLightEvent::TimerExpired) => { [INFO] [stdout] | --------------------------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 80 | (TrafficLightState::Green, TrafficLightEvent::TimerExpired) => { [INFO] [stdout] | ----------------------------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 87 | (TrafficLightState::Yellow, TrafficLightEvent::TimerExpired) => { [INFO] [stdout] | ------------------------------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 94 | _ => false, [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `init` is never used [INFO] [stdout] --> examples/embassy_test.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 112 | impl BlinkActiveObject { [INFO] [stdout] | ------------------------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 129 | fn init(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_led_on` is never used [INFO] [stdout] --> examples/embassy_test.rs:248:8 [INFO] [stdout] | [INFO] [stdout] 236 | impl TestBlinkActions { [INFO] [stdout] | --------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 248 | fn is_led_on(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Channel` [INFO] [stdout] --> examples/embassy_test.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / pub const fn new() -> Self { [INFO] [stdout] 27 | | Self { [INFO] [stdout] 28 | | queue: RefCell::new(VecDeque::new()), [INFO] [stdout] 29 | | } [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 25 + impl Default for Channel { [INFO] [stdout] 26 + fn default() -> Self { [INFO] [stdout] 27 + Self::new() [INFO] [stdout] 28 + } [INFO] [stdout] 29 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/door_lock_test.rs:315:9 [INFO] [stdout] | [INFO] [stdout] 315 | let mut actions = TestDoorActions::new(log.clone()); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_door_closed` is never used [INFO] [stdout] --> examples/door_lock_test.rs:151:8 [INFO] [stdout] | [INFO] [stdout] 138 | impl TestDoorActions { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 151 | fn set_door_closed(&mut self, closed: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_active_timers` and `get_keepalive_count` are never used [INFO] [stdout] --> examples/connection_manager_test.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 188 | impl TestConnectionActions { [INFO] [stdout] | -------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 197 | fn get_active_timers(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 201 | fn get_keepalive_count(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_safe_to_start`, `set_cooled_down`, and `is_power_enabled` are never used [INFO] [stdout] --> examples/rtic_test.rs:457:8 [INFO] [stdout] | [INFO] [stdout] 443 | impl TestMotorActions { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 457 | fn set_safe_to_start(&self, safe: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 461 | fn set_cooled_down(&self, cooled: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 469 | fn is_power_enabled(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Queue` [INFO] [stdout] --> examples/rtic_test.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / pub const fn new() -> Self { [INFO] [stdout] 50 | | Self { [INFO] [stdout] 51 | | buffer: RefCell::new(Vec::new()), [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 48 + impl Default for Queue { [INFO] [stdout] 49 + fn default() -> Self { [INFO] [stdout] 50 + Self::new() [INFO] [stdout] 51 + } [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> examples/rtic_test.rs:370:17 [INFO] [stdout] | [INFO] [stdout] 370 | / if self.state != MotorState::Fault { [INFO] [stdout] 371 | | self.context.log_event("FAULT detected!"); [INFO] [stdout] 372 | | self.context.disable_power_stage(); [INFO] [stdout] 373 | | self.context.trigger_fault_alarm(); [INFO] [stdout] 374 | | self.state = MotorState::Fault; [INFO] [stdout] 375 | | self.fault_count += 1; [INFO] [stdout] 376 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 369 ~ (_, MotorSignal::OverCurrent) | (_, MotorSignal::OverTemp) [INFO] [stdout] 370 ~ if self.state != MotorState::Fault => { [INFO] [stdout] 371 | self.context.log_event("FAULT detected!"); [INFO] [stdout] ... [INFO] [stdout] 375 | self.fault_count += 1; [INFO] [stdout] 376 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser/mod.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | let mut inner_iter = inner.into_inner(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_composite` is never used [INFO] [stdout] --> src/fsm/mod.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 134 | impl State { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 148 | pub fn is_composite(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `with_event`, `with_guard`, and `with_action` are never used [INFO] [stdout] --> src/fsm/mod.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 185 | impl Transition { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 186 | pub fn new(source: impl Into, target: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 197 | pub fn with_event(mut self, event: Event) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 202 | pub fn with_guard(mut self, guard: Guard) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 207 | pub fn with_action(mut self, action: Action) -> Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/fsm/mod.rs:251:12 [INFO] [stdout] | [INFO] [stdout] 250 | impl Event { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 251 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/fsm/mod.rs:264:12 [INFO] [stdout] | [INFO] [stdout] 263 | impl Guard { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 264 | pub fn new(expression: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `with_params` are never used [INFO] [stdout] --> src/fsm/mod.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 280 | impl Action { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 281 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 288 | pub fn with_params(mut self, params: Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FsmContext` is never constructed [INFO] [stdout] --> src/fsm/mod.rs:296:12 [INFO] [stdout] | [INFO] [stdout] 296 | pub struct FsmContext { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/fsm/mod.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 305 | impl FsmContext { [INFO] [stdout] | ------------------------------ associated function in this implementation [INFO] [stdout] 306 | pub fn new(initial_state: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `with_data` is never used [INFO] [stdout] --> src/fsm/mod.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 315 | impl FsmContext { [INFO] [stdout] | --------------------- associated function in this implementation [INFO] [stdout] 316 | pub fn with_data(initial_state: impl Into, data: T) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `periodic`, and `auto_start_in` are never used [INFO] [stdout] --> src/fsm/mod.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 344 | impl Timer { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 345 | pub fn new(name: impl Into, duration_ms: u32, event: Event) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 355 | pub fn periodic(mut self) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 360 | pub fn auto_start_in(mut self, state: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_branch` and `add_else` are never used [INFO] [stdout] --> src/fsm/mod.rs:399:12 [INFO] [stdout] | [INFO] [stdout] 390 | impl ChoicePoint { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 399 | pub fn add_branch(mut self, guard: impl Into, target: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 408 | pub fn add_else(mut self, target: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `SyntaxError` and `UnknownState` are never constructed [INFO] [stdout] --> src/parser/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub enum ParseError { [INFO] [stdout] | ---------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 25 | SyntaxError { line: usize, message: String }, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 26 | #[error("Unknown state reference: {0}")] [INFO] [stdout] 27 | UnknownState(String), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParseError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / match item.as_rule() { [INFO] [stdout] 65 | | Rule::fsm_body => { [INFO] [stdout] 66 | | parse_fsm_body(item, &mut fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 ~ if item.as_rule() == Rule::fsm_body { [INFO] [stdout] 65 + parse_fsm_body(item, &mut fsm)?; [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / match item.as_rule() { [INFO] [stdout] 78 | | Rule::fsm_item => { [INFO] [stdout] 79 | | parse_fsm_item(item, fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 77 ~ if item.as_rule() == Rule::fsm_item { [INFO] [stdout] 78 + parse_fsm_item(item, fsm)?; [INFO] [stdout] 79 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser/mod.rs:126:13 [INFO] [stdout] | [INFO] [stdout] 126 | / if transition.source != "[*]" && !transition.source.starts_with("<<") { [INFO] [stdout] 127 | | if !fsm.states.iter().any(|s| s.name == transition.source) { [INFO] [stdout] 128 | | fsm.states [INFO] [stdout] 129 | | .push(State::new(&transition.source, StateType::Simple)); [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 126 ~ if transition.source != "[*]" && !transition.source.starts_with("<<") [INFO] [stdout] 127 ~ && !fsm.states.iter().any(|s| s.name == transition.source) { [INFO] [stdout] 128 | fsm.states [INFO] [stdout] 129 | .push(State::new(&transition.source, StateType::Simple)); [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser/mod.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | / if transition.target != "[*]" && !transition.target.starts_with("<<") { [INFO] [stdout] 133 | | if !fsm.states.iter().any(|s| s.name == transition.target) { [INFO] [stdout] 134 | | fsm.states [INFO] [stdout] 135 | | .push(State::new(&transition.target, StateType::Simple)); [INFO] [stdout] 136 | | } [INFO] [stdout] 137 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ if transition.target != "[*]" && !transition.target.starts_with("<<") [INFO] [stdout] 133 ~ && !fsm.states.iter().any(|s| s.name == transition.target) { [INFO] [stdout] 134 | fsm.states [INFO] [stdout] 135 | .push(State::new(&transition.target, StateType::Simple)); [INFO] [stdout] 136 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | / match item.as_rule() { [INFO] [stdout] 385 | | Rule::state_body_item => { [INFO] [stdout] 386 | | parse_state_body_item(item, state)?; [INFO] [stdout] ... | [INFO] [stdout] 389 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 384 ~ if item.as_rule() == Rule::state_body_item { [INFO] [stdout] 385 + parse_state_body_item(item, state)?; [INFO] [stdout] 386 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | / match item.as_rule() { [INFO] [stdout] 404 | | Rule::fsm_item => { [INFO] [stdout] 405 | | if let Some(ref mut sub_fsm) = state.sub_fsm { [INFO] [stdout] 406 | | parse_fsm_item(item, sub_fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 409 | | _ => {} [INFO] [stdout] 410 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 403 ~ if item.as_rule() == Rule::fsm_item { [INFO] [stdout] 404 + if let Some(ref mut sub_fsm) = state.sub_fsm { [INFO] [stdout] 405 + parse_fsm_item(item, sub_fsm)?; [INFO] [stdout] 406 + } [INFO] [stdout] 407 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser/mod.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | let mut inner_iter = inner.into_inner(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `collect_events` and `validate` are never used [INFO] [stdout] --> src/fsm/mod.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 30 | impl FsmDefinition { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn collect_events(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 70 | pub fn validate(&self) -> Result<(), Vec> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_composite` is never used [INFO] [stdout] --> src/fsm/mod.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 134 | impl State { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 148 | pub fn is_composite(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `with_event`, `with_guard`, and `with_action` are never used [INFO] [stdout] --> src/fsm/mod.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 185 | impl Transition { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 186 | pub fn new(source: impl Into, target: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 197 | pub fn with_event(mut self, event: Event) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 202 | pub fn with_guard(mut self, guard: Guard) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 207 | pub fn with_action(mut self, action: Action) -> Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/fsm/mod.rs:251:12 [INFO] [stdout] | [INFO] [stdout] 250 | impl Event { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 251 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/fsm/mod.rs:264:12 [INFO] [stdout] | [INFO] [stdout] 263 | impl Guard { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 264 | pub fn new(expression: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `with_params` are never used [INFO] [stdout] --> src/fsm/mod.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 280 | impl Action { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 281 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 288 | pub fn with_params(mut self, params: Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FsmContext` is never constructed [INFO] [stdout] --> src/fsm/mod.rs:296:12 [INFO] [stdout] | [INFO] [stdout] 296 | pub struct FsmContext { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/fsm/mod.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 305 | impl FsmContext { [INFO] [stdout] | ------------------------------ associated function in this implementation [INFO] [stdout] 306 | pub fn new(initial_state: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `with_data` is never used [INFO] [stdout] --> src/fsm/mod.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 315 | impl FsmContext { [INFO] [stdout] | --------------------- associated function in this implementation [INFO] [stdout] 316 | pub fn with_data(initial_state: impl Into, data: T) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `periodic`, and `auto_start_in` are never used [INFO] [stdout] --> src/fsm/mod.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 344 | impl Timer { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 345 | pub fn new(name: impl Into, duration_ms: u32, event: Event) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 355 | pub fn periodic(mut self) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 360 | pub fn auto_start_in(mut self, state: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_branch` and `add_else` are never used [INFO] [stdout] --> src/fsm/mod.rs:399:12 [INFO] [stdout] | [INFO] [stdout] 390 | impl ChoicePoint { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 399 | pub fn add_branch(mut self, guard: impl Into, target: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 408 | pub fn add_else(mut self, target: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `SyntaxError` and `UnknownState` are never constructed [INFO] [stdout] --> src/parser/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub enum ParseError { [INFO] [stdout] | ---------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 25 | SyntaxError { line: usize, message: String }, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 26 | #[error("Unknown state reference: {0}")] [INFO] [stdout] 27 | UnknownState(String), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParseError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `eframe::egui::ComboBox::from_id_source`: Renamed id_salt [INFO] [stdout] --> src/main.rs:1718:33 [INFO] [stdout] | [INFO] [stdout] 1718 | egui::ComboBox::from_id_source("layout_direction") [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `eframe::egui::DragValue::<'a>::clamp_range`: Use `range` instead [INFO] [stdout] --> src/main.rs:1770:93 [INFO] [stdout] | [INFO] [stdout] 1770 | ... ui.add(egui::DragValue::new(&mut self.sim.auto_period_s).speed(0.1).clamp_range(0.1..=10.0).prefix("period ").suffix("s")); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / match item.as_rule() { [INFO] [stdout] 65 | | Rule::fsm_body => { [INFO] [stdout] 66 | | parse_fsm_body(item, &mut fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 ~ if item.as_rule() == Rule::fsm_body { [INFO] [stdout] 65 + parse_fsm_body(item, &mut fsm)?; [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / match item.as_rule() { [INFO] [stdout] 78 | | Rule::fsm_item => { [INFO] [stdout] 79 | | parse_fsm_item(item, fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 77 ~ if item.as_rule() == Rule::fsm_item { [INFO] [stdout] 78 + parse_fsm_item(item, fsm)?; [INFO] [stdout] 79 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser/mod.rs:126:13 [INFO] [stdout] | [INFO] [stdout] 126 | / if transition.source != "[*]" && !transition.source.starts_with("<<") { [INFO] [stdout] 127 | | if !fsm.states.iter().any(|s| s.name == transition.source) { [INFO] [stdout] 128 | | fsm.states [INFO] [stdout] 129 | | .push(State::new(&transition.source, StateType::Simple)); [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 126 ~ if transition.source != "[*]" && !transition.source.starts_with("<<") [INFO] [stdout] 127 ~ && !fsm.states.iter().any(|s| s.name == transition.source) { [INFO] [stdout] 128 | fsm.states [INFO] [stdout] 129 | .push(State::new(&transition.source, StateType::Simple)); [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser/mod.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | / if transition.target != "[*]" && !transition.target.starts_with("<<") { [INFO] [stdout] 133 | | if !fsm.states.iter().any(|s| s.name == transition.target) { [INFO] [stdout] 134 | | fsm.states [INFO] [stdout] 135 | | .push(State::new(&transition.target, StateType::Simple)); [INFO] [stdout] 136 | | } [INFO] [stdout] 137 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ if transition.target != "[*]" && !transition.target.starts_with("<<") [INFO] [stdout] 133 ~ && !fsm.states.iter().any(|s| s.name == transition.target) { [INFO] [stdout] 134 | fsm.states [INFO] [stdout] 135 | .push(State::new(&transition.target, StateType::Simple)); [INFO] [stdout] 136 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | / match item.as_rule() { [INFO] [stdout] 385 | | Rule::state_body_item => { [INFO] [stdout] 386 | | parse_state_body_item(item, state)?; [INFO] [stdout] ... | [INFO] [stdout] 389 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 384 ~ if item.as_rule() == Rule::state_body_item { [INFO] [stdout] 385 + parse_state_body_item(item, state)?; [INFO] [stdout] 386 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | / match item.as_rule() { [INFO] [stdout] 404 | | Rule::fsm_item => { [INFO] [stdout] 405 | | if let Some(ref mut sub_fsm) = state.sub_fsm { [INFO] [stdout] 406 | | parse_fsm_item(item, sub_fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 409 | | _ => {} [INFO] [stdout] 410 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 403 ~ if item.as_rule() == Rule::fsm_item { [INFO] [stdout] 404 + if let Some(ref mut sub_fsm) = state.sub_fsm { [INFO] [stdout] 405 + parse_fsm_item(item, sub_fsm)?; [INFO] [stdout] 406 + } [INFO] [stdout] 407 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `eframe::egui::ComboBox::from_id_source`: Renamed id_salt [INFO] [stdout] --> src/main.rs:1718:33 [INFO] [stdout] | [INFO] [stdout] 1718 | egui::ComboBox::from_id_source("layout_direction") [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `eframe::egui::DragValue::<'a>::clamp_range`: Use `range` instead [INFO] [stdout] --> src/main.rs:1770:93 [INFO] [stdout] | [INFO] [stdout] 1770 | ... ui.add(egui::DragValue::new(&mut self.sim.auto_period_s).speed(0.1).clamp_range(0.1..=10.0).prefix("period ").suffix("s")); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser/mod.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | let mut inner_iter = inner.into_inner(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser/mod.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | let mut inner_iter = inner.into_inner(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `max_level` [INFO] [stdout] --> src/main.rs:823:21 [INFO] [stdout] | [INFO] [stdout] 823 | let max_level = levels.values().max().copied().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_max_level` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `max_level` [INFO] [stdout] --> src/main.rs:823:21 [INFO] [stdout] | [INFO] [stdout] 823 | let max_level = levels.values().max().copied().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_max_level` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `label` is never read [INFO] [stdout] --> src/main.rs:315:5 [INFO] [stdout] | [INFO] [stdout] 311 | struct SimFired { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 315 | label: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SimFired` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `calculate_state_positions` and `apply_force_layout` are never used [INFO] [stdout] --> src/main.rs:778:8 [INFO] [stdout] | [INFO] [stdout] 340 | impl OxidateApp { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 778 | fn calculate_state_positions(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 848 | fn apply_force_layout(&mut self, levels: &std::collections::HashMap, min_x: f32, min_y: f32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `width` and `height` are never read [INFO] [stdout] --> src/main.rs:527:13 [INFO] [stdout] | [INFO] [stdout] 526 | struct JsGraphOut { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 527 | width: f32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 528 | height: f32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x` and `y` are never read [INFO] [stdout] --> src/main.rs:537:13 [INFO] [stdout] | [INFO] [stdout] 532 | struct JsEdgeOut { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 537 | x: Option, [INFO] [stdout] | ^ [INFO] [stdout] 538 | y: Option, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `graph` is never read [INFO] [stdout] --> src/main.rs:543:13 [INFO] [stdout] | [INFO] [stdout] 542 | struct JsLayoutOutput { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 543 | graph: JsGraphOut, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `StateBox` is never constructed [INFO] [stdout] --> src/main.rs:2016:8 [INFO] [stdout] | [INFO] [stdout] 2016 | struct StateBox { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LaneAllocator` is never constructed [INFO] [stdout] --> src/main.rs:2021:8 [INFO] [stdout] | [INFO] [stdout] 2021 | struct LaneAllocator { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `allocate_horizontal_lane`, and `allocate_vertical_lane` are never used [INFO] [stdout] --> src/main.rs:2031:8 [INFO] [stdout] | [INFO] [stdout] 2030 | impl LaneAllocator { [INFO] [stdout] | ------------------ associated items in this implementation [INFO] [stdout] 2031 | fn new(zoom: f32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 2040 | fn allocate_horizontal_lane(&mut self, preferred_y: f32) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2073 | fn allocate_vertical_lane(&mut self, preferred_x: f32) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_relative_position` is never used [INFO] [stdout] --> src/main.rs:2105:4 [INFO] [stdout] | [INFO] [stdout] 2105 | fn get_relative_position(from: egui::Pos2, to: egui::Pos2) -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_orthogonal_route_with_lanes` is never used [INFO] [stdout] --> src/main.rs:2117:4 [INFO] [stdout] | [INFO] [stdout] 2117 | fn calculate_orthogonal_route_with_lanes( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Return` is never constructed [INFO] [stdout] --> src/main.rs:2285:5 [INFO] [stdout] | [INFO] [stdout] 2283 | enum TransitionType { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 2284 | Forward, // Main flow - straight arrows [INFO] [stdout] 2285 | Return, // Return transitions - curved arrows [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransitionType` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `classify_transition` is never used [INFO] [stdout] --> src/main.rs:2296:4 [INFO] [stdout] | [INFO] [stdout] 2296 | fn classify_transition(transition: &fsm::Transition, is_reverse: bool) -> TransitionType { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_label_position` is never used [INFO] [stdout] --> src/main.rs:2326:4 [INFO] [stdout] | [INFO] [stdout] 2326 | fn calculate_label_position( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_label_info_orthogonal` is never used [INFO] [stdout] --> src/main.rs:2455:4 [INFO] [stdout] | [INFO] [stdout] 2455 | fn calculate_label_info_orthogonal( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `rects_overlap_with_margin` is never used [INFO] [stdout] --> src/main.rs:2500:4 [INFO] [stdout] | [INFO] [stdout] 2500 | fn rects_overlap_with_margin(a: &egui::Rect, b: &egui::Rect, margin: f32) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `overlap_depth` is never used [INFO] [stdout] --> src/main.rs:2506:4 [INFO] [stdout] | [INFO] [stdout] 2506 | fn overlap_depth(a: &egui::Rect, b: &egui::Rect) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `resolve_label_overlaps` is never used [INFO] [stdout] --> src/main.rs:2518:4 [INFO] [stdout] | [INFO] [stdout] 2518 | fn resolve_label_overlaps(labels: &mut [LabelInfo], state_boxes: &[StateBox]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `draw_orthogonal_arrow` is never used [INFO] [stdout] --> src/main.rs:2608:4 [INFO] [stdout] | [INFO] [stdout] 2608 | fn draw_orthogonal_arrow(painter: &egui::Painter, route: &[egui::Pos2], zoom: f32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_state_levels` is never used [INFO] [stdout] --> src/main.rs:2720:4 [INFO] [stdout] | [INFO] [stdout] 2720 | fn calculate_state_levels(fsm: &fsm::FsmDefinition) -> std::collections::HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_state_rect` is never used [INFO] [stdout] --> src/main.rs:2773:4 [INFO] [stdout] | [INFO] [stdout] 2773 | fn calculate_state_rect(state: &fsm::State, pos: egui::Pos2, zoom: f32) -> egui::Rect { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `collect_events` and `validate` are never used [INFO] [stdout] --> src/fsm/mod.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 30 | impl FsmDefinition { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn collect_events(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 70 | pub fn validate(&self) -> Result<(), Vec> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_composite` is never used [INFO] [stdout] --> src/fsm/mod.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 134 | impl State { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 148 | pub fn is_composite(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `with_event`, `with_guard`, and `with_action` are never used [INFO] [stdout] --> src/fsm/mod.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 185 | impl Transition { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 186 | pub fn new(source: impl Into, target: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 197 | pub fn with_event(mut self, event: Event) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 202 | pub fn with_guard(mut self, guard: Guard) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 207 | pub fn with_action(mut self, action: Action) -> Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/fsm/mod.rs:251:12 [INFO] [stdout] | [INFO] [stdout] 250 | impl Event { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 251 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/fsm/mod.rs:264:12 [INFO] [stdout] | [INFO] [stdout] 263 | impl Guard { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 264 | pub fn new(expression: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `with_params` are never used [INFO] [stdout] --> src/fsm/mod.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 280 | impl Action { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 281 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 288 | pub fn with_params(mut self, params: Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FsmContext` is never constructed [INFO] [stdout] --> src/fsm/mod.rs:296:12 [INFO] [stdout] | [INFO] [stdout] 296 | pub struct FsmContext { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/fsm/mod.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 305 | impl FsmContext { [INFO] [stdout] | ------------------------------ associated function in this implementation [INFO] [stdout] 306 | pub fn new(initial_state: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `with_data` is never used [INFO] [stdout] --> src/fsm/mod.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 315 | impl FsmContext { [INFO] [stdout] | --------------------- associated function in this implementation [INFO] [stdout] 316 | pub fn with_data(initial_state: impl Into, data: T) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `periodic`, and `auto_start_in` are never used [INFO] [stdout] --> src/fsm/mod.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 344 | impl Timer { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 345 | pub fn new(name: impl Into, duration_ms: u32, event: Event) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 355 | pub fn periodic(mut self) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 360 | pub fn auto_start_in(mut self, state: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_branch` and `add_else` are never used [INFO] [stdout] --> src/fsm/mod.rs:399:12 [INFO] [stdout] | [INFO] [stdout] 390 | impl ChoicePoint { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 399 | pub fn add_branch(mut self, guard: impl Into, target: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 408 | pub fn add_else(mut self, target: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `SyntaxError` and `UnknownState` are never constructed [INFO] [stdout] --> src/parser/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub enum ParseError { [INFO] [stdout] | ---------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 25 | SyntaxError { line: usize, message: String }, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 26 | #[error("Unknown state reference: {0}")] [INFO] [stdout] 27 | UnknownState(String), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParseError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_available` and `upgrade_message` are never used [INFO] [stdout] --> src/codegen/mod.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 33 | impl CodegenTarget { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] 34 | /// Check if target is available (premium features) [INFO] [stdout] 35 | pub fn is_available(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | pub fn upgrade_message(&self) -> Option<&'static str> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `generate_rust_code` is never used [INFO] [stdout] --> src/codegen/mod.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn generate_rust_code(fsm: &FsmDefinition) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `label` is never read [INFO] [stdout] --> src/main.rs:315:5 [INFO] [stdout] | [INFO] [stdout] 311 | struct SimFired { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 315 | label: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SimFired` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `calculate_state_positions` and `apply_force_layout` are never used [INFO] [stdout] --> src/main.rs:778:8 [INFO] [stdout] | [INFO] [stdout] 340 | impl OxidateApp { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 778 | fn calculate_state_positions(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 848 | fn apply_force_layout(&mut self, levels: &std::collections::HashMap, min_x: f32, min_y: f32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `width` and `height` are never read [INFO] [stdout] --> src/main.rs:527:13 [INFO] [stdout] | [INFO] [stdout] 526 | struct JsGraphOut { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 527 | width: f32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 528 | height: f32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x` and `y` are never read [INFO] [stdout] --> src/main.rs:537:13 [INFO] [stdout] | [INFO] [stdout] 532 | struct JsEdgeOut { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 537 | x: Option, [INFO] [stdout] | ^ [INFO] [stdout] 538 | y: Option, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `graph` is never read [INFO] [stdout] --> src/main.rs:543:13 [INFO] [stdout] | [INFO] [stdout] 542 | struct JsLayoutOutput { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 543 | graph: JsGraphOut, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `StateBox` is never constructed [INFO] [stdout] --> src/main.rs:2016:8 [INFO] [stdout] | [INFO] [stdout] 2016 | struct StateBox { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LaneAllocator` is never constructed [INFO] [stdout] --> src/main.rs:2021:8 [INFO] [stdout] | [INFO] [stdout] 2021 | struct LaneAllocator { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `allocate_horizontal_lane`, and `allocate_vertical_lane` are never used [INFO] [stdout] --> src/main.rs:2031:8 [INFO] [stdout] | [INFO] [stdout] 2030 | impl LaneAllocator { [INFO] [stdout] | ------------------ associated items in this implementation [INFO] [stdout] 2031 | fn new(zoom: f32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 2040 | fn allocate_horizontal_lane(&mut self, preferred_y: f32) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2073 | fn allocate_vertical_lane(&mut self, preferred_x: f32) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_relative_position` is never used [INFO] [stdout] --> src/main.rs:2105:4 [INFO] [stdout] | [INFO] [stdout] 2105 | fn get_relative_position(from: egui::Pos2, to: egui::Pos2) -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_orthogonal_route_with_lanes` is never used [INFO] [stdout] --> src/main.rs:2117:4 [INFO] [stdout] | [INFO] [stdout] 2117 | fn calculate_orthogonal_route_with_lanes( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Return` is never constructed [INFO] [stdout] --> src/main.rs:2285:5 [INFO] [stdout] | [INFO] [stdout] 2283 | enum TransitionType { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 2284 | Forward, // Main flow - straight arrows [INFO] [stdout] 2285 | Return, // Return transitions - curved arrows [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransitionType` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `classify_transition` is never used [INFO] [stdout] --> src/main.rs:2296:4 [INFO] [stdout] | [INFO] [stdout] 2296 | fn classify_transition(transition: &fsm::Transition, is_reverse: bool) -> TransitionType { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_label_position` is never used [INFO] [stdout] --> src/main.rs:2326:4 [INFO] [stdout] | [INFO] [stdout] 2326 | fn calculate_label_position( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_label_info_orthogonal` is never used [INFO] [stdout] --> src/main.rs:2455:4 [INFO] [stdout] | [INFO] [stdout] 2455 | fn calculate_label_info_orthogonal( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `rects_overlap_with_margin` is never used [INFO] [stdout] --> src/main.rs:2500:4 [INFO] [stdout] | [INFO] [stdout] 2500 | fn rects_overlap_with_margin(a: &egui::Rect, b: &egui::Rect, margin: f32) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `overlap_depth` is never used [INFO] [stdout] --> src/main.rs:2506:4 [INFO] [stdout] | [INFO] [stdout] 2506 | fn overlap_depth(a: &egui::Rect, b: &egui::Rect) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `resolve_label_overlaps` is never used [INFO] [stdout] --> src/main.rs:2518:4 [INFO] [stdout] | [INFO] [stdout] 2518 | fn resolve_label_overlaps(labels: &mut [LabelInfo], state_boxes: &[StateBox]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `draw_orthogonal_arrow` is never used [INFO] [stdout] --> src/main.rs:2608:4 [INFO] [stdout] | [INFO] [stdout] 2608 | fn draw_orthogonal_arrow(painter: &egui::Painter, route: &[egui::Pos2], zoom: f32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_state_levels` is never used [INFO] [stdout] --> src/main.rs:2720:4 [INFO] [stdout] | [INFO] [stdout] 2720 | fn calculate_state_levels(fsm: &fsm::FsmDefinition) -> std::collections::HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_state_rect` is never used [INFO] [stdout] --> src/main.rs:2773:4 [INFO] [stdout] | [INFO] [stdout] 2773 | fn calculate_state_rect(state: &fsm::State, pos: egui::Pos2, zoom: f32) -> egui::Rect { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_composite` is never used [INFO] [stdout] --> src/fsm/mod.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 134 | impl State { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 148 | pub fn is_composite(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `with_event`, `with_guard`, and `with_action` are never used [INFO] [stdout] --> src/fsm/mod.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 185 | impl Transition { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 186 | pub fn new(source: impl Into, target: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 197 | pub fn with_event(mut self, event: Event) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 202 | pub fn with_guard(mut self, guard: Guard) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 207 | pub fn with_action(mut self, action: Action) -> Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/fsm/mod.rs:251:12 [INFO] [stdout] | [INFO] [stdout] 250 | impl Event { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 251 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/fsm/mod.rs:264:12 [INFO] [stdout] | [INFO] [stdout] 263 | impl Guard { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 264 | pub fn new(expression: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `with_params` are never used [INFO] [stdout] --> src/fsm/mod.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 280 | impl Action { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 281 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 288 | pub fn with_params(mut self, params: Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FsmContext` is never constructed [INFO] [stdout] --> src/fsm/mod.rs:296:12 [INFO] [stdout] | [INFO] [stdout] 296 | pub struct FsmContext { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/fsm/mod.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 305 | impl FsmContext { [INFO] [stdout] | ------------------------------ associated function in this implementation [INFO] [stdout] 306 | pub fn new(initial_state: impl Into) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `with_data` is never used [INFO] [stdout] --> src/fsm/mod.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 315 | impl FsmContext { [INFO] [stdout] | --------------------- associated function in this implementation [INFO] [stdout] 316 | pub fn with_data(initial_state: impl Into, data: T) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `periodic`, and `auto_start_in` are never used [INFO] [stdout] --> src/fsm/mod.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 344 | impl Timer { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 345 | pub fn new(name: impl Into, duration_ms: u32, event: Event) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 355 | pub fn periodic(mut self) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 360 | pub fn auto_start_in(mut self, state: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_branch` and `add_else` are never used [INFO] [stdout] --> src/fsm/mod.rs:399:12 [INFO] [stdout] | [INFO] [stdout] 390 | impl ChoicePoint { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 399 | pub fn add_branch(mut self, guard: impl Into, target: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 408 | pub fn add_else(mut self, target: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `SyntaxError` and `UnknownState` are never constructed [INFO] [stdout] --> src/parser/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub enum ParseError { [INFO] [stdout] | ---------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 25 | SyntaxError { line: usize, message: String }, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 26 | #[error("Unknown state reference: {0}")] [INFO] [stdout] 27 | UnknownState(String), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParseError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_available` and `upgrade_message` are never used [INFO] [stdout] --> src/codegen/mod.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 33 | impl CodegenTarget { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] 34 | /// Check if target is available (premium features) [INFO] [stdout] 35 | pub fn is_available(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | pub fn upgrade_message(&self) -> Option<&'static str> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `generate_rust_code` is never used [INFO] [stdout] --> src/codegen/mod.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn generate_rust_code(fsm: &FsmDefinition) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / match item.as_rule() { [INFO] [stdout] 65 | | Rule::fsm_body => { [INFO] [stdout] 66 | | parse_fsm_body(item, &mut fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 ~ if item.as_rule() == Rule::fsm_body { [INFO] [stdout] 65 + parse_fsm_body(item, &mut fsm)?; [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / match item.as_rule() { [INFO] [stdout] 78 | | Rule::fsm_item => { [INFO] [stdout] 79 | | parse_fsm_item(item, fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 77 ~ if item.as_rule() == Rule::fsm_item { [INFO] [stdout] 78 + parse_fsm_item(item, fsm)?; [INFO] [stdout] 79 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser/mod.rs:126:13 [INFO] [stdout] | [INFO] [stdout] 126 | / if transition.source != "[*]" && !transition.source.starts_with("<<") { [INFO] [stdout] 127 | | if !fsm.states.iter().any(|s| s.name == transition.source) { [INFO] [stdout] 128 | | fsm.states [INFO] [stdout] 129 | | .push(State::new(&transition.source, StateType::Simple)); [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 126 ~ if transition.source != "[*]" && !transition.source.starts_with("<<") [INFO] [stdout] 127 ~ && !fsm.states.iter().any(|s| s.name == transition.source) { [INFO] [stdout] 128 | fsm.states [INFO] [stdout] 129 | .push(State::new(&transition.source, StateType::Simple)); [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser/mod.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | / if transition.target != "[*]" && !transition.target.starts_with("<<") { [INFO] [stdout] 133 | | if !fsm.states.iter().any(|s| s.name == transition.target) { [INFO] [stdout] 134 | | fsm.states [INFO] [stdout] 135 | | .push(State::new(&transition.target, StateType::Simple)); [INFO] [stdout] 136 | | } [INFO] [stdout] 137 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ if transition.target != "[*]" && !transition.target.starts_with("<<") [INFO] [stdout] 133 ~ && !fsm.states.iter().any(|s| s.name == transition.target) { [INFO] [stdout] 134 | fsm.states [INFO] [stdout] 135 | .push(State::new(&transition.target, StateType::Simple)); [INFO] [stdout] 136 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | / match item.as_rule() { [INFO] [stdout] 385 | | Rule::state_body_item => { [INFO] [stdout] 386 | | parse_state_body_item(item, state)?; [INFO] [stdout] ... | [INFO] [stdout] 389 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 384 ~ if item.as_rule() == Rule::state_body_item { [INFO] [stdout] 385 + parse_state_body_item(item, state)?; [INFO] [stdout] 386 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | / match item.as_rule() { [INFO] [stdout] 404 | | Rule::fsm_item => { [INFO] [stdout] 405 | | if let Some(ref mut sub_fsm) = state.sub_fsm { [INFO] [stdout] 406 | | parse_fsm_item(item, sub_fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 409 | | _ => {} [INFO] [stdout] 410 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 403 ~ if item.as_rule() == Rule::fsm_item { [INFO] [stdout] 404 + if let Some(ref mut sub_fsm) = state.sub_fsm { [INFO] [stdout] 405 + parse_fsm_item(item, sub_fsm)?; [INFO] [stdout] 406 + } [INFO] [stdout] 407 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/codegen/mod.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | / impl Default for CodegenTarget { [INFO] [stdout] 59 | | fn default() -> Self { [INFO] [stdout] 60 | | Self::Standard [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Default)] [INFO] [stdout] 25 | pub enum CodegenTarget { [INFO] [stdout] 26 | /// Standard Rust (std) - MIT licensed [INFO] [stdout] 27 ~ #[default] [INFO] [stdout] 28 ~ Standard, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/codegen/mod.rs:205:20 [INFO] [stdout] | [INFO] [stdout] 205 | code.push_str(&format!(" Self {{\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" Self {\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / match item.as_rule() { [INFO] [stdout] 65 | | Rule::fsm_body => { [INFO] [stdout] 66 | | parse_fsm_body(item, &mut fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 ~ if item.as_rule() == Rule::fsm_body { [INFO] [stdout] 65 + parse_fsm_body(item, &mut fsm)?; [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / match item.as_rule() { [INFO] [stdout] 78 | | Rule::fsm_item => { [INFO] [stdout] 79 | | parse_fsm_item(item, fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 77 ~ if item.as_rule() == Rule::fsm_item { [INFO] [stdout] 78 + parse_fsm_item(item, fsm)?; [INFO] [stdout] 79 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/codegen/mod.rs:374:12 [INFO] [stdout] | [INFO] [stdout] 374 | result.replace(' ', "_").replace('-', "_") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace([' ', '-'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser/mod.rs:126:13 [INFO] [stdout] | [INFO] [stdout] 126 | / if transition.source != "[*]" && !transition.source.starts_with("<<") { [INFO] [stdout] 127 | | if !fsm.states.iter().any(|s| s.name == transition.source) { [INFO] [stdout] 128 | | fsm.states [INFO] [stdout] 129 | | .push(State::new(&transition.source, StateType::Simple)); [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 126 ~ if transition.source != "[*]" && !transition.source.starts_with("<<") [INFO] [stdout] 127 ~ && !fsm.states.iter().any(|s| s.name == transition.source) { [INFO] [stdout] 128 | fsm.states [INFO] [stdout] 129 | .push(State::new(&transition.source, StateType::Simple)); [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser/mod.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | / if transition.target != "[*]" && !transition.target.starts_with("<<") { [INFO] [stdout] 133 | | if !fsm.states.iter().any(|s| s.name == transition.target) { [INFO] [stdout] 134 | | fsm.states [INFO] [stdout] 135 | | .push(State::new(&transition.target, StateType::Simple)); [INFO] [stdout] 136 | | } [INFO] [stdout] 137 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ if transition.target != "[*]" && !transition.target.starts_with("<<") [INFO] [stdout] 133 ~ && !fsm.states.iter().any(|s| s.name == transition.target) { [INFO] [stdout] 134 | fsm.states [INFO] [stdout] 135 | .push(State::new(&transition.target, StateType::Simple)); [INFO] [stdout] 136 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | / match item.as_rule() { [INFO] [stdout] 385 | | Rule::state_body_item => { [INFO] [stdout] 386 | | parse_state_body_item(item, state)?; [INFO] [stdout] ... | [INFO] [stdout] 389 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 384 ~ if item.as_rule() == Rule::state_body_item { [INFO] [stdout] 385 + parse_state_body_item(item, state)?; [INFO] [stdout] 386 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | / match item.as_rule() { [INFO] [stdout] 404 | | Rule::fsm_item => { [INFO] [stdout] 405 | | if let Some(ref mut sub_fsm) = state.sub_fsm { [INFO] [stdout] 406 | | parse_fsm_item(item, sub_fsm)?; [INFO] [stdout] ... | [INFO] [stdout] 409 | | _ => {} [INFO] [stdout] 410 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 403 ~ if item.as_rule() == Rule::fsm_item { [INFO] [stdout] 404 + if let Some(ref mut sub_fsm) = state.sub_fsm { [INFO] [stdout] 405 + parse_fsm_item(item, sub_fsm)?; [INFO] [stdout] 406 + } [INFO] [stdout] 407 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/codegen/mod.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | / impl Default for CodegenTarget { [INFO] [stdout] 59 | | fn default() -> Self { [INFO] [stdout] 60 | | Self::Standard [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Default)] [INFO] [stdout] 25 | pub enum CodegenTarget { [INFO] [stdout] 26 | /// Standard Rust (std) - MIT licensed [INFO] [stdout] 27 ~ #[default] [INFO] [stdout] 28 ~ Standard, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/codegen/mod.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | code.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/codegen/mod.rs:205:20 [INFO] [stdout] | [INFO] [stdout] 205 | code.push_str(&format!(" Self {{\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" Self {\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/codegen/mod.rs:374:12 [INFO] [stdout] | [INFO] [stdout] 374 | result.replace(' ', "_").replace('-', "_") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace([' ', '-'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/main.rs:819:35 [INFO] [stdout] | [INFO] [stdout] 819 | for (_, level) in &levels { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 819 - for (_, level) in &levels { [INFO] [stdout] 819 + for level in levels.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/main.rs:926:20 [INFO] [stdout] | [INFO] [stdout] 926 | .split(|c| c == ',' || c == ';' || c == '\n') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `[',', ';', '\n']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:1393:25 [INFO] [stdout] | [INFO] [stdout] 1393 | / if ui.button("✓ Create New (Replace)").clicked() { [INFO] [stdout] 1394 | | if !self.new_fsm_name.is_empty() { [INFO] [stdout] 1395 | | let names = self.new_fsm_name.clone(); [INFO] [stdout] 1396 | | self.create_new_fsms(&names); [INFO] [stdout] ... | [INFO] [stdout] 1399 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1393 ~ if ui.button("✓ Create New (Replace)").clicked() [INFO] [stdout] 1394 ~ && !self.new_fsm_name.is_empty() { [INFO] [stdout] 1395 | let names = self.new_fsm_name.clone(); [INFO] [stdout] 1396 | self.create_new_fsms(&names); [INFO] [stdout] 1397 | self.show_new_fsm_dialog = false; [INFO] [stdout] 1398 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:1400:25 [INFO] [stdout] | [INFO] [stdout] 1400 | / if ui.button("➕ Add to Existing").clicked() { [INFO] [stdout] 1401 | | if !self.new_fsm_name.is_empty() { [INFO] [stdout] 1402 | | // Add each FSM to existing code [INFO] [stdout] 1403 | | let names_str = self.new_fsm_name.clone(); [INFO] [stdout] ... | [INFO] [stdout] 1414 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1400 ~ if ui.button("➕ Add to Existing").clicked() [INFO] [stdout] 1401 ~ && !self.new_fsm_name.is_empty() { [INFO] [stdout] 1402 | // Add each FSM to existing code [INFO] [stdout] ... [INFO] [stdout] 1412 | self.show_new_fsm_dialog = false; [INFO] [stdout] 1413 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/main.rs:1405:44 [INFO] [stdout] | [INFO] [stdout] 1405 | ... .split(|c| c == ',' || c == ';' || c == '\n') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `[',', ';', '\n']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/main.rs:819:35 [INFO] [stdout] | [INFO] [stdout] 819 | for (_, level) in &levels { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 819 - for (_, level) in &levels { [INFO] [stdout] 819 + for level in levels.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/main.rs:926:20 [INFO] [stdout] | [INFO] [stdout] 926 | .split(|c| c == ',' || c == ';' || c == '\n') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `[',', ';', '\n']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> src/main.rs:1911:45 [INFO] [stdout] | [INFO] [stdout] 1911 | ... let is_active = self [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 1912 | | ... .sim [INFO] [stdout] 1913 | | ... .enabled [INFO] [stdout] 1914 | | ... .then(|| self.sim.current_state.as_deref() == Some(state.name.as_str())) [INFO] [stdout] 1915 | | ... .unwrap_or(false); [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] = note: `#[warn(clippy::obfuscated_if_else)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1911 ~ let is_active = if self [INFO] [stdout] 1912 + .sim [INFO] [stdout] 1913 ~ .enabled { self.sim.current_state.as_deref() == Some(state.name.as_str()) } else { false }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/main.rs:2290:1 [INFO] [stdout] | [INFO] [stdout] 2290 | / impl Default for TransitionType { [INFO] [stdout] 2291 | | fn default() -> Self { [INFO] [stdout] 2292 | | TransitionType::Forward [INFO] [stdout] 2293 | | } [INFO] [stdout] 2294 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 2283 + #[derive(Default)] [INFO] [stdout] 2284 | enum TransitionType { [INFO] [stdout] 2285 ~ #[default] [INFO] [stdout] 2286 ~ Forward, // Main flow - straight arrows [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:1393:25 [INFO] [stdout] | [INFO] [stdout] 1393 | / if ui.button("✓ Create New (Replace)").clicked() { [INFO] [stdout] 1394 | | if !self.new_fsm_name.is_empty() { [INFO] [stdout] 1395 | | let names = self.new_fsm_name.clone(); [INFO] [stdout] 1396 | | self.create_new_fsms(&names); [INFO] [stdout] ... | [INFO] [stdout] 1399 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1393 ~ if ui.button("✓ Create New (Replace)").clicked() [INFO] [stdout] 1394 ~ && !self.new_fsm_name.is_empty() { [INFO] [stdout] 1395 | let names = self.new_fsm_name.clone(); [INFO] [stdout] 1396 | self.create_new_fsms(&names); [INFO] [stdout] 1397 | self.show_new_fsm_dialog = false; [INFO] [stdout] 1398 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:1400:25 [INFO] [stdout] | [INFO] [stdout] 1400 | / if ui.button("➕ Add to Existing").clicked() { [INFO] [stdout] 1401 | | if !self.new_fsm_name.is_empty() { [INFO] [stdout] 1402 | | // Add each FSM to existing code [INFO] [stdout] 1403 | | let names_str = self.new_fsm_name.clone(); [INFO] [stdout] ... | [INFO] [stdout] 1414 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1400 ~ if ui.button("➕ Add to Existing").clicked() [INFO] [stdout] 1401 ~ && !self.new_fsm_name.is_empty() { [INFO] [stdout] 1402 | // Add each FSM to existing code [INFO] [stdout] ... [INFO] [stdout] 1412 | self.show_new_fsm_dialog = false; [INFO] [stdout] 1413 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/main.rs:1405:44 [INFO] [stdout] | [INFO] [stdout] 1405 | ... .split(|c| c == ',' || c == ';' || c == '\n') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `[',', ';', '\n']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:2742:18 [INFO] [stdout] | [INFO] [stdout] 2742 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> src/main.rs:1911:45 [INFO] [stdout] | [INFO] [stdout] 1911 | ... let is_active = self [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 1912 | | ... .sim [INFO] [stdout] 1913 | | ... .enabled [INFO] [stdout] 1914 | | ... .then(|| self.sim.current_state.as_deref() == Some(state.name.as_str())) [INFO] [stdout] 1915 | | ... .unwrap_or(false); [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] = note: `#[warn(clippy::obfuscated_if_else)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1911 ~ let is_active = if self [INFO] [stdout] 1912 + .sim [INFO] [stdout] 1913 ~ .enabled { self.sim.current_state.as_deref() == Some(state.name.as_str()) } else { false }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/main.rs:2290:1 [INFO] [stdout] | [INFO] [stdout] 2290 | / impl Default for TransitionType { [INFO] [stdout] 2291 | | fn default() -> Self { [INFO] [stdout] 2292 | | TransitionType::Forward [INFO] [stdout] 2293 | | } [INFO] [stdout] 2294 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 2283 + #[derive(Default)] [INFO] [stdout] 2284 | enum TransitionType { [INFO] [stdout] 2285 ~ #[default] [INFO] [stdout] 2286 ~ Forward, // Main flow - straight arrows [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:2742:18 [INFO] [stdout] | [INFO] [stdout] 2742 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 21s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: ashpd v0.8.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "9ab891ba7812af80b1889c8dc2d77514e6e608a3a92da291a7448e301a823a70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ab891ba7812af80b1889c8dc2d77514e6e608a3a92da291a7448e301a823a70", kill_on_drop: false }` [INFO] [stdout] 9ab891ba7812af80b1889c8dc2d77514e6e608a3a92da291a7448e301a823a70