[INFO] fetching crate oters_gui 0.1.8... [INFO] linting oters_gui-0.1.8 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate oters_gui 0.1.8 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate oters_gui 0.1.8 [INFO] finished tweaking crates.io crate oters_gui 0.1.8 [INFO] tweaked toml for crates.io crate oters_gui 0.1.8 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate oters_gui 0.1.8 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 138 packages to latest compatible versions [INFO] [stderr] Adding macroquad v0.3.26 (available: v0.4.14) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hound v3.5.1 [INFO] [stderr] Downloaded quad-alsa-sys v0.3.2 [INFO] [stderr] Downloaded oters_macro v0.1.8 [INFO] [stderr] Downloaded dasp_frame v0.11.0 [INFO] [stderr] Downloaded macroquad_macro v0.1.8 [INFO] [stderr] Downloaded quad-rand v0.2.3 [INFO] [stderr] Downloaded daggy v0.8.1 [INFO] [stderr] Downloaded audir-sles v0.1.0 [INFO] [stderr] Downloaded ena v0.14.4 [INFO] [stderr] Downloaded audrey v0.3.0 [INFO] [stderr] Downloaded oters_lang v0.1.8 [INFO] [stderr] Downloaded ogg v0.7.1 [INFO] [stderr] Downloaded fontdue v0.7.3 [INFO] [stderr] Downloaded lewton v0.9.4 [INFO] [stderr] Downloaded miniquad v0.3.16 [INFO] [stderr] Downloaded macroquad v0.3.26 [INFO] [stderr] Downloaded quad-snd v0.2.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 529f4d42f0fcd78cfd6ee83a0d167f27bca03606635232d49a600d6a279fa16f [INFO] running `Command { std: "docker" "start" "-a" "529f4d42f0fcd78cfd6ee83a0d167f27bca03606635232d49a600d6a279fa16f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "529f4d42f0fcd78cfd6ee83a0d167f27bca03606635232d49a600d6a279fa16f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "529f4d42f0fcd78cfd6ee83a0d167f27bca03606635232d49a600d6a279fa16f", kill_on_drop: false }` [INFO] [stdout] 529f4d42f0fcd78cfd6ee83a0d167f27bca03606635232d49a600d6a279fa16f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac73dfe4cca74b7e9b030c43f28f4eb8d46340c89e9a2831b1c73b7814032c37 [INFO] running `Command { std: "docker" "start" "-a" "ac73dfe4cca74b7e9b030c43f28f4eb8d46340c89e9a2831b1c73b7814032c37", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling cfg-if v1.0.4 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Compiling regex-syntax v0.8.10 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Compiling hashbrown v0.16.1 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Compiling equivalent v1.0.2 [INFO] [stderr] Compiling quad-alsa-sys v0.3.2 [INFO] [stderr] Compiling siphasher v1.0.2 [INFO] [stderr] Checking ogg v0.7.1 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Checking lewton v0.9.4 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling ena v0.14.4 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking dasp_frame v0.11.0 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling miniquad v0.3.16 [INFO] [stderr] Compiling quad-snd v0.2.8 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling is-terminal v0.4.17 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling parking_lot v0.12.5 [INFO] [stderr] Checking audrey v0.3.0 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Compiling string_cache v0.8.9 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking ttf-parser v0.15.2 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking fixedbitset v0.5.7 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking petgraph v0.7.1 [INFO] [stderr] Checking bumpalo v3.20.2 [INFO] [stderr] Compiling macroquad_macro v0.1.8 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking quad-rand v0.2.3 [INFO] [stderr] Checking glam v0.21.3 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking daggy v0.8.1 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking fontdue v0.7.3 [INFO] [stderr] Compiling lalrpop-util v0.19.12 [INFO] [stderr] Checking macroquad v0.3.26 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling oters_macro v0.1.8 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Compiling oters_lang v0.1.8 [INFO] [stderr] Checking oters_gui v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/image.rs:71:53 [INFO] [stdout] | [INFO] [stdout] 71 | self.texture_map.push(Texture2D::from_image(&image)); [INFO] [stdout] | ^^^^^^ help: change this to: `image` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/image.rs:71:53 [INFO] [stdout] | [INFO] [stdout] 71 | self.texture_map.push(Texture2D::from_image(&image)); [INFO] [stdout] | ^^^^^^ help: change this to: `image` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Font` which implements the `Copy` trait [INFO] [stdout] --> src/text.rs:43:15 [INFO] [stdout] | [INFO] [stdout] 43 | font: FONTS.lock().unwrap()[font as usize].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `FONTS.lock().unwrap()[font as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Font` which implements the `Copy` trait [INFO] [stdout] --> src/text.rs:43:15 [INFO] [stdout] | [INFO] [stdout] 43 | font: FONTS.lock().unwrap()[font as usize].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `FONTS.lock().unwrap()[font as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/hgroup.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | if !(y + elem.size.1 > max_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(y + elem.size.1 <= max_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/hgroup.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 63 | if !(x + elem.size.0 > max_x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(x + elem.size.0 <= max_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/hgroup.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | if !(y + elem.size.1 > max_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(y + elem.size.1 <= max_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/hgroup.rs:72:16 [INFO] [stdout] | [INFO] [stdout] 72 | if !(g_pos.1 + PADDING + elem.size.1 > max_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(g_pos.1 + PADDING + elem.size.1 <= max_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/hgroup.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 63 | if !(x + elem.size.0 > max_x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(x + elem.size.0 <= max_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/hgroup.rs:72:16 [INFO] [stdout] | [INFO] [stdout] 72 | if !(g_pos.1 + PADDING + elem.size.1 > max_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(g_pos.1 + PADDING + elem.size.1 <= max_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ui/hgroup.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / match elem.ty { [INFO] [stdout] 57 | | UIType::Separator => { [INFO] [stdout] 58 | | elem.size = (2, g_size.1 - 2 * PADDING); [INFO] [stdout] ... | [INFO] [stdout] 61 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 ~ if let UIType::Separator = elem.ty { [INFO] [stdout] 57 + elem.size = (2, g_size.1 - 2 * PADDING); [INFO] [stdout] 58 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ui/hgroup.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / match elem.ty { [INFO] [stdout] 57 | | UIType::Separator => { [INFO] [stdout] 58 | | elem.size = (2, g_size.1 - 2 * PADDING); [INFO] [stdout] ... | [INFO] [stdout] 61 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 ~ if let UIType::Separator = elem.ty { [INFO] [stdout] 57 + elem.size = (2, g_size.1 - 2 * PADDING); [INFO] [stdout] 58 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/hgroup.rs:101:32 [INFO] [stdout] | [INFO] [stdout] 101 | if y >= elem.size.1 && !(y - elem.size.1 < min_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(y - elem.size.1 >= min_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/hgroup.rs:101:32 [INFO] [stdout] | [INFO] [stdout] 101 | if y >= elem.size.1 && !(y - elem.size.1 < min_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(y - elem.size.1 >= min_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/hgroup.rs:102:16 [INFO] [stdout] | [INFO] [stdout] 102 | if !(x + elem.size.0 > max_x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(x + elem.size.0 <= max_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/hgroup.rs:102:16 [INFO] [stdout] | [INFO] [stdout] 102 | if !(x + elem.size.0 > max_x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(x + elem.size.0 <= max_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/hgroup.rs:111:16 [INFO] [stdout] | [INFO] [stdout] 111 | if !(g_pos.1 + g_size.1 - PADDING - elem.size.1 < min_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(g_pos.1 + g_size.1 - PADDING - elem.size.1 >= min_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/hgroup.rs:111:16 [INFO] [stdout] | [INFO] [stdout] 111 | if !(g_pos.1 + g_size.1 - PADDING - elem.size.1 < min_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(g_pos.1 + g_size.1 - PADDING - elem.size.1 >= min_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ui/hgroup.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / match elem.ty { [INFO] [stdout] 96 | | UIType::Separator => { [INFO] [stdout] 97 | | elem.size = (2, g_size.1 - 2 * PADDING); [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 95 ~ if let UIType::Separator = elem.ty { [INFO] [stdout] 96 + elem.size = (2, g_size.1 - 2 * PADDING); [INFO] [stdout] 97 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ui/hgroup.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / match elem.ty { [INFO] [stdout] 96 | | UIType::Separator => { [INFO] [stdout] 97 | | elem.size = (2, g_size.1 - 2 * PADDING); [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 95 ~ if let UIType::Separator = elem.ty { [INFO] [stdout] 96 + elem.size = (2, g_size.1 - 2 * PADDING); [INFO] [stdout] 97 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/vgroup.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if !(x + elem.size.0 > max_x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(x + elem.size.0 <= max_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/vgroup.rs:62:16 [INFO] [stdout] | [INFO] [stdout] 62 | if !(y + elem.size.1 > max_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(y + elem.size.1 <= max_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/vgroup.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 71 | if !(g_pos.0 + PADDING + elem.size.0 > max_x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(g_pos.0 + PADDING + elem.size.0 <= max_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ui/vgroup.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / match elem.ty { [INFO] [stdout] 56 | | UIType::Separator => { [INFO] [stdout] 57 | | elem.size = (g_size.0 - 2 * PADDING, 2); [INFO] [stdout] ... | [INFO] [stdout] 60 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 ~ if let UIType::Separator = elem.ty { [INFO] [stdout] 56 + elem.size = (g_size.0 - 2 * PADDING, 2); [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/vgroup.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if !(x + elem.size.0 > max_x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(x + elem.size.0 <= max_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/vgroup.rs:62:16 [INFO] [stdout] | [INFO] [stdout] 62 | if !(y + elem.size.1 > max_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(y + elem.size.1 <= max_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/vgroup.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 71 | if !(g_pos.0 + PADDING + elem.size.0 > max_x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(g_pos.0 + PADDING + elem.size.0 <= max_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/vgroup.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 100 | if x > elem.size.0 && !(x - elem.size.0 < min_x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(x - elem.size.0 >= min_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ui/vgroup.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / match elem.ty { [INFO] [stdout] 56 | | UIType::Separator => { [INFO] [stdout] 57 | | elem.size = (g_size.0 - 2 * PADDING, 2); [INFO] [stdout] ... | [INFO] [stdout] 60 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 ~ if let UIType::Separator = elem.ty { [INFO] [stdout] 56 + elem.size = (g_size.0 - 2 * PADDING, 2); [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/vgroup.rs:101:16 [INFO] [stdout] | [INFO] [stdout] 101 | if !(y + elem.size.1 > max_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(y + elem.size.1 <= max_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/vgroup.rs:110:16 [INFO] [stdout] | [INFO] [stdout] 110 | if !(g_pos.0 + g_size.0 - PADDING - elem.size.0 < min_x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(g_pos.0 + g_size.0 - PADDING - elem.size.0 >= min_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/vgroup.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 100 | if x > elem.size.0 && !(x - elem.size.0 < min_x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(x - elem.size.0 >= min_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/vgroup.rs:101:16 [INFO] [stdout] | [INFO] [stdout] 101 | if !(y + elem.size.1 > max_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(y + elem.size.1 <= max_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/vgroup.rs:110:16 [INFO] [stdout] | [INFO] [stdout] 110 | if !(g_pos.0 + g_size.0 - PADDING - elem.size.0 < min_x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(g_pos.0 + g_size.0 - PADDING - elem.size.0 >= min_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ui/vgroup.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | / match elem.ty { [INFO] [stdout] 95 | | UIType::Separator => { [INFO] [stdout] 96 | | elem.size = (g_size.0 - 2 * PADDING, 2); [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 ~ if let UIType::Separator = elem.ty { [INFO] [stdout] 95 + elem.size = (g_size.0 - 2 * PADDING, 2); [INFO] [stdout] 96 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ui/vgroup.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | / match elem.ty { [INFO] [stdout] 95 | | UIType::Separator => { [INFO] [stdout] 96 | | elem.size = (g_size.0 - 2 * PADDING, 2); [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 ~ if let UIType::Separator = elem.ty { [INFO] [stdout] 95 + elem.size = (g_size.0 - 2 * PADDING, 2); [INFO] [stdout] 96 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `exports` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 199 | if exports.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = exports` [INFO] [stdout] 200 | pefs.extend( [INFO] [stdout] 201 | / exports [INFO] [stdout] 202 | | .unwrap() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:198:34 [INFO] [stdout] | [INFO] [stdout] 198 | .map_err(|e| e.to_anyhow(&source))?; [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `exports` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 199 | if exports.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = exports` [INFO] [stdout] 200 | pefs.extend( [INFO] [stdout] 201 | / exports [INFO] [stdout] 202 | | .unwrap() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:198:34 [INFO] [stdout] | [INFO] [stdout] 198 | .map_err(|e| e.to_anyhow(&source))?; [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 41s [INFO] running `Command { std: "docker" "inspect" "ac73dfe4cca74b7e9b030c43f28f4eb8d46340c89e9a2831b1c73b7814032c37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac73dfe4cca74b7e9b030c43f28f4eb8d46340c89e9a2831b1c73b7814032c37", kill_on_drop: false }` [INFO] [stdout] ac73dfe4cca74b7e9b030c43f28f4eb8d46340c89e9a2831b1c73b7814032c37