[INFO] fetching crate option-symbology 0.2.0... [INFO] linting option-symbology-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate option-symbology 0.2.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate option-symbology 0.2.0 [INFO] finished tweaking crates.io crate option-symbology 0.2.0 [INFO] tweaked toml for crates.io crate option-symbology 0.2.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate option-symbology 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding fancy-regex v0.6.0 (available: v0.17.0) [INFO] [stderr] Adding strum v0.21.0 (available: v0.28.0) [INFO] [stderr] Adding strum_macros v0.21.1 (available: v0.28.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fancy-regex v0.6.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb58b24809a49858392297fcf4a2166e314a01705a1c677553aaf8f2da028d27 [INFO] running `Command { std: "docker" "start" "-a" "bb58b24809a49858392297fcf4a2166e314a01705a1c677553aaf8f2da028d27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb58b24809a49858392297fcf4a2166e314a01705a1c677553aaf8f2da028d27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb58b24809a49858392297fcf4a2166e314a01705a1c677553aaf8f2da028d27", kill_on_drop: false }` [INFO] [stdout] bb58b24809a49858392297fcf4a2166e314a01705a1c677553aaf8f2da028d27 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c3c014dd1fa74ccf1e9680328f9dac3585e61941b4ee0550a83d82f954d0e83b [INFO] running `Command { std: "docker" "start" "-a" "c3c014dd1fa74ccf1e9680328f9dac3585e61941b4ee0550a83d82f954d0e83b", kill_on_drop: false }` [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking strum v0.21.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling strum_macros v0.21.1 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking fancy-regex v0.6.0 [INFO] [stderr] Checking option-symbology v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: name `JAN` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | JAN = 1, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jan` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FEB` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | FEB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Feb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MAR` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | MAR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Mar` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `APR` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | APR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Apr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MAY` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | MAY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `May` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JUN` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | JUN, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jun` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JUL` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | JUL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jul` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AUG` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | AUG, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Aug` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEP` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | SEP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sep` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OCT` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | OCT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Oct` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOV` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | NOV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Nov` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | DEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JAN` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | JAN = 1, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jan` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FEB` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | FEB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Feb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MAR` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | MAR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Mar` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `APR` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | APR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Apr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MAY` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | MAY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `May` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JUN` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | JUN, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jun` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JUL` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | JUL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jul` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AUG` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | AUG, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Aug` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEP` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | SEP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sep` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OCT` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | OCT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Oct` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOV` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | NOV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Nov` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/options/mod.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | DEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/options/mod.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | / (1000 as f64), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `1000_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/options/mod.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | / (1000 as f64), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `1000_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/options/mod.rs:168:41 [INFO] [stdout] | [INFO] [stdout] 168 | price = self.strike_price * 1000 as f64 [INFO] [stdout] | ^^^^^^^^^^^ help: try: `1000_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/options/mod.rs:182:41 [INFO] [stdout] | [INFO] [stdout] 182 | price = self.strike_price * 1000 as f64 [INFO] [stdout] | ^^^^^^^^^^^ help: try: `1000_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/options/mod.rs:168:41 [INFO] [stdout] | [INFO] [stdout] 168 | price = self.strike_price * 1000 as f64 [INFO] [stdout] | ^^^^^^^^^^^ help: try: `1000_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/options/mod.rs:196:21 [INFO] [stdout] | [INFO] [stdout] 196 | price = self.strike_price as f64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ self.strike_price }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/options/mod.rs:182:41 [INFO] [stdout] | [INFO] [stdout] 182 | price = self.strike_price * 1000 as f64 [INFO] [stdout] | ^^^^^^^^^^^ help: try: `1000_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/options/mod.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | if !(month >= 1 && month <= 12) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=12).contains(&month)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/options/mod.rs:196:21 [INFO] [stdout] | [INFO] [stdout] 196 | price = self.strike_price as f64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ self.strike_price }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/options/mod.rs:229:30 [INFO] [stdout] | [INFO] [stdout] 229 | return (year % 4 == 0 && !(year % 100 == 0)) || year % 400 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(year % 100 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/options/mod.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | return (year % 4 == 0 && !(year % 100 == 0)) || year % 400 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - return (year % 4 == 0 && !(year % 100 == 0)) || year % 400 == 0; [INFO] [stdout] 229 + (year % 4 == 0 && !(year % 100 == 0)) || year % 400 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/options/mod.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | if !(month >= 1 && month <= 12) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=12).contains(&month)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/options/mod.rs:229:30 [INFO] [stdout] | [INFO] [stdout] 229 | return (year % 4 == 0 && !(year % 100 == 0)) || year % 400 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(year % 100 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/options/mod.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | return (year % 4 == 0 && !(year % 100 == 0)) || year % 400 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - return (year % 4 == 0 && !(year % 100 == 0)) || year % 400 == 0; [INFO] [stdout] 229 + (year % 4 == 0 && !(year % 100 == 0)) || year % 400 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/options/mod.rs:235:5 [INFO] [stdout] | [INFO] [stdout] 235 | / return day > 0 [INFO] [stdout] 236 | | && ( [INFO] [stdout] 237 | | (month == 2 && [INFO] [stdout] 238 | | (day <= 28 || day == 29 && is_leap_year(year))) [INFO] [stdout] 239 | | || (month != 2 && [INFO] [stdout] 240 | | ( day <= 30 || day == 31 && MONTH_WITH_31_DAYS.contains(&month))) [INFO] [stdout] 241 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 235 ~ day > 0 [INFO] [stdout] 236 + && ( [INFO] [stdout] 237 + (month == 2 && [INFO] [stdout] 238 + (day <= 28 || day == 29 && is_leap_year(year))) [INFO] [stdout] 239 + || (month != 2 && [INFO] [stdout] 240 + ( day <= 30 || day == 31 && MONTH_WITH_31_DAYS.contains(&month))) [INFO] [stdout] 241 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/options/mod.rs:235:5 [INFO] [stdout] | [INFO] [stdout] 235 | / return day > 0 [INFO] [stdout] 236 | | && ( [INFO] [stdout] 237 | | (month == 2 && [INFO] [stdout] 238 | | (day <= 28 || day == 29 && is_leap_year(year))) [INFO] [stdout] 239 | | || (month != 2 && [INFO] [stdout] 240 | | ( day <= 30 || day == 31 && MONTH_WITH_31_DAYS.contains(&month))) [INFO] [stdout] 241 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 235 ~ day > 0 [INFO] [stdout] 236 + && ( [INFO] [stdout] 237 + (month == 2 && [INFO] [stdout] 238 + (day <= 28 || day == 29 && is_leap_year(year))) [INFO] [stdout] 239 + || (month != 2 && [INFO] [stdout] 240 + ( day <= 30 || day == 31 && MONTH_WITH_31_DAYS.contains(&month))) [INFO] [stdout] 241 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/options/tests.rs:6:23 [INFO] [stdout] | [INFO] [stdout] 6 | strike_price: 470 as f64, [INFO] [stdout] | ^^^^^^^^^^ help: try: `470_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/options/tests.rs:23:23 [INFO] [stdout] | [INFO] [stdout] 23 | strike_price: 470 as f64, [INFO] [stdout] | ^^^^^^^^^^ help: try: `470_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/options/tests.rs:44:23 [INFO] [stdout] | [INFO] [stdout] 44 | strike_price: 470 as f64, [INFO] [stdout] | ^^^^^^^^^^ help: try: `470_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/options/tests.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | strike_price: 470 as f64, [INFO] [stdout] | ^^^^^^^^^^ help: try: `470_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/options/tests.rs:78:23 [INFO] [stdout] | [INFO] [stdout] 78 | strike_price: 470 as f64, [INFO] [stdout] | ^^^^^^^^^^ help: try: `470_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/options/tests.rs:97:23 [INFO] [stdout] | [INFO] [stdout] 97 | strike_price: 470 as f64, [INFO] [stdout] | ^^^^^^^^^^ help: try: `470_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/options/tests.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | assert_eq!(true, is_leap_year(2000)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 113 - assert_eq!(true, is_leap_year(2000)); [INFO] [stdout] 113 + assert!(is_leap_year(2000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/options/tests.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | assert_eq!(true, is_leap_year(2004)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 114 - assert_eq!(true, is_leap_year(2004)); [INFO] [stdout] 114 + assert!(is_leap_year(2004)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/options/tests.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | assert_eq!(false, is_leap_year(2100)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 115 - assert_eq!(false, is_leap_year(2100)); [INFO] [stdout] 115 + assert!(!is_leap_year(2100)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/options/tests.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 116 | assert_eq!(false, is_leap_year(2021)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 116 - assert_eq!(false, is_leap_year(2021)); [INFO] [stdout] 116 + assert!(!is_leap_year(2021)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/options/tests.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | assert_eq!(true, is_day_in_month_and_year(2000, 2, 29)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 120 - assert_eq!(true, is_day_in_month_and_year(2000, 2, 29)); [INFO] [stdout] 120 + assert!(is_day_in_month_and_year(2000, 2, 29)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/options/tests.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | assert_eq!(false, is_day_in_month_and_year(2001, 2, 29)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 121 - assert_eq!(false, is_day_in_month_and_year(2001, 2, 29)); [INFO] [stdout] 121 + assert!(!is_day_in_month_and_year(2001, 2, 29)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/options/tests.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | assert_eq!(false, is_day_in_month_and_year(2000, 2, 30)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 122 - assert_eq!(false, is_day_in_month_and_year(2000, 2, 30)); [INFO] [stdout] 122 + assert!(!is_day_in_month_and_year(2000, 2, 30)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/options/tests.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | assert_eq!(false, is_day_in_month_and_year(2000, 4, 31)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 123 - assert_eq!(false, is_day_in_month_and_year(2000, 4, 31)); [INFO] [stdout] 123 + assert!(!is_day_in_month_and_year(2000, 4, 31)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/options/tests.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | assert_eq!(true, is_day_in_month_and_year(2001, 8, 31)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 124 - assert_eq!(true, is_day_in_month_and_year(2001, 8, 31)); [INFO] [stdout] 124 + assert!(is_day_in_month_and_year(2001, 8, 31)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.77s [INFO] running `Command { std: "docker" "inspect" "c3c014dd1fa74ccf1e9680328f9dac3585e61941b4ee0550a83d82f954d0e83b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3c014dd1fa74ccf1e9680328f9dac3585e61941b4ee0550a83d82f954d0e83b", kill_on_drop: false }` [INFO] [stdout] c3c014dd1fa74ccf1e9680328f9dac3585e61941b4ee0550a83d82f954d0e83b