[INFO] fetching crate opt 0.1.0... [INFO] linting opt-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate opt 0.1.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate opt 0.1.0 [INFO] finished tweaking crates.io crate opt 0.1.0 [INFO] tweaked toml for crates.io crate opt 0.1.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate opt 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate opt 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num-complex v0.1.44 [INFO] [stderr] Downloaded spectral v0.6.0 [INFO] [stderr] Downloaded num-bigint v0.1.45 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b664ebd03abd8163d1483fb9f7cf870016a9c340ed9ab75274b3f62428958c6d [INFO] running `Command { std: "docker" "start" "-a" "b664ebd03abd8163d1483fb9f7cf870016a9c340ed9ab75274b3f62428958c6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b664ebd03abd8163d1483fb9f7cf870016a9c340ed9ab75274b3f62428958c6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b664ebd03abd8163d1483fb9f7cf870016a9c340ed9ab75274b3f62428958c6d", kill_on_drop: false }` [INFO] [stdout] b664ebd03abd8163d1483fb9f7cf870016a9c340ed9ab75274b3f62428958c6d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f38a7c851f76a1d61b787926f0acb255a29df3317ed252f50eefd4a6c35e15ff [INFO] running `Command { std: "docker" "start" "-a" "f38a7c851f76a1d61b787926f0acb255a29df3317ed252f50eefd4a6c35e15ff", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling num-bigint v0.1.45 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Compiling num-rational v0.1.43 [INFO] [stderr] Compiling num-complex v0.1.44 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking ndarray v0.17.2 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking num v0.1.43 [INFO] [stderr] Checking spectral v0.6.0 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking opt v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:431:9 [INFO] [stdout] | [INFO] [stdout] 431 | / match solve_with_shift(lambda_hi) { [INFO] [stdout] 432 | | Some(s) => { [INFO] [stdout] 433 | | let s_norm = s.dot(&s).sqrt(); [INFO] [stdout] 434 | | let pred = predicted(&s); [INFO] [stdout] ... | [INFO] [stdout] 440 | | None => {} [INFO] [stdout] 441 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 431 ~ if let Some(s) = solve_with_shift(lambda_hi) { [INFO] [stdout] 432 + let s_norm = s.dot(&s).sqrt(); [INFO] [stdout] 433 + let pred = predicted(&s); [INFO] [stdout] 434 + if s_norm.is_finite() && s_norm <= delta && pred.is_finite() && pred > 0.0 { [INFO] [stdout] 435 + best = Some((s, pred)); [INFO] [stdout] 436 + break; [INFO] [stdout] 437 + } [INFO] [stdout] 438 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/lib.rs:2628:5 [INFO] [stdout] | [INFO] [stdout] 2628 | / fn try_trust_region_step( [INFO] [stdout] 2629 | | &mut self, [INFO] [stdout] 2630 | | obj_fn: &mut ObjFn, [INFO] [stdout] 2631 | | oracle: &mut FirstOrderCache, [INFO] [stdout] ... | [INFO] [stdout] 2639 | | where [INFO] [stdout] 2640 | | ObjFn: FirstOrderObjective, [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:2762:17 [INFO] [stdout] | [INFO] [stdout] 2762 | self.chol_fail_iters = self.chol_fail_iters + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.chol_fail_iters += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:3001:13 [INFO] [stdout] | [INFO] [stdout] 3001 | p = p * (delta / p_norm); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `p *= (delta / p_norm)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:3825:17 [INFO] [stdout] | [INFO] [stdout] 3825 | self.no_improve_streak = self.no_improve_streak + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.no_improve_streak += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:3923:29 [INFO] [stdout] | [INFO] [stdout] 3923 | ... self.chol_fail_iters = self.chol_fail_iters + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.chol_fail_iters += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:3942:25 [INFO] [stdout] | [INFO] [stdout] 3942 | self.chol_fail_iters = self.chol_fail_iters + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.chol_fail_iters += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:4375:13 [INFO] [stdout] | [INFO] [stdout] 4375 | / if r.is_err() { [INFO] [stdout] 4376 | | if best.f.is_finite() { [INFO] [stdout] 4377 | | core.global_best = Some(best.clone()); [INFO] [stdout] 4378 | | } [INFO] [stdout] 4379 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4375 ~ if r.is_err() [INFO] [stdout] 4376 ~ && best.f.is_finite() { [INFO] [stdout] 4377 | core.global_best = Some(best.clone()); [INFO] [stdout] 4378 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:4560:13 [INFO] [stdout] | [INFO] [stdout] 4560 | / if r.is_err() { [INFO] [stdout] 4561 | | if best.f.is_finite() { [INFO] [stdout] 4562 | | core.global_best = Some(best.clone()); [INFO] [stdout] 4563 | | } [INFO] [stdout] 4564 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4560 ~ if r.is_err() [INFO] [stdout] 4561 ~ && best.f.is_finite() { [INFO] [stdout] 4562 | core.global_best = Some(best.clone()); [INFO] [stdout] 4563 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:5386:12 [INFO] [stdout] | [INFO] [stdout] 5386 | if !ok_f && !(core.relaxed_acceptors_enabled() && flat_f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(ok_f || core.relaxed_acceptors_enabled() && flat_f)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:431:9 [INFO] [stdout] | [INFO] [stdout] 431 | / match solve_with_shift(lambda_hi) { [INFO] [stdout] 432 | | Some(s) => { [INFO] [stdout] 433 | | let s_norm = s.dot(&s).sqrt(); [INFO] [stdout] 434 | | let pred = predicted(&s); [INFO] [stdout] ... | [INFO] [stdout] 440 | | None => {} [INFO] [stdout] 441 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 431 ~ if let Some(s) = solve_with_shift(lambda_hi) { [INFO] [stdout] 432 + let s_norm = s.dot(&s).sqrt(); [INFO] [stdout] 433 + let pred = predicted(&s); [INFO] [stdout] 434 + if s_norm.is_finite() && s_norm <= delta && pred.is_finite() && pred > 0.0 { [INFO] [stdout] 435 + best = Some((s, pred)); [INFO] [stdout] 436 + break; [INFO] [stdout] 437 + } [INFO] [stdout] 438 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/lib.rs:2628:5 [INFO] [stdout] | [INFO] [stdout] 2628 | / fn try_trust_region_step( [INFO] [stdout] 2629 | | &mut self, [INFO] [stdout] 2630 | | obj_fn: &mut ObjFn, [INFO] [stdout] 2631 | | oracle: &mut FirstOrderCache, [INFO] [stdout] ... | [INFO] [stdout] 2639 | | where [INFO] [stdout] 2640 | | ObjFn: FirstOrderObjective, [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:2762:17 [INFO] [stdout] | [INFO] [stdout] 2762 | self.chol_fail_iters = self.chol_fail_iters + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.chol_fail_iters += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:3001:13 [INFO] [stdout] | [INFO] [stdout] 3001 | p = p * (delta / p_norm); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `p *= (delta / p_norm)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:3825:17 [INFO] [stdout] | [INFO] [stdout] 3825 | self.no_improve_streak = self.no_improve_streak + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.no_improve_streak += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:3923:29 [INFO] [stdout] | [INFO] [stdout] 3923 | ... self.chol_fail_iters = self.chol_fail_iters + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.chol_fail_iters += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:3942:25 [INFO] [stdout] | [INFO] [stdout] 3942 | self.chol_fail_iters = self.chol_fail_iters + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.chol_fail_iters += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:4375:13 [INFO] [stdout] | [INFO] [stdout] 4375 | / if r.is_err() { [INFO] [stdout] 4376 | | if best.f.is_finite() { [INFO] [stdout] 4377 | | core.global_best = Some(best.clone()); [INFO] [stdout] 4378 | | } [INFO] [stdout] 4379 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4375 ~ if r.is_err() [INFO] [stdout] 4376 ~ && best.f.is_finite() { [INFO] [stdout] 4377 | core.global_best = Some(best.clone()); [INFO] [stdout] 4378 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:4560:13 [INFO] [stdout] | [INFO] [stdout] 4560 | / if r.is_err() { [INFO] [stdout] 4561 | | if best.f.is_finite() { [INFO] [stdout] 4562 | | core.global_best = Some(best.clone()); [INFO] [stdout] 4563 | | } [INFO] [stdout] 4564 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4560 ~ if r.is_err() [INFO] [stdout] 4561 ~ && best.f.is_finite() { [INFO] [stdout] 4562 | core.global_best = Some(best.clone()); [INFO] [stdout] 4563 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:5386:12 [INFO] [stdout] | [INFO] [stdout] 5386 | if !ok_f && !(core.relaxed_acceptors_enabled() && flat_f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(ok_f || core.relaxed_acceptors_enabled() && flat_f)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.31s [INFO] running `Command { std: "docker" "inspect" "f38a7c851f76a1d61b787926f0acb255a29df3317ed252f50eefd4a6c35e15ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f38a7c851f76a1d61b787926f0acb255a29df3317ed252f50eefd4a6c35e15ff", kill_on_drop: false }` [INFO] [stdout] f38a7c851f76a1d61b787926f0acb255a29df3317ed252f50eefd4a6c35e15ff