[INFO] fetching crate openmw-config 0.1.92... [INFO] linting openmw-config-0.1.92 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate openmw-config 0.1.92 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate openmw-config 0.1.92 [INFO] finished tweaking crates.io crate openmw-config 0.1.92 [INFO] tweaked toml for crates.io crate openmw-config 0.1.92 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate openmw-config 0.1.92 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate openmw-config 0.1.92 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libredox v0.1.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b7b7fab4feea8dc2dd62201d873cdb25e66176136667a653d8852991144841c2 [INFO] running `Command { std: "docker" "start" "-a" "b7b7fab4feea8dc2dd62201d873cdb25e66176136667a653d8852991144841c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b7b7fab4feea8dc2dd62201d873cdb25e66176136667a653d8852991144841c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7b7fab4feea8dc2dd62201d873cdb25e66176136667a653d8852991144841c2", kill_on_drop: false }` [INFO] [stdout] b7b7fab4feea8dc2dd62201d873cdb25e66176136667a653d8852991144841c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1091f7d00d8b7667948e8a960f3fab6e55c0c00f08b1e73ebb3063d488f35d6c [INFO] running `Command { std: "docker" "start" "-a" "1091f7d00d8b7667948e8a960f3fab6e55c0c00f08b1e73ebb3063d488f35d6c", kill_on_drop: false }` [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking shellexpand v3.1.1 [INFO] [stderr] Checking openmw-config v0.1.92 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config/directorysetting.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | source_config: source_config, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/config.rs:282:5 [INFO] [stdout] | [INFO] [stdout] 282 | / /// See https://openmw.readthedocs.io/en/latest/reference/modding/paths.html#configuration-sources for examples and further e... [INFO] [stdout] 283 | | [INFO] [stdout] | |_^ [INFO] [stdout] 284 | /// Path to the highest-level configuration *directory* [INFO] [stdout] 285 | pub fn user_config_path(&self) -> PathBuf { [INFO] [stdout] | ----------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 283 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config/directorysetting.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | source_config: source_config, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/config.rs:282:5 [INFO] [stdout] | [INFO] [stdout] 282 | / /// See https://openmw.readthedocs.io/en/latest/reference/modding/paths.html#configuration-sources for examples and further e... [INFO] [stdout] 283 | | [INFO] [stdout] | |_^ [INFO] [stdout] 284 | /// Path to the highest-level configuration *directory* [INFO] [stdout] 285 | pub fn user_config_path(&self) -> PathBuf { [INFO] [stdout] | ----------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 283 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `user_config_writable` is never used [INFO] [stdout] --> src/config/util.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn user_config_writable(path: &std::path::PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/gamesetting.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | / write!( [INFO] [stdout] 21 | | f, [INFO] [stdout] 22 | | "{}", [INFO] [stdout] 23 | | format!("{}fallback={},{r},{g},{b}", self.meta.comment, self.key) [INFO] [stdout] 24 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/gamesetting.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / write!( [INFO] [stdout] 38 | | f, [INFO] [stdout] 39 | | "{}", [INFO] [stdout] 40 | | format!("{}fallback={},{}", self.meta.comment, self.key, self.value) [INFO] [stdout] 41 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/gamesetting.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | / write!( [INFO] [stdout] 55 | | f, [INFO] [stdout] 56 | | "{}", [INFO] [stdout] 57 | | format!("{}fallback={},{}", self.meta.comment, self.key, self.value) [INFO] [stdout] 58 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/gamesetting.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / write!( [INFO] [stdout] 72 | | f, [INFO] [stdout] 73 | | "{}", [INFO] [stdout] 74 | | format!("{}fallback={},{}", self.meta.comment, self.key, self.value) [INFO] [stdout] 75 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stdout] --> src/config/gamesetting.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / match &self { [INFO] [stdout] 90 | | &GameSettingType::Color(setting) => &setting.key, [INFO] [stdout] 91 | | &GameSettingType::String(setting) => &setting.key, [INFO] [stdout] 92 | | &GameSettingType::Float(setting) => &setting.key, [INFO] [stdout] 93 | | &GameSettingType::Int(setting) => &setting.key, [INFO] [stdout] 94 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 89 ~ match self { [INFO] [stdout] 90 ~ GameSettingType::Color(setting) => &setting.key, [INFO] [stdout] 91 ~ GameSettingType::String(setting) => &setting.key, [INFO] [stdout] 92 ~ GameSettingType::Float(setting) => &setting.key, [INFO] [stdout] 93 ~ GameSettingType::Int(setting) => &setting.key, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stdout] --> src/config/gamesetting.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / match &self { [INFO] [stdout] 99 | | &GameSettingType::Color(setting) => { [INFO] [stdout] 100 | | let (r, g, b) = setting.value; [INFO] [stdout] 101 | | format!("{r},{g},{b}") [INFO] [stdout] ... | [INFO] [stdout] 105 | | &GameSettingType::Int(setting) => setting.value.to_string(), [INFO] [stdout] 106 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 98 ~ match self { [INFO] [stdout] 99 ~ GameSettingType::Color(setting) => { [INFO] [stdout] 100 | let (r, g, b) = setting.value; [INFO] [stdout] 101 | format!("{r},{g},{b}") [INFO] [stdout] 102 | } [INFO] [stdout] 103 ~ GameSettingType::String(setting) => setting.value.clone(), [INFO] [stdout] 104 ~ GameSettingType::Float(setting) => setting.value.to_string(), [INFO] [stdout] 105 ~ GameSettingType::Int(setting) => setting.value.to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/config/gamesetting.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | / if value.contains('.') { [INFO] [stdout] 193 | | if let Ok(f) = value.parse::() { [INFO] [stdout] 194 | | return Ok(GameSettingType::Float(FloatGameSetting { [INFO] [stdout] 195 | | meta, [INFO] [stdout] ... | [INFO] [stdout] 200 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 192 ~ if value.contains('.') [INFO] [stdout] 193 ~ && let Ok(f) = value.parse::() { [INFO] [stdout] 194 | return Ok(GameSettingType::Float(FloatGameSetting { [INFO] [stdout] ... [INFO] [stdout] 198 | })); [INFO] [stdout] 199 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/encodingsetting.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | / write!( [INFO] [stdout] 50 | | f, [INFO] [stdout] 51 | | "{}", [INFO] [stdout] 52 | | format!("{}encoding={}", self.meta.comment, self.encoding) [INFO] [stdout] 53 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `user_config_writable` is never used [INFO] [stdout] --> src/config/util.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn user_config_writable(path: &std::path::PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:125:61 [INFO] [stdout] | [INFO] [stdout] 125 | ConfigError::NotFileOrDirectory(config_path) => write!( [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 126 | | f, [INFO] [stdout] 127 | | "{}", [INFO] [stdout] 128 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 132 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | / write!( [INFO] [stdout] 135 | | f, [INFO] [stdout] 136 | | "{}", [INFO] [stdout] 137 | | format!("An openmw.cfg does not exist at: {}", config_path.display()) [INFO] [stdout] 138 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:140:72 [INFO] [stdout] | [INFO] [stdout] 140 | ConfigError::DuplicateContentFile { file, config_path } => write!( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 141 | | f, [INFO] [stdout] 142 | | "{}", [INFO] [stdout] 143 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 146 | | ), [INFO] [stdout] 147 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:148:72 [INFO] [stdout] | [INFO] [stdout] 148 | ConfigError::CannotAddContentFile { file, config_path } => write!( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 149 | | f, [INFO] [stdout] 150 | | "{}", [INFO] [stdout] 151 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 154 | | ), [INFO] [stdout] 155 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:156:76 [INFO] [stdout] | [INFO] [stdout] 156 | ConfigError::DuplicateGroundcoverFile { file, config_path } => write!( [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 157 | | f, [INFO] [stdout] 158 | | "{}", [INFO] [stdout] 159 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 162 | | ), [INFO] [stdout] 163 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:164:76 [INFO] [stdout] | [INFO] [stdout] 164 | ConfigError::CannotAddGroundcoverFile { file, config_path } => write!( [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 165 | | f, [INFO] [stdout] 166 | | "{}", [INFO] [stdout] 167 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 170 | | ), [INFO] [stdout] 171 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:172:72 [INFO] [stdout] | [INFO] [stdout] 172 | ConfigError::DuplicateArchiveFile { file, config_path } => write!( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 173 | | f, [INFO] [stdout] 174 | | "{}", [INFO] [stdout] 175 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 178 | | ), [INFO] [stdout] 179 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:180:72 [INFO] [stdout] | [INFO] [stdout] 180 | ConfigError::CannotAddArchiveFile { file, config_path } => write!( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 181 | | f, [INFO] [stdout] 182 | | "{}", [INFO] [stdout] 183 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 186 | | ), [INFO] [stdout] 187 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:189:17 [INFO] [stdout] | [INFO] [stdout] 189 | / write!( [INFO] [stdout] 190 | | f, [INFO] [stdout] 191 | | "{}", [INFO] [stdout] 192 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 195 | | ), [INFO] [stdout] 196 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 199 | / write!( [INFO] [stdout] 200 | | f, [INFO] [stdout] 201 | | "{}", [INFO] [stdout] 202 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 206 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a reference on `std::path::MAIN_SEPARATOR` conversion to `String` [INFO] [stdout] --> src/config/strings.rs:67:50 [INFO] [stdout] | [INFO] [stdout] 67 | let data_dir = data_dir.replace(['/', '\\'], &std::path::MAIN_SEPARATOR.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `std::path::MAIN_SEPARATOR_STR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_main_separator_str [INFO] [stdout] = note: `#[warn(clippy::manual_main_separator_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/config/util.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/config/util.rs:25:18 [INFO] [stdout] | [INFO] [stdout] 25 | .map(|m| m.permissions().readonly() == false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!m.permissions().readonly()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/gamesetting.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | / write!( [INFO] [stdout] 21 | | f, [INFO] [stdout] 22 | | "{}", [INFO] [stdout] 23 | | format!("{}fallback={},{r},{g},{b}", self.meta.comment, self.key) [INFO] [stdout] 24 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/gamesetting.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / write!( [INFO] [stdout] 38 | | f, [INFO] [stdout] 39 | | "{}", [INFO] [stdout] 40 | | format!("{}fallback={},{}", self.meta.comment, self.key, self.value) [INFO] [stdout] 41 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/gamesetting.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | / write!( [INFO] [stdout] 55 | | f, [INFO] [stdout] 56 | | "{}", [INFO] [stdout] 57 | | format!("{}fallback={},{}", self.meta.comment, self.key, self.value) [INFO] [stdout] 58 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/gamesetting.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / write!( [INFO] [stdout] 72 | | f, [INFO] [stdout] 73 | | "{}", [INFO] [stdout] 74 | | format!("{}fallback={},{}", self.meta.comment, self.key, self.value) [INFO] [stdout] 75 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stdout] --> src/config/gamesetting.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / match &self { [INFO] [stdout] 90 | | &GameSettingType::Color(setting) => &setting.key, [INFO] [stdout] 91 | | &GameSettingType::String(setting) => &setting.key, [INFO] [stdout] 92 | | &GameSettingType::Float(setting) => &setting.key, [INFO] [stdout] 93 | | &GameSettingType::Int(setting) => &setting.key, [INFO] [stdout] 94 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 89 ~ match self { [INFO] [stdout] 90 ~ GameSettingType::Color(setting) => &setting.key, [INFO] [stdout] 91 ~ GameSettingType::String(setting) => &setting.key, [INFO] [stdout] 92 ~ GameSettingType::Float(setting) => &setting.key, [INFO] [stdout] 93 ~ GameSettingType::Int(setting) => &setting.key, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stdout] --> src/config/gamesetting.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / match &self { [INFO] [stdout] 99 | | &GameSettingType::Color(setting) => { [INFO] [stdout] 100 | | let (r, g, b) = setting.value; [INFO] [stdout] 101 | | format!("{r},{g},{b}") [INFO] [stdout] ... | [INFO] [stdout] 105 | | &GameSettingType::Int(setting) => setting.value.to_string(), [INFO] [stdout] 106 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 98 ~ match self { [INFO] [stdout] 99 ~ GameSettingType::Color(setting) => { [INFO] [stdout] 100 | let (r, g, b) = setting.value; [INFO] [stdout] 101 | format!("{r},{g},{b}") [INFO] [stdout] 102 | } [INFO] [stdout] 103 ~ GameSettingType::String(setting) => setting.value.clone(), [INFO] [stdout] 104 ~ GameSettingType::Float(setting) => setting.value.to_string(), [INFO] [stdout] 105 ~ GameSettingType::Int(setting) => setting.value.to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:212:24 [INFO] [stdout] | [INFO] [stdout] 212 | if !path_meta.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `path_meta.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/config.rs:212:21 [INFO] [stdout] | [INFO] [stdout] 212 | / if !path_meta.is_ok() { [INFO] [stdout] 213 | | if let Err(error) = create_dir_all(path) { [INFO] [stdout] 214 | | util::debug_log(format!( [INFO] [stdout] 215 | | "WARNING: Attempted to crete a data-local directory at {path:?}, but failed: {error}" [INFO] [stdout] 216 | | )) [INFO] [stdout] 217 | | }; [INFO] [stdout] 218 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 212 ~ if !path_meta.is_ok() [INFO] [stdout] 213 ~ && let Err(error) = create_dir_all(path) { [INFO] [stdout] 214 | util::debug_log(format!( [INFO] [stdout] 215 | "WARNING: Attempted to crete a data-local directory at {path:?}, but failed: {error}" [INFO] [stdout] 216 | )) [INFO] [stdout] 217 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/config/gamesetting.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | / if value.contains('.') { [INFO] [stdout] 193 | | if let Ok(f) = value.parse::() { [INFO] [stdout] 194 | | return Ok(GameSettingType::Float(FloatGameSetting { [INFO] [stdout] 195 | | meta, [INFO] [stdout] ... | [INFO] [stdout] 200 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 192 ~ if value.contains('.') [INFO] [stdout] 193 ~ && let Ok(f) = value.parse::() { [INFO] [stdout] 194 | return Ok(GameSettingType::Float(FloatGameSetting { [INFO] [stdout] ... [INFO] [stdout] 198 | })); [INFO] [stdout] 199 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/encodingsetting.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | / write!( [INFO] [stdout] 50 | | f, [INFO] [stdout] 51 | | "{}", [INFO] [stdout] 52 | | format!("{}encoding={}", self.meta.comment, self.encoding) [INFO] [stdout] 53 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/config.rs:560:56 [INFO] [stdout] | [INFO] [stdout] 560 | self.settings.iter().filter(move |s| predicate(*s)) [INFO] [stdout] | ^^ help: try: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/config.rs:647:13 [INFO] [stdout] | [INFO] [stdout] 647 | / if let SettingValue::GameSetting(gs) = setting { [INFO] [stdout] 648 | | if seen.insert(gs.to_string()) { [INFO] [stdout] 649 | | unique_settings.push(gs); [INFO] [stdout] 650 | | } [INFO] [stdout] 651 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 647 ~ if let SettingValue::GameSetting(gs) = setting [INFO] [stdout] 648 ~ && seen.insert(gs.to_string()) { [INFO] [stdout] 649 | unique_settings.push(gs); [INFO] [stdout] 650 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:125:61 [INFO] [stdout] | [INFO] [stdout] 125 | ConfigError::NotFileOrDirectory(config_path) => write!( [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 126 | | f, [INFO] [stdout] 127 | | "{}", [INFO] [stdout] 128 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 132 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | / write!( [INFO] [stdout] 135 | | f, [INFO] [stdout] 136 | | "{}", [INFO] [stdout] 137 | | format!("An openmw.cfg does not exist at: {}", config_path.display()) [INFO] [stdout] 138 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:140:72 [INFO] [stdout] | [INFO] [stdout] 140 | ConfigError::DuplicateContentFile { file, config_path } => write!( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 141 | | f, [INFO] [stdout] 142 | | "{}", [INFO] [stdout] 143 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 146 | | ), [INFO] [stdout] 147 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:148:72 [INFO] [stdout] | [INFO] [stdout] 148 | ConfigError::CannotAddContentFile { file, config_path } => write!( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 149 | | f, [INFO] [stdout] 150 | | "{}", [INFO] [stdout] 151 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 154 | | ), [INFO] [stdout] 155 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:156:76 [INFO] [stdout] | [INFO] [stdout] 156 | ConfigError::DuplicateGroundcoverFile { file, config_path } => write!( [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 157 | | f, [INFO] [stdout] 158 | | "{}", [INFO] [stdout] 159 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 162 | | ), [INFO] [stdout] 163 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/config.rs:748:29 [INFO] [stdout] | [INFO] [stdout] 748 | ... &config_dir, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `config_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:164:76 [INFO] [stdout] | [INFO] [stdout] 164 | ConfigError::CannotAddGroundcoverFile { file, config_path } => write!( [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 165 | | f, [INFO] [stdout] 166 | | "{}", [INFO] [stdout] 167 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 170 | | ), [INFO] [stdout] 171 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:172:72 [INFO] [stdout] | [INFO] [stdout] 172 | ConfigError::DuplicateArchiveFile { file, config_path } => write!( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 173 | | f, [INFO] [stdout] 174 | | "{}", [INFO] [stdout] 175 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 178 | | ), [INFO] [stdout] 179 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/config.rs:771:29 [INFO] [stdout] | [INFO] [stdout] 771 | ... &config_dir, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `config_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:180:72 [INFO] [stdout] | [INFO] [stdout] 180 | ConfigError::CannotAddArchiveFile { file, config_path } => write!( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 181 | | f, [INFO] [stdout] 182 | | "{}", [INFO] [stdout] 183 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 186 | | ), [INFO] [stdout] 187 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/config.rs:790:29 [INFO] [stdout] | [INFO] [stdout] 790 | ... &config_dir, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `config_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:189:17 [INFO] [stdout] | [INFO] [stdout] 189 | / write!( [INFO] [stdout] 190 | | f, [INFO] [stdout] 191 | | "{}", [INFO] [stdout] 192 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 195 | | ), [INFO] [stdout] 196 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/config/error.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 199 | / write!( [INFO] [stdout] 200 | | f, [INFO] [stdout] 201 | | "{}", [INFO] [stdout] 202 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 206 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a reference on `std::path::MAIN_SEPARATOR` conversion to `String` [INFO] [stdout] --> src/config/strings.rs:67:50 [INFO] [stdout] | [INFO] [stdout] 67 | let data_dir = data_dir.replace(['/', '\\'], &std::path::MAIN_SEPARATOR.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `std::path::MAIN_SEPARATOR_STR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_main_separator_str [INFO] [stdout] = note: `#[warn(clippy::manual_main_separator_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/config/util.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/config/util.rs:25:18 [INFO] [stdout] | [INFO] [stdout] 25 | .map(|m| m.permissions().readonly() == false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!m.permissions().readonly()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:893:19 [INFO] [stdout] | [INFO] [stdout] 893 | .open(&path) [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:212:24 [INFO] [stdout] | [INFO] [stdout] 212 | if !path_meta.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `path_meta.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/config.rs:212:21 [INFO] [stdout] | [INFO] [stdout] 212 | / if !path_meta.is_ok() { [INFO] [stdout] 213 | | if let Err(error) = create_dir_all(path) { [INFO] [stdout] 214 | | util::debug_log(format!( [INFO] [stdout] 215 | | "WARNING: Attempted to crete a data-local directory at {path:?}, but failed: {error}" [INFO] [stdout] 216 | | )) [INFO] [stdout] 217 | | }; [INFO] [stdout] 218 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 212 ~ if !path_meta.is_ok() [INFO] [stdout] 213 ~ && let Err(error) = create_dir_all(path) { [INFO] [stdout] 214 | util::debug_log(format!( [INFO] [stdout] 215 | "WARNING: Attempted to crete a data-local directory at {path:?}, but failed: {error}" [INFO] [stdout] 216 | )) [INFO] [stdout] 217 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/config.rs:560:56 [INFO] [stdout] | [INFO] [stdout] 560 | self.settings.iter().filter(move |s| predicate(*s)) [INFO] [stdout] | ^^ help: try: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/config.rs:647:13 [INFO] [stdout] | [INFO] [stdout] 647 | / if let SettingValue::GameSetting(gs) = setting { [INFO] [stdout] 648 | | if seen.insert(gs.to_string()) { [INFO] [stdout] 649 | | unique_settings.push(gs); [INFO] [stdout] 650 | | } [INFO] [stdout] 651 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 647 ~ if let SettingValue::GameSetting(gs) = setting [INFO] [stdout] 648 ~ && seen.insert(gs.to_string()) { [INFO] [stdout] 649 | unique_settings.push(gs); [INFO] [stdout] 650 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/config.rs:748:29 [INFO] [stdout] | [INFO] [stdout] 748 | ... &config_dir, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `config_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/config.rs:771:29 [INFO] [stdout] | [INFO] [stdout] 771 | ... &config_dir, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `config_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/config.rs:790:29 [INFO] [stdout] | [INFO] [stdout] 790 | ... &config_dir, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `config_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:893:19 [INFO] [stdout] | [INFO] [stdout] 893 | .open(&path) [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.82s [INFO] running `Command { std: "docker" "inspect" "1091f7d00d8b7667948e8a960f3fab6e55c0c00f08b1e73ebb3063d488f35d6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1091f7d00d8b7667948e8a960f3fab6e55c0c00f08b1e73ebb3063d488f35d6c", kill_on_drop: false }` [INFO] [stdout] 1091f7d00d8b7667948e8a960f3fab6e55c0c00f08b1e73ebb3063d488f35d6c