[INFO] fetching crate open-file 0.1.0... [INFO] linting open-file-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate open-file 0.1.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate open-file 0.1.0 [INFO] finished tweaking crates.io crate open-file 0.1.0 [INFO] tweaked toml for crates.io crate open-file 0.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate open-file 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b914609a11d30669e194d797508b1af222674e5c364b9b8b8bb2226c965c7bd2 [INFO] running `Command { std: "docker" "start" "-a" "b914609a11d30669e194d797508b1af222674e5c364b9b8b8bb2226c965c7bd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b914609a11d30669e194d797508b1af222674e5c364b9b8b8bb2226c965c7bd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b914609a11d30669e194d797508b1af222674e5c364b9b8b8bb2226c965c7bd2", kill_on_drop: false }` [INFO] [stdout] b914609a11d30669e194d797508b1af222674e5c364b9b8b8bb2226c965c7bd2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5fb99d5b70286c6b26d98f5ce760ad0bf222c2a61071cb6a91b5fcc2ed7131ac [INFO] running `Command { std: "docker" "start" "-a" "5fb99d5b70286c6b26d98f5ce760ad0bf222c2a61071cb6a91b5fcc2ed7131ac", kill_on_drop: false }` [INFO] [stderr] Checking open-file v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | if !opts.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `opts.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `opts` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 47 | if !opts.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 48 | opts.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/lib.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 35 | let visual = match env::var("VISUAL") { [INFO] [stdout] | __________________^ [INFO] [stdout] 36 | | Ok(env) => env, [INFO] [stdout] 37 | | Err(_) => String::new(), [INFO] [stdout] 38 | | }; [INFO] [stdout] | |_____^ help: replace it with: `env::var("VISUAL").unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/lib.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 40 | let editor = match env::var("EDITOR") { [INFO] [stdout] | __________________^ [INFO] [stdout] 41 | | Ok(env) => env, [INFO] [stdout] 42 | | Err(_) => String::new(), [INFO] [stdout] 43 | | }; [INFO] [stdout] | |_____^ help: replace it with: `env::var("EDITOR").unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | if !opts.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `opts.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `opts` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 47 | if !opts.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 48 | opts.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/lib.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 35 | let visual = match env::var("VISUAL") { [INFO] [stdout] | __________________^ [INFO] [stdout] 36 | | Ok(env) => env, [INFO] [stdout] 37 | | Err(_) => String::new(), [INFO] [stdout] 38 | | }; [INFO] [stdout] | |_____^ help: replace it with: `env::var("VISUAL").unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/lib.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 40 | let editor = match env::var("EDITOR") { [INFO] [stdout] | __________________^ [INFO] [stdout] 41 | | Ok(env) => env, [INFO] [stdout] 42 | | Err(_) => String::new(), [INFO] [stdout] 43 | | }; [INFO] [stdout] | |_____^ help: replace it with: `env::var("EDITOR").unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s [INFO] running `Command { std: "docker" "inspect" "5fb99d5b70286c6b26d98f5ce760ad0bf222c2a61071cb6a91b5fcc2ed7131ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fb99d5b70286c6b26d98f5ce760ad0bf222c2a61071cb6a91b5fcc2ed7131ac", kill_on_drop: false }` [INFO] [stdout] 5fb99d5b70286c6b26d98f5ce760ad0bf222c2a61071cb6a91b5fcc2ed7131ac