[INFO] fetching crate opam-file-rs 0.1.5... [INFO] linting opam-file-rs-0.1.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate opam-file-rs 0.1.5 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate opam-file-rs 0.1.5 [INFO] finished tweaking crates.io crate opam-file-rs 0.1.5 [INFO] tweaked toml for crates.io crate opam-file-rs 0.1.5 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate opam-file-rs 0.1.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 59 packages to latest compatible versions [INFO] [stderr] Adding lalrpop v0.19.12 (available: v0.23.1) [INFO] [stderr] Adding lalrpop-util v0.19.12 (available: v0.23.1) [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4f26f7ae3209d9078b1a350fc0a491efc5265218d8b28c7b765086506f2cc4d8 [INFO] running `Command { std: "docker" "start" "-a" "4f26f7ae3209d9078b1a350fc0a491efc5265218d8b28c7b765086506f2cc4d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4f26f7ae3209d9078b1a350fc0a491efc5265218d8b28c7b765086506f2cc4d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f26f7ae3209d9078b1a350fc0a491efc5265218d8b28c7b765086506f2cc4d8", kill_on_drop: false }` [INFO] [stdout] 4f26f7ae3209d9078b1a350fc0a491efc5265218d8b28c7b765086506f2cc4d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b06f73fafa8d2c21e194cc802db6f05881a706d32cb5d38699842208f8ed4712 [INFO] running `Command { std: "docker" "start" "-a" "b06f73fafa8d2c21e194cc802db6f05881a706d32cb5d38699842208f8ed4712", kill_on_drop: false }` [INFO] [stderr] Compiling opam-file-rs v0.1.5 (/opt/rustwide/workdir) [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> /opt/rustwide/target/debug/build/opam-file-rs-e044092b48cfae15/out/parser.rs:972:9 [INFO] [stdout] | [INFO] [stdout] 972 | (_, __0, _): ((), value::OpamFile, ()), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] = note: `#[warn(clippy::just_underscores_and_digits)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> /opt/rustwide/target/debug/build/opam-file-rs-e044092b48cfae15/out/parser.rs:972:9 [INFO] [stdout] | [INFO] [stdout] 972 | (_, __0, _): ((), value::OpamFile, ()), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] = note: `#[warn(clippy::just_underscores_and_digits)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:12:3 [INFO] [stdout] | [INFO] [stdout] 12 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STRING` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:13:3 [INFO] [stdout] | [INFO] [stdout] 13 | STRING(String), [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `String` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IDENT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:14:3 [INFO] [stdout] | [INFO] [stdout] 14 | IDENT(String), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BOOL` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:15:3 [INFO] [stdout] | [INFO] [stdout] 15 | BOOL(bool), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Bool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:16:3 [INFO] [stdout] | [INFO] [stdout] 16 | INT(isize), [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Int` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LBRACKET` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:17:3 [INFO] [stdout] | [INFO] [stdout] 17 | LBRACKET, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Lbracket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RBRACKET` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:18:3 [INFO] [stdout] | [INFO] [stdout] 18 | RBRACKET, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Rbracket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LPAR` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:19:3 [INFO] [stdout] | [INFO] [stdout] 19 | LPAR, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Lpar` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RPAR` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:20:3 [INFO] [stdout] | [INFO] [stdout] 20 | RPAR, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Rpar` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LBRACE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:21:3 [INFO] [stdout] | [INFO] [stdout] 21 | LBRACE, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Lbrace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RBRACE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:22:3 [INFO] [stdout] | [INFO] [stdout] 22 | RBRACE, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Rbrace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COLON` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:23:3 [INFO] [stdout] | [INFO] [stdout] 23 | COLON, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Colon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:24:3 [INFO] [stdout] | [INFO] [stdout] 24 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RELOP` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:26:3 [INFO] [stdout] | [INFO] [stdout] 26 | RELOP(value::RelOpKind), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Relop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PFXOP` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:27:3 [INFO] [stdout] | [INFO] [stdout] 27 | PFXOP(value::PfxOpKind), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Pfxop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ENVOP` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:28:3 [INFO] [stdout] | [INFO] [stdout] 28 | ENVOP(value::EnvUpdateOpKind), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Envop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/lexer.rs:292:16 [INFO] [stdout] | [INFO] [stdout] 292 | fn lex_comment(depth: usize, input: &[char], pos: usize) -> usize { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_depth` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/lexer.rs:308:37 [INFO] [stdout] | [INFO] [stdout] 308 | let new_pos = lex_comment(depth + 1, input, pos); [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:323:30 [INFO] [stdout] | [INFO] [stdout] 323 | while pos < input.len() && !('\n' == input[pos]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `('\n' != input[pos])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lexer.rs:347:11 [INFO] [stdout] | [INFO] [stdout] 347 | s_pos = s_pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `s_pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/lexer.rs:380:13 [INFO] [stdout] | [INFO] [stdout] 380 | str.push_str("\""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lexer.rs:385:11 [INFO] [stdout] | [INFO] [stdout] 385 | s_pos = s_pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `s_pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/lexer.rs:414:23 [INFO] [stdout] | [INFO] [stdout] 414 | let hex_i64 = i64::from_str_radix(&hex, 10).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `hex.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:482:13 [INFO] [stdout] | [INFO] [stdout] 482 | if str == "true".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"true"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:484:20 [INFO] [stdout] | [INFO] [stdout] 484 | } else if str == "false".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"false"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/value.rs:138:40 [INFO] [stdout] | [INFO] [stdout] 138 | fn opam_file_item_vec_to_string(value: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 138 - fn opam_file_item_vec_to_string(value: &Vec) -> String { [INFO] [stdout] 138 + fn opam_file_item_vec_to_string(value: &[OpamFileItem]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/value.rs:148:29 [INFO] [stdout] | [INFO] [stdout] 148 | .unwrap_or_else(|| String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lexer.rs:404:19 [INFO] [stdout] | [INFO] [stdout] 404 | let hex = vec![*c1, *c2].iter().collect::(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: you can use an array directly: `[*c1, *c2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lexer.rs:413:19 [INFO] [stdout] | [INFO] [stdout] 413 | let hex = vec![*c, *c1, *c2].iter().collect::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[*c, *c1, *c2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:12:3 [INFO] [stdout] | [INFO] [stdout] 12 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.82s [INFO] [stdout] warning: name `STRING` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:13:3 [INFO] [stdout] | [INFO] [stdout] 13 | STRING(String), [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `String` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IDENT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:14:3 [INFO] [stdout] | [INFO] [stdout] 14 | IDENT(String), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BOOL` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:15:3 [INFO] [stdout] | [INFO] [stdout] 15 | BOOL(bool), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Bool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:16:3 [INFO] [stdout] | [INFO] [stdout] 16 | INT(isize), [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Int` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LBRACKET` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:17:3 [INFO] [stdout] | [INFO] [stdout] 17 | LBRACKET, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Lbracket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RBRACKET` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:18:3 [INFO] [stdout] | [INFO] [stdout] 18 | RBRACKET, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Rbracket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LPAR` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:19:3 [INFO] [stdout] | [INFO] [stdout] 19 | LPAR, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Lpar` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RPAR` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:20:3 [INFO] [stdout] | [INFO] [stdout] 20 | RPAR, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Rpar` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LBRACE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:21:3 [INFO] [stdout] | [INFO] [stdout] 21 | LBRACE, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Lbrace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RBRACE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:22:3 [INFO] [stdout] | [INFO] [stdout] 22 | RBRACE, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Rbrace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COLON` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:23:3 [INFO] [stdout] | [INFO] [stdout] 23 | COLON, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Colon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:24:3 [INFO] [stdout] | [INFO] [stdout] 24 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RELOP` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:26:3 [INFO] [stdout] | [INFO] [stdout] 26 | RELOP(value::RelOpKind), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Relop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PFXOP` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:27:3 [INFO] [stdout] | [INFO] [stdout] 27 | PFXOP(value::PfxOpKind), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Pfxop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ENVOP` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:28:3 [INFO] [stdout] | [INFO] [stdout] 28 | ENVOP(value::EnvUpdateOpKind), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Envop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/lexer.rs:292:16 [INFO] [stdout] | [INFO] [stdout] 292 | fn lex_comment(depth: usize, input: &[char], pos: usize) -> usize { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_depth` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/lexer.rs:308:37 [INFO] [stdout] | [INFO] [stdout] 308 | let new_pos = lex_comment(depth + 1, input, pos); [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:323:30 [INFO] [stdout] | [INFO] [stdout] 323 | while pos < input.len() && !('\n' == input[pos]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `('\n' != input[pos])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lexer.rs:347:11 [INFO] [stdout] | [INFO] [stdout] 347 | s_pos = s_pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `s_pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/lexer.rs:380:13 [INFO] [stdout] | [INFO] [stdout] 380 | str.push_str("\""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lexer.rs:385:11 [INFO] [stdout] | [INFO] [stdout] 385 | s_pos = s_pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `s_pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/lexer.rs:414:23 [INFO] [stdout] | [INFO] [stdout] 414 | let hex_i64 = i64::from_str_radix(&hex, 10).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `hex.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:482:13 [INFO] [stdout] | [INFO] [stdout] 482 | if str == "true".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"true"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:484:20 [INFO] [stdout] | [INFO] [stdout] 484 | } else if str == "false".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"false"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/value.rs:138:40 [INFO] [stdout] | [INFO] [stdout] 138 | fn opam_file_item_vec_to_string(value: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 138 - fn opam_file_item_vec_to_string(value: &Vec) -> String { [INFO] [stdout] 138 + fn opam_file_item_vec_to_string(value: &[OpamFileItem]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/value.rs:148:29 [INFO] [stdout] | [INFO] [stdout] 148 | .unwrap_or_else(|| String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lexer.rs:404:19 [INFO] [stdout] | [INFO] [stdout] 404 | let hex = vec![*c1, *c2].iter().collect::(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: you can use an array directly: `[*c1, *c2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lexer.rs:413:19 [INFO] [stdout] | [INFO] [stdout] 413 | let hex = vec![*c, *c1, *c2].iter().collect::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[*c, *c1, *c2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "b06f73fafa8d2c21e194cc802db6f05881a706d32cb5d38699842208f8ed4712", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b06f73fafa8d2c21e194cc802db6f05881a706d32cb5d38699842208f8ed4712", kill_on_drop: false }` [INFO] [stdout] b06f73fafa8d2c21e194cc802db6f05881a706d32cb5d38699842208f8ed4712