[INFO] fetching crate op_result 0.5.8... [INFO] linting op_result-0.5.8 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate op_result 0.5.8 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate op_result 0.5.8 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate op_result 0.5.8 [INFO] tweaked toml for crates.io crate op_result 0.5.8 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate op_result 0.5.8 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate op_result 0.5.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded syn v2.0.109 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0489af10052c04ba577c4bbf2606e11ec2e171c990945814e9acdfc273df5ad7 [INFO] running `Command { std: "docker" "start" "-a" "0489af10052c04ba577c4bbf2606e11ec2e171c990945814e9acdfc273df5ad7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0489af10052c04ba577c4bbf2606e11ec2e171c990945814e9acdfc273df5ad7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0489af10052c04ba577c4bbf2606e11ec2e171c990945814e9acdfc273df5ad7", kill_on_drop: false }` [INFO] [stdout] 0489af10052c04ba577c4bbf2606e11ec2e171c990945814e9acdfc273df5ad7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a672b3e72d8d1a847af613d21ff29c5dcfdcc95924717f67ec5c794ee446ec49 [INFO] running `Command { std: "docker" "start" "-a" "a672b3e72d8d1a847af613d21ff29c5dcfdcc95924717f67ec5c794ee446ec49", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Checking unicode-ident v1.0.22 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Checking syn v2.0.109 [INFO] [stderr] Checking op_result v0.5.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/op_result.rs:104:71 [INFO] [stdout] | [INFO] [stdout] 104 | for (_idx, (span, expansion)) in defined_expansions.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 104 - for (_idx, (span, expansion)) in defined_expansions.iter().enumerate() { [INFO] [stdout] 104 + for (span, expansion) in defined_expansions.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/op_result.rs:133:79 [INFO] [stdout] | [INFO] [stdout] 133 | for (_idx, (span, expansion)) in defined_expansions.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 133 - for (_idx, (span, expansion)) in defined_expansions.iter().enumerate() { [INFO] [stdout] 133 + for (span, expansion) in defined_expansions.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/op_result.rs:401:20 [INFO] [stdout] | [INFO] [stdout] 401 | ident.to_string() == config.marker_trait_name { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/op_result.rs:446:19 [INFO] [stdout] | [INFO] [stdout] 446 | result.extend(tokens.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 446 - result.extend(tokens.into_iter()); [INFO] [stdout] 446 + result.extend(tokens); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/op_result.rs:591:43 [INFO] [stdout] | [INFO] [stdout] 591 | fn extract_all_operations(expr: &Expr) -> (Box, Vec<(proc_macro2::Span, proc_macro2::TokenStream, Option>)>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/op_result.rs:104:71 [INFO] [stdout] | [INFO] [stdout] 104 | for (_idx, (span, expansion)) in defined_expansions.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 104 - for (_idx, (span, expansion)) in defined_expansions.iter().enumerate() { [INFO] [stdout] 104 + for (span, expansion) in defined_expansions.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/op_result.rs:133:79 [INFO] [stdout] | [INFO] [stdout] 133 | for (_idx, (span, expansion)) in defined_expansions.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 133 - for (_idx, (span, expansion)) in defined_expansions.iter().enumerate() { [INFO] [stdout] 133 + for (span, expansion) in defined_expansions.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/op_result.rs:401:20 [INFO] [stdout] | [INFO] [stdout] 401 | ident.to_string() == config.marker_trait_name { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/op_result.rs:446:19 [INFO] [stdout] | [INFO] [stdout] 446 | result.extend(tokens.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 446 - result.extend(tokens.into_iter()); [INFO] [stdout] 446 + result.extend(tokens); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/op_result.rs:591:43 [INFO] [stdout] | [INFO] [stdout] 591 | fn extract_all_operations(expr: &Expr) -> (Box, Vec<(proc_macro2::Span, proc_macro2::TokenStream, Option>)>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/op_result.rs:104:71 [INFO] [stdout] | [INFO] [stdout] 104 | for (_idx, (span, expansion)) in defined_expansions.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 104 - for (_idx, (span, expansion)) in defined_expansions.iter().enumerate() { [INFO] [stdout] 104 + for (span, expansion) in defined_expansions.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/op_result.rs:133:79 [INFO] [stdout] | [INFO] [stdout] 133 | for (_idx, (span, expansion)) in defined_expansions.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 133 - for (_idx, (span, expansion)) in defined_expansions.iter().enumerate() { [INFO] [stdout] 133 + for (span, expansion) in defined_expansions.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/op_result.rs:401:20 [INFO] [stdout] | [INFO] [stdout] 401 | ident.to_string() == config.marker_trait_name { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/op_result.rs:446:19 [INFO] [stdout] | [INFO] [stdout] 446 | result.extend(tokens.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 446 - result.extend(tokens.into_iter()); [INFO] [stdout] 446 + result.extend(tokens); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/op_result.rs:591:43 [INFO] [stdout] | [INFO] [stdout] 591 | fn extract_all_operations(expr: &Expr) -> (Box, Vec<(proc_macro2::Span, proc_macro2::TokenStream, Option>)>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `a` and `b` are never read [INFO] [stdout] --> tests/test_nested.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 7 | struct TestStruct [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | a: T, [INFO] [stdout] | ^ [INFO] [stdout] 12 | b: U, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test_output.rs:264:24 [INFO] [stdout] | [INFO] [stdout] 264 | let _: NotOutput = !true; [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test_output.rs:278:22 [INFO] [stdout] | [INFO] [stdout] 278 | let _: Complex = (!true) & false; [INFO] [stdout] | ^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.60s [INFO] running `Command { std: "docker" "inspect" "a672b3e72d8d1a847af613d21ff29c5dcfdcc95924717f67ec5c794ee446ec49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a672b3e72d8d1a847af613d21ff29c5dcfdcc95924717f67ec5c794ee446ec49", kill_on_drop: false }` [INFO] [stdout] a672b3e72d8d1a847af613d21ff29c5dcfdcc95924717f67ec5c794ee446ec49