[INFO] fetching crate oly 0.1.0... [INFO] linting oly-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate oly 0.1.0 into /workspace/builds/worker-4-tc1/source [INFO] removed /workspace/builds/worker-4-tc1/source/.cargo/config.toml [INFO] started tweaking crates.io crate oly 0.1.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate oly 0.1.0 [INFO] tweaked toml for crates.io crate oly 0.1.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate oly 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate oly 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded time-core v0.1.7 [INFO] [stderr] Downloaded windows-version v0.1.7 [INFO] [stderr] Downloaded mimalloc v0.1.48 [INFO] [stderr] Downloaded argon2 v0.5.3 [INFO] [stderr] Downloaded axum-macros v0.5.0 [INFO] [stderr] Downloaded zbus_macros v5.14.0 [INFO] [stderr] Downloaded zvariant v5.10.0 [INFO] [stderr] Downloaded derive_more v2.1.1 [INFO] [stderr] Downloaded derive_more-impl v2.1.1 [INFO] [stderr] Downloaded interprocess v2.4.0 [INFO] [stderr] Downloaded axum v0.8.8 [INFO] [stderr] Downloaded reqwest v0.13.2 [INFO] [stderr] Downloaded webpki-root-certs v1.0.6 [INFO] [stderr] Downloaded rpassword v7.4.0 [INFO] [stderr] Downloaded time v0.3.45 [INFO] [stderr] Downloaded aws-lc-rs v1.16.1 [INFO] [stderr] Downloaded crossterm v0.29.0 [INFO] [stderr] Downloaded zbus v5.14.0 [INFO] [stderr] Downloaded toml_edit v0.25.4+spec-1.1.0 [INFO] [stderr] Downloaded notify-rust v4.12.0 [INFO] [stderr] Downloaded serial2 v0.2.34 [INFO] [stderr] Downloaded nix v0.28.0 [INFO] [stderr] Downloaded portable-pty v0.9.0 [INFO] [stderr] Downloaded tauri-winrt-notification v0.7.2 [INFO] [stderr] Downloaded axum-core v0.5.6 [INFO] [stderr] Downloaded convert_case v0.10.0 [INFO] [stderr] Downloaded uds_windows v1.2.0 [INFO] [stderr] Downloaded libmimalloc-sys v0.1.44 [INFO] [stderr] Downloaded toml_datetime v1.0.0+spec-1.1.0 [INFO] [stderr] Downloaded zvariant_derive v5.10.0 [INFO] [stderr] Downloaded filedescriptor v0.8.3 [INFO] [stderr] Downloaded shared_library v0.1.9 [INFO] [stderr] Downloaded rust-embed-utils v8.11.0 [INFO] [stderr] Downloaded mac-notification-sys v0.6.10 [INFO] [stderr] Downloaded rtoolbox v0.0.3 [INFO] [stderr] Downloaded rust-embed-impl v8.11.0 [INFO] [stderr] Downloaded vte v0.15.0 [INFO] [stderr] Downloaded winres v0.1.12 [INFO] [stderr] Downloaded time-macros v0.2.25 [INFO] [stderr] Downloaded vt100 v0.16.2 [INFO] [stderr] Downloaded which v8.0.1 [INFO] [stderr] Downloaded rust-embed v8.11.0 [INFO] [stderr] Downloaded aws-lc-sys v0.38.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc01b369833fd250f55ffed428ce26ced24854b5cd2ae6da491a43e46f637a93 [INFO] running `Command { std: "docker" "start" "-a" "dc01b369833fd250f55ffed428ce26ced24854b5cd2ae6da491a43e46f637a93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc01b369833fd250f55ffed428ce26ced24854b5cd2ae6da491a43e46f637a93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc01b369833fd250f55ffed428ce26ced24854b5cd2ae6da491a43e46f637a93", kill_on_drop: false }` [INFO] [stdout] dc01b369833fd250f55ffed428ce26ced24854b5cd2ae6da491a43e46f637a93 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e6770e299acc49b8066b72e8ea3fe3cee3150c32e603efd6fa5c792c9c23d62 [INFO] running `Command { std: "docker" "start" "-a" "5e6770e299acc49b8066b72e8ea3fe3cee3150c32e603efd6fa5c792c9c23d62", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling generic-array v0.14.9 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Compiling hashbrown v0.16.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling winnow v0.7.15 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling cfg-if v1.0.4 [INFO] [stderr] Checking base64ct v1.8.3 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling aws-lc-rs v1.16.1 [INFO] [stderr] Compiling pin-project-lite v0.2.17 [INFO] [stderr] Compiling futures-core v0.3.32 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling toml_datetime v1.0.0+spec-1.1.0 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Compiling futures-sink v0.3.32 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling cpufeatures v0.2.17 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Checking unicode-ident v1.0.24 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Compiling futures-task v0.3.32 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling itoa v1.0.17 [INFO] [stderr] Compiling slab v0.4.12 [INFO] [stderr] Compiling futures-io v0.3.32 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling socket2 v0.6.3 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Compiling mio v1.1.1 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Compiling toml_parser v1.0.9+spec-1.1.0 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Compiling allocator-api2 v0.2.21 [INFO] [stderr] Compiling parking_lot v0.12.5 [INFO] [stderr] Compiling futures-util v0.3.32 [INFO] [stderr] Compiling tokio v1.50.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling toml_edit v0.25.4+spec-1.1.0 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling iana-time-zone v0.1.65 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling chrono v0.4.44 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Compiling crc v3.4.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling proc-macro-crate v3.5.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking data-encoding v2.10.0 [INFO] [stderr] Compiling ryu v1.0.23 [INFO] [stderr] Compiling endi v1.1.1 [INFO] [stderr] Compiling aws-lc-sys v0.38.0 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Compiling futures-channel v0.3.32 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling convert_case v0.10.0 [INFO] [stderr] Checking getrandom v0.4.2 [INFO] [stderr] Compiling libmimalloc-sys v0.1.44 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking piper v0.2.5 [INFO] [stderr] Compiling futures-executor v0.3.32 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking uuid v1.22.0 [INFO] [stderr] Compiling rust-embed-utils v8.11.0 [INFO] [stderr] Checking async-executor v1.14.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking time-core v0.1.7 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking iri-string v0.7.10 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking vte v0.15.0 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking rtoolbox v0.0.3 [INFO] [stderr] Checking serial2 v0.2.34 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking shell-words v1.1.1 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Compiling tokio-stream v0.1.18 [INFO] [stderr] Compiling doctest-file v1.0.0 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Checking time v0.3.45 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Compiling oly v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking env_home v0.1.0 [INFO] [stdout] warning: unused variable: `icon_path` [INFO] [stdout] --> build.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | let icon_path = manifest_dir.join("assets").join("icon.ico"); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_icon_path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking which v8.0.1 [INFO] [stderr] Checking vt100 v0.16.2 [INFO] [stderr] Checking mimalloc v0.1.48 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking rpassword v7.4.0 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Compiling axum-macros v0.5.0 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling rust-embed-impl v8.11.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Compiling zerovec v0.11.5 [INFO] [stderr] Compiling zerotrie v0.2.3 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking tungstenite v0.28.0 [INFO] [stderr] Checking axum-core v0.5.6 [INFO] [stderr] Checking rust-embed v8.11.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking filedescriptor v0.8.3 [INFO] [stderr] Checking portable-pty v0.9.0 [INFO] [stderr] Compiling tinystr v0.8.2 [INFO] [stderr] Compiling potential_utf v0.1.4 [INFO] [stderr] Compiling icu_locale_core v2.1.1 [INFO] [stderr] Compiling icu_collections v2.1.1 [INFO] [stderr] Checking tracing-appender v0.2.4 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking zvariant_utils v3.3.0 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Compiling zvariant_derive v5.10.0 [INFO] [stderr] Compiling idna_adapter v1.2.1 [INFO] [stderr] Compiling idna v1.1.0 [INFO] [stderr] Compiling zvariant v5.10.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-tungstenite v0.28.0 [INFO] [stderr] Checking interprocess v2.4.0 [INFO] [stderr] Compiling sqlx-core v0.8.6 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Compiling zbus_names v4.3.1 [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Compiling zbus_macros v5.14.0 [INFO] [stderr] Checking sqlx-sqlite v0.8.6 [INFO] [stderr] Checking zbus v5.14.0 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking notify-rust v4.12.0 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking tungstenite v0.26.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.13.2 [INFO] [stderr] Checking tokio-tungstenite v0.26.2 [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> tests/e2e_daemon.rs:71:33 [INFO] [stdout] | [INFO] [stdout] 71 | fn socket_name_for_tmp(tmp_dir: &PathBuf) -> String { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 71 - fn socket_name_for_tmp(tmp_dir: &PathBuf) -> String { [INFO] [stdout] 71 + fn socket_name_for_tmp(tmp_dir: &Path) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is not `wait()`ed on in all code paths [INFO] [stdout] --> tests/e2e_daemon.rs:152:17 [INFO] [stdout] | [INFO] [stdout] 152 | let child = oly_cmd(tmp) [INFO] [stdout] | _________________^ [INFO] [stdout] 153 | | .args([ [INFO] [stdout] 154 | | "daemon", [INFO] [stdout] 155 | | "start", [INFO] [stdout] ... | [INFO] [stdout] 163 | | .spawn() [INFO] [stdout] 164 | | .expect("failed to spawn daemon process"); [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] note: this if expression has a `wait()` call, but it is missing an else block [INFO] [stdout] --> tests/e2e_daemon.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | / if probe_stderr.contains("zzz9999") { [INFO] [stdout] 185 | | // Daemon processed the request — it's up and accepting connections. [INFO] [stdout] 186 | | return DaemonGuard { [INFO] [stdout] 187 | | child, [INFO] [stdout] 188 | | tmp_dir: tmp.clone(), [INFO] [stdout] 189 | | }; [INFO] [stdout] 190 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] note: `wait()` called here [INFO] [stdout] --> tests/e2e_daemon.rs:187:17 [INFO] [stdout] | [INFO] [stdout] 187 | child, [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: consider calling `.wait()` in all code paths [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is not `wait()`ed on in all code paths [INFO] [stdout] --> tests/e2e_daemon.rs:214:17 [INFO] [stdout] | [INFO] [stdout] 214 | let child = oly_cmd(tmp) [INFO] [stdout] | _________________^ [INFO] [stdout] 215 | | .args([ [INFO] [stdout] 216 | | "daemon", [INFO] [stdout] 217 | | "start", [INFO] [stdout] ... | [INFO] [stdout] 226 | | .spawn() [INFO] [stdout] 227 | | .expect("failed to spawn daemon process"); [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] note: this if expression has a `wait()` call, but it is missing an else block [INFO] [stdout] --> tests/e2e_daemon.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | / if probe_stderr.contains("zzz9999") { [INFO] [stdout] 241 | | return DaemonGuard { [INFO] [stdout] 242 | | child, [INFO] [stdout] 243 | | tmp_dir: tmp.clone(), [INFO] [stdout] 244 | | }; [INFO] [stdout] 245 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] note: `wait()` called here [INFO] [stdout] --> tests/e2e_daemon.rs:242:17 [INFO] [stdout] | [INFO] [stdout] 242 | child, [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: consider calling `.wait()` in all code paths [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/http/sessions.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | offset: offset, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/http/sessions.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | offset: offset, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/session/runtime.rs:856:13 [INFO] [stdout] | [INFO] [stdout] 856 | let mut cmd = portable_pty::CommandBuilder::new("true"); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/client/attach.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | / if let Err(err) = execute_result { [INFO] [stdout] 223 | | if first_error.is_none() { [INFO] [stdout] 224 | | first_error = Some(err.into()); [INFO] [stdout] 225 | | } [INFO] [stdout] 226 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 222 ~ if let Err(err) = execute_result [INFO] [stdout] 223 ~ && first_error.is_none() { [INFO] [stdout] 224 | first_error = Some(err.into()); [INFO] [stdout] 225 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/client/attach.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | / if let Err(err) = stdout.flush() { [INFO] [stdout] 229 | | if first_error.is_none() { [INFO] [stdout] 230 | | first_error = Some(err.into()); [INFO] [stdout] 231 | | } [INFO] [stdout] 232 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 228 ~ if let Err(err) = stdout.flush() [INFO] [stdout] 229 ~ && first_error.is_none() { [INFO] [stdout] 230 | first_error = Some(err.into()); [INFO] [stdout] 231 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/client/input.rs:221:69 [INFO] [stdout] | [INFO] [stdout] 221 | let payload = if raw.starts_with("0x") || raw.starts_with("0X") { [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 222 | | &raw[2..] [INFO] [stdout] 223 | | } else if raw.starts_with("\\x") || raw.starts_with("\\X") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/client/input.rs:223:64 [INFO] [stdout] | [INFO] [stdout] 223 | } else if raw.starts_with("\\x") || raw.starts_with("\\X") { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 224 | | &raw[2..] [INFO] [stdout] 225 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/client/join.rs:299:55 [INFO] [stdout] | [INFO] [stdout] 299 | ... RpcRequest::Health { .. } [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/client/list.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | sessions.sort_by(|a, b| a.created_at.cmp(&b.created_at)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - sessions.sort_by(|a, b| a.created_at.cmp(&b.created_at)); [INFO] [stdout] 56 + sessions.sort_by_key(|a| a.created_at); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/client/logs.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / pub async fn run_logs( [INFO] [stdout] 21 | | config: &AppConfig, [INFO] [stdout] 22 | | id: &str, [INFO] [stdout] 23 | | tail: usize, [INFO] [stdout] ... | [INFO] [stdout] 28 | | timeout_secs: u64, [INFO] [stdout] 29 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/client/logs.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | / if start > 0 { [INFO] [stdout] 129 | | if let Some(pos) = buf.iter().position(|&b| b == b'\n') { [INFO] [stdout] 130 | | buf.drain(..=pos); [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 128 ~ if start > 0 [INFO] [stdout] 129 ~ && let Some(pos) = buf.iter().position(|&b| b == b'\n') { [INFO] [stdout] 130 | buf.drain(..=pos); [INFO] [stdout] 131 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/config.rs:144:41 [INFO] [stdout] | [INFO] [stdout] 144 | let mut out = String::with_capacity((bytes.len() * 4 + 2) / 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(bytes.len() * 4).div_ceil(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:208:30 [INFO] [stdout] | [INFO] [stdout] 208 | fn load_overrides(state_dir: &PathBuf) -> AppConfigOverrides { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 208 - fn load_overrides(state_dir: &PathBuf) -> AppConfigOverrides { [INFO] [stdout] 208 + fn load_overrides(state_dir: &Path) -> AppConfigOverrides { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/client/attach.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | / if let Err(err) = execute_result { [INFO] [stdout] 223 | | if first_error.is_none() { [INFO] [stdout] 224 | | first_error = Some(err.into()); [INFO] [stdout] 225 | | } [INFO] [stdout] 226 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 222 ~ if let Err(err) = execute_result [INFO] [stdout] 223 ~ && first_error.is_none() { [INFO] [stdout] 224 | first_error = Some(err.into()); [INFO] [stdout] 225 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/client/attach.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | / if let Err(err) = stdout.flush() { [INFO] [stdout] 229 | | if first_error.is_none() { [INFO] [stdout] 230 | | first_error = Some(err.into()); [INFO] [stdout] 231 | | } [INFO] [stdout] 232 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 228 ~ if let Err(err) = stdout.flush() [INFO] [stdout] 229 ~ && first_error.is_none() { [INFO] [stdout] 230 | first_error = Some(err.into()); [INFO] [stdout] 231 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/daemon/rpc.rs:338:17 [INFO] [stdout] | [INFO] [stdout] 338 | / if let Some(dl) = deadline { [INFO] [stdout] 339 | | if tokio::time::Instant::now() >= dl { [INFO] [stdout] 340 | | break 'wait; [INFO] [stdout] 341 | | } [INFO] [stdout] 342 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 338 ~ if let Some(dl) = deadline [INFO] [stdout] 339 ~ && tokio::time::Instant::now() >= dl { [INFO] [stdout] 340 | break 'wait; [INFO] [stdout] 341 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/daemon/rpc.rs:372:25 [INFO] [stdout] | [INFO] [stdout] 372 | / if let Some(dl) = deadline { [INFO] [stdout] 373 | | if tokio::time::Instant::now() >= dl { [INFO] [stdout] 374 | | break 'wait; [INFO] [stdout] 375 | | } [INFO] [stdout] 376 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 372 ~ if let Some(dl) = deadline [INFO] [stdout] 373 ~ && tokio::time::Instant::now() >= dl { [INFO] [stdout] 374 | break 'wait; [INFO] [stdout] 375 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `query.offset` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/db.rs:183:22 [INFO] [stdout] | [INFO] [stdout] 183 | let offset = query.offset.max(0) as i64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `query.offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/db.rs:203:17 [INFO] [stdout] | [INFO] [stdout] 203 | qb.push(&format!(" ORDER BY {} {}", sort_field, order)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!(" ORDER BY {} {}", sort_field, order)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/client/input.rs:221:69 [INFO] [stdout] | [INFO] [stdout] 221 | let payload = if raw.starts_with("0x") || raw.starts_with("0X") { [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 222 | | &raw[2..] [INFO] [stdout] 223 | | } else if raw.starts_with("\\x") || raw.starts_with("\\X") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/client/input.rs:223:64 [INFO] [stdout] | [INFO] [stdout] 223 | } else if raw.starts_with("\\x") || raw.starts_with("\\X") { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 224 | | &raw[2..] [INFO] [stdout] 225 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/http/auth.rs:73:39 [INFO] [stdout] | [INFO] [stdout] 73 | lockout.retain(|_, r| r.locked_until.map_or(true, |t| now < t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 73 - lockout.retain(|_, r| r.locked_until.map_or(true, |t| now < t)); [INFO] [stdout] 73 + lockout.retain(|_, r| r.locked_until.is_none_or(|t| now < t)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/http/auth.rs:337:5 [INFO] [stdout] | [INFO] [stdout] 337 | / if let Some(ref token) = token { [INFO] [stdout] 338 | | if auth.is_valid_token(token).await { [INFO] [stdout] 339 | | debug!(path = %path, "auth: authorized request"); [INFO] [stdout] 340 | | return next.run(request).await; [INFO] [stdout] 341 | | } [INFO] [stdout] 342 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 337 ~ if let Some(ref token) = token [INFO] [stdout] 338 ~ && auth.is_valid_token(token).await { [INFO] [stdout] 339 | debug!(path = %path, "auth: authorized request"); [INFO] [stdout] 340 | return next.run(request).await; [INFO] [stdout] 341 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/client/join.rs:299:55 [INFO] [stdout] | [INFO] [stdout] 299 | ... RpcRequest::Health { .. } [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/client/list.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | sessions.sort_by(|a, b| a.created_at.cmp(&b.created_at)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - sessions.sort_by(|a, b| a.created_at.cmp(&b.created_at)); [INFO] [stdout] 56 + sessions.sort_by_key(|a| a.created_at); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/http/sessions.rs:144:22 [INFO] [stdout] | [INFO] [stdout] 144 | let page_limit = params.limit.unwrap_or(20).max(1).min(200); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `params.limit.unwrap_or(20).clamp(1, 200)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/client/logs.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / pub async fn run_logs( [INFO] [stdout] 21 | | config: &AppConfig, [INFO] [stdout] 22 | | id: &str, [INFO] [stdout] 23 | | tail: usize, [INFO] [stdout] ... | [INFO] [stdout] 28 | | timeout_secs: u64, [INFO] [stdout] 29 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/client/logs.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | / if start > 0 { [INFO] [stdout] 129 | | if let Some(pos) = buf.iter().position(|&b| b == b'\n') { [INFO] [stdout] 130 | | buf.drain(..=pos); [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 128 ~ if start > 0 [INFO] [stdout] 129 ~ && let Some(pos) = buf.iter().position(|&b| b == b'\n') { [INFO] [stdout] 130 | buf.drain(..=pos); [INFO] [stdout] 131 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/http/sessions.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | / store [INFO] [stdout] 302 | | .start_session(&state.config, spec) [INFO] [stdout] 303 | | .await [INFO] [stdout] 304 | | .and_then(|id| { [INFO] [stdout] 305 | | let summary = store.get_summary(&id); [INFO] [stdout] 306 | | Ok((id, summary)) [INFO] [stdout] 307 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 304 ~ .map(|id| { [INFO] [stdout] 305 | let summary = store.get_summary(&id); [INFO] [stdout] 306 ~ (id, summary) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/config.rs:144:41 [INFO] [stdout] | [INFO] [stdout] 144 | let mut out = String::with_capacity((bytes.len() * 4 + 2) / 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(bytes.len() * 4).div_ceil(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:208:30 [INFO] [stdout] | [INFO] [stdout] 208 | fn load_overrides(state_dir: &PathBuf) -> AppConfigOverrides { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 208 - fn load_overrides(state_dir: &PathBuf) -> AppConfigOverrides { [INFO] [stdout] 208 + fn load_overrides(state_dir: &Path) -> AppConfigOverrides { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/daemon/rpc.rs:338:17 [INFO] [stdout] | [INFO] [stdout] 338 | / if let Some(dl) = deadline { [INFO] [stdout] 339 | | if tokio::time::Instant::now() >= dl { [INFO] [stdout] 340 | | break 'wait; [INFO] [stdout] 341 | | } [INFO] [stdout] 342 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 338 ~ if let Some(dl) = deadline [INFO] [stdout] 339 ~ && tokio::time::Instant::now() >= dl { [INFO] [stdout] 340 | break 'wait; [INFO] [stdout] 341 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/daemon/rpc.rs:372:25 [INFO] [stdout] | [INFO] [stdout] 372 | / if let Some(dl) = deadline { [INFO] [stdout] 373 | | if tokio::time::Instant::now() >= dl { [INFO] [stdout] 374 | | break 'wait; [INFO] [stdout] 375 | | } [INFO] [stdout] 376 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 372 ~ if let Some(dl) = deadline [INFO] [stdout] 373 ~ && tokio::time::Instant::now() >= dl { [INFO] [stdout] 374 | break 'wait; [INFO] [stdout] 375 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `query.offset` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/db.rs:183:22 [INFO] [stdout] | [INFO] [stdout] 183 | let offset = query.offset.max(0) as i64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `query.offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/db.rs:203:17 [INFO] [stdout] | [INFO] [stdout] 203 | qb.push(&format!(" ORDER BY {} {}", sort_field, order)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!(" ORDER BY {} {}", sort_field, order)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/http/auth.rs:73:39 [INFO] [stdout] | [INFO] [stdout] 73 | lockout.retain(|_, r| r.locked_until.map_or(true, |t| now < t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 73 - lockout.retain(|_, r| r.locked_until.map_or(true, |t| now < t)); [INFO] [stdout] 73 + lockout.retain(|_, r| r.locked_until.is_none_or(|t| now < t)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Session` [INFO] [stdout] --> src/http/mod.rs:41:1 [INFO] [stdout] | [INFO] [stdout] 41 | / pub enum SessionEvent { [INFO] [stdout] 42 | | SessionCreated(SessionSummary), [INFO] [stdout] 43 | | SessionUpdated(SessionSummary), [INFO] [stdout] 44 | | SessionDeleted { [INFO] [stdout] ... | [INFO] [stdout] 56 | | }, [INFO] [stdout] 57 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/http/auth.rs:337:5 [INFO] [stdout] | [INFO] [stdout] 337 | / if let Some(ref token) = token { [INFO] [stdout] 338 | | if auth.is_valid_token(token).await { [INFO] [stdout] 339 | | debug!(path = %path, "auth: authorized request"); [INFO] [stdout] 340 | | return next.run(request).await; [INFO] [stdout] 341 | | } [INFO] [stdout] 342 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 337 ~ if let Some(ref token) = token [INFO] [stdout] 338 ~ && auth.is_valid_token(token).await { [INFO] [stdout] 339 | debug!(path = %path, "auth: authorized request"); [INFO] [stdout] 340 | return next.run(request).await; [INFO] [stdout] 341 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/notification/prompt.rs:98:17 [INFO] [stdout] | [INFO] [stdout] 98 | while let Some(c) = chars.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for c in chars.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/notification/prompt.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | while let Some(c) = chars.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for c in chars.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/http/sessions.rs:144:22 [INFO] [stdout] | [INFO] [stdout] 144 | let page_limit = params.limit.unwrap_or(20).max(1).min(200); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `params.limit.unwrap_or(20).clamp(1, 200)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/notification/mod.rs:101:31 [INFO] [stdout] | [INFO] [stdout] 101 | let raw = clean [INFO] [stdout] | _______________________________^ [INFO] [stdout] 102 | | .lines() [INFO] [stdout] 103 | | .filter(|l| !l.trim().is_empty()) [INFO] [stdout] 104 | | .last() [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 104 - .last() [INFO] [stdout] 104 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/notification/mod.rs:118:31 [INFO] [stdout] | [INFO] [stdout] 118 | let raw = clean [INFO] [stdout] | _______________________________^ [INFO] [stdout] 119 | | .lines() [INFO] [stdout] 120 | | .filter(|l| !l.trim().is_empty()) [INFO] [stdout] 121 | | .last() [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 121 - .last() [INFO] [stdout] 121 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/http/sessions.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | / store [INFO] [stdout] 302 | | .start_session(&state.config, spec) [INFO] [stdout] 303 | | .await [INFO] [stdout] 304 | | .and_then(|id| { [INFO] [stdout] 305 | | let summary = store.get_summary(&id); [INFO] [stdout] 306 | | Ok((id, summary)) [INFO] [stdout] 307 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 304 ~ .map(|id| { [INFO] [stdout] 305 | let summary = store.get_summary(&id); [INFO] [stdout] 306 ~ (id, summary) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Session` [INFO] [stdout] --> src/http/mod.rs:41:1 [INFO] [stdout] | [INFO] [stdout] 41 | / pub enum SessionEvent { [INFO] [stdout] 42 | | SessionCreated(SessionSummary), [INFO] [stdout] 43 | | SessionUpdated(SessionSummary), [INFO] [stdout] 44 | | SessionDeleted { [INFO] [stdout] ... | [INFO] [stdout] 56 | | }, [INFO] [stdout] 57 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/notification/prompt.rs:98:17 [INFO] [stdout] | [INFO] [stdout] 98 | while let Some(c) = chars.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for c in chars.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/notification/prompt.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | while let Some(c) = chars.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for c in chars.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/notification/mod.rs:101:31 [INFO] [stdout] | [INFO] [stdout] 101 | let raw = clean [INFO] [stdout] | _______________________________^ [INFO] [stdout] 102 | | .lines() [INFO] [stdout] 103 | | .filter(|l| !l.trim().is_empty()) [INFO] [stdout] 104 | | .last() [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 104 - .last() [INFO] [stdout] 104 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/notification/mod.rs:118:31 [INFO] [stdout] | [INFO] [stdout] 118 | let raw = clean [INFO] [stdout] | _______________________________^ [INFO] [stdout] 119 | | .lines() [INFO] [stdout] 120 | | .filter(|l| !l.trim().is_empty()) [INFO] [stdout] 121 | | .last() [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 121 - .last() [INFO] [stdout] 121 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/session/store.rs:511:17 [INFO] [stdout] | [INFO] [stdout] 511 | / if let Some(last_attach_activity) = rt.last_attach_activity_at { [INFO] [stdout] 512 | | if now.duration_since(last_attach_activity) < suppression_window { [INFO] [stdout] 513 | | rt.last_output_at = None; [INFO] [stdout] 514 | | return None; [INFO] [stdout] 515 | | } [INFO] [stdout] 516 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 511 ~ if let Some(last_attach_activity) = rt.last_attach_activity_at [INFO] [stdout] 512 ~ && now.duration_since(last_attach_activity) < suppression_window { [INFO] [stdout] 513 | rt.last_output_at = None; [INFO] [stdout] 514 | return None; [INFO] [stdout] 515 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/session/store.rs:523:17 [INFO] [stdout] | [INFO] [stdout] 523 | / if let Some(last_notified_at) = rt.last_notified_at { [INFO] [stdout] 524 | | if now.duration_since(last_notified_at) < min_notification_interval { [INFO] [stdout] 525 | | return None; [INFO] [stdout] 526 | | } [INFO] [stdout] 527 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 523 ~ if let Some(last_notified_at) = rt.last_notified_at [INFO] [stdout] 524 ~ && now.duration_since(last_notified_at) < min_notification_interval { [INFO] [stdout] 525 | return None; [INFO] [stdout] 526 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/session/store.rs:555:9 [INFO] [stdout] | [INFO] [stdout] 555 | / if let Some(runtime) = self.sessions.get(session_id) { [INFO] [stdout] 556 | | if let Ok(mut rt) = runtime.lock() { [INFO] [stdout] 557 | | rt.notified_output_epoch = Some(output_epoch); [INFO] [stdout] 558 | | rt.last_notified_at = Some(notified_at); [INFO] [stdout] 559 | | } [INFO] [stdout] 560 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 555 ~ if let Some(runtime) = self.sessions.get(session_id) [INFO] [stdout] 556 ~ && let Ok(mut rt) = runtime.lock() { [INFO] [stdout] 557 | rt.notified_output_epoch = Some(output_epoch); [INFO] [stdout] 558 | rt.last_notified_at = Some(notified_at); [INFO] [stdout] 559 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/storage.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return dirs::home_dir() [INFO] [stdout] 30 | | .unwrap_or_else(|| PathBuf::from(".")) [INFO] [stdout] 31 | | .join(".local") [INFO] [stdout] 32 | | .join("state") [INFO] [stdout] 33 | | .join("oly"); [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ dirs::home_dir() [INFO] [stdout] 30 + .unwrap_or_else(|| PathBuf::from(".")) [INFO] [stdout] 31 + .join(".local") [INFO] [stdout] 32 + .join("state") [INFO] [stdout] 33 ~ .join("oly") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u16` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:59:59 [INFO] [stdout] | [INFO] [stdout] 59 | let http_port = start_args.port.unwrap_or(config.http_port.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.http_port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `eprintln!` [INFO] [stdout] --> src/main.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 111 | eprintln!(""); [INFO] [stdout] | ^^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:189:59 [INFO] [stdout] | [INFO] [stdout] 189 | ... println!("{:<24} {}", "NAME", "CREATED"); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 189 - println!("{:<24} {}", "NAME", "CREATED"); [INFO] [stdout] 189 + println!("{:<24} CREATED", "NAME"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:234:40 [INFO] [stdout] | [INFO] [stdout] 234 | println!("{}", "NAME"); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 234 - println!("{}", "NAME"); [INFO] [stdout] 234 + println!("NAME"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:257:72 [INFO] [stdout] | [INFO] [stdout] 257 | println!("{:<24} {:<12} {}", "NAME", "STATUS", "PRIMARY URL"); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 257 - println!("{:<24} {:<12} {}", "NAME", "STATUS", "PRIMARY URL"); [INFO] [stdout] 257 + println!("{:<24} {:<12} PRIMARY URL", "NAME", "STATUS"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/session/store.rs:511:17 [INFO] [stdout] | [INFO] [stdout] 511 | / if let Some(last_attach_activity) = rt.last_attach_activity_at { [INFO] [stdout] 512 | | if now.duration_since(last_attach_activity) < suppression_window { [INFO] [stdout] 513 | | rt.last_output_at = None; [INFO] [stdout] 514 | | return None; [INFO] [stdout] 515 | | } [INFO] [stdout] 516 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 511 ~ if let Some(last_attach_activity) = rt.last_attach_activity_at [INFO] [stdout] 512 ~ && now.duration_since(last_attach_activity) < suppression_window { [INFO] [stdout] 513 | rt.last_output_at = None; [INFO] [stdout] 514 | return None; [INFO] [stdout] 515 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/session/store.rs:523:17 [INFO] [stdout] | [INFO] [stdout] 523 | / if let Some(last_notified_at) = rt.last_notified_at { [INFO] [stdout] 524 | | if now.duration_since(last_notified_at) < min_notification_interval { [INFO] [stdout] 525 | | return None; [INFO] [stdout] 526 | | } [INFO] [stdout] 527 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 523 ~ if let Some(last_notified_at) = rt.last_notified_at [INFO] [stdout] 524 ~ && now.duration_since(last_notified_at) < min_notification_interval { [INFO] [stdout] 525 | return None; [INFO] [stdout] 526 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/session/store.rs:555:9 [INFO] [stdout] | [INFO] [stdout] 555 | / if let Some(runtime) = self.sessions.get(session_id) { [INFO] [stdout] 556 | | if let Ok(mut rt) = runtime.lock() { [INFO] [stdout] 557 | | rt.notified_output_epoch = Some(output_epoch); [INFO] [stdout] 558 | | rt.last_notified_at = Some(notified_at); [INFO] [stdout] 559 | | } [INFO] [stdout] 560 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 555 ~ if let Some(runtime) = self.sessions.get(session_id) [INFO] [stdout] 556 ~ && let Ok(mut rt) = runtime.lock() { [INFO] [stdout] 557 | rt.notified_output_epoch = Some(output_epoch); [INFO] [stdout] 558 | rt.last_notified_at = Some(notified_at); [INFO] [stdout] 559 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/storage.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return dirs::home_dir() [INFO] [stdout] 30 | | .unwrap_or_else(|| PathBuf::from(".")) [INFO] [stdout] 31 | | .join(".local") [INFO] [stdout] 32 | | .join("state") [INFO] [stdout] 33 | | .join("oly"); [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ dirs::home_dir() [INFO] [stdout] 30 + .unwrap_or_else(|| PathBuf::from(".")) [INFO] [stdout] 31 + .join(".local") [INFO] [stdout] 32 + .join("state") [INFO] [stdout] 33 ~ .join("oly") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u16` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:59:59 [INFO] [stdout] | [INFO] [stdout] 59 | let http_port = start_args.port.unwrap_or(config.http_port.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.http_port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `eprintln!` [INFO] [stdout] --> src/main.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 111 | eprintln!(""); [INFO] [stdout] | ^^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:189:59 [INFO] [stdout] | [INFO] [stdout] 189 | ... println!("{:<24} {}", "NAME", "CREATED"); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 189 - println!("{:<24} {}", "NAME", "CREATED"); [INFO] [stdout] 189 + println!("{:<24} CREATED", "NAME"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:234:40 [INFO] [stdout] | [INFO] [stdout] 234 | println!("{}", "NAME"); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 234 - println!("{}", "NAME"); [INFO] [stdout] 234 + println!("NAME"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:257:72 [INFO] [stdout] | [INFO] [stdout] 257 | println!("{:<24} {:<12} {}", "NAME", "STATUS", "PRIMARY URL"); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 257 - println!("{:<24} {:<12} {}", "NAME", "STATUS", "PRIMARY URL"); [INFO] [stdout] 257 + println!("{:<24} {:<12} PRIMARY URL", "NAME", "STATUS"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 09s [INFO] running `Command { std: "docker" "inspect" "5e6770e299acc49b8066b72e8ea3fe3cee3150c32e603efd6fa5c792c9c23d62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e6770e299acc49b8066b72e8ea3fe3cee3150c32e603efd6fa5c792c9c23d62", kill_on_drop: false }` [INFO] [stdout] 5e6770e299acc49b8066b72e8ea3fe3cee3150c32e603efd6fa5c792c9c23d62