[INFO] fetching crate octorus 0.5.7... [INFO] linting octorus-0.5.7 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate octorus 0.5.7 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate octorus 0.5.7 [INFO] finished tweaking crates.io crate octorus 0.5.7 [INFO] tweaked toml for crates.io crate octorus 0.5.7 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate octorus 0.5.7 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate octorus 0.5.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tree-sitter-language v0.1.6 [INFO] [stderr] Downloaded tree-sitter-svelte-ng v1.0.2 [INFO] [stderr] Downloaded syntect-tui v3.0.4 [INFO] [stderr] Downloaded tree-sitter-html v0.23.2 [INFO] [stderr] Downloaded tree-sitter-lua v0.4.1 [INFO] [stderr] Downloaded octorus-tree-sitter-vue3 v0.1.0 [INFO] [stderr] Downloaded tree-sitter-css v0.25.0 [INFO] [stderr] Downloaded tree-sitter-go v0.25.0 [INFO] [stderr] Downloaded tree-sitter-python v0.25.0 [INFO] [stderr] Downloaded octorus-tree-sitter-moonbit v0.1.0 [INFO] [stderr] Downloaded tree-sitter v0.26.3 [INFO] [stderr] Downloaded tree-sitter-zig v1.1.2 [INFO] [stderr] Downloaded tree-sitter-java v0.23.5 [INFO] [stderr] Downloaded tree-sitter-c v0.24.1 [INFO] [stderr] Downloaded tree-sitter-javascript v0.25.0 [INFO] [stderr] Downloaded tree-sitter-md v0.5.2 [INFO] [stderr] Downloaded tree-sitter-rust v0.24.0 [INFO] [stderr] Downloaded tree-sitter-bash v0.25.1 [INFO] [stderr] Downloaded ratatui v0.28.1 [INFO] [stderr] Downloaded tree-sitter-ruby v0.23.1 [INFO] [stderr] Downloaded tree-sitter-php v0.24.2 [INFO] [stderr] Downloaded tree-sitter-typescript v0.23.2 [INFO] [stderr] Downloaded tree-sitter-haskell v0.23.1 [INFO] [stderr] Downloaded tree-sitter-swift v0.7.1 [INFO] [stderr] Downloaded tree-sitter-cpp v0.23.4 [INFO] [stderr] Downloaded tree-sitter-c-sharp v0.23.1 [INFO] [stderr] Downloaded two-face v0.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 21bbfeed5fcf5af840fbefd83539030b80fa8633f6fccb2b5c58c5838ab866aa [INFO] running `Command { std: "docker" "start" "-a" "21bbfeed5fcf5af840fbefd83539030b80fa8633f6fccb2b5c58c5838ab866aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "21bbfeed5fcf5af840fbefd83539030b80fa8633f6fccb2b5c58c5838ab866aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21bbfeed5fcf5af840fbefd83539030b80fa8633f6fccb2b5c58c5838ab866aa", kill_on_drop: false }` [INFO] [stdout] 21bbfeed5fcf5af840fbefd83539030b80fa8633f6fccb2b5c58c5838ab866aa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5cedd7860ab6560219f5022e582bb03b52c8a6ed9178017d7cd2dc9d5c0798b1 [INFO] running `Command { std: "docker" "start" "-a" "5cedd7860ab6560219f5022e582bb03b52c8a6ed9178017d7cd2dc9d5c0798b1", kill_on_drop: false }` [INFO] [stderr] Compiling tree-sitter-language v0.1.6 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking time-core v0.1.7 [INFO] [stderr] Compiling onig_sys v69.9.1 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking compact_str v0.9.0 [INFO] [stderr] Checking lru v0.16.3 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking quick-xml v0.38.4 [INFO] [stderr] Compiling phf_shared v0.13.1 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking time v0.3.45 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Checking line-clipping v0.3.5 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Compiling phf_generator v0.13.1 [INFO] [stderr] Compiling pest v2.8.5 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Compiling tree-sitter-html v0.23.2 [INFO] [stderr] Compiling tree-sitter-javascript v0.25.0 [INFO] [stderr] Compiling tree-sitter-md v0.5.2 [INFO] [stderr] Compiling tree-sitter-svelte-ng v1.0.2 [INFO] [stderr] Compiling octorus-tree-sitter-moonbit v0.1.0 [INFO] [stderr] Compiling tree-sitter-php v0.24.2 [INFO] [stderr] Compiling tree-sitter-zig v1.1.2 [INFO] [stderr] Compiling tree-sitter-go v0.25.0 [INFO] [stderr] Compiling tree-sitter-c-sharp v0.23.1 [INFO] [stderr] Compiling tree-sitter-python v0.25.0 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Compiling tree-sitter-java v0.23.5 [INFO] [stderr] Compiling tree-sitter-rust v0.24.0 [INFO] [stderr] Compiling tree-sitter-bash v0.25.1 [INFO] [stderr] Compiling tree-sitter-typescript v0.23.2 [INFO] [stderr] Compiling tree-sitter-ruby v0.23.1 [INFO] [stderr] Compiling tree-sitter-lua v0.4.1 [INFO] [stderr] Compiling tree-sitter-css v0.25.0 [INFO] [stderr] Compiling tree-sitter-haskell v0.23.1 [INFO] [stderr] Compiling tree-sitter-c v0.24.1 [INFO] [stderr] Compiling tree-sitter-swift v0.7.1 [INFO] [stderr] Compiling tree-sitter-cpp v0.23.4 [INFO] [stderr] Compiling octorus-tree-sitter-vue3 v0.1.0 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Compiling pest_meta v2.8.5 [INFO] [stderr] Compiling tree-sitter v0.26.3 [INFO] [stderr] Checking unicode-truncate v2.0.1 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking fancy-regex v0.16.2 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking onig v6.5.1 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking which v8.0.0 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Checking sdd v3.0.10 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling pest_generator v2.8.5 [INFO] [stderr] Checking scc v2.4.0 [INFO] [stderr] Checking similar v2.7.0 [INFO] [stderr] Checking assert_cmd v2.1.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerocopy-derive v0.8.33 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling phf_macros v0.13.1 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling pest_derive v2.8.5 [INFO] [stderr] Compiling serial_test_derive v3.3.1 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking phf v0.13.1 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking serial_test v3.3.1 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking kasuari v0.4.11 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking zerocopy v0.8.33 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Compiling instability v0.3.11 [INFO] [stderr] Checking ratatui-core v0.1.0 [INFO] [stderr] Checking ratatui v0.28.1 [INFO] [stderr] Checking ratatui-widgets v0.3.0 [INFO] [stderr] Checking ratatui-crossterm v0.1.0 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking plist v1.8.0 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking insta v1.46.3 [INFO] [stderr] Checking lasso v0.7.3 [INFO] [stderr] Checking ratatui-macros v0.7.0 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking ratatui v0.30.0 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking syntect v5.3.0 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking two-face v0.5.1 [INFO] [stderr] Checking syntect-tui v3.0.4 [INFO] [stderr] Checking octorus v0.5.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/github/commit.rs:84:14 [INFO] [stdout] | [INFO] [stdout] 84 | .map(|r| commit_response_to_pr_commit(r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `commit_response_to_pr_commit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/headless.rs:634:26 [INFO] [stdout] | [INFO] [stdout] 634 | .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 634 - .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e))?; [INFO] [stdout] 634 + .map_err(|e| std::io::Error::other(e))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/migrate.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 287 | / if def.scope == scope && def.filename == filename && def.version != current_version { [INFO] [stdout] 288 | | if hash == def.sha256 { [INFO] [stdout] 289 | | return FileStatus::MatchesPreviousDefault { [INFO] [stdout] 290 | | version: def.version.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 293 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 287 ~ if def.scope == scope && def.filename == filename && def.version != current_version [INFO] [stdout] 288 ~ && hash == def.sha256 { [INFO] [stdout] 289 | return FileStatus::MatchesPreviousDefault { [INFO] [stdout] 290 | version: def.version.to_string(), [INFO] [stdout] 291 | }; [INFO] [stdout] 292 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/migrate.rs:711:17 [INFO] [stdout] | [INFO] [stdout] 711 | / if !manifest.files.contains_key(&filename) { [INFO] [stdout] 712 | | // First time seeing this file — detect version from content hash [INFO] [stdout] 713 | | // or fall back to "0.0.0" to ensure future migrations aren't skipped [INFO] [stdout] 714 | | let detected_version = fs::read_to_string(path) [INFO] [stdout] ... | [INFO] [stdout] 730 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/migrate.rs:924:9 [INFO] [stdout] | [INFO] [stdout] 924 | &config_dir, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `config_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/migrate.rs:925:9 [INFO] [stdout] | [INFO] [stdout] 925 | skill_dir.as_deref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `skill_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/migrate.rs:998:36 [INFO] [stdout] | [INFO] [stdout] 998 | let backup_dir = create_backup(&config_dir, skill_dir.as_deref()) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `config_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/migrate.rs:998:49 [INFO] [stdout] | [INFO] [stdout] 998 | let backup_dir = create_backup(&config_dir, skill_dir.as_deref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `skill_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/update.rs:296:22 [INFO] [stdout] | [INFO] [stdout] 296 | .arg(&archive_path.to_string_lossy().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `archive_path.to_string_lossy().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.pr` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:194:18 [INFO] [stdout] | [INFO] [stdout] 193 | if args.ai_rally && args.pr.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 194 | let pr = args.pr.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/migrate.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 287 | / if def.scope == scope && def.filename == filename && def.version != current_version { [INFO] [stdout] 288 | | if hash == def.sha256 { [INFO] [stdout] 289 | | return FileStatus::MatchesPreviousDefault { [INFO] [stdout] 290 | | version: def.version.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 293 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 287 ~ if def.scope == scope && def.filename == filename && def.version != current_version [INFO] [stdout] 288 ~ && hash == def.sha256 { [INFO] [stdout] 289 | return FileStatus::MatchesPreviousDefault { [INFO] [stdout] 290 | version: def.version.to_string(), [INFO] [stdout] 291 | }; [INFO] [stdout] 292 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/migrate.rs:711:17 [INFO] [stdout] | [INFO] [stdout] 711 | / if !manifest.files.contains_key(&filename) { [INFO] [stdout] 712 | | // First time seeing this file — detect version from content hash [INFO] [stdout] 713 | | // or fall back to "0.0.0" to ensure future migrations aren't skipped [INFO] [stdout] 714 | | let detected_version = fs::read_to_string(path) [INFO] [stdout] ... | [INFO] [stdout] 730 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/migrate.rs:924:9 [INFO] [stdout] | [INFO] [stdout] 924 | &config_dir, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `config_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/migrate.rs:925:9 [INFO] [stdout] | [INFO] [stdout] 925 | skill_dir.as_deref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `skill_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/migrate.rs:998:36 [INFO] [stdout] | [INFO] [stdout] 998 | let backup_dir = create_backup(&config_dir, skill_dir.as_deref()) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `config_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/migrate.rs:998:49 [INFO] [stdout] | [INFO] [stdout] 998 | let backup_dir = create_backup(&config_dir, skill_dir.as_deref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `skill_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/update.rs:296:22 [INFO] [stdout] | [INFO] [stdout] 296 | .arg(&archive_path.to_string_lossy().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `archive_path.to_string_lossy().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/update.rs:585:26 [INFO] [stdout] | [INFO] [stdout] 585 | .arg(&archive_path.to_string_lossy().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `archive_path.to_string_lossy().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/update.rs:636:12 [INFO] [stdout] | [INFO] [stdout] 636 | if path.parent().map_or(false, |p| p.exists()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 636 - if path.parent().map_or(false, |p| p.exists()) { [INFO] [stdout] 636 + if path.parent().is_some_and(|p| p.exists()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.pr` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:194:18 [INFO] [stdout] | [INFO] [stdout] 193 | if args.ai_rally && args.pr.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 194 | let pr = args.pr.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/github/commit.rs:84:14 [INFO] [stdout] | [INFO] [stdout] 84 | .map(|r| commit_response_to_pr_commit(r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `commit_response_to_pr_commit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/headless.rs:634:26 [INFO] [stdout] | [INFO] [stdout] 634 | .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 634 - .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e))?; [INFO] [stdout] 634 + .map_err(|e| std::io::Error::other(e))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/headless.rs:1079:9 [INFO] [stdout] | [INFO] [stdout] 1079 | config.project_root = project_root; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `config::Config { project_root: project_root, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/headless.rs:1078:9 [INFO] [stdout] | [INFO] [stdout] 1078 | let mut config = Config::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/headless.rs:1095:9 [INFO] [stdout] | [INFO] [stdout] 1095 | config.project_root = project_root; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `config::Config { project_root: project_root, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/headless.rs:1094:9 [INFO] [stdout] | [INFO] [stdout] 1094 | let mut config = Config::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 17s [INFO] running `Command { std: "docker" "inspect" "5cedd7860ab6560219f5022e582bb03b52c8a6ed9178017d7cd2dc9d5c0798b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5cedd7860ab6560219f5022e582bb03b52c8a6ed9178017d7cd2dc9d5c0798b1", kill_on_drop: false }` [INFO] [stdout] 5cedd7860ab6560219f5022e582bb03b52c8a6ed9178017d7cd2dc9d5c0798b1