[INFO] fetching crate ochat 0.5.1... [INFO] linting ochat-0.5.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ochat 0.5.1 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate ochat 0.5.1 [INFO] finished tweaking crates.io crate ochat 0.5.1 [INFO] tweaked toml for crates.io crate ochat 0.5.1 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ochat 0.5.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ochat 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zmij v1.0.2 [INFO] [stderr] Downloaded version-compare v0.2.1 [INFO] [stderr] Downloaded unit-prefix v0.5.2 [INFO] [stderr] Downloaded ravif v0.11.20 [INFO] [stderr] Downloaded cc v1.2.49 [INFO] [stderr] Downloaded base64-stream v4.0.0 [INFO] [stderr] Downloaded educe v0.5.11 [INFO] [stderr] Downloaded ochat-common v0.5.1 [INFO] [stderr] Downloaded indicatif v0.18.3 [INFO] [stderr] Downloaded icu_normalizer v2.1.0 [INFO] [stderr] Downloaded icu_properties v2.1.0 [INFO] [stderr] Downloaded ochat-types v0.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 04d06b60414097a1c1fd421662d59d89d5d6c3cdb2bfbd147a031a61b0b3fa09 [INFO] running `Command { std: "docker" "start" "-a" "04d06b60414097a1c1fd421662d59d89d5d6c3cdb2bfbd147a031a61b0b3fa09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "04d06b60414097a1c1fd421662d59d89d5d6c3cdb2bfbd147a031a61b0b3fa09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04d06b60414097a1c1fd421662d59d89d5d6c3cdb2bfbd147a031a61b0b3fa09", kill_on_drop: false }` [INFO] [stdout] 04d06b60414097a1c1fd421662d59d89d5d6c3cdb2bfbd147a031a61b0b3fa09 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 99815ccfcc1739939c5f8693ce16f1400e44119f4aed2c7ed9ed2d7e881cc069 [INFO] running `Command { std: "docker" "start" "-a" "99815ccfcc1739939c5f8693ce16f1400e44119f4aed2c7ed9ed2d7e881cc069", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling cc v1.2.49 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Compiling zerocopy v0.8.26 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling zmij v1.0.2 [INFO] [stderr] Compiling built v0.7.7 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking indexmap v2.12.0 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Compiling serde_json v1.0.148 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking imgref v1.12.0 [INFO] [stderr] Checking bitstream-io v2.6.0 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking avif-serialize v0.8.6 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking pxfm v0.1.25 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking iri-string v0.7.9 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking rustls-pki-types v1.13.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking generic-array v1.3.5 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking papergrid v0.17.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Checking moxcms v0.7.9 [INFO] [stderr] Checking fd-lock v4.0.4 [INFO] [stderr] Checking console v0.16.1 [INFO] [stderr] Checking testing_table v0.3.0 [INFO] [stderr] Checking unit-prefix v0.5.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling zerocopy-derive v0.8.26 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.1.0 [INFO] [stderr] Checking icu_normalizer v2.1.0 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Compiling enum-ordinalize-derive v4.3.2 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Compiling enum-ordinalize v4.3.2 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Compiling educe v0.5.11 [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling tabled_derive v0.11.0 [INFO] [stderr] Checking base64-stream v4.0.0 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking indicatif v0.18.3 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking rustyline v17.0.2 [INFO] [stderr] Checking tabled v0.20.0 [INFO] [stderr] Checking ochat-types v0.5.1 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.24 [INFO] [stderr] Checking ravif v0.11.20 [INFO] [stderr] Checking image v0.25.8 [INFO] [stderr] Checking ochat-common v0.5.1 [INFO] [stderr] Checking ochat v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/main.rs:111:1 [INFO] [stdout] | [INFO] [stdout] 111 | impl Into for ClapProviderType { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 111 ~ impl From for ProviderType { [INFO] [stdout] 112 ~ fn from(val: ClapProviderType) -> Self { [INFO] [stdout] 113 ~ match val { [INFO] [stdout] 114 ~ ClapProviderType::Ollama => ProviderType::Ollama, [INFO] [stdout] 115 ~ ClapProviderType::OpenAI => ProviderType::OpenAI, [INFO] [stdout] 116 ~ ClapProviderType::Gemini => ProviderType::Gemini, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:154:35 [INFO] [stdout] | [INFO] [stdout] 154 | let download_server = server || !server && !gui; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 154 - let download_server = server || !server && !gui; [INFO] [stdout] 154 + let download_server = !(!server && gui); [INFO] [stdout] | [INFO] [stdout] 154 - let download_server = server || !server && !gui; [INFO] [stdout] 154 + let download_server = server || !gui; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:155:33 [INFO] [stdout] | [INFO] [stdout] 155 | let download_iced = gui || !gui && !server; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 155 - let download_iced = gui || !gui && !server; [INFO] [stdout] 155 + let download_iced = !(!gui && server); [INFO] [stdout] | [INFO] [stdout] 155 - let download_iced = gui || !gui && !server; [INFO] [stdout] 155 + let download_iced = gui || !server; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:304:58 [INFO] [stdout] | [INFO] [stdout] 304 | ProviderAction::Pull { model } => pull_model(&req, &args.id, &model).await, [INFO] [stdout] | ^^^^ help: change this to: `req` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:306:17 [INFO] [stdout] | [INFO] [stdout] 306 | let _ = repl(&req, args.id, model).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 306 - let _ = repl(&req, args.id, model).await?; [INFO] [stdout] 306 + repl(&req, args.id, model).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:306:30 [INFO] [stdout] | [INFO] [stdout] 306 | let _ = repl(&req, args.id, model).await?; [INFO] [stdout] | ^^^^ help: change this to: `req` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:388:13 [INFO] [stdout] | [INFO] [stdout] 388 | let _ = server.kill()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 388 - let _ = server.kill()?; [INFO] [stdout] 388 + server.kill()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:405:13 [INFO] [stdout] | [INFO] [stdout] 405 | let _ = server.kill()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 405 - let _ = server.kill()?; [INFO] [stdout] 405 + server.kill()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:415:13 [INFO] [stdout] | [INFO] [stdout] 415 | let _ = server.kill()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 415 - let _ = server.kill()?; [INFO] [stdout] 415 + server.kill()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:439:20 [INFO] [stdout] | [INFO] [stdout] 439 | pull_model(&req, &provider, &model).await; [INFO] [stdout] | ^^^^ help: change this to: `req` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:459:26 [INFO] [stdout] | [INFO] [stdout] 459 | .get(&format!("{0}/generation/text/stream/", req.url,)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{0}/generation/text/stream/", req.url,)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:478:29 [INFO] [stdout] | [INFO] [stdout] 478 | / ... let _ = match serde_json::from_slice::(&response) { [INFO] [stdout] 479 | | ... Ok(x) => match x { [INFO] [stdout] 480 | | ... ChatStreamResult::Idle => {} [INFO] [stdout] 481 | | ... ChatStreamResult::Generating(x) => { [INFO] [stdout] ... | [INFO] [stdout] 493 | | ... Err(e) => eprintln!("{e}"), [INFO] [stdout] 494 | | ... }; [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 478 - let _ = match serde_json::from_slice::(&response) { [INFO] [stdout] 478 + match serde_json::from_slice::(&response) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:482:41 [INFO] [stdout] | [INFO] [stdout] 482 | ... let _ = stdout.write_all(x.content.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 482 - let _ = stdout.write_all(x.content.as_bytes()).unwrap(); [INFO] [stdout] 482 + stdout.write_all(x.content.as_bytes()).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:483:41 [INFO] [stdout] | [INFO] [stdout] 483 | ... let _ = stdout.flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 483 - let _ = stdout.flush().unwrap(); [INFO] [stdout] 483 + stdout.flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:533:15 [INFO] [stdout] | [INFO] [stdout] 533 | .post(&format!( [INFO] [stdout] | _______________^ [INFO] [stdout] 534 | | "{0}/provider/{1}/model/{2}", [INFO] [stdout] 535 | | req.url, provider, model [INFO] [stdout] 536 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 533 ~ .post(format!( [INFO] [stdout] 534 + "{0}/provider/{1}/model/{2}", [INFO] [stdout] 535 + req.url, provider, model [INFO] [stdout] 536 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:545:17 [INFO] [stdout] | [INFO] [stdout] 545 | / let _ = match serde_json::from_slice::(&response) { [INFO] [stdout] 546 | | Ok(x) => match x { [INFO] [stdout] 547 | | OllamaPullModelStreamResult::Idle => {} [INFO] [stdout] 548 | | OllamaPullModelStreamResult::Pulling(x) => { [INFO] [stdout] ... | [INFO] [stdout] 560 | | Err(e) => eprintln!("{e}"), [INFO] [stdout] 561 | | }; [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 545 - let _ = match serde_json::from_slice::(&response) { [INFO] [stdout] 545 + match serde_json::from_slice::(&response) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/main.rs:111:1 [INFO] [stdout] | [INFO] [stdout] 111 | impl Into for ClapProviderType { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 111 ~ impl From for ProviderType { [INFO] [stdout] 112 ~ fn from(val: ClapProviderType) -> Self { [INFO] [stdout] 113 ~ match val { [INFO] [stdout] 114 ~ ClapProviderType::Ollama => ProviderType::Ollama, [INFO] [stdout] 115 ~ ClapProviderType::OpenAI => ProviderType::OpenAI, [INFO] [stdout] 116 ~ ClapProviderType::Gemini => ProviderType::Gemini, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:154:35 [INFO] [stdout] | [INFO] [stdout] 154 | let download_server = server || !server && !gui; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 154 - let download_server = server || !server && !gui; [INFO] [stdout] 154 + let download_server = !(!server && gui); [INFO] [stdout] | [INFO] [stdout] 154 - let download_server = server || !server && !gui; [INFO] [stdout] 154 + let download_server = server || !gui; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:155:33 [INFO] [stdout] | [INFO] [stdout] 155 | let download_iced = gui || !gui && !server; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 155 - let download_iced = gui || !gui && !server; [INFO] [stdout] 155 + let download_iced = !(!gui && server); [INFO] [stdout] | [INFO] [stdout] 155 - let download_iced = gui || !gui && !server; [INFO] [stdout] 155 + let download_iced = gui || !server; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:304:58 [INFO] [stdout] | [INFO] [stdout] 304 | ProviderAction::Pull { model } => pull_model(&req, &args.id, &model).await, [INFO] [stdout] | ^^^^ help: change this to: `req` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:306:17 [INFO] [stdout] | [INFO] [stdout] 306 | let _ = repl(&req, args.id, model).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 306 - let _ = repl(&req, args.id, model).await?; [INFO] [stdout] 306 + repl(&req, args.id, model).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:306:30 [INFO] [stdout] | [INFO] [stdout] 306 | let _ = repl(&req, args.id, model).await?; [INFO] [stdout] | ^^^^ help: change this to: `req` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:388:13 [INFO] [stdout] | [INFO] [stdout] 388 | let _ = server.kill()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 388 - let _ = server.kill()?; [INFO] [stdout] 388 + server.kill()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:405:13 [INFO] [stdout] | [INFO] [stdout] 405 | let _ = server.kill()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 405 - let _ = server.kill()?; [INFO] [stdout] 405 + server.kill()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:415:13 [INFO] [stdout] | [INFO] [stdout] 415 | let _ = server.kill()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 415 - let _ = server.kill()?; [INFO] [stdout] 415 + server.kill()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:439:20 [INFO] [stdout] | [INFO] [stdout] 439 | pull_model(&req, &provider, &model).await; [INFO] [stdout] | ^^^^ help: change this to: `req` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:459:26 [INFO] [stdout] | [INFO] [stdout] 459 | .get(&format!("{0}/generation/text/stream/", req.url,)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{0}/generation/text/stream/", req.url,)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:478:29 [INFO] [stdout] | [INFO] [stdout] 478 | / ... let _ = match serde_json::from_slice::(&response) { [INFO] [stdout] 479 | | ... Ok(x) => match x { [INFO] [stdout] 480 | | ... ChatStreamResult::Idle => {} [INFO] [stdout] 481 | | ... ChatStreamResult::Generating(x) => { [INFO] [stdout] ... | [INFO] [stdout] 493 | | ... Err(e) => eprintln!("{e}"), [INFO] [stdout] 494 | | ... }; [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 478 - let _ = match serde_json::from_slice::(&response) { [INFO] [stdout] 478 + match serde_json::from_slice::(&response) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:482:41 [INFO] [stdout] | [INFO] [stdout] 482 | ... let _ = stdout.write_all(x.content.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 482 - let _ = stdout.write_all(x.content.as_bytes()).unwrap(); [INFO] [stdout] 482 + stdout.write_all(x.content.as_bytes()).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:483:41 [INFO] [stdout] | [INFO] [stdout] 483 | ... let _ = stdout.flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 483 - let _ = stdout.flush().unwrap(); [INFO] [stdout] 483 + stdout.flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:533:15 [INFO] [stdout] | [INFO] [stdout] 533 | .post(&format!( [INFO] [stdout] | _______________^ [INFO] [stdout] 534 | | "{0}/provider/{1}/model/{2}", [INFO] [stdout] 535 | | req.url, provider, model [INFO] [stdout] 536 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 533 ~ .post(format!( [INFO] [stdout] 534 + "{0}/provider/{1}/model/{2}", [INFO] [stdout] 535 + req.url, provider, model [INFO] [stdout] 536 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:545:17 [INFO] [stdout] | [INFO] [stdout] 545 | / let _ = match serde_json::from_slice::(&response) { [INFO] [stdout] 546 | | Ok(x) => match x { [INFO] [stdout] 547 | | OllamaPullModelStreamResult::Idle => {} [INFO] [stdout] 548 | | OllamaPullModelStreamResult::Pulling(x) => { [INFO] [stdout] ... | [INFO] [stdout] 560 | | Err(e) => eprintln!("{e}"), [INFO] [stdout] 561 | | }; [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 545 - let _ = match serde_json::from_slice::(&response) { [INFO] [stdout] 545 + match serde_json::from_slice::(&response) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 00s [INFO] running `Command { std: "docker" "inspect" "99815ccfcc1739939c5f8693ce16f1400e44119f4aed2c7ed9ed2d7e881cc069", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99815ccfcc1739939c5f8693ce16f1400e44119f4aed2c7ed9ed2d7e881cc069", kill_on_drop: false }` [INFO] [stdout] 99815ccfcc1739939c5f8693ce16f1400e44119f4aed2c7ed9ed2d7e881cc069