[INFO] fetching crate oauth21-server 0.1.2... [INFO] linting oauth21-server-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate oauth21-server 0.1.2 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate oauth21-server 0.1.2 [INFO] finished tweaking crates.io crate oauth21-server 0.1.2 [INFO] tweaked toml for crates.io crate oauth21-server 0.1.2 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate oauth21-server 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 55 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (available: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dddcef47c03658601cbfa6c6c4276a68f6355833c20030a04863c891803d2009 [INFO] running `Command { std: "docker" "start" "-a" "dddcef47c03658601cbfa6c6c4276a68f6355833c20030a04863c891803d2009", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dddcef47c03658601cbfa6c6c4276a68f6355833c20030a04863c891803d2009", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dddcef47c03658601cbfa6c6c4276a68f6355833c20030a04863c891803d2009", kill_on_drop: false }` [INFO] [stdout] dddcef47c03658601cbfa6c6c4276a68f6355833c20030a04863c891803d2009 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9d031b87e6ddb0bcdc0ce5304698278c3d63e6805cb29de8680b0f17e69dbfb1 [INFO] running `Command { std: "docker" "start" "-a" "9d031b87e6ddb0bcdc0ce5304698278c3d63e6805cb29de8680b0f17e69dbfb1", kill_on_drop: false }` [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking oauth21-server v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/error.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | error: error, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/error.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | state: state, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/error.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | error: error, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/error.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | state: state, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `grant_types` and `response_types` are never read [INFO] [stdout] --> src/client.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct Client { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 25 | pub(crate) grant_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 26 | pub(crate) response_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Client` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `access_token`, `token_type`, `expires_in`, and `scope` are never read [INFO] [stdout] --> src/provider.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub struct TokenResponse { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 49 | access_token: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 50 | token_type: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 51 | expires_in: u64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 52 | scope: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `state` is never read [INFO] [stdout] --> src/provider.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct AuthorizationInformation { [INFO] [stdout] | ------------------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 79 | state: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AuthorizationInformation` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/provider.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 84 | pub struct SigninInformation { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 85 | client_name: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 86 | client_uri: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 87 | logo_uri: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 88 | scopes: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 89 | contacts: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 90 | tos_uri: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 91 | policy_uri: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SigninInformation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `grant_types` and `response_types` are never read [INFO] [stdout] --> src/client.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct Client { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 25 | pub(crate) grant_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 26 | pub(crate) response_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Client` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `access_token`, `token_type`, `expires_in`, and `scope` are never read [INFO] [stdout] --> src/provider.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub struct TokenResponse { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 49 | access_token: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 50 | token_type: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 51 | expires_in: u64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 52 | scope: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `state` is never read [INFO] [stdout] --> src/provider.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct AuthorizationInformation { [INFO] [stdout] | ------------------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 79 | state: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AuthorizationInformation` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/provider.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 84 | pub struct SigninInformation { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 85 | client_name: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 86 | client_uri: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 87 | logo_uri: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 88 | scopes: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 89 | contacts: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 90 | tos_uri: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 91 | policy_uri: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SigninInformation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/provider.rs:240:21 [INFO] [stdout] | [INFO] [stdout] 240 | / !client [INFO] [stdout] 241 | | .scopes [INFO] [stdout] 242 | | .iter() [INFO] [stdout] 243 | | .find(|defined_scope| *defined_scope == scope) [INFO] [stdout] 244 | | .is_some() [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 240 ~ client [INFO] [stdout] 241 + .scopes [INFO] [stdout] 242 + .iter() [INFO] [stdout] 243 + .find(|defined_scope| *defined_scope == scope).is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/provider.rs:240:21 [INFO] [stdout] | [INFO] [stdout] 240 | / !client [INFO] [stdout] 241 | | .scopes [INFO] [stdout] 242 | | .iter() [INFO] [stdout] 243 | | .find(|defined_scope| *defined_scope == scope) [INFO] [stdout] 244 | | .is_some() [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 240 ~ client [INFO] [stdout] 241 + .scopes [INFO] [stdout] 242 + .iter() [INFO] [stdout] 243 + .find(|defined_scope| *defined_scope == scope).is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/provider.rs:343:62 [INFO] [stdout] | [INFO] [stdout] 343 | } else if authentication_information.redirect_uri != client.redirect_uris[0].to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `client.redirect_uris[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/provider.rs:358:20 [INFO] [stdout] | [INFO] [stdout] 358 | if &sha256(&request.code_verifier) [INFO] [stdout] | ^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | ____________________help: use the left value directly: `sha256(&request.code_verifier)` [INFO] [stdout] | | [INFO] [stdout] 359 | | != authentication_information.code_challenge.as_bytes() [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/provider.rs:343:62 [INFO] [stdout] | [INFO] [stdout] 343 | } else if authentication_information.redirect_uri != client.redirect_uris[0].to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `client.redirect_uris[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/provider.rs:358:20 [INFO] [stdout] | [INFO] [stdout] 358 | if &sha256(&request.code_verifier) [INFO] [stdout] | ^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | ____________________help: use the left value directly: `sha256(&request.code_verifier)` [INFO] [stdout] | | [INFO] [stdout] 359 | | != authentication_information.code_challenge.as_bytes() [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/provider.rs:409:17 [INFO] [stdout] | [INFO] [stdout] 409 | / !authenticated_client [INFO] [stdout] 410 | | .as_ref() [INFO] [stdout] 411 | | .unwrap() [INFO] [stdout] 412 | | .scopes [INFO] [stdout] 413 | | .iter() [INFO] [stdout] 414 | | .find(|defined_scope| *defined_scope == scope) [INFO] [stdout] 415 | | .is_some() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 409 ~ authenticated_client [INFO] [stdout] 410 + .as_ref() [INFO] [stdout] 411 + .unwrap() [INFO] [stdout] 412 + .scopes [INFO] [stdout] 413 + .iter() [INFO] [stdout] 414 + .find(|defined_scope| *defined_scope == scope).is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/provider.rs:409:17 [INFO] [stdout] | [INFO] [stdout] 409 | / !authenticated_client [INFO] [stdout] 410 | | .as_ref() [INFO] [stdout] 411 | | .unwrap() [INFO] [stdout] 412 | | .scopes [INFO] [stdout] 413 | | .iter() [INFO] [stdout] 414 | | .find(|defined_scope| *defined_scope == scope) [INFO] [stdout] 415 | | .is_some() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 409 ~ authenticated_client [INFO] [stdout] 410 + .as_ref() [INFO] [stdout] 411 + .unwrap() [INFO] [stdout] 412 + .scopes [INFO] [stdout] 413 + .iter() [INFO] [stdout] 414 + .find(|defined_scope| *defined_scope == scope).is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.32s [INFO] running `Command { std: "docker" "inspect" "9d031b87e6ddb0bcdc0ce5304698278c3d63e6805cb29de8680b0f17e69dbfb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d031b87e6ddb0bcdc0ce5304698278c3d63e6805cb29de8680b0f17e69dbfb1", kill_on_drop: false }` [INFO] [stdout] 9d031b87e6ddb0bcdc0ce5304698278c3d63e6805cb29de8680b0f17e69dbfb1