[INFO] fetching crate nylas 0.0.8... [INFO] linting nylas-0.0.8 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate nylas 0.0.8 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate nylas 0.0.8 [INFO] finished tweaking crates.io crate nylas 0.0.8 [INFO] tweaked toml for crates.io crate nylas 0.0.8 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate nylas 0.0.8 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 163 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.13.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b17433f681e095987114e9b7b01f04cfcfa87377b258e5a8171c614fbea8072 [INFO] running `Command { std: "docker" "start" "-a" "0b17433f681e095987114e9b7b01f04cfcfa87377b258e5a8171c614fbea8072", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b17433f681e095987114e9b7b01f04cfcfa87377b258e5a8171c614fbea8072", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b17433f681e095987114e9b7b01f04cfcfa87377b258e5a8171c614fbea8072", kill_on_drop: false }` [INFO] [stdout] 0b17433f681e095987114e9b7b01f04cfcfa87377b258e5a8171c614fbea8072 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24c0bea42bf702e78b76dff2fd2ab8c00a7c1534bb88ad0138e3312de4d1cf49 [INFO] running `Command { std: "docker" "start" "-a" "24c0bea42bf702e78b76dff2fd2ab8c00a7c1534bb88ad0138e3312de4d1cf49", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Checking libc v0.2.183 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking icu_properties_data v2.1.2 [INFO] [stderr] Checking icu_normalizer_data v2.1.1 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking serde_core v1.0.228 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking openssl-probe v0.2.1 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking httparse v1.10.1 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking zmij v1.0.21 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking ipnet v2.12.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking openssl-sys v0.9.112 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking openssl v0.10.76 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking native-tls v0.2.18 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking nylas v0.0.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/client.rs:68:16 [INFO] [stdout] | [INFO] [stdout] 68 | if let Some(_) = nylas.access_token { [INFO] [stdout] | -------^^^^^^^--------------------- help: try: `if nylas.access_token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/client.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 133 | if !Url::parse(redirect_uri).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Url::parse(redirect_uri).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/client.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | url.push_str("="); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('=')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/client.rs:244:17 [INFO] [stdout] | [INFO] [stdout] 244 | return Ok(access_token.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 244 - return Ok(access_token.to_string()); [INFO] [stdout] 244 + Ok(access_token.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/client.rs:246:17 [INFO] [stdout] | [INFO] [stdout] 246 | return Err("Access token not found in the response.".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 246 - return Err("Access token not found in the response.".to_string()); [INFO] [stdout] 246 + Err("Access token not found in the response.".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/client.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 254 | return Err(format!("HTTP Error: - {}", error_message)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return Err(format!("HTTP Error: - {}", error_message)); [INFO] [stdout] 254 + Err(format!("HTTP Error: - {}", error_message)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/messages.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / impl ToString for View { [INFO] [stdout] 16 | | fn to_string(&self) -> String { [INFO] [stdout] 17 | | match self { [INFO] [stdout] 18 | | View::Ids => "ids".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/messages.rs:146:53 [INFO] [stdout] | [INFO] [stdout] 146 | .any(|recipient| recipient.email == to.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*to` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/messages.rs:156:47 [INFO] [stdout] | [INFO] [stdout] 156 | .any(|sender| sender.email == from.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `*from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/messages.rs:166:53 [INFO] [stdout] | [INFO] [stdout] 166 | .any(|recipient| recipient.email == cc.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*cc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/messages.rs:176:53 [INFO] [stdout] | [INFO] [stdout] 176 | .any(|recipient| recipient.email == bcc.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*bcc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/messages.rs:222:34 [INFO] [stdout] | [INFO] [stdout] 222 | if self.thread_id != thread_id.to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `*thread_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/messages.rs:231:67 [INFO] [stdout] | [INFO] [stdout] 231 | .any(|label| self.labels.iter().any(|l| l.name == label.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `*label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/messages.rs:587:9 [INFO] [stdout] | [INFO] [stdout] 587 | sorted_messages.sort_by(|a, b| b.date.cmp(&a.date)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 587 - sorted_messages.sort_by(|a, b| b.date.cmp(&a.date)); [INFO] [stdout] 587 + sorted_messages.sort_by_key(|b| std::cmp::Reverse(b.date)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/client.rs:337:21 [INFO] [stdout] | [INFO] [stdout] 337 | pub fn messages(&mut self) -> Messages { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 337 | pub fn messages(&mut self) -> Messages<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/client.rs:68:16 [INFO] [stdout] | [INFO] [stdout] 68 | if let Some(_) = nylas.access_token { [INFO] [stdout] | -------^^^^^^^--------------------- help: try: `if nylas.access_token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/client.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 133 | if !Url::parse(redirect_uri).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Url::parse(redirect_uri).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/client.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | url.push_str("="); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('=')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/client.rs:244:17 [INFO] [stdout] | [INFO] [stdout] 244 | return Ok(access_token.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 244 - return Ok(access_token.to_string()); [INFO] [stdout] 244 + Ok(access_token.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/client.rs:246:17 [INFO] [stdout] | [INFO] [stdout] 246 | return Err("Access token not found in the response.".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 246 - return Err("Access token not found in the response.".to_string()); [INFO] [stdout] 246 + Err("Access token not found in the response.".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/client.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 254 | return Err(format!("HTTP Error: - {}", error_message)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return Err(format!("HTTP Error: - {}", error_message)); [INFO] [stdout] 254 + Err(format!("HTTP Error: - {}", error_message)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/messages.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / impl ToString for View { [INFO] [stdout] 16 | | fn to_string(&self) -> String { [INFO] [stdout] 17 | | match self { [INFO] [stdout] 18 | | View::Ids => "ids".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/messages.rs:146:53 [INFO] [stdout] | [INFO] [stdout] 146 | .any(|recipient| recipient.email == to.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*to` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/messages.rs:156:47 [INFO] [stdout] | [INFO] [stdout] 156 | .any(|sender| sender.email == from.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `*from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/messages.rs:166:53 [INFO] [stdout] | [INFO] [stdout] 166 | .any(|recipient| recipient.email == cc.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*cc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/messages.rs:176:53 [INFO] [stdout] | [INFO] [stdout] 176 | .any(|recipient| recipient.email == bcc.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*bcc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/messages.rs:222:34 [INFO] [stdout] | [INFO] [stdout] 222 | if self.thread_id != thread_id.to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `*thread_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/messages.rs:231:67 [INFO] [stdout] | [INFO] [stdout] 231 | .any(|label| self.labels.iter().any(|l| l.name == label.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `*label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/messages.rs:587:9 [INFO] [stdout] | [INFO] [stdout] 587 | sorted_messages.sort_by(|a, b| b.date.cmp(&a.date)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 587 - sorted_messages.sort_by(|a, b| b.date.cmp(&a.date)); [INFO] [stdout] 587 + sorted_messages.sort_by_key(|b| std::cmp::Reverse(b.date)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/client.rs:337:21 [INFO] [stdout] | [INFO] [stdout] 337 | pub fn messages(&mut self) -> Messages { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 337 | pub fn messages(&mut self) -> Messages<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.80s [INFO] running `Command { std: "docker" "inspect" "24c0bea42bf702e78b76dff2fd2ab8c00a7c1534bb88ad0138e3312de4d1cf49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24c0bea42bf702e78b76dff2fd2ab8c00a7c1534bb88ad0138e3312de4d1cf49", kill_on_drop: false }` [INFO] [stdout] 24c0bea42bf702e78b76dff2fd2ab8c00a7c1534bb88ad0138e3312de4d1cf49