[INFO] fetching crate nviwatch 0.2.1... [INFO] linting nviwatch-0.2.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate nviwatch 0.2.1 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate nviwatch 0.2.1 [INFO] finished tweaking crates.io crate nviwatch 0.2.1 [INFO] tweaked toml for crates.io crate nviwatch 0.2.1 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate nviwatch 0.2.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate nviwatch 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lru v0.12.4 [INFO] [stderr] Downloaded anstyle-query v1.1.1 [INFO] [stderr] Downloaded anstyle-wincon v3.0.4 [INFO] [stderr] Downloaded colorchoice v1.0.2 [INFO] [stderr] Downloaded influxdb_derive v0.5.1 [INFO] [stderr] Downloaded instability v0.3.2 [INFO] [stderr] Downloaded wrapcenum-derive v0.4.1 [INFO] [stderr] Downloaded anstyle-parse v0.2.5 [INFO] [stderr] Downloaded anstream v0.6.15 [INFO] [stderr] Downloaded serde_derive v1.0.209 [INFO] [stderr] Downloaded nvml-wrapper-sys v0.9.0 [INFO] [stderr] Downloaded nvml-wrapper v0.11.0 [INFO] [stderr] Downloaded flate2 v1.0.33 [INFO] [stderr] Downloaded serde v1.0.209 [INFO] [stderr] Downloaded bitflags v2.9.2 [INFO] [stderr] Downloaded influxdb v0.7.2 [INFO] [stderr] Downloaded prettytable-rs v0.10.0 [INFO] [stderr] Downloaded compact_str v0.8.0 [INFO] [stderr] Downloaded rustix v0.38.35 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2ee03b79064822f5d731eaa009306b7356cea69f3e0184ad348bce04e2944a4 [INFO] running `Command { std: "docker" "start" "-a" "a2ee03b79064822f5d731eaa009306b7356cea69f3e0184ad348bce04e2944a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2ee03b79064822f5d731eaa009306b7356cea69f3e0184ad348bce04e2944a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2ee03b79064822f5d731eaa009306b7356cea69f3e0184ad348bce04e2944a4", kill_on_drop: false }` [INFO] [stdout] a2ee03b79064822f5d731eaa009306b7356cea69f3e0184ad348bce04e2944a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87baedaacc61bc44305fd55b900a32aa86454441302a3c88469cd3262603b145 [INFO] running `Command { std: "docker" "start" "-a" "87baedaacc61bc44305fd55b900a32aa86454441302a3c88469cd3262603b145", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking bitflags v2.9.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking ring v0.17.14 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking slab v0.4.10 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling convert_case v0.7.1 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Compiling procfs v0.17.0 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking clap_builder v4.5.44 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking nvml-wrapper-sys v0.9.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Compiling indoc v2.0.6 [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Checking clap v4.5.45 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling influxdb_derive v0.5.1 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Compiling instability v0.3.2 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling wrapcenum-derive v0.4.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking nvml-wrapper v0.11.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking prettytable-rs v0.10.0 [INFO] [stderr] Checking procfs-core v0.17.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking influxdb v0.7.2 [INFO] [stderr] Checking nviwatch v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/ui/render.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | all_processes.sort_by(|a, b| b.1.used_gpu_memory.cmp(&a.1.used_gpu_memory)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 205 - all_processes.sort_by(|a, b| b.1.used_gpu_memory.cmp(&a.1.used_gpu_memory)); [INFO] [stdout] 205 + all_processes.sort_by_key(|b| std::cmp::Reverse(b.1.used_gpu_memory)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_state.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | assert!(!(0 < total_processes)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(0 >= total_processes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_state.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 111 | assert!(!(1 < total_processes)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(1 >= total_processes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/app_state.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | assert!(0 < state.gpu_infos.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!state.gpu_infos.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/ui/widgets.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 92 | if gpu_count > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ check performed here [INFO] [stdout] ... [INFO] [stdout] 96 | Constraint::Percentage((100 / gpu_count) as u16); [INFO] [stdout] | ----------------- division performed here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/utils/system.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | all_processes.sort_by(|a, b| b.used_gpu_memory.cmp(&a.used_gpu_memory)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 48 - all_processes.sort_by(|a, b| b.used_gpu_memory.cmp(&a.used_gpu_memory)); [INFO] [stdout] 48 + all_processes.sort_by_key(|b| std::cmp::Reverse(b.used_gpu_memory)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/utils/system.rs:62:36 [INFO] [stdout] | [INFO] [stdout] 62 | Err(e) => Err(Box::new(IoError::new( [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 63 | | ErrorKind::Other, [INFO] [stdout] 64 | | format!( [INFO] [stdout] 65 | | "Failed to terminate process {} ({}): {}", [INFO] [stdout] 66 | | pid, selected_process.command, e [INFO] [stdout] 67 | | ), [INFO] [stdout] 68 | | ))), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 62 ~ Err(e) => Err(Box::new(IoError::other( [INFO] [stdout] 63 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 147 | / if app_state.selected_process > 0 { [INFO] [stdout] 148 | | app_state.selected_process -= 1; [INFO] [stdout] 149 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 146 ~ KeyCode::Up [INFO] [stdout] 147 ~ if app_state.selected_process > 0 => { [INFO] [stdout] 148 | app_state.selected_process -= 1; [INFO] [stdout] 149 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/ui/render.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | all_processes.sort_by(|a, b| b.1.used_gpu_memory.cmp(&a.1.used_gpu_memory)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 205 - all_processes.sort_by(|a, b| b.1.used_gpu_memory.cmp(&a.1.used_gpu_memory)); [INFO] [stdout] 205 + all_processes.sort_by_key(|b| std::cmp::Reverse(b.1.used_gpu_memory)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:162:25 [INFO] [stdout] | [INFO] [stdout] 162 | / if app_state.use_tabbed_graphs && app_state.selected_gpu_tab > 0 { [INFO] [stdout] 163 | | app_state.selected_gpu_tab -= 1; [INFO] [stdout] 164 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 161 ~ KeyCode::Left [INFO] [stdout] 162 ~ if app_state.use_tabbed_graphs && app_state.selected_gpu_tab > 0 => { [INFO] [stdout] 163 | app_state.selected_gpu_tab -= 1; [INFO] [stdout] 164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:167:25 [INFO] [stdout] | [INFO] [stdout] 167 | / if app_state.use_tabbed_graphs [INFO] [stdout] 168 | | && app_state.selected_gpu_tab < app_state.gpu_infos.len() - 1 [INFO] [stdout] 169 | | { [INFO] [stdout] 170 | | app_state.selected_gpu_tab += 1; [INFO] [stdout] 171 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 166 ~ KeyCode::Right [INFO] [stdout] 167 | if app_state.use_tabbed_graphs [INFO] [stdout] 168 | && app_state.selected_gpu_tab < app_state.gpu_infos.len() - 1 [INFO] [stdout] 169 ~ => { [INFO] [stdout] 170 | app_state.selected_gpu_tab += 1; [INFO] [stdout] 171 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/ui/widgets.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 92 | if gpu_count > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ check performed here [INFO] [stdout] ... [INFO] [stdout] 96 | Constraint::Percentage((100 / gpu_count) as u16); [INFO] [stdout] | ----------------- division performed here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/utils/system.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | all_processes.sort_by(|a, b| b.used_gpu_memory.cmp(&a.used_gpu_memory)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 48 - all_processes.sort_by(|a, b| b.used_gpu_memory.cmp(&a.used_gpu_memory)); [INFO] [stdout] 48 + all_processes.sort_by_key(|b| std::cmp::Reverse(b.used_gpu_memory)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/utils/system.rs:62:36 [INFO] [stdout] | [INFO] [stdout] 62 | Err(e) => Err(Box::new(IoError::new( [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 63 | | ErrorKind::Other, [INFO] [stdout] 64 | | format!( [INFO] [stdout] 65 | | "Failed to terminate process {} ({}): {}", [INFO] [stdout] 66 | | pid, selected_process.command, e [INFO] [stdout] 67 | | ), [INFO] [stdout] 68 | | ))), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 62 ~ Err(e) => Err(Box::new(IoError::other( [INFO] [stdout] 63 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 147 | / if app_state.selected_process > 0 { [INFO] [stdout] 148 | | app_state.selected_process -= 1; [INFO] [stdout] 149 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 146 ~ KeyCode::Up [INFO] [stdout] 147 ~ if app_state.selected_process > 0 => { [INFO] [stdout] 148 | app_state.selected_process -= 1; [INFO] [stdout] 149 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:162:25 [INFO] [stdout] | [INFO] [stdout] 162 | / if app_state.use_tabbed_graphs && app_state.selected_gpu_tab > 0 { [INFO] [stdout] 163 | | app_state.selected_gpu_tab -= 1; [INFO] [stdout] 164 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 161 ~ KeyCode::Left [INFO] [stdout] 162 ~ if app_state.use_tabbed_graphs && app_state.selected_gpu_tab > 0 => { [INFO] [stdout] 163 | app_state.selected_gpu_tab -= 1; [INFO] [stdout] 164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:167:25 [INFO] [stdout] | [INFO] [stdout] 167 | / if app_state.use_tabbed_graphs [INFO] [stdout] 168 | | && app_state.selected_gpu_tab < app_state.gpu_infos.len() - 1 [INFO] [stdout] 169 | | { [INFO] [stdout] 170 | | app_state.selected_gpu_tab += 1; [INFO] [stdout] 171 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 166 ~ KeyCode::Right [INFO] [stdout] 167 | if app_state.use_tabbed_graphs [INFO] [stdout] 168 | && app_state.selected_gpu_tab < app_state.gpu_infos.len() - 1 [INFO] [stdout] 169 ~ => { [INFO] [stdout] 170 | app_state.selected_gpu_tab += 1; [INFO] [stdout] 171 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 20s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: influxdb v0.7.2 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "87baedaacc61bc44305fd55b900a32aa86454441302a3c88469cd3262603b145", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87baedaacc61bc44305fd55b900a32aa86454441302a3c88469cd3262603b145", kill_on_drop: false }` [INFO] [stdout] 87baedaacc61bc44305fd55b900a32aa86454441302a3c88469cd3262603b145