[INFO] fetching crate nixpkgs-fmt 1.3.0...
[INFO] linting nixpkgs-fmt-1.3.0 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate nixpkgs-fmt 1.3.0 into /workspace/builds/worker-3-tc1/source
[INFO] started tweaking crates.io crate nixpkgs-fmt 1.3.0
[INFO] finished tweaking crates.io crate nixpkgs-fmt 1.3.0
[INFO] tweaked toml for crates.io crate nixpkgs-fmt 1.3.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate nixpkgs-fmt 1.3.0 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate crates.io crate nixpkgs-fmt 1.3.0 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded unindent v0.1.7
[INFO] [stderr]   Downloaded countme v2.0.4
[INFO] [stderr]   Downloaded text-size v1.1.0
[INFO] [stderr]   Downloaded cbitset v0.2.0
[INFO] [stderr]   Downloaded rowan v0.12.6
[INFO] [stderr]   Downloaded smol_str v0.1.21
[INFO] [stderr]   Downloaded unicode-width v0.1.9
[INFO] [stderr]   Downloaded globset v0.4.8
[INFO] [stderr]   Downloaded ignore v0.4.18
[INFO] [stderr]   Downloaded serde_json v1.0.71
[INFO] [stderr]   Downloaded serde v1.0.130
[INFO] [stderr]   Downloaded rnix v0.10.2
[INFO] [stderr]   Downloaded bstr v0.2.17
[INFO] [stderr]   Downloaded libc v0.2.108
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 5ef431fc875b10eb05340a7e6b99ea0d03515e7fd200aa2ed9eb804355a756e0
[INFO] running `Command { std: "docker" "start" "-a" "5ef431fc875b10eb05340a7e6b99ea0d03515e7fd200aa2ed9eb804355a756e0", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "5ef431fc875b10eb05340a7e6b99ea0d03515e7fd200aa2ed9eb804355a756e0", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5ef431fc875b10eb05340a7e6b99ea0d03515e7fd200aa2ed9eb804355a756e0", kill_on_drop: false }`
[INFO] [stdout] 5ef431fc875b10eb05340a7e6b99ea0d03515e7fd200aa2ed9eb804355a756e0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 04063fa3a7c387499f4573dcc851fa4487e1936bb9a2866a05a631d59703b860
[INFO] running `Command { std: "docker" "start" "-a" "04063fa3a7c387499f4573dcc851fa4487e1936bb9a2866a05a631d59703b860", kill_on_drop: false }`
[INFO] [stderr]    Compiling autocfg v1.0.1
[INFO] [stderr]    Compiling memchr v2.4.1
[INFO] [stderr]    Compiling serde v1.0.130
[INFO] [stderr]    Compiling libc v0.2.108
[INFO] [stderr]    Compiling log v0.4.14
[INFO] [stderr]    Compiling ryu v1.0.5
[INFO] [stderr]    Compiling maybe-uninit v2.0.0
[INFO] [stderr]    Compiling crossbeam-utils v0.8.5
[INFO] [stderr]     Checking regex-syntax v0.6.26
[INFO] [stderr]     Checking hashbrown v0.9.1
[INFO] [stderr]    Compiling serde_json v1.0.71
[INFO] [stderr]     Checking once_cell v1.8.0
[INFO] [stderr]    Compiling memoffset v0.6.4
[INFO] [stderr]    Compiling num-traits v0.2.14
[INFO] [stderr]    Compiling crossbeam-utils v0.7.2
[INFO] [stderr]     Checking countme v2.0.4
[INFO] [stderr]     Checking unicode-width v0.1.9
[INFO] [stderr]     Checking textwrap v0.11.0
[INFO] [stderr]     Checking thread_local v1.1.3
[INFO] [stderr]     Checking atty v0.2.14
[INFO] [stderr]     Checking aho-corasick v0.7.18
[INFO] [stderr]     Checking bstr v0.2.17
[INFO] [stderr]     Checking itoa v0.4.8
[INFO] [stderr]     Checking ansi_term v0.11.0
[INFO] [stderr]     Checking unindent v0.1.7
[INFO] [stderr]     Checking crossbeam-channel v0.4.4
[INFO] [stderr]     Checking clap v2.33.3
[INFO] [stderr]     Checking cbitset v0.2.0
[INFO] [stderr]     Checking regex v1.5.6
[INFO] [stderr]     Checking globset v0.4.8
[INFO] [stderr]     Checking ignore v0.4.18
[INFO] [stderr]     Checking text-size v1.1.0
[INFO] [stderr]     Checking smol_str v0.1.21
[INFO] [stderr]     Checking rowan v0.12.6
[INFO] [stderr]     Checking rnix v0.10.2
[INFO] [stderr]     Checking nixpkgs-fmt v1.3.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]   --> src/pattern.rs:28:19
[INFO] [stdout]    |
[INFO] [stdout] 28 |     pred: Arc<dyn (Fn(&SyntaxElement) -> bool)>,
[INFO] [stdout]    |                   ^                          ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 28 -     pred: Arc<dyn (Fn(&SyntaxElement) -> bool)>,
[INFO] [stdout] 28 +     pred: Arc<dyn Fn(&SyntaxElement) -> bool>,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]   --> src/pattern.rs:28:19
[INFO] [stdout]    |
[INFO] [stdout] 28 |     pred: Arc<dyn (Fn(&SyntaxElement) -> bool)>,
[INFO] [stdout]    |                   ^                          ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 28 -     pred: Arc<dyn (Fn(&SyntaxElement) -> bool)>,
[INFO] [stdout] 28 +     pred: Arc<dyn Fn(&SyntaxElement) -> bool>,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/lib.rs:90:10
[INFO] [stdout]    |
[INFO] [stdout] 90 |     let (mut text, line_endings) = convert_to_unix_line_endings(text);
[INFO] [stdout]    |          ----^^^^
[INFO] [stdout]    |          |
[INFO] [stdout]    |          help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `indent_value` is never read
[INFO] [stdout]    --> src/dsl.rs:300:16
[INFO] [stdout]     |
[INFO] [stdout] 275 | pub(crate) struct IndentRule {
[INFO] [stdout]     |                   ---------- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 300 |     pub(crate) indent_value: IndentValue,
[INFO] [stdout]     |                ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `IndentRule` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/engine/indentation.rs:229:5
[INFO] [stdout]     |
[INFO] [stdout] 229 |     return;
[INFO] [stdout]     |     ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 228 -     }
[INFO] [stdout] 229 -     return;
[INFO] [stdout] 228 +     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/engine/indentation.rs:217:45
[INFO] [stdout]     |
[INFO] [stdout] 217 |     let anchor_indent = match indent_anchor(&syntax_element, model, anchor_set) {
[INFO] [stdout]     |                                             ^^^^^^^^^^^^^^^ help: change this to: `syntax_element`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/engine/indentation.rs:221:33
[INFO] [stdout]     |
[INFO] [stdout] 221 |     let block = model.block_for(&syntax_element, BlockPosition::Before);
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^ help: change this to: `syntax_element`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]   --> src/engine/spacing.rs:66:39
[INFO] [stdout]    |
[INFO] [stdout] 66 |             let parent_is_multiline = element.parent().map_or(false, |it| has_newline(&it));
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_map_or)]` on by default
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]    |
[INFO] [stdout] 66 -             let parent_is_multiline = element.parent().map_or(false, |it| has_newline(&it));
[INFO] [stdout] 66 +             let parent_is_multiline = element.parent().is_some_and(|it| has_newline(&it));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]   --> src/engine/spacing.rs:74:39
[INFO] [stdout]    |
[INFO] [stdout] 74 |             let parent_is_multiline = element.parent().map_or(false, |it| has_newline(&it));
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]    |
[INFO] [stdout] 74 -             let parent_is_multiline = element.parent().map_or(false, |it| has_newline(&it));
[INFO] [stdout] 74 +             let parent_is_multiline = element.parent().is_some_and(|it| has_newline(&it));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/engine/fixes.rs:176:26
[INFO] [stdout]     |
[INFO] [stdout] 176 |         let indent_len = s.find(|c| c != ' ').unwrap_or_else(|| s.len());
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
[INFO] [stdout] help: use `unwrap_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 176 -         let indent_len = s.find(|c| c != ' ').unwrap_or_else(|| s.len());
[INFO] [stdout] 176 +         let indent_len = s.find(|c| c != ' ').unwrap_or(s.len());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/rules.rs:164:5
[INFO] [stdout]     |
[INFO] [stdout] 164 | /     return if let Some(body) = prev.clone().and_then(With::cast).and_then(|w| w.body()) {
[INFO] [stdout] 165 | |         is_literal(body.kind())
[INFO] [stdout] 166 | |     } else {
[INFO] [stdout] 167 | |         prev.map(|it| is_literal(it.kind())) == Some(true)
[INFO] [stdout] 168 | |     };
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 164 ~     if let Some(body) = prev.clone().and_then(With::cast).and_then(|w| w.body()) {
[INFO] [stdout] 165 +         is_literal(body.kind())
[INFO] [stdout] 166 +     } else {
[INFO] [stdout] 167 +         prev.map(|it| is_literal(it.kind())) == Some(true)
[INFO] [stdout] 168 ~     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/rules.rs:187:33
[INFO] [stdout]     |
[INFO] [stdout] 187 |                     _ => return true && before_token_has_newline(&it.into()),
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `before_token_has_newline(&it.into())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/rules.rs:190:13
[INFO] [stdout]     |
[INFO] [stdout] 190 |             return false;
[INFO] [stdout]     |             ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 190 -             return false;
[INFO] [stdout] 190 +             false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/rules.rs:203:9
[INFO] [stdout]     |
[INFO] [stdout] 198 | /         let inline_attr = element
[INFO] [stdout] 199 | |             .parent()?
[INFO] [stdout] 200 | |             .descendants_with_tokens()
[INFO] [stdout] 201 | |             .find(|e| e.kind() == NODE_ATTR_SET)
[INFO] [stdout] 202 | |             .map(|t| before_token_has_newline(&t));
[INFO] [stdout]     | |___________________________________________________- unnecessary `let` binding
[INFO] [stdout] 203 |           inline_attr
[INFO] [stdout]     |           ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 198 ~         
[INFO] [stdout] 199 ~         element
[INFO] [stdout] 200 +             .parent()?
[INFO] [stdout] 201 +             .descendants_with_tokens()
[INFO] [stdout] 202 +             .find(|e| e.kind() == NODE_ATTR_SET)
[INFO] [stdout] 203 +             .map(|t| before_token_has_newline(&t))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/rules.rs:244:17
[INFO] [stdout]     |
[INFO] [stdout] 244 |                 return false;
[INFO] [stdout]     |                 ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 244 -                 return false;
[INFO] [stdout] 244 +                 false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/rules.rs:246:22
[INFO] [stdout]     |
[INFO] [stdout] 246 |             false => return has_newline(&parent),
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 246 -             false => return has_newline(&parent),
[INFO] [stdout] 246 +             false => has_newline(&parent),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/rules.rs:236:59
[INFO] [stdout]     |
[INFO] [stdout] 236 | ...                   return node.as_node().map(|t| has_newline(t)).unwrap_or(false);
[INFO] [stdout]     |                                                 ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `has_newline`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/rules.rs:268:5
[INFO] [stdout]     |
[INFO] [stdout] 260 | /     let is_last_argument = match element.parent() {
[INFO] [stdout] 261 | |         None => false,
[INFO] [stdout] 262 | |         Some(it) => match next_sibling(&it.into()) {
[INFO] [stdout] 263 | |             None => true,
[INFO] [stdout] 264 | |             _ => false,
[INFO] [stdout] 265 | |         },
[INFO] [stdout] 266 | |     };
[INFO] [stdout]     | |______- unnecessary `let` binding
[INFO] [stdout] 267 |
[INFO] [stdout] 268 |       is_last_argument
[INFO] [stdout]     |       ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 260 ~     
[INFO] [stdout] 261 |
[INFO] [stdout] 262 ~     match element.parent() {
[INFO] [stdout] 263 +         None => false,
[INFO] [stdout] 264 +         Some(it) => match next_sibling(&it.into()) {
[INFO] [stdout] 265 +             None => true,
[INFO] [stdout] 266 +             _ => false,
[INFO] [stdout] 267 +         },
[INFO] [stdout] 268 +     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/rules.rs:262:21
[INFO] [stdout]     |
[INFO] [stdout] 262 |           Some(it) => match next_sibling(&it.into()) {
[INFO] [stdout]     |  _____________________^
[INFO] [stdout] 263 | |             None => true,
[INFO] [stdout] 264 | |             _ => false,
[INFO] [stdout] 265 | |         },
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]     = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 262 -         Some(it) => match next_sibling(&it.into()) {
[INFO] [stdout] 263 -             None => true,
[INFO] [stdout] 264 -             _ => false,
[INFO] [stdout] 265 -         },
[INFO] [stdout] 262 +         Some(it) => matches!(next_sibling(&it.into()), None),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stdout]    --> src/rules.rs:262:21
[INFO] [stdout]     |
[INFO] [stdout] 262 |           Some(it) => match next_sibling(&it.into()) {
[INFO] [stdout]     |  _____________________^
[INFO] [stdout] 263 | |             None => true,
[INFO] [stdout] 264 | |             _ => false,
[INFO] [stdout] 265 | |         },
[INFO] [stdout]     | |_________^ help: try: `next_sibling(&it.into()).is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/rules.rs:284:5
[INFO] [stdout]     |
[INFO] [stdout] 284 |     return false;
[INFO] [stdout]     |     ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 284 -     return false;
[INFO] [stdout] 284 +     false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/rules.rs:293:31
[INFO] [stdout]     |
[INFO] [stdout] 293 |               .filter(|element| match element {
[INFO] [stdout]     |  _______________________________^
[INFO] [stdout] 294 | |                 NodeOrToken::Token(_) => true,
[INFO] [stdout] 295 | |                 _ => false,
[INFO] [stdout] 296 | |             })
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 293 -             .filter(|element| match element {
[INFO] [stdout] 294 -                 NodeOrToken::Token(_) => true,
[INFO] [stdout] 295 -                 _ => false,
[INFO] [stdout] 296 -             })
[INFO] [stdout] 293 +             .filter(|element| matches!(element, NodeOrToken::Token(_)))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `rnix::SyntaxElementChildren<rnix::NixLanguage>`
[INFO] [stdout]    --> src/rules.rs:321:22
[INFO] [stdout]     |
[INFO] [stdout] 321 |           let header = letin
[INFO] [stdout]     |  ______________________^
[INFO] [stdout] 322 | |             .node()
[INFO] [stdout] 323 | |             .children_with_tokens()
[INFO] [stdout] 324 | |             .into_iter()
[INFO] [stdout]     | |________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] help: consider removing `.into_iter()`
[INFO] [stdout]     |
[INFO] [stdout] 321 ~         let header = letin
[INFO] [stdout] 322 +             .node()
[INFO] [stdout] 323 +             .children_with_tokens()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `rnix::SyntaxElementChildren<rnix::NixLanguage>`
[INFO] [stdout]    --> src/rules.rs:357:49
[INFO] [stdout]     |
[INFO] [stdout] 357 |               let mut nodes: Vec<SyntaxElement> = x
[INFO] [stdout]     |  _________________________________________________^
[INFO] [stdout] 358 | |                 .children_with_tokens()
[INFO] [stdout] 359 | |                 .into_iter()
[INFO] [stdout]     | |____________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing `.into_iter()`
[INFO] [stdout]     |
[INFO] [stdout] 357 ~             let mut nodes: Vec<SyntaxElement> = x
[INFO] [stdout] 358 +                 .children_with_tokens()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/rules.rs:686:31
[INFO] [stdout]     |
[INFO] [stdout] 686 |               .filter(|element| match element {
[INFO] [stdout]     |  _______________________________^
[INFO] [stdout] 687 | |                 NodeOrToken::Token(_) => true,
[INFO] [stdout] 688 | |                 _ => false,
[INFO] [stdout] 689 | |             })
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 686 -             .filter(|element| match element {
[INFO] [stdout] 687 -                 NodeOrToken::Token(_) => true,
[INFO] [stdout] 688 -                 _ => false,
[INFO] [stdout] 689 -             })
[INFO] [stdout] 686 +             .filter(|element| matches!(element, NodeOrToken::Token(_)))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/rules.rs:729:24
[INFO] [stdout]     |
[INFO] [stdout] 729 |         let first_el = element.as_node()?.descendants().filter(|e| e.kind() != NODE_BIN_OP).nth(0);
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `element.as_node()?.descendants().filter(|e| e.kind() != NODE_BIN_OP).next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]     = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/rules.rs:928:21
[INFO] [stdout]     |
[INFO] [stdout] 928 |             assert!(res.len() > 0);
[INFO] [stdout]     |                     ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!res.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.as_ref().map(|it| it.as_str())` on an `Option` value
[INFO] [stdout]    --> src/rules.rs:933:24
[INFO] [stdout]     |
[INFO] [stdout] 933 |             let name = self.name.as_ref().map(|it| it.as_str()).unwrap_or("");
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `self.name.as_deref()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
[INFO] [stdout]     = note: `#[warn(clippy::option_as_ref_deref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref which would be done by auto-deref
[INFO] [stdout]   --> src/lib.rs:92:27
[INFO] [stdout]    |
[INFO] [stdout] 92 |     let ast = rnix::parse(&*text);
[INFO] [stdout]    |                           ^^^^^^ help: try: `&text`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[INFO] [stdout]    = note: `#[warn(clippy::explicit_auto_deref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref which would be done by auto-deref
[INFO] [stdout]    --> src/lib.rs:103:27
[INFO] [stdout]     |
[INFO] [stdout] 103 |     let ast = rnix::parse(&*text);
[INFO] [stdout]     |                           ^^^^^^ help: try: `&text`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/lib.rs:148:39
[INFO] [stdout]     |
[INFO] [stdout] 148 | fn convert_to_unix_line_endings(text: &str) -> (Cow<str>, LineEndings) {
[INFO] [stdout]     |                                       ^^^^      ^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                                       |
[INFO] [stdout]     |                                       the lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 148 | fn convert_to_unix_line_endings(text: &str) -> (Cow<'_, str>, LineEndings) {
[INFO] [stdout]     |                                                     +++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/lib.rs:90:10
[INFO] [stdout]    |
[INFO] [stdout] 90 |     let (mut text, line_endings) = convert_to_unix_line_endings(text);
[INFO] [stdout]    |          ----^^^^
[INFO] [stdout]    |          |
[INFO] [stdout]    |          help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `indent_value` is never read
[INFO] [stdout]    --> src/dsl.rs:300:16
[INFO] [stdout]     |
[INFO] [stdout] 275 | pub(crate) struct IndentRule {
[INFO] [stdout]     |                   ---------- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 300 |     pub(crate) indent_value: IndentValue,
[INFO] [stdout]     |                ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `IndentRule` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/engine/indentation.rs:229:5
[INFO] [stdout]     |
[INFO] [stdout] 229 |     return;
[INFO] [stdout]     |     ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 228 -     }
[INFO] [stdout] 229 -     return;
[INFO] [stdout] 228 +     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/engine/indentation.rs:217:45
[INFO] [stdout]     |
[INFO] [stdout] 217 |     let anchor_indent = match indent_anchor(&syntax_element, model, anchor_set) {
[INFO] [stdout]     |                                             ^^^^^^^^^^^^^^^ help: change this to: `syntax_element`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/engine/indentation.rs:221:33
[INFO] [stdout]     |
[INFO] [stdout] 221 |     let block = model.block_for(&syntax_element, BlockPosition::Before);
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^ help: change this to: `syntax_element`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]   --> src/engine/spacing.rs:66:39
[INFO] [stdout]    |
[INFO] [stdout] 66 |             let parent_is_multiline = element.parent().map_or(false, |it| has_newline(&it));
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_map_or)]` on by default
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]    |
[INFO] [stdout] 66 -             let parent_is_multiline = element.parent().map_or(false, |it| has_newline(&it));
[INFO] [stdout] 66 +             let parent_is_multiline = element.parent().is_some_and(|it| has_newline(&it));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]   --> src/engine/spacing.rs:74:39
[INFO] [stdout]    |
[INFO] [stdout] 74 |             let parent_is_multiline = element.parent().map_or(false, |it| has_newline(&it));
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]    |
[INFO] [stdout] 74 -             let parent_is_multiline = element.parent().map_or(false, |it| has_newline(&it));
[INFO] [stdout] 74 +             let parent_is_multiline = element.parent().is_some_and(|it| has_newline(&it));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/engine/fixes.rs:176:26
[INFO] [stdout]     |
[INFO] [stdout] 176 |         let indent_len = s.find(|c| c != ' ').unwrap_or_else(|| s.len());
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
[INFO] [stdout] help: use `unwrap_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 176 -         let indent_len = s.find(|c| c != ' ').unwrap_or_else(|| s.len());
[INFO] [stdout] 176 +         let indent_len = s.find(|c| c != ' ').unwrap_or(s.len());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/rules.rs:164:5
[INFO] [stdout]     |
[INFO] [stdout] 164 | /     return if let Some(body) = prev.clone().and_then(With::cast).and_then(|w| w.body()) {
[INFO] [stdout] 165 | |         is_literal(body.kind())
[INFO] [stdout] 166 | |     } else {
[INFO] [stdout] 167 | |         prev.map(|it| is_literal(it.kind())) == Some(true)
[INFO] [stdout] 168 | |     };
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 164 ~     if let Some(body) = prev.clone().and_then(With::cast).and_then(|w| w.body()) {
[INFO] [stdout] 165 +         is_literal(body.kind())
[INFO] [stdout] 166 +     } else {
[INFO] [stdout] 167 +         prev.map(|it| is_literal(it.kind())) == Some(true)
[INFO] [stdout] 168 ~     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/rules.rs:187:33
[INFO] [stdout]     |
[INFO] [stdout] 187 |                     _ => return true && before_token_has_newline(&it.into()),
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `before_token_has_newline(&it.into())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/rules.rs:190:13
[INFO] [stdout]     |
[INFO] [stdout] 190 |             return false;
[INFO] [stdout]     |             ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 190 -             return false;
[INFO] [stdout] 190 +             false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/rules.rs:203:9
[INFO] [stdout]     |
[INFO] [stdout] 198 | /         let inline_attr = element
[INFO] [stdout] 199 | |             .parent()?
[INFO] [stdout] 200 | |             .descendants_with_tokens()
[INFO] [stdout] 201 | |             .find(|e| e.kind() == NODE_ATTR_SET)
[INFO] [stdout] 202 | |             .map(|t| before_token_has_newline(&t));
[INFO] [stdout]     | |___________________________________________________- unnecessary `let` binding
[INFO] [stdout] 203 |           inline_attr
[INFO] [stdout]     |           ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 198 ~         
[INFO] [stdout] 199 ~         element
[INFO] [stdout] 200 +             .parent()?
[INFO] [stdout] 201 +             .descendants_with_tokens()
[INFO] [stdout] 202 +             .find(|e| e.kind() == NODE_ATTR_SET)
[INFO] [stdout] 203 +             .map(|t| before_token_has_newline(&t))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/rules.rs:244:17
[INFO] [stdout]     |
[INFO] [stdout] 244 |                 return false;
[INFO] [stdout]     |                 ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 244 -                 return false;
[INFO] [stdout] 244 +                 false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/rules.rs:246:22
[INFO] [stdout]     |
[INFO] [stdout] 246 |             false => return has_newline(&parent),
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 246 -             false => return has_newline(&parent),
[INFO] [stdout] 246 +             false => has_newline(&parent),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/rules.rs:236:59
[INFO] [stdout]     |
[INFO] [stdout] 236 | ...                   return node.as_node().map(|t| has_newline(t)).unwrap_or(false);
[INFO] [stdout]     |                                                 ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `has_newline`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/rules.rs:268:5
[INFO] [stdout]     |
[INFO] [stdout] 260 | /     let is_last_argument = match element.parent() {
[INFO] [stdout] 261 | |         None => false,
[INFO] [stdout] 262 | |         Some(it) => match next_sibling(&it.into()) {
[INFO] [stdout] 263 | |             None => true,
[INFO] [stdout] 264 | |             _ => false,
[INFO] [stdout] 265 | |         },
[INFO] [stdout] 266 | |     };
[INFO] [stdout]     | |______- unnecessary `let` binding
[INFO] [stdout] 267 |
[INFO] [stdout] 268 |       is_last_argument
[INFO] [stdout]     |       ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 260 ~     
[INFO] [stdout] 261 |
[INFO] [stdout] 262 ~     match element.parent() {
[INFO] [stdout] 263 +         None => false,
[INFO] [stdout] 264 +         Some(it) => match next_sibling(&it.into()) {
[INFO] [stdout] 265 +             None => true,
[INFO] [stdout] 266 +             _ => false,
[INFO] [stdout] 267 +         },
[INFO] [stdout] 268 +     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/rules.rs:262:21
[INFO] [stdout]     |
[INFO] [stdout] 262 |           Some(it) => match next_sibling(&it.into()) {
[INFO] [stdout]     |  _____________________^
[INFO] [stdout] 263 | |             None => true,
[INFO] [stdout] 264 | |             _ => false,
[INFO] [stdout] 265 | |         },
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]     = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 262 -         Some(it) => match next_sibling(&it.into()) {
[INFO] [stdout] 263 -             None => true,
[INFO] [stdout] 264 -             _ => false,
[INFO] [stdout] 265 -         },
[INFO] [stdout] 262 +         Some(it) => matches!(next_sibling(&it.into()), None),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stdout]    --> src/rules.rs:262:21
[INFO] [stdout]     |
[INFO] [stdout] 262 |           Some(it) => match next_sibling(&it.into()) {
[INFO] [stdout]     |  _____________________^
[INFO] [stdout] 263 | |             None => true,
[INFO] [stdout] 264 | |             _ => false,
[INFO] [stdout] 265 | |         },
[INFO] [stdout]     | |_________^ help: try: `next_sibling(&it.into()).is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/rules.rs:284:5
[INFO] [stdout]     |
[INFO] [stdout] 284 |     return false;
[INFO] [stdout]     |     ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 284 -     return false;
[INFO] [stdout] 284 +     false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/rules.rs:293:31
[INFO] [stdout]     |
[INFO] [stdout] 293 |               .filter(|element| match element {
[INFO] [stdout]     |  _______________________________^
[INFO] [stdout] 294 | |                 NodeOrToken::Token(_) => true,
[INFO] [stdout] 295 | |                 _ => false,
[INFO] [stdout] 296 | |             })
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 293 -             .filter(|element| match element {
[INFO] [stdout] 294 -                 NodeOrToken::Token(_) => true,
[INFO] [stdout] 295 -                 _ => false,
[INFO] [stdout] 296 -             })
[INFO] [stdout] 293 +             .filter(|element| matches!(element, NodeOrToken::Token(_)))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `rnix::SyntaxElementChildren<rnix::NixLanguage>`
[INFO] [stdout]    --> src/rules.rs:321:22
[INFO] [stdout]     |
[INFO] [stdout] 321 |           let header = letin
[INFO] [stdout]     |  ______________________^
[INFO] [stdout] 322 | |             .node()
[INFO] [stdout] 323 | |             .children_with_tokens()
[INFO] [stdout] 324 | |             .into_iter()
[INFO] [stdout]     | |________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] help: consider removing `.into_iter()`
[INFO] [stdout]     |
[INFO] [stdout] 321 ~         let header = letin
[INFO] [stdout] 322 +             .node()
[INFO] [stdout] 323 +             .children_with_tokens()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `rnix::SyntaxElementChildren<rnix::NixLanguage>`
[INFO] [stdout]    --> src/rules.rs:357:49
[INFO] [stdout]     |
[INFO] [stdout] 357 |               let mut nodes: Vec<SyntaxElement> = x
[INFO] [stdout]     |  _________________________________________________^
[INFO] [stdout] 358 | |                 .children_with_tokens()
[INFO] [stdout] 359 | |                 .into_iter()
[INFO] [stdout]     | |____________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing `.into_iter()`
[INFO] [stdout]     |
[INFO] [stdout] 357 ~             let mut nodes: Vec<SyntaxElement> = x
[INFO] [stdout] 358 +                 .children_with_tokens()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/rules.rs:686:31
[INFO] [stdout]     |
[INFO] [stdout] 686 |               .filter(|element| match element {
[INFO] [stdout]     |  _______________________________^
[INFO] [stdout] 687 | |                 NodeOrToken::Token(_) => true,
[INFO] [stdout] 688 | |                 _ => false,
[INFO] [stdout] 689 | |             })
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 686 -             .filter(|element| match element {
[INFO] [stdout] 687 -                 NodeOrToken::Token(_) => true,
[INFO] [stdout] 688 -                 _ => false,
[INFO] [stdout] 689 -             })
[INFO] [stdout] 686 +             .filter(|element| matches!(element, NodeOrToken::Token(_)))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/rules.rs:729:24
[INFO] [stdout]     |
[INFO] [stdout] 729 |         let first_el = element.as_node()?.descendants().filter(|e| e.kind() != NODE_BIN_OP).nth(0);
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `element.as_node()?.descendants().filter(|e| e.kind() != NODE_BIN_OP).next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]     = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref which would be done by auto-deref
[INFO] [stdout]   --> src/lib.rs:92:27
[INFO] [stdout]    |
[INFO] [stdout] 92 |     let ast = rnix::parse(&*text);
[INFO] [stdout]    |                           ^^^^^^ help: try: `&text`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[INFO] [stdout]    = note: `#[warn(clippy::explicit_auto_deref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref which would be done by auto-deref
[INFO] [stdout]    --> src/lib.rs:103:27
[INFO] [stdout]     |
[INFO] [stdout] 103 |     let ast = rnix::parse(&*text);
[INFO] [stdout]     |                           ^^^^^^ help: try: `&text`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/lib.rs:148:39
[INFO] [stdout]     |
[INFO] [stdout] 148 | fn convert_to_unix_line_endings(text: &str) -> (Cow<str>, LineEndings) {
[INFO] [stdout]     |                                       ^^^^      ^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                                       |
[INFO] [stdout]     |                                       the lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 148 | fn convert_to_unix_line_endings(text: &str) -> (Cow<'_, str>, LineEndings) {
[INFO] [stdout]     |                                                     +++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: spawned process is never `wait()`ed on
[INFO] [stdout]   --> tests/integration_tests.rs:20:21
[INFO] [stdout]    |
[INFO] [stdout] 20 |           let child = Command::new(env!("CARGO_BIN_EXE_nixpkgs-fmt"))
[INFO] [stdout]    |  _____________________^
[INFO] [stdout] 21 | |             .args(args)
[INFO] [stdout] 22 | |             .stdin(Stdio::piped())
[INFO] [stdout] 23 | |             .stdout(Stdio::piped())
[INFO] [stdout] 24 | |             .spawn()
[INFO] [stdout] 25 | |             .unwrap();
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: consider calling `.wait()`
[INFO] [stdout]    = note: not doing so might leave behind zombie processes
[INFO] [stdout]    = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes
[INFO] [stdout]    = note: `#[warn(clippy::zombie_processes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/main.rs:202:13
[INFO] [stdout]     |
[INFO] [stdout] 202 | /             match (output_format, error_buf.is_empty()) {
[INFO] [stdout] 203 | |                 (OutputFormat::Rnix, false) => {
[INFO] [stdout] 204 | |                     return Err(error_buf.into());
[INFO] [stdout] ...   |
[INFO] [stdout] 207 | |             };
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 202 ~             if let (OutputFormat::Rnix, false) = (output_format, error_buf.is_empty()) {
[INFO] [stdout] 203 +                 return Err(error_buf.into());
[INFO] [stdout] 204 ~             };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/main.rs:259:17
[INFO] [stdout]     |
[INFO] [stdout] 259 | /                 match reformat_dir_entry(entry, write_changes, &s) {
[INFO] [stdout] 260 | |                     Err(err) => eprintln!("error: {}", err),
[INFO] [stdout] 261 | |                     Ok(()) => {}
[INFO] [stdout] 262 | |                 }
[INFO] [stdout]     | |_________________^ help: try: `if let Err(err) = reformat_dir_entry(entry, write_changes, &s) { eprintln!("error: {}", err) }`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/main.rs:202:13
[INFO] [stdout]     |
[INFO] [stdout] 202 | /             match (output_format, error_buf.is_empty()) {
[INFO] [stdout] 203 | |                 (OutputFormat::Rnix, false) => {
[INFO] [stdout] 204 | |                     return Err(error_buf.into());
[INFO] [stdout] ...   |
[INFO] [stdout] 207 | |             };
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 202 ~             if let (OutputFormat::Rnix, false) = (output_format, error_buf.is_empty()) {
[INFO] [stdout] 203 +                 return Err(error_buf.into());
[INFO] [stdout] 204 ~             };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/main.rs:259:17
[INFO] [stdout]     |
[INFO] [stdout] 259 | /                 match reformat_dir_entry(entry, write_changes, &s) {
[INFO] [stdout] 260 | |                     Err(err) => eprintln!("error: {}", err),
[INFO] [stdout] 261 | |                     Ok(()) => {}
[INFO] [stdout] 262 | |                 }
[INFO] [stdout]     | |_________________^ help: try: `if let Err(err) = reformat_dir_entry(entry, write_changes, &s) { eprintln!("error: {}", err) }`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.86s
[INFO] running `Command { std: "docker" "inspect" "04063fa3a7c387499f4573dcc851fa4487e1936bb9a2866a05a631d59703b860", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "04063fa3a7c387499f4573dcc851fa4487e1936bb9a2866a05a631d59703b860", kill_on_drop: false }`
[INFO] [stdout] 04063fa3a7c387499f4573dcc851fa4487e1936bb9a2866a05a631d59703b860