[INFO] fetching crate nitro_pkg 0.29.0... [INFO] linting nitro_pkg-0.29.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate nitro_pkg 0.29.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate nitro_pkg 0.29.0 [INFO] finished tweaking crates.io crate nitro_pkg 0.29.0 [INFO] tweaked toml for crates.io crate nitro_pkg 0.29.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate nitro_pkg 0.29.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate nitro_pkg 0.29.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded nitro_parse v0.29.0 [INFO] [stderr] Downloaded nitro_shared v0.29.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 974069228ad5a3c17811bc5d2cb70c056d16f2fc148d07c3c4d44952306e46f9 [INFO] running `Command { std: "docker" "start" "-a" "974069228ad5a3c17811bc5d2cb70c056d16f2fc148d07c3c4d44952306e46f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "974069228ad5a3c17811bc5d2cb70c056d16f2fc148d07c3c4d44952306e46f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "974069228ad5a3c17811bc5d2cb70c056d16f2fc148d07c3c4d44952306e46f9", kill_on_drop: false }` [INFO] [stdout] 974069228ad5a3c17811bc5d2cb70c056d16f2fc148d07c3c4d44952306e46f9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b190e24a8bfa289f01231eedf1a9b1405737c1c3724715ccde84008f47d1ddc [INFO] running `Command { std: "docker" "start" "-a" "2b190e24a8bfa289f01231eedf1a9b1405737c1c3724715ccde84008f47d1ddc", kill_on_drop: false }` [INFO] [stderr] Checking lexical-util v1.0.7 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Checking sys-locale v0.3.2 [INFO] [stderr] Checking cfg-match v0.2.1 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Checking lexical-write-integer v1.0.6 [INFO] [stderr] Checking lexical-parse-integer v1.0.6 [INFO] [stderr] Checking lexical-parse-float v1.0.6 [INFO] [stderr] Checking lexical-write-float v1.0.6 [INFO] [stderr] Checking lexical-core v1.0.6 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking ref-cast v1.0.25 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking halfbrown v0.2.5 [INFO] [stderr] Checking nitro_shared v0.29.0 [INFO] [stderr] Checking value-trait v0.8.1 [INFO] [stderr] Checking simd-json v0.13.11 [INFO] [stderr] Checking nitro_parse v0.29.0 [INFO] [stderr] Checking nitro_pkg v0.29.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/declarative.rs:274:8 [INFO] [stdout] | [INFO] [stdout] 274 | if !addon_version.version.as_ref().is_some_and(|x| x == version) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `addon_version.version.as_ref().is_none_or(|x| x != version)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/declarative.rs:289:3 [INFO] [stdout] | [INFO] [stdout] 289 | return version; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 - return version; [INFO] [stdout] 289 + version [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/resolve.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | / if !resolver.is_required(package) { [INFO] [stdout] 157 | | let package = evaluator.make_req_displayable(package, common_input).await; [INFO] [stdout] 158 | | let source = package.source.get_source(); [INFO] [stdout] 159 | | let source = if let Some(source) = source { [INFO] [stdout] ... | [INFO] [stdout] 167 | | )); [INFO] [stdout] 168 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 155 ~ ConstraintKind::Extend(package) [INFO] [stdout] 156 ~ if !resolver.is_required(package) => { [INFO] [stdout] 157 | let package = evaluator.make_req_displayable(package, common_input).await; [INFO] [stdout] ... [INFO] [stdout] 167 | )); [INFO] [stdout] 168 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/declarative.rs:274:8 [INFO] [stdout] | [INFO] [stdout] 274 | if !addon_version.version.as_ref().is_some_and(|x| x == version) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `addon_version.version.as_ref().is_none_or(|x| x != version)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/declarative.rs:289:3 [INFO] [stdout] | [INFO] [stdout] 289 | return version; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 - return version; [INFO] [stdout] 289 + version [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/resolve.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | / if !resolver.is_required(package) { [INFO] [stdout] 157 | | let package = evaluator.make_req_displayable(package, common_input).await; [INFO] [stdout] 158 | | let source = package.source.get_source(); [INFO] [stdout] 159 | | let source = if let Some(source) = source { [INFO] [stdout] ... | [INFO] [stdout] 167 | | )); [INFO] [stdout] 168 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 155 ~ ConstraintKind::Extend(package) [INFO] [stdout] 156 ~ if !resolver.is_required(package) => { [INFO] [stdout] 157 | let package = evaluator.make_req_displayable(package, common_input).await; [INFO] [stdout] ... [INFO] [stdout] 167 | )); [INFO] [stdout] 168 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.82s [INFO] running `Command { std: "docker" "inspect" "2b190e24a8bfa289f01231eedf1a9b1405737c1c3724715ccde84008f47d1ddc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b190e24a8bfa289f01231eedf1a9b1405737c1c3724715ccde84008f47d1ddc", kill_on_drop: false }` [INFO] [stdout] 2b190e24a8bfa289f01231eedf1a9b1405737c1c3724715ccde84008f47d1ddc