[INFO] fetching crate nil-zonefile 0.3.0... [INFO] linting nil-zonefile-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate nil-zonefile 0.3.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate nil-zonefile 0.3.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate nil-zonefile 0.3.0 [INFO] tweaked toml for crates.io crate nil-zonefile 0.3.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate nil-zonefile 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 71 packages to latest compatible versions [INFO] [stderr] Adding brotli v7.0.0 (available: v8.0.2) [INFO] [stderr] Adding env_logger v0.10.2 (available: v0.11.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded nil-slip44 v0.3.8 [INFO] [stderr] Downloaded brotli-decompressor v4.0.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 25022f201bf5854c91ec211710c3a329c93344c6e27905be412d5b906f2c0ac3 [INFO] running `Command { std: "docker" "start" "-a" "25022f201bf5854c91ec211710c3a329c93344c6e27905be412d5b906f2c0ac3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "25022f201bf5854c91ec211710c3a329c93344c6e27905be412d5b906f2c0ac3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25022f201bf5854c91ec211710c3a329c93344c6e27905be412d5b906f2c0ac3", kill_on_drop: false }` [INFO] [stdout] 25022f201bf5854c91ec211710c3a329c93344c6e27905be412d5b906f2c0ac3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e45b5876db4ea7d3c6acc7a2c156e2ca104762b389bb7e9324a7e5b7abb971c [INFO] running `Command { std: "docker" "start" "-a" "5e45b5876db4ea7d3c6acc7a2c156e2ca104762b389bb7e9324a7e5b7abb971c", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling wasm-bindgen v0.2.114 [INFO] [stderr] Compiling zerocopy-derive v0.8.42 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking brotli-decompressor v4.0.3 [INFO] [stderr] Compiling nil-zonefile v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> build.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 22 | if !Command::new("brew").arg("--version").output().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Command::new("brew").arg("--version").output().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.64 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Checking brotli v7.0.0 [INFO] [stderr] Checking wasm-bindgen-test-shared v0.2.114 [INFO] [stderr] Checking nil-slip44 v0.3.8 [INFO] [stderr] Checking js-sys v0.3.91 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use ciborium; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/wallet.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use log; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/id.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / impl Default for Id { [INFO] [stdout] 24 | | fn default() -> Self { [INFO] [stdout] 25 | | Self { name: None, pfp: None, site: None, loc: None, disp: None, desc: None, srvs: None } [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Default)] [INFO] [stdout] 7 | pub struct Id { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/wallet.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | / pub fn from_str(s: &str) -> Option { [INFO] [stdout] 103 | | // Try parsing as SLIP44 symbol first for on-chain addresses [INFO] [stdout] 104 | | if let Ok(symbol) = s.parse::() { [INFO] [stdout] 105 | | return Some(WalletType::OnChain(Coin::from(symbol))); [INFO] [stdout] ... | [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `wallet::WalletType` [INFO] [stdout] --> src/wallet.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | / pub fn to_string(&self) -> String { [INFO] [stdout] 116 | | match self { [INFO] [stdout] 117 | | WalletType::OnChain(coin) => coin.to_string(), [INFO] [stdout] 118 | | WalletType::Lightning => "lightning".to_string(), [INFO] [stdout] 119 | | } [INFO] [stdout] 120 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `wallet::WalletType` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/dns.rs:122:1 [INFO] [stdout] | [INFO] [stdout] 122 | / impl Default for Dns { [INFO] [stdout] 123 | | fn default() -> Self { [INFO] [stdout] 124 | | Self { zone: None } [INFO] [stdout] 125 | | } [INFO] [stdout] 126 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Default)] [INFO] [stdout] 6 | pub struct Dns { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/lib.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | / pub fn from_str(zonefile_str: &str) -> Result { [INFO] [stdout] 93 | | debug!("Attempting to parse zonefile from string"); [INFO] [stdout] ... | [INFO] [stdout] 132 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/lib.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | / pub fn new_v0( [INFO] [stdout] 154 | | owner: String, [INFO] [stdout] 155 | | general: String, [INFO] [stdout] 156 | | twitter: String, [INFO] [stdout] ... | [INFO] [stdout] 161 | | subdomains: HashMap, [INFO] [stdout] 162 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking wasm-bindgen-futures v0.4.64 [INFO] [stderr] Checking wasm-bindgen-test v0.3.64 [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use ciborium; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/resource.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use ciborium; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/wallet.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use log; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/dns.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/id.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / impl Default for Id { [INFO] [stdout] 24 | | fn default() -> Self { [INFO] [stdout] 25 | | Self { name: None, pfp: None, site: None, loc: None, disp: None, desc: None, srvs: None } [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Default)] [INFO] [stdout] 7 | pub struct Id { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/wallet.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | / pub fn from_str(s: &str) -> Option { [INFO] [stdout] 103 | | // Try parsing as SLIP44 symbol first for on-chain addresses [INFO] [stdout] 104 | | if let Ok(symbol) = s.parse::() { [INFO] [stdout] 105 | | return Some(WalletType::OnChain(Coin::from(symbol))); [INFO] [stdout] ... | [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `wallet::WalletType` [INFO] [stdout] --> src/wallet.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | / pub fn to_string(&self) -> String { [INFO] [stdout] 116 | | match self { [INFO] [stdout] 117 | | WalletType::OnChain(coin) => coin.to_string(), [INFO] [stdout] 118 | | WalletType::Lightning => "lightning".to_string(), [INFO] [stdout] 119 | | } [INFO] [stdout] 120 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `wallet::WalletType` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/dns.rs:122:1 [INFO] [stdout] | [INFO] [stdout] 122 | / impl Default for Dns { [INFO] [stdout] 123 | | fn default() -> Self { [INFO] [stdout] 124 | | Self { zone: None } [INFO] [stdout] 125 | | } [INFO] [stdout] 126 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Default)] [INFO] [stdout] 6 | pub struct Dns { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/lib.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | / pub fn from_str(zonefile_str: &str) -> Result { [INFO] [stdout] 93 | | debug!("Attempting to parse zonefile from string"); [INFO] [stdout] ... | [INFO] [stdout] 132 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/lib.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | / pub fn new_v0( [INFO] [stdout] 154 | | owner: String, [INFO] [stdout] 155 | | general: String, [INFO] [stdout] 156 | | twitter: String, [INFO] [stdout] ... | [INFO] [stdout] 161 | | subdomains: HashMap, [INFO] [stdout] 162 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.34s [INFO] running `Command { std: "docker" "inspect" "5e45b5876db4ea7d3c6acc7a2c156e2ca104762b389bb7e9324a7e5b7abb971c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e45b5876db4ea7d3c6acc7a2c156e2ca104762b389bb7e9324a7e5b7abb971c", kill_on_drop: false }` [INFO] [stdout] 5e45b5876db4ea7d3c6acc7a2c156e2ca104762b389bb7e9324a7e5b7abb971c