[INFO] fetching crate nihdb 0.3.0... [INFO] linting nihdb-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate nihdb 0.3.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate nihdb 0.3.0 [INFO] finished tweaking crates.io crate nihdb 0.3.0 [INFO] tweaked toml for crates.io crate nihdb 0.3.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate nihdb 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding crc v1.8.1 (available: v3.4.0) [INFO] [stderr] Adding owning_ref v0.3.3 (available: v0.4.1) [INFO] [stderr] Adding rand v0.4.6 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded owning_ref v0.3.3 [INFO] [stderr] Downloaded crc v1.8.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 04acae3e203f88c7fc8752a15725c27dde9f68108813599e42cf5acfc57b2d58 [INFO] running `Command { std: "docker" "start" "-a" "04acae3e203f88c7fc8752a15725c27dde9f68108813599e42cf5acfc57b2d58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "04acae3e203f88c7fc8752a15725c27dde9f68108813599e42cf5acfc57b2d58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04acae3e203f88c7fc8752a15725c27dde9f68108813599e42cf5acfc57b2d58", kill_on_drop: false }` [INFO] [stdout] 04acae3e203f88c7fc8752a15725c27dde9f68108813599e42cf5acfc57b2d58 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ee93dd74093f45150d91fda3f8ae2039bb0cfbba4db65df788b94b93dbe22963 [INFO] running `Command { std: "docker" "start" "-a" "ee93dd74093f45150d91fda3f8ae2039bb0cfbba4db65df788b94b93dbe22963", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling build_const v0.2.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Checking nihdb v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:256:37 [INFO] [stdout] | [INFO] [stdout] 256 | return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `keys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:256:62 [INFO] [stdout] | [INFO] [stdout] 256 | return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_end_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:396:17 [INFO] [stdout] | [INFO] [stdout] 396 | keys_iter: keys_iter, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:397:17 [INFO] [stdout] | [INFO] [stdout] 397 | values_buf: values_buf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `values_buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 399 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:403:17 [INFO] [stdout] | [INFO] [stdout] 403 | keys_iter: keys_iter, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:407:17 [INFO] [stdout] | [INFO] [stdout] 407 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/iter.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | iters: iters, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `iters` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/iter.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | iters_front: iters_front, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iters_front` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:256:37 [INFO] [stdout] | [INFO] [stdout] 256 | return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `keys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:256:62 [INFO] [stdout] | [INFO] [stdout] 256 | return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_end_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/iter.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/iter.rs:98:77 [INFO] [stdout] | [INFO] [stdout] 98 | return Ok(ConcatIterator{current: Some((key, current)), next_gen: next_gen}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `next_gen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/iter.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 104 | next_gen: next_gen, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `next_gen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/memstore.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/memstore.rs:83:17 [INFO] [stdout] | [INFO] [stdout] 83 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/toc.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | level: level, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/toc.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | keys_offset: keys_offset, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/toc.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | file_size: file_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/toc.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | smallest_key: smallest_key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `smallest_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/toc.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | biggest_key: biggest_key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `biggest_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | threshold: threshold, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | directory: directory, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | toc_file: toc_file, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `toc_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | toc: toc, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `toc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:229:72 [INFO] [stdout] | [INFO] [stdout] 229 | = table_infos.into_iter().map(|x: TableInfo| TableInfo{level: level, .. x}).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:396:17 [INFO] [stdout] | [INFO] [stdout] 396 | keys_iter: keys_iter, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 232 | additions: additions, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:397:17 [INFO] [stdout] | [INFO] [stdout] 397 | values_buf: values_buf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `values_buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:285:21 [INFO] [stdout] | [INFO] [stdout] 285 | keys_offset: keys_offset, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 399 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:286:21 [INFO] [stdout] | [INFO] [stdout] 286 | file_size: file_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:403:17 [INFO] [stdout] | [INFO] [stdout] 403 | keys_iter: keys_iter, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:296:17 [INFO] [stdout] | [INFO] [stdout] 296 | additions: additions, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/disk.rs:407:17 [INFO] [stdout] | [INFO] [stdout] 407 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:297:17 [INFO] [stdout] | [INFO] [stdout] 297 | removals: removals, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `removals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:365:13 [INFO] [stdout] | [INFO] [stdout] 365 | level: level, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:366:13 [INFO] [stdout] | [INFO] [stdout] 366 | keys_offset: keys_offset, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:367:13 [INFO] [stdout] | [INFO] [stdout] 367 | file_size: file_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/iter.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | iters: iters, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `iters` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/iter.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | iters_front: iters_front, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iters_front` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:502:13 [INFO] [stdout] | [INFO] [stdout] 502 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/iter.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/iter.rs:98:77 [INFO] [stdout] | [INFO] [stdout] 98 | return Ok(ConcatIterator{current: Some((key, current)), next_gen: next_gen}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `next_gen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/iter.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 104 | next_gen: next_gen, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `next_gen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/memstore.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/memstore.rs:83:17 [INFO] [stdout] | [INFO] [stdout] 83 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/toc.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | level: level, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/toc.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | keys_offset: keys_offset, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/toc.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | file_size: file_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/toc.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | smallest_key: smallest_key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `smallest_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/toc.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | biggest_key: biggest_key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `biggest_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | threshold: threshold, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | directory: directory, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | toc_file: toc_file, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `toc_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | toc: toc, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `toc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:229:72 [INFO] [stdout] | [INFO] [stdout] 229 | = table_infos.into_iter().map(|x: TableInfo| TableInfo{level: level, .. x}).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 232 | additions: additions, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:285:21 [INFO] [stdout] | [INFO] [stdout] 285 | keys_offset: keys_offset, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:286:21 [INFO] [stdout] | [INFO] [stdout] 286 | file_size: file_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:296:17 [INFO] [stdout] | [INFO] [stdout] 296 | additions: additions, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:297:17 [INFO] [stdout] | [INFO] [stdout] 297 | removals: removals, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `removals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:365:13 [INFO] [stdout] | [INFO] [stdout] 365 | level: level, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:366:13 [INFO] [stdout] | [INFO] [stdout] 366 | keys_offset: keys_offset, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keys_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:367:13 [INFO] [stdout] | [INFO] [stdout] 367 | file_size: file_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:502:13 [INFO] [stdout] | [INFO] [stdout] 502 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/iter.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | iters: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | iters: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/iter.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | next_gen: Box Result>> + 'a>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 89 | next_gen: Box Result>> + 'a>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/iter.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | iters: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | iters: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/iter.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | next_gen: Box Result>> + 'a>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 89 | next_gen: Box Result>> + 'a>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/error.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 48 | fn cause(&self) -> Option<&std::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 48 | fn cause(&self) -> Option<&dyn std::error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/error.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 48 | fn cause(&self) -> Option<&std::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 48 | fn cause(&self) -> Option<&dyn std::error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/iter.rs:40:36 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn make(mut iters: Vec>, direction: Direction) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 40 | pub fn make(mut iters: Vec>, direction: Direction) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/iter.rs:93:35 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn make(mut next_gen: Box Result>> + 'a> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 93 | pub fn make(mut next_gen: Box Result>> + 'a> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/disk.rs:161:42 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn finish(mut self, writer: &mut Write) -> Result<(u64, u64, Buf, Buf)> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 161 | pub fn finish(mut self, writer: &mut dyn Write) -> Result<(u64, u64, Buf, Buf)> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/iter.rs:40:36 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn make(mut iters: Vec>, direction: Direction) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 40 | pub fn make(mut iters: Vec>, direction: Direction) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/iter.rs:93:35 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn make(mut next_gen: Box Result>> + 'a> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 93 | pub fn make(mut next_gen: Box Result>> + 'a> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:441:36 [INFO] [stdout] | [INFO] [stdout] 441 | &self, iters: &mut Vec>, table_id: TableId, interval: &Interval, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 441 | &self, iters: &mut Vec>, table_id: TableId, interval: &Interval, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/disk.rs:161:42 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn finish(mut self, writer: &mut Write) -> Result<(u64, u64, Buf, Buf)> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 161 | pub fn finish(mut self, writer: &mut dyn Write) -> Result<(u64, u64, Buf, Buf)> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:441:36 [INFO] [stdout] | [INFO] [stdout] 441 | &self, iters: &mut Vec>, table_id: TableId, interval: &Interval, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 441 | &self, iters: &mut Vec>, table_id: TableId, interval: &Interval, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/error.rs:20:46 [INFO] [stdout] | [INFO] [stdout] 20 | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | &Error::IoError(ref e) => (e as &dyn std::error::Error).description(), [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/error.rs:20:46 [INFO] [stdout] | [INFO] [stdout] 20 | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | &Error::IoError(ref e) => (e as &dyn std::error::Error).description(), [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:20:65 [INFO] [stdout] | [INFO] [stdout] 20 | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:20:65 [INFO] [stdout] | [INFO] [stdout] 20 | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:238:36 [INFO] [stdout] | [INFO] [stdout] 238 | let mut iters: Vec> = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 238 | let mut iters: Vec> = Vec::new(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:238:36 [INFO] [stdout] | [INFO] [stdout] 238 | let mut iters: Vec> = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 238 | let mut iters: Vec> = Vec::new(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:457:32 [INFO] [stdout] | [INFO] [stdout] 457 | let mut iters: Vec> = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 457 | let mut iters: Vec> = Vec::new(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:457:32 [INFO] [stdout] | [INFO] [stdout] 457 | let mut iters: Vec> = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 457 | let mut iters: Vec> = Vec::new(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/disk.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | / match m { [INFO] [stdout] 57 | | &Mutation::Set(ref s) => { [INFO] [stdout] 58 | | v.push(0); [INFO] [stdout] 59 | | encode_str(v, s); [INFO] [stdout] ... | [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 56 ~ match *m { [INFO] [stdout] 57 ~ Mutation::Set(ref s) => { [INFO] [stdout] 58 | v.push(0); [INFO] [stdout] 59 | encode_str(v, s); [INFO] [stdout] 60 | }, [INFO] [stdout] 61 ~ Mutation::Delete => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/disk.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | &Mutation::Set(ref s) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 57 - &Mutation::Set(ref s) => { [INFO] [stdout] 57 + Mutation::Set(s) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return Some(Mutation::Set(s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Some(Mutation::Set(s)); [INFO] [stdout] 72 + Some(Mutation::Set(s)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return Some(Mutation::Delete); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return Some(Mutation::Delete); [INFO] [stdout] 74 + Some(Mutation::Delete) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return None; [INFO] [stdout] 76 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/disk.rs:71:33 [INFO] [stdout] | [INFO] [stdout] 71 | let s: Buf = decode_str(&v, pos)?; [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | / return 1 // prev key entry len [INFO] [stdout] 94 | | + 1 // value len [INFO] [stdout] 95 | | + 3 // value offset [INFO] [stdout] 96 | | + 1 // key len [INFO] [stdout] 97 | | + key.len(); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 ~ 1 // prev key entry len [INFO] [stdout] 94 + + 1 // value len [INFO] [stdout] 95 + + 3 // value offset [INFO] [stdout] 96 + + 1 // key len [INFO] [stdout] 97 ~ + key.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | / return 1 // Set/delete byte [INFO] [stdout] 101 | | + 1 // val len [INFO] [stdout] 102 | | + val.len(); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 ~ 1 // Set/delete byte [INFO] [stdout] 101 + + 1 // val len [INFO] [stdout] 102 ~ + val.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | / return match val { [INFO] [stdout] 106 | | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] 107 | | &Mutation::Delete => 1, [INFO] [stdout] 108 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 ~ match val { [INFO] [stdout] 106 + &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] 107 + &Mutation::Delete => 1, [INFO] [stdout] 108 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/disk.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 105 | return match val { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] 107 | | &Mutation::Delete => 1, [INFO] [stdout] 108 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 105 ~ return match *val { [INFO] [stdout] 106 ~ Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] 107 ~ Mutation::Delete => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/disk.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 106 - &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] 106 + Mutation::Set(x) => set_value_usage(&x), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/disk.rs:106:50 [INFO] [stdout] | [INFO] [stdout] 106 | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | / return TableBuilder{ [INFO] [stdout] 125 | | values_buf: Vec::new(), [INFO] [stdout] 126 | | keys_buf: Vec::new(), [INFO] [stdout] 127 | | first_key: None, [INFO] [stdout] 128 | | last_key: None, [INFO] [stdout] 129 | | last_entry_len: 0, [INFO] [stdout] 130 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 ~ TableBuilder{ [INFO] [stdout] 125 + values_buf: Vec::new(), [INFO] [stdout] 126 + keys_buf: Vec::new(), [INFO] [stdout] 127 + first_key: None, [INFO] [stdout] 128 + last_key: None, [INFO] [stdout] 129 + last_entry_len: 0, [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | return self.first_key.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return self.first_key.is_none(); [INFO] [stdout] 135 + self.first_key.is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | return self.values_buf.len() + self.keys_buf.len() + TAB_BACK_PADDING; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return self.values_buf.len() + self.keys_buf.len() + TAB_BACK_PADDING; [INFO] [stdout] 139 + self.values_buf.len() + self.keys_buf.len() + TAB_BACK_PADDING [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/disk.rs:162:17 [INFO] [stdout] | [INFO] [stdout] 162 | assert!(!self.first_key.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.first_key.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | / return Ok(( [INFO] [stdout] 175 | | keys_offset, [INFO] [stdout] 176 | | keys_offset + self.keys_buf.len() as u64, [INFO] [stdout] 177 | | self.first_key.as_ref().unwrap().clone(), [INFO] [stdout] 178 | | self.last_key.as_ref().unwrap().clone(), [INFO] [stdout] 179 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 ~ Ok(( [INFO] [stdout] 175 + keys_offset, [INFO] [stdout] 176 + keys_offset + self.keys_buf.len() as u64, [INFO] [stdout] 177 + self.first_key.as_ref().unwrap().clone(), [INFO] [stdout] 178 + self.last_key.as_ref().unwrap().clone(), [INFO] [stdout] 179 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/disk.rs:184:22 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn flush_to_disk<'a>(dir: &str, table_id: TableId, m: &'a MemStore) -> Result<(u64, u64, Buf, Buf)> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 184 - pub fn flush_to_disk<'a>(dir: &str, table_id: TableId, m: &'a MemStore) -> Result<(u64, u64, Buf, Buf)> { [INFO] [stdout] 184 + pub fn flush_to_disk(dir: &str, table_id: TableId, m: &MemStore) -> Result<(u64, u64, Buf, Buf)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 192 | return builder.finish(&mut f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return builder.finish(&mut f); [INFO] [stdout] 192 + builder.finish(&mut f) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 197 | return Ok(f); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 197 - return Ok(f); [INFO] [stdout] 197 + Ok(f) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 207 | return Ok(buf); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - return Ok(buf); [INFO] [stdout] 207 + Ok(buf) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/disk.rs:204:19 [INFO] [stdout] | [INFO] [stdout] 204 | let mut buf = Vec::::new(); [INFO] [stdout] | ___________________^ [INFO] [stdout] 205 | | buf.resize(length, 0u8); [INFO] [stdout] | |___________________________^ help: consider replacing this with: `vec![0; length]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] = note: `#[warn(clippy::slow_vector_initialization)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 - return Ok(None); [INFO] [stdout] 234 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 256 | return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stdout] 256 + Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `keys.get(keys.len() - 1)` [INFO] [stdout] --> src/disk.rs:251:26 [INFO] [stdout] | [INFO] [stdout] 251 | let step_back = *keys.get(keys.len() - 1).or_err("table keys buffer too small")? as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `keys.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 260 | return TableKeysInterval{keys_pos: self.keys_pos, keys_end_pos: self.keys_end_pos}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 260 - return TableKeysInterval{keys_pos: self.keys_pos, keys_end_pos: self.keys_end_pos}; [INFO] [stdout] 260 + TableKeysInterval{keys_pos: self.keys_pos, keys_end_pos: self.keys_end_pos} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | return Ok((key, value_offset, value_length)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 271 - return Ok((key, value_offset, value_length)); [INFO] [stdout] 271 + Ok((key, value_offset, value_length)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/disk.rs:270:38 [INFO] [stdout] | [INFO] [stdout] 270 | let key: &[u8] = observe_str(&*keys, pos).or_err("cannot decode key")?; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 270 - let key: &[u8] = observe_str(&*keys, pos).or_err("cannot decode key")?; [INFO] [stdout] 270 + let key: &[u8] = observe_str(keys, pos).or_err("cannot decode key")?; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 270 | let key: &[u8] = observe_str(&**keys, pos).or_err("cannot decode key")?; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:281:9 [INFO] [stdout] | [INFO] [stdout] 281 | return Ok(Some(tup)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return Ok(Some(tup)); [INFO] [stdout] 281 + Ok(Some(tup)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 285 | return TableKeysIterator::help_current_key(&self.keys, self.keys_pos, self.keys_end_pos); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 285 - return TableKeysIterator::help_current_key(&self.keys, self.keys_pos, self.keys_end_pos); [INFO] [stdout] 285 + TableKeysIterator::help_current_key(&self.keys, self.keys_pos, self.keys_end_pos) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:294:9 [INFO] [stdout] | [INFO] [stdout] 294 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 294 - return Ok(()); [INFO] [stdout] 294 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/disk.rs:292:47 [INFO] [stdout] | [INFO] [stdout] 292 | let _ = TableKeysIterator::decode_key(&keys, &mut pos)?; [INFO] [stdout] | ^^^^^ help: change this to: `keys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 298 | return TableKeysIterator::help_step_key(&self.keys, &mut self.keys_pos) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return TableKeysIterator::help_step_key(&self.keys, &mut self.keys_pos) [INFO] [stdout] 298 + TableKeysIterator::help_step_key(&self.keys, &mut self.keys_pos) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 306 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 306 - return Ok(None); [INFO] [stdout] 306 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 320 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 320 - return ret; [INFO] [stdout] 320 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 333 | return Ok(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 - return Ok(true); [INFO] [stdout] 333 + Ok(true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:344:5 [INFO] [stdout] | [INFO] [stdout] 344 | return Ok((f, keys_buf)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 344 - return Ok((f, keys_buf)); [INFO] [stdout] 344 + Ok((f, keys_buf)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:355:5 [INFO] [stdout] | [INFO] [stdout] 355 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 355 - return Ok(()); [INFO] [stdout] 355 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:395:13 [INFO] [stdout] | [INFO] [stdout] 395 | / return Ok(TableIterator{ [INFO] [stdout] 396 | | keys_iter: keys_iter, [INFO] [stdout] 397 | | values_buf: values_buf, [INFO] [stdout] 398 | | offset_of_values_buf: value_offset, [INFO] [stdout] 399 | | direction: direction, [INFO] [stdout] 400 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 395 ~ Ok(TableIterator{ [INFO] [stdout] 396 + keys_iter: keys_iter, [INFO] [stdout] 397 + values_buf: values_buf, [INFO] [stdout] 398 + offset_of_values_buf: value_offset, [INFO] [stdout] 399 + direction: direction, [INFO] [stdout] 400 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:402:13 [INFO] [stdout] | [INFO] [stdout] 402 | / return Ok(TableIterator{ [INFO] [stdout] 403 | | keys_iter: keys_iter, [INFO] [stdout] 404 | | // keys_iter is empty, so these will never get used. [INFO] [stdout] 405 | | values_buf: Vec::::new(), [INFO] [stdout] 406 | | offset_of_values_buf: 0, [INFO] [stdout] 407 | | direction: direction, [INFO] [stdout] 408 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 402 ~ Ok(TableIterator{ [INFO] [stdout] 403 + keys_iter: keys_iter, [INFO] [stdout] 404 + // keys_iter is empty, so these will never get used. [INFO] [stdout] 405 + values_buf: Vec::::new(), [INFO] [stdout] 406 + offset_of_values_buf: 0, [INFO] [stdout] 407 + direction: direction, [INFO] [stdout] 408 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:414:9 [INFO] [stdout] | [INFO] [stdout] 414 | / return match direction { [INFO] [stdout] 415 | | Direction::Forward => keys_iter.current_key(), [INFO] [stdout] 416 | | Direction::Backward => keys_iter.current_back_key() [INFO] [stdout] 417 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 414 ~ match direction { [INFO] [stdout] 415 + Direction::Forward => keys_iter.current_key(), [INFO] [stdout] 416 + Direction::Backward => keys_iter.current_back_key() [INFO] [stdout] 417 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:421:9 [INFO] [stdout] | [INFO] [stdout] 421 | return TableIterator::help_current_entry(&self.keys_iter, self.direction); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 421 - return TableIterator::help_current_entry(&self.keys_iter, self.direction); [INFO] [stdout] 421 + TableIterator::help_current_entry(&self.keys_iter, self.direction) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 428 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 428 - return ret; [INFO] [stdout] 428 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:447:9 [INFO] [stdout] | [INFO] [stdout] 447 | return mk_err("current_value called on empty TableIterator"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 447 - return mk_err("current_value called on empty TableIterator"); [INFO] [stdout] 447 + mk_err("current_value called on empty TableIterator") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:453:17 [INFO] [stdout] | [INFO] [stdout] 453 | return self.keys_iter.step_key(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 453 - return self.keys_iter.step_key(); [INFO] [stdout] 453 + self.keys_iter.step_key() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:459:17 [INFO] [stdout] | [INFO] [stdout] 459 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 459 - return Ok(()); [INFO] [stdout] 459 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/encoding.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return Some(n); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return Some(n); [INFO] [stdout] 43 + Some(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/encoding.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | return Some(x as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return Some(x as usize); [INFO] [stdout] 50 + Some(x as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/encoding.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | if x > (usize::max_value() as u64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 47 - if x > (usize::max_value() as u64) { [INFO] [stdout] 47 + if x > (usize::MAX as u64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `bytes` [INFO] [stdout] --> src/encoding.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | for i in 0..8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 56 - for i in 0..8 { [INFO] [stdout] 56 + for in &mut bytes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/encoding.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | return Some(n); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return Some(n); [INFO] [stdout] 73 + Some(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `bytes` [INFO] [stdout] --> src/encoding.rs:78:14 [INFO] [stdout] | [INFO] [stdout] 78 | for i in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 78 - for i in 0..4 { [INFO] [stdout] 78 + for in &mut bytes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/encoding.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | return Some(n); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Some(n); [INFO] [stdout] 95 + Some(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/encoding.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | return Some(slice); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return Some(slice); [INFO] [stdout] 111 + Some(slice) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/encoding.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 116 | return Some(s.to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return Some(s.to_vec()); [INFO] [stdout] 116 + Some(s.to_vec()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | return Error::MsgError(msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return Error::MsgError(msg.to_string()); [INFO] [stdout] 15 + Error::MsgError(msg.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / return match self { [INFO] [stdout] 20 | | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] 21 | | &Error::MsgError(ref s) => &s, [INFO] [stdout] 22 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ match self { [INFO] [stdout] 20 + &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] 21 + &Error::MsgError(ref s) => &s, [INFO] [stdout] 22 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/error.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | return match self { [INFO] [stdout] | ________________^ [INFO] [stdout] 20 | | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] 21 | | &Error::MsgError(ref s) => &s, [INFO] [stdout] 22 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 19 ~ return match *self { [INFO] [stdout] 20 ~ Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] 21 ~ Error::MsgError(ref s) => &s, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/error.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 20 - &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] 20 + Error::IoError(e) => (e as &std::error::Error).description(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/error.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | &Error::MsgError(ref s) => &s, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 21 - &Error::MsgError(ref s) => &s, [INFO] [stdout] 21 + Error::MsgError(s) => &s, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/error.rs:21:40 [INFO] [stdout] | [INFO] [stdout] 21 | &Error::MsgError(ref s) => &s, [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | return Err(Error::new(msg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return Err(Error::new(msg)); [INFO] [stdout] 35 + Err(Error::new(msg)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | return write!(f, "{}", self.msg()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return write!(f, "{}", self.msg()); [INFO] [stdout] 41 + write!(f, "{}", self.msg()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | / return match self { [INFO] [stdout] 50 | | &Error::IoError(ref e) => Some(e), [INFO] [stdout] 51 | | &Error::MsgError(_) => None, [INFO] [stdout] 52 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 ~ match self { [INFO] [stdout] 50 + &Error::IoError(ref e) => Some(e), [INFO] [stdout] 51 + &Error::MsgError(_) => None, [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/error.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | return match self { [INFO] [stdout] | ________________^ [INFO] [stdout] 50 | | &Error::IoError(ref e) => Some(e), [INFO] [stdout] 51 | | &Error::MsgError(_) => None, [INFO] [stdout] 52 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 49 ~ return match *self { [INFO] [stdout] 50 ~ Error::IoError(ref e) => Some(e), [INFO] [stdout] 51 ~ Error::MsgError(_) => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/error.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | &Error::IoError(ref e) => Some(e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 50 - &Error::IoError(ref e) => Some(e), [INFO] [stdout] 50 + Error::IoError(e) => Some(e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return ixkeys.min_by_key(|&(_, k)| k); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return ixkeys.min_by_key(|&(_, k)| k); [INFO] [stdout] 30 + ixkeys.min_by_key(|&(_, k)| k) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | return ixkeys.max_by_key(|&(i, k)| (k, n - i)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return ixkeys.max_by_key(|&(i, k)| (k, n - i)); [INFO] [stdout] 35 + ixkeys.max_by_key(|&(i, k)| (k, n - i)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / return Ok(MergeIterator{ [INFO] [stdout] 48 | | iters: iters, [INFO] [stdout] 49 | | iters_front: iters_front, [INFO] [stdout] 50 | | direction: direction, [INFO] [stdout] 51 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 ~ Ok(MergeIterator{ [INFO] [stdout] 48 + iters: iters, [INFO] [stdout] 49 + iters_front: iters_front, [INFO] [stdout] 50 + direction: direction, [INFO] [stdout] 51 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return ret; [INFO] [stdout] 58 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/iter.rs:57:38 [INFO] [stdout] | [INFO] [stdout] 57 | let ret = Ok(frontmost_front(&self).map(|(_, k)| k)); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | return self.iters[i].current_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return self.iters[i].current_value(); [INFO] [stdout] 62 + self.iters[i].current_value() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | return mk_err("current_value called on empty MutationIterator"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return mk_err("current_value called on empty MutationIterator"); [INFO] [stdout] 64 + mk_err("current_value called on empty MutationIterator") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/iter.rs:61:47 [INFO] [stdout] | [INFO] [stdout] 61 | if let Some((i, _)) = frontmost_front(&self) { [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Ok(()); [INFO] [stdout] 79 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/iter.rs:69:44 [INFO] [stdout] | [INFO] [stdout] 69 | let (_, key) = frontmost_front(&self).or_err("step MergeIterator too far")?; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/disk.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | / match m { [INFO] [stdout] 57 | | &Mutation::Set(ref s) => { [INFO] [stdout] 58 | | v.push(0); [INFO] [stdout] 59 | | encode_str(v, s); [INFO] [stdout] ... | [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 56 ~ match *m { [INFO] [stdout] 57 ~ Mutation::Set(ref s) => { [INFO] [stdout] 58 | v.push(0); [INFO] [stdout] 59 | encode_str(v, s); [INFO] [stdout] 60 | }, [INFO] [stdout] 61 ~ Mutation::Delete => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/disk.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | &Mutation::Set(ref s) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 57 - &Mutation::Set(ref s) => { [INFO] [stdout] 57 + Mutation::Set(s) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return Some(Mutation::Set(s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Some(Mutation::Set(s)); [INFO] [stdout] 72 + Some(Mutation::Set(s)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return ret; [INFO] [stdout] 114 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return Some(Mutation::Delete); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return Some(Mutation::Delete); [INFO] [stdout] 74 + Some(Mutation::Delete) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return None; [INFO] [stdout] 76 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/iter.rs:113:49 [INFO] [stdout] | [INFO] [stdout] 113 | let ret = Ok(self.current.as_ref().map(|&(ref key, _)| key as &[u8])); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 113 - let ret = Ok(self.current.as_ref().map(|&(ref key, _)| key as &[u8])); [INFO] [stdout] 113 + let ret = Ok(self.current.as_ref().map(|(key, _)| key as &[u8])); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | return iter.current_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return iter.current_value(); [INFO] [stdout] 118 + iter.current_value() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | return mk_err("current_value called on empty ConcatIterator"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return mk_err("current_value called on empty ConcatIterator"); [INFO] [stdout] 120 + mk_err("current_value called on empty ConcatIterator") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return Ok(()); [INFO] [stdout] 142 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/disk.rs:71:33 [INFO] [stdout] | [INFO] [stdout] 71 | let s: Buf = decode_str(&v, pos)?; [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | / return 1 // prev key entry len [INFO] [stdout] 94 | | + 1 // value len [INFO] [stdout] 95 | | + 3 // value offset [INFO] [stdout] 96 | | + 1 // key len [INFO] [stdout] 97 | | + key.len(); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 ~ 1 // prev key entry len [INFO] [stdout] 94 + + 1 // value len [INFO] [stdout] 95 + + 3 // value offset [INFO] [stdout] 96 + + 1 // key len [INFO] [stdout] 97 ~ + key.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | / return 1 // Set/delete byte [INFO] [stdout] 101 | | + 1 // val len [INFO] [stdout] 102 | | + val.len(); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 ~ 1 // Set/delete byte [INFO] [stdout] 101 + + 1 // val len [INFO] [stdout] 102 ~ + val.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/memstore.rs:29:60 [INFO] [stdout] | [INFO] [stdout] 29 | old_usage = k_usage + disk::approx_value_usage(&old_value); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `old_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | / return match val { [INFO] [stdout] 106 | | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] 107 | | &Mutation::Delete => 1, [INFO] [stdout] 108 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 ~ match val { [INFO] [stdout] 106 + &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] 107 + &Mutation::Delete => 1, [INFO] [stdout] 108 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/disk.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 105 | return match val { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] 107 | | &Mutation::Delete => 1, [INFO] [stdout] 108 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 105 ~ return match *val { [INFO] [stdout] 106 ~ Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] 107 ~ Mutation::Delete => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/disk.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 106 - &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] 106 + Mutation::Set(x) => set_value_usage(&x), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/disk.rs:106:50 [INFO] [stdout] | [INFO] [stdout] 106 | &Mutation::Set(ref x) => set_value_usage(&x), [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | / return TableBuilder{ [INFO] [stdout] 125 | | values_buf: Vec::new(), [INFO] [stdout] 126 | | keys_buf: Vec::new(), [INFO] [stdout] 127 | | first_key: None, [INFO] [stdout] 128 | | last_key: None, [INFO] [stdout] 129 | | last_entry_len: 0, [INFO] [stdout] 130 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 ~ TableBuilder{ [INFO] [stdout] 125 + values_buf: Vec::new(), [INFO] [stdout] 126 + keys_buf: Vec::new(), [INFO] [stdout] 127 + first_key: None, [INFO] [stdout] 128 + last_key: None, [INFO] [stdout] 129 + last_entry_len: 0, [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | return self.first_key.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return self.first_key.is_none(); [INFO] [stdout] 135 + self.first_key.is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | return self.values_buf.len() + self.keys_buf.len() + TAB_BACK_PADDING; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return self.values_buf.len() + self.keys_buf.len() + TAB_BACK_PADDING; [INFO] [stdout] 139 + self.values_buf.len() + self.keys_buf.len() + TAB_BACK_PADDING [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return self.entries.get(key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return self.entries.get(key); [INFO] [stdout] 43 + self.entries.get(key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return range.next().map(|(key, _)| key as &[u8]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return range.next().map(|(key, _)| key as &[u8]); [INFO] [stdout] 48 + range.next().map(|(key, _)| key as &[u8]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/disk.rs:162:17 [INFO] [stdout] | [INFO] [stdout] 162 | assert!(!self.first_key.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.first_key.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | / return Ok(( [INFO] [stdout] 175 | | keys_offset, [INFO] [stdout] 176 | | keys_offset + self.keys_buf.len() as u64, [INFO] [stdout] 177 | | self.first_key.as_ref().unwrap().clone(), [INFO] [stdout] 178 | | self.last_key.as_ref().unwrap().clone(), [INFO] [stdout] 179 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 ~ Ok(( [INFO] [stdout] 175 + keys_offset, [INFO] [stdout] 176 + keys_offset + self.keys_buf.len() as u64, [INFO] [stdout] 177 + self.first_key.as_ref().unwrap().clone(), [INFO] [stdout] 178 + self.last_key.as_ref().unwrap().clone(), [INFO] [stdout] 179 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return range.next_back().map(|(key, _)| key as &[u8]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return range.next_back().map(|(key, _)| key as &[u8]); [INFO] [stdout] 53 + range.next_back().map(|(key, _)| key as &[u8]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return MemStore{entries: BTreeMap::::new(), mem_usage: 0}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return MemStore{entries: BTreeMap::::new(), mem_usage: 0}; [INFO] [stdout] 57 + MemStore{entries: BTreeMap::::new(), mem_usage: 0} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | / return match direction { [INFO] [stdout] 73 | | Direction::Forward => MemStoreIterator{ [INFO] [stdout] 74 | | memstore: ms, [INFO] [stdout] 75 | | current: ms.first_in_range(interval), [INFO] [stdout] ... | [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 ~ match direction { [INFO] [stdout] 73 + Direction::Forward => MemStoreIterator{ [INFO] [stdout] 74 + memstore: ms, [INFO] [stdout] 75 + current: ms.first_in_range(interval), [INFO] [stdout] 76 + bound: interval.upper.clone(), [INFO] [stdout] 77 + direction: direction, [INFO] [stdout] 78 + }, [INFO] [stdout] 79 + Direction::Backward => MemStoreIterator{ [INFO] [stdout] 80 + memstore: ms, [INFO] [stdout] 81 + current: ms.last_in_range(interval), [INFO] [stdout] 82 + bound: interval.lower.clone(), [INFO] [stdout] 83 + direction: direction, [INFO] [stdout] 84 + } [INFO] [stdout] 85 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return Ok(self.current); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return Ok(self.current); [INFO] [stdout] 91 + Ok(self.current) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/disk.rs:184:22 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn flush_to_disk<'a>(dir: &str, table_id: TableId, m: &'a MemStore) -> Result<(u64, u64, Buf, Buf)> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 184 - pub fn flush_to_disk<'a>(dir: &str, table_id: TableId, m: &'a MemStore) -> Result<(u64, u64, Buf, Buf)> { [INFO] [stdout] 184 + pub fn flush_to_disk(dir: &str, table_id: TableId, m: &MemStore) -> Result<(u64, u64, Buf, Buf)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return mk_err("current_value called on empty MemStoreIterator"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return mk_err("current_value called on empty MemStoreIterator"); [INFO] [stdout] 98 + mk_err("current_value called on empty MemStoreIterator") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 192 | return builder.finish(&mut f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return builder.finish(&mut f); [INFO] [stdout] 192 + builder.finish(&mut f) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return Ok(()); [INFO] [stdout] 112 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:123:17 [INFO] [stdout] | [INFO] [stdout] 123 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return Ok(()); [INFO] [stdout] 123 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 197 | return Ok(f); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 197 - return Ok(f); [INFO] [stdout] 197 + Ok(f) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/memstore.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | self.current = Some(&key); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 207 | return Ok(buf); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - return Ok(buf); [INFO] [stdout] 207 + Ok(buf) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/memstore.rs:119:41 [INFO] [stdout] | [INFO] [stdout] 119 | self.current = Some(&key); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/disk.rs:204:19 [INFO] [stdout] | [INFO] [stdout] 204 | let mut buf = Vec::::new(); [INFO] [stdout] | ___________________^ [INFO] [stdout] 205 | | buf.resize(length, 0u8); [INFO] [stdout] | |___________________________^ help: consider replacing this with: `vec![0; length]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] = note: `#[warn(clippy::slow_vector_initialization)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/toc.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'N'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/toc.rs:34:40 [INFO] [stdout] | [INFO] [stdout] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'I'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 - return Ok(None); [INFO] [stdout] 234 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/toc.rs:34:51 [INFO] [stdout] | [INFO] [stdout] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'H'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/toc.rs:34:62 [INFO] [stdout] | [INFO] [stdout] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 256 | return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}); [INFO] [stdout] 256 + Ok(TableKeysIterator{keys: keys, keys_pos: 0, keys_end_pos: keys_end_pos}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return format!("{}/toc", dir); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return format!("{}/toc", dir); [INFO] [stdout] 67 + format!("{}/toc", dir) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | return Ok(f); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return Ok(f); [INFO] [stdout] 74 + Ok(f) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `keys.get(keys.len() - 1)` [INFO] [stdout] --> src/disk.rs:251:26 [INFO] [stdout] | [INFO] [stdout] 251 | let step_back = *keys.get(keys.len() - 1).or_err("table keys buffer too small")? as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `keys.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/toc.rs:89:83 [INFO] [stdout] | [INFO] [stdout] 89 | let set: &mut BTreeSet = toc.level_infos.entry(level).or_insert_with(|| BTreeSet::::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BTreeSet::::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 260 | return TableKeysInterval{keys_pos: self.keys_pos, keys_end_pos: self.keys_end_pos}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 260 - return TableKeysInterval{keys_pos: self.keys_pos, keys_end_pos: self.keys_end_pos}; [INFO] [stdout] 260 + TableKeysInterval{keys_pos: self.keys_pos, keys_end_pos: self.keys_end_pos} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | return Ok((key, value_offset, value_length)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 271 - return Ok((key, value_offset, value_length)); [INFO] [stdout] 271 + Ok((key, value_offset, value_length)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | / return Some(TableInfo{ [INFO] [stdout] 112 | | id: TableId(id), [INFO] [stdout] 113 | | level: level, [INFO] [stdout] 114 | | keys_offset: keys_offset, [INFO] [stdout] ... | [INFO] [stdout] 117 | | biggest_key: biggest_key, [INFO] [stdout] 118 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 ~ Some(TableInfo{ [INFO] [stdout] 112 + id: TableId(id), [INFO] [stdout] 113 + level: level, [INFO] [stdout] 114 + keys_offset: keys_offset, [INFO] [stdout] 115 + file_size: file_size, [INFO] [stdout] 116 + smallest_key: smallest_key, [INFO] [stdout] 117 + biggest_key: biggest_key, [INFO] [stdout] 118 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:105:34 [INFO] [stdout] | [INFO] [stdout] 105 | let id: u64 = decode_uvarint(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/disk.rs:270:38 [INFO] [stdout] | [INFO] [stdout] 270 | let key: &[u8] = observe_str(&*keys, pos).or_err("cannot decode key")?; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 270 - let key: &[u8] = observe_str(&*keys, pos).or_err("cannot decode key")?; [INFO] [stdout] 270 + let key: &[u8] = observe_str(keys, pos).or_err("cannot decode key")?; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 270 | let key: &[u8] = observe_str(&**keys, pos).or_err("cannot decode key")?; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:106:37 [INFO] [stdout] | [INFO] [stdout] 106 | let level: u64 = decode_uvarint(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:107:43 [INFO] [stdout] | [INFO] [stdout] 107 | let keys_offset: u64 = decode_uvarint(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:281:9 [INFO] [stdout] | [INFO] [stdout] 281 | return Ok(Some(tup)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return Ok(Some(tup)); [INFO] [stdout] 281 + Ok(Some(tup)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | let file_size: u64 = decode_uvarint(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:109:40 [INFO] [stdout] | [INFO] [stdout] 109 | let smallest_key: Buf = decode_str(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 285 | return TableKeysIterator::help_current_key(&self.keys, self.keys_pos, self.keys_end_pos); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 285 - return TableKeysIterator::help_current_key(&self.keys, self.keys_pos, self.keys_end_pos); [INFO] [stdout] 285 + TableKeysIterator::help_current_key(&self.keys, self.keys_pos, self.keys_end_pos) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:110:39 [INFO] [stdout] | [INFO] [stdout] 110 | let biggest_key: Buf = decode_str(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:294:9 [INFO] [stdout] | [INFO] [stdout] 294 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 294 - return Ok(()); [INFO] [stdout] 294 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:140:5 [INFO] [stdout] | [INFO] [stdout] 140 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - return ret; [INFO] [stdout] 140 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/disk.rs:292:47 [INFO] [stdout] | [INFO] [stdout] 292 | let _ = TableKeysIterator::decode_key(&keys, &mut pos)?; [INFO] [stdout] | ^^^^^ help: change this to: `keys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 298 | return TableKeysIterator::help_step_key(&self.keys, &mut self.keys_pos) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return TableKeysIterator::help_step_key(&self.keys, &mut self.keys_pos) [INFO] [stdout] 298 + TableKeysIterator::help_step_key(&self.keys, &mut self.keys_pos) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:131:35 [INFO] [stdout] | [INFO] [stdout] 131 | encode_table_info(&mut v, &table_info); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `table_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 306 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 306 - return Ok(None); [INFO] [stdout] 306 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:174:5 [INFO] [stdout] | [INFO] [stdout] 174 | return Some(Entry{removals, additions}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 - return Some(Entry{removals, additions}); [INFO] [stdout] 174 + Some(Entry{removals, additions}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:144:50 [INFO] [stdout] | [INFO] [stdout] 144 | let length: usize = try_into_size(decode_u64(&buf, pos)?)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 320 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 320 - return ret; [INFO] [stdout] 320 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:145:36 [INFO] [stdout] | [INFO] [stdout] 145 | let checksum: u32 = decode_u32(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:158:60 [INFO] [stdout] | [INFO] [stdout] 158 | let num_removals: usize = try_into_size(decode_uvarint(&buf, pos)?)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:161:44 [INFO] [stdout] | [INFO] [stdout] 161 | let table = TableId(decode_uvarint(&buf, pos)?); [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 333 | return Ok(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 - return Ok(true); [INFO] [stdout] 333 + Ok(true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:344:5 [INFO] [stdout] | [INFO] [stdout] 344 | return Ok((f, keys_buf)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 344 - return Ok((f, keys_buf)); [INFO] [stdout] 344 + Ok((f, keys_buf)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:165:61 [INFO] [stdout] | [INFO] [stdout] 165 | let num_additions: usize = try_into_size(decode_uvarint(&buf, pos)?)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:168:42 [INFO] [stdout] | [INFO] [stdout] 168 | additions.push(decode_table_info(&buf, pos)?); [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 189 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return ret; [INFO] [stdout] 189 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:355:5 [INFO] [stdout] | [INFO] [stdout] 355 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 355 - return Ok(()); [INFO] [stdout] 355 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return None; [INFO] [stdout] 204 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/toc.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 197 | if let Some(x) = frontpart.parse::().ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(x)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 197 - if let Some(x) = frontpart.parse::().ok() { [INFO] [stdout] 197 + if let Ok(x) = frontpart.parse::() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:224:5 [INFO] [stdout] | [INFO] [stdout] 224 | return Ok(ret); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 224 - return Ok(ret); [INFO] [stdout] 224 + Ok(ret) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:395:13 [INFO] [stdout] | [INFO] [stdout] 395 | / return Ok(TableIterator{ [INFO] [stdout] 396 | | keys_iter: keys_iter, [INFO] [stdout] 397 | | values_buf: values_buf, [INFO] [stdout] 398 | | offset_of_values_buf: value_offset, [INFO] [stdout] 399 | | direction: direction, [INFO] [stdout] 400 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 395 ~ Ok(TableIterator{ [INFO] [stdout] 396 + keys_iter: keys_iter, [INFO] [stdout] 397 + values_buf: values_buf, [INFO] [stdout] 398 + offset_of_values_buf: value_offset, [INFO] [stdout] 399 + direction: direction, [INFO] [stdout] 400 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:402:13 [INFO] [stdout] | [INFO] [stdout] 402 | / return Ok(TableIterator{ [INFO] [stdout] 403 | | keys_iter: keys_iter, [INFO] [stdout] 404 | | // keys_iter is empty, so these will never get used. [INFO] [stdout] 405 | | values_buf: Vec::::new(), [INFO] [stdout] 406 | | offset_of_values_buf: 0, [INFO] [stdout] 407 | | direction: direction, [INFO] [stdout] 408 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 402 ~ Ok(TableIterator{ [INFO] [stdout] 403 + keys_iter: keys_iter, [INFO] [stdout] 404 + // keys_iter is empty, so these will never get used. [INFO] [stdout] 405 + values_buf: Vec::::new(), [INFO] [stdout] 406 + offset_of_values_buf: 0, [INFO] [stdout] 407 + direction: direction, [INFO] [stdout] 408 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:228:5 [INFO] [stdout] | [INFO] [stdout] 228 | / return toc.table_infos.iter().all(|(id, info)| [INFO] [stdout] 229 | | dirent_tables.get(id).map(|x| *x) == Some(info.file_size) [INFO] [stdout] 230 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 228 ~ toc.table_infos.iter().all(|(id, info)| [INFO] [stdout] 229 + dirent_tables.get(id).map(|x| *x) == Some(info.file_size) [INFO] [stdout] 230 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/toc.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | dirent_tables.get(id).map(|x| *x) == Some(info.file_size) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `dirent_tables.get(id).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:267:5 [INFO] [stdout] | [INFO] [stdout] 267 | return Ok((f, toc)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 267 - return Ok((f, toc)); [INFO] [stdout] 267 + Ok((f, toc)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:414:9 [INFO] [stdout] | [INFO] [stdout] 414 | / return match direction { [INFO] [stdout] 415 | | Direction::Forward => keys_iter.current_key(), [INFO] [stdout] 416 | | Direction::Backward => keys_iter.current_back_key() [INFO] [stdout] 417 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 414 ~ match direction { [INFO] [stdout] 415 + Direction::Forward => keys_iter.current_key(), [INFO] [stdout] 416 + Direction::Backward => keys_iter.current_back_key() [INFO] [stdout] 417 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:421:9 [INFO] [stdout] | [INFO] [stdout] 421 | return TableIterator::help_current_entry(&self.keys_iter, self.direction); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 421 - return TableIterator::help_current_entry(&self.keys_iter, self.direction); [INFO] [stdout] 421 + TableIterator::help_current_entry(&self.keys_iter, self.direction) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 428 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 428 - return ret; [INFO] [stdout] 428 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:274:5 [INFO] [stdout] | [INFO] [stdout] 274 | return Ok(process_entry(toc, entry)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 274 - return Ok(process_entry(toc, entry)); [INFO] [stdout] 274 + Ok(process_entry(toc, entry)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:447:9 [INFO] [stdout] | [INFO] [stdout] 447 | return mk_err("current_value called on empty TableIterator"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 447 - return mk_err("current_value called on empty TableIterator"); [INFO] [stdout] 447 + mk_err("current_value called on empty TableIterator") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / return match bound { [INFO] [stdout] 20 | | &Bound::Excluded(ref s) => x < &s, [INFO] [stdout] 21 | | &Bound::Included(ref s) => x <= &s, [INFO] [stdout] 22 | | &Bound::Unbounded => true, [INFO] [stdout] 23 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ match bound { [INFO] [stdout] 20 + &Bound::Excluded(ref s) => x < &s, [INFO] [stdout] 21 + &Bound::Included(ref s) => x <= &s, [INFO] [stdout] 22 + &Bound::Unbounded => true, [INFO] [stdout] 23 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/util.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | return match bound { [INFO] [stdout] | ____________^ [INFO] [stdout] 20 | | &Bound::Excluded(ref s) => x < &s, [INFO] [stdout] 21 | | &Bound::Included(ref s) => x <= &s, [INFO] [stdout] 22 | | &Bound::Unbounded => true, [INFO] [stdout] 23 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 19 ~ return match *bound { [INFO] [stdout] 20 ~ Bound::Excluded(ref s) => x < &s, [INFO] [stdout] 21 ~ Bound::Included(ref s) => x <= &s, [INFO] [stdout] 22 ~ Bound::Unbounded => true, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/util.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | &Bound::Excluded(ref s) => x < &s, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 20 - &Bound::Excluded(ref s) => x < &s, [INFO] [stdout] 20 + Bound::Excluded(s) => x < &s, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:453:17 [INFO] [stdout] | [INFO] [stdout] 453 | return self.keys_iter.step_key(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 453 - return self.keys_iter.step_key(); [INFO] [stdout] 453 + self.keys_iter.step_key() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/disk.rs:459:17 [INFO] [stdout] | [INFO] [stdout] 459 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 459 - return Ok(()); [INFO] [stdout] 459 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/util.rs:20:40 [INFO] [stdout] | [INFO] [stdout] 20 | &Bound::Excluded(ref s) => x < &s, [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/util.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | &Bound::Included(ref s) => x <= &s, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 21 - &Bound::Included(ref s) => x <= &s, [INFO] [stdout] 21 + Bound::Included(s) => x <= &s, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/util.rs:21:41 [INFO] [stdout] | [INFO] [stdout] 21 | &Bound::Included(ref s) => x <= &s, [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / return match bound { [INFO] [stdout] 28 | | &Bound::Excluded(ref s) => x > &s, [INFO] [stdout] 29 | | &Bound::Included(ref s) => x >= &s, [INFO] [stdout] 30 | | &Bound::Unbounded => true, [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 ~ match bound { [INFO] [stdout] 28 + &Bound::Excluded(ref s) => x > &s, [INFO] [stdout] 29 + &Bound::Included(ref s) => x >= &s, [INFO] [stdout] 30 + &Bound::Unbounded => true, [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/encoding.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return Some(n); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return Some(n); [INFO] [stdout] 43 + Some(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/util.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | return match bound { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | &Bound::Excluded(ref s) => x > &s, [INFO] [stdout] 29 | | &Bound::Included(ref s) => x >= &s, [INFO] [stdout] 30 | | &Bound::Unbounded => true, [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 27 ~ return match *bound { [INFO] [stdout] 28 ~ Bound::Excluded(ref s) => x > &s, [INFO] [stdout] 29 ~ Bound::Included(ref s) => x >= &s, [INFO] [stdout] 30 ~ Bound::Unbounded => true, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/util.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | &Bound::Excluded(ref s) => x > &s, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 28 - &Bound::Excluded(ref s) => x > &s, [INFO] [stdout] 28 + Bound::Excluded(s) => x > &s, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/util.rs:28:40 [INFO] [stdout] | [INFO] [stdout] 28 | &Bound::Excluded(ref s) => x > &s, [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/util.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | &Bound::Included(ref s) => x >= &s, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 29 - &Bound::Included(ref s) => x >= &s, [INFO] [stdout] 29 + Bound::Included(s) => x >= &s, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/util.rs:29:41 [INFO] [stdout] | [INFO] [stdout] 29 | &Bound::Included(ref s) => x >= &s, [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/encoding.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | return Some(x as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return Some(x as usize); [INFO] [stdout] 50 + Some(x as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/encoding.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | if x > (usize::max_value() as u64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 47 - if x > (usize::max_value() as u64) { [INFO] [stdout] 47 + if x > (usize::MAX as u64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `bytes` [INFO] [stdout] --> src/encoding.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | for i in 0..8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 56 - for i in 0..8 { [INFO] [stdout] 56 + for in &mut bytes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/util.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / match x { [INFO] [stdout] 36 | | &Bound::Excluded(ref b) => Bound::Excluded(b), [INFO] [stdout] 37 | | &Bound::Included(ref b) => Bound::Included(b), [INFO] [stdout] 38 | | &Bound::Unbounded => Bound::Unbounded, [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 35 ~ match *x { [INFO] [stdout] 36 ~ Bound::Excluded(ref b) => Bound::Excluded(b), [INFO] [stdout] 37 ~ Bound::Included(ref b) => Bound::Included(b), [INFO] [stdout] 38 ~ Bound::Unbounded => Bound::Unbounded, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/util.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | &Bound::Excluded(ref b) => Bound::Excluded(b), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 36 - &Bound::Excluded(ref b) => Bound::Excluded(b), [INFO] [stdout] 36 + Bound::Excluded(b) => Bound::Excluded(b), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/util.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | &Bound::Included(ref b) => Bound::Included(b), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 37 - &Bound::Included(ref b) => Bound::Included(b), [INFO] [stdout] 37 + Bound::Included(b) => Bound::Included(b), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/encoding.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | return Some(n); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return Some(n); [INFO] [stdout] 73 + Some(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `bytes` [INFO] [stdout] --> src/encoding.rs:78:14 [INFO] [stdout] | [INFO] [stdout] 78 | for i in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 78 - for i in 0..4 { [INFO] [stdout] 78 + for in &mut bytes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return Ok(()); [INFO] [stdout] 67 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/encoding.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | return Some(n); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Some(n); [INFO] [stdout] 95 + Some(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(Store::make_existing(threshold, dir.to_string(), toc_file, toc, MemStore::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(Store::make_existing(threshold, dir.to_string(), toc_file, toc, MemStore::new())); [INFO] [stdout] 75 + Ok(Store::make_existing(threshold, dir.to_string(), toc_file, toc, MemStore::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | / return Store{ [INFO] [stdout] 80 | | memstores: vec![MemStore::new(), ms], [INFO] [stdout] 81 | | threshold: threshold, [INFO] [stdout] ... | [INFO] [stdout] 85 | | toc: toc, [INFO] [stdout] 86 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 ~ Store{ [INFO] [stdout] 80 + memstores: vec![MemStore::new(), ms], [INFO] [stdout] 81 + threshold: threshold, [INFO] [stdout] 82 + [INFO] [stdout] 83 + directory: directory, [INFO] [stdout] 84 + toc_file: toc_file, [INFO] [stdout] 85 + toc: toc, [INFO] [stdout] 86 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/encoding.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | return Some(slice); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return Some(slice); [INFO] [stdout] 111 + Some(slice) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return Ok(false); [INFO] [stdout] 96 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return Ok(false); [INFO] [stdout] 106 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/encoding.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 116 | return Some(s.to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return Some(s.to_vec()); [INFO] [stdout] 116 + Some(s.to_vec()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/encoding.rs:145:19 [INFO] [stdout] | [INFO] [stdout] 145 | if num <= u32::max_value() as u64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 145 - if num <= u32::max_value() as u64 { [INFO] [stdout] 145 + if num <= u32::MAX as u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | return Error::MsgError(msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return Error::MsgError(msg.to_string()); [INFO] [stdout] 15 + Error::MsgError(msg.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / return match self { [INFO] [stdout] 20 | | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] 21 | | &Error::MsgError(ref s) => &s, [INFO] [stdout] 22 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ match self { [INFO] [stdout] 20 + &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] 21 + &Error::MsgError(ref s) => &s, [INFO] [stdout] 22 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/error.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | return match self { [INFO] [stdout] | ________________^ [INFO] [stdout] 20 | | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] 21 | | &Error::MsgError(ref s) => &s, [INFO] [stdout] 22 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 19 ~ return match *self { [INFO] [stdout] 20 ~ Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] 21 ~ Error::MsgError(ref s) => &s, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/error.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 20 - &Error::IoError(ref e) => (e as &std::error::Error).description(), [INFO] [stdout] 20 + Error::IoError(e) => (e as &std::error::Error).description(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/error.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | &Error::MsgError(ref s) => &s, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 21 - &Error::MsgError(ref s) => &s, [INFO] [stdout] 21 + Error::MsgError(s) => &s, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/error.rs:21:40 [INFO] [stdout] | [INFO] [stdout] 21 | &Error::MsgError(ref s) => &s, [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | return Err(Error::new(msg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return Err(Error::new(msg)); [INFO] [stdout] 35 + Err(Error::new(msg)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | return write!(f, "{}", self.msg()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return write!(f, "{}", self.msg()); [INFO] [stdout] 41 + write!(f, "{}", self.msg()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | / return match self { [INFO] [stdout] 50 | | &Error::IoError(ref e) => Some(e), [INFO] [stdout] 51 | | &Error::MsgError(_) => None, [INFO] [stdout] 52 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 ~ match self { [INFO] [stdout] 50 + &Error::IoError(ref e) => Some(e), [INFO] [stdout] 51 + &Error::MsgError(_) => None, [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/error.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | return match self { [INFO] [stdout] | ________________^ [INFO] [stdout] 50 | | &Error::IoError(ref e) => Some(e), [INFO] [stdout] 51 | | &Error::MsgError(_) => None, [INFO] [stdout] 52 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 49 ~ return match *self { [INFO] [stdout] 50 ~ Error::IoError(ref e) => Some(e), [INFO] [stdout] 51 ~ Error::MsgError(_) => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/error.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | &Error::IoError(ref e) => Some(e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 50 - &Error::IoError(ref e) => Some(e), [INFO] [stdout] 50 + Error::IoError(e) => Some(e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return ixkeys.min_by_key(|&(_, k)| k); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return ixkeys.min_by_key(|&(_, k)| k); [INFO] [stdout] 30 + ixkeys.min_by_key(|&(_, k)| k) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | return ixkeys.max_by_key(|&(i, k)| (k, n - i)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return ixkeys.max_by_key(|&(i, k)| (k, n - i)); [INFO] [stdout] 35 + ixkeys.max_by_key(|&(i, k)| (k, n - i)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / return Ok(MergeIterator{ [INFO] [stdout] 48 | | iters: iters, [INFO] [stdout] 49 | | iters_front: iters_front, [INFO] [stdout] 50 | | direction: direction, [INFO] [stdout] 51 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 ~ Ok(MergeIterator{ [INFO] [stdout] 48 + iters: iters, [INFO] [stdout] 49 + iters_front: iters_front, [INFO] [stdout] 50 + direction: direction, [INFO] [stdout] 51 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return ret; [INFO] [stdout] 58 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/iter.rs:57:38 [INFO] [stdout] | [INFO] [stdout] 57 | let ret = Ok(frontmost_front(&self).map(|(_, k)| k)); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | return self.iters[i].current_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return self.iters[i].current_value(); [INFO] [stdout] 62 + self.iters[i].current_value() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | return mk_err("current_value called on empty MutationIterator"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return mk_err("current_value called on empty MutationIterator"); [INFO] [stdout] 64 + mk_err("current_value called on empty MutationIterator") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/iter.rs:61:47 [INFO] [stdout] | [INFO] [stdout] 61 | if let Some((i, _)) = frontmost_front(&self) { [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Ok(()); [INFO] [stdout] 79 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/iter.rs:69:44 [INFO] [stdout] | [INFO] [stdout] 69 | let (_, key) = frontmost_front(&self).or_err("step MergeIterator too far")?; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | return self.consider_split(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return self.consider_split(); [INFO] [stdout] 113 + self.consider_split() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return Ok(false); [INFO] [stdout] 123 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return Ok(()); [INFO] [stdout] 135 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return Ok(()); [INFO] [stdout] 148 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return Ok(()); [INFO] [stdout] 211 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 152 | if self.toc.level_infos.get(&0).map_or(false, |lz| lz.len() > 4) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 152 - if self.toc.level_infos.get(&0).map_or(false, |lz| lz.len() > 4) { [INFO] [stdout] 152 + if self.toc.level_infos.get(&0).is_some_and(|lz| lz.len() > 4) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 155 | = self.toc.level_infos.get(&0).unwrap().iter().rev().skip(1).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.toc.level_infos.get(&0).unwrap().iter().rev().skip(1).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:186:44 [INFO] [stdout] | [INFO] [stdout] 186 | let mut smallest_overlap = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 186 - let mut smallest_overlap = usize::max_value(); [INFO] [stdout] 186 + let mut smallest_overlap = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:203:45 [INFO] [stdout] | [INFO] [stdout] 203 | assert!(smallest_overlap != usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 203 - assert!(smallest_overlap != usize::max_value()); [INFO] [stdout] 203 + assert!(smallest_overlap != usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 236 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 236 - return Ok(()); [INFO] [stdout] 236 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:308:13 [INFO] [stdout] | [INFO] [stdout] 308 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 308 - return Ok(()); [INFO] [stdout] 308 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:219:33 [INFO] [stdout] | [INFO] [stdout] 219 | assert!(if level == 0 { tables.len() > 0 } else { tables.len() == 1 }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tables.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:293:19 [INFO] [stdout] | [INFO] [stdout] 293 | = tables.iter().chain(lower_overlapping_ids.iter()).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `tables.iter().chain(lower_overlapping_ids.iter()).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | return !(!above_lower_bound(&x.biggest_key, &y.lower) || !below_upper_bound(&x.smallest_key, &y.upper)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 313 - return !(!above_lower_bound(&x.biggest_key, &y.lower) || !below_upper_bound(&x.smallest_key, &y.upper)); [INFO] [stdout] 313 + !(!above_lower_bound(&x.biggest_key, &y.lower) || !below_upper_bound(&x.smallest_key, &y.upper)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - return false; [INFO] [stdout] 324 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 328 | return !(x.biggest_key < y.smallest_key || y.biggest_key < x.smallest_key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 - return !(x.biggest_key < y.smallest_key || y.biggest_key < x.smallest_key); [INFO] [stdout] 328 + !(x.biggest_key < y.smallest_key || y.biggest_key < x.smallest_key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:343:13 [INFO] [stdout] | [INFO] [stdout] 343 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 343 - return ret; [INFO] [stdout] 343 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:345:13 [INFO] [stdout] | [INFO] [stdout] 345 | return Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 345 - return Vec::new(); [INFO] [stdout] 345 + Vec::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:353:9 [INFO] [stdout] | [INFO] [stdout] 353 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 353 - return Ok(()); [INFO] [stdout] 353 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 372 - return Ok(()); [INFO] [stdout] 372 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:362:100 [INFO] [stdout] | [INFO] [stdout] 362 | let (keys_offset, file_size, smallest, biggest) = flush_to_disk(&self.directory, table_id, &ms)?; [INFO] [stdout] | ^^^ help: change this to: `ms` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:404:9 [INFO] [stdout] | [INFO] [stdout] 404 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 404 - return Ok(false); [INFO] [stdout] 404 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/lib.rs:379:27 [INFO] [stdout] | [INFO] [stdout] 379 | return Ok(match m { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 380 | | &Mutation::Set(_) => true, [INFO] [stdout] 381 | | &Mutation::Delete => false, [INFO] [stdout] 382 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 379 ~ return Ok(match *m { [INFO] [stdout] 380 ~ Mutation::Set(_) => true, [INFO] [stdout] 381 ~ Mutation::Delete => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:437:9 [INFO] [stdout] | [INFO] [stdout] 437 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - return Ok(None); [INFO] [stdout] 437 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/lib.rs:413:27 [INFO] [stdout] | [INFO] [stdout] 413 | return Ok(match m { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 414 | | &Mutation::Set(ref x) => Some(x.clone()), [INFO] [stdout] 415 | | &Mutation::Delete => None, [INFO] [stdout] 416 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 413 ~ return Ok(match *m { [INFO] [stdout] 414 ~ Mutation::Set(ref x) => Some(x.clone()), [INFO] [stdout] 415 ~ Mutation::Delete => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/lib.rs:414:21 [INFO] [stdout] | [INFO] [stdout] 414 | &Mutation::Set(ref x) => Some(x.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 414 - &Mutation::Set(ref x) => Some(x.clone()), [INFO] [stdout] 414 + Mutation::Set(x) => Some(x.clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:447:9 [INFO] [stdout] | [INFO] [stdout] 447 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 447 - return Ok(()); [INFO] [stdout] 447 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:467:73 [INFO] [stdout] | [INFO] [stdout] 467 | self.add_table_iter_to_iters(&mut iters, *table_id, &interval, direction)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:511:9 [INFO] [stdout] | [INFO] [stdout] 511 | return self.range_directed(interval, Direction::Forward); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 511 - return self.range_directed(interval, Direction::Forward); [INFO] [stdout] 511 + self.range_directed(interval, Direction::Forward) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:516:9 [INFO] [stdout] | [INFO] [stdout] 516 | return self.range_directed(interval, Direction::Backward); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 516 - return self.range_directed(interval, Direction::Backward); [INFO] [stdout] 516 + self.range_directed(interval, Direction::Backward) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return ret; [INFO] [stdout] 114 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/iter.rs:113:49 [INFO] [stdout] | [INFO] [stdout] 113 | let ret = Ok(self.current.as_ref().map(|&(ref key, _)| key as &[u8])); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 113 - let ret = Ok(self.current.as_ref().map(|&(ref key, _)| key as &[u8])); [INFO] [stdout] 113 + let ret = Ok(self.current.as_ref().map(|(key, _)| key as &[u8])); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | return iter.current_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return iter.current_value(); [INFO] [stdout] 118 + iter.current_value() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | return mk_err("current_value called on empty ConcatIterator"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return mk_err("current_value called on empty ConcatIterator"); [INFO] [stdout] 120 + mk_err("current_value called on empty ConcatIterator") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/iter.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return Ok(()); [INFO] [stdout] 142 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/memstore.rs:29:60 [INFO] [stdout] | [INFO] [stdout] 29 | old_usage = k_usage + disk::approx_value_usage(&old_value); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `old_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return self.entries.get(key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return self.entries.get(key); [INFO] [stdout] 43 + self.entries.get(key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return range.next().map(|(key, _)| key as &[u8]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return range.next().map(|(key, _)| key as &[u8]); [INFO] [stdout] 48 + range.next().map(|(key, _)| key as &[u8]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return range.next_back().map(|(key, _)| key as &[u8]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return range.next_back().map(|(key, _)| key as &[u8]); [INFO] [stdout] 53 + range.next_back().map(|(key, _)| key as &[u8]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return MemStore{entries: BTreeMap::::new(), mem_usage: 0}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return MemStore{entries: BTreeMap::::new(), mem_usage: 0}; [INFO] [stdout] 57 + MemStore{entries: BTreeMap::::new(), mem_usage: 0} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | / return match direction { [INFO] [stdout] 73 | | Direction::Forward => MemStoreIterator{ [INFO] [stdout] 74 | | memstore: ms, [INFO] [stdout] 75 | | current: ms.first_in_range(interval), [INFO] [stdout] ... | [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 ~ match direction { [INFO] [stdout] 73 + Direction::Forward => MemStoreIterator{ [INFO] [stdout] 74 + memstore: ms, [INFO] [stdout] 75 + current: ms.first_in_range(interval), [INFO] [stdout] 76 + bound: interval.upper.clone(), [INFO] [stdout] 77 + direction: direction, [INFO] [stdout] 78 + }, [INFO] [stdout] 79 + Direction::Backward => MemStoreIterator{ [INFO] [stdout] 80 + memstore: ms, [INFO] [stdout] 81 + current: ms.last_in_range(interval), [INFO] [stdout] 82 + bound: interval.lower.clone(), [INFO] [stdout] 83 + direction: direction, [INFO] [stdout] 84 + } [INFO] [stdout] 85 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return Ok(self.current); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return Ok(self.current); [INFO] [stdout] 91 + Ok(self.current) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return mk_err("current_value called on empty MemStoreIterator"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return mk_err("current_value called on empty MemStoreIterator"); [INFO] [stdout] 98 + mk_err("current_value called on empty MemStoreIterator") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return Ok(()); [INFO] [stdout] 112 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memstore.rs:123:17 [INFO] [stdout] | [INFO] [stdout] 123 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return Ok(()); [INFO] [stdout] 123 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/memstore.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | self.current = Some(&key); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/memstore.rs:119:41 [INFO] [stdout] | [INFO] [stdout] 119 | self.current = Some(&key); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/toc.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'N'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/toc.rs:34:40 [INFO] [stdout] | [INFO] [stdout] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'I'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/toc.rs:34:51 [INFO] [stdout] | [INFO] [stdout] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'H'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/toc.rs:34:62 [INFO] [stdout] | [INFO] [stdout] 34 | const TOC_MAGIC: [u8; 8] = ['N' as u8, 'I' as u8, 'H' as u8, '\0' as u8, 1, 0, 0, 0]; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return format!("{}/toc", dir); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return format!("{}/toc", dir); [INFO] [stdout] 67 + format!("{}/toc", dir) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | return Ok(f); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return Ok(f); [INFO] [stdout] 74 + Ok(f) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/toc.rs:89:83 [INFO] [stdout] | [INFO] [stdout] 89 | let set: &mut BTreeSet = toc.level_infos.entry(level).or_insert_with(|| BTreeSet::::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BTreeSet::::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | / return Some(TableInfo{ [INFO] [stdout] 112 | | id: TableId(id), [INFO] [stdout] 113 | | level: level, [INFO] [stdout] 114 | | keys_offset: keys_offset, [INFO] [stdout] ... | [INFO] [stdout] 117 | | biggest_key: biggest_key, [INFO] [stdout] 118 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 ~ Some(TableInfo{ [INFO] [stdout] 112 + id: TableId(id), [INFO] [stdout] 113 + level: level, [INFO] [stdout] 114 + keys_offset: keys_offset, [INFO] [stdout] 115 + file_size: file_size, [INFO] [stdout] 116 + smallest_key: smallest_key, [INFO] [stdout] 117 + biggest_key: biggest_key, [INFO] [stdout] 118 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:105:34 [INFO] [stdout] | [INFO] [stdout] 105 | let id: u64 = decode_uvarint(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:106:37 [INFO] [stdout] | [INFO] [stdout] 106 | let level: u64 = decode_uvarint(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:107:43 [INFO] [stdout] | [INFO] [stdout] 107 | let keys_offset: u64 = decode_uvarint(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | let file_size: u64 = decode_uvarint(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:109:40 [INFO] [stdout] | [INFO] [stdout] 109 | let smallest_key: Buf = decode_str(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:110:39 [INFO] [stdout] | [INFO] [stdout] 110 | let biggest_key: Buf = decode_str(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:140:5 [INFO] [stdout] | [INFO] [stdout] 140 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - return ret; [INFO] [stdout] 140 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:131:35 [INFO] [stdout] | [INFO] [stdout] 131 | encode_table_info(&mut v, &table_info); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `table_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:174:5 [INFO] [stdout] | [INFO] [stdout] 174 | return Some(Entry{removals, additions}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 - return Some(Entry{removals, additions}); [INFO] [stdout] 174 + Some(Entry{removals, additions}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:144:50 [INFO] [stdout] | [INFO] [stdout] 144 | let length: usize = try_into_size(decode_u64(&buf, pos)?)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:145:36 [INFO] [stdout] | [INFO] [stdout] 145 | let checksum: u32 = decode_u32(&buf, pos)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:158:60 [INFO] [stdout] | [INFO] [stdout] 158 | let num_removals: usize = try_into_size(decode_uvarint(&buf, pos)?)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:161:44 [INFO] [stdout] | [INFO] [stdout] 161 | let table = TableId(decode_uvarint(&buf, pos)?); [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:165:61 [INFO] [stdout] | [INFO] [stdout] 165 | let num_additions: usize = try_into_size(decode_uvarint(&buf, pos)?)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/toc.rs:168:42 [INFO] [stdout] | [INFO] [stdout] 168 | additions.push(decode_table_info(&buf, pos)?); [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 189 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return ret; [INFO] [stdout] 189 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return None; [INFO] [stdout] 204 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/toc.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 197 | if let Some(x) = frontpart.parse::().ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(x)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 197 - if let Some(x) = frontpart.parse::().ok() { [INFO] [stdout] 197 + if let Ok(x) = frontpart.parse::() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:224:5 [INFO] [stdout] | [INFO] [stdout] 224 | return Ok(ret); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 224 - return Ok(ret); [INFO] [stdout] 224 + Ok(ret) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:228:5 [INFO] [stdout] | [INFO] [stdout] 228 | / return toc.table_infos.iter().all(|(id, info)| [INFO] [stdout] 229 | | dirent_tables.get(id).map(|x| *x) == Some(info.file_size) [INFO] [stdout] 230 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 228 ~ toc.table_infos.iter().all(|(id, info)| [INFO] [stdout] 229 + dirent_tables.get(id).map(|x| *x) == Some(info.file_size) [INFO] [stdout] 230 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/toc.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | dirent_tables.get(id).map(|x| *x) == Some(info.file_size) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `dirent_tables.get(id).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:267:5 [INFO] [stdout] | [INFO] [stdout] 267 | return Ok((f, toc)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 267 - return Ok((f, toc)); [INFO] [stdout] 267 + Ok((f, toc)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/toc.rs:274:5 [INFO] [stdout] | [INFO] [stdout] 274 | return Ok(process_entry(toc, entry)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 274 - return Ok(process_entry(toc, entry)); [INFO] [stdout] 274 + Ok(process_entry(toc, entry)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / return match bound { [INFO] [stdout] 20 | | &Bound::Excluded(ref s) => x < &s, [INFO] [stdout] 21 | | &Bound::Included(ref s) => x <= &s, [INFO] [stdout] 22 | | &Bound::Unbounded => true, [INFO] [stdout] 23 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ match bound { [INFO] [stdout] 20 + &Bound::Excluded(ref s) => x < &s, [INFO] [stdout] 21 + &Bound::Included(ref s) => x <= &s, [INFO] [stdout] 22 + &Bound::Unbounded => true, [INFO] [stdout] 23 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/util.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | return match bound { [INFO] [stdout] | ____________^ [INFO] [stdout] 20 | | &Bound::Excluded(ref s) => x < &s, [INFO] [stdout] 21 | | &Bound::Included(ref s) => x <= &s, [INFO] [stdout] 22 | | &Bound::Unbounded => true, [INFO] [stdout] 23 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 19 ~ return match *bound { [INFO] [stdout] 20 ~ Bound::Excluded(ref s) => x < &s, [INFO] [stdout] 21 ~ Bound::Included(ref s) => x <= &s, [INFO] [stdout] 22 ~ Bound::Unbounded => true, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/util.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | &Bound::Excluded(ref s) => x < &s, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 20 - &Bound::Excluded(ref s) => x < &s, [INFO] [stdout] 20 + Bound::Excluded(s) => x < &s, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/util.rs:20:40 [INFO] [stdout] | [INFO] [stdout] 20 | &Bound::Excluded(ref s) => x < &s, [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/util.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | &Bound::Included(ref s) => x <= &s, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 21 - &Bound::Included(ref s) => x <= &s, [INFO] [stdout] 21 + Bound::Included(s) => x <= &s, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/util.rs:21:41 [INFO] [stdout] | [INFO] [stdout] 21 | &Bound::Included(ref s) => x <= &s, [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / return match bound { [INFO] [stdout] 28 | | &Bound::Excluded(ref s) => x > &s, [INFO] [stdout] 29 | | &Bound::Included(ref s) => x >= &s, [INFO] [stdout] 30 | | &Bound::Unbounded => true, [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 ~ match bound { [INFO] [stdout] 28 + &Bound::Excluded(ref s) => x > &s, [INFO] [stdout] 29 + &Bound::Included(ref s) => x >= &s, [INFO] [stdout] 30 + &Bound::Unbounded => true, [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/util.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | return match bound { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | &Bound::Excluded(ref s) => x > &s, [INFO] [stdout] 29 | | &Bound::Included(ref s) => x >= &s, [INFO] [stdout] 30 | | &Bound::Unbounded => true, [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 27 ~ return match *bound { [INFO] [stdout] 28 ~ Bound::Excluded(ref s) => x > &s, [INFO] [stdout] 29 ~ Bound::Included(ref s) => x >= &s, [INFO] [stdout] 30 ~ Bound::Unbounded => true, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/util.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | &Bound::Excluded(ref s) => x > &s, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 28 - &Bound::Excluded(ref s) => x > &s, [INFO] [stdout] 28 + Bound::Excluded(s) => x > &s, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/util.rs:28:40 [INFO] [stdout] | [INFO] [stdout] 28 | &Bound::Excluded(ref s) => x > &s, [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/util.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | &Bound::Included(ref s) => x >= &s, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 29 - &Bound::Included(ref s) => x >= &s, [INFO] [stdout] 29 + Bound::Included(s) => x >= &s, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/util.rs:29:41 [INFO] [stdout] | [INFO] [stdout] 29 | &Bound::Included(ref s) => x >= &s, [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/util.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / match x { [INFO] [stdout] 36 | | &Bound::Excluded(ref b) => Bound::Excluded(b), [INFO] [stdout] 37 | | &Bound::Included(ref b) => Bound::Included(b), [INFO] [stdout] 38 | | &Bound::Unbounded => Bound::Unbounded, [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 35 ~ match *x { [INFO] [stdout] 36 ~ Bound::Excluded(ref b) => Bound::Excluded(b), [INFO] [stdout] 37 ~ Bound::Included(ref b) => Bound::Included(b), [INFO] [stdout] 38 ~ Bound::Unbounded => Bound::Unbounded, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/util.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | &Bound::Excluded(ref b) => Bound::Excluded(b), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 36 - &Bound::Excluded(ref b) => Bound::Excluded(b), [INFO] [stdout] 36 + Bound::Excluded(b) => Bound::Excluded(b), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/util.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | &Bound::Included(ref b) => Bound::Included(b), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 37 - &Bound::Included(ref b) => Bound::Included(b), [INFO] [stdout] 37 + Bound::Included(b) => Bound::Included(b), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return Ok(()); [INFO] [stdout] 67 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(Store::make_existing(threshold, dir.to_string(), toc_file, toc, MemStore::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(Store::make_existing(threshold, dir.to_string(), toc_file, toc, MemStore::new())); [INFO] [stdout] 75 + Ok(Store::make_existing(threshold, dir.to_string(), toc_file, toc, MemStore::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | / return Store{ [INFO] [stdout] 80 | | memstores: vec![MemStore::new(), ms], [INFO] [stdout] 81 | | threshold: threshold, [INFO] [stdout] ... | [INFO] [stdout] 85 | | toc: toc, [INFO] [stdout] 86 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 ~ Store{ [INFO] [stdout] 80 + memstores: vec![MemStore::new(), ms], [INFO] [stdout] 81 + threshold: threshold, [INFO] [stdout] 82 + [INFO] [stdout] 83 + directory: directory, [INFO] [stdout] 84 + toc_file: toc_file, [INFO] [stdout] 85 + toc: toc, [INFO] [stdout] 86 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return Ok(false); [INFO] [stdout] 96 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return Ok(false); [INFO] [stdout] 106 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | return self.consider_split(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return self.consider_split(); [INFO] [stdout] 113 + self.consider_split() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return Ok(false); [INFO] [stdout] 123 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return Ok(()); [INFO] [stdout] 135 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return Ok(()); [INFO] [stdout] 148 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return Ok(()); [INFO] [stdout] 211 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 152 | if self.toc.level_infos.get(&0).map_or(false, |lz| lz.len() > 4) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 152 - if self.toc.level_infos.get(&0).map_or(false, |lz| lz.len() > 4) { [INFO] [stdout] 152 + if self.toc.level_infos.get(&0).is_some_and(|lz| lz.len() > 4) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 155 | = self.toc.level_infos.get(&0).unwrap().iter().rev().skip(1).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.toc.level_infos.get(&0).unwrap().iter().rev().skip(1).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:186:44 [INFO] [stdout] | [INFO] [stdout] 186 | let mut smallest_overlap = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 186 - let mut smallest_overlap = usize::max_value(); [INFO] [stdout] 186 + let mut smallest_overlap = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:203:45 [INFO] [stdout] | [INFO] [stdout] 203 | assert!(smallest_overlap != usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 203 - assert!(smallest_overlap != usize::max_value()); [INFO] [stdout] 203 + assert!(smallest_overlap != usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 236 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 236 - return Ok(()); [INFO] [stdout] 236 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:308:13 [INFO] [stdout] | [INFO] [stdout] 308 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 308 - return Ok(()); [INFO] [stdout] 308 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:219:33 [INFO] [stdout] | [INFO] [stdout] 219 | assert!(if level == 0 { tables.len() > 0 } else { tables.len() == 1 }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tables.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:293:19 [INFO] [stdout] | [INFO] [stdout] 293 | = tables.iter().chain(lower_overlapping_ids.iter()).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `tables.iter().chain(lower_overlapping_ids.iter()).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | return !(!above_lower_bound(&x.biggest_key, &y.lower) || !below_upper_bound(&x.smallest_key, &y.upper)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 313 - return !(!above_lower_bound(&x.biggest_key, &y.lower) || !below_upper_bound(&x.smallest_key, &y.upper)); [INFO] [stdout] 313 + !(!above_lower_bound(&x.biggest_key, &y.lower) || !below_upper_bound(&x.smallest_key, &y.upper)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - return false; [INFO] [stdout] 324 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 328 | return !(x.biggest_key < y.smallest_key || y.biggest_key < x.smallest_key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 - return !(x.biggest_key < y.smallest_key || y.biggest_key < x.smallest_key); [INFO] [stdout] 328 + !(x.biggest_key < y.smallest_key || y.biggest_key < x.smallest_key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:343:13 [INFO] [stdout] | [INFO] [stdout] 343 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 343 - return ret; [INFO] [stdout] 343 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:345:13 [INFO] [stdout] | [INFO] [stdout] 345 | return Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 345 - return Vec::new(); [INFO] [stdout] 345 + Vec::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:353:9 [INFO] [stdout] | [INFO] [stdout] 353 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 353 - return Ok(()); [INFO] [stdout] 353 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 372 - return Ok(()); [INFO] [stdout] 372 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:362:100 [INFO] [stdout] | [INFO] [stdout] 362 | let (keys_offset, file_size, smallest, biggest) = flush_to_disk(&self.directory, table_id, &ms)?; [INFO] [stdout] | ^^^ help: change this to: `ms` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:404:9 [INFO] [stdout] | [INFO] [stdout] 404 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 404 - return Ok(false); [INFO] [stdout] 404 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/lib.rs:379:27 [INFO] [stdout] | [INFO] [stdout] 379 | return Ok(match m { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 380 | | &Mutation::Set(_) => true, [INFO] [stdout] 381 | | &Mutation::Delete => false, [INFO] [stdout] 382 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 379 ~ return Ok(match *m { [INFO] [stdout] 380 ~ Mutation::Set(_) => true, [INFO] [stdout] 381 ~ Mutation::Delete => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:437:9 [INFO] [stdout] | [INFO] [stdout] 437 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - return Ok(None); [INFO] [stdout] 437 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/lib.rs:413:27 [INFO] [stdout] | [INFO] [stdout] 413 | return Ok(match m { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 414 | | &Mutation::Set(ref x) => Some(x.clone()), [INFO] [stdout] 415 | | &Mutation::Delete => None, [INFO] [stdout] 416 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 413 ~ return Ok(match *m { [INFO] [stdout] 414 ~ Mutation::Set(ref x) => Some(x.clone()), [INFO] [stdout] 415 ~ Mutation::Delete => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/lib.rs:414:21 [INFO] [stdout] | [INFO] [stdout] 414 | &Mutation::Set(ref x) => Some(x.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 414 - &Mutation::Set(ref x) => Some(x.clone()), [INFO] [stdout] 414 + Mutation::Set(x) => Some(x.clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:447:9 [INFO] [stdout] | [INFO] [stdout] 447 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 447 - return Ok(()); [INFO] [stdout] 447 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:467:73 [INFO] [stdout] | [INFO] [stdout] 467 | self.add_table_iter_to_iters(&mut iters, *table_id, &interval, direction)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:511:9 [INFO] [stdout] | [INFO] [stdout] 511 | return self.range_directed(interval, Direction::Forward); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 511 - return self.range_directed(interval, Direction::Forward); [INFO] [stdout] 511 + self.range_directed(interval, Direction::Forward) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:516:9 [INFO] [stdout] | [INFO] [stdout] 516 | return self.range_directed(interval, Direction::Backward); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 516 - return self.range_directed(interval, Direction::Backward); [INFO] [stdout] 516 + self.range_directed(interval, Direction::Backward) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:571:9 [INFO] [stdout] | [INFO] [stdout] 571 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 571 - return ret; [INFO] [stdout] 571 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:588:13 [INFO] [stdout] | [INFO] [stdout] 588 | return ts; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 588 - return ts; [INFO] [stdout] 588 + ts [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:596:13 [INFO] [stdout] | [INFO] [stdout] 596 | return self.store.take().map(|_| ()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 596 - return self.store.take().map(|_| ()); [INFO] [stdout] 596 + self.store.take().map(|_| ()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:599:13 [INFO] [stdout] | [INFO] [stdout] 599 | return self.store.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 599 - return self.store.as_mut().unwrap(); [INFO] [stdout] 599 + self.store.as_mut().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:604:9 [INFO] [stdout] | [INFO] [stdout] 604 | return s.as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 604 - return s.as_bytes(); [INFO] [stdout] 604 + s.as_bytes() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/lib.rs:662:63 [INFO] [stdout] | [INFO] [stdout] 662 | kv.put(b(&i.to_string()), b(&format!("value-{}", i.to_string()))).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/lib.rs:750:16 [INFO] [stdout] | [INFO] [stdout] 750 | if high % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `high.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/lib.rs:767:16 [INFO] [stdout] | [INFO] [stdout] 767 | if low % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `low.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.88s [INFO] running `Command { std: "docker" "inspect" "ee93dd74093f45150d91fda3f8ae2039bb0cfbba4db65df788b94b93dbe22963", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee93dd74093f45150d91fda3f8ae2039bb0cfbba4db65df788b94b93dbe22963", kill_on_drop: false }` [INFO] [stdout] ee93dd74093f45150d91fda3f8ae2039bb0cfbba4db65df788b94b93dbe22963