[INFO] fetching crate ngxav 0.6.3... [INFO] linting ngxav-0.6.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ngxav 0.6.3 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate ngxav 0.6.3 [INFO] finished tweaking crates.io crate ngxav 0.6.3 [INFO] tweaked toml for crates.io crate ngxav 0.6.3 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ngxav 0.6.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ngxav 0.6.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anstyle v1.0.5 [INFO] [stderr] Downloaded either v1.10.0 [INFO] [stderr] Downloaded chrono v0.4.33 [INFO] [stderr] Downloaded regex-automata v0.4.5 [INFO] [stderr] Downloaded woothee v0.13.0 [INFO] [stderr] Downloaded isbot v0.1.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 389444921d5e79755e281034fb91b5ff040ba3a7d5e3682df27aca9943d449c0 [INFO] running `Command { std: "docker" "start" "-a" "389444921d5e79755e281034fb91b5ff040ba3a7d5e3682df27aca9943d449c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "389444921d5e79755e281034fb91b5ff040ba3a7d5e3682df27aca9943d449c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "389444921d5e79755e281034fb91b5ff040ba3a7d5e3682df27aca9943d449c0", kill_on_drop: false }` [INFO] [stdout] 389444921d5e79755e281034fb91b5ff040ba3a7d5e3682df27aca9943d449c0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b17d677cfb6bede3a067e442176f25390474c5a47a5d1e33ccdf8b25ccc21d6a [INFO] running `Command { std: "docker" "start" "-a" "b17d677cfb6bede3a067e442176f25390474c5a47a5d1e33ccdf8b25ccc21d6a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.5 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling woothee v0.13.0 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking chrono v0.4.33 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking isbot v0.1.3 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking ngxav v0.6.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `atty::Stream` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use atty::Stream; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `utils::read_folder::read_folder` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use utils::read_folder::read_folder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::structs::UserAgentParseResult` [INFO] [stdout] --> src/utils/keep_line.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::structs::UserAgentParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `atty::Stream` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use atty::Stream; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `utils::read_folder::read_folder` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use utils::read_folder::read_folder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parse_line` [INFO] [stdout] --> src/utils/session_analytics.rs:2:20 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::utils::{parse_line, parse_nginx_time_format, sessionize::sessionize}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lazy_static::lazy_static` [INFO] [stdout] --> src/utils/unique_ips_only.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use lazy_static::lazy_static; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:107:8 [INFO] [stdout] | [INFO] [stdout] 107 | if (!args.unique.is_none() && args.unique == Some(true)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 107 - if (!args.unique.is_none() && args.unique == Some(true)) { [INFO] [stdout] 107 + if !args.unique.is_none() && args.unique == Some(true) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/./structs/AnalyticsResult.rs` [INFO] [stdout] --> src/./structs/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod AnalyticsResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ first loaded here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/../structs/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod AnalyticsResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] = note: `#[warn(clippy::duplicate_mod)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/./structs/Args.rs` [INFO] [stdout] --> src/./structs/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod Args; [INFO] [stdout] | ^^^^^^^^^^^^^ first loaded here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/../structs/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod Args; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/./structs/LineParseResult.rs` [INFO] [stdout] --> src/./structs/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod LineParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ first loaded here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/../structs/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod LineParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/./structs/UserAgentParseResult.rs` [INFO] [stdout] --> src/./structs/mod.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | pub mod UserAgentParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ first loaded here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/../structs/mod.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | pub mod UserAgentParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/./structs/mod.rs` [INFO] [stdout] --> src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / #[path = "./structs/mod.rs"] [INFO] [stdout] 14 | | mod structs; [INFO] [stdout] | |____________^ first loaded here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/generate_analytics.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #[path = "../structs/mod.rs"] [INFO] [stdout] 2 | | mod structs; [INFO] [stdout] | |____________^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/keep_line.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / #[path = "../structs/mod.rs"] [INFO] [stdout] 7 | | mod structs; [INFO] [stdout] | |____________^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/parse_line.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #[path = "../structs/mod.rs"] [INFO] [stdout] 2 | | mod structs; [INFO] [stdout] | |____________^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/parse_user_agent.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #[path = "../structs/mod.rs"] [INFO] [stdout] 2 | | mod structs; [INFO] [stdout] | |____________^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/sort_by_body_size.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #[path = "../structs/mod.rs"] [INFO] [stdout] 2 | | mod structs; [INFO] [stdout] | |____________^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/unique_ips_only.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #[path = "../structs/mod.rs"] [INFO] [stdout] 2 | | mod structs; [INFO] [stdout] | |____________^ loaded again here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::structs::UserAgentParseResult` [INFO] [stdout] --> src/utils/keep_line.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::structs::UserAgentParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parse_line` [INFO] [stdout] --> src/utils/session_analytics.rs:2:20 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::utils::{parse_line, parse_nginx_time_format, sessionize::sessionize}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lazy_static::lazy_static` [INFO] [stdout] --> src/utils/unique_ips_only.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use lazy_static::lazy_static; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:107:8 [INFO] [stdout] | [INFO] [stdout] 107 | if (!args.unique.is_none() && args.unique == Some(true)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 107 - if (!args.unique.is_none() && args.unique == Some(true)) { [INFO] [stdout] 107 + if !args.unique.is_none() && args.unique == Some(true) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/./structs/AnalyticsResult.rs` [INFO] [stdout] --> src/./structs/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod AnalyticsResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ first loaded here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/../structs/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod AnalyticsResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] = note: `#[warn(clippy::duplicate_mod)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/./structs/Args.rs` [INFO] [stdout] --> src/./structs/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod Args; [INFO] [stdout] | ^^^^^^^^^^^^^ first loaded here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/../structs/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod Args; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/./structs/LineParseResult.rs` [INFO] [stdout] --> src/./structs/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod LineParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ first loaded here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/../structs/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod LineParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/./structs/UserAgentParseResult.rs` [INFO] [stdout] --> src/./structs/mod.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | pub mod UserAgentParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ first loaded here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/../structs/mod.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | pub mod UserAgentParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | loaded again here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/./structs/mod.rs` [INFO] [stdout] --> src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / #[path = "./structs/mod.rs"] [INFO] [stdout] 14 | | mod structs; [INFO] [stdout] | |____________^ first loaded here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/generate_analytics.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #[path = "../structs/mod.rs"] [INFO] [stdout] 2 | | mod structs; [INFO] [stdout] | |____________^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/keep_line.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / #[path = "../structs/mod.rs"] [INFO] [stdout] 7 | | mod structs; [INFO] [stdout] | |____________^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/parse_line.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #[path = "../structs/mod.rs"] [INFO] [stdout] 2 | | mod structs; [INFO] [stdout] | |____________^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/parse_user_agent.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #[path = "../structs/mod.rs"] [INFO] [stdout] 2 | | mod structs; [INFO] [stdout] | |____________^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/sort_by_body_size.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #[path = "../structs/mod.rs"] [INFO] [stdout] 2 | | mod structs; [INFO] [stdout] | |____________^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/utils/unique_ips_only.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #[path = "../structs/mod.rs"] [INFO] [stdout] 2 | | mod structs; [INFO] [stdout] | |____________^ loaded again here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/utils/parse_line.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut fields = line.split(" ").collect::>(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `key` is never read [INFO] [stdout] --> src/utils/sessionize.rs:26:31 [INFO] [stdout] | [INFO] [stdout] 26 | let mut key: String = "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/utils/sort_by_body_size.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | let mut parsed_lines = log_selection.clone(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/utils/unique_ips_only.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | let mut u: String = "".to_string(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `u` [INFO] [stdout] --> src/utils/unique_ips_only.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | let mut u: String = "".to_string(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_u` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AnalyticsResult` is never constructed [INFO] [stdout] --> src/./structs/AnalyticsResult.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct AnalyticsResult<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TopResult` is never constructed [INFO] [stdout] --> src/./structs/AnalyticsResult.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TopResult<'a> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `request_time` is never read [INFO] [stdout] --> src/./structs/LineParseResult.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct LineParseResult<'a> { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub request_time: i64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LineParseResult` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LineParseResult` is never constructed [INFO] [stdout] --> src/utils/../structs/LineParseResult.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct LineParseResult<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UserAgentParseResult` is never constructed [INFO] [stdout] --> src/utils/../structs/UserAgentParseResult.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct UserAgentParseResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AnalyticsResult` is never constructed [INFO] [stdout] --> src/utils/../structs/AnalyticsResult.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct AnalyticsResult<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TopResult` is never constructed [INFO] [stdout] --> src/utils/../structs/AnalyticsResult.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TopResult<'a> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_folder` is never used [INFO] [stdout] --> src/utils/read_folder.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn read_folder(file_path: String) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `average_request_count` and `average_request_length` are never read [INFO] [stdout] --> src/utils/session_analytics.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 9 | struct SessionAnalysisStats { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | average_request_count: i64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 13 | average_request_length: i64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/generate_analytics.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if stats.top_requests.contains_key(&parsed_line.request) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!stats.top_requests.contains_key(&parsed_line.request)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/generate_analytics.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if stats.top_hosts.contains_key(&parsed_line.host) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!stats.top_hosts.contains_key(&parsed_line.host)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/generate_analytics.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if stats.top_ips.contains_key(&parsed_line.ip_address) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!stats.top_ips.contains_key(&parsed_line.ip_address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/generate_analytics.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | return ans; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return ans; [INFO] [stdout] 98 + ans [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/utils/generate_analytics.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | let rel_data: Vec<&structs::AnalyticsResult::TopResult>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `rel_data` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 87 ~ [INFO] [stdout] 88 ~ let rel_data: Vec<&structs::AnalyticsResult::TopResult> = if data.len() < n { [INFO] [stdout] 89 ~ data[0..data.len()].to_vec() [INFO] [stdout] 90 | } else { [INFO] [stdout] 91 ~ data[0..n].to_vec() [INFO] [stdout] 92 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/generate_analytics.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | return format!("{num} KB", num = f / 1024); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return format!("{num} KB", num = f / 1024); [INFO] [stdout] 109 + format!("{num} KB", num = f / 1024) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | if !ARGS.search.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.search.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | if !ARGS.plain_text.is_none() && ARGS.plain_text == Some(true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.plain_text.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | if !ARGS.host.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.host.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 38 | if !ARGS.request.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.request.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 45 | if !ARGS.http_status.is_none() && parsed_line.status != ARGS.http_status.as_ref().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.http_status.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | if !ARGS.referer.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.referer.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 88 | if !ARGS.start_date.is_none() && ARGS.end_date.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.start_date.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | if !ARGS.end_date.is_none() && ARGS.start_date.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.end_date.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 102 | if !ARGS.start_date.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.start_date.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 103 | && !ARGS.end_date.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.end_date.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:117:8 [INFO] [stdout] | [INFO] [stdout] 117 | if !ARGS.last.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.last.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/keep_line.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return true; [INFO] [stdout] 123 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/keep_line.rs:28:39 [INFO] [stdout] | [INFO] [stdout] 28 | if !SEARCH_REGEX.is_match(&parsed_line.full_text) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `parsed_line.full_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/keep_line.rs:76:34 [INFO] [stdout] | [INFO] [stdout] 76 | if ARGS.bot.is_some() && ARGS.bot.unwrap() == false && parsed_ua.isBot == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!ARGS.bot.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/utils/keep_line.rs:76:64 [INFO] [stdout] | [INFO] [stdout] 76 | if ARGS.bot.is_some() && ARGS.bot.unwrap() == false && parsed_ua.isBot == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_ua.isBot` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/utils/keep_line.rs:79:34 [INFO] [stdout] | [INFO] [stdout] 79 | if ARGS.bot.is_some() && ARGS.bot.unwrap() == true && parsed_ua.isBot == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.bot.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/keep_line.rs:79:63 [INFO] [stdout] | [INFO] [stdout] 79 | if ARGS.bot.is_some() && ARGS.bot.unwrap() == true && parsed_ua.isBot == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!parsed_ua.isBot` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/keep_line.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if cm == false { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `!cm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/keep_line.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | / if !ARGS.start_date.is_none() && ARGS.end_date.is_none() { [INFO] [stdout] 89 | | if parse_nginx_time_format(&parsed_line.time) [INFO] [stdout] 90 | | < parse_input_time(&ARGS.start_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] ... | [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 88 ~ if !ARGS.start_date.is_none() && ARGS.end_date.is_none() [INFO] [stdout] 89 ~ && parse_nginx_time_format(&parsed_line.time) [INFO] [stdout] 90 | < parse_input_time(&ARGS.start_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] 91 | { [INFO] [stdout] 92 | return false; [INFO] [stdout] 93 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/keep_line.rs:90:32 [INFO] [stdout] | [INFO] [stdout] 90 | < parse_input_time(&ARGS.start_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ARGS.start_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/keep_line.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | / if !ARGS.end_date.is_none() && ARGS.start_date.is_none() { [INFO] [stdout] 96 | | if parse_nginx_time_format(&parsed_line.time) [INFO] [stdout] 97 | | > parse_input_time(&ARGS.end_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] ... | [INFO] [stdout] 101 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 95 ~ if !ARGS.end_date.is_none() && ARGS.start_date.is_none() [INFO] [stdout] 96 ~ && parse_nginx_time_format(&parsed_line.time) [INFO] [stdout] 97 | > parse_input_time(&ARGS.end_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] 98 | { [INFO] [stdout] 99 | return false; [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/keep_line.rs:97:32 [INFO] [stdout] | [INFO] [stdout] 97 | > parse_input_time(&ARGS.end_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ARGS.end_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/keep_line.rs:105:32 [INFO] [stdout] | [INFO] [stdout] 105 | > parse_input_time(&ARGS.end_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ARGS.end_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/keep_line.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | < parse_input_time(&ARGS.start_date.as_ref().unwrap(), tz.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ARGS.start_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils/keep_line.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | epoch_seconds = epoch_seconds - 60 * ARGS.last.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `epoch_seconds -= 60 * ARGS.last.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/parse_line.rs:33:29 [INFO] [stdout] | [INFO] [stdout] 33 | body_bytes_sent: if !fields[10].to_string().parse::().is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fields[10].to_string().parse::().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/parse_line.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / return crate::structs::LineParseResult::LineParseResult { [INFO] [stdout] 27 | | ip_address: fields[0], [INFO] [stdout] 28 | | time: fields[3].replace("[", "") + " " + &fields[4].replace("]", ""), [INFO] [stdout] 29 | | host: fields[5], [INFO] [stdout] ... | [INFO] [stdout] 40 | | full_text: line, [INFO] [stdout] 41 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 ~ crate::structs::LineParseResult::LineParseResult { [INFO] [stdout] 27 + ip_address: fields[0], [INFO] [stdout] 28 + time: fields[3].replace("[", "") + " " + &fields[4].replace("]", ""), [INFO] [stdout] 29 + host: fields[5], [INFO] [stdout] 30 + referer: fields[11], [INFO] [stdout] 31 + request: matches[1], [INFO] [stdout] 32 + status: fields[9], [INFO] [stdout] 33 + body_bytes_sent: if !fields[10].to_string().parse::().is_err() { [INFO] [stdout] 34 + !fields[10].to_string().parse::().unwrap() [INFO] [stdout] 35 + } else { [INFO] [stdout] 36 + 0 [INFO] [stdout] 37 + }, [INFO] [stdout] 38 + request_time: 0, [INFO] [stdout] 39 + user_agent: matches[3], [INFO] [stdout] 40 + full_text: line, [INFO] [stdout] 41 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/parse_user_agent.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / return crate::structs::UserAgentParseResult::UserAgentParseResult { [INFO] [stdout] 26 | | operating_system: resultu.os.to_string(), [INFO] [stdout] 27 | | category: resultu.category.to_string(), [INFO] [stdout] 28 | | isBot: bots.is_bot(ua), [INFO] [stdout] 29 | | browser: resultu.name.to_string(), [INFO] [stdout] 30 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 ~ crate::structs::UserAgentParseResult::UserAgentParseResult { [INFO] [stdout] 26 + operating_system: resultu.os.to_string(), [INFO] [stdout] 27 + category: resultu.category.to_string(), [INFO] [stdout] 28 + isBot: bots.is_bot(ua), [INFO] [stdout] 29 + browser: resultu.name.to_string(), [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/read_folder.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return lines; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return lines; [INFO] [stdout] 53 + lines [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:39:54 [INFO] [stdout] | [INFO] [stdout] 39 | ... if isUnique.is_some() && isUnique.unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `isUnique.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:40:33 [INFO] [stdout] | [INFO] [stdout] 40 | / ... if !occurrences.contains_key(&ip) { [INFO] [stdout] 41 | | ... println!("{}", line.clone() + "\n"); [INFO] [stdout] 42 | | ... occurrences.insert(ip, true); [INFO] [stdout] 43 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 ~ occurrences.entry(ip).or_insert_with(|| { [INFO] [stdout] 41 + println!("{}", line.clone() + "\n"); [INFO] [stdout] 42 + true [INFO] [stdout] 43 + }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:57:32 [INFO] [stdout] | [INFO] [stdout] 57 | for line in reader.flatten() { [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | for line in reader.flatten() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:60:46 [INFO] [stdout] | [INFO] [stdout] 60 | if isUnique.is_some() && isUnique.unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `isUnique.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | / if !occurrences.contains_key(&ip) { [INFO] [stdout] 62 | | println!("{}", line.clone() + "\n"); [INFO] [stdout] 63 | | occurrences.insert(ip, true); [INFO] [stdout] 64 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 61 ~ occurrences.entry(ip).or_insert_with(|| { [INFO] [stdout] 62 + println!("{}", line.clone() + "\n"); [INFO] [stdout] 63 + true [INFO] [stdout] 64 + }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/session_analytics.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 66 | if host_path.len() == 0 || host_path[host_path.len() - 1] != a { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `host_path.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils/session_analytics.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | / ips_text = ips_text [INFO] [stdout] 85 | | + format!( [INFO] [stdout] 86 | | "- {ip} - {num}\n", [INFO] [stdout] 87 | | ip = s.ip_address, [INFO] [stdout] ... | [INFO] [stdout] 90 | | .as_str(); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 84 ~ ips_text += format!( [INFO] [stdout] 85 + "- {ip} - {num}\n", [INFO] [stdout] 86 + ip = s.ip_address, [INFO] [stdout] 87 + num = s.sessions.len() [INFO] [stdout] 88 + ) [INFO] [stdout] 89 ~ .as_str(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils/session_analytics.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | / host_text = host_text [INFO] [stdout] 102 | | + format!( [INFO] [stdout] 103 | | "- {pe} [{cnt}]\n", [INFO] [stdout] 104 | | pe = path_entry [INFO] [stdout] ... | [INFO] [stdout] 111 | | .as_str(); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 101 ~ host_text += format!( [INFO] [stdout] 102 + "- {pe} [{cnt}]\n", [INFO] [stdout] 103 + pe = path_entry [INFO] [stdout] 104 + .path [INFO] [stdout] 105 + .replace(",", " -->") [INFO] [stdout] 106 + .replace("[", "") [INFO] [stdout] 107 + .replace("]", ""), [INFO] [stdout] 108 + cnt = path_entry.count [INFO] [stdout] 109 + ) [INFO] [stdout] 110 ~ .as_str(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/session_analytics.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | return ans + "]"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return ans + "]"; [INFO] [stdout] 144 + ans + "]" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/session_unique.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | if session.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!session.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/session_unique.rs:19:65 [INFO] [stdout] | [INFO] [stdout] 19 | out.par_sort_by_key(|a| parse_nginx_time_format(&parse_line(&a).time).timestamp()); [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `m` after checking its variant with `is_some` [INFO] [stdout] --> src/utils/sessionize.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 29 | if m.is_some() { [INFO] [stdout] | -------------- help: try: `if let Some() = m` [INFO] [stdout] 30 | key = m.unwrap().as_str().to_string(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sessionize.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | return o.to_owned().into_values().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return o.to_owned().into_values().collect(); [INFO] [stdout] 85 + o.to_owned().into_values().collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sessionize.rs:23:24 [INFO] [stdout] | [INFO] [stdout] 23 | r = Regex::new(&u).unwrap(); [INFO] [stdout] | ^^ help: change this to: `u` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/utils/sessionize.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | / let mut l = Vec::new(); [INFO] [stdout] 41 | | l.push(parsed_line.full_text.to_string()); [INFO] [stdout] | |__________________________________________________________^ help: consider using the `vec![]` macro: `let l = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/utils/sessionize.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | / let mut t = Vec::new(); [INFO] [stdout] 43 | | t.push(time); [INFO] [stdout] | |_____________________________^ help: consider using the `vec![]` macro: `let t = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/utils/sessionize.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | for l in &entry.times { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, l) in entry.times.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `m` after checking its variant with `is_some` [INFO] [stdout] --> src/utils/sessions_from_ip.rs:23:23 [INFO] [stdout] | [INFO] [stdout] 22 | if m.is_some() { [INFO] [stdout] | -------------- help: try: `if let Some() = m` [INFO] [stdout] 23 | key = m.unwrap().clone().as_str().to_string(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/sessions_from_ip.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | if session.len() != 0 && session.len() != 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!session.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/sessions_from_ip.rs:37:28 [INFO] [stdout] | [INFO] [stdout] 37 | if host_path.len() == 0 || host_path[host_path.len() - 1] != h { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `host_path.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/utils/sessions_from_ip.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | for path in host_paths { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, path) in host_paths.into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sessions_from_ip.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | return ans + "]"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return ans + "]"; [INFO] [stdout] 70 + ans + "]" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/sort_by_body_size.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | if occurrences.contains_key(&line.request) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!occurrences.contains_key(&line.request)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/utils/sort_by_body_size.rs:16:55 [INFO] [stdout] | [INFO] [stdout] 16 | final_lines.par_sort_by_key(|a: &LineParseResult| a.body_bytes_sent.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `a.body_bytes_sent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/utils/sort_by_body_size.rs:18:37 [INFO] [stdout] | [INFO] [stdout] 18 | final_lines.par_sort_by_key(|a| a.body_bytes_sent.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `a.body_bytes_sent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sort_by_body_size.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return format!("{num} KB", num = f / 1024); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return format!("{num} KB", num = f / 1024); [INFO] [stdout] 44 + format!("{num} KB", num = f / 1024) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sort_by_date.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return (0, log_selection.len() - 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return (0, log_selection.len() - 1); [INFO] [stdout] 56 + (0, log_selection.len() - 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/sort_by_date.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | if log_selection.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `log_selection.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | &log_selection, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `log_selection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | &log_selection, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `log_selection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:34:30 [INFO] [stdout] | [INFO] [stdout] 34 | parse_input_time(&start_date.as_ref().unwrap(), tz.clone()).timestamp(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `start_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:35:30 [INFO] [stdout] | [INFO] [stdout] 35 | parse_input_time(&end_date.as_ref().unwrap(), tz.clone()).timestamp(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `end_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | &log_selection, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `log_selection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:42:30 [INFO] [stdout] | [INFO] [stdout] 42 | parse_input_time(&end_date.as_ref().unwrap(), tz).timestamp(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `end_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | &log_selection, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `log_selection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 52 | parse_input_time(&start_date.as_ref().unwrap(), tz).timestamp(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `start_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sort_by_date.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | return (st, en + st); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return (st, en + st); [INFO] [stdout] 71 + (st, en + st) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils/sort_by_date.rs:59:19 [INFO] [stdout] | [INFO] [stdout] 59 | fn b_search(logs: &Vec, start_time_range: i64, end_time_range: i64) -> (usize, usize) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 59 - fn b_search(logs: &Vec, start_time_range: i64, end_time_range: i64) -> (usize, usize) { [INFO] [stdout] 59 + fn b_search(logs: &[String], start_time_range: i64, end_time_range: i64) -> (usize, usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sort_by_date.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return parse_nginx_time_format(&t).timestamp() < end_time_range; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return parse_nginx_time_format(&t).timestamp() < end_time_range; [INFO] [stdout] 68 + parse_nginx_time_format(&t).timestamp() < end_time_range [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `m` after checking its variant with `is_some` [INFO] [stdout] --> src/utils/unique_ips_only.rs:22:36 [INFO] [stdout] | [INFO] [stdout] 21 | if m.is_some() { [INFO] [stdout] | -------------- help: try: `if let Some() = m` [INFO] [stdout] 22 | occurrences.insert(m.unwrap().as_str(), line); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/unique_ips_only.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return occurrences.into_iter().map(|(_, v)| v).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return occurrences.into_iter().map(|(_, v)| v).collect(); [INFO] [stdout] 30 + occurrences.into_iter().map(|(_, v)| v).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/unique_ips_only.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | if occurrences.contains_key(&line.ip_address) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!occurrences.contains_key(&line.ip_address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/utils/unique_ips_only.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | return occurrences.into_iter().map(|(_, v)| v).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `occurrences.into_values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | / return stdin [INFO] [stdout] 41 | | .lock() [INFO] [stdout] 42 | | .lines() [INFO] [stdout] 43 | | .map(|line| line.expect("Failed to read line")) [INFO] [stdout] 44 | | .collect(); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ stdin [INFO] [stdout] 41 + .lock() [INFO] [stdout] 42 + .lines() [INFO] [stdout] 43 + .map(|line| line.expect("Failed to read line")) [INFO] [stdout] 44 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | && !args.conserve_memory.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.conserve_memory.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | if (!args.unique.is_none() && args.unique == Some(true)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.unique.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:110:8 [INFO] [stdout] | [INFO] [stdout] 110 | if !args.analytics.is_none() && args.analytics == Some(true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.analytics.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:112:15 [INFO] [stdout] | [INFO] [stdout] 112 | } else if !args.session_analytics.is_none() && args.session_analytics == Some(true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.session_analytics.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:114:15 [INFO] [stdout] | [INFO] [stdout] 114 | } else if !args.large.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `args.large.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:116:15 [INFO] [stdout] | [INFO] [stdout] 116 | } else if !args.ip_ses.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.ip_ses.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:118:15 [INFO] [stdout] | [INFO] [stdout] 118 | } else if !args.session_unqiue.is_none() && args.session_unqiue == Some(true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.session_unqiue.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.thread_count` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 48 | if args.thread_count.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = args.thread_count` [INFO] [stdout] 49 | rayon::ThreadPoolBuilder::new() [INFO] [stdout] 50 | .num_threads(args.thread_count.unwrap().try_into().expect("WOMP WOMP")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.file` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:59:46 [INFO] [stdout] | [INFO] [stdout] 54 | if args.file.is_some() [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 59 | if let Ok(lines) = read_line_by_line(args.file.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.file` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:85:17 [INFO] [stdout] | [INFO] [stdout] 82 | if args.file.is_some() && metadata(args.file.clone().unwrap()).unwrap().is_dir() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 85 | args.file.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.large` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:115:58 [INFO] [stdout] | [INFO] [stdout] 114 | } else if !args.large.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] 115 | utils::sort_by_body_size::sort_by_body_size(kel, args.large.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | && args.conserve_memory.unwrap() == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.conserve_memory.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/main.rs:61:31 [INFO] [stdout] | [INFO] [stdout] 61 | for line in lines.flatten() { [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/main.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | for line in lines.flatten() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:64:49 [INFO] [stdout] | [INFO] [stdout] 64 | if args.unique.is_some() && args.unique.unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.unique.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/main.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 65 | / if !occurrences.contains_key(&ip) { [INFO] [stdout] 66 | | println!("{}", line.clone() + "\n"); [INFO] [stdout] 67 | | occurrences.insert(ip, true); [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 ~ occurrences.entry(ip).or_insert_with(|| { [INFO] [stdout] 66 + println!("{}", line.clone() + "\n"); [INFO] [stdout] 67 + true [INFO] [stdout] 68 + }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:79:31 [INFO] [stdout] | [INFO] [stdout] 79 | if args.file.is_none() && stdin.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stdin.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:83:46 [INFO] [stdout] | [INFO] [stdout] 83 | if args.conserve_memory.is_some() && args.conserve_memory.unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.conserve_memory.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:90:38 [INFO] [stdout] | [INFO] [stdout] 90 | } else if args.file.is_none() && stdin.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!stdin.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | utils::keep_line::keep_line(p, false) == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `utils::keep_line::keep_line(p, false)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | stdout.write_all(line.full_text.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 123 | let _ = stdout.write_all(line.full_text.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | stdout.write_all(b"\n\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 124 | let _ = stdout.write_all(b"\n\n"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `AnalyticsResult` should have a snake case name [INFO] [stdout] --> src/./structs/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod AnalyticsResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `analytics_result` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Args` should have a snake case name [INFO] [stdout] --> src/./structs/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod Args; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `LineParseResult` should have a snake case name [INFO] [stdout] --> src/./structs/mod.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod LineParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `line_parse_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `UserAgentParseResult` should have a snake case name [INFO] [stdout] --> src/./structs/mod.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub mod UserAgentParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `user_agent_parse_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `isBot` should have a snake case name [INFO] [stdout] --> src/./structs/UserAgentParseResult.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub isBot: bool, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `is_bot` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/generate_analytics.rs:16:42 [INFO] [stdout] | [INFO] [stdout] 16 | let request = parsed_line.request.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/generate_analytics.rs:17:36 [INFO] [stdout] | [INFO] [stdout] 17 | let host = parsed_line.host.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/generate_analytics.rs:18:40 [INFO] [stdout] | [INFO] [stdout] 18 | let ip = parsed_line.ip_address.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/generate_analytics.rs:47:29 [INFO] [stdout] | [INFO] [stdout] 47 | text: ip.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `AnalyticsResult` should have a snake case name [INFO] [stdout] --> src/utils/../structs/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod AnalyticsResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `analytics_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Args` should have a snake case name [INFO] [stdout] --> src/utils/../structs/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod Args; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `LineParseResult` should have a snake case name [INFO] [stdout] --> src/utils/../structs/mod.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod LineParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `line_parse_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `UserAgentParseResult` should have a snake case name [INFO] [stdout] --> src/utils/../structs/mod.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub mod UserAgentParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `user_agent_parse_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `isBot` should have a snake case name [INFO] [stdout] --> src/utils/../structs/UserAgentParseResult.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub isBot: bool, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `is_bot` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/parse_line.rs:9:25 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn parse_line(line: &str) -> crate::structs::LineParseResult::LineParseResult { [INFO] [stdout] | ^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 9 | pub fn parse_line(line: &str) -> crate::structs::LineParseResult::LineParseResult<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `parser` should have an upper case name [INFO] [stdout] --> src/utils/parse_user_agent.rs:9:16 [INFO] [stdout] | [INFO] [stdout] 9 | static ref parser: woothee::parser::Parser = Parser::new(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 9 - static ref parser: woothee::parser::Parser = Parser::new(); [INFO] [stdout] 9 + static ref PARSER: woothee::parser::Parser = Parser::new(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `bots` should have an upper case name [INFO] [stdout] --> src/utils/parse_user_agent.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | static ref bots: Bots = Bots::default(); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 10 - static ref bots: Bots = Bots::default(); [INFO] [stdout] 10 + static ref BOTS: Bots = Bots::default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `isUnique` should have a snake case name [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:11:55 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn read_folder_conserve_memory(file_path: String, isUnique: Option) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `is_unique` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `StringVecToKey` should have a snake case name [INFO] [stdout] --> src/utils/session_analytics.rs:137:4 [INFO] [stdout] | [INFO] [stdout] 137 | fn StringVecToKey(sv: Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_vec_to_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `StringVecToKey` should have a snake case name [INFO] [stdout] --> src/utils/sessions_from_ip.rs:63:4 [INFO] [stdout] | [INFO] [stdout] 63 | fn StringVecToKey(sv: Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_vec_to_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/utils/parse_line.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut fields = line.split(" ").collect::>(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `key` is never read [INFO] [stdout] --> src/utils/sessionize.rs:26:31 [INFO] [stdout] | [INFO] [stdout] 26 | let mut key: String = "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/utils/sort_by_body_size.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | let mut parsed_lines = log_selection.clone(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/utils/unique_ips_only.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | let mut u: String = "".to_string(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `u` [INFO] [stdout] --> src/utils/unique_ips_only.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | let mut u: String = "".to_string(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_u` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AnalyticsResult` is never constructed [INFO] [stdout] --> src/./structs/AnalyticsResult.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct AnalyticsResult<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TopResult` is never constructed [INFO] [stdout] --> src/./structs/AnalyticsResult.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TopResult<'a> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `request_time` is never read [INFO] [stdout] --> src/./structs/LineParseResult.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct LineParseResult<'a> { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub request_time: i64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LineParseResult` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LineParseResult` is never constructed [INFO] [stdout] --> src/utils/../structs/LineParseResult.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct LineParseResult<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UserAgentParseResult` is never constructed [INFO] [stdout] --> src/utils/../structs/UserAgentParseResult.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct UserAgentParseResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AnalyticsResult` is never constructed [INFO] [stdout] --> src/utils/../structs/AnalyticsResult.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct AnalyticsResult<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TopResult` is never constructed [INFO] [stdout] --> src/utils/../structs/AnalyticsResult.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TopResult<'a> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_folder` is never used [INFO] [stdout] --> src/utils/read_folder.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn read_folder(file_path: String) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `average_request_count` and `average_request_length` are never read [INFO] [stdout] --> src/utils/session_analytics.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 9 | struct SessionAnalysisStats { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | average_request_count: i64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 13 | average_request_length: i64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/generate_analytics.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if stats.top_requests.contains_key(&parsed_line.request) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!stats.top_requests.contains_key(&parsed_line.request)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/generate_analytics.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if stats.top_hosts.contains_key(&parsed_line.host) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!stats.top_hosts.contains_key(&parsed_line.host)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/generate_analytics.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if stats.top_ips.contains_key(&parsed_line.ip_address) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!stats.top_ips.contains_key(&parsed_line.ip_address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/generate_analytics.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | return ans; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return ans; [INFO] [stdout] 98 + ans [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/utils/generate_analytics.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | let rel_data: Vec<&structs::AnalyticsResult::TopResult>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `rel_data` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 87 ~ [INFO] [stdout] 88 ~ let rel_data: Vec<&structs::AnalyticsResult::TopResult> = if data.len() < n { [INFO] [stdout] 89 ~ data[0..data.len()].to_vec() [INFO] [stdout] 90 | } else { [INFO] [stdout] 91 ~ data[0..n].to_vec() [INFO] [stdout] 92 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/generate_analytics.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | return format!("{num} KB", num = f / 1024); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return format!("{num} KB", num = f / 1024); [INFO] [stdout] 109 + format!("{num} KB", num = f / 1024) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | if !ARGS.search.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.search.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | if !ARGS.plain_text.is_none() && ARGS.plain_text == Some(true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.plain_text.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | if !ARGS.host.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.host.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 38 | if !ARGS.request.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.request.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 45 | if !ARGS.http_status.is_none() && parsed_line.status != ARGS.http_status.as_ref().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.http_status.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | if !ARGS.referer.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.referer.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 88 | if !ARGS.start_date.is_none() && ARGS.end_date.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.start_date.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | if !ARGS.end_date.is_none() && ARGS.start_date.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.end_date.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 102 | if !ARGS.start_date.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.start_date.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 103 | && !ARGS.end_date.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.end_date.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/keep_line.rs:117:8 [INFO] [stdout] | [INFO] [stdout] 117 | if !ARGS.last.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.last.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/keep_line.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return true; [INFO] [stdout] 123 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/keep_line.rs:28:39 [INFO] [stdout] | [INFO] [stdout] 28 | if !SEARCH_REGEX.is_match(&parsed_line.full_text) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `parsed_line.full_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/keep_line.rs:76:34 [INFO] [stdout] | [INFO] [stdout] 76 | if ARGS.bot.is_some() && ARGS.bot.unwrap() == false && parsed_ua.isBot == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!ARGS.bot.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/utils/keep_line.rs:76:64 [INFO] [stdout] | [INFO] [stdout] 76 | if ARGS.bot.is_some() && ARGS.bot.unwrap() == false && parsed_ua.isBot == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_ua.isBot` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/utils/keep_line.rs:79:34 [INFO] [stdout] | [INFO] [stdout] 79 | if ARGS.bot.is_some() && ARGS.bot.unwrap() == true && parsed_ua.isBot == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ARGS.bot.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/keep_line.rs:79:63 [INFO] [stdout] | [INFO] [stdout] 79 | if ARGS.bot.is_some() && ARGS.bot.unwrap() == true && parsed_ua.isBot == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!parsed_ua.isBot` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/keep_line.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if cm == false { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `!cm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/keep_line.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | / if !ARGS.start_date.is_none() && ARGS.end_date.is_none() { [INFO] [stdout] 89 | | if parse_nginx_time_format(&parsed_line.time) [INFO] [stdout] 90 | | < parse_input_time(&ARGS.start_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] ... | [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 88 ~ if !ARGS.start_date.is_none() && ARGS.end_date.is_none() [INFO] [stdout] 89 ~ && parse_nginx_time_format(&parsed_line.time) [INFO] [stdout] 90 | < parse_input_time(&ARGS.start_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] 91 | { [INFO] [stdout] 92 | return false; [INFO] [stdout] 93 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/keep_line.rs:90:32 [INFO] [stdout] | [INFO] [stdout] 90 | < parse_input_time(&ARGS.start_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ARGS.start_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/keep_line.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | / if !ARGS.end_date.is_none() && ARGS.start_date.is_none() { [INFO] [stdout] 96 | | if parse_nginx_time_format(&parsed_line.time) [INFO] [stdout] 97 | | > parse_input_time(&ARGS.end_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] ... | [INFO] [stdout] 101 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 95 ~ if !ARGS.end_date.is_none() && ARGS.start_date.is_none() [INFO] [stdout] 96 ~ && parse_nginx_time_format(&parsed_line.time) [INFO] [stdout] 97 | > parse_input_time(&ARGS.end_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] 98 | { [INFO] [stdout] 99 | return false; [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/keep_line.rs:97:32 [INFO] [stdout] | [INFO] [stdout] 97 | > parse_input_time(&ARGS.end_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ARGS.end_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/keep_line.rs:105:32 [INFO] [stdout] | [INFO] [stdout] 105 | > parse_input_time(&ARGS.end_date.as_ref().unwrap(), tz.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ARGS.end_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/keep_line.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | < parse_input_time(&ARGS.start_date.as_ref().unwrap(), tz.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ARGS.start_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils/keep_line.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | epoch_seconds = epoch_seconds - 60 * ARGS.last.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `epoch_seconds -= 60 * ARGS.last.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/parse_line.rs:33:29 [INFO] [stdout] | [INFO] [stdout] 33 | body_bytes_sent: if !fields[10].to_string().parse::().is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fields[10].to_string().parse::().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/parse_line.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / return crate::structs::LineParseResult::LineParseResult { [INFO] [stdout] 27 | | ip_address: fields[0], [INFO] [stdout] 28 | | time: fields[3].replace("[", "") + " " + &fields[4].replace("]", ""), [INFO] [stdout] 29 | | host: fields[5], [INFO] [stdout] ... | [INFO] [stdout] 40 | | full_text: line, [INFO] [stdout] 41 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 ~ crate::structs::LineParseResult::LineParseResult { [INFO] [stdout] 27 + ip_address: fields[0], [INFO] [stdout] 28 + time: fields[3].replace("[", "") + " " + &fields[4].replace("]", ""), [INFO] [stdout] 29 + host: fields[5], [INFO] [stdout] 30 + referer: fields[11], [INFO] [stdout] 31 + request: matches[1], [INFO] [stdout] 32 + status: fields[9], [INFO] [stdout] 33 + body_bytes_sent: if !fields[10].to_string().parse::().is_err() { [INFO] [stdout] 34 + !fields[10].to_string().parse::().unwrap() [INFO] [stdout] 35 + } else { [INFO] [stdout] 36 + 0 [INFO] [stdout] 37 + }, [INFO] [stdout] 38 + request_time: 0, [INFO] [stdout] 39 + user_agent: matches[3], [INFO] [stdout] 40 + full_text: line, [INFO] [stdout] 41 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/parse_user_agent.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / return crate::structs::UserAgentParseResult::UserAgentParseResult { [INFO] [stdout] 26 | | operating_system: resultu.os.to_string(), [INFO] [stdout] 27 | | category: resultu.category.to_string(), [INFO] [stdout] 28 | | isBot: bots.is_bot(ua), [INFO] [stdout] 29 | | browser: resultu.name.to_string(), [INFO] [stdout] 30 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 ~ crate::structs::UserAgentParseResult::UserAgentParseResult { [INFO] [stdout] 26 + operating_system: resultu.os.to_string(), [INFO] [stdout] 27 + category: resultu.category.to_string(), [INFO] [stdout] 28 + isBot: bots.is_bot(ua), [INFO] [stdout] 29 + browser: resultu.name.to_string(), [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/read_folder.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return lines; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return lines; [INFO] [stdout] 53 + lines [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:39:54 [INFO] [stdout] | [INFO] [stdout] 39 | ... if isUnique.is_some() && isUnique.unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `isUnique.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:40:33 [INFO] [stdout] | [INFO] [stdout] 40 | / ... if !occurrences.contains_key(&ip) { [INFO] [stdout] 41 | | ... println!("{}", line.clone() + "\n"); [INFO] [stdout] 42 | | ... occurrences.insert(ip, true); [INFO] [stdout] 43 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 ~ occurrences.entry(ip).or_insert_with(|| { [INFO] [stdout] 41 + println!("{}", line.clone() + "\n"); [INFO] [stdout] 42 + true [INFO] [stdout] 43 + }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:57:32 [INFO] [stdout] | [INFO] [stdout] 57 | for line in reader.flatten() { [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | for line in reader.flatten() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:60:46 [INFO] [stdout] | [INFO] [stdout] 60 | if isUnique.is_some() && isUnique.unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `isUnique.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | / if !occurrences.contains_key(&ip) { [INFO] [stdout] 62 | | println!("{}", line.clone() + "\n"); [INFO] [stdout] 63 | | occurrences.insert(ip, true); [INFO] [stdout] 64 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 61 ~ occurrences.entry(ip).or_insert_with(|| { [INFO] [stdout] 62 + println!("{}", line.clone() + "\n"); [INFO] [stdout] 63 + true [INFO] [stdout] 64 + }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/session_analytics.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 66 | if host_path.len() == 0 || host_path[host_path.len() - 1] != a { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `host_path.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils/session_analytics.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | / ips_text = ips_text [INFO] [stdout] 85 | | + format!( [INFO] [stdout] 86 | | "- {ip} - {num}\n", [INFO] [stdout] 87 | | ip = s.ip_address, [INFO] [stdout] ... | [INFO] [stdout] 90 | | .as_str(); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 84 ~ ips_text += format!( [INFO] [stdout] 85 + "- {ip} - {num}\n", [INFO] [stdout] 86 + ip = s.ip_address, [INFO] [stdout] 87 + num = s.sessions.len() [INFO] [stdout] 88 + ) [INFO] [stdout] 89 ~ .as_str(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils/session_analytics.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | / host_text = host_text [INFO] [stdout] 102 | | + format!( [INFO] [stdout] 103 | | "- {pe} [{cnt}]\n", [INFO] [stdout] 104 | | pe = path_entry [INFO] [stdout] ... | [INFO] [stdout] 111 | | .as_str(); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 101 ~ host_text += format!( [INFO] [stdout] 102 + "- {pe} [{cnt}]\n", [INFO] [stdout] 103 + pe = path_entry [INFO] [stdout] 104 + .path [INFO] [stdout] 105 + .replace(",", " -->") [INFO] [stdout] 106 + .replace("[", "") [INFO] [stdout] 107 + .replace("]", ""), [INFO] [stdout] 108 + cnt = path_entry.count [INFO] [stdout] 109 + ) [INFO] [stdout] 110 ~ .as_str(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/session_analytics.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | return ans + "]"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return ans + "]"; [INFO] [stdout] 144 + ans + "]" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/session_unique.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | if session.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!session.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/session_unique.rs:19:65 [INFO] [stdout] | [INFO] [stdout] 19 | out.par_sort_by_key(|a| parse_nginx_time_format(&parse_line(&a).time).timestamp()); [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `m` after checking its variant with `is_some` [INFO] [stdout] --> src/utils/sessionize.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 29 | if m.is_some() { [INFO] [stdout] | -------------- help: try: `if let Some() = m` [INFO] [stdout] 30 | key = m.unwrap().as_str().to_string(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sessionize.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | return o.to_owned().into_values().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return o.to_owned().into_values().collect(); [INFO] [stdout] 85 + o.to_owned().into_values().collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sessionize.rs:23:24 [INFO] [stdout] | [INFO] [stdout] 23 | r = Regex::new(&u).unwrap(); [INFO] [stdout] | ^^ help: change this to: `u` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/utils/sessionize.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | / let mut l = Vec::new(); [INFO] [stdout] 41 | | l.push(parsed_line.full_text.to_string()); [INFO] [stdout] | |__________________________________________________________^ help: consider using the `vec![]` macro: `let l = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/utils/sessionize.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | / let mut t = Vec::new(); [INFO] [stdout] 43 | | t.push(time); [INFO] [stdout] | |_____________________________^ help: consider using the `vec![]` macro: `let t = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/utils/sessionize.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | for l in &entry.times { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, l) in entry.times.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `m` after checking its variant with `is_some` [INFO] [stdout] --> src/utils/sessions_from_ip.rs:23:23 [INFO] [stdout] | [INFO] [stdout] 22 | if m.is_some() { [INFO] [stdout] | -------------- help: try: `if let Some() = m` [INFO] [stdout] 23 | key = m.unwrap().clone().as_str().to_string(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/sessions_from_ip.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | if session.len() != 0 && session.len() != 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!session.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/sessions_from_ip.rs:37:28 [INFO] [stdout] | [INFO] [stdout] 37 | if host_path.len() == 0 || host_path[host_path.len() - 1] != h { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `host_path.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/utils/sessions_from_ip.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | for path in host_paths { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, path) in host_paths.into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sessions_from_ip.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | return ans + "]"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return ans + "]"; [INFO] [stdout] 70 + ans + "]" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/sort_by_body_size.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | if occurrences.contains_key(&line.request) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!occurrences.contains_key(&line.request)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/utils/sort_by_body_size.rs:16:55 [INFO] [stdout] | [INFO] [stdout] 16 | final_lines.par_sort_by_key(|a: &LineParseResult| a.body_bytes_sent.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `a.body_bytes_sent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/utils/sort_by_body_size.rs:18:37 [INFO] [stdout] | [INFO] [stdout] 18 | final_lines.par_sort_by_key(|a| a.body_bytes_sent.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `a.body_bytes_sent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sort_by_body_size.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return format!("{num} KB", num = f / 1024); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return format!("{num} KB", num = f / 1024); [INFO] [stdout] 44 + format!("{num} KB", num = f / 1024) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sort_by_date.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return (0, log_selection.len() - 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return (0, log_selection.len() - 1); [INFO] [stdout] 56 + (0, log_selection.len() - 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/sort_by_date.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | if log_selection.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `log_selection.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | &log_selection, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `log_selection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | &log_selection, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `log_selection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:34:30 [INFO] [stdout] | [INFO] [stdout] 34 | parse_input_time(&start_date.as_ref().unwrap(), tz.clone()).timestamp(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `start_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:35:30 [INFO] [stdout] | [INFO] [stdout] 35 | parse_input_time(&end_date.as_ref().unwrap(), tz.clone()).timestamp(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `end_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | &log_selection, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `log_selection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:42:30 [INFO] [stdout] | [INFO] [stdout] 42 | parse_input_time(&end_date.as_ref().unwrap(), tz).timestamp(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `end_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | &log_selection, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `log_selection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/sort_by_date.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 52 | parse_input_time(&start_date.as_ref().unwrap(), tz).timestamp(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `start_date.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sort_by_date.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | return (st, en + st); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return (st, en + st); [INFO] [stdout] 71 + (st, en + st) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils/sort_by_date.rs:59:19 [INFO] [stdout] | [INFO] [stdout] 59 | fn b_search(logs: &Vec, start_time_range: i64, end_time_range: i64) -> (usize, usize) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 59 - fn b_search(logs: &Vec, start_time_range: i64, end_time_range: i64) -> (usize, usize) { [INFO] [stdout] 59 + fn b_search(logs: &[String], start_time_range: i64, end_time_range: i64) -> (usize, usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sort_by_date.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return parse_nginx_time_format(&t).timestamp() < end_time_range; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return parse_nginx_time_format(&t).timestamp() < end_time_range; [INFO] [stdout] 68 + parse_nginx_time_format(&t).timestamp() < end_time_range [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `m` after checking its variant with `is_some` [INFO] [stdout] --> src/utils/unique_ips_only.rs:22:36 [INFO] [stdout] | [INFO] [stdout] 21 | if m.is_some() { [INFO] [stdout] | -------------- help: try: `if let Some() = m` [INFO] [stdout] 22 | occurrences.insert(m.unwrap().as_str(), line); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/unique_ips_only.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return occurrences.into_iter().map(|(_, v)| v).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return occurrences.into_iter().map(|(_, v)| v).collect(); [INFO] [stdout] 30 + occurrences.into_iter().map(|(_, v)| v).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils/unique_ips_only.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | if occurrences.contains_key(&line.ip_address) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!occurrences.contains_key(&line.ip_address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/utils/unique_ips_only.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | return occurrences.into_iter().map(|(_, v)| v).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `occurrences.into_values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | / return stdin [INFO] [stdout] 41 | | .lock() [INFO] [stdout] 42 | | .lines() [INFO] [stdout] 43 | | .map(|line| line.expect("Failed to read line")) [INFO] [stdout] 44 | | .collect(); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ stdin [INFO] [stdout] 41 + .lock() [INFO] [stdout] 42 + .lines() [INFO] [stdout] 43 + .map(|line| line.expect("Failed to read line")) [INFO] [stdout] 44 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | && !args.conserve_memory.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.conserve_memory.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | if (!args.unique.is_none() && args.unique == Some(true)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.unique.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:110:8 [INFO] [stdout] | [INFO] [stdout] 110 | if !args.analytics.is_none() && args.analytics == Some(true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.analytics.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:112:15 [INFO] [stdout] | [INFO] [stdout] 112 | } else if !args.session_analytics.is_none() && args.session_analytics == Some(true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.session_analytics.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:114:15 [INFO] [stdout] | [INFO] [stdout] 114 | } else if !args.large.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `args.large.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:116:15 [INFO] [stdout] | [INFO] [stdout] 116 | } else if !args.ip_ses.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.ip_ses.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:118:15 [INFO] [stdout] | [INFO] [stdout] 118 | } else if !args.session_unqiue.is_none() && args.session_unqiue == Some(true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.session_unqiue.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.thread_count` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 48 | if args.thread_count.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = args.thread_count` [INFO] [stdout] 49 | rayon::ThreadPoolBuilder::new() [INFO] [stdout] 50 | .num_threads(args.thread_count.unwrap().try_into().expect("WOMP WOMP")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.file` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:59:46 [INFO] [stdout] | [INFO] [stdout] 54 | if args.file.is_some() [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 59 | if let Ok(lines) = read_line_by_line(args.file.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.file` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:85:17 [INFO] [stdout] | [INFO] [stdout] 82 | if args.file.is_some() && metadata(args.file.clone().unwrap()).unwrap().is_dir() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 85 | args.file.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.large` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:115:58 [INFO] [stdout] | [INFO] [stdout] 114 | } else if !args.large.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] 115 | utils::sort_by_body_size::sort_by_body_size(kel, args.large.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | && args.conserve_memory.unwrap() == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.conserve_memory.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/main.rs:61:31 [INFO] [stdout] | [INFO] [stdout] 61 | for line in lines.flatten() { [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/main.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | for line in lines.flatten() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:64:49 [INFO] [stdout] | [INFO] [stdout] 64 | if args.unique.is_some() && args.unique.unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.unique.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/main.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 65 | / if !occurrences.contains_key(&ip) { [INFO] [stdout] 66 | | println!("{}", line.clone() + "\n"); [INFO] [stdout] 67 | | occurrences.insert(ip, true); [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 ~ occurrences.entry(ip).or_insert_with(|| { [INFO] [stdout] 66 + println!("{}", line.clone() + "\n"); [INFO] [stdout] 67 + true [INFO] [stdout] 68 + }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:79:31 [INFO] [stdout] | [INFO] [stdout] 79 | if args.file.is_none() && stdin.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stdin.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:83:46 [INFO] [stdout] | [INFO] [stdout] 83 | if args.conserve_memory.is_some() && args.conserve_memory.unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.conserve_memory.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:90:38 [INFO] [stdout] | [INFO] [stdout] 90 | } else if args.file.is_none() && stdin.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!stdin.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | utils::keep_line::keep_line(p, false) == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `utils::keep_line::keep_line(p, false)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | stdout.write_all(line.full_text.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 123 | let _ = stdout.write_all(line.full_text.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | stdout.write_all(b"\n\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 124 | let _ = stdout.write_all(b"\n\n"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `AnalyticsResult` should have a snake case name [INFO] [stdout] --> src/./structs/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod AnalyticsResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `analytics_result` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Args` should have a snake case name [INFO] [stdout] --> src/./structs/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod Args; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `LineParseResult` should have a snake case name [INFO] [stdout] --> src/./structs/mod.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod LineParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `line_parse_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `UserAgentParseResult` should have a snake case name [INFO] [stdout] --> src/./structs/mod.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub mod UserAgentParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `user_agent_parse_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `isBot` should have a snake case name [INFO] [stdout] --> src/./structs/UserAgentParseResult.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub isBot: bool, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `is_bot` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/generate_analytics.rs:16:42 [INFO] [stdout] | [INFO] [stdout] 16 | let request = parsed_line.request.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/generate_analytics.rs:17:36 [INFO] [stdout] | [INFO] [stdout] 17 | let host = parsed_line.host.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/generate_analytics.rs:18:40 [INFO] [stdout] | [INFO] [stdout] 18 | let ip = parsed_line.ip_address.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/generate_analytics.rs:47:29 [INFO] [stdout] | [INFO] [stdout] 47 | text: ip.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `AnalyticsResult` should have a snake case name [INFO] [stdout] --> src/utils/../structs/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod AnalyticsResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `analytics_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Args` should have a snake case name [INFO] [stdout] --> src/utils/../structs/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod Args; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `LineParseResult` should have a snake case name [INFO] [stdout] --> src/utils/../structs/mod.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod LineParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `line_parse_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `UserAgentParseResult` should have a snake case name [INFO] [stdout] --> src/utils/../structs/mod.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub mod UserAgentParseResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `user_agent_parse_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `isBot` should have a snake case name [INFO] [stdout] --> src/utils/../structs/UserAgentParseResult.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub isBot: bool, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `is_bot` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/parse_line.rs:9:25 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn parse_line(line: &str) -> crate::structs::LineParseResult::LineParseResult { [INFO] [stdout] | ^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 9 | pub fn parse_line(line: &str) -> crate::structs::LineParseResult::LineParseResult<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `parser` should have an upper case name [INFO] [stdout] --> src/utils/parse_user_agent.rs:9:16 [INFO] [stdout] | [INFO] [stdout] 9 | static ref parser: woothee::parser::Parser = Parser::new(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 9 - static ref parser: woothee::parser::Parser = Parser::new(); [INFO] [stdout] 9 + static ref PARSER: woothee::parser::Parser = Parser::new(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `bots` should have an upper case name [INFO] [stdout] --> src/utils/parse_user_agent.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | static ref bots: Bots = Bots::default(); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 10 - static ref bots: Bots = Bots::default(); [INFO] [stdout] 10 + static ref BOTS: Bots = Bots::default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `isUnique` should have a snake case name [INFO] [stdout] --> src/utils/read_folder_conserve_memory.rs:11:55 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn read_folder_conserve_memory(file_path: String, isUnique: Option) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `is_unique` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `StringVecToKey` should have a snake case name [INFO] [stdout] --> src/utils/session_analytics.rs:137:4 [INFO] [stdout] | [INFO] [stdout] 137 | fn StringVecToKey(sv: Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_vec_to_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `StringVecToKey` should have a snake case name [INFO] [stdout] --> src/utils/sessions_from_ip.rs:63:4 [INFO] [stdout] | [INFO] [stdout] 63 | fn StringVecToKey(sv: Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_vec_to_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 26.29s [INFO] running `Command { std: "docker" "inspect" "b17d677cfb6bede3a067e442176f25390474c5a47a5d1e33ccdf8b25ccc21d6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b17d677cfb6bede3a067e442176f25390474c5a47a5d1e33ccdf8b25ccc21d6a", kill_on_drop: false }` [INFO] [stdout] b17d677cfb6bede3a067e442176f25390474c5a47a5d1e33ccdf8b25ccc21d6a