[INFO] fetching crate nexion 0.1.1... [INFO] linting nexion-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate nexion 0.1.1 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate nexion 0.1.1 [INFO] finished tweaking crates.io crate nexion 0.1.1 [INFO] tweaked toml for crates.io crate nexion 0.1.1 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate nexion 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate nexion 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded objc2-metal v0.3.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9a6d432e459ebdaf3d573407506017cb886a7ebaca462a5ad9a3c1a88f64bd1 [INFO] running `Command { std: "docker" "start" "-a" "e9a6d432e459ebdaf3d573407506017cb886a7ebaca462a5ad9a3c1a88f64bd1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9a6d432e459ebdaf3d573407506017cb886a7ebaca462a5ad9a3c1a88f64bd1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9a6d432e459ebdaf3d573407506017cb886a7ebaca462a5ad9a3c1a88f64bd1", kill_on_drop: false }` [INFO] [stdout] e9a6d432e459ebdaf3d573407506017cb886a7ebaca462a5ad9a3c1a88f64bd1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80cf0f90867de1141b67a5f01659d1bc5725b9b38c03dec1b9ae0a92273077ba [INFO] running `Command { std: "docker" "start" "-a" "80cf0f90867de1141b67a5f01659d1bc5725b9b38c03dec1b9ae0a92273077ba", kill_on_drop: false }` [INFO] [stderr] Compiling ash v0.38.0+1.3.281 [INFO] [stderr] Compiling zmij v1.0.12 [INFO] [stderr] Checking presser v0.3.1 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling delegate v0.13.5 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking gpu-allocator v0.28.0 [INFO] [stderr] Checking nexion v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 208 | allocation: allocation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | physical_device: physical_device, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `physical_device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | instance: instance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:229:13 [INFO] [stdout] | [INFO] [stdout] 229 | graphics_queue: graphics_queue, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `graphics_queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | transfer_queue: transfer_queue, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transfer_queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | compute_queue: compute_queue, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compute_queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:365:17 [INFO] [stdout] | [INFO] [stdout] 365 | allocation: allocation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:438:17 [INFO] [stdout] | [INFO] [stdout] 438 | allocation: allocation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:443:26 [INFO] [stdout] | [INFO] [stdout] 443 | return ImageId { id: id }; [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:477:30 [INFO] [stdout] | [INFO] [stdout] 477 | return ImageViewId { id: id }; [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:513:28 [INFO] [stdout] | [INFO] [stdout] 513 | return SamplerId { id: id }; [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/backend/gpu_resources.rs:44:1 [INFO] [stdout] | [INFO] [stdout] 44 | / /// Actual creation and destruction happens on a device, this just manages the ids [INFO] [stdout] 45 | | [INFO] [stdout] | |_^ [INFO] [stdout] 46 | pub(crate) struct ResourcePool { [INFO] [stdout] | ------------------------------ the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/gpu_resources.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | image_view: image_view, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/gpu_resources.rs:282:13 [INFO] [stdout] | [INFO] [stdout] 282 | image_view: image_view, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/gpu_resources.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 306 | sampler: sampler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/instance.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | entry: entry, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/instance.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | debug_messenger: debug_messenger, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `debug_messenger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/instance.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | debug_loader: debug_loader, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `debug_loader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/pipelines.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | device: device, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/pipelines.rs:226:17 [INFO] [stdout] | [INFO] [stdout] 226 | pipeline: pipeline, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/pipelines.rs:267:17 [INFO] [stdout] | [INFO] [stdout] 267 | pipeline: pipeline, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 208 | allocation: allocation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:138:27 [INFO] [stdout] | [INFO] [stdout] 138 | ImageId { id: id } [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 168 | swapchain_loader: swapchain_loader, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `swapchain_loader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:171:13 [INFO] [stdout] | [INFO] [stdout] 171 | image_views: image_views, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_views` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | physical_device: physical_device, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `physical_device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 175 | fences: fences, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `fences` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | device: device, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | instance: instance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:229:13 [INFO] [stdout] | [INFO] [stdout] 229 | graphics_queue: graphics_queue, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `graphics_queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | transfer_queue: transfer_queue, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transfer_queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | compute_queue: compute_queue, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compute_queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:252:13 [INFO] [stdout] | [INFO] [stdout] 252 | image_semaphore: image_semaphore, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_semaphore` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 254 | fence: fence, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `fence` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:365:17 [INFO] [stdout] | [INFO] [stdout] 365 | allocation: allocation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/commands.rs:174:44 [INFO] [stdout] | [INFO] [stdout] 174 | extent: vk::Extent2D { width: width, height: height }, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/commands.rs:174:58 [INFO] [stdout] | [INFO] [stdout] 174 | extent: vk::Extent2D { width: width, height: height }, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:438:17 [INFO] [stdout] | [INFO] [stdout] 438 | allocation: allocation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:443:26 [INFO] [stdout] | [INFO] [stdout] 443 | return ImageId { id: id }; [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:477:30 [INFO] [stdout] | [INFO] [stdout] 477 | return ImageViewId { id: id }; [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/device.rs:513:28 [INFO] [stdout] | [INFO] [stdout] 513 | return SamplerId { id: id }; [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/backend/gpu_resources.rs:44:1 [INFO] [stdout] | [INFO] [stdout] 44 | / /// Actual creation and destruction happens on a device, this just manages the ids [INFO] [stdout] 45 | | [INFO] [stdout] | |_^ [INFO] [stdout] 46 | pub(crate) struct ResourcePool { [INFO] [stdout] | ------------------------------ the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/device.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | index: index, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/device.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | queue_type: queue_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/gpu_resources.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | image_view: image_view, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/gpu_resources.rs:282:13 [INFO] [stdout] | [INFO] [stdout] 282 | image_view: image_view, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/instance.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | inner_device: inner_device, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inner_device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/instance.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | pipeline_manager: pipeline_manager, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline_manager` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/gpu_resources.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 306 | sampler: sampler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/swapchain.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | width: width, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/instance.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | entry: entry, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/instance.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | debug_messenger: debug_messenger, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `debug_messenger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/instance.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | debug_loader: debug_loader, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `debug_loader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/pipelines.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | device: device, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/swapchain.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | height: height, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/pipelines.rs:226:17 [INFO] [stdout] | [INFO] [stdout] 226 | pipeline: pipeline, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/pipelines.rs:267:17 [INFO] [stdout] | [INFO] [stdout] 267 | pipeline: pipeline, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:138:27 [INFO] [stdout] | [INFO] [stdout] 138 | ImageId { id: id } [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 168 | swapchain_loader: swapchain_loader, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `swapchain_loader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:171:13 [INFO] [stdout] | [INFO] [stdout] 171 | image_views: image_views, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_views` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 175 | fences: fences, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `fences` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | device: device, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:252:13 [INFO] [stdout] | [INFO] [stdout] 252 | image_semaphore: image_semaphore, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_semaphore` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/backend/swapchain.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 254 | fence: fence, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `fence` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/commands.rs:174:44 [INFO] [stdout] | [INFO] [stdout] 174 | extent: vk::Extent2D { width: width, height: height }, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/commands.rs:174:58 [INFO] [stdout] | [INFO] [stdout] 174 | extent: vk::Extent2D { width: width, height: height }, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/device.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | index: index, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/device.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | queue_type: queue_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/vulkan_context.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | instance: instance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/vulkan_context.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | device: device, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/vulkan_context.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | swapchain: swapchain, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `swapchain` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/instance.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | inner_device: inner_device, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inner_device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/instance.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | pipeline_manager: pipeline_manager, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline_manager` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/swapchain.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | width: width, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/swapchain.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | height: height, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/vulkan_context.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | instance: instance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/vulkan_context.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | device: device, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/vulkan_context.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | swapchain: swapchain, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `swapchain` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return self.graphics_family.is_some() && self.compute_family.is_some() && self.transfer_family.is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return self.graphics_family.is_some() && self.compute_family.is_some() && self.transfer_family.is_some(); [INFO] [stdout] 18 + self.graphics_family.is_some() && self.compute_family.is_some() && self.transfer_family.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | / return InnerDevice { [INFO] [stdout] 216 | | handle: dev, [INFO] [stdout] 217 | | physical_device: physical_device, [INFO] [stdout] 218 | | allocator: UnsafeCell::new(allocator), [INFO] [stdout] ... | [INFO] [stdout] 231 | | compute_queue: compute_queue, [INFO] [stdout] 232 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 ~ InnerDevice { [INFO] [stdout] 216 + handle: dev, [INFO] [stdout] 217 + physical_device: physical_device, [INFO] [stdout] 218 + allocator: UnsafeCell::new(allocator), [INFO] [stdout] 219 + instance: instance, [INFO] [stdout] 220 + [INFO] [stdout] 221 + //Resource Pools [INFO] [stdout] 222 + bindless_descriptors: bindless_desc, [INFO] [stdout] 223 + buffer_pool: UnsafeCell::new(ResourcePool::new()), [INFO] [stdout] 224 + image_pool: UnsafeCell::new(ResourcePool::new()), [INFO] [stdout] 225 + image_view_pool: UnsafeCell::new(ResourcePool::new()), [INFO] [stdout] 226 + sampler_pool: UnsafeCell::new(ResourcePool::new()), [INFO] [stdout] 227 + [INFO] [stdout] 228 + //Queues [INFO] [stdout] 229 + graphics_queue: graphics_queue, [INFO] [stdout] 230 + transfer_queue: transfer_queue, [INFO] [stdout] 231 + compute_queue: compute_queue, [INFO] [stdout] 232 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return self.graphics_family.is_some() && self.compute_family.is_some() && self.transfer_family.is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return self.graphics_family.is_some() && self.compute_family.is_some() && self.transfer_family.is_some(); [INFO] [stdout] 18 + self.graphics_family.is_some() && self.compute_family.is_some() && self.transfer_family.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | / return InnerDevice { [INFO] [stdout] 216 | | handle: dev, [INFO] [stdout] 217 | | physical_device: physical_device, [INFO] [stdout] 218 | | allocator: UnsafeCell::new(allocator), [INFO] [stdout] ... | [INFO] [stdout] 231 | | compute_queue: compute_queue, [INFO] [stdout] 232 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 ~ InnerDevice { [INFO] [stdout] 216 + handle: dev, [INFO] [stdout] 217 + physical_device: physical_device, [INFO] [stdout] 218 + allocator: UnsafeCell::new(allocator), [INFO] [stdout] 219 + instance: instance, [INFO] [stdout] 220 + [INFO] [stdout] 221 + //Resource Pools [INFO] [stdout] 222 + bindless_descriptors: bindless_desc, [INFO] [stdout] 223 + buffer_pool: UnsafeCell::new(ResourcePool::new()), [INFO] [stdout] 224 + image_pool: UnsafeCell::new(ResourcePool::new()), [INFO] [stdout] 225 + image_view_pool: UnsafeCell::new(ResourcePool::new()), [INFO] [stdout] 226 + sampler_pool: UnsafeCell::new(ResourcePool::new()), [INFO] [stdout] 227 + [INFO] [stdout] 228 + //Queues [INFO] [stdout] 229 + graphics_queue: graphics_queue, [INFO] [stdout] 230 + transfer_queue: transfer_queue, [INFO] [stdout] 231 + compute_queue: compute_queue, [INFO] [stdout] 232 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:266:13 [INFO] [stdout] | [INFO] [stdout] 266 | return Some(indices); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 266 - return Some(indices); [INFO] [stdout] 266 + Some(indices) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 - return None; [INFO] [stdout] 268 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 275 | / return required_extensions.iter().all(|&required_ptr| { [INFO] [stdout] 276 | | let required_str = unsafe { std::ffi::CStr::from_ptr(required_ptr) }; [INFO] [stdout] 277 | | [INFO] [stdout] 278 | | available_extensions.iter().any(|avail| { [INFO] [stdout] ... | [INFO] [stdout] 282 | | }) [INFO] [stdout] 283 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 275 ~ required_extensions.iter().all(|&required_ptr| { [INFO] [stdout] 276 + let required_str = unsafe { std::ffi::CStr::from_ptr(required_ptr) }; [INFO] [stdout] 277 + [INFO] [stdout] 278 + available_extensions.iter().any(|avail| { [INFO] [stdout] 279 + let avail_str = unsafe { std::ffi::CStr::from_ptr(avail.extension_name.as_ptr()) }; [INFO] [stdout] 280 + [INFO] [stdout] 281 + avail_str == required_str [INFO] [stdout] 282 + }) [INFO] [stdout] 283 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:266:13 [INFO] [stdout] | [INFO] [stdout] 266 | return Some(indices); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 266 - return Some(indices); [INFO] [stdout] 266 + Some(indices) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/backend/device.rs:272:124 [INFO] [stdout] | [INFO] [stdout] 272 | ..., device: ash::vk::PhysicalDevice, required_extensions: &Vec<*const i8>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 272 - fn check_device_extension_support(instance: &Arc, device: ash::vk::PhysicalDevice, required_extensions: &Vec<*const i8>) -> bool { [INFO] [stdout] 272 + fn check_device_extension_support(instance: &Arc, device: ash::vk::PhysicalDevice, required_extensions: &[*const i8]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 - return None; [INFO] [stdout] 268 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | return best_device.map(|(_, dev)| dev); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - return best_device.map(|(_, dev)| dev); [INFO] [stdout] 324 + best_device.map(|(_, dev)| dev) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 275 | / return required_extensions.iter().all(|&required_ptr| { [INFO] [stdout] 276 | | let required_str = unsafe { std::ffi::CStr::from_ptr(required_ptr) }; [INFO] [stdout] 277 | | [INFO] [stdout] 278 | | available_extensions.iter().any(|avail| { [INFO] [stdout] ... | [INFO] [stdout] 282 | | }) [INFO] [stdout] 283 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 275 ~ required_extensions.iter().all(|&required_ptr| { [INFO] [stdout] 276 + let required_str = unsafe { std::ffi::CStr::from_ptr(required_ptr) }; [INFO] [stdout] 277 + [INFO] [stdout] 278 + available_extensions.iter().any(|avail| { [INFO] [stdout] 279 + let avail_str = unsafe { std::ffi::CStr::from_ptr(avail.extension_name.as_ptr()) }; [INFO] [stdout] 280 + [INFO] [stdout] 281 + avail_str == required_str [INFO] [stdout] 282 + }) [INFO] [stdout] 283 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/backend/device.rs:272:124 [INFO] [stdout] | [INFO] [stdout] 272 | ..., device: ash::vk::PhysicalDevice, required_extensions: &Vec<*const i8>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 272 - fn check_device_extension_support(instance: &Arc, device: ash::vk::PhysicalDevice, required_extensions: &Vec<*const i8>) -> bool { [INFO] [stdout] 272 + fn check_device_extension_support(instance: &Arc, device: ash::vk::PhysicalDevice, required_extensions: &[*const i8]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | return best_device.map(|(_, dev)| dev); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - return best_device.map(|(_, dev)| dev); [INFO] [stdout] 324 + best_device.map(|(_, dev)| dev) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:369:9 [INFO] [stdout] | [INFO] [stdout] 369 | return BufferId { id: raw_id }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 369 - return BufferId { id: raw_id }; [INFO] [stdout] 369 + BufferId { id: raw_id } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:369:9 [INFO] [stdout] | [INFO] [stdout] 369 | return BufferId { id: raw_id }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 369 - return BufferId { id: raw_id }; [INFO] [stdout] 369 + BufferId { id: raw_id } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:382:31 [INFO] [stdout] | [INFO] [stdout] 382 | let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 382 - let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] 382 + let buffer = unsafe { (&*self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:382:31 [INFO] [stdout] | [INFO] [stdout] 382 | let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 382 - let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] 382 + let buffer = unsafe { (&*self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:393:9 [INFO] [stdout] | [INFO] [stdout] 393 | return buffer.allocation.mapped_ptr().expect("Tried to write to an unmapped buffer").as_ptr() as *mut u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 393 - return buffer.allocation.mapped_ptr().expect("Tried to write to an unmapped buffer").as_ptr() as *mut u8; [INFO] [stdout] 393 + buffer.allocation.mapped_ptr().expect("Tried to write to an unmapped buffer").as_ptr() as *mut u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:391:31 [INFO] [stdout] | [INFO] [stdout] 391 | let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 391 - let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] 391 + let buffer = unsafe { (&*self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | return buffer.address; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return buffer.address; [INFO] [stdout] 399 + buffer.address [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:397:31 [INFO] [stdout] | [INFO] [stdout] 397 | let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 397 - let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] 397 + let buffer = unsafe { (&*self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:443:9 [INFO] [stdout] | [INFO] [stdout] 443 | return ImageId { id: id }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 443 - return ImageId { id: id }; [INFO] [stdout] 443 + ImageId { id: id } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:393:9 [INFO] [stdout] | [INFO] [stdout] 393 | return buffer.allocation.mapped_ptr().expect("Tried to write to an unmapped buffer").as_ptr() as *mut u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 393 - return buffer.allocation.mapped_ptr().expect("Tried to write to an unmapped buffer").as_ptr() as *mut u8; [INFO] [stdout] 393 + buffer.allocation.mapped_ptr().expect("Tried to write to an unmapped buffer").as_ptr() as *mut u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:391:31 [INFO] [stdout] | [INFO] [stdout] 391 | let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 391 - let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] 391 + let buffer = unsafe { (&*self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:477:9 [INFO] [stdout] | [INFO] [stdout] 477 | return ImageViewId { id: id }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 477 - return ImageViewId { id: id }; [INFO] [stdout] 477 + ImageViewId { id: id } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:459:28 [INFO] [stdout] | [INFO] [stdout] 459 | let img = unsafe { (&mut *self.image_pool.get()).get_ref(image_id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 459 - let img = unsafe { (&mut *self.image_pool.get()).get_ref(image_id.id) }; [INFO] [stdout] 459 + let img = unsafe { (&*self.image_pool.get()).get_ref(image_id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:513:9 [INFO] [stdout] | [INFO] [stdout] 513 | return SamplerId { id: id }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 513 - return SamplerId { id: id }; [INFO] [stdout] 513 + SamplerId { id: id } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | return buffer.address; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return buffer.address; [INFO] [stdout] 399 + buffer.address [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:397:31 [INFO] [stdout] | [INFO] [stdout] 397 | let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 397 - let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] 397 + let buffer = unsafe { (&*self.buffer_pool.get()).get_ref(buffer_id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:443:9 [INFO] [stdout] | [INFO] [stdout] 443 | return ImageId { id: id }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 443 - return ImageId { id: id }; [INFO] [stdout] 443 + ImageId { id: id } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:477:9 [INFO] [stdout] | [INFO] [stdout] 477 | return ImageViewId { id: id }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 477 - return ImageViewId { id: id }; [INFO] [stdout] 477 + ImageViewId { id: id } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:459:28 [INFO] [stdout] | [INFO] [stdout] 459 | let img = unsafe { (&mut *self.image_pool.get()).get_ref(image_id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 459 - let img = unsafe { (&mut *self.image_pool.get()).get_ref(image_id.id) }; [INFO] [stdout] 459 + let img = unsafe { (&*self.image_pool.get()).get_ref(image_id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:528:31 [INFO] [stdout] | [INFO] [stdout] 528 | let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_write_info.buffer.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 528 - let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_write_info.buffer.id) }; [INFO] [stdout] 528 + let buffer = unsafe { (&*self.buffer_pool.get()).get_ref(buffer_write_info.buffer.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:513:9 [INFO] [stdout] | [INFO] [stdout] 513 | return SamplerId { id: id }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 513 - return SamplerId { id: id }; [INFO] [stdout] 513 + SamplerId { id: id } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:534:33 [INFO] [stdout] | [INFO] [stdout] 534 | let img_view = unsafe { (&mut *self.image_view_pool.get()).get_ref(image_write_info.view.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 534 - let img_view = unsafe { (&mut *self.image_view_pool.get()).get_ref(image_write_info.view.id) }; [INFO] [stdout] 534 + let img_view = unsafe { (&*self.image_view_pool.get()).get_ref(image_write_info.view.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:543:32 [INFO] [stdout] | [INFO] [stdout] 543 | let sampler = unsafe { (&mut *self.sampler_pool.get()).get_ref(sampler_write_info.sampler.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 543 - let sampler = unsafe { (&mut *self.sampler_pool.get()).get_ref(sampler_write_info.sampler.id) }; [INFO] [stdout] 543 + let sampler = unsafe { (&*self.sampler_pool.get()).get_ref(sampler_write_info.sampler.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/backend/device.rs:549:1 [INFO] [stdout] | [INFO] [stdout] 549 | / //// Command buffers //// [INFO] [stdout] 550 | | impl InnerDevice { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] = note: `#[warn(clippy::four_forward_slashes)]` on by default [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 549 - //// Command buffers //// [INFO] [stdout] 550 - impl InnerDevice { [INFO] [stdout] 549 + /// Command buffers //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:561:9 [INFO] [stdout] | [INFO] [stdout] 561 | return pool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 561 - return pool; [INFO] [stdout] 561 + pool [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/backend/device.rs:565:1 [INFO] [stdout] | [INFO] [stdout] 565 | / //// Sync //// [INFO] [stdout] 566 | | impl InnerDevice { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 565 - //// Sync //// [INFO] [stdout] 566 - impl InnerDevice { [INFO] [stdout] 565 + /// Sync //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:570:9 [INFO] [stdout] | [INFO] [stdout] 570 | return unsafe { self.handle.create_fence(&create_info, None).expect("Failed to create Fence") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 570 - return unsafe { self.handle.create_fence(&create_info, None).expect("Failed to create Fence") }; [INFO] [stdout] 570 + unsafe { self.handle.create_fence(&create_info, None).expect("Failed to create Fence") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:528:31 [INFO] [stdout] | [INFO] [stdout] 528 | let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_write_info.buffer.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 528 - let buffer = unsafe { (&mut *self.buffer_pool.get()).get_ref(buffer_write_info.buffer.id) }; [INFO] [stdout] 528 + let buffer = unsafe { (&*self.buffer_pool.get()).get_ref(buffer_write_info.buffer.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:534:33 [INFO] [stdout] | [INFO] [stdout] 534 | let img_view = unsafe { (&mut *self.image_view_pool.get()).get_ref(image_write_info.view.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 534 - let img_view = unsafe { (&mut *self.image_view_pool.get()).get_ref(image_write_info.view.id) }; [INFO] [stdout] 534 + let img_view = unsafe { (&*self.image_view_pool.get()).get_ref(image_write_info.view.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/backend/device.rs:543:32 [INFO] [stdout] | [INFO] [stdout] 543 | let sampler = unsafe { (&mut *self.sampler_pool.get()).get_ref(sampler_write_info.sampler.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 543 - let sampler = unsafe { (&mut *self.sampler_pool.get()).get_ref(sampler_write_info.sampler.id) }; [INFO] [stdout] 543 + let sampler = unsafe { (&*self.sampler_pool.get()).get_ref(sampler_write_info.sampler.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/backend/device.rs:549:1 [INFO] [stdout] | [INFO] [stdout] 549 | / //// Command buffers //// [INFO] [stdout] 550 | | impl InnerDevice { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] = note: `#[warn(clippy::four_forward_slashes)]` on by default [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 549 - //// Command buffers //// [INFO] [stdout] 550 - impl InnerDevice { [INFO] [stdout] 549 + /// Command buffers //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:576:9 [INFO] [stdout] | [INFO] [stdout] 576 | return unsafe { self.handle.create_semaphore(&create_info, None).expect("Failed to create semaphore") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 576 - return unsafe { self.handle.create_semaphore(&create_info, None).expect("Failed to create semaphore") }; [INFO] [stdout] 576 + unsafe { self.handle.create_semaphore(&create_info, None).expect("Failed to create semaphore") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:561:9 [INFO] [stdout] | [INFO] [stdout] 561 | return pool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 561 - return pool; [INFO] [stdout] 561 + pool [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:584:9 [INFO] [stdout] | [INFO] [stdout] 584 | return unsafe { self.handle.create_semaphore(&create_info, None).expect("Failed to create timeline semaphore") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 584 - return unsafe { self.handle.create_semaphore(&create_info, None).expect("Failed to create timeline semaphore") }; [INFO] [stdout] 584 + unsafe { self.handle.create_semaphore(&create_info, None).expect("Failed to create timeline semaphore") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/backend/device.rs:565:1 [INFO] [stdout] | [INFO] [stdout] 565 | / //// Sync //// [INFO] [stdout] 566 | | impl InnerDevice { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 565 - //// Sync //// [INFO] [stdout] 566 - impl InnerDevice { [INFO] [stdout] 565 + /// Sync //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:570:9 [INFO] [stdout] | [INFO] [stdout] 570 | return unsafe { self.handle.create_fence(&create_info, None).expect("Failed to create Fence") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 570 - return unsafe { self.handle.create_fence(&create_info, None).expect("Failed to create Fence") }; [INFO] [stdout] 570 + unsafe { self.handle.create_fence(&create_info, None).expect("Failed to create Fence") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:576:9 [INFO] [stdout] | [INFO] [stdout] 576 | return unsafe { self.handle.create_semaphore(&create_info, None).expect("Failed to create semaphore") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 576 - return unsafe { self.handle.create_semaphore(&create_info, None).expect("Failed to create semaphore") }; [INFO] [stdout] 576 + unsafe { self.handle.create_semaphore(&create_info, None).expect("Failed to create semaphore") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/device.rs:584:9 [INFO] [stdout] | [INFO] [stdout] 584 | return unsafe { self.handle.create_semaphore(&create_info, None).expect("Failed to create timeline semaphore") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 584 - return unsafe { self.handle.create_semaphore(&create_info, None).expect("Failed to create timeline semaphore") }; [INFO] [stdout] 584 + unsafe { self.handle.create_semaphore(&create_info, None).expect("Failed to create timeline semaphore") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/backend/device.rs:612:1 [INFO] [stdout] | [INFO] [stdout] 612 | / //// Queue submission //// [INFO] [stdout] 613 | | impl InnerDevice { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 612 - //// Queue submission //// [INFO] [stdout] 613 - impl InnerDevice { [INFO] [stdout] 612 + /// Queue submission //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/backend/device.rs:612:1 [INFO] [stdout] | [INFO] [stdout] 612 | / //// Queue submission //// [INFO] [stdout] 613 | | impl InnerDevice { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 612 - //// Queue submission //// [INFO] [stdout] 613 - impl InnerDevice { [INFO] [stdout] 612 + /// Queue submission //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return (page << 32) | (index << 16) | version; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return (page << 32) | (index << 16) | version; [INFO] [stdout] 31 + (page << 32) | (index << 16) | version [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return (((id >> 32) & MASK) as usize, ((id >> 16) & MASK) as usize, (id & MASK)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return (((id >> 32) & MASK) as usize, ((id >> 16) & MASK) as usize, (id & MASK)); [INFO] [stdout] 36 + (((id >> 32) & MASK) as usize, ((id >> 16) & MASK) as usize, (id & MASK)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / return ResourcePool { [INFO] [stdout] 56 | | data: vec![std::array::from_fn(|_| (None, 0))], [INFO] [stdout] 57 | | free_indices: Vec::new(), [INFO] [stdout] 58 | | curr_index: 0, [INFO] [stdout] 59 | | curr_page: 0, [INFO] [stdout] 60 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 ~ ResourcePool { [INFO] [stdout] 56 + data: vec![std::array::from_fn(|_| (None, 0))], [INFO] [stdout] 57 + free_indices: Vec::new(), [INFO] [stdout] 58 + curr_index: 0, [INFO] [stdout] 59 + curr_page: 0, [INFO] [stdout] 60 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return (page << 32) | (index << 16) | version; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return (page << 32) | (index << 16) | version; [INFO] [stdout] 31 + (page << 32) | (index << 16) | version [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return (((id >> 32) & MASK) as usize, ((id >> 16) & MASK) as usize, (id & MASK)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return (((id >> 32) & MASK) as usize, ((id >> 16) & MASK) as usize, (id & MASK)); [INFO] [stdout] 36 + (((id >> 32) & MASK) as usize, ((id >> 16) & MASK) as usize, (id & MASK)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | return id; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return id; [INFO] [stdout] 77 + id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / return ResourcePool { [INFO] [stdout] 56 | | data: vec![std::array::from_fn(|_| (None, 0))], [INFO] [stdout] 57 | | free_indices: Vec::new(), [INFO] [stdout] 58 | | curr_index: 0, [INFO] [stdout] 59 | | curr_page: 0, [INFO] [stdout] 60 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 ~ ResourcePool { [INFO] [stdout] 56 + data: vec![std::array::from_fn(|_| (None, 0))], [INFO] [stdout] 57 + free_indices: Vec::new(), [INFO] [stdout] 58 + curr_index: 0, [INFO] [stdout] 59 + curr_page: 0, [INFO] [stdout] 60 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | return id; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return id; [INFO] [stdout] 77 + id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | return encode(page as u64, index as u64, version + 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return encode(page as u64, index as u64, version + 1); [INFO] [stdout] 85 + encode(page as u64, index as u64, version + 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | return encode(page as u64, index as u64, version + 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return encode(page as u64, index as u64, version + 1); [INFO] [stdout] 85 + encode(page as u64, index as u64, version + 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return res; [INFO] [stdout] 100 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/backend/gpu_resources.rs:96:17 [INFO] [stdout] | [INFO] [stdout] 96 | / if *res_version == version { [INFO] [stdout] 97 | | self.data[page][index] = (None, version); [INFO] [stdout] 98 | | self.free_indices.push(id); [INFO] [stdout] ... | [INFO] [stdout] 102 | | panic!("Attempted to acess with invalid ID") [INFO] [stdout] 103 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 95 ~ Some(res) [INFO] [stdout] 96 ~ if *res_version == version => { [INFO] [stdout] 97 | self.data[page][index] = (None, version); [INFO] [stdout] ... [INFO] [stdout] 100 | return res; [INFO] [stdout] 101 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return res; [INFO] [stdout] 100 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/backend/gpu_resources.rs:96:17 [INFO] [stdout] | [INFO] [stdout] 96 | / if *res_version == version { [INFO] [stdout] 97 | | self.data[page][index] = (None, version); [INFO] [stdout] 98 | | self.free_indices.push(id); [INFO] [stdout] ... | [INFO] [stdout] 102 | | panic!("Attempted to acess with invalid ID") [INFO] [stdout] 103 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 95 ~ Some(res) [INFO] [stdout] 96 ~ if *res_version == version => { [INFO] [stdout] 97 | self.data[page][index] = (None, version); [INFO] [stdout] ... [INFO] [stdout] 100 | return res; [INFO] [stdout] 101 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 119 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 - return res; [INFO] [stdout] 119 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/backend/gpu_resources.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | / if *res_version == version { [INFO] [stdout] 119 | | return res; [INFO] [stdout] 120 | | } else { [INFO] [stdout] 121 | | panic!("Attempted acess with invalid ID") [INFO] [stdout] 122 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 117 ~ Some(res) [INFO] [stdout] 118 ~ if *res_version == version => { [INFO] [stdout] 119 | return res; [INFO] [stdout] 120 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 119 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 - return res; [INFO] [stdout] 119 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/backend/gpu_resources.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | / if *res_version == version { [INFO] [stdout] 119 | | return res; [INFO] [stdout] 120 | | } else { [INFO] [stdout] 121 | | panic!("Attempted acess with invalid ID") [INFO] [stdout] 122 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 117 ~ Some(res) [INFO] [stdout] 118 ~ if *res_version == version => { [INFO] [stdout] 119 | return res; [INFO] [stdout] 120 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | / return GpuBindlessDescriptorPool { [INFO] [stdout] 242 | | pool: descriptor_pool, [INFO] [stdout] 243 | | set: bindless_set, [INFO] [stdout] 244 | | layout: bindless_set_layout, [INFO] [stdout] 245 | | device_address_buffer: Some(buffer), [INFO] [stdout] 246 | | pending_buffers: UnsafeCell::new(vec![0; 100]), [INFO] [stdout] 247 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 ~ GpuBindlessDescriptorPool { [INFO] [stdout] 242 + pool: descriptor_pool, [INFO] [stdout] 243 + set: bindless_set, [INFO] [stdout] 244 + layout: bindless_set_layout, [INFO] [stdout] 245 + device_address_buffer: Some(buffer), [INFO] [stdout] 246 + pending_buffers: UnsafeCell::new(vec![0; 100]), [INFO] [stdout] 247 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | / return GpuBindlessDescriptorPool { [INFO] [stdout] 242 | | pool: descriptor_pool, [INFO] [stdout] 243 | | set: bindless_set, [INFO] [stdout] 244 | | layout: bindless_set_layout, [INFO] [stdout] 245 | | device_address_buffer: Some(buffer), [INFO] [stdout] 246 | | pending_buffers: UnsafeCell::new(vec![0; 100]), [INFO] [stdout] 247 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 ~ GpuBindlessDescriptorPool { [INFO] [stdout] 242 + pool: descriptor_pool, [INFO] [stdout] 243 + set: bindless_set, [INFO] [stdout] 244 + layout: bindless_set_layout, [INFO] [stdout] 245 + device_address_buffer: Some(buffer), [INFO] [stdout] 246 + pending_buffers: UnsafeCell::new(vec![0; 100]), [INFO] [stdout] 247 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 328 | return std::slice::from_raw_parts(ptr, len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 - return std::slice::from_raw_parts(ptr, len); [INFO] [stdout] 328 + std::slice::from_raw_parts(ptr, len) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/gpu_resources.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 328 | return std::slice::from_raw_parts(ptr, len); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 - return std::slice::from_raw_parts(ptr, len); [INFO] [stdout] 328 + std::slice::from_raw_parts(ptr, len) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/backend/gpu_resources.rs:326:23 [INFO] [stdout] | [INFO] [stdout] 326 | let ptr = *(&(*self.pending_buffers.get()).as_ptr()) as *const u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*self.pending_buffers.get()).as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/backend/gpu_resources.rs:326:23 [INFO] [stdout] | [INFO] [stdout] 326 | let ptr = *(&(*self.pending_buffers.get()).as_ptr()) as *const u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*self.pending_buffers.get()).as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/instance.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / return InnerInstance { [INFO] [stdout] 90 | | entry: entry, [INFO] [stdout] 91 | | handle: instance, [INFO] [stdout] 92 | | debug_messenger: debug_messenger, [INFO] [stdout] 93 | | debug_loader: debug_loader, [INFO] [stdout] 94 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 ~ InnerInstance { [INFO] [stdout] 90 + entry: entry, [INFO] [stdout] 91 + handle: instance, [INFO] [stdout] 92 + debug_messenger: debug_messenger, [INFO] [stdout] 93 + debug_loader: debug_loader, [INFO] [stdout] 94 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/instance.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / return InnerInstance { [INFO] [stdout] 90 | | entry: entry, [INFO] [stdout] 91 | | handle: instance, [INFO] [stdout] 92 | | debug_messenger: debug_messenger, [INFO] [stdout] 93 | | debug_loader: debug_loader, [INFO] [stdout] 94 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 ~ InnerInstance { [INFO] [stdout] 90 + entry: entry, [INFO] [stdout] 91 + handle: instance, [INFO] [stdout] 92 + debug_messenger: debug_messenger, [INFO] [stdout] 93 + debug_loader: debug_loader, [INFO] [stdout] 94 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/backend/instance.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | / if !push_if_supported(ash::khr::wayland_surface::NAME) { [INFO] [stdout] 39 | | // If we are on Wayland but the extension isn't supported (RenderDoc), [INFO] [stdout] 40 | | // you might need to force X11 via env vars or handle the error gracefully. [INFO] [stdout] 41 | | println!("Warning: Wayland surface extension not supported by Vulkan driver/layer"); [INFO] [stdout] 42 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ raw_window_handle::RawWindowHandle::Wayland(_) [INFO] [stdout] 37 | // If RenderDoc doesn't support Wayland, try to fall back or at least don't crash here [INFO] [stdout] 38 ~ if !push_if_supported(ash::khr::wayland_surface::NAME) => { [INFO] [stdout] 39 | // If we are on Wayland but the extension isn't supported (RenderDoc), [INFO] [stdout] 40 | // you might need to force X11 via env vars or handle the error gracefully. [INFO] [stdout] 41 | println!("Warning: Wayland surface extension not supported by Vulkan driver/layer"); [INFO] [stdout] 42 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/backend/instance.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | / if !push_if_supported(ash::khr::wayland_surface::NAME) { [INFO] [stdout] 39 | | // If we are on Wayland but the extension isn't supported (RenderDoc), [INFO] [stdout] 40 | | // you might need to force X11 via env vars or handle the error gracefully. [INFO] [stdout] 41 | | println!("Warning: Wayland surface extension not supported by Vulkan driver/layer"); [INFO] [stdout] 42 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ raw_window_handle::RawWindowHandle::Wayland(_) [INFO] [stdout] 37 | // If RenderDoc doesn't support Wayland, try to fall back or at least don't crash here [INFO] [stdout] 38 ~ if !push_if_supported(ash::khr::wayland_surface::NAME) => { [INFO] [stdout] 39 | // If we are on Wayland but the extension isn't supported (RenderDoc), [INFO] [stdout] 40 | // you might need to force X11 via env vars or handle the error gracefully. [INFO] [stdout] 41 | println!("Warning: Wayland surface extension not supported by Vulkan driver/layer"); [INFO] [stdout] 42 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ApiVersion` which implements the `Copy` trait [INFO] [stdout] --> src/backend/instance.rs:61:26 [INFO] [stdout] | [INFO] [stdout] 61 | api_version: instance_create_info.api_version.clone() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `instance_create_info.api_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/backend/instance.rs:119:16 [INFO] [stdout] | [INFO] [stdout] 119 | if !self.debug_messenger.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.debug_messenger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.debug_messenger` after checking its variant with `is_none` [INFO] [stdout] --> src/backend/instance.rs:124:83 [INFO] [stdout] | [INFO] [stdout] 119 | if !self.debug_messenger.is_none() { [INFO] [stdout] | ------------------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 124 | self.debug_loader.as_mut().unwrap().destroy_debug_utils_messenger(self.debug_messenger.unwrap(), None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/pipelines.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / return InnerPipelineManager { [INFO] [stdout] 37 | | desc_layout: device.bindless_descriptors.layout, [INFO] [stdout] 38 | | pipelines: UnsafeCell::new(ResourcePool::new()), [INFO] [stdout] 39 | | device: device, [INFO] [stdout] 40 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 ~ InnerPipelineManager { [INFO] [stdout] 37 + desc_layout: device.bindless_descriptors.layout, [INFO] [stdout] 38 + pipelines: UnsafeCell::new(ResourcePool::new()), [INFO] [stdout] 39 + device: device, [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/pipelines.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return dst_path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return dst_path; [INFO] [stdout] 59 + dst_path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/pipelines.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return bytes.chunks_exact(4).map(|b| u32::from_le_bytes(b.try_into().unwrap())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return bytes.chunks_exact(4).map(|b| u32::from_le_bytes(b.try_into().unwrap())).collect(); [INFO] [stdout] 65 + bytes.chunks_exact(4).map(|b| u32::from_le_bytes(b.try_into().unwrap())).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/pipelines.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return unsafe { self.device.handle.create_shader_module(&module_create_info, None).expect("Failed to crate shader module") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return unsafe { self.device.handle.create_shader_module(&module_create_info, None).expect("Failed to crate shader module") }; [INFO] [stdout] 73 + unsafe { self.device.handle.create_shader_module(&module_create_info, None).expect("Failed to crate shader module") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/backend/pipelines.rs:77:1 [INFO] [stdout] | [INFO] [stdout] 77 | / //// Pipeline creation //// [INFO] [stdout] 78 | | impl InnerPipelineManager { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 77 - //// Pipeline creation //// [INFO] [stdout] 78 - impl InnerPipelineManager { [INFO] [stdout] 77 + /// Pipeline creation //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/pipelines.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | return Pipeline::Rasterization(raw_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 233 - return Pipeline::Rasterization(raw_id); [INFO] [stdout] 233 + Pipeline::Rasterization(raw_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/backend/pipelines.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 193 | / let c = if desc.outputs.stencil.is_some() { [INFO] [stdout] 194 | | b.stencil_attachment_format(desc.outputs.stencil.clone().unwrap().to_vk_format()) [INFO] [stdout] 195 | | } else { [INFO] [stdout] 196 | | b [INFO] [stdout] 197 | | }; [INFO] [stdout] | |______________- unnecessary `let` binding [INFO] [stdout] 198 | [INFO] [stdout] 199 | c [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 193 ~ [INFO] [stdout] 194 | [INFO] [stdout] 195 ~ if desc.outputs.stencil.is_some() { [INFO] [stdout] 196 + b.stencil_attachment_format(desc.outputs.stencil.clone().unwrap().to_vk_format()) [INFO] [stdout] 197 + } else { [INFO] [stdout] 198 + b [INFO] [stdout] 199 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/backend/pipelines.rs:191:81 [INFO] [stdout] | [INFO] [stdout] 191 | ...pth_attachment_format(desc.outputs.depth.clone().unwrap().to_vk_format()) } else { a }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `desc.outputs.depth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/backend/pipelines.rs:194:45 [INFO] [stdout] | [INFO] [stdout] 194 | b.stencil_attachment_format(desc.outputs.stencil.clone().unwrap().to_vk_format()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `desc.outputs.stencil` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/pipelines.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | return Pipeline::Compute(raw_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 274 - return Pipeline::Compute(raw_id); [INFO] [stdout] 274 + Pipeline::Compute(raw_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ApiVersion` which implements the `Copy` trait [INFO] [stdout] --> src/backend/instance.rs:61:26 [INFO] [stdout] | [INFO] [stdout] 61 | api_version: instance_create_info.api_version.clone() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `instance_create_info.api_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/swapchain.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return None; [INFO] [stdout] 42 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/swapchain.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | return Some(SwapchainSupport { capabilities, formats, present_modes }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Some(SwapchainSupport { capabilities, formats, present_modes }); [INFO] [stdout] 44 + Some(SwapchainSupport { capabilities, formats, present_modes }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/swapchain.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | / return InnerSwapchain { [INFO] [stdout] 167 | | handle: swapchain, [INFO] [stdout] 168 | | swapchain_loader: swapchain_loader, [INFO] [stdout] 169 | | desc: swapchain_description.clone(), [INFO] [stdout] ... | [INFO] [stdout] 178 | | device: device, [INFO] [stdout] 179 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 ~ InnerSwapchain { [INFO] [stdout] 167 + handle: swapchain, [INFO] [stdout] 168 + swapchain_loader: swapchain_loader, [INFO] [stdout] 169 + desc: swapchain_description.clone(), [INFO] [stdout] 170 + curr_img_indeices: UnsafeCell::new(VecDeque::with_capacity(swapchain_description.image_count as usize)), [INFO] [stdout] 171 + image_views: image_views, [INFO] [stdout] 172 + images: image_ids, [INFO] [stdout] 173 + image_semaphores, [INFO] [stdout] 174 + preset_semaphores: present_semaphore, [INFO] [stdout] 175 + fences: fences, [INFO] [stdout] 176 + image_timeline: Cell::new(0), [INFO] [stdout] 177 + frame_timeline: Cell::new(0), [INFO] [stdout] 178 + device: device, [INFO] [stdout] 179 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/backend/instance.rs:119:16 [INFO] [stdout] | [INFO] [stdout] 119 | if !self.debug_messenger.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.debug_messenger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.debug_messenger` after checking its variant with `is_none` [INFO] [stdout] --> src/backend/instance.rs:124:83 [INFO] [stdout] | [INFO] [stdout] 119 | if !self.debug_messenger.is_none() { [INFO] [stdout] | ------------------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 124 | self.debug_loader.as_mut().unwrap().destroy_debug_utils_messenger(self.debug_messenger.unwrap(), None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SwapchainDescription` which implements the `Copy` trait [INFO] [stdout] --> src/backend/swapchain.rs:169:19 [INFO] [stdout] | [INFO] [stdout] 169 | desc: swapchain_description.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*swapchain_description` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/swapchain.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | / return Surface { [INFO] [stdout] 217 | | handle: surface_handle, [INFO] [stdout] 218 | | loader: ash::khr::surface::Instance::new(&device.instance.entry, &device.instance.handle), [INFO] [stdout] 219 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 216 ~ Surface { [INFO] [stdout] 217 + handle: surface_handle, [INFO] [stdout] 218 + loader: ash::khr::surface::Instance::new(&device.instance.entry, &device.instance.handle), [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/pipelines.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / return InnerPipelineManager { [INFO] [stdout] 37 | | desc_layout: device.bindless_descriptors.layout, [INFO] [stdout] 38 | | pipelines: UnsafeCell::new(ResourcePool::new()), [INFO] [stdout] 39 | | device: device, [INFO] [stdout] 40 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 ~ InnerPipelineManager { [INFO] [stdout] 37 + desc_layout: device.bindless_descriptors.layout, [INFO] [stdout] 38 + pipelines: UnsafeCell::new(ResourcePool::new()), [INFO] [stdout] 39 + device: device, [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/pipelines.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return dst_path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return dst_path; [INFO] [stdout] 59 + dst_path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/swapchain.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 249 | / return AcquiredImage { [INFO] [stdout] 250 | | image: self.images[index as usize], [INFO] [stdout] 251 | | view: self.image_views[index as usize], [INFO] [stdout] 252 | | image_semaphore: image_semaphore, [INFO] [stdout] ... | [INFO] [stdout] 255 | | curr_frame: frame_timeline, [INFO] [stdout] 256 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 249 ~ AcquiredImage { [INFO] [stdout] 250 + image: self.images[index as usize], [INFO] [stdout] 251 + view: self.image_views[index as usize], [INFO] [stdout] 252 + image_semaphore: image_semaphore, [INFO] [stdout] 253 + present_semaphore: self.preset_semaphores[index as usize], [INFO] [stdout] 254 + fence: fence, [INFO] [stdout] 255 + curr_frame: frame_timeline, [INFO] [stdout] 256 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/pipelines.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return bytes.chunks_exact(4).map(|b| u32::from_le_bytes(b.try_into().unwrap())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return bytes.chunks_exact(4).map(|b| u32::from_le_bytes(b.try_into().unwrap())).collect(); [INFO] [stdout] 65 + bytes.chunks_exact(4).map(|b| u32::from_le_bytes(b.try_into().unwrap())).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/pipelines.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return unsafe { self.device.handle.create_shader_module(&module_create_info, None).expect("Failed to crate shader module") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return unsafe { self.device.handle.create_shader_module(&module_create_info, None).expect("Failed to crate shader module") }; [INFO] [stdout] 73 + unsafe { self.device.handle.create_shader_module(&module_create_info, None).expect("Failed to crate shader module") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/backend/pipelines.rs:77:1 [INFO] [stdout] | [INFO] [stdout] 77 | / //// Pipeline creation //// [INFO] [stdout] 78 | | impl InnerPipelineManager { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 77 - //// Pipeline creation //// [INFO] [stdout] 78 - impl InnerPipelineManager { [INFO] [stdout] 77 + /// Pipeline creation //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/pipelines.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | return Pipeline::Rasterization(raw_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 233 - return Pipeline::Rasterization(raw_id); [INFO] [stdout] 233 + Pipeline::Rasterization(raw_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/commands.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | / return ExecutableCommandBuffer { [INFO] [stdout] 52 | | handle: return_buffer, [INFO] [stdout] 53 | | queue_type: self.queue_type, [INFO] [stdout] 54 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 ~ ExecutableCommandBuffer { [INFO] [stdout] 52 + handle: return_buffer, [INFO] [stdout] 53 + queue_type: self.queue_type, [INFO] [stdout] 54 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `color_attachement.resolve_image_view` after checking its variant with `is_some` [INFO] [stdout] --> src/core/commands.rs:64:54 [INFO] [stdout] | [INFO] [stdout] 63 | let resolve_image_view = if color_attachement.resolve_image_view.is_some() { [INFO] [stdout] | ------------------------------------------------- help: try: `if let Some() = color_attachement.resolve_image_view` [INFO] [stdout] 64 | self.check_and_remeber_image_view_id(color_attachement.resolve_image_view.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `rendering_begin_info.depth_attachment` after checking its variant with `is_some` [INFO] [stdout] --> src/core/commands.rs:97:36 [INFO] [stdout] | [INFO] [stdout] 96 | if rendering_begin_info.depth_attachment.is_some() { [INFO] [stdout] | -------------------------------------------------- help: try: `if let Some() = &rendering_begin_info.depth_attachment` [INFO] [stdout] 97 | let depth_attachment = rendering_begin_info.depth_attachment.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `depth_attachment.resolve_image_view` after checking its variant with `is_some` [INFO] [stdout] --> src/core/commands.rs:101:54 [INFO] [stdout] | [INFO] [stdout] 100 | let resolve_image_view = if depth_attachment.resolve_image_view.is_some() { [INFO] [stdout] | ------------------------------------------------ help: try: `if let Some() = depth_attachment.resolve_image_view` [INFO] [stdout] 101 | self.check_and_remeber_image_view_id(depth_attachment.resolve_image_view.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `rendering_begin_info.stencil_attachment` after checking its variant with `is_some` [INFO] [stdout] --> src/core/commands.rs:120:38 [INFO] [stdout] | [INFO] [stdout] 119 | if rendering_begin_info.stencil_attachment.is_some() { [INFO] [stdout] | ---------------------------------------------------- help: try: `if let Some() = &rendering_begin_info.stencil_attachment` [INFO] [stdout] 120 | let stencil_attachment = rendering_begin_info.stencil_attachment.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stencil_attachment.resolve_image_view` after checking its variant with `is_some` [INFO] [stdout] --> src/core/commands.rs:124:54 [INFO] [stdout] | [INFO] [stdout] 123 | let resolve_image_view = if stencil_attachment.resolve_image_view.is_some() { [INFO] [stdout] | -------------------------------------------------- help: try: `if let Some() = stencil_attachment.resolve_image_view` [INFO] [stdout] 124 | self.check_and_remeber_image_view_id(stencil_attachment.resolve_image_view.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/backend/pipelines.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 193 | / let c = if desc.outputs.stencil.is_some() { [INFO] [stdout] 194 | | b.stencil_attachment_format(desc.outputs.stencil.clone().unwrap().to_vk_format()) [INFO] [stdout] 195 | | } else { [INFO] [stdout] 196 | | b [INFO] [stdout] 197 | | }; [INFO] [stdout] | |______________- unnecessary `let` binding [INFO] [stdout] 198 | [INFO] [stdout] 199 | c [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 193 ~ [INFO] [stdout] 194 | [INFO] [stdout] 195 ~ if desc.outputs.stencil.is_some() { [INFO] [stdout] 196 + b.stencil_attachment_format(desc.outputs.stencil.clone().unwrap().to_vk_format()) [INFO] [stdout] 197 + } else { [INFO] [stdout] 198 + b [INFO] [stdout] 199 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/backend/pipelines.rs:191:81 [INFO] [stdout] | [INFO] [stdout] 191 | ...pth_attachment_format(desc.outputs.depth.clone().unwrap().to_vk_format()) } else { a }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `desc.outputs.depth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/backend/pipelines.rs:194:45 [INFO] [stdout] | [INFO] [stdout] 194 | b.stencil_attachment_format(desc.outputs.stencil.clone().unwrap().to_vk_format()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `desc.outputs.stencil` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/pipelines.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | return Pipeline::Compute(raw_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 274 - return Pipeline::Compute(raw_id); [INFO] [stdout] 274 + Pipeline::Compute(raw_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/swapchain.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return None; [INFO] [stdout] 42 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/swapchain.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | return Some(SwapchainSupport { capabilities, formats, present_modes }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Some(SwapchainSupport { capabilities, formats, present_modes }); [INFO] [stdout] 44 + Some(SwapchainSupport { capabilities, formats, present_modes }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/swapchain.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | / return InnerSwapchain { [INFO] [stdout] 167 | | handle: swapchain, [INFO] [stdout] 168 | | swapchain_loader: swapchain_loader, [INFO] [stdout] 169 | | desc: swapchain_description.clone(), [INFO] [stdout] ... | [INFO] [stdout] 178 | | device: device, [INFO] [stdout] 179 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 ~ InnerSwapchain { [INFO] [stdout] 167 + handle: swapchain, [INFO] [stdout] 168 + swapchain_loader: swapchain_loader, [INFO] [stdout] 169 + desc: swapchain_description.clone(), [INFO] [stdout] 170 + curr_img_indeices: UnsafeCell::new(VecDeque::with_capacity(swapchain_description.image_count as usize)), [INFO] [stdout] 171 + image_views: image_views, [INFO] [stdout] 172 + images: image_ids, [INFO] [stdout] 173 + image_semaphores, [INFO] [stdout] 174 + preset_semaphores: present_semaphore, [INFO] [stdout] 175 + fences: fences, [INFO] [stdout] 176 + image_timeline: Cell::new(0), [INFO] [stdout] 177 + frame_timeline: Cell::new(0), [INFO] [stdout] 178 + device: device, [INFO] [stdout] 179 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> src/core/commands.rs:367:23 [INFO] [stdout] | [INFO] [stdout] 367 | let len = info.data.len() * std::mem::size_of::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(info.data)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SwapchainDescription` which implements the `Copy` trait [INFO] [stdout] --> src/backend/swapchain.rs:169:19 [INFO] [stdout] | [INFO] [stdout] 169 | desc: swapchain_description.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*swapchain_description` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/commands.rs:503:9 [INFO] [stdout] | [INFO] [stdout] 503 | return img.handle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 503 - return img.handle; [INFO] [stdout] 503 + img.handle [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/core/commands.rs:501:28 [INFO] [stdout] | [INFO] [stdout] 501 | let img = unsafe { (&mut *self.device.image_pool.get()).get_ref(id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 501 - let img = unsafe { (&mut *self.device.image_pool.get()).get_ref(id.id) }; [INFO] [stdout] 501 + let img = unsafe { (&*self.device.image_pool.get()).get_ref(id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/commands.rs:509:9 [INFO] [stdout] | [INFO] [stdout] 509 | return buffer.handle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 509 - return buffer.handle; [INFO] [stdout] 509 + buffer.handle [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/core/commands.rs:507:31 [INFO] [stdout] | [INFO] [stdout] 507 | let buffer = unsafe { (&mut *self.device.buffer_pool.get()).get_ref(id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 507 - let buffer = unsafe { (&mut *self.device.buffer_pool.get()).get_ref(id.id) }; [INFO] [stdout] 507 + let buffer = unsafe { (&*self.device.buffer_pool.get()).get_ref(id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/swapchain.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | / return Surface { [INFO] [stdout] 217 | | handle: surface_handle, [INFO] [stdout] 218 | | loader: ash::khr::surface::Instance::new(&device.instance.entry, &device.instance.handle), [INFO] [stdout] 219 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 216 ~ Surface { [INFO] [stdout] 217 + handle: surface_handle, [INFO] [stdout] 218 + loader: ash::khr::surface::Instance::new(&device.instance.entry, &device.instance.handle), [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/commands.rs:514:9 [INFO] [stdout] | [INFO] [stdout] 514 | return img_view.handle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 514 - return img_view.handle; [INFO] [stdout] 514 + img_view.handle [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/core/commands.rs:513:33 [INFO] [stdout] | [INFO] [stdout] 513 | let img_view = unsafe { (&mut *self.device.image_view_pool.get()).get_ref(id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 513 - let img_view = unsafe { (&mut *self.device.image_view_pool.get()).get_ref(id.id) }; [INFO] [stdout] 513 + let img_view = unsafe { (&*self.device.image_view_pool.get()).get_ref(id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/commands.rs:522:9 [INFO] [stdout] | [INFO] [stdout] 522 | return cmd_buffer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 522 - return cmd_buffer; [INFO] [stdout] 522 + cmd_buffer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/commands.rs:572:9 [INFO] [stdout] | [INFO] [stdout] 572 | / return match self { [INFO] [stdout] 573 | | Self::Binary(b) => b.handle, [INFO] [stdout] 574 | | Self::Timeline(t) => t.handle, [INFO] [stdout] 575 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 572 ~ match self { [INFO] [stdout] 573 + Self::Binary(b) => b.handle, [INFO] [stdout] 574 + Self::Timeline(t) => t.handle, [INFO] [stdout] 575 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / return Swapchain { [INFO] [stdout] 25 | | inner: Arc::new(inner_swapchain), [INFO] [stdout] 26 | | surface: Arc::new(surface), [INFO] [stdout] 27 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 ~ Swapchain { [INFO] [stdout] 25 + inner: Arc::new(inner_swapchain), [INFO] [stdout] 26 + surface: Arc::new(surface), [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/backend/swapchain.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 249 | / return AcquiredImage { [INFO] [stdout] 250 | | image: self.images[index as usize], [INFO] [stdout] 251 | | view: self.image_views[index as usize], [INFO] [stdout] 252 | | image_semaphore: image_semaphore, [INFO] [stdout] ... | [INFO] [stdout] 255 | | curr_frame: frame_timeline, [INFO] [stdout] 256 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 249 ~ AcquiredImage { [INFO] [stdout] 250 + image: self.images[index as usize], [INFO] [stdout] 251 + view: self.image_views[index as usize], [INFO] [stdout] 252 + image_semaphore: image_semaphore, [INFO] [stdout] 253 + present_semaphore: self.preset_semaphores[index as usize], [INFO] [stdout] 254 + fence: fence, [INFO] [stdout] 255 + curr_frame: frame_timeline, [INFO] [stdout] 256 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/core/device.rs:25:20 [INFO] [stdout] | [INFO] [stdout] 25 | inner: Arc::new(inner_swapchain), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc` is not `Send` and `Sync` as `InnerSwapchain` is not `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `InnerSwapchain` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return self.inner_device.create_buffer(buffer_desc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return self.inner_device.create_buffer(buffer_desc); [INFO] [stdout] 34 + self.inner_device.create_buffer(buffer_desc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return self.inner_device.get_raw_ptr(buffer_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return self.inner_device.get_raw_ptr(buffer_id); [INFO] [stdout] 46 + self.inner_device.get_raw_ptr(buffer_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | return self.inner_device.get_device_address(buffer_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return self.inner_device.get_device_address(buffer_id); [INFO] [stdout] 50 + self.inner_device.get_device_address(buffer_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return self.inner_device.create_image(image_desc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return self.inner_device.create_image(image_desc); [INFO] [stdout] 57 + self.inner_device.create_image(image_desc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return self.inner_device.create_image_view(image_id, image_view_desc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return self.inner_device.create_image_view(image_id, image_view_desc); [INFO] [stdout] 68 + self.inner_device.create_image_view(image_id, image_view_desc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return self.inner_device.create_sampler(sampler_desc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return self.inner_device.create_sampler(sampler_desc); [INFO] [stdout] 79 + self.inner_device.create_sampler(sampler_desc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | return Texture { image: img, image_view: img_view }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return Texture { image: img, image_view: img_view }; [INFO] [stdout] 99 + Texture { image: img, image_view: img_view } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return self.pipeline_manager.create_raster_pipeline_data(raster_pipeline_desc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return self.pipeline_manager.create_raster_pipeline_data(raster_pipeline_desc); [INFO] [stdout] 110 + self.pipeline_manager.create_raster_pipeline_data(raster_pipeline_desc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/commands.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | / return ExecutableCommandBuffer { [INFO] [stdout] 52 | | handle: return_buffer, [INFO] [stdout] 53 | | queue_type: self.queue_type, [INFO] [stdout] 54 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 ~ ExecutableCommandBuffer { [INFO] [stdout] 52 + handle: return_buffer, [INFO] [stdout] 53 + queue_type: self.queue_type, [INFO] [stdout] 54 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return self.pipeline_manager.create_compute_pipeline(compute_pipeline_desc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return self.pipeline_manager.create_compute_pipeline(compute_pipeline_desc); [INFO] [stdout] 114 + self.pipeline_manager.create_compute_pipeline(compute_pipeline_desc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `color_attachement.resolve_image_view` after checking its variant with `is_some` [INFO] [stdout] --> src/core/commands.rs:64:54 [INFO] [stdout] | [INFO] [stdout] 63 | let resolve_image_view = if color_attachement.resolve_image_view.is_some() { [INFO] [stdout] | ------------------------------------------------- help: try: `if let Some() = color_attachement.resolve_image_view` [INFO] [stdout] 64 | self.check_and_remeber_image_view_id(color_attachement.resolve_image_view.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | / return CommandRecorder { [INFO] [stdout] 158 | | handle: self.inner_device.create_cmd_recorder_data(queue_type), [INFO] [stdout] 159 | | commad_buffers: smallvec![], [INFO] [stdout] 160 | | exec_command_buffers: smallvec![], [INFO] [stdout] ... | [INFO] [stdout] 164 | | device: self.inner_device.clone(), [INFO] [stdout] 165 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 ~ CommandRecorder { [INFO] [stdout] 158 + handle: self.inner_device.create_cmd_recorder_data(queue_type), [INFO] [stdout] 159 + commad_buffers: smallvec![], [INFO] [stdout] 160 + exec_command_buffers: smallvec![], [INFO] [stdout] 161 + current_commad_buffer: vk::CommandBuffer::null(), [INFO] [stdout] 162 + pipeline_manager: self.pipeline_manager.clone(), [INFO] [stdout] 163 + queue_type: queue_type, [INFO] [stdout] 164 + device: self.inner_device.clone(), [INFO] [stdout] 165 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `rendering_begin_info.depth_attachment` after checking its variant with `is_some` [INFO] [stdout] --> src/core/commands.rs:97:36 [INFO] [stdout] | [INFO] [stdout] 96 | if rendering_begin_info.depth_attachment.is_some() { [INFO] [stdout] | -------------------------------------------------- help: try: `if let Some() = &rendering_begin_info.depth_attachment` [INFO] [stdout] 97 | let depth_attachment = rendering_begin_info.depth_attachment.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `depth_attachment.resolve_image_view` after checking its variant with `is_some` [INFO] [stdout] --> src/core/commands.rs:101:54 [INFO] [stdout] | [INFO] [stdout] 100 | let resolve_image_view = if depth_attachment.resolve_image_view.is_some() { [INFO] [stdout] | ------------------------------------------------ help: try: `if let Some() = depth_attachment.resolve_image_view` [INFO] [stdout] 101 | self.check_and_remeber_image_view_id(depth_attachment.resolve_image_view.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `rendering_begin_info.stencil_attachment` after checking its variant with `is_some` [INFO] [stdout] --> src/core/commands.rs:120:38 [INFO] [stdout] | [INFO] [stdout] 119 | if rendering_begin_info.stencil_attachment.is_some() { [INFO] [stdout] | ---------------------------------------------------- help: try: `if let Some() = &rendering_begin_info.stencil_attachment` [INFO] [stdout] 120 | let stencil_attachment = rendering_begin_info.stencil_attachment.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stencil_attachment.resolve_image_view` after checking its variant with `is_some` [INFO] [stdout] --> src/core/commands.rs:124:54 [INFO] [stdout] | [INFO] [stdout] 123 | let resolve_image_view = if stencil_attachment.resolve_image_view.is_some() { [INFO] [stdout] | -------------------------------------------------- help: try: `if let Some() = stencil_attachment.resolve_image_view` [INFO] [stdout] 124 | self.check_and_remeber_image_view_id(stencil_attachment.resolve_image_view.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | / return Fence { [INFO] [stdout] 173 | | handle: self.inner_device.create_fence(signaled), [INFO] [stdout] 174 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 ~ Fence { [INFO] [stdout] 173 + handle: self.inner_device.create_fence(signaled), [INFO] [stdout] 174 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | / return Semaphore::Binary(BinarySemaphore { [INFO] [stdout] 179 | | handle: self.inner_device.create_binary_semaphore(), [INFO] [stdout] 180 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 178 ~ Semaphore::Binary(BinarySemaphore { [INFO] [stdout] 179 + handle: self.inner_device.create_binary_semaphore(), [INFO] [stdout] 180 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | / return Semaphore::Timeline(TimelineSemaphore { [INFO] [stdout] 185 | | handle: self.inner_device.create_timeline_semaphore(), [INFO] [stdout] 186 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 ~ Semaphore::Timeline(TimelineSemaphore { [INFO] [stdout] 185 + handle: self.inner_device.create_timeline_semaphore(), [INFO] [stdout] 186 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/core/gpu_resources.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::u64; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u64::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/gpu_resources.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | return BufferId { id: u64::MAX }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return BufferId { id: u64::MAX }; [INFO] [stdout] 10 + BufferId { id: u64::MAX } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/gpu_resources.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return ImageId { id: u64::MAX }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return ImageId { id: u64::MAX }; [INFO] [stdout] 21 + ImageId { id: u64::MAX } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/gpu_resources.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return SamplerId { id: u64::MAX }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return SamplerId { id: u64::MAX }; [INFO] [stdout] 32 + SamplerId { id: u64::MAX } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/gpu_resources.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return ImageViewId { id: u64::MAX }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return ImageViewId { id: u64::MAX }; [INFO] [stdout] 43 + ImageViewId { id: u64::MAX } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/gpu_resources.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return Pipeline::Rasterization(u64::MAX); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return Pipeline::Rasterization(u64::MAX); [INFO] [stdout] 57 + Pipeline::Rasterization(u64::MAX) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/gpu_resources.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / return match self { [INFO] [stdout] 62 | | Pipeline::Compute(id) => *id, [INFO] [stdout] 63 | | Pipeline::Rasterization(id) => *id, [INFO] [stdout] 64 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ match self { [INFO] [stdout] 62 + Pipeline::Compute(id) => *id, [INFO] [stdout] 63 + Pipeline::Rasterization(id) => *id, [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/instance.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return Instance { inner: Arc::new(inner_instance) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return Instance { inner: Arc::new(inner_instance) }; [INFO] [stdout] 18 + Instance { inner: Arc::new(inner_instance) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/instance.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / return Device { [INFO] [stdout] 25 | | inner_device: inner_device, [INFO] [stdout] 26 | | pipeline_manager: pipeline_manager, [INFO] [stdout] 27 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 ~ Device { [INFO] [stdout] 25 + inner_device: inner_device, [INFO] [stdout] 26 + pipeline_manager: pipeline_manager, [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/core/instance.rs:23:32 [INFO] [stdout] | [INFO] [stdout] 23 | let pipeline_manager = Arc::new(InnerPipelineManager::new(inner_device.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc` is not `Send` and `Sync` as `InnerPipelineManager` is not `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `InnerPipelineManager` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SwapchainDescription` which implements the `Copy` trait [INFO] [stdout] --> src/core/swapchain.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 30 | let old_desc = self.inner.desc.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.inner.desc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/core/swapchain.rs:38:22 [INFO] [stdout] | [INFO] [stdout] 38 | self.inner = Arc::new(new_swapchain); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc` is not `Send` and `Sync` as `InnerSwapchain` is not `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `InnerSwapchain` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/swapchain.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return self.inner.acquire_image(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return self.inner.acquire_image(); [INFO] [stdout] 42 + self.inner.acquire_image() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/definations/commands.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::u64; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u64::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:24:37 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) const fn to_vk_flags(&self) -> vk::CommandBufferUsageFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> src/core/commands.rs:367:23 [INFO] [stdout] | [INFO] [stdout] 367 | let len = info.data.len() * std::mem::size_of::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(info.data)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:40:36 [INFO] [stdout] | [INFO] [stdout] 40 | pub(crate) const fn to_vk_flag(&self) -> vk::IndexType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:64:31 [INFO] [stdout] | [INFO] [stdout] 64 | pub(crate) const fn to_vk(&self) -> vk::AttachmentLoadOp { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:82:31 [INFO] [stdout] | [INFO] [stdout] 82 | pub(crate) const fn to_vk(&self) -> vk::AttachmentStoreOp { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 102 | pub(crate) const fn to_vk(&self) -> vk::ResolveModeFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/commands.rs:503:9 [INFO] [stdout] | [INFO] [stdout] 503 | return img.handle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 503 - return img.handle; [INFO] [stdout] 503 + img.handle [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/core/commands.rs:501:28 [INFO] [stdout] | [INFO] [stdout] 501 | let img = unsafe { (&mut *self.device.image_pool.get()).get_ref(id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 501 - let img = unsafe { (&mut *self.device.image_pool.get()).get_ref(id.id) }; [INFO] [stdout] 501 + let img = unsafe { (&*self.device.image_pool.get()).get_ref(id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/commands.rs:509:9 [INFO] [stdout] | [INFO] [stdout] 509 | return buffer.handle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 509 - return buffer.handle; [INFO] [stdout] 509 + buffer.handle [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/core/commands.rs:507:31 [INFO] [stdout] | [INFO] [stdout] 507 | let buffer = unsafe { (&mut *self.device.buffer_pool.get()).get_ref(id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 507 - let buffer = unsafe { (&mut *self.device.buffer_pool.get()).get_ref(id.id) }; [INFO] [stdout] 507 + let buffer = unsafe { (&*self.device.buffer_pool.get()).get_ref(id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:123:31 [INFO] [stdout] | [INFO] [stdout] 123 | pub(crate) const fn to_vk(&self) -> vk::ClearValue { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/commands.rs:514:9 [INFO] [stdout] | [INFO] [stdout] 514 | return img_view.handle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 514 - return img_view.handle; [INFO] [stdout] 514 + img_view.handle [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_ref` doesn't need a mutable reference [INFO] [stdout] --> src/core/commands.rs:513:33 [INFO] [stdout] | [INFO] [stdout] 513 | let img_view = unsafe { (&mut *self.device.image_view_pool.get()).get_ref(id.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 513 - let img_view = unsafe { (&mut *self.device.image_view_pool.get()).get_ref(id.id) }; [INFO] [stdout] 513 + let img_view = unsafe { (&*self.device.image_view_pool.get()).get_ref(id.id) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/commands.rs:522:9 [INFO] [stdout] | [INFO] [stdout] 522 | return cmd_buffer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 522 - return cmd_buffer; [INFO] [stdout] 522 + cmd_buffer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/commands.rs:572:9 [INFO] [stdout] | [INFO] [stdout] 572 | / return match self { [INFO] [stdout] 573 | | Self::Binary(b) => b.handle, [INFO] [stdout] 574 | | Self::Timeline(t) => t.handle, [INFO] [stdout] 575 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 572 ~ match self { [INFO] [stdout] 573 + Self::Binary(b) => b.handle, [INFO] [stdout] 574 + Self::Timeline(t) => t.handle, [INFO] [stdout] 575 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/definations/commands.rs:165:43 [INFO] [stdout] | [INFO] [stdout] 165 | image_view: ImageViewId { id: u64::max_value() }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 165 - image_view: ImageViewId { id: u64::max_value() }, [INFO] [stdout] 165 + image_view: ImageViewId { id: u64::MAX }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / return Swapchain { [INFO] [stdout] 25 | | inner: Arc::new(inner_swapchain), [INFO] [stdout] 26 | | surface: Arc::new(surface), [INFO] [stdout] 27 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 ~ Swapchain { [INFO] [stdout] 25 + inner: Arc::new(inner_swapchain), [INFO] [stdout] 26 + surface: Arc::new(surface), [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:187:31 [INFO] [stdout] | [INFO] [stdout] 187 | pub(crate) const fn to_vk(&self) -> vk::RenderingFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/core/device.rs:25:20 [INFO] [stdout] | [INFO] [stdout] 25 | inner: Arc::new(inner_swapchain), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc` is not `Send` and `Sync` as `InnerSwapchain` is not `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `InnerSwapchain` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return self.inner_device.create_buffer(buffer_desc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return self.inner_device.create_buffer(buffer_desc); [INFO] [stdout] 34 + self.inner_device.create_buffer(buffer_desc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return self.inner_device.get_raw_ptr(buffer_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return self.inner_device.get_raw_ptr(buffer_id); [INFO] [stdout] 46 + self.inner_device.get_raw_ptr(buffer_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | return self.inner_device.get_device_address(buffer_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return self.inner_device.get_device_address(buffer_id); [INFO] [stdout] 50 + self.inner_device.get_device_address(buffer_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return self.inner_device.create_image(image_desc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return self.inner_device.create_image(image_desc); [INFO] [stdout] 57 + self.inner_device.create_image(image_desc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return self.inner_device.create_image_view(image_id, image_view_desc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return self.inner_device.create_image_view(image_id, image_view_desc); [INFO] [stdout] 68 + self.inner_device.create_image_view(image_id, image_view_desc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return self.inner_device.create_sampler(sampler_desc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return self.inner_device.create_sampler(sampler_desc); [INFO] [stdout] 79 + self.inner_device.create_sampler(sampler_desc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | return Texture { image: img, image_view: img_view }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return Texture { image: img, image_view: img_view }; [INFO] [stdout] 99 + Texture { image: img, image_view: img_view } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return self.pipeline_manager.create_raster_pipeline_data(raster_pipeline_desc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return self.pipeline_manager.create_raster_pipeline_data(raster_pipeline_desc); [INFO] [stdout] 110 + self.pipeline_manager.create_raster_pipeline_data(raster_pipeline_desc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return self.pipeline_manager.create_compute_pipeline(compute_pipeline_desc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return self.pipeline_manager.create_compute_pipeline(compute_pipeline_desc); [INFO] [stdout] 114 + self.pipeline_manager.create_compute_pipeline(compute_pipeline_desc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | / return CommandRecorder { [INFO] [stdout] 158 | | handle: self.inner_device.create_cmd_recorder_data(queue_type), [INFO] [stdout] 159 | | commad_buffers: smallvec![], [INFO] [stdout] 160 | | exec_command_buffers: smallvec![], [INFO] [stdout] ... | [INFO] [stdout] 164 | | device: self.inner_device.clone(), [INFO] [stdout] 165 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 ~ CommandRecorder { [INFO] [stdout] 158 + handle: self.inner_device.create_cmd_recorder_data(queue_type), [INFO] [stdout] 159 + commad_buffers: smallvec![], [INFO] [stdout] 160 + exec_command_buffers: smallvec![], [INFO] [stdout] 161 + current_commad_buffer: vk::CommandBuffer::null(), [INFO] [stdout] 162 + pipeline_manager: self.pipeline_manager.clone(), [INFO] [stdout] 163 + queue_type: queue_type, [INFO] [stdout] 164 + device: self.inner_device.clone(), [INFO] [stdout] 165 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | / return Fence { [INFO] [stdout] 173 | | handle: self.inner_device.create_fence(signaled), [INFO] [stdout] 174 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 ~ Fence { [INFO] [stdout] 173 + handle: self.inner_device.create_fence(signaled), [INFO] [stdout] 174 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | / return Semaphore::Binary(BinarySemaphore { [INFO] [stdout] 179 | | handle: self.inner_device.create_binary_semaphore(), [INFO] [stdout] 180 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 178 ~ Semaphore::Binary(BinarySemaphore { [INFO] [stdout] 179 + handle: self.inner_device.create_binary_semaphore(), [INFO] [stdout] 180 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/device.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | / return Semaphore::Timeline(TimelineSemaphore { [INFO] [stdout] 185 | | handle: self.inner_device.create_timeline_semaphore(), [INFO] [stdout] 186 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 ~ Semaphore::Timeline(TimelineSemaphore { [INFO] [stdout] 185 + handle: self.inner_device.create_timeline_semaphore(), [INFO] [stdout] 186 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/core/gpu_resources.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::u64; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u64::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/gpu_resources.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | return BufferId { id: u64::MAX }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return BufferId { id: u64::MAX }; [INFO] [stdout] 10 + BufferId { id: u64::MAX } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/gpu_resources.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return ImageId { id: u64::MAX }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return ImageId { id: u64::MAX }; [INFO] [stdout] 21 + ImageId { id: u64::MAX } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/gpu_resources.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return SamplerId { id: u64::MAX }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return SamplerId { id: u64::MAX }; [INFO] [stdout] 32 + SamplerId { id: u64::MAX } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/gpu_resources.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return ImageViewId { id: u64::MAX }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return ImageViewId { id: u64::MAX }; [INFO] [stdout] 43 + ImageViewId { id: u64::MAX } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/gpu_resources.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return Pipeline::Rasterization(u64::MAX); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return Pipeline::Rasterization(u64::MAX); [INFO] [stdout] 57 + Pipeline::Rasterization(u64::MAX) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/gpu_resources.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / return match self { [INFO] [stdout] 62 | | Pipeline::Compute(id) => *id, [INFO] [stdout] 63 | | Pipeline::Rasterization(id) => *id, [INFO] [stdout] 64 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ match self { [INFO] [stdout] 62 + Pipeline::Compute(id) => *id, [INFO] [stdout] 63 + Pipeline::Rasterization(id) => *id, [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/instance.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return Instance { inner: Arc::new(inner_instance) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return Instance { inner: Arc::new(inner_instance) }; [INFO] [stdout] 18 + Instance { inner: Arc::new(inner_instance) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:453:31 [INFO] [stdout] | [INFO] [stdout] 453 | pub(crate) const fn to_vk(&self) -> vk::AccessFlags2 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/instance.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / return Device { [INFO] [stdout] 25 | | inner_device: inner_device, [INFO] [stdout] 26 | | pipeline_manager: pipeline_manager, [INFO] [stdout] 27 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 ~ Device { [INFO] [stdout] 25 + inner_device: inner_device, [INFO] [stdout] 26 + pipeline_manager: pipeline_manager, [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/core/instance.rs:23:32 [INFO] [stdout] | [INFO] [stdout] 23 | let pipeline_manager = Arc::new(InnerPipelineManager::new(inner_device.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc` is not `Send` and `Sync` as `InnerPipelineManager` is not `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `InnerPipelineManager` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SwapchainDescription` which implements the `Copy` trait [INFO] [stdout] --> src/core/swapchain.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 30 | let old_desc = self.inner.desc.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.inner.desc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/core/swapchain.rs:38:22 [INFO] [stdout] | [INFO] [stdout] 38 | self.inner = Arc::new(new_swapchain); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc` is not `Send` and `Sync` as `InnerSwapchain` is not `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `InnerSwapchain` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/commands.rs:482:9 [INFO] [stdout] | [INFO] [stdout] 482 | / return MemoryBarrier { [INFO] [stdout] 483 | | src_stage: PipelineStage::TopOfPipe, [INFO] [stdout] 484 | | dst_stage: PipelineStage::BottomOfPipe, [INFO] [stdout] 485 | | src_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 486 | | dst_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 487 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 482 ~ MemoryBarrier { [INFO] [stdout] 483 + src_stage: PipelineStage::TopOfPipe, [INFO] [stdout] 484 + dst_stage: PipelineStage::BottomOfPipe, [INFO] [stdout] 485 + src_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 486 + dst_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 487 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/swapchain.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return self.inner.acquire_image(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return self.inner.acquire_image(); [INFO] [stdout] 42 + self.inner.acquire_image() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/definations/commands.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::u64; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u64::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:24:37 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) const fn to_vk_flags(&self) -> vk::CommandBufferUsageFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/commands.rs:507:9 [INFO] [stdout] | [INFO] [stdout] 507 | / return ImageBarrier { [INFO] [stdout] 508 | | image: ImageId::null(), [INFO] [stdout] 509 | | old_layout: ImageLayout::Undefined, [INFO] [stdout] 510 | | new_layout: ImageLayout::Undefined, [INFO] [stdout] ... | [INFO] [stdout] 517 | | subresources: ImageSubresources::default(), [INFO] [stdout] 518 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 507 ~ ImageBarrier { [INFO] [stdout] 508 + image: ImageId::null(), [INFO] [stdout] 509 + old_layout: ImageLayout::Undefined, [INFO] [stdout] 510 + new_layout: ImageLayout::Undefined, [INFO] [stdout] 511 + src_stage: PipelineStage::TopOfPipe, [INFO] [stdout] 512 + dst_stage: PipelineStage::BottomOfPipe, [INFO] [stdout] 513 + src_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 514 + dst_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 515 + src_queue: QueueType::None, [INFO] [stdout] 516 + dst_queue: QueueType::None, [INFO] [stdout] 517 + subresources: ImageSubresources::default(), [INFO] [stdout] 518 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:40:36 [INFO] [stdout] | [INFO] [stdout] 40 | pub(crate) const fn to_vk_flag(&self) -> vk::IndexType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/commands.rs:537:9 [INFO] [stdout] | [INFO] [stdout] 537 | / return BufferBarrier { [INFO] [stdout] 538 | | buffer: BufferId { id: u64::MAX }, [INFO] [stdout] 539 | | src_stage: PipelineStage::TopOfPipe, [INFO] [stdout] 540 | | dst_stage: PipelineStage::BottomOfPipe, [INFO] [stdout] ... | [INFO] [stdout] 546 | | size: vk::WHOLE_SIZE, [INFO] [stdout] 547 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 537 ~ BufferBarrier { [INFO] [stdout] 538 + buffer: BufferId { id: u64::MAX }, [INFO] [stdout] 539 + src_stage: PipelineStage::TopOfPipe, [INFO] [stdout] 540 + dst_stage: PipelineStage::BottomOfPipe, [INFO] [stdout] 541 + src_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 542 + dst_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 543 + src_queue: QueueType::None, [INFO] [stdout] 544 + dst_queue: QueueType::None, [INFO] [stdout] 545 + offset: 0, [INFO] [stdout] 546 + size: vk::WHOLE_SIZE, [INFO] [stdout] 547 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:64:31 [INFO] [stdout] | [INFO] [stdout] 64 | pub(crate) const fn to_vk(&self) -> vk::AttachmentLoadOp { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:82:31 [INFO] [stdout] | [INFO] [stdout] 82 | pub(crate) const fn to_vk(&self) -> vk::AttachmentStoreOp { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 102 | pub(crate) const fn to_vk(&self) -> vk::ResolveModeFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:123:31 [INFO] [stdout] | [INFO] [stdout] 123 | pub(crate) const fn to_vk(&self) -> vk::ClearValue { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/core.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | / return DeviceDescription { [INFO] [stdout] 31 | | use_compute_queue: true, [INFO] [stdout] 32 | | use_transfer_queue: true, [INFO] [stdout] 33 | | mesh_shaders: false, [INFO] [stdout] 34 | | atomic_float_operations: false, [INFO] [stdout] 35 | | ray_tracing: false, [INFO] [stdout] 36 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ DeviceDescription { [INFO] [stdout] 31 + use_compute_queue: true, [INFO] [stdout] 32 + use_transfer_queue: true, [INFO] [stdout] 33 + mesh_shaders: false, [INFO] [stdout] 34 + atomic_float_operations: false, [INFO] [stdout] 35 + ray_tracing: false, [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/core.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 58 | pub(crate) fn to_vk(&self) -> ash::vk::Extent3D { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/core.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / return ash::vk::Extent3D { [INFO] [stdout] 60 | | width: self.width, [INFO] [stdout] 61 | | height: self.height, [INFO] [stdout] 62 | | depth: self.depth, [INFO] [stdout] 63 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ ash::vk::Extent3D { [INFO] [stdout] 60 + width: self.width, [INFO] [stdout] 61 + height: self.height, [INFO] [stdout] 62 + depth: self.depth, [INFO] [stdout] 63 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/definations/commands.rs:165:43 [INFO] [stdout] | [INFO] [stdout] 165 | image_view: ImageViewId { id: u64::max_value() }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 165 - image_view: ImageViewId { id: u64::max_value() }, [INFO] [stdout] 165 + image_view: ImageViewId { id: u64::MAX }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/core.rs:75:25 [INFO] [stdout] | [INFO] [stdout] 75 | pub(crate) fn to_vk(&self) -> ash::vk::Extent2D { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/core.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return ash::vk::Extent2D { width: self.width, height: self.height }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return ash::vk::Extent2D { width: self.width, height: self.height }; [INFO] [stdout] 76 + ash::vk::Extent2D { width: self.width, height: self.height } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:187:31 [INFO] [stdout] | [INFO] [stdout] 187 | pub(crate) const fn to_vk(&self) -> vk::RenderingFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/core.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | pub(crate) fn to_vk(&self) -> ash::vk::Offset3D { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/core.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return ash::vk::Offset3D { x: self.x, y: self.y, z: self.z }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return ash::vk::Offset3D { x: self.x, y: self.y, z: self.z }; [INFO] [stdout] 90 + ash::vk::Offset3D { x: self.x, y: self.y, z: self.z } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/core.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 102 | pub(crate) fn to_vk(&self) -> ash::vk::Offset2D { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/core.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | return ash::vk::Offset2D { x: self.x, y: self.y }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return ash::vk::Offset2D { x: self.x, y: self.y }; [INFO] [stdout] 103 + ash::vk::Offset2D { x: self.x, y: self.y } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:32:36 [INFO] [stdout] | [INFO] [stdout] 32 | pub(crate) const fn to_vk_flag(&self) -> MemoryLocation { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:74:30 [INFO] [stdout] | [INFO] [stdout] 74 | pub(crate) fn to_vk_flag(&self) -> vk::BufferUsageFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | / return BufferDescription { [INFO] [stdout] 111 | | usage: BufferUsage::STORAGE, [INFO] [stdout] 112 | | size: 10, [INFO] [stdout] 113 | | memory_type: MemoryType::Auto, [INFO] [stdout] 114 | | create_mapped: false, [INFO] [stdout] 115 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 ~ BufferDescription { [INFO] [stdout] 111 + usage: BufferUsage::STORAGE, [INFO] [stdout] 112 + size: 10, [INFO] [stdout] 113 + memory_type: MemoryType::Auto, [INFO] [stdout] 114 + create_mapped: false, [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/gpu_resources.rs:119:1 [INFO] [stdout] | [INFO] [stdout] 119 | / //// IMAGE DESCRIPTION //// [INFO] [stdout] 120 | | #[derive(Clone, Copy, Debug)] [INFO] [stdout] 121 | | pub enum ImageType { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 119 - //// IMAGE DESCRIPTION //// [INFO] [stdout] 120 - #[derive(Clone, Copy, Debug)] [INFO] [stdout] 119 + /// IMAGE DESCRIPTION //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:128:25 [INFO] [stdout] | [INFO] [stdout] 128 | pub(crate) fn to_vk(&self) -> vk::ImageType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:153:30 [INFO] [stdout] | [INFO] [stdout] 153 | pub(crate) fn to_vk_flag(&self) -> vk::ImageUsageFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:228:38 [INFO] [stdout] | [INFO] [stdout] 228 | pub(crate) const fn to_vk_format(&self) -> vk::Format { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | / return match self { [INFO] [stdout] 230 | | // Unsigned Normalized (UNORM) [INFO] [stdout] 231 | | Self::Rgba8Unorm => vk::Format::R8G8B8A8_UNORM, [INFO] [stdout] 232 | | Self::Bgra8Unorm => vk::Format::B8G8R8A8_UNORM, [INFO] [stdout] ... | [INFO] [stdout] 254 | | Self::BC7Unorm => vk::Format::BC7_UNORM_BLOCK, [INFO] [stdout] 255 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 ~ match self { [INFO] [stdout] 230 + // Unsigned Normalized (UNORM) [INFO] [stdout] 231 + Self::Rgba8Unorm => vk::Format::R8G8B8A8_UNORM, [INFO] [stdout] 232 + Self::Bgra8Unorm => vk::Format::B8G8R8A8_UNORM, [INFO] [stdout] 233 + Self::Rgb565Unorm => vk::Format::R5G6B5_UNORM_PACK16, [INFO] [stdout] 234 + [INFO] [stdout] 235 + // Signed/Unsigned Integers (SINT/UINT) [INFO] [stdout] 236 + Self::R32Uint => vk::Format::R32_UINT, [INFO] [stdout] 237 + Self::Rgba8Uint => vk::Format::R8G8B8A8_UINT, [INFO] [stdout] 238 + Self::Rgba32Sint => vk::Format::R32G32B32A32_SINT, [INFO] [stdout] 239 + [INFO] [stdout] 240 + // Float Formats (SFLOAT) [INFO] [stdout] 241 + Self::Rgba16Float => vk::Format::R16G16B16A16_SFLOAT, [INFO] [stdout] 242 + Self::Rg32Float => vk::Format::R32G32_SFLOAT, [INFO] [stdout] 243 + Self::Rgb32Float => vk::Format::R32G32B32_SFLOAT, [INFO] [stdout] 244 + Self::Rgba32Float => vk::Format::R32G32B32A32_SFLOAT, [INFO] [stdout] 245 + Self::R32Float => vk::Format::R32_SFLOAT, [INFO] [stdout] 246 + [INFO] [stdout] 247 + // Depth and Stencil [INFO] [stdout] 248 + Self::D32Float => vk::Format::D32_SFLOAT, [INFO] [stdout] 249 + Self::D24UnormS8Uint => vk::Format::D24_UNORM_S8_UINT, [INFO] [stdout] 250 + Self::D16Unorm => vk::Format::D16_UNORM, [INFO] [stdout] 251 + [INFO] [stdout] 252 + // Block Compressed [INFO] [stdout] 253 + Self::BC1RgbaUnorm => vk::Format::BC1_RGBA_UNORM_BLOCK, [INFO] [stdout] 254 + Self::BC7Unorm => vk::Format::BC7_UNORM_BLOCK, [INFO] [stdout] 255 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | / return match self { [INFO] [stdout] 273 | | Self::Type1 => vk::SampleCountFlags::TYPE_1, [INFO] [stdout] 274 | | Self::Type2 => vk::SampleCountFlags::TYPE_2, [INFO] [stdout] 275 | | Self::Type4 => vk::SampleCountFlags::TYPE_4, [INFO] [stdout] ... | [INFO] [stdout] 279 | | Self::Type64 => vk::SampleCountFlags::TYPE_64, [INFO] [stdout] 280 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 272 ~ match self { [INFO] [stdout] 273 + Self::Type1 => vk::SampleCountFlags::TYPE_1, [INFO] [stdout] 274 + Self::Type2 => vk::SampleCountFlags::TYPE_2, [INFO] [stdout] 275 + Self::Type4 => vk::SampleCountFlags::TYPE_4, [INFO] [stdout] 276 + Self::Type8 => vk::SampleCountFlags::TYPE_8, [INFO] [stdout] 277 + Self::Type16 => vk::SampleCountFlags::TYPE_16, [INFO] [stdout] 278 + Self::Type32 => vk::SampleCountFlags::TYPE_32, [INFO] [stdout] 279 + Self::Type64 => vk::SampleCountFlags::TYPE_64, [INFO] [stdout] 280 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:326:9 [INFO] [stdout] | [INFO] [stdout] 326 | / return Self { [INFO] [stdout] 327 | | usage: ImageUsage::SAMPLED, [INFO] [stdout] 328 | | format: Format::Rgba16Float, [INFO] [stdout] 329 | | image_type: ImageType::Type2D, [INFO] [stdout] ... | [INFO] [stdout] 334 | | samples: SampleCount::Type1, [INFO] [stdout] 335 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 326 ~ Self { [INFO] [stdout] 327 + usage: ImageUsage::SAMPLED, [INFO] [stdout] 328 + format: Format::Rgba16Float, [INFO] [stdout] 329 + image_type: ImageType::Type2D, [INFO] [stdout] 330 + extent: Extent3D { width: 1, height: 1, depth: 1 }, [INFO] [stdout] 331 + memory_type: MemoryType::Auto, [INFO] [stdout] 332 + mip_levels: 1, [INFO] [stdout] 333 + array_layers: 1, [INFO] [stdout] 334 + samples: SampleCount::Type1, [INFO] [stdout] 335 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:350:50 [INFO] [stdout] | [INFO] [stdout] 350 | pub(crate) const fn to_vk_subresource_layers(&self) -> vk::ImageSubresourceLayers { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:351:9 [INFO] [stdout] | [INFO] [stdout] 351 | / return vk::ImageSubresourceLayers { [INFO] [stdout] 352 | | aspect_mask: self.aspect.to_vk_aspect(), [INFO] [stdout] 353 | | mip_level: self.mip_level, [INFO] [stdout] 354 | | base_array_layer: self.base_array_layer, [INFO] [stdout] 355 | | layer_count: self.layer_count, [INFO] [stdout] 356 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 351 ~ vk::ImageSubresourceLayers { [INFO] [stdout] 352 + aspect_mask: self.aspect.to_vk_aspect(), [INFO] [stdout] 353 + mip_level: self.mip_level, [INFO] [stdout] 354 + base_array_layer: self.base_array_layer, [INFO] [stdout] 355 + layer_count: self.layer_count, [INFO] [stdout] 356 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:359:49 [INFO] [stdout] | [INFO] [stdout] 359 | pub(crate) const fn to_vk_subresource_range(&self) -> vk::ImageSubresourceRange { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:360:9 [INFO] [stdout] | [INFO] [stdout] 360 | / return vk::ImageSubresourceRange { [INFO] [stdout] 361 | | aspect_mask: self.aspect.to_vk_aspect(), [INFO] [stdout] 362 | | base_mip_level: self.mip_level, [INFO] [stdout] 363 | | level_count: self.level_count, [INFO] [stdout] 364 | | base_array_layer: self.base_array_layer, [INFO] [stdout] 365 | | layer_count: self.layer_count, [INFO] [stdout] 366 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 360 ~ vk::ImageSubresourceRange { [INFO] [stdout] 361 + aspect_mask: self.aspect.to_vk_aspect(), [INFO] [stdout] 362 + base_mip_level: self.mip_level, [INFO] [stdout] 363 + level_count: self.level_count, [INFO] [stdout] 364 + base_array_layer: self.base_array_layer, [INFO] [stdout] 365 + layer_count: self.layer_count, [INFO] [stdout] 366 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | / return ImageSubresources { [INFO] [stdout] 373 | | aspect: ImageAspect::Color, [INFO] [stdout] 374 | | mip_level: 0, [INFO] [stdout] 375 | | level_count: 1, [INFO] [stdout] 376 | | base_array_layer: 0, [INFO] [stdout] 377 | | layer_count: 1, [INFO] [stdout] 378 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 372 ~ ImageSubresources { [INFO] [stdout] 373 + aspect: ImageAspect::Color, [INFO] [stdout] 374 + mip_level: 0, [INFO] [stdout] 375 + level_count: 1, [INFO] [stdout] 376 + base_array_layer: 0, [INFO] [stdout] 377 + layer_count: 1, [INFO] [stdout] 378 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/gpu_resources.rs:382:1 [INFO] [stdout] | [INFO] [stdout] 382 | / //// Image View Description //// [INFO] [stdout] 383 | | #[derive(Clone, Copy)] [INFO] [stdout] 384 | | pub enum ImageViewType { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 382 - //// Image View Description //// [INFO] [stdout] 383 - #[derive(Clone, Copy)] [INFO] [stdout] 382 + /// Image View Description //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:395:36 [INFO] [stdout] | [INFO] [stdout] 395 | pub(crate) const fn to_vk_type(&self) -> vk::ImageViewType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:417:38 [INFO] [stdout] | [INFO] [stdout] 417 | pub(crate) const fn to_vk_aspect(&self) -> vk::ImageAspectFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/commands.rs:453:31 [INFO] [stdout] | [INFO] [stdout] 453 | pub(crate) const fn to_vk(&self) -> vk::AccessFlags2 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 434 | / return Self { [INFO] [stdout] 435 | | view_type: ImageViewType::Type2D, [INFO] [stdout] 436 | | subresources: ImageSubresources::default(), [INFO] [stdout] 437 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 434 ~ Self { [INFO] [stdout] 435 + view_type: ImageViewType::Type2D, [INFO] [stdout] 436 + subresources: ImageSubresources::default(), [INFO] [stdout] 437 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/gpu_resources.rs:441:1 [INFO] [stdout] | [INFO] [stdout] 441 | / //// SAMPLER DESCRIPTION //// [INFO] [stdout] 442 | | #[derive(Debug, Clone, Copy, PartialEq)] [INFO] [stdout] 443 | | pub enum Filter { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 441 - //// SAMPLER DESCRIPTION //// [INFO] [stdout] 442 - #[derive(Debug, Clone, Copy, PartialEq)] [INFO] [stdout] 441 + /// SAMPLER DESCRIPTION //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/commands.rs:482:9 [INFO] [stdout] | [INFO] [stdout] 482 | / return MemoryBarrier { [INFO] [stdout] 483 | | src_stage: PipelineStage::TopOfPipe, [INFO] [stdout] 484 | | dst_stage: PipelineStage::BottomOfPipe, [INFO] [stdout] 485 | | src_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 486 | | dst_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 487 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 482 ~ MemoryBarrier { [INFO] [stdout] 483 + src_stage: PipelineStage::TopOfPipe, [INFO] [stdout] 484 + dst_stage: PipelineStage::BottomOfPipe, [INFO] [stdout] 485 + src_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 486 + dst_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 487 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/commands.rs:507:9 [INFO] [stdout] | [INFO] [stdout] 507 | / return ImageBarrier { [INFO] [stdout] 508 | | image: ImageId::null(), [INFO] [stdout] 509 | | old_layout: ImageLayout::Undefined, [INFO] [stdout] 510 | | new_layout: ImageLayout::Undefined, [INFO] [stdout] ... | [INFO] [stdout] 517 | | subresources: ImageSubresources::default(), [INFO] [stdout] 518 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 507 ~ ImageBarrier { [INFO] [stdout] 508 + image: ImageId::null(), [INFO] [stdout] 509 + old_layout: ImageLayout::Undefined, [INFO] [stdout] 510 + new_layout: ImageLayout::Undefined, [INFO] [stdout] 511 + src_stage: PipelineStage::TopOfPipe, [INFO] [stdout] 512 + dst_stage: PipelineStage::BottomOfPipe, [INFO] [stdout] 513 + src_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 514 + dst_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 515 + src_queue: QueueType::None, [INFO] [stdout] 516 + dst_queue: QueueType::None, [INFO] [stdout] 517 + subresources: ImageSubresources::default(), [INFO] [stdout] 518 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/definations/pipelines.rs:4:23 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{ops::BitOr, u64}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u64::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/pipelines.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / ////Descriptors//// [INFO] [stdout] 7 | | [INFO] [stdout] 8 | | pub struct BufferWriteInfo { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 6 - ////Descriptors//// [INFO] [stdout] 7 - [INFO] [stdout] 6 + ///Descriptors//// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / return BufferWriteInfo { [INFO] [stdout] 18 | | buffer: BufferId::null(), [INFO] [stdout] 19 | | offset: 0, [INFO] [stdout] 20 | | range: 0, [INFO] [stdout] 21 | | index: 0, [INFO] [stdout] 22 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ BufferWriteInfo { [INFO] [stdout] 18 + buffer: BufferId::null(), [INFO] [stdout] 19 + offset: 0, [INFO] [stdout] 20 + range: 0, [INFO] [stdout] 21 + index: 0, [INFO] [stdout] 22 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / return ImageWriteInfo { [INFO] [stdout] 40 | | view: ImageViewId::null(), [INFO] [stdout] 41 | | image_descriptor_type: ImageDescriptorType::SampledImage, [INFO] [stdout] 42 | | index: 0, [INFO] [stdout] 43 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 ~ ImageWriteInfo { [INFO] [stdout] 40 + view: ImageViewId::null(), [INFO] [stdout] 41 + image_descriptor_type: ImageDescriptorType::SampledImage, [INFO] [stdout] 42 + index: 0, [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | return SamplerWriteInfo { sampler: SamplerId::null(), index: 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return SamplerWriteInfo { sampler: SamplerId::null(), index: 0 }; [INFO] [stdout] 54 + SamplerWriteInfo { sampler: SamplerId::null(), index: 0 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/pipelines.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | / //// Vertex //// [INFO] [stdout] 59 | | [INFO] [stdout] 60 | | pub trait VertexFormat { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 58 - //// Vertex //// [INFO] [stdout] 59 - [INFO] [stdout] 58 + /// Vertex //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/commands.rs:537:9 [INFO] [stdout] | [INFO] [stdout] 537 | / return BufferBarrier { [INFO] [stdout] 538 | | buffer: BufferId { id: u64::MAX }, [INFO] [stdout] 539 | | src_stage: PipelineStage::TopOfPipe, [INFO] [stdout] 540 | | dst_stage: PipelineStage::BottomOfPipe, [INFO] [stdout] ... | [INFO] [stdout] 546 | | size: vk::WHOLE_SIZE, [INFO] [stdout] 547 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 537 ~ BufferBarrier { [INFO] [stdout] 538 + buffer: BufferId { id: u64::MAX }, [INFO] [stdout] 539 + src_stage: PipelineStage::TopOfPipe, [INFO] [stdout] 540 + dst_stage: PipelineStage::BottomOfPipe, [INFO] [stdout] 541 + src_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 542 + dst_access: AccessType::ColorAttachmentRead, [INFO] [stdout] 543 + src_queue: QueueType::None, [INFO] [stdout] 544 + dst_queue: QueueType::None, [INFO] [stdout] 545 + offset: 0, [INFO] [stdout] 546 + size: vk::WHOLE_SIZE, [INFO] [stdout] 547 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | return Self { bindings: Vec::new(), attributes: Vec::new() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return Self { bindings: Vec::new(), attributes: Vec::new() }; [INFO] [stdout] 122 + Self { bindings: Vec::new(), attributes: Vec::new() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/core.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | / return DeviceDescription { [INFO] [stdout] 31 | | use_compute_queue: true, [INFO] [stdout] 32 | | use_transfer_queue: true, [INFO] [stdout] 33 | | mesh_shaders: false, [INFO] [stdout] 34 | | atomic_float_operations: false, [INFO] [stdout] 35 | | ray_tracing: false, [INFO] [stdout] 36 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ DeviceDescription { [INFO] [stdout] 31 + use_compute_queue: true, [INFO] [stdout] 32 + use_transfer_queue: true, [INFO] [stdout] 33 + mesh_shaders: false, [INFO] [stdout] 34 + atomic_float_operations: false, [INFO] [stdout] 35 + ray_tracing: false, [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/pipelines.rs:153:1 [INFO] [stdout] | [INFO] [stdout] 153 | / //// Rasterization pipeline create info //// [INFO] [stdout] 154 | | #[derive(Clone, Copy)] [INFO] [stdout] 155 | | pub enum CullMode { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 153 - //// Rasterization pipeline create info //// [INFO] [stdout] 154 - #[derive(Clone, Copy)] [INFO] [stdout] 153 + /// Rasterization pipeline create info //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/pipelines.rs:163:36 [INFO] [stdout] | [INFO] [stdout] 163 | pub(crate) const fn to_vk_flag(&self) -> vk::CullModeFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/pipelines.rs:180:36 [INFO] [stdout] | [INFO] [stdout] 180 | pub(crate) const fn to_vk_flag(&self) -> vk::FrontFace { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/pipelines.rs:196:30 [INFO] [stdout] | [INFO] [stdout] 196 | pub(crate) fn to_vk_flag(&self) -> vk::PolygonMode { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/core.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 58 | pub(crate) fn to_vk(&self) -> ash::vk::Extent3D { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/core.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / return ash::vk::Extent3D { [INFO] [stdout] 60 | | width: self.width, [INFO] [stdout] 61 | | height: self.height, [INFO] [stdout] 62 | | depth: self.depth, [INFO] [stdout] 63 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ ash::vk::Extent3D { [INFO] [stdout] 60 + width: self.width, [INFO] [stdout] 61 + height: self.height, [INFO] [stdout] 62 + depth: self.depth, [INFO] [stdout] 63 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | / return PipelineOutputs { [INFO] [stdout] 235 | | color: &[Format::Rgba16Float], [INFO] [stdout] 236 | | depth: None, [INFO] [stdout] 237 | | stencil: None, [INFO] [stdout] 238 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 ~ PipelineOutputs { [INFO] [stdout] 235 + color: &[Format::Rgba16Float], [INFO] [stdout] 236 + depth: None, [INFO] [stdout] 237 + stencil: None, [INFO] [stdout] 238 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/core.rs:75:25 [INFO] [stdout] | [INFO] [stdout] 75 | pub(crate) fn to_vk(&self) -> ash::vk::Extent2D { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/core.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return ash::vk::Extent2D { width: self.width, height: self.height }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return ash::vk::Extent2D { width: self.width, height: self.height }; [INFO] [stdout] 76 + ash::vk::Extent2D { width: self.width, height: self.height } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/core.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | pub(crate) fn to_vk(&self) -> ash::vk::Offset3D { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 261 | return Self(vk::ShaderStageFlags::from_raw(self.0.as_raw() | other.0.as_raw())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 261 - return Self(vk::ShaderStageFlags::from_raw(self.0.as_raw() | other.0.as_raw())); [INFO] [stdout] 261 + Self(vk::ShaderStageFlags::from_raw(self.0.as_raw() | other.0.as_raw())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/core.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return ash::vk::Offset3D { x: self.x, y: self.y, z: self.z }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return ash::vk::Offset3D { x: self.x, y: self.y, z: self.z }; [INFO] [stdout] 90 + ash::vk::Offset3D { x: self.x, y: self.y, z: self.z } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:265:9 [INFO] [stdout] | [INFO] [stdout] 265 | return Self(vk::ShaderStageFlags::from_raw(self.0.as_raw() & other.0.as_raw())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 265 - return Self(vk::ShaderStageFlags::from_raw(self.0.as_raw() & other.0.as_raw())); [INFO] [stdout] 265 + Self(vk::ShaderStageFlags::from_raw(self.0.as_raw() & other.0.as_raw())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/core.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 102 | pub(crate) fn to_vk(&self) -> ash::vk::Offset2D { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/core.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | return ash::vk::Offset2D { x: self.x, y: self.y }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return ash::vk::Offset2D { x: self.x, y: self.y }; [INFO] [stdout] 103 + ash::vk::Offset2D { x: self.x, y: self.y } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/pipelines.rs:283:31 [INFO] [stdout] | [INFO] [stdout] 283 | pub(crate) const fn to_vk(&self) -> vk::PrimitiveTopology { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | / return PushConstantsDescription { [INFO] [stdout] 301 | | stage_flags: ShaderStages::ALL, [INFO] [stdout] 302 | | offset: 0, [INFO] [stdout] 303 | | size: 0, [INFO] [stdout] 304 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 300 ~ PushConstantsDescription { [INFO] [stdout] 301 + stage_flags: ShaderStages::ALL, [INFO] [stdout] 302 + offset: 0, [INFO] [stdout] 303 + size: 0, [INFO] [stdout] 304 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:32:36 [INFO] [stdout] | [INFO] [stdout] 32 | pub(crate) const fn to_vk_flag(&self) -> MemoryLocation { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/pipelines.rs:348:1 [INFO] [stdout] | [INFO] [stdout] 348 | / //// Compute Pipeline create info //// [INFO] [stdout] 349 | | #[derive(Clone)] [INFO] [stdout] 350 | | pub struct ComputePipelineDescription { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 348 - //// Compute Pipeline create info //// [INFO] [stdout] 349 - #[derive(Clone)] [INFO] [stdout] 348 + /// Compute Pipeline create info //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:74:30 [INFO] [stdout] | [INFO] [stdout] 74 | pub(crate) fn to_vk_flag(&self) -> vk::BufferUsageFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | / return BufferDescription { [INFO] [stdout] 111 | | usage: BufferUsage::STORAGE, [INFO] [stdout] 112 | | size: 10, [INFO] [stdout] 113 | | memory_type: MemoryType::Auto, [INFO] [stdout] 114 | | create_mapped: false, [INFO] [stdout] 115 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 ~ BufferDescription { [INFO] [stdout] 111 + usage: BufferUsage::STORAGE, [INFO] [stdout] 112 + size: 10, [INFO] [stdout] 113 + memory_type: MemoryType::Auto, [INFO] [stdout] 114 + create_mapped: false, [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/gpu_resources.rs:119:1 [INFO] [stdout] | [INFO] [stdout] 119 | / //// IMAGE DESCRIPTION //// [INFO] [stdout] 120 | | #[derive(Clone, Copy, Debug)] [INFO] [stdout] 121 | | pub enum ImageType { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 119 - //// IMAGE DESCRIPTION //// [INFO] [stdout] 120 - #[derive(Clone, Copy, Debug)] [INFO] [stdout] 119 + /// IMAGE DESCRIPTION //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/vulkan_context.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | / return VulkanContext { [INFO] [stdout] 21 | | instance: instance, [INFO] [stdout] 22 | | device: device, [INFO] [stdout] 23 | | swapchain: swapchain, [INFO] [stdout] 24 | | swapchain_description: swapchain_desc.clone(), [INFO] [stdout] 25 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 ~ VulkanContext { [INFO] [stdout] 21 + instance: instance, [INFO] [stdout] 22 + device: device, [INFO] [stdout] 23 + swapchain: swapchain, [INFO] [stdout] 24 + swapchain_description: swapchain_desc.clone(), [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:128:25 [INFO] [stdout] | [INFO] [stdout] 128 | pub(crate) fn to_vk(&self) -> vk::ImageType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SwapchainDescription` which implements the `Copy` trait [INFO] [stdout] --> src/utils/vulkan_context.rs:24:36 [INFO] [stdout] | [INFO] [stdout] 24 | swapchain_description: swapchain_desc.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*swapchain_desc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:153:30 [INFO] [stdout] | [INFO] [stdout] 153 | pub(crate) fn to_vk_flag(&self) -> vk::ImageUsageFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:228:38 [INFO] [stdout] | [INFO] [stdout] 228 | pub(crate) const fn to_vk_format(&self) -> vk::Format { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | / return match self { [INFO] [stdout] 230 | | // Unsigned Normalized (UNORM) [INFO] [stdout] 231 | | Self::Rgba8Unorm => vk::Format::R8G8B8A8_UNORM, [INFO] [stdout] 232 | | Self::Bgra8Unorm => vk::Format::B8G8R8A8_UNORM, [INFO] [stdout] ... | [INFO] [stdout] 254 | | Self::BC7Unorm => vk::Format::BC7_UNORM_BLOCK, [INFO] [stdout] 255 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 ~ match self { [INFO] [stdout] 230 + // Unsigned Normalized (UNORM) [INFO] [stdout] 231 + Self::Rgba8Unorm => vk::Format::R8G8B8A8_UNORM, [INFO] [stdout] 232 + Self::Bgra8Unorm => vk::Format::B8G8R8A8_UNORM, [INFO] [stdout] 233 + Self::Rgb565Unorm => vk::Format::R5G6B5_UNORM_PACK16, [INFO] [stdout] 234 + [INFO] [stdout] 235 + // Signed/Unsigned Integers (SINT/UINT) [INFO] [stdout] 236 + Self::R32Uint => vk::Format::R32_UINT, [INFO] [stdout] 237 + Self::Rgba8Uint => vk::Format::R8G8B8A8_UINT, [INFO] [stdout] 238 + Self::Rgba32Sint => vk::Format::R32G32B32A32_SINT, [INFO] [stdout] 239 + [INFO] [stdout] 240 + // Float Formats (SFLOAT) [INFO] [stdout] 241 + Self::Rgba16Float => vk::Format::R16G16B16A16_SFLOAT, [INFO] [stdout] 242 + Self::Rg32Float => vk::Format::R32G32_SFLOAT, [INFO] [stdout] 243 + Self::Rgb32Float => vk::Format::R32G32B32_SFLOAT, [INFO] [stdout] 244 + Self::Rgba32Float => vk::Format::R32G32B32A32_SFLOAT, [INFO] [stdout] 245 + Self::R32Float => vk::Format::R32_SFLOAT, [INFO] [stdout] 246 + [INFO] [stdout] 247 + // Depth and Stencil [INFO] [stdout] 248 + Self::D32Float => vk::Format::D32_SFLOAT, [INFO] [stdout] 249 + Self::D24UnormS8Uint => vk::Format::D24_UNORM_S8_UINT, [INFO] [stdout] 250 + Self::D16Unorm => vk::Format::D16_UNORM, [INFO] [stdout] 251 + [INFO] [stdout] 252 + // Block Compressed [INFO] [stdout] 253 + Self::BC1RgbaUnorm => vk::Format::BC1_RGBA_UNORM_BLOCK, [INFO] [stdout] 254 + Self::BC7Unorm => vk::Format::BC7_UNORM_BLOCK, [INFO] [stdout] 255 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | / return match self { [INFO] [stdout] 273 | | Self::Type1 => vk::SampleCountFlags::TYPE_1, [INFO] [stdout] 274 | | Self::Type2 => vk::SampleCountFlags::TYPE_2, [INFO] [stdout] 275 | | Self::Type4 => vk::SampleCountFlags::TYPE_4, [INFO] [stdout] ... | [INFO] [stdout] 279 | | Self::Type64 => vk::SampleCountFlags::TYPE_64, [INFO] [stdout] 280 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 272 ~ match self { [INFO] [stdout] 273 + Self::Type1 => vk::SampleCountFlags::TYPE_1, [INFO] [stdout] 274 + Self::Type2 => vk::SampleCountFlags::TYPE_2, [INFO] [stdout] 275 + Self::Type4 => vk::SampleCountFlags::TYPE_4, [INFO] [stdout] 276 + Self::Type8 => vk::SampleCountFlags::TYPE_8, [INFO] [stdout] 277 + Self::Type16 => vk::SampleCountFlags::TYPE_16, [INFO] [stdout] 278 + Self::Type32 => vk::SampleCountFlags::TYPE_32, [INFO] [stdout] 279 + Self::Type64 => vk::SampleCountFlags::TYPE_64, [INFO] [stdout] 280 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:326:9 [INFO] [stdout] | [INFO] [stdout] 326 | / return Self { [INFO] [stdout] 327 | | usage: ImageUsage::SAMPLED, [INFO] [stdout] 328 | | format: Format::Rgba16Float, [INFO] [stdout] 329 | | image_type: ImageType::Type2D, [INFO] [stdout] ... | [INFO] [stdout] 334 | | samples: SampleCount::Type1, [INFO] [stdout] 335 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 326 ~ Self { [INFO] [stdout] 327 + usage: ImageUsage::SAMPLED, [INFO] [stdout] 328 + format: Format::Rgba16Float, [INFO] [stdout] 329 + image_type: ImageType::Type2D, [INFO] [stdout] 330 + extent: Extent3D { width: 1, height: 1, depth: 1 }, [INFO] [stdout] 331 + memory_type: MemoryType::Auto, [INFO] [stdout] 332 + mip_levels: 1, [INFO] [stdout] 333 + array_layers: 1, [INFO] [stdout] 334 + samples: SampleCount::Type1, [INFO] [stdout] 335 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:350:50 [INFO] [stdout] | [INFO] [stdout] 350 | pub(crate) const fn to_vk_subresource_layers(&self) -> vk::ImageSubresourceLayers { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:351:9 [INFO] [stdout] | [INFO] [stdout] 351 | / return vk::ImageSubresourceLayers { [INFO] [stdout] 352 | | aspect_mask: self.aspect.to_vk_aspect(), [INFO] [stdout] 353 | | mip_level: self.mip_level, [INFO] [stdout] 354 | | base_array_layer: self.base_array_layer, [INFO] [stdout] 355 | | layer_count: self.layer_count, [INFO] [stdout] 356 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 351 ~ vk::ImageSubresourceLayers { [INFO] [stdout] 352 + aspect_mask: self.aspect.to_vk_aspect(), [INFO] [stdout] 353 + mip_level: self.mip_level, [INFO] [stdout] 354 + base_array_layer: self.base_array_layer, [INFO] [stdout] 355 + layer_count: self.layer_count, [INFO] [stdout] 356 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:359:49 [INFO] [stdout] | [INFO] [stdout] 359 | pub(crate) const fn to_vk_subresource_range(&self) -> vk::ImageSubresourceRange { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:360:9 [INFO] [stdout] | [INFO] [stdout] 360 | / return vk::ImageSubresourceRange { [INFO] [stdout] 361 | | aspect_mask: self.aspect.to_vk_aspect(), [INFO] [stdout] 362 | | base_mip_level: self.mip_level, [INFO] [stdout] 363 | | level_count: self.level_count, [INFO] [stdout] 364 | | base_array_layer: self.base_array_layer, [INFO] [stdout] 365 | | layer_count: self.layer_count, [INFO] [stdout] 366 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 360 ~ vk::ImageSubresourceRange { [INFO] [stdout] 361 + aspect_mask: self.aspect.to_vk_aspect(), [INFO] [stdout] 362 + base_mip_level: self.mip_level, [INFO] [stdout] 363 + level_count: self.level_count, [INFO] [stdout] 364 + base_array_layer: self.base_array_layer, [INFO] [stdout] 365 + layer_count: self.layer_count, [INFO] [stdout] 366 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | / return ImageSubresources { [INFO] [stdout] 373 | | aspect: ImageAspect::Color, [INFO] [stdout] 374 | | mip_level: 0, [INFO] [stdout] 375 | | level_count: 1, [INFO] [stdout] 376 | | base_array_layer: 0, [INFO] [stdout] 377 | | layer_count: 1, [INFO] [stdout] 378 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 372 ~ ImageSubresources { [INFO] [stdout] 373 + aspect: ImageAspect::Color, [INFO] [stdout] 374 + mip_level: 0, [INFO] [stdout] 375 + level_count: 1, [INFO] [stdout] 376 + base_array_layer: 0, [INFO] [stdout] 377 + layer_count: 1, [INFO] [stdout] 378 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/gpu_resources.rs:382:1 [INFO] [stdout] | [INFO] [stdout] 382 | / //// Image View Description //// [INFO] [stdout] 383 | | #[derive(Clone, Copy)] [INFO] [stdout] 384 | | pub enum ImageViewType { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 382 - //// Image View Description //// [INFO] [stdout] 383 - #[derive(Clone, Copy)] [INFO] [stdout] 382 + /// Image View Description //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:395:36 [INFO] [stdout] | [INFO] [stdout] 395 | pub(crate) const fn to_vk_type(&self) -> vk::ImageViewType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/gpu_resources.rs:417:38 [INFO] [stdout] | [INFO] [stdout] 417 | pub(crate) const fn to_vk_aspect(&self) -> vk::ImageAspectFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/gpu_resources.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 434 | / return Self { [INFO] [stdout] 435 | | view_type: ImageViewType::Type2D, [INFO] [stdout] 436 | | subresources: ImageSubresources::default(), [INFO] [stdout] 437 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 434 ~ Self { [INFO] [stdout] 435 + view_type: ImageViewType::Type2D, [INFO] [stdout] 436 + subresources: ImageSubresources::default(), [INFO] [stdout] 437 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/gpu_resources.rs:441:1 [INFO] [stdout] | [INFO] [stdout] 441 | / //// SAMPLER DESCRIPTION //// [INFO] [stdout] 442 | | #[derive(Debug, Clone, Copy, PartialEq)] [INFO] [stdout] 443 | | pub enum Filter { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 441 - //// SAMPLER DESCRIPTION //// [INFO] [stdout] 442 - #[derive(Debug, Clone, Copy, PartialEq)] [INFO] [stdout] 441 + /// SAMPLER DESCRIPTION //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/definations/pipelines.rs:4:23 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{ops::BitOr, u64}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u64::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/pipelines.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / ////Descriptors//// [INFO] [stdout] 7 | | [INFO] [stdout] 8 | | pub struct BufferWriteInfo { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 6 - ////Descriptors//// [INFO] [stdout] 7 - [INFO] [stdout] 6 + ///Descriptors//// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / return BufferWriteInfo { [INFO] [stdout] 18 | | buffer: BufferId::null(), [INFO] [stdout] 19 | | offset: 0, [INFO] [stdout] 20 | | range: 0, [INFO] [stdout] 21 | | index: 0, [INFO] [stdout] 22 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ BufferWriteInfo { [INFO] [stdout] 18 + buffer: BufferId::null(), [INFO] [stdout] 19 + offset: 0, [INFO] [stdout] 20 + range: 0, [INFO] [stdout] 21 + index: 0, [INFO] [stdout] 22 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / return ImageWriteInfo { [INFO] [stdout] 40 | | view: ImageViewId::null(), [INFO] [stdout] 41 | | image_descriptor_type: ImageDescriptorType::SampledImage, [INFO] [stdout] 42 | | index: 0, [INFO] [stdout] 43 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 ~ ImageWriteInfo { [INFO] [stdout] 40 + view: ImageViewId::null(), [INFO] [stdout] 41 + image_descriptor_type: ImageDescriptorType::SampledImage, [INFO] [stdout] 42 + index: 0, [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | return SamplerWriteInfo { sampler: SamplerId::null(), index: 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return SamplerWriteInfo { sampler: SamplerId::null(), index: 0 }; [INFO] [stdout] 54 + SamplerWriteInfo { sampler: SamplerId::null(), index: 0 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/pipelines.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | / //// Vertex //// [INFO] [stdout] 59 | | [INFO] [stdout] 60 | | pub trait VertexFormat { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 58 - //// Vertex //// [INFO] [stdout] 59 - [INFO] [stdout] 58 + /// Vertex //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | return Self { bindings: Vec::new(), attributes: Vec::new() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return Self { bindings: Vec::new(), attributes: Vec::new() }; [INFO] [stdout] 122 + Self { bindings: Vec::new(), attributes: Vec::new() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/pipelines.rs:153:1 [INFO] [stdout] | [INFO] [stdout] 153 | / //// Rasterization pipeline create info //// [INFO] [stdout] 154 | | #[derive(Clone, Copy)] [INFO] [stdout] 155 | | pub enum CullMode { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 153 - //// Rasterization pipeline create info //// [INFO] [stdout] 154 - #[derive(Clone, Copy)] [INFO] [stdout] 153 + /// Rasterization pipeline create info //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/pipelines.rs:163:36 [INFO] [stdout] | [INFO] [stdout] 163 | pub(crate) const fn to_vk_flag(&self) -> vk::CullModeFlags { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/pipelines.rs:180:36 [INFO] [stdout] | [INFO] [stdout] 180 | pub(crate) const fn to_vk_flag(&self) -> vk::FrontFace { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/pipelines.rs:196:30 [INFO] [stdout] | [INFO] [stdout] 196 | pub(crate) fn to_vk_flag(&self) -> vk::PolygonMode { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | / return PipelineOutputs { [INFO] [stdout] 235 | | color: &[Format::Rgba16Float], [INFO] [stdout] 236 | | depth: None, [INFO] [stdout] 237 | | stencil: None, [INFO] [stdout] 238 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 ~ PipelineOutputs { [INFO] [stdout] 235 + color: &[Format::Rgba16Float], [INFO] [stdout] 236 + depth: None, [INFO] [stdout] 237 + stencil: None, [INFO] [stdout] 238 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 261 | return Self(vk::ShaderStageFlags::from_raw(self.0.as_raw() | other.0.as_raw())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 261 - return Self(vk::ShaderStageFlags::from_raw(self.0.as_raw() | other.0.as_raw())); [INFO] [stdout] 261 + Self(vk::ShaderStageFlags::from_raw(self.0.as_raw() | other.0.as_raw())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:265:9 [INFO] [stdout] | [INFO] [stdout] 265 | return Self(vk::ShaderStageFlags::from_raw(self.0.as_raw() & other.0.as_raw())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 265 - return Self(vk::ShaderStageFlags::from_raw(self.0.as_raw() & other.0.as_raw())); [INFO] [stdout] 265 + Self(vk::ShaderStageFlags::from_raw(self.0.as_raw() & other.0.as_raw())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/definations/pipelines.rs:283:31 [INFO] [stdout] | [INFO] [stdout] 283 | pub(crate) const fn to_vk(&self) -> vk::PrimitiveTopology { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/definations/pipelines.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | / return PushConstantsDescription { [INFO] [stdout] 301 | | stage_flags: ShaderStages::ALL, [INFO] [stdout] 302 | | offset: 0, [INFO] [stdout] 303 | | size: 0, [INFO] [stdout] 304 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 300 ~ PushConstantsDescription { [INFO] [stdout] 301 + stage_flags: ShaderStages::ALL, [INFO] [stdout] 302 + offset: 0, [INFO] [stdout] 303 + size: 0, [INFO] [stdout] 304 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/definations/pipelines.rs:348:1 [INFO] [stdout] | [INFO] [stdout] 348 | / //// Compute Pipeline create info //// [INFO] [stdout] 349 | | #[derive(Clone)] [INFO] [stdout] 350 | | pub struct ComputePipelineDescription { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 348 - //// Compute Pipeline create info //// [INFO] [stdout] 349 - #[derive(Clone)] [INFO] [stdout] 348 + /// Compute Pipeline create info //// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/vulkan_context.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | / return VulkanContext { [INFO] [stdout] 21 | | instance: instance, [INFO] [stdout] 22 | | device: device, [INFO] [stdout] 23 | | swapchain: swapchain, [INFO] [stdout] 24 | | swapchain_description: swapchain_desc.clone(), [INFO] [stdout] 25 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 ~ VulkanContext { [INFO] [stdout] 21 + instance: instance, [INFO] [stdout] 22 + device: device, [INFO] [stdout] 23 + swapchain: swapchain, [INFO] [stdout] 24 + swapchain_description: swapchain_desc.clone(), [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SwapchainDescription` which implements the `Copy` trait [INFO] [stdout] --> src/utils/vulkan_context.rs:24:36 [INFO] [stdout] | [INFO] [stdout] 24 | swapchain_description: swapchain_desc.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*swapchain_desc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.47s [INFO] running `Command { std: "docker" "inspect" "80cf0f90867de1141b67a5f01659d1bc5725b9b38c03dec1b9ae0a92273077ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80cf0f90867de1141b67a5f01659d1bc5725b9b38c03dec1b9ae0a92273077ba", kill_on_drop: false }` [INFO] [stdout] 80cf0f90867de1141b67a5f01659d1bc5725b9b38c03dec1b9ae0a92273077ba