[INFO] fetching crate nes_rust_slim 0.2.0... [INFO] linting nes_rust_slim-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate nes_rust_slim 0.2.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate nes_rust_slim 0.2.0 [INFO] finished tweaking crates.io crate nes_rust_slim 0.2.0 [INFO] tweaked toml for crates.io crate nes_rust_slim 0.2.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate nes_rust_slim 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate nes_rust_slim 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap_complete v4.5.46 [INFO] [stderr] Downloaded clap v4.5.32 [INFO] [stderr] Downloaded symsrv v0.2.0 [INFO] [stderr] Downloaded range-collections v0.2.4 [INFO] [stderr] Downloaded lzxd v0.1.4 [INFO] [stderr] Downloaded pdb-addr2line v0.10.4 [INFO] [stderr] Downloaded blondie v0.5.2 [INFO] [stderr] Downloaded clap_builder v4.5.32 [INFO] [stderr] Downloaded cab v0.4.1 [INFO] [stderr] Downloaded inferno v0.12.1 [INFO] [stderr] Downloaded pdb v0.8.0 [INFO] [stderr] Downloaded object v0.30.4 [INFO] [stderr] Downloaded flamegraph v0.6.7 [INFO] [stderr] Downloaded windows v0.44.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c289a0523e3f641a90c968a31550ecb0811f9c73a74ad3599bb87cbac09e8ace [INFO] running `Command { std: "docker" "start" "-a" "c289a0523e3f641a90c968a31550ecb0811f9c73a74ad3599bb87cbac09e8ace", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c289a0523e3f641a90c968a31550ecb0811f9c73a74ad3599bb87cbac09e8ace", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c289a0523e3f641a90c968a31550ecb0811f9c73a74ad3599bb87cbac09e8ace", kill_on_drop: false }` [INFO] [stdout] c289a0523e3f641a90c968a31550ecb0811f9c73a74ad3599bb87cbac09e8ace [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37065a98210b120f3cc1926c75bb26be39911e8cf54c31b7b336c94529db022c [INFO] running `Command { std: "docker" "start" "-a" "37065a98210b120f3cc1926c75bb26be39911e8cf54c31b7b336c94529db022c", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Checking once_cell v1.21.1 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Compiling portable-atomic v1.11.0 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking clap_builder v4.5.32 [INFO] [stderr] Checking smallvec v1.14.0 [INFO] [stderr] Checking bytemuck v1.22.0 [INFO] [stderr] Compiling anyhow v1.0.97 [INFO] [stderr] Checking indexmap v2.8.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking crossbeam-channel v0.5.14 [INFO] [stderr] Checking quick-xml v0.37.2 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking log v0.4.26 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking nes_rust_slim v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/apu.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | audio: audio, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `audio` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/apu.rs:350:13 [INFO] [stdout] | [INFO] [stdout] 350 | channel: channel, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:1104:13 [INFO] [stdout] | [INFO] [stdout] 1104 | input: input, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | * 0x8000 - 0xBFFF: 0x0000 - 0x3FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:53:7 [INFO] [stdout] | [INFO] [stdout] 53 | * 0xC000 - 0xFFFF: 0x0000 - 0x3FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/mapper.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | control_register: control_register, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_register` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ppu.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | display: display, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ppu.rs:1328:26 [INFO] [stdout] | [INFO] [stdout] 1328 | SpritesManager { memory: memory } [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | header: header, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | mapper: mapper, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mapper` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/apu.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | if (self.cycle % self.sample_period) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(self.sample_period)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/apu.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 86 | if (self.cycle % 2) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/apu.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | if (self.cycle % 7457) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(7457)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apu.rs:666:9 [INFO] [stdout] | [INFO] [stdout] 666 | return SEQUENCE_TABLE[self.timer_sequence as usize] & 0xF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 666 - return SEQUENCE_TABLE[self.timer_sequence as usize] & 0xF; [INFO] [stdout] 666 + SEQUENCE_TABLE[self.timer_sequence as usize] & 0xF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/apu.rs:796:36 [INFO] [stdout] | [INFO] [stdout] 796 | self.shift_register = ((feedback as u16) << 14) | (self.shift_register >> 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `feedback` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/apu.rs:1033:13 [INFO] [stdout] | [INFO] [stdout] 1033 | self.shift_register = self.shift_register >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.shift_register >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INV` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | INV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | ADC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Adc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | ASL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Asl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | BCC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | BCS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BEQ` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | BEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Beq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BIT` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | BIT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BMI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | BMI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bmi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BNE` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | BNE, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bne` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BPL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | BPL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bpl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BRK` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | BRK, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Brk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | BVC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | BVS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | CLC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLD` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | CLD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLV` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | CLV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CMP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | CMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | CPX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | CPY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | DEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | DEX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | DEY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | EOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Eor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | INC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | INX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | INY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Iny` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | JMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | JSR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | LDA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lda` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | LDX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | LDY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LSR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | LSR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | NOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ORA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | ORA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ora` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | PHA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | PHP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Php` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 116 | PLA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | PLP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Plp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | ROL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 119 | ROR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ror` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | RTI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | SBC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | SEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SED` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | SED, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | SEI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sei` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | STA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | STX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Stx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | STY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | TAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | TAY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tay` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TSX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | TSX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Tsx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | TXA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Txa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 133 | TXS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Txs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TYA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tya` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1292:53 [INFO] [stdout] | [INFO] [stdout] 1292 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:1320:20 [INFO] [stdout] | [INFO] [stdout] 1320 | if !(((src1 ^ src2 as u8) & 0x80) != 0) && ((src2 as u8 ^ result as u8) & 0x80) != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((src1 ^ src2 as u8) & 0x80) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1310:59 [INFO] [stdout] | [INFO] [stdout] 1310 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1329:59 [INFO] [stdout] | [INFO] [stdout] 1329 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1344:32 [INFO] [stdout] | [INFO] [stdout] 1344 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1348:32 [INFO] [stdout] | [INFO] [stdout] 1348 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1352:32 [INFO] [stdout] | [INFO] [stdout] 1352 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1357:59 [INFO] [stdout] | [INFO] [stdout] 1357 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1369:32 [INFO] [stdout] | [INFO] [stdout] 1369 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1373:32 [INFO] [stdout] | [INFO] [stdout] 1373 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1377:32 [INFO] [stdout] | [INFO] [stdout] 1377 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1387:32 [INFO] [stdout] | [INFO] [stdout] 1387 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1391:32 [INFO] [stdout] | [INFO] [stdout] 1391 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1414:59 [INFO] [stdout] | [INFO] [stdout] 1414 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1451:59 [INFO] [stdout] | [INFO] [stdout] 1451 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1502:51 [INFO] [stdout] | [INFO] [stdout] 1502 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1507:51 [INFO] [stdout] | [INFO] [stdout] 1507 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1512:51 [INFO] [stdout] | [INFO] [stdout] 1512 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1657:59 [INFO] [stdout] | [INFO] [stdout] 1657 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1691:49 [INFO] [stdout] | [INFO] [stdout] 1691 | self.store_with_addressing_mode(&op, value); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1695:49 [INFO] [stdout] | [INFO] [stdout] 1695 | self.store_with_addressing_mode(&op, value); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1699:49 [INFO] [stdout] | [INFO] [stdout] 1699 | self.store_with_addressing_mode(&op, value); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1749:12 [INFO] [stdout] | [INFO] [stdout] 1749 | if address >= 0x2000 && address < 0x4000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..0x4000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1754:12 [INFO] [stdout] | [INFO] [stdout] 1754 | if (address >= 0x4000 && address < 0x4014) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..0x4014).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1756:16 [INFO] [stdout] | [INFO] [stdout] 1756 | || (address >= 0x4017 && address < 0x4020) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4017..0x4020).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1773:12 [INFO] [stdout] | [INFO] [stdout] 1773 | if address >= 0x4020 && address < 0x6000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4020..0x6000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1777:12 [INFO] [stdout] | [INFO] [stdout] 1777 | if address >= 0x6000 && address < 0x8000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x6000..0x8000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1818:12 [INFO] [stdout] | [INFO] [stdout] 1818 | if address >= 0x2000 && address < 0x4000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..0x4000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1824:12 [INFO] [stdout] | [INFO] [stdout] 1824 | if (address >= 0x4000 && address < 0x4014) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..0x4014).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1826:16 [INFO] [stdout] | [INFO] [stdout] 1826 | || (address >= 0x4017 && address < 0x4020) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4017..0x4020).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1856:12 [INFO] [stdout] | [INFO] [stdout] 1856 | if address >= 0x4020 && address < 0x6000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4020..0x6000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1862:12 [INFO] [stdout] | [INFO] [stdout] 1862 | if address >= 0x6000 && address < 0x8000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x6000..0x8000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cpu.rs:1878:17 [INFO] [stdout] | [INFO] [stdout] 1878 | / if self.p.is_i() { [INFO] [stdout] 1879 | | return; [INFO] [stdout] 1880 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1877 ~ Interrupts::IRQ [INFO] [stdout] 1878 ~ if self.p.is_i() => { [INFO] [stdout] 1879 | return; [INFO] [stdout] 1880 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/cpu.rs:1876:9 [INFO] [stdout] | [INFO] [stdout] 1876 | / match interrupt_type { [INFO] [stdout] 1877 | | Interrupts::IRQ => { [INFO] [stdout] 1878 | | if self.p.is_i() { [INFO] [stdout] 1879 | | return; [INFO] [stdout] ... | [INFO] [stdout] 1882 | | _ => {} [INFO] [stdout] 1883 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1876 ~ if let Interrupts::IRQ = interrupt_type { [INFO] [stdout] 1877 + if self.p.is_i() { [INFO] [stdout] 1878 + return; [INFO] [stdout] 1879 + } [INFO] [stdout] 1880 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1909:69 [INFO] [stdout] | [INFO] [stdout] 1909 | let address = self.get_address_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cpu.rs:1988:25 [INFO] [stdout] | [INFO] [stdout] 1988 | / if (address & 0xff00) != (effective_address & 0xff00) { [INFO] [stdout] 1989 | | self.stall_cycles += 1; [INFO] [stdout] 1990 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1986 ~ | InstructionTypes::SBC [INFO] [stdout] 1987 | // stall_cycles + 1 if page is crossed [INFO] [stdout] 1988 ~ if (address & 0xff00) != (effective_address & 0xff00) => { [INFO] [stdout] 1989 | self.stall_cycles += 1; [INFO] [stdout] 1990 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/cpu.rs:2019:48 [INFO] [stdout] | [INFO] [stdout] 2019 | self.load_2bytes_from_zeropage(((tmp.wrapping_add(self.x.load())) & 0xFF) as u16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(tmp.wrapping_add(self.x.load()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cpu.rs:2035:25 [INFO] [stdout] | [INFO] [stdout] 2035 | / if (address2 & 0xff00) != (effective_address & 0xff00) { [INFO] [stdout] 2036 | | self.stall_cycles += 1; [INFO] [stdout] 2037 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2033 ~ | InstructionTypes::SBC [INFO] [stdout] 2034 | // stall_cycles + 1 if page is crossed [INFO] [stdout] 2035 ~ if (address2 & 0xff00) != (effective_address & 0xff00) => { [INFO] [stdout] 2036 | self.stall_cycles += 1; [INFO] [stdout] 2037 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2112:15 [INFO] [stdout] | [INFO] [stdout] 2112 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2113:15 [INFO] [stdout] | [INFO] [stdout] 2113 | + &"pc:".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"pc:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2116:15 [INFO] [stdout] | [INFO] [stdout] 2116 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2117:15 [INFO] [stdout] | [INFO] [stdout] 2117 | + &"sp:".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"sp:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2119:15 [INFO] [stdout] | [INFO] [stdout] 2119 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2120:15 [INFO] [stdout] | [INFO] [stdout] 2120 | + &"a:".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"a:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2122:15 [INFO] [stdout] | [INFO] [stdout] 2122 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2123:15 [INFO] [stdout] | [INFO] [stdout] 2123 | + &"x:".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"x:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2125:15 [INFO] [stdout] | [INFO] [stdout] 2125 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2126:15 [INFO] [stdout] | [INFO] [stdout] 2126 | + &"y:".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"y:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2128:15 [INFO] [stdout] | [INFO] [stdout] 2128 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2130:15 [INFO] [stdout] | [INFO] [stdout] 2130 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2137:73 [INFO] [stdout] | [INFO] [stdout] 2137 | "#".to_owned() + &format!("0x{:02x} ", self.load(pc)) + &"immediate".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"immediate"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2140:61 [INFO] [stdout] | [INFO] [stdout] 2140 | format!("0x{:02x} ", self.load(pc) as i8) + &"relative".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"relative"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2146:23 [INFO] [stdout] | [INFO] [stdout] 2146 | + &"absolute".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"absolute"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2155:23 [INFO] [stdout] | [INFO] [stdout] 2155 | + &"indexed_absolute_x".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_absolute_x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2164:23 [INFO] [stdout] | [INFO] [stdout] 2164 | + &"indexed_absolute_y".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_absolute_y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2170:23 [INFO] [stdout] | [INFO] [stdout] 2170 | + &"zero_page".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"zero_page"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2179:23 [INFO] [stdout] | [INFO] [stdout] 2179 | + &"indexed_zero_page_x".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_zero_page_x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2188:23 [INFO] [stdout] | [INFO] [stdout] 2188 | + &"indexed_zero_page_y".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_zero_page_y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2195:23 [INFO] [stdout] | [INFO] [stdout] 2195 | + &"indirect".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indirect"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2202:23 [INFO] [stdout] | [INFO] [stdout] 2202 | + &"indexed_indirect_x".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_indirect_x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2211:23 [INFO] [stdout] | [INFO] [stdout] 2211 | + &"indexed_indirect_y".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_indirect_y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2214:56 [INFO] [stdout] | [INFO] [stdout] 2214 | format!("A0x{:02x} ", self.a.load()) + &"accumulator".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"accumulator"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CpuStatusRegister` [INFO] [stdout] --> src/cpu.rs:2226:5 [INFO] [stdout] | [INFO] [stdout] 2226 | / pub fn new() -> Self { [INFO] [stdout] 2227 | | CpuStatusRegister { [INFO] [stdout] 2228 | | register: Register::::new(), [INFO] [stdout] 2229 | | } [INFO] [stdout] 2230 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 2225 + impl Default for CpuStatusRegister { [INFO] [stdout] 2226 + fn default() -> Self { [INFO] [stdout] 2227 + Self::new() [INFO] [stdout] 2228 + } [INFO] [stdout] 2229 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2341:15 [INFO] [stdout] | [INFO] [stdout] 2341 | + &"(".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `"("` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2382:15 [INFO] [stdout] | [INFO] [stdout] 2382 | + &")".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultAudio` [INFO] [stdout] --> src/default_audio.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / pub fn new() -> Self { [INFO] [stdout] 11 | | DefaultAudio { [INFO] [stdout] 12 | | buffer_index: 0, [INFO] [stdout] 13 | | buffer: [0.0; BUFFER_CAPACITY], [INFO] [stdout] ... | [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl Default for DefaultAudio { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `sample_buffer` [INFO] [stdout] --> src/default_audio.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..client_sample_buffer_length { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..client_sample_buffer_length { [INFO] [stdout] 34 + for (i, ) in sample_buffer.iter_mut().enumerate().take(client_sample_buffer_length) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultDisplay` [INFO] [stdout] --> src/default_display.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> Self { [INFO] [stdout] 9 | | DefaultDisplay { [INFO] [stdout] 10 | | pixels: vec![0; PIXELS_CAPACITY], [INFO] [stdout] 11 | | } [INFO] [stdout] 12 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for DefaultDisplay { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/default_display.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | self.pixels[(base_index + 0) as usize] = b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `base_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/default_display.rs:33:58 [INFO] [stdout] | [INFO] [stdout] 33 | pixels[base_index * 4 + 0] = self.pixels[base_index * 3 + 0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(base_index * 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/default_display.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 33 | pixels[base_index * 4 + 0] = self.pixels[base_index * 3 + 0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(base_index * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultInput` [INFO] [stdout] --> src/default_input.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | DefaultInput { [INFO] [stdout] 13 | | events: VecDeque::<(button::Button, button::Event)>::new(), [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for DefaultInput { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/default_input.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 20 | match self.events.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.events.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Joypad` [INFO] [stdout] --> src/joypad.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / pub fn new() -> Self { [INFO] [stdout] 39 | | Joypad { [INFO] [stdout] 40 | | register: Register::::new(), [INFO] [stdout] 41 | | latch: 0, [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 37 + impl Default for Joypad { [INFO] [stdout] 38 + fn default() -> Self { [INFO] [stdout] 39 + Self::new() [INFO] [stdout] 40 + } [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/joypad.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | value = value & 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value &= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mapper.rs:54:7 [INFO] [stdout] | [INFO] [stdout] 54 | * else: [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 54 | * else: [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mapper.rs:55:7 [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/mapper.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | offset = offset | (address & 0x4000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset |= (address & 0x4000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/mapper.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | offset = offset | (address & 0x1000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset |= (address & 0x1000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 428 | address = address & 0x3FFF; // just in case [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `address &= 0x3FFF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | address = address & 0x3FFF; // just in case [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `address &= 0x3FFF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ppu.rs:832:12 [INFO] [stdout] | [INFO] [stdout] 832 | if (self.cycle % 8) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:902:28 [INFO] [stdout] | [INFO] [stdout] 902 | self.ppuaddr.store(self.current_vram_address as u8 & 0xFF); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(self.current_vram_address as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:1084:13 [INFO] [stdout] | [INFO] [stdout] 1084 | c = c | 0x00FF0000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `c |= 0x00FF0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:1087:13 [INFO] [stdout] | [INFO] [stdout] 1087 | c = c | 0x0000FF00; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `c |= 0x0000FF00` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:1090:13 [INFO] [stdout] | [INFO] [stdout] 1090 | c = c | 0x000000FF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `c |= 0x000000FF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/ppu.rs:1095:34 [INFO] [stdout] | [INFO] [stdout] 1095 | pub fn get_display(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&dyn Display` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:1347:30 [INFO] [stdout] | [INFO] [stdout] 1347 | byte0: self.load(index * 4 + 0), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `(index * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:1356:20 [INFO] [stdout] | [INFO] [stdout] 1356 | self.store(index * 4 + 0, sprite.byte0); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `(index * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:1365:24 [INFO] [stdout] | [INFO] [stdout] 1365 | self.store(i * 4 + 0, 0xff); [INFO] [stdout] | ^^^^^^^^^ help: consider reducing it to: `(i * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Register` [INFO] [stdout] --> src/register.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> Register { [INFO] [stdout] 9 | | Register { data: 0 } [INFO] [stdout] 10 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for Register { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Register` [INFO] [stdout] --> src/register.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | / pub fn new() -> Register { [INFO] [stdout] 94 | | Register { data: 0 } [INFO] [stdout] 95 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 92 + impl Default for Register { [INFO] [stdout] 93 + fn default() -> Self { [INFO] [stdout] 94 + Self::new() [INFO] [stdout] 95 + } [INFO] [stdout] 96 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/rom.rs:40:34 [INFO] [stdout] | [INFO] [stdout] 40 | let mut address_in_rom = 0 as u32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `vec` [INFO] [stdout] --> src/rom.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 91 | for i in 0..HEADER_SIZE { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 91 - for i in 0..HEADER_SIZE { [INFO] [stdout] 91 + for in vec.iter().take(HEADER_SIZE) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/rom.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 110 | for i in 0..3 as u32 { [INFO] [stdout] | ^^^^^^^^ help: try: `3_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> src/rom.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | let mut value = 0 as u64; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/rom.rs:146:21 [INFO] [stdout] | [INFO] [stdout] 146 | for i in 0..7 as u32 { [INFO] [stdout] | ^^^^^^^^ help: try: `7_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rom.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | / match self.mirroring_type() { [INFO] [stdout] 168 | | Mirrorings::Horizontal => true, [INFO] [stdout] 169 | | _ => false, [INFO] [stdout] 170 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 167 - match self.mirroring_type() { [INFO] [stdout] 168 - Mirrorings::Horizontal => true, [INFO] [stdout] 169 - _ => false, [INFO] [stdout] 170 - } [INFO] [stdout] 167 + matches!(self.mirroring_type(), Mirrorings::Horizontal) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking inferno v0.12.1 [INFO] [stderr] Checking bstr v1.11.3 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking opener v0.7.2 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking clap v4.5.32 [INFO] [stderr] Checking clap_complete v4.5.46 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking camino v1.1.9 [INFO] [stderr] Checking cargo-platform v0.1.9 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking cargo_metadata v0.19.2 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking flamegraph v0.6.7 [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/apu.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | audio: audio, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `audio` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/apu.rs:350:13 [INFO] [stdout] | [INFO] [stdout] 350 | channel: channel, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:1104:13 [INFO] [stdout] | [INFO] [stdout] 1104 | input: input, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | * 0x8000 - 0xBFFF: 0x0000 - 0x3FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:53:7 [INFO] [stdout] | [INFO] [stdout] 53 | * 0xC000 - 0xFFFF: 0x0000 - 0x3FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/mapper.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | control_register: control_register, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_register` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ppu.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | display: display, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ppu.rs:1328:26 [INFO] [stdout] | [INFO] [stdout] 1328 | SpritesManager { memory: memory } [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | header: header, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | mapper: mapper, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mapper` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/rom.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | let r = Rom::new(vec![0; 17]); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/apu.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | if (self.cycle % self.sample_period) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(self.sample_period)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/apu.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 86 | if (self.cycle % 2) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/apu.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | if (self.cycle % 7457) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(7457)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apu.rs:666:9 [INFO] [stdout] | [INFO] [stdout] 666 | return SEQUENCE_TABLE[self.timer_sequence as usize] & 0xF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 666 - return SEQUENCE_TABLE[self.timer_sequence as usize] & 0xF; [INFO] [stdout] 666 + SEQUENCE_TABLE[self.timer_sequence as usize] & 0xF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/apu.rs:796:36 [INFO] [stdout] | [INFO] [stdout] 796 | self.shift_register = ((feedback as u16) << 14) | (self.shift_register >> 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `feedback` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/apu.rs:1033:13 [INFO] [stdout] | [INFO] [stdout] 1033 | self.shift_register = self.shift_register >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.shift_register >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INV` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | INV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | ADC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Adc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | ASL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Asl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | BCC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | BCS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BEQ` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | BEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Beq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BIT` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | BIT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BMI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | BMI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bmi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BNE` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | BNE, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bne` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BPL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | BPL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bpl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BRK` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | BRK, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Brk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | BVC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | BVS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | CLC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLD` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | CLD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLV` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | CLV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CMP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | CMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | CPX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | CPY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | DEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | DEX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | DEY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | EOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Eor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | INC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | INX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | INY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Iny` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | JMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | JSR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | LDA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lda` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | LDX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | LDY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LSR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | LSR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | NOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ORA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | ORA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ora` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | PHA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | PHP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Php` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 116 | PLA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | PLP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Plp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | ROL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 119 | ROR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ror` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | RTI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | SBC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | SEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SED` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | SED, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | SEI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sei` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | STA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | STX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Stx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | STY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | TAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | TAY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tay` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TSX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | TSX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Tsx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | TXA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Txa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 133 | TXS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Txs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TYA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tya` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1292:53 [INFO] [stdout] | [INFO] [stdout] 1292 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:1320:20 [INFO] [stdout] | [INFO] [stdout] 1320 | if !(((src1 ^ src2 as u8) & 0x80) != 0) && ((src2 as u8 ^ result as u8) & 0x80) != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((src1 ^ src2 as u8) & 0x80) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1310:59 [INFO] [stdout] | [INFO] [stdout] 1310 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1329:59 [INFO] [stdout] | [INFO] [stdout] 1329 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1344:32 [INFO] [stdout] | [INFO] [stdout] 1344 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1348:32 [INFO] [stdout] | [INFO] [stdout] 1348 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1352:32 [INFO] [stdout] | [INFO] [stdout] 1352 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1357:59 [INFO] [stdout] | [INFO] [stdout] 1357 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1369:32 [INFO] [stdout] | [INFO] [stdout] 1369 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1373:32 [INFO] [stdout] | [INFO] [stdout] 1373 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1377:32 [INFO] [stdout] | [INFO] [stdout] 1377 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1387:32 [INFO] [stdout] | [INFO] [stdout] 1387 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1391:32 [INFO] [stdout] | [INFO] [stdout] 1391 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1414:59 [INFO] [stdout] | [INFO] [stdout] 1414 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1451:59 [INFO] [stdout] | [INFO] [stdout] 1451 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1502:51 [INFO] [stdout] | [INFO] [stdout] 1502 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1507:51 [INFO] [stdout] | [INFO] [stdout] 1507 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1512:51 [INFO] [stdout] | [INFO] [stdout] 1512 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1657:59 [INFO] [stdout] | [INFO] [stdout] 1657 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1691:49 [INFO] [stdout] | [INFO] [stdout] 1691 | self.store_with_addressing_mode(&op, value); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1695:49 [INFO] [stdout] | [INFO] [stdout] 1695 | self.store_with_addressing_mode(&op, value); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1699:49 [INFO] [stdout] | [INFO] [stdout] 1699 | self.store_with_addressing_mode(&op, value); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1749:12 [INFO] [stdout] | [INFO] [stdout] 1749 | if address >= 0x2000 && address < 0x4000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..0x4000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1754:12 [INFO] [stdout] | [INFO] [stdout] 1754 | if (address >= 0x4000 && address < 0x4014) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..0x4014).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1756:16 [INFO] [stdout] | [INFO] [stdout] 1756 | || (address >= 0x4017 && address < 0x4020) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4017..0x4020).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1773:12 [INFO] [stdout] | [INFO] [stdout] 1773 | if address >= 0x4020 && address < 0x6000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4020..0x6000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1777:12 [INFO] [stdout] | [INFO] [stdout] 1777 | if address >= 0x6000 && address < 0x8000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x6000..0x8000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1818:12 [INFO] [stdout] | [INFO] [stdout] 1818 | if address >= 0x2000 && address < 0x4000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..0x4000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1824:12 [INFO] [stdout] | [INFO] [stdout] 1824 | if (address >= 0x4000 && address < 0x4014) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..0x4014).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1826:16 [INFO] [stdout] | [INFO] [stdout] 1826 | || (address >= 0x4017 && address < 0x4020) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4017..0x4020).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1856:12 [INFO] [stdout] | [INFO] [stdout] 1856 | if address >= 0x4020 && address < 0x6000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4020..0x6000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1862:12 [INFO] [stdout] | [INFO] [stdout] 1862 | if address >= 0x6000 && address < 0x8000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x6000..0x8000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cpu.rs:1878:17 [INFO] [stdout] | [INFO] [stdout] 1878 | / if self.p.is_i() { [INFO] [stdout] 1879 | | return; [INFO] [stdout] 1880 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1877 ~ Interrupts::IRQ [INFO] [stdout] 1878 ~ if self.p.is_i() => { [INFO] [stdout] 1879 | return; [INFO] [stdout] 1880 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/cpu.rs:1876:9 [INFO] [stdout] | [INFO] [stdout] 1876 | / match interrupt_type { [INFO] [stdout] 1877 | | Interrupts::IRQ => { [INFO] [stdout] 1878 | | if self.p.is_i() { [INFO] [stdout] 1879 | | return; [INFO] [stdout] ... | [INFO] [stdout] 1882 | | _ => {} [INFO] [stdout] 1883 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1876 ~ if let Interrupts::IRQ = interrupt_type { [INFO] [stdout] 1877 + if self.p.is_i() { [INFO] [stdout] 1878 + return; [INFO] [stdout] 1879 + } [INFO] [stdout] 1880 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1909:69 [INFO] [stdout] | [INFO] [stdout] 1909 | let address = self.get_address_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cpu.rs:1988:25 [INFO] [stdout] | [INFO] [stdout] 1988 | / if (address & 0xff00) != (effective_address & 0xff00) { [INFO] [stdout] 1989 | | self.stall_cycles += 1; [INFO] [stdout] 1990 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1986 ~ | InstructionTypes::SBC [INFO] [stdout] 1987 | // stall_cycles + 1 if page is crossed [INFO] [stdout] 1988 ~ if (address & 0xff00) != (effective_address & 0xff00) => { [INFO] [stdout] 1989 | self.stall_cycles += 1; [INFO] [stdout] 1990 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/cpu.rs:2019:48 [INFO] [stdout] | [INFO] [stdout] 2019 | self.load_2bytes_from_zeropage(((tmp.wrapping_add(self.x.load())) & 0xFF) as u16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(tmp.wrapping_add(self.x.load()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cpu.rs:2035:25 [INFO] [stdout] | [INFO] [stdout] 2035 | / if (address2 & 0xff00) != (effective_address & 0xff00) { [INFO] [stdout] 2036 | | self.stall_cycles += 1; [INFO] [stdout] 2037 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2033 ~ | InstructionTypes::SBC [INFO] [stdout] 2034 | // stall_cycles + 1 if page is crossed [INFO] [stdout] 2035 ~ if (address2 & 0xff00) != (effective_address & 0xff00) => { [INFO] [stdout] 2036 | self.stall_cycles += 1; [INFO] [stdout] 2037 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2112:15 [INFO] [stdout] | [INFO] [stdout] 2112 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2113:15 [INFO] [stdout] | [INFO] [stdout] 2113 | + &"pc:".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"pc:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2116:15 [INFO] [stdout] | [INFO] [stdout] 2116 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2117:15 [INFO] [stdout] | [INFO] [stdout] 2117 | + &"sp:".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"sp:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2119:15 [INFO] [stdout] | [INFO] [stdout] 2119 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2120:15 [INFO] [stdout] | [INFO] [stdout] 2120 | + &"a:".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"a:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2122:15 [INFO] [stdout] | [INFO] [stdout] 2122 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2123:15 [INFO] [stdout] | [INFO] [stdout] 2123 | + &"x:".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"x:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2125:15 [INFO] [stdout] | [INFO] [stdout] 2125 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2126:15 [INFO] [stdout] | [INFO] [stdout] 2126 | + &"y:".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"y:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2128:15 [INFO] [stdout] | [INFO] [stdout] 2128 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2130:15 [INFO] [stdout] | [INFO] [stdout] 2130 | + &" ".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2137:73 [INFO] [stdout] | [INFO] [stdout] 2137 | "#".to_owned() + &format!("0x{:02x} ", self.load(pc)) + &"immediate".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"immediate"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2140:61 [INFO] [stdout] | [INFO] [stdout] 2140 | format!("0x{:02x} ", self.load(pc) as i8) + &"relative".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"relative"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2146:23 [INFO] [stdout] | [INFO] [stdout] 2146 | + &"absolute".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"absolute"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2155:23 [INFO] [stdout] | [INFO] [stdout] 2155 | + &"indexed_absolute_x".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_absolute_x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2164:23 [INFO] [stdout] | [INFO] [stdout] 2164 | + &"indexed_absolute_y".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_absolute_y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2170:23 [INFO] [stdout] | [INFO] [stdout] 2170 | + &"zero_page".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"zero_page"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2179:23 [INFO] [stdout] | [INFO] [stdout] 2179 | + &"indexed_zero_page_x".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_zero_page_x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2188:23 [INFO] [stdout] | [INFO] [stdout] 2188 | + &"indexed_zero_page_y".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_zero_page_y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2195:23 [INFO] [stdout] | [INFO] [stdout] 2195 | + &"indirect".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indirect"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2202:23 [INFO] [stdout] | [INFO] [stdout] 2202 | + &"indexed_indirect_x".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_indirect_x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2211:23 [INFO] [stdout] | [INFO] [stdout] 2211 | + &"indexed_indirect_y".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_indirect_y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2214:56 [INFO] [stdout] | [INFO] [stdout] 2214 | format!("A0x{:02x} ", self.a.load()) + &"accumulator".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"accumulator"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CpuStatusRegister` [INFO] [stdout] --> src/cpu.rs:2226:5 [INFO] [stdout] | [INFO] [stdout] 2226 | / pub fn new() -> Self { [INFO] [stdout] 2227 | | CpuStatusRegister { [INFO] [stdout] 2228 | | register: Register::::new(), [INFO] [stdout] 2229 | | } [INFO] [stdout] 2230 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 2225 + impl Default for CpuStatusRegister { [INFO] [stdout] 2226 + fn default() -> Self { [INFO] [stdout] 2227 + Self::new() [INFO] [stdout] 2228 + } [INFO] [stdout] 2229 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2341:15 [INFO] [stdout] | [INFO] [stdout] 2341 | + &"(".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `"("` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2382:15 [INFO] [stdout] | [INFO] [stdout] 2382 | + &")".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultAudio` [INFO] [stdout] --> src/default_audio.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / pub fn new() -> Self { [INFO] [stdout] 11 | | DefaultAudio { [INFO] [stdout] 12 | | buffer_index: 0, [INFO] [stdout] 13 | | buffer: [0.0; BUFFER_CAPACITY], [INFO] [stdout] ... | [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl Default for DefaultAudio { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `sample_buffer` [INFO] [stdout] --> src/default_audio.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..client_sample_buffer_length { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..client_sample_buffer_length { [INFO] [stdout] 34 + for (i, ) in sample_buffer.iter_mut().enumerate().take(client_sample_buffer_length) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultDisplay` [INFO] [stdout] --> src/default_display.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> Self { [INFO] [stdout] 9 | | DefaultDisplay { [INFO] [stdout] 10 | | pixels: vec![0; PIXELS_CAPACITY], [INFO] [stdout] 11 | | } [INFO] [stdout] 12 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for DefaultDisplay { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/default_display.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | self.pixels[(base_index + 0) as usize] = b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `base_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/default_display.rs:33:58 [INFO] [stdout] | [INFO] [stdout] 33 | pixels[base_index * 4 + 0] = self.pixels[base_index * 3 + 0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(base_index * 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/default_display.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 33 | pixels[base_index * 4 + 0] = self.pixels[base_index * 3 + 0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(base_index * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultInput` [INFO] [stdout] --> src/default_input.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | DefaultInput { [INFO] [stdout] 13 | | events: VecDeque::<(button::Button, button::Event)>::new(), [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for DefaultInput { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/default_input.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 20 | match self.events.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.events.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Joypad` [INFO] [stdout] --> src/joypad.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / pub fn new() -> Self { [INFO] [stdout] 39 | | Joypad { [INFO] [stdout] 40 | | register: Register::::new(), [INFO] [stdout] 41 | | latch: 0, [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 37 + impl Default for Joypad { [INFO] [stdout] 38 + fn default() -> Self { [INFO] [stdout] 39 + Self::new() [INFO] [stdout] 40 + } [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/joypad.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | value = value & 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value &= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mapper.rs:54:7 [INFO] [stdout] | [INFO] [stdout] 54 | * else: [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 54 | * else: [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mapper.rs:55:7 [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/mapper.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | offset = offset | (address & 0x4000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset |= (address & 0x4000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/mapper.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | offset = offset | (address & 0x1000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset |= (address & 0x1000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> src/mapper.rs:477:9 [INFO] [stdout] | [INFO] [stdout] 477 | / NRomMapper { [INFO] [stdout] 478 | | program_bank_num: 1, [INFO] [stdout] 479 | | }; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] = note: `#[warn(clippy::no_effect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 428 | address = address & 0x3FFF; // just in case [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `address &= 0x3FFF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | address = address & 0x3FFF; // just in case [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `address &= 0x3FFF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ppu.rs:832:12 [INFO] [stdout] | [INFO] [stdout] 832 | if (self.cycle % 8) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:902:28 [INFO] [stdout] | [INFO] [stdout] 902 | self.ppuaddr.store(self.current_vram_address as u8 & 0xFF); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(self.current_vram_address as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:1084:13 [INFO] [stdout] | [INFO] [stdout] 1084 | c = c | 0x00FF0000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `c |= 0x00FF0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:1087:13 [INFO] [stdout] | [INFO] [stdout] 1087 | c = c | 0x0000FF00; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `c |= 0x0000FF00` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:1090:13 [INFO] [stdout] | [INFO] [stdout] 1090 | c = c | 0x000000FF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `c |= 0x000000FF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/ppu.rs:1095:34 [INFO] [stdout] | [INFO] [stdout] 1095 | pub fn get_display(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&dyn Display` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:1347:30 [INFO] [stdout] | [INFO] [stdout] 1347 | byte0: self.load(index * 4 + 0), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `(index * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:1356:20 [INFO] [stdout] | [INFO] [stdout] 1356 | self.store(index * 4 + 0, sprite.byte0); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `(index * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:1365:24 [INFO] [stdout] | [INFO] [stdout] 1365 | self.store(i * 4 + 0, 0xff); [INFO] [stdout] | ^^^^^^^^^ help: consider reducing it to: `(i * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Register` [INFO] [stdout] --> src/register.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> Register { [INFO] [stdout] 9 | | Register { data: 0 } [INFO] [stdout] 10 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for Register { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Register` [INFO] [stdout] --> src/register.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | / pub fn new() -> Register { [INFO] [stdout] 94 | | Register { data: 0 } [INFO] [stdout] 95 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 92 + impl Default for Register { [INFO] [stdout] 93 + fn default() -> Self { [INFO] [stdout] 94 + Self::new() [INFO] [stdout] 95 + } [INFO] [stdout] 96 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:278:9 [INFO] [stdout] | [INFO] [stdout] 278 | assert_eq!(false, r.is_bit_set(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 278 - assert_eq!(false, r.is_bit_set(1)); [INFO] [stdout] 278 + assert!(!r.is_bit_set(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 280 | assert_eq!(true, r.is_bit_set(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 280 - assert_eq!(true, r.is_bit_set(1)); [INFO] [stdout] 280 + assert!(r.is_bit_set(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:456:9 [INFO] [stdout] | [INFO] [stdout] 456 | assert_eq!(false, r.is_bit_set(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 456 - assert_eq!(false, r.is_bit_set(1)); [INFO] [stdout] 456 + assert!(!r.is_bit_set(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:458:9 [INFO] [stdout] | [INFO] [stdout] 458 | assert_eq!(true, r.is_bit_set(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 458 - assert_eq!(true, r.is_bit_set(1)); [INFO] [stdout] 458 + assert!(r.is_bit_set(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/rom.rs:40:34 [INFO] [stdout] | [INFO] [stdout] 40 | let mut address_in_rom = 0 as u32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `vec` [INFO] [stdout] --> src/rom.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 91 | for i in 0..HEADER_SIZE { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 91 - for i in 0..HEADER_SIZE { [INFO] [stdout] 91 + for in vec.iter().take(HEADER_SIZE) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/rom.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 110 | for i in 0..3 as u32 { [INFO] [stdout] | ^^^^^^^^ help: try: `3_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> src/rom.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | let mut value = 0 as u64; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/rom.rs:146:21 [INFO] [stdout] | [INFO] [stdout] 146 | for i in 0..7 as u32 { [INFO] [stdout] | ^^^^^^^^ help: try: `7_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rom.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | / match self.mirroring_type() { [INFO] [stdout] 168 | | Mirrorings::Horizontal => true, [INFO] [stdout] 169 | | _ => false, [INFO] [stdout] 170 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 167 - match self.mirroring_type() { [INFO] [stdout] 168 - Mirrorings::Horizontal => true, [INFO] [stdout] 169 - _ => false, [INFO] [stdout] 170 - } [INFO] [stdout] 167 + matches!(self.mirroring_type(), Mirrorings::Horizontal) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/rom.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | assert_eq!(false, r.valid()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 216 - assert_eq!(false, r.valid()); [INFO] [stdout] 216 + assert!(!r.valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/rom.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | assert_eq!(true, r2.valid()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 223 - assert_eq!(true, r2.valid()); [INFO] [stdout] 223 + assert!(r2.valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.55s [INFO] running `Command { std: "docker" "inspect" "37065a98210b120f3cc1926c75bb26be39911e8cf54c31b7b336c94529db022c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37065a98210b120f3cc1926c75bb26be39911e8cf54c31b7b336c94529db022c", kill_on_drop: false }` [INFO] [stdout] 37065a98210b120f3cc1926c75bb26be39911e8cf54c31b7b336c94529db022c