[INFO] fetching crate nes_rust 0.1.2... [INFO] linting nes_rust-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate nes_rust 0.1.2 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate nes_rust 0.1.2 [INFO] finished tweaking crates.io crate nes_rust 0.1.2 [INFO] tweaked toml for crates.io crate nes_rust 0.1.2 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate nes_rust 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5117d5071e20e0de91cf21973d5404198f76cbebec2129687306f91999f843ac [INFO] running `Command { std: "docker" "start" "-a" "5117d5071e20e0de91cf21973d5404198f76cbebec2129687306f91999f843ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5117d5071e20e0de91cf21973d5404198f76cbebec2129687306f91999f843ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5117d5071e20e0de91cf21973d5404198f76cbebec2129687306f91999f843ac", kill_on_drop: false }` [INFO] [stdout] 5117d5071e20e0de91cf21973d5404198f76cbebec2129687306f91999f843ac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42ce7f8e5ec5f65fb9e224662906c110b04fe93db53656c86048983a35432476 [INFO] running `Command { std: "docker" "start" "-a" "42ce7f8e5ec5f65fb9e224662906c110b04fe93db53656c86048983a35432476", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking nes_rust v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:1106:4 [INFO] [stdout] | [INFO] [stdout] 1106 | input: input, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ppu.rs:236:4 [INFO] [stdout] | [INFO] [stdout] 236 | display: display, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ppu.rs:1287:4 [INFO] [stdout] | [INFO] [stdout] 1287 | memory: memory [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/apu.rs:57:4 [INFO] [stdout] | [INFO] [stdout] 57 | audio: audio [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `audio` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/apu.rs:355:4 [INFO] [stdout] | [INFO] [stdout] 355 | channel: channel, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/apu.rs:800:6 [INFO] [stdout] | [INFO] [stdout] 800 | (((self.shift_register >> match self.is_random() { true => 6, false => 1 })) & 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove them: `(self.shift_register >> match self.is_random() { true => 6, false => 1 })` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:24:4 [INFO] [stdout] | [INFO] [stdout] 24 | header: header, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:26:4 [INFO] [stdout] | [INFO] [stdout] 26 | mapper: mapper [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mapper` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | * CPU memory address: [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | * 0x0000 - 0x1FFF: Character ROM access [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:33:1 [INFO] [stdout] | [INFO] [stdout] 33 | * 0x8000 - 0xFFFF: Program ROM access [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:34:1 [INFO] [stdout] | [INFO] [stdout] 34 | * [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | * To access wide range ROM data with limited CPU memory address space [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | * Mapper maps CPU memory address to ROM's. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:37:1 [INFO] [stdout] | [INFO] [stdout] 37 | * In general writing control registers in Mapper via .store() switches bank. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | */ [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:56:1 [INFO] [stdout] | [INFO] [stdout] 56 | * In general writing with ROM address space updates control registers in Mapper. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:57:1 [INFO] [stdout] | [INFO] [stdout] 57 | */ [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:51:1 [INFO] [stdout] | [INFO] [stdout] 51 | * if program_bank_num == 1: [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:52:1 [INFO] [stdout] | [INFO] [stdout] 52 | * 0x8000 - 0xBFFF: 0x0000 - 0x3FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | * 0x8000 - 0xBFFF: 0x0000 - 0x3FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | * 0xC000 - 0xFFFF: 0x0000 - 0x3FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:53:4 [INFO] [stdout] | [INFO] [stdout] 53 | * 0xC000 - 0xFFFF: 0x0000 - 0x3FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:54:1 [INFO] [stdout] | [INFO] [stdout] 54 | * else: [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:56:1 [INFO] [stdout] | [INFO] [stdout] 56 | */ [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:65:1 [INFO] [stdout] | [INFO] [stdout] 65 | * 0x0000 - 0x1FFF: 0x0000 - 0x1FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:66:1 [INFO] [stdout] | [INFO] [stdout] 66 | */ [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:72:1 [INFO] [stdout] | [INFO] [stdout] 72 | * Nothing to do [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:73:1 [INFO] [stdout] | [INFO] [stdout] 73 | */ [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/mapper.rs:107:4 [INFO] [stdout] | [INFO] [stdout] 107 | control_register: control_register, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_register` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Register` [INFO] [stdout] --> src/register.rs:8:2 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> Register { [INFO] [stdout] 9 | | Register{ data: 0 } [INFO] [stdout] 10 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for Register { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Register` [INFO] [stdout] --> src/register.rs:93:2 [INFO] [stdout] | [INFO] [stdout] 93 | / pub fn new() -> Register { [INFO] [stdout] 94 | | Register{ data: 0 } [INFO] [stdout] 95 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 92 + impl Default for Register { [INFO] [stdout] 93 + fn default() -> Self { [INFO] [stdout] 94 + Self::new() [INFO] [stdout] 95 + } [INFO] [stdout] 96 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INV` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:81:2 [INFO] [stdout] | [INFO] [stdout] 81 | INV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:82:2 [INFO] [stdout] | [INFO] [stdout] 82 | ADC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Adc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:83:2 [INFO] [stdout] | [INFO] [stdout] 83 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:84:2 [INFO] [stdout] | [INFO] [stdout] 84 | ASL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Asl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:85:2 [INFO] [stdout] | [INFO] [stdout] 85 | BCC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:86:2 [INFO] [stdout] | [INFO] [stdout] 86 | BCS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BEQ` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | BEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Beq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BIT` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:88:2 [INFO] [stdout] | [INFO] [stdout] 88 | BIT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BMI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:89:2 [INFO] [stdout] | [INFO] [stdout] 89 | BMI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bmi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BNE` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:90:2 [INFO] [stdout] | [INFO] [stdout] 90 | BNE, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bne` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BPL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:91:2 [INFO] [stdout] | [INFO] [stdout] 91 | BPL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bpl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BRK` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:92:2 [INFO] [stdout] | [INFO] [stdout] 92 | BRK, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Brk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:93:2 [INFO] [stdout] | [INFO] [stdout] 93 | BVC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:94:2 [INFO] [stdout] | [INFO] [stdout] 94 | BVS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:95:2 [INFO] [stdout] | [INFO] [stdout] 95 | CLC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLD` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:96:2 [INFO] [stdout] | [INFO] [stdout] 96 | CLD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:97:2 [INFO] [stdout] | [INFO] [stdout] 97 | CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLV` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:98:2 [INFO] [stdout] | [INFO] [stdout] 98 | CLV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CMP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:99:2 [INFO] [stdout] | [INFO] [stdout] 99 | CMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:100:2 [INFO] [stdout] | [INFO] [stdout] 100 | CPX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:101:2 [INFO] [stdout] | [INFO] [stdout] 101 | CPY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:102:2 [INFO] [stdout] | [INFO] [stdout] 102 | DEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:103:2 [INFO] [stdout] | [INFO] [stdout] 103 | DEX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:104:2 [INFO] [stdout] | [INFO] [stdout] 104 | DEY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:105:2 [INFO] [stdout] | [INFO] [stdout] 105 | EOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Eor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:106:2 [INFO] [stdout] | [INFO] [stdout] 106 | INC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:107:2 [INFO] [stdout] | [INFO] [stdout] 107 | INX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:108:2 [INFO] [stdout] | [INFO] [stdout] 108 | INY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Iny` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:109:2 [INFO] [stdout] | [INFO] [stdout] 109 | JMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:110:2 [INFO] [stdout] | [INFO] [stdout] 110 | JSR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:111:2 [INFO] [stdout] | [INFO] [stdout] 111 | LDA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lda` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:112:2 [INFO] [stdout] | [INFO] [stdout] 112 | LDX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:113:2 [INFO] [stdout] | [INFO] [stdout] 113 | LDY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LSR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:114:2 [INFO] [stdout] | [INFO] [stdout] 114 | LSR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:115:2 [INFO] [stdout] | [INFO] [stdout] 115 | NOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ORA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:116:2 [INFO] [stdout] | [INFO] [stdout] 116 | ORA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ora` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:117:2 [INFO] [stdout] | [INFO] [stdout] 117 | PHA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:118:2 [INFO] [stdout] | [INFO] [stdout] 118 | PHP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Php` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:119:2 [INFO] [stdout] | [INFO] [stdout] 119 | PLA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:120:2 [INFO] [stdout] | [INFO] [stdout] 120 | PLP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Plp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:121:2 [INFO] [stdout] | [INFO] [stdout] 121 | ROL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:122:2 [INFO] [stdout] | [INFO] [stdout] 122 | ROR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ror` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:123:2 [INFO] [stdout] | [INFO] [stdout] 123 | RTI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:124:2 [INFO] [stdout] | [INFO] [stdout] 124 | RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:125:2 [INFO] [stdout] | [INFO] [stdout] 125 | SBC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:126:2 [INFO] [stdout] | [INFO] [stdout] 126 | SEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SED` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:127:2 [INFO] [stdout] | [INFO] [stdout] 127 | SED, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:128:2 [INFO] [stdout] | [INFO] [stdout] 128 | SEI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sei` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:129:2 [INFO] [stdout] | [INFO] [stdout] 129 | STA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:130:2 [INFO] [stdout] | [INFO] [stdout] 130 | STX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Stx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:131:2 [INFO] [stdout] | [INFO] [stdout] 131 | STY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:132:2 [INFO] [stdout] | [INFO] [stdout] 132 | TAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:133:2 [INFO] [stdout] | [INFO] [stdout] 133 | TAY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tay` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TSX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:134:2 [INFO] [stdout] | [INFO] [stdout] 134 | TSX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Tsx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:135:2 [INFO] [stdout] | [INFO] [stdout] 135 | TXA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Txa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:136:2 [INFO] [stdout] | [INFO] [stdout] 136 | TXS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Txs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TYA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:137:2 [INFO] [stdout] | [INFO] [stdout] 137 | TYA [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tya` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:1106:4 [INFO] [stdout] | [INFO] [stdout] 1106 | input: input, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1274:47 [INFO] [stdout] | [INFO] [stdout] 1274 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:1302:8 [INFO] [stdout] | [INFO] [stdout] 1302 | if !(((src1 ^ src2 as u8) & 0x80) != 0) && ((src2 as u8 ^ result as u8) & 0x80) != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((src1 ^ src2 as u8) & 0x80) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1292:47 [INFO] [stdout] | [INFO] [stdout] 1292 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1310:47 [INFO] [stdout] | [INFO] [stdout] 1310 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1326:20 [INFO] [stdout] | [INFO] [stdout] 1326 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1330:20 [INFO] [stdout] | [INFO] [stdout] 1330 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1334:20 [INFO] [stdout] | [INFO] [stdout] 1334 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1339:47 [INFO] [stdout] | [INFO] [stdout] 1339 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1351:20 [INFO] [stdout] | [INFO] [stdout] 1351 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1355:20 [INFO] [stdout] | [INFO] [stdout] 1355 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1359:20 [INFO] [stdout] | [INFO] [stdout] 1359 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1369:20 [INFO] [stdout] | [INFO] [stdout] 1369 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1373:20 [INFO] [stdout] | [INFO] [stdout] 1373 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1399:47 [INFO] [stdout] | [INFO] [stdout] 1399 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ppu.rs:236:4 [INFO] [stdout] | [INFO] [stdout] 236 | display: display, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1436:47 [INFO] [stdout] | [INFO] [stdout] 1436 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1487:51 [INFO] [stdout] | [INFO] [stdout] 1487 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1492:51 [INFO] [stdout] | [INFO] [stdout] 1492 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1497:51 [INFO] [stdout] | [INFO] [stdout] 1497 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ppu.rs:1287:4 [INFO] [stdout] | [INFO] [stdout] 1287 | memory: memory [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/apu.rs:57:4 [INFO] [stdout] | [INFO] [stdout] 57 | audio: audio [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `audio` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/apu.rs:355:4 [INFO] [stdout] | [INFO] [stdout] 355 | channel: channel, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1642:47 [INFO] [stdout] | [INFO] [stdout] 1642 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/apu.rs:800:6 [INFO] [stdout] | [INFO] [stdout] 800 | (((self.shift_register >> match self.is_random() { true => 6, false => 1 })) & 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove them: `(self.shift_register >> match self.is_random() { true => 6, false => 1 })` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1676:37 [INFO] [stdout] | [INFO] [stdout] 1676 | self.store_with_addressing_mode(&op, value); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1680:37 [INFO] [stdout] | [INFO] [stdout] 1680 | self.store_with_addressing_mode(&op, value); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1684:37 [INFO] [stdout] | [INFO] [stdout] 1684 | self.store_with_addressing_mode(&op, value); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:24:4 [INFO] [stdout] | [INFO] [stdout] 24 | header: header, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:26:4 [INFO] [stdout] | [INFO] [stdout] 26 | mapper: mapper [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mapper` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | * CPU memory address: [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | * 0x0000 - 0x1FFF: Character ROM access [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:33:1 [INFO] [stdout] | [INFO] [stdout] 33 | * 0x8000 - 0xFFFF: Program ROM access [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:34:1 [INFO] [stdout] | [INFO] [stdout] 34 | * [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | * To access wide range ROM data with limited CPU memory address space [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | * Mapper maps CPU memory address to ROM's. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:37:1 [INFO] [stdout] | [INFO] [stdout] 37 | * In general writing control registers in Mapper via .store() switches bank. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | */ [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:56:1 [INFO] [stdout] | [INFO] [stdout] 56 | * In general writing with ROM address space updates control registers in Mapper. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/rom.rs:57:1 [INFO] [stdout] | [INFO] [stdout] 57 | */ [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1734:6 [INFO] [stdout] | [INFO] [stdout] 1734 | if address >= 0x2000 && address < 0x4000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..0x4000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1738:6 [INFO] [stdout] | [INFO] [stdout] 1738 | if address >= 0x4000 && address < 0x4014 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..0x4014).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1758:6 [INFO] [stdout] | [INFO] [stdout] 1758 | if address >= 0x4017 && address < 0x4020 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4017..0x4020).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1762:6 [INFO] [stdout] | [INFO] [stdout] 1762 | if address >= 0x4020 && address < 0x6000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4020..0x6000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1766:6 [INFO] [stdout] | [INFO] [stdout] 1766 | if address >= 0x6000 && address < 0x8000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x6000..0x8000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1806:6 [INFO] [stdout] | [INFO] [stdout] 1806 | if address >= 0x2000 && address < 0x4000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..0x4000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1810:6 [INFO] [stdout] | [INFO] [stdout] 1810 | if address >= 0x4000 && address < 0x4014 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..0x4014).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:51:1 [INFO] [stdout] | [INFO] [stdout] 51 | * if program_bank_num == 1: [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:52:1 [INFO] [stdout] | [INFO] [stdout] 52 | * 0x8000 - 0xBFFF: 0x0000 - 0x3FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | * 0x8000 - 0xBFFF: 0x0000 - 0x3FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | * 0xC000 - 0xFFFF: 0x0000 - 0x3FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:53:4 [INFO] [stdout] | [INFO] [stdout] 53 | * 0xC000 - 0xFFFF: 0x0000 - 0x3FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:54:1 [INFO] [stdout] | [INFO] [stdout] 54 | * else: [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:56:1 [INFO] [stdout] | [INFO] [stdout] 56 | */ [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:65:1 [INFO] [stdout] | [INFO] [stdout] 65 | * 0x0000 - 0x1FFF: 0x0000 - 0x1FFF [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:66:1 [INFO] [stdout] | [INFO] [stdout] 66 | */ [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:72:1 [INFO] [stdout] | [INFO] [stdout] 72 | * Nothing to do [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/mapper.rs:73:1 [INFO] [stdout] | [INFO] [stdout] 73 | */ [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1841:6 [INFO] [stdout] | [INFO] [stdout] 1841 | if address >= 0x4017 && address < 0x4020 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4017..0x4020).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/mapper.rs:107:4 [INFO] [stdout] | [INFO] [stdout] 107 | control_register: control_register, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_register` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1847:6 [INFO] [stdout] | [INFO] [stdout] 1847 | if address >= 0x4020 && address < 0x6000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4020..0x6000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1853:6 [INFO] [stdout] | [INFO] [stdout] 1853 | if address >= 0x6000 && address < 0x8000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x6000..0x8000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cpu.rs:1869:5 [INFO] [stdout] | [INFO] [stdout] 1869 | / if self.p.is_i() { [INFO] [stdout] 1870 | | return; [INFO] [stdout] 1871 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1868 ~ Interrupts::IRQ [INFO] [stdout] 1869 ~ if self.p.is_i() => { [INFO] [stdout] 1870 | return; [INFO] [stdout] 1871 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/cpu.rs:1867:3 [INFO] [stdout] | [INFO] [stdout] 1867 | / match interrupt_type { [INFO] [stdout] 1868 | | Interrupts::IRQ => { [INFO] [stdout] 1869 | | if self.p.is_i() { [INFO] [stdout] 1870 | | return; [INFO] [stdout] ... | [INFO] [stdout] 1873 | | _ => {} [INFO] [stdout] 1874 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1867 ~ if let Interrupts::IRQ = interrupt_type { [INFO] [stdout] 1868 ~ if self.p.is_i() { [INFO] [stdout] 1869 ~ return; [INFO] [stdout] 1870 ~ } [INFO] [stdout] 1871 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1902:57 [INFO] [stdout] | [INFO] [stdout] 1902 | let address = self.get_address_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cpu.rs:1976:7 [INFO] [stdout] | [INFO] [stdout] 1976 | / if (address & 0xff00) != (effective_address & 0xff00) { [INFO] [stdout] 1977 | | self.stall_cycles += 1; [INFO] [stdout] 1978 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1974 ~ InstructionTypes::SBC [INFO] [stdout] 1975 | // stall_cycles + 1 if page is crossed [INFO] [stdout] 1976 ~ if (address & 0xff00) != (effective_address & 0xff00) => { [INFO] [stdout] 1977 | self.stall_cycles += 1; [INFO] [stdout] 1978 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/cpu.rs:2004:36 [INFO] [stdout] | [INFO] [stdout] 2004 | self.load_2bytes_from_zeropage(((tmp.wrapping_add(self.x.load())) & 0xFF) as u16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(tmp.wrapping_add(self.x.load()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cpu.rs:2020:7 [INFO] [stdout] | [INFO] [stdout] 2020 | / if (address2 & 0xff00) != (effective_address & 0xff00) { [INFO] [stdout] 2021 | | self.stall_cycles += 1; [INFO] [stdout] 2022 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2018 ~ InstructionTypes::SBC [INFO] [stdout] 2019 | // stall_cycles + 1 if page is crossed [INFO] [stdout] 2020 ~ if (address2 & 0xff00) != (effective_address & 0xff00) => { [INFO] [stdout] 2021 | self.stall_cycles += 1; [INFO] [stdout] 2022 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2095:38 [INFO] [stdout] | [INFO] [stdout] 2095 | "p:".to_owned() + &self.p.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2096:3 [INFO] [stdout] | [INFO] [stdout] 2096 | &"pc:".to_owned() + &self.pc.dump() + &format!("(0x{:02x})", opc) + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"pc:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2096:71 [INFO] [stdout] | [INFO] [stdout] 2096 | &"pc:".to_owned() + &self.pc.dump() + &format!("(0x{:02x})", opc) + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2097:3 [INFO] [stdout] | [INFO] [stdout] 2097 | &"sp:".to_owned() + &self.sp.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"sp:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2097:41 [INFO] [stdout] | [INFO] [stdout] 2097 | &"sp:".to_owned() + &self.sp.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2098:3 [INFO] [stdout] | [INFO] [stdout] 2098 | &"a:".to_owned() + &self.a.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"a:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2098:39 [INFO] [stdout] | [INFO] [stdout] 2098 | &"a:".to_owned() + &self.a.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2099:3 [INFO] [stdout] | [INFO] [stdout] 2099 | &"x:".to_owned() + &self.x.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"x:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2099:39 [INFO] [stdout] | [INFO] [stdout] 2099 | &"x:".to_owned() + &self.x.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2100:3 [INFO] [stdout] | [INFO] [stdout] 2100 | &"y:".to_owned() + &self.y.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"y:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2100:39 [INFO] [stdout] | [INFO] [stdout] 2100 | &"y:".to_owned() + &self.y.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2101:43 [INFO] [stdout] | [INFO] [stdout] 2101 | instruction_name(op.instruction_type) + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2109:5 [INFO] [stdout] | [INFO] [stdout] 2109 | &"immediate".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"immediate"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2113:5 [INFO] [stdout] | [INFO] [stdout] 2113 | &"relative".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"relative"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2119:5 [INFO] [stdout] | [INFO] [stdout] 2119 | &"absolute".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"absolute"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2125:5 [INFO] [stdout] | [INFO] [stdout] 2125 | &"indexed_absolute_x".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_absolute_x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2131:5 [INFO] [stdout] | [INFO] [stdout] 2131 | &"indexed_absolute_y".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_absolute_y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2137:5 [INFO] [stdout] | [INFO] [stdout] 2137 | &"zero_page".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"zero_page"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2143:5 [INFO] [stdout] | [INFO] [stdout] 2143 | &"indexed_zero_page_x".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_zero_page_x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2149:5 [INFO] [stdout] | [INFO] [stdout] 2149 | &"indexed_zero_page_y".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_zero_page_y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2156:5 [INFO] [stdout] | [INFO] [stdout] 2156 | &"indirect".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indirect"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2163:5 [INFO] [stdout] | [INFO] [stdout] 2163 | &"indexed_indirect_x".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_indirect_x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2170:5 [INFO] [stdout] | [INFO] [stdout] 2170 | &"indexed_indirect_y".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_indirect_y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2174:5 [INFO] [stdout] | [INFO] [stdout] 2174 | &"accumulator".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"accumulator"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CpuStatusRegister` [INFO] [stdout] --> src/cpu.rs:2186:2 [INFO] [stdout] | [INFO] [stdout] 2186 | / pub fn new() -> Self { [INFO] [stdout] 2187 | | CpuStatusRegister { [INFO] [stdout] 2188 | | register: Register::::new() [INFO] [stdout] 2189 | | } [INFO] [stdout] 2190 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 2185 + impl Default for CpuStatusRegister { [INFO] [stdout] 2186 + fn default() -> Self { [INFO] [stdout] 2187 + Self::new() [INFO] [stdout] 2188 + } [INFO] [stdout] 2189 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2301:3 [INFO] [stdout] | [INFO] [stdout] 2301 | &"(".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `"("` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2310:3 [INFO] [stdout] | [INFO] [stdout] 2310 | &")".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:436:3 [INFO] [stdout] | [INFO] [stdout] 436 | address = address & 0x3FFF; // just in case [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `address &= 0x3FFF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:448:3 [INFO] [stdout] | [INFO] [stdout] 448 | address = address & 0x3FFF; // just in case [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `address &= 0x3FFF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ppu.rs:782:3 [INFO] [stdout] | [INFO] [stdout] 782 | / if self.cycle == 20 && self.scanline == 241 { [INFO] [stdout] 783 | | if self.ppustatus.is_vblank() && [INFO] [stdout] 784 | | self.ppuctrl.is_nmi_enabled() { [INFO] [stdout] 785 | | self.nmi_interrupted = true; [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 782 ~ if self.cycle == 20 && self.scanline == 241 [INFO] [stdout] 783 ~ && self.ppustatus.is_vblank() && [INFO] [stdout] 784 | self.ppuctrl.is_nmi_enabled() { [INFO] [stdout] 785 | self.nmi_interrupted = true; [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ppu.rs:808:3 [INFO] [stdout] | [INFO] [stdout] 808 | / if self.scanline == 261 { [INFO] [stdout] 809 | | if self.cycle >= 280 && self.cycle <= 304 { [INFO] [stdout] 810 | | self.current_vram_address &= !0x7BE0; [INFO] [stdout] 811 | | self.current_vram_address |= self.temporal_vram_address & 0x7BE0; [INFO] [stdout] 812 | | } [INFO] [stdout] 813 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 808 ~ if self.scanline == 261 [INFO] [stdout] 809 ~ && self.cycle >= 280 && self.cycle <= 304 { [INFO] [stdout] 810 | self.current_vram_address &= !0x7BE0; [INFO] [stdout] 811 | self.current_vram_address |= self.temporal_vram_address & 0x7BE0; [INFO] [stdout] 812 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ppu.rs:819:6 [INFO] [stdout] | [INFO] [stdout] 819 | if (self.cycle % 8) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:889:22 [INFO] [stdout] | [INFO] [stdout] 889 | self.ppuaddr.store(self.current_vram_address as u8 & 0xFF); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(self.current_vram_address as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:1053:4 [INFO] [stdout] | [INFO] [stdout] 1053 | c = c | 0x00FF0000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `c |= 0x00FF0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:1056:4 [INFO] [stdout] | [INFO] [stdout] 1056 | c = c | 0x0000FF00; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `c |= 0x0000FF00` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:1059:4 [INFO] [stdout] | [INFO] [stdout] 1059 | c = c | 0x000000FF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `c |= 0x000000FF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/ppu.rs:1064:31 [INFO] [stdout] | [INFO] [stdout] 1064 | pub fn get_display(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&dyn Display` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:1305:21 [INFO] [stdout] | [INFO] [stdout] 1305 | byte0: self.load(index * 4 + 0), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `(index * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:1313:14 [INFO] [stdout] | [INFO] [stdout] 1313 | self.store(index * 4 + 0, sprite.byte0); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `(index * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:1321:15 [INFO] [stdout] | [INFO] [stdout] 1321 | self.store(i * 4 + 0, 0xff); [INFO] [stdout] | ^^^^^^^^^ help: consider reducing it to: `(i * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/apu.rs:81:6 [INFO] [stdout] | [INFO] [stdout] 81 | if (self.cycle % self.sample_period) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(self.sample_period)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/apu.rs:89:6 [INFO] [stdout] | [INFO] [stdout] 89 | if (self.cycle % 2) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/apu.rs:104:6 [INFO] [stdout] | [INFO] [stdout] 104 | if (self.cycle % 7457) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(7457)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apu.rs:674:3 [INFO] [stdout] | [INFO] [stdout] 674 | return SEQUENCE_TABLE[self.timer_sequence as usize] & 0xF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 674 - return SEQUENCE_TABLE[self.timer_sequence as usize] & 0xF; [INFO] [stdout] 674 + SEQUENCE_TABLE[self.timer_sequence as usize] & 0xF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/apu.rs:802:27 [INFO] [stdout] | [INFO] [stdout] 802 | self.shift_register = ((feedback as u16) << 14) | (self.shift_register >> 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `feedback` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/apu.rs:1045:4 [INFO] [stdout] | [INFO] [stdout] 1045 | self.shift_register = self.shift_register >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.shift_register >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/rom.rs:40:28 [INFO] [stdout] | [INFO] [stdout] 40 | let mut address_in_rom = 0 as u32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `vec` [INFO] [stdout] --> src/rom.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | for i in 0..HEADER_SIZE { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 93 - for i in 0..HEADER_SIZE { [INFO] [stdout] 93 + for in vec.iter().take(HEADER_SIZE) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/rom.rs:112:15 [INFO] [stdout] | [INFO] [stdout] 112 | for i in 0..3 as u32 { [INFO] [stdout] | ^^^^^^^^ help: try: `3_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> src/rom.rs:147:19 [INFO] [stdout] | [INFO] [stdout] 147 | let mut value = 0 as u64; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/rom.rs:148:15 [INFO] [stdout] | [INFO] [stdout] 148 | for i in 0..7 as u32 { [INFO] [stdout] | ^^^^^^^^ help: try: `7_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rom.rs:169:3 [INFO] [stdout] | [INFO] [stdout] 169 | / match self.mirroring_type() { [INFO] [stdout] 170 | | Mirrorings::Horizontal => true, [INFO] [stdout] 171 | | _ => false [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 169 - match self.mirroring_type() { [INFO] [stdout] 170 - Mirrorings::Horizontal => true, [INFO] [stdout] 171 - _ => false [INFO] [stdout] 172 - } [INFO] [stdout] 169 + matches!(self.mirroring_type(), Mirrorings::Horizontal) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mapper.rs:54:4 [INFO] [stdout] | [INFO] [stdout] 54 | * else: [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 54 | * else: [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mapper.rs:55:4 [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/mapper.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | offset = offset | (address & 0x4000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset |= (address & 0x4000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/mapper.rs:154:4 [INFO] [stdout] | [INFO] [stdout] 154 | offset = offset | (address & 0x1000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset |= (address & 0x1000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Joypad` [INFO] [stdout] --> src/joypad.rs:38:2 [INFO] [stdout] | [INFO] [stdout] 38 | / pub fn new() -> Self { [INFO] [stdout] 39 | | Joypad { [INFO] [stdout] 40 | | register: Register::::new(), [INFO] [stdout] 41 | | latch: 0, [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 37 + impl Default for Joypad { [INFO] [stdout] 38 + fn default() -> Self { [INFO] [stdout] 39 + Self::new() [INFO] [stdout] 40 + } [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/joypad.rs:72:3 [INFO] [stdout] | [INFO] [stdout] 72 | value = value & 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value &= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultInput` [INFO] [stdout] --> src/default_input.rs:11:2 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | DefaultInput { [INFO] [stdout] 13 | | events: VecDeque::<(button::Button, button::Event)>::new() [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for DefaultInput { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/default_input.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | match self.events.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.events.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultAudio` [INFO] [stdout] --> src/default_audio.rs:10:2 [INFO] [stdout] | [INFO] [stdout] 10 | / pub fn new() -> Self { [INFO] [stdout] 11 | | DefaultAudio { [INFO] [stdout] 12 | | buffer_index: 0, [INFO] [stdout] 13 | | buffer: [0.0; BUFFER_CAPACITY], [INFO] [stdout] ... | [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl Default for DefaultAudio { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `sample_buffer` [INFO] [stdout] --> src/default_audio.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..client_sample_buffer_length { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..client_sample_buffer_length { [INFO] [stdout] 34 + for (i, ) in sample_buffer.iter_mut().enumerate().take(client_sample_buffer_length) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultDisplay` [INFO] [stdout] --> src/default_display.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | DefaultDisplay { [INFO] [stdout] 16 | | pixels: vec![0; PIXELS_CAPACITY] [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for DefaultDisplay { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/default_display.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 30 | self.pixels[(base_index + 0) as usize] = b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `base_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/default_display.rs:40:46 [INFO] [stdout] | [INFO] [stdout] 40 | pixels[base_index * 4 + 0] = self.pixels[base_index * 3 + 0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(base_index * 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/default_display.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | pixels[base_index * 4 + 0] = self.pixels[base_index * 3 + 0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(base_index * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/rom.rs:200:7 [INFO] [stdout] | [INFO] [stdout] 200 | let r = Rom::new(vec![0; 17]); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Register` [INFO] [stdout] --> src/register.rs:8:2 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> Register { [INFO] [stdout] 9 | | Register{ data: 0 } [INFO] [stdout] 10 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for Register { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Register` [INFO] [stdout] --> src/register.rs:93:2 [INFO] [stdout] | [INFO] [stdout] 93 | / pub fn new() -> Register { [INFO] [stdout] 94 | | Register{ data: 0 } [INFO] [stdout] 95 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 92 + impl Default for Register { [INFO] [stdout] 93 + fn default() -> Self { [INFO] [stdout] 94 + Self::new() [INFO] [stdout] 95 + } [INFO] [stdout] 96 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:278:3 [INFO] [stdout] | [INFO] [stdout] 278 | assert_eq!(false, r.is_bit_set(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 278 - assert_eq!(false, r.is_bit_set(1)); [INFO] [stdout] 278 + assert!(!r.is_bit_set(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:280:3 [INFO] [stdout] | [INFO] [stdout] 280 | assert_eq!(true, r.is_bit_set(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 280 - assert_eq!(true, r.is_bit_set(1)); [INFO] [stdout] 280 + assert!(r.is_bit_set(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:457:3 [INFO] [stdout] | [INFO] [stdout] 457 | assert_eq!(false, r.is_bit_set(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 457 - assert_eq!(false, r.is_bit_set(1)); [INFO] [stdout] 457 + assert!(!r.is_bit_set(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/register.rs:459:3 [INFO] [stdout] | [INFO] [stdout] 459 | assert_eq!(true, r.is_bit_set(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 459 - assert_eq!(true, r.is_bit_set(1)); [INFO] [stdout] 459 + assert!(r.is_bit_set(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INV` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:81:2 [INFO] [stdout] | [INFO] [stdout] 81 | INV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:82:2 [INFO] [stdout] | [INFO] [stdout] 82 | ADC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Adc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:83:2 [INFO] [stdout] | [INFO] [stdout] 83 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:84:2 [INFO] [stdout] | [INFO] [stdout] 84 | ASL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Asl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:85:2 [INFO] [stdout] | [INFO] [stdout] 85 | BCC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:86:2 [INFO] [stdout] | [INFO] [stdout] 86 | BCS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BEQ` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | BEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Beq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BIT` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:88:2 [INFO] [stdout] | [INFO] [stdout] 88 | BIT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BMI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:89:2 [INFO] [stdout] | [INFO] [stdout] 89 | BMI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bmi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BNE` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:90:2 [INFO] [stdout] | [INFO] [stdout] 90 | BNE, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bne` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BPL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:91:2 [INFO] [stdout] | [INFO] [stdout] 91 | BPL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bpl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BRK` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:92:2 [INFO] [stdout] | [INFO] [stdout] 92 | BRK, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Brk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:93:2 [INFO] [stdout] | [INFO] [stdout] 93 | BVC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:94:2 [INFO] [stdout] | [INFO] [stdout] 94 | BVS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:95:2 [INFO] [stdout] | [INFO] [stdout] 95 | CLC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLD` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:96:2 [INFO] [stdout] | [INFO] [stdout] 96 | CLD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:97:2 [INFO] [stdout] | [INFO] [stdout] 97 | CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLV` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:98:2 [INFO] [stdout] | [INFO] [stdout] 98 | CLV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CMP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:99:2 [INFO] [stdout] | [INFO] [stdout] 99 | CMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:100:2 [INFO] [stdout] | [INFO] [stdout] 100 | CPX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:101:2 [INFO] [stdout] | [INFO] [stdout] 101 | CPY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:102:2 [INFO] [stdout] | [INFO] [stdout] 102 | DEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:103:2 [INFO] [stdout] | [INFO] [stdout] 103 | DEX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:104:2 [INFO] [stdout] | [INFO] [stdout] 104 | DEY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:105:2 [INFO] [stdout] | [INFO] [stdout] 105 | EOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Eor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:106:2 [INFO] [stdout] | [INFO] [stdout] 106 | INC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:107:2 [INFO] [stdout] | [INFO] [stdout] 107 | INX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:108:2 [INFO] [stdout] | [INFO] [stdout] 108 | INY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Iny` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:109:2 [INFO] [stdout] | [INFO] [stdout] 109 | JMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:110:2 [INFO] [stdout] | [INFO] [stdout] 110 | JSR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:111:2 [INFO] [stdout] | [INFO] [stdout] 111 | LDA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lda` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:112:2 [INFO] [stdout] | [INFO] [stdout] 112 | LDX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:113:2 [INFO] [stdout] | [INFO] [stdout] 113 | LDY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LSR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:114:2 [INFO] [stdout] | [INFO] [stdout] 114 | LSR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:115:2 [INFO] [stdout] | [INFO] [stdout] 115 | NOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ORA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:116:2 [INFO] [stdout] | [INFO] [stdout] 116 | ORA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ora` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:117:2 [INFO] [stdout] | [INFO] [stdout] 117 | PHA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:118:2 [INFO] [stdout] | [INFO] [stdout] 118 | PHP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Php` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:119:2 [INFO] [stdout] | [INFO] [stdout] 119 | PLA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:120:2 [INFO] [stdout] | [INFO] [stdout] 120 | PLP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Plp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:121:2 [INFO] [stdout] | [INFO] [stdout] 121 | ROL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:122:2 [INFO] [stdout] | [INFO] [stdout] 122 | ROR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ror` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:123:2 [INFO] [stdout] | [INFO] [stdout] 123 | RTI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:124:2 [INFO] [stdout] | [INFO] [stdout] 124 | RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:125:2 [INFO] [stdout] | [INFO] [stdout] 125 | SBC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:126:2 [INFO] [stdout] | [INFO] [stdout] 126 | SEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SED` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:127:2 [INFO] [stdout] | [INFO] [stdout] 127 | SED, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:128:2 [INFO] [stdout] | [INFO] [stdout] 128 | SEI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sei` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:129:2 [INFO] [stdout] | [INFO] [stdout] 129 | STA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:130:2 [INFO] [stdout] | [INFO] [stdout] 130 | STX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Stx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:131:2 [INFO] [stdout] | [INFO] [stdout] 131 | STY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:132:2 [INFO] [stdout] | [INFO] [stdout] 132 | TAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:133:2 [INFO] [stdout] | [INFO] [stdout] 133 | TAY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tay` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TSX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:134:2 [INFO] [stdout] | [INFO] [stdout] 134 | TSX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Tsx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:135:2 [INFO] [stdout] | [INFO] [stdout] 135 | TXA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Txa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:136:2 [INFO] [stdout] | [INFO] [stdout] 136 | TXS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Txs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TYA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:137:2 [INFO] [stdout] | [INFO] [stdout] 137 | TYA [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tya` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1274:47 [INFO] [stdout] | [INFO] [stdout] 1274 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:1302:8 [INFO] [stdout] | [INFO] [stdout] 1302 | if !(((src1 ^ src2 as u8) & 0x80) != 0) && ((src2 as u8 ^ result as u8) & 0x80) != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((src1 ^ src2 as u8) & 0x80) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1292:47 [INFO] [stdout] | [INFO] [stdout] 1292 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1310:47 [INFO] [stdout] | [INFO] [stdout] 1310 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1326:20 [INFO] [stdout] | [INFO] [stdout] 1326 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1330:20 [INFO] [stdout] | [INFO] [stdout] 1330 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1334:20 [INFO] [stdout] | [INFO] [stdout] 1334 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1339:47 [INFO] [stdout] | [INFO] [stdout] 1339 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1351:20 [INFO] [stdout] | [INFO] [stdout] 1351 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1355:20 [INFO] [stdout] | [INFO] [stdout] 1355 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1359:20 [INFO] [stdout] | [INFO] [stdout] 1359 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1369:20 [INFO] [stdout] | [INFO] [stdout] 1369 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1373:20 [INFO] [stdout] | [INFO] [stdout] 1373 | self.do_branch(&op, flag); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1399:47 [INFO] [stdout] | [INFO] [stdout] 1399 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1436:47 [INFO] [stdout] | [INFO] [stdout] 1436 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1487:51 [INFO] [stdout] | [INFO] [stdout] 1487 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1492:51 [INFO] [stdout] | [INFO] [stdout] 1492 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1497:51 [INFO] [stdout] | [INFO] [stdout] 1497 | let result = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1642:47 [INFO] [stdout] | [INFO] [stdout] 1642 | let src2 = self.load_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1676:37 [INFO] [stdout] | [INFO] [stdout] 1676 | self.store_with_addressing_mode(&op, value); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1680:37 [INFO] [stdout] | [INFO] [stdout] 1680 | self.store_with_addressing_mode(&op, value); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1684:37 [INFO] [stdout] | [INFO] [stdout] 1684 | self.store_with_addressing_mode(&op, value); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1734:6 [INFO] [stdout] | [INFO] [stdout] 1734 | if address >= 0x2000 && address < 0x4000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..0x4000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1738:6 [INFO] [stdout] | [INFO] [stdout] 1738 | if address >= 0x4000 && address < 0x4014 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..0x4014).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1758:6 [INFO] [stdout] | [INFO] [stdout] 1758 | if address >= 0x4017 && address < 0x4020 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4017..0x4020).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1762:6 [INFO] [stdout] | [INFO] [stdout] 1762 | if address >= 0x4020 && address < 0x6000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4020..0x6000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1766:6 [INFO] [stdout] | [INFO] [stdout] 1766 | if address >= 0x6000 && address < 0x8000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x6000..0x8000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1806:6 [INFO] [stdout] | [INFO] [stdout] 1806 | if address >= 0x2000 && address < 0x4000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..0x4000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1810:6 [INFO] [stdout] | [INFO] [stdout] 1810 | if address >= 0x4000 && address < 0x4014 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..0x4014).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1841:6 [INFO] [stdout] | [INFO] [stdout] 1841 | if address >= 0x4017 && address < 0x4020 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4017..0x4020).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1847:6 [INFO] [stdout] | [INFO] [stdout] 1847 | if address >= 0x4020 && address < 0x6000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4020..0x6000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/cpu.rs:1853:6 [INFO] [stdout] | [INFO] [stdout] 1853 | if address >= 0x6000 && address < 0x8000 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x6000..0x8000).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cpu.rs:1869:5 [INFO] [stdout] | [INFO] [stdout] 1869 | / if self.p.is_i() { [INFO] [stdout] 1870 | | return; [INFO] [stdout] 1871 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1868 ~ Interrupts::IRQ [INFO] [stdout] 1869 ~ if self.p.is_i() => { [INFO] [stdout] 1870 | return; [INFO] [stdout] 1871 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/cpu.rs:1867:3 [INFO] [stdout] | [INFO] [stdout] 1867 | / match interrupt_type { [INFO] [stdout] 1868 | | Interrupts::IRQ => { [INFO] [stdout] 1869 | | if self.p.is_i() { [INFO] [stdout] 1870 | | return; [INFO] [stdout] ... | [INFO] [stdout] 1873 | | _ => {} [INFO] [stdout] 1874 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1867 ~ if let Interrupts::IRQ = interrupt_type { [INFO] [stdout] 1868 ~ if self.p.is_i() { [INFO] [stdout] 1869 ~ return; [INFO] [stdout] 1870 ~ } [INFO] [stdout] 1871 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cpu.rs:1902:57 [INFO] [stdout] | [INFO] [stdout] 1902 | let address = self.get_address_with_addressing_mode(&op); [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cpu.rs:1976:7 [INFO] [stdout] | [INFO] [stdout] 1976 | / if (address & 0xff00) != (effective_address & 0xff00) { [INFO] [stdout] 1977 | | self.stall_cycles += 1; [INFO] [stdout] 1978 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1974 ~ InstructionTypes::SBC [INFO] [stdout] 1975 | // stall_cycles + 1 if page is crossed [INFO] [stdout] 1976 ~ if (address & 0xff00) != (effective_address & 0xff00) => { [INFO] [stdout] 1977 | self.stall_cycles += 1; [INFO] [stdout] 1978 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/cpu.rs:2004:36 [INFO] [stdout] | [INFO] [stdout] 2004 | self.load_2bytes_from_zeropage(((tmp.wrapping_add(self.x.load())) & 0xFF) as u16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(tmp.wrapping_add(self.x.load()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cpu.rs:2020:7 [INFO] [stdout] | [INFO] [stdout] 2020 | / if (address2 & 0xff00) != (effective_address & 0xff00) { [INFO] [stdout] 2021 | | self.stall_cycles += 1; [INFO] [stdout] 2022 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2018 ~ InstructionTypes::SBC [INFO] [stdout] 2019 | // stall_cycles + 1 if page is crossed [INFO] [stdout] 2020 ~ if (address2 & 0xff00) != (effective_address & 0xff00) => { [INFO] [stdout] 2021 | self.stall_cycles += 1; [INFO] [stdout] 2022 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2095:38 [INFO] [stdout] | [INFO] [stdout] 2095 | "p:".to_owned() + &self.p.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2096:3 [INFO] [stdout] | [INFO] [stdout] 2096 | &"pc:".to_owned() + &self.pc.dump() + &format!("(0x{:02x})", opc) + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"pc:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2096:71 [INFO] [stdout] | [INFO] [stdout] 2096 | &"pc:".to_owned() + &self.pc.dump() + &format!("(0x{:02x})", opc) + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2097:3 [INFO] [stdout] | [INFO] [stdout] 2097 | &"sp:".to_owned() + &self.sp.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `"sp:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2097:41 [INFO] [stdout] | [INFO] [stdout] 2097 | &"sp:".to_owned() + &self.sp.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2098:3 [INFO] [stdout] | [INFO] [stdout] 2098 | &"a:".to_owned() + &self.a.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"a:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2098:39 [INFO] [stdout] | [INFO] [stdout] 2098 | &"a:".to_owned() + &self.a.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2099:3 [INFO] [stdout] | [INFO] [stdout] 2099 | &"x:".to_owned() + &self.x.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"x:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2099:39 [INFO] [stdout] | [INFO] [stdout] 2099 | &"x:".to_owned() + &self.x.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2100:3 [INFO] [stdout] | [INFO] [stdout] 2100 | &"y:".to_owned() + &self.y.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"y:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2100:39 [INFO] [stdout] | [INFO] [stdout] 2100 | &"y:".to_owned() + &self.y.dump() + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2101:43 [INFO] [stdout] | [INFO] [stdout] 2101 | instruction_name(op.instruction_type) + &" ".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2109:5 [INFO] [stdout] | [INFO] [stdout] 2109 | &"immediate".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"immediate"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2113:5 [INFO] [stdout] | [INFO] [stdout] 2113 | &"relative".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"relative"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2119:5 [INFO] [stdout] | [INFO] [stdout] 2119 | &"absolute".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"absolute"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2125:5 [INFO] [stdout] | [INFO] [stdout] 2125 | &"indexed_absolute_x".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_absolute_x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2131:5 [INFO] [stdout] | [INFO] [stdout] 2131 | &"indexed_absolute_y".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_absolute_y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2137:5 [INFO] [stdout] | [INFO] [stdout] 2137 | &"zero_page".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"zero_page"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2143:5 [INFO] [stdout] | [INFO] [stdout] 2143 | &"indexed_zero_page_x".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_zero_page_x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2149:5 [INFO] [stdout] | [INFO] [stdout] 2149 | &"indexed_zero_page_y".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_zero_page_y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2156:5 [INFO] [stdout] | [INFO] [stdout] 2156 | &"indirect".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indirect"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2163:5 [INFO] [stdout] | [INFO] [stdout] 2163 | &"indexed_indirect_x".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_indirect_x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2170:5 [INFO] [stdout] | [INFO] [stdout] 2170 | &"indexed_indirect_y".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"indexed_indirect_y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2174:5 [INFO] [stdout] | [INFO] [stdout] 2174 | &"accumulator".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"accumulator"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CpuStatusRegister` [INFO] [stdout] --> src/cpu.rs:2186:2 [INFO] [stdout] | [INFO] [stdout] 2186 | / pub fn new() -> Self { [INFO] [stdout] 2187 | | CpuStatusRegister { [INFO] [stdout] 2188 | | register: Register::::new() [INFO] [stdout] 2189 | | } [INFO] [stdout] 2190 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 2185 + impl Default for CpuStatusRegister { [INFO] [stdout] 2186 + fn default() -> Self { [INFO] [stdout] 2187 + Self::new() [INFO] [stdout] 2188 + } [INFO] [stdout] 2189 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2301:3 [INFO] [stdout] | [INFO] [stdout] 2301 | &"(".to_owned() + [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `"("` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/cpu.rs:2310:3 [INFO] [stdout] | [INFO] [stdout] 2310 | &")".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:436:3 [INFO] [stdout] | [INFO] [stdout] 436 | address = address & 0x3FFF; // just in case [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `address &= 0x3FFF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:448:3 [INFO] [stdout] | [INFO] [stdout] 448 | address = address & 0x3FFF; // just in case [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `address &= 0x3FFF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ppu.rs:782:3 [INFO] [stdout] | [INFO] [stdout] 782 | / if self.cycle == 20 && self.scanline == 241 { [INFO] [stdout] 783 | | if self.ppustatus.is_vblank() && [INFO] [stdout] 784 | | self.ppuctrl.is_nmi_enabled() { [INFO] [stdout] 785 | | self.nmi_interrupted = true; [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 782 ~ if self.cycle == 20 && self.scanline == 241 [INFO] [stdout] 783 ~ && self.ppustatus.is_vblank() && [INFO] [stdout] 784 | self.ppuctrl.is_nmi_enabled() { [INFO] [stdout] 785 | self.nmi_interrupted = true; [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ppu.rs:808:3 [INFO] [stdout] | [INFO] [stdout] 808 | / if self.scanline == 261 { [INFO] [stdout] 809 | | if self.cycle >= 280 && self.cycle <= 304 { [INFO] [stdout] 810 | | self.current_vram_address &= !0x7BE0; [INFO] [stdout] 811 | | self.current_vram_address |= self.temporal_vram_address & 0x7BE0; [INFO] [stdout] 812 | | } [INFO] [stdout] 813 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 808 ~ if self.scanline == 261 [INFO] [stdout] 809 ~ && self.cycle >= 280 && self.cycle <= 304 { [INFO] [stdout] 810 | self.current_vram_address &= !0x7BE0; [INFO] [stdout] 811 | self.current_vram_address |= self.temporal_vram_address & 0x7BE0; [INFO] [stdout] 812 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ppu.rs:819:6 [INFO] [stdout] | [INFO] [stdout] 819 | if (self.cycle % 8) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:889:22 [INFO] [stdout] | [INFO] [stdout] 889 | self.ppuaddr.store(self.current_vram_address as u8 & 0xFF); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(self.current_vram_address as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:1053:4 [INFO] [stdout] | [INFO] [stdout] 1053 | c = c | 0x00FF0000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `c |= 0x00FF0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:1056:4 [INFO] [stdout] | [INFO] [stdout] 1056 | c = c | 0x0000FF00; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `c |= 0x0000FF00` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:1059:4 [INFO] [stdout] | [INFO] [stdout] 1059 | c = c | 0x000000FF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `c |= 0x000000FF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/ppu.rs:1064:31 [INFO] [stdout] | [INFO] [stdout] 1064 | pub fn get_display(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&dyn Display` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:1305:21 [INFO] [stdout] | [INFO] [stdout] 1305 | byte0: self.load(index * 4 + 0), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `(index * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:1313:14 [INFO] [stdout] | [INFO] [stdout] 1313 | self.store(index * 4 + 0, sprite.byte0); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `(index * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:1321:15 [INFO] [stdout] | [INFO] [stdout] 1321 | self.store(i * 4 + 0, 0xff); [INFO] [stdout] | ^^^^^^^^^ help: consider reducing it to: `(i * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/apu.rs:81:6 [INFO] [stdout] | [INFO] [stdout] 81 | if (self.cycle % self.sample_period) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(self.sample_period)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/apu.rs:89:6 [INFO] [stdout] | [INFO] [stdout] 89 | if (self.cycle % 2) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/apu.rs:104:6 [INFO] [stdout] | [INFO] [stdout] 104 | if (self.cycle % 7457) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle.is_multiple_of(7457)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apu.rs:674:3 [INFO] [stdout] | [INFO] [stdout] 674 | return SEQUENCE_TABLE[self.timer_sequence as usize] & 0xF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 674 - return SEQUENCE_TABLE[self.timer_sequence as usize] & 0xF; [INFO] [stdout] 674 + SEQUENCE_TABLE[self.timer_sequence as usize] & 0xF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/apu.rs:802:27 [INFO] [stdout] | [INFO] [stdout] 802 | self.shift_register = ((feedback as u16) << 14) | (self.shift_register >> 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `feedback` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/apu.rs:1045:4 [INFO] [stdout] | [INFO] [stdout] 1045 | self.shift_register = self.shift_register >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.shift_register >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/rom.rs:40:28 [INFO] [stdout] | [INFO] [stdout] 40 | let mut address_in_rom = 0 as u32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `vec` [INFO] [stdout] --> src/rom.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | for i in 0..HEADER_SIZE { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 93 - for i in 0..HEADER_SIZE { [INFO] [stdout] 93 + for in vec.iter().take(HEADER_SIZE) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/rom.rs:112:15 [INFO] [stdout] | [INFO] [stdout] 112 | for i in 0..3 as u32 { [INFO] [stdout] | ^^^^^^^^ help: try: `3_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> src/rom.rs:147:19 [INFO] [stdout] | [INFO] [stdout] 147 | let mut value = 0 as u64; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/rom.rs:148:15 [INFO] [stdout] | [INFO] [stdout] 148 | for i in 0..7 as u32 { [INFO] [stdout] | ^^^^^^^^ help: try: `7_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rom.rs:169:3 [INFO] [stdout] | [INFO] [stdout] 169 | / match self.mirroring_type() { [INFO] [stdout] 170 | | Mirrorings::Horizontal => true, [INFO] [stdout] 171 | | _ => false [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 169 - match self.mirroring_type() { [INFO] [stdout] 170 - Mirrorings::Horizontal => true, [INFO] [stdout] 171 - _ => false [INFO] [stdout] 172 - } [INFO] [stdout] 169 + matches!(self.mirroring_type(), Mirrorings::Horizontal) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/rom.rs:218:3 [INFO] [stdout] | [INFO] [stdout] 218 | assert_eq!(false, r.valid()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 218 - assert_eq!(false, r.valid()); [INFO] [stdout] 218 + assert!(!r.valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/rom.rs:225:3 [INFO] [stdout] | [INFO] [stdout] 225 | assert_eq!(true, r2.valid()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 225 - assert_eq!(true, r2.valid()); [INFO] [stdout] 225 + assert!(r2.valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mapper.rs:54:4 [INFO] [stdout] | [INFO] [stdout] 54 | * else: [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 54 | * else: [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mapper.rs:55:4 [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 55 | * 0x8000 - 0xFFFF: 0x0000 - 0x7FFF [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/mapper.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | offset = offset | (address & 0x4000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset |= (address & 0x4000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/mapper.rs:154:4 [INFO] [stdout] | [INFO] [stdout] 154 | offset = offset | (address & 0x1000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset |= (address & 0x1000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> src/mapper.rs:475:3 [INFO] [stdout] | [INFO] [stdout] 475 | NRomMapper{program_bank_num: 1}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] = note: `#[warn(clippy::no_effect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Joypad` [INFO] [stdout] --> src/joypad.rs:38:2 [INFO] [stdout] | [INFO] [stdout] 38 | / pub fn new() -> Self { [INFO] [stdout] 39 | | Joypad { [INFO] [stdout] 40 | | register: Register::::new(), [INFO] [stdout] 41 | | latch: 0, [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 37 + impl Default for Joypad { [INFO] [stdout] 38 + fn default() -> Self { [INFO] [stdout] 39 + Self::new() [INFO] [stdout] 40 + } [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/joypad.rs:72:3 [INFO] [stdout] | [INFO] [stdout] 72 | value = value & 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value &= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultInput` [INFO] [stdout] --> src/default_input.rs:11:2 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | DefaultInput { [INFO] [stdout] 13 | | events: VecDeque::<(button::Button, button::Event)>::new() [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for DefaultInput { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/default_input.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | match self.events.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.events.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultAudio` [INFO] [stdout] --> src/default_audio.rs:10:2 [INFO] [stdout] | [INFO] [stdout] 10 | / pub fn new() -> Self { [INFO] [stdout] 11 | | DefaultAudio { [INFO] [stdout] 12 | | buffer_index: 0, [INFO] [stdout] 13 | | buffer: [0.0; BUFFER_CAPACITY], [INFO] [stdout] ... | [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl Default for DefaultAudio { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `sample_buffer` [INFO] [stdout] --> src/default_audio.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..client_sample_buffer_length { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..client_sample_buffer_length { [INFO] [stdout] 34 + for (i, ) in sample_buffer.iter_mut().enumerate().take(client_sample_buffer_length) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultDisplay` [INFO] [stdout] --> src/default_display.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | DefaultDisplay { [INFO] [stdout] 16 | | pixels: vec![0; PIXELS_CAPACITY] [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for DefaultDisplay { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/default_display.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 30 | self.pixels[(base_index + 0) as usize] = b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `base_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/default_display.rs:40:46 [INFO] [stdout] | [INFO] [stdout] 40 | pixels[base_index * 4 + 0] = self.pixels[base_index * 3 + 0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(base_index * 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/default_display.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | pixels[base_index * 4 + 0] = self.pixels[base_index * 3 + 0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(base_index * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `Command { std: "docker" "inspect" "42ce7f8e5ec5f65fb9e224662906c110b04fe93db53656c86048983a35432476", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42ce7f8e5ec5f65fb9e224662906c110b04fe93db53656c86048983a35432476", kill_on_drop: false }` [INFO] [stdout] 42ce7f8e5ec5f65fb9e224662906c110b04fe93db53656c86048983a35432476