[INFO] fetching crate neleus-db 0.1.1... [INFO] linting neleus-db-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate neleus-db 0.1.1 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate neleus-db 0.1.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate neleus-db 0.1.1 [INFO] tweaked toml for crates.io crate neleus-db 0.1.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate neleus-db 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate neleus-db 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_ipld_dagcbor v0.6.4 [INFO] [stderr] Downloaded ipld-core v0.4.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0da147d568422f3e82a2fd653811cb9659552f033622ff45a714617e93303afc [INFO] running `Command { std: "docker" "start" "-a" "0da147d568422f3e82a2fd653811cb9659552f033622ff45a714617e93303afc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0da147d568422f3e82a2fd653811cb9659552f033622ff45a714617e93303afc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0da147d568422f3e82a2fd653811cb9659552f033622ff45a714617e93303afc", kill_on_drop: false }` [INFO] [stdout] 0da147d568422f3e82a2fd653811cb9659552f033622ff45a714617e93303afc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7d7db855ae92518a581cddaadbfb7dffd3762f6fc56fdb779f00a1ee48ed36ce [INFO] running `Command { std: "docker" "start" "-a" "7d7db855ae92518a581cddaadbfb7dffd3762f6fc56fdb779f00a1ee48ed36ce", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking data-encoding v2.10.0 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Checking serde_bytes v0.11.19 [INFO] [stderr] Compiling blake3 v1.8.3 [INFO] [stderr] Compiling syn v2.0.116 [INFO] [stderr] Checking clap_builder v4.5.59 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking getrandom v0.4.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking tempfile v3.25.0 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling match-lookup v0.1.2 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.17 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking data-encoding-macro v0.1.19 [INFO] [stderr] Checking base256emoji v1.0.2 [INFO] [stderr] Checking multibase v0.9.2 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking clap v4.5.59 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking multihash v0.19.3 [INFO] [stderr] Checking cbor4ii v0.2.14 [INFO] [stderr] Checking cid v0.11.1 [INFO] [stderr] Checking ipld-core v0.4.3 [INFO] [stderr] Checking serde_ipld_dagcbor v0.6.4 [INFO] [stderr] Checking neleus-db v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/index/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | chunk_vec.sort_by(|a, b| a.chunk_hash.cmp(&b.chunk_hash)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 97 - chunk_vec.sort_by(|a, b| a.chunk_hash.cmp(&b.chunk_hash)); [INFO] [stdout] 97 + chunk_vec.sort_by_key(|a| a.chunk_hash); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/index/mod.rs:376:6 [INFO] [stdout] | [INFO] [stdout] 376 | ) -> ( [INFO] [stdout] | ______^ [INFO] [stdout] 377 | | u32, [INFO] [stdout] 378 | | f32, [INFO] [stdout] 379 | | BTreeMap, [INFO] [stdout] 380 | | BTreeMap, [INFO] [stdout] 381 | | BTreeMap>, [INFO] [stdout] 382 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/index/mod.rs:421:9 [INFO] [stdout] | [INFO] [stdout] 421 | plist.sort_by(|a, b| a.chunk_hash.cmp(&b.chunk_hash)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 421 - plist.sort_by(|a, b| a.chunk_hash.cmp(&b.chunk_hash)); [INFO] [stdout] 421 + plist.sort_by_key(|a| a.chunk_hash); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/merkle.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | let sibling_idx = if idx % 2 == 0 { idx + 1 } else { idx - 1 }; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `idx.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/merkle.rs:105:22 [INFO] [stdout] | [INFO] [stdout] 105 | current = if idx % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `idx.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:606:16 [INFO] [stdout] | [INFO] [stdout] 606 | if !(left.entry.key.as_slice() < key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.entry.key.as_slice() >= key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:625:16 [INFO] [stdout] | [INFO] [stdout] 625 | if !(key < right.entry.key.as_slice()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(key >= right.entry.key.as_slice())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:637:12 [INFO] [stdout] | [INFO] [stdout] 637 | && !(left.entry.key.as_slice() < right.entry.key.as_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.entry.key.as_slice() >= right.entry.key.as_slice())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/index/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | chunk_vec.sort_by(|a, b| a.chunk_hash.cmp(&b.chunk_hash)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 97 - chunk_vec.sort_by(|a, b| a.chunk_hash.cmp(&b.chunk_hash)); [INFO] [stdout] 97 + chunk_vec.sort_by_key(|a| a.chunk_hash); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/index/mod.rs:376:6 [INFO] [stdout] | [INFO] [stdout] 376 | ) -> ( [INFO] [stdout] | ______^ [INFO] [stdout] 377 | | u32, [INFO] [stdout] 378 | | f32, [INFO] [stdout] 379 | | BTreeMap, [INFO] [stdout] 380 | | BTreeMap, [INFO] [stdout] 381 | | BTreeMap>, [INFO] [stdout] 382 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/index/mod.rs:421:9 [INFO] [stdout] | [INFO] [stdout] 421 | plist.sort_by(|a, b| a.chunk_hash.cmp(&b.chunk_hash)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 421 - plist.sort_by(|a, b| a.chunk_hash.cmp(&b.chunk_hash)); [INFO] [stdout] 421 + plist.sort_by_key(|a| a.chunk_hash); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/merkle.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | let sibling_idx = if idx % 2 == 0 { idx + 1 } else { idx - 1 }; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `idx.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/merkle.rs:105:22 [INFO] [stdout] | [INFO] [stdout] 105 | current = if idx % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `idx.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:606:16 [INFO] [stdout] | [INFO] [stdout] 606 | if !(left.entry.key.as_slice() < key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.entry.key.as_slice() >= key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:625:16 [INFO] [stdout] | [INFO] [stdout] 625 | if !(key < right.entry.key.as_slice()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(key >= right.entry.key.as_slice())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:637:12 [INFO] [stdout] | [INFO] [stdout] 637 | && !(left.entry.key.as_slice() < right.entry.key.as_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.entry.key.as_slice() >= right.entry.key.as_slice())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.32s [INFO] running `Command { std: "docker" "inspect" "7d7db855ae92518a581cddaadbfb7dffd3762f6fc56fdb779f00a1ee48ed36ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d7db855ae92518a581cddaadbfb7dffd3762f6fc56fdb779f00a1ee48ed36ce", kill_on_drop: false }` [INFO] [stdout] 7d7db855ae92518a581cddaadbfb7dffd3762f6fc56fdb779f00a1ee48ed36ce