[INFO] fetching crate nbib 0.1.1...
[INFO] linting nbib-0.1.1 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate nbib 0.1.1 into /workspace/builds/worker-0-tc1/source
[INFO] started tweaking crates.io crate nbib 0.1.1
[INFO] finished tweaking crates.io crate nbib 0.1.1
[INFO] tweaked toml for crates.io crate nbib 0.1.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate nbib 0.1.1 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 11 packages to latest compatible versions
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 68b904742e744e3fb5679c8f271614de79838d347225db5f0e79386da54e5699
[INFO] running `Command { std: "docker" "start" "-a" "68b904742e744e3fb5679c8f271614de79838d347225db5f0e79386da54e5699", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "68b904742e744e3fb5679c8f271614de79838d347225db5f0e79386da54e5699", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "68b904742e744e3fb5679c8f271614de79838d347225db5f0e79386da54e5699", kill_on_drop: false }`
[INFO] [stdout] 68b904742e744e3fb5679c8f271614de79838d347225db5f0e79386da54e5699
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 6ba399b6ee0162519f62b93134fa9c0947717574d042fa984ba30d2b8cbafca9
[INFO] running `Command { std: "docker" "start" "-a" "6ba399b6ee0162519f62b93134fa9c0947717574d042fa984ba30d2b8cbafca9", kill_on_drop: false }`
[INFO] [stderr]     Checking nbib v0.1.1 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused imports: `BufReader` and `self`
[INFO] [stdout]  --> src/lib.rs:2:15
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::io::{self, prelude::*, BufReader};
[INFO] [stdout]   |               ^^^^              ^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/transforms.rs:80:21
[INFO] [stdout]    |
[INFO] [stdout] 80 |     MergeMultiline {range: range, buf: vec![]}
[INFO] [stdout]    |                     ^^^^^^^^^^^^ help: replace it with: `range`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/groupby.rs:70:13
[INFO] [stdout]    |
[INFO] [stdout] 70 |             pred: pred,
[INFO] [stdout]    |             ^^^^^^^^^^ help: replace it with: `pred`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused imports: `BufReader` and `self`
[INFO] [stdout]  --> src/lib.rs:2:15
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::io::{self, prelude::*, BufReader};
[INFO] [stdout]   |               ^^^^              ^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/transforms.rs:80:21
[INFO] [stdout]    |
[INFO] [stdout] 80 |     MergeMultiline {range: range, buf: vec![]}
[INFO] [stdout]    |                     ^^^^^^^^^^^^ help: replace it with: `range`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/groupby.rs:70:13
[INFO] [stdout]    |
[INFO] [stdout] 70 |             pred: pred,
[INFO] [stdout]    |             ^^^^^^^^^^ help: replace it with: `pred`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `SerializeSeq`
[INFO] [stdout]  --> src/types.rs:2:30
[INFO] [stdout]   |
[INFO] [stdout] 2 | use serde::ser::{Serializer, SerializeSeq, SerializeMap};
[INFO] [stdout]   |                              ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `prelude`
[INFO] [stdout]  --> src/lib.rs:2:21
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::io::{self, prelude::*, BufReader};
[INFO] [stdout]   |                     ^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/transforms.rs:58:13
[INFO] [stdout]    |
[INFO] [stdout] 58 |             return None
[INFO] [stdout]    |             ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 58 -             return None
[INFO] [stdout] 58 +             None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/transforms.rs:60:13
[INFO] [stdout]    |
[INFO] [stdout] 60 |             return Some(self.buf.pop().unwrap())
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 60 -             return Some(self.buf.pop().unwrap())
[INFO] [stdout] 60 +             Some(self.buf.pop().unwrap())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/transforms.rs:64:13
[INFO] [stdout]    |
[INFO] [stdout] 64 |             return Some(ret)
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 64 -             return Some(ret)
[INFO] [stdout] 64 +             Some(ret)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this loop could be written as a `for` loop
[INFO] [stdout]   --> src/transforms.rs:24:9
[INFO] [stdout]    |
[INFO] [stdout] 24 |         while let Some(row) = self.range.next() {
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for row in self.range.by_ref()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stdout]    = note: `#[warn(clippy::while_let_on_iterator)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this lifetime isn't used in the function definition
[INFO] [stdout]   --> src/transforms.rs:84:23
[INFO] [stdout]    |
[INFO] [stdout] 84 | pub fn medline_to_csl<'a, I>(range: I) -> impl Iterator<Item = Result<CSLValue, String>> 
[INFO] [stdout]    |                       ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stdout]    = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/transforms.rs:111:17
[INFO] [stdout]     |
[INFO] [stdout] 111 | /                 match x {
[INFO] [stdout] 112 | |                     CSLValue::None => false,
[INFO] [stdout] 113 | |                     _ => true
[INFO] [stdout] 114 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]     = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 111 -                 match x {
[INFO] [stdout] 112 -                     CSLValue::None => false,
[INFO] [stdout] 113 -                     _ => true
[INFO] [stdout] 114 -                 }
[INFO] [stdout] 111 +                 !matches!(x, CSLValue::None)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/transforms.rs:146:25
[INFO] [stdout]     |
[INFO] [stdout] 146 |                         a.np().unwrap().family.as_ref().unwrap().split(" ").nth(0) ==
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `a.np().unwrap().family.as_ref().unwrap().split(" ").next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]     = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/transforms.rs:147:25
[INFO] [stdout]     |
[INFO] [stdout] 147 |                         b.np().unwrap().family.as_ref().unwrap().split(" ").nth(0)
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `b.np().unwrap().family.as_ref().unwrap().split(" ").next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/transforms.rs:151:55
[INFO] [stdout]     |
[INFO] [stdout] 151 |     let reduced = grouped_by_family.map(|x| x.map(|y| y.into_iter().nth(0).unwrap()));
[INFO] [stdout]     |                                                       ^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `y.into_iter().next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/transforms.rs:192:5
[INFO] [stdout]     |
[INFO] [stdout] 192 |     return serde_json::to_value(items).map_err(|e| e.to_string());
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 192 -     return serde_json::to_value(items).map_err(|e| e.to_string());
[INFO] [stdout] 192 +     serde_json::to_value(items).map_err(|e| e.to_string())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `CSLItem`
[INFO] [stdout]   --> src/types.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 | /     pub fn new() -> Self {
[INFO] [stdout] 27 | |         Self {
[INFO] [stdout] 28 | |             fields: Vec::new(),
[INFO] [stdout] 29 | |             names: Vec::new(),
[INFO] [stdout] ...  |
[INFO] [stdout] 32 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 25 + impl Default for CSLItem {
[INFO] [stdout] 26 +     fn default() -> Self {
[INFO] [stdout] 27 +         Self::new()
[INFO] [stdout] 28 +     }
[INFO] [stdout] 29 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `SerializeSeq`
[INFO] [stdout]  --> src/types.rs:2:30
[INFO] [stdout]   |
[INFO] [stdout] 2 | use serde::ser::{Serializer, SerializeSeq, SerializeMap};
[INFO] [stdout]   |                              ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/groupby.rs:36:12
[INFO] [stdout]    |
[INFO] [stdout] 36 |         if self.buf.len() == 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buf.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this loop could be written as a `for` loop
[INFO] [stdout]   --> src/groupby.rs:40:9
[INFO] [stdout]    |
[INFO] [stdout] 40 |         while let Some(b) = self.range.next() {
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for b in self.range.by_ref()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this lifetime isn't used in the function definition
[INFO] [stdout]   --> src/groupby.rs:55:17
[INFO] [stdout]    |
[INFO] [stdout] 55 |     fn group_by<'a, P>(self, pred: P) -> GroupBy<Self, P>
[INFO] [stdout]    |                 ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/groupby.rs:65:12
[INFO] [stdout]    |
[INFO] [stdout] 65 |         if !front.is_none() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^ help: try: `front.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `front` after checking its variant with `is_none`
[INFO] [stdout]   --> src/groupby.rs:66:22
[INFO] [stdout]    |
[INFO] [stdout] 65 |         if !front.is_none() {
[INFO] [stdout]    |             --------------- the check is happening here
[INFO] [stdout] 66 |             arr.push(front.unwrap());
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/lib.rs:15:23
[INFO] [stdout]    |
[INFO] [stdout] 15 |         .split(|line| *line == "") // an iterator over groups of lines
[INFO] [stdout]    |                       ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]    = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/lib.rs:34:23
[INFO] [stdout]    |
[INFO] [stdout] 34 |         .split(|line| *line == "") // an iterator over groups of lines
[INFO] [stdout]    |                       ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `matchingNames` should have a snake case name
[INFO] [stdout]   --> src/types.rs:66:17
[INFO] [stdout]    |
[INFO] [stdout] 66 |             let matchingNames = self.names.iter()
[INFO] [stdout]    |                 ^^^^^^^^^^^^^ help: convert the identifier to snake case: `matching_names`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/lib.rs:56:13
[INFO] [stdout]    |
[INFO] [stdout] 56 |         let mut input = String::from(r#"PMID- 12345
[INFO] [stdout]    |             ----^^^^^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/transforms.rs:58:13
[INFO] [stdout]    |
[INFO] [stdout] 58 |             return None
[INFO] [stdout]    |             ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 58 -             return None
[INFO] [stdout] 58 +             None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/transforms.rs:60:13
[INFO] [stdout]    |
[INFO] [stdout] 60 |             return Some(self.buf.pop().unwrap())
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 60 -             return Some(self.buf.pop().unwrap())
[INFO] [stdout] 60 +             Some(self.buf.pop().unwrap())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/transforms.rs:64:13
[INFO] [stdout]    |
[INFO] [stdout] 64 |             return Some(ret)
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 64 -             return Some(ret)
[INFO] [stdout] 64 +             Some(ret)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this loop could be written as a `for` loop
[INFO] [stdout]   --> src/transforms.rs:24:9
[INFO] [stdout]    |
[INFO] [stdout] 24 |         while let Some(row) = self.range.next() {
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for row in self.range.by_ref()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stdout]    = note: `#[warn(clippy::while_let_on_iterator)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this lifetime isn't used in the function definition
[INFO] [stdout]   --> src/transforms.rs:84:23
[INFO] [stdout]    |
[INFO] [stdout] 84 | pub fn medline_to_csl<'a, I>(range: I) -> impl Iterator<Item = Result<CSLValue, String>> 
[INFO] [stdout]    |                       ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stdout]    = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/transforms.rs:111:17
[INFO] [stdout]     |
[INFO] [stdout] 111 | /                 match x {
[INFO] [stdout] 112 | |                     CSLValue::None => false,
[INFO] [stdout] 113 | |                     _ => true
[INFO] [stdout] 114 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]     = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 111 -                 match x {
[INFO] [stdout] 112 -                     CSLValue::None => false,
[INFO] [stdout] 113 -                     _ => true
[INFO] [stdout] 114 -                 }
[INFO] [stdout] 111 +                 !matches!(x, CSLValue::None)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/transforms.rs:146:25
[INFO] [stdout]     |
[INFO] [stdout] 146 |                         a.np().unwrap().family.as_ref().unwrap().split(" ").nth(0) ==
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `a.np().unwrap().family.as_ref().unwrap().split(" ").next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]     = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/transforms.rs:147:25
[INFO] [stdout]     |
[INFO] [stdout] 147 |                         b.np().unwrap().family.as_ref().unwrap().split(" ").nth(0)
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `b.np().unwrap().family.as_ref().unwrap().split(" ").next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/transforms.rs:151:55
[INFO] [stdout]     |
[INFO] [stdout] 151 |     let reduced = grouped_by_family.map(|x| x.map(|y| y.into_iter().nth(0).unwrap()));
[INFO] [stdout]     |                                                       ^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `y.into_iter().next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/transforms.rs:192:5
[INFO] [stdout]     |
[INFO] [stdout] 192 |     return serde_json::to_value(items).map_err(|e| e.to_string());
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 192 -     return serde_json::to_value(items).map_err(|e| e.to_string());
[INFO] [stdout] 192 +     serde_json::to_value(items).map_err(|e| e.to_string())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `CSLItem`
[INFO] [stdout]   --> src/types.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 | /     pub fn new() -> Self {
[INFO] [stdout] 27 | |         Self {
[INFO] [stdout] 28 | |             fields: Vec::new(),
[INFO] [stdout] 29 | |             names: Vec::new(),
[INFO] [stdout] ...  |
[INFO] [stdout] 32 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 25 + impl Default for CSLItem {
[INFO] [stdout] 26 +     fn default() -> Self {
[INFO] [stdout] 27 +         Self::new()
[INFO] [stdout] 28 +     }
[INFO] [stdout] 29 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/groupby.rs:36:12
[INFO] [stdout]    |
[INFO] [stdout] 36 |         if self.buf.len() == 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buf.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this loop could be written as a `for` loop
[INFO] [stdout]   --> src/groupby.rs:40:9
[INFO] [stdout]    |
[INFO] [stdout] 40 |         while let Some(b) = self.range.next() {
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for b in self.range.by_ref()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this lifetime isn't used in the function definition
[INFO] [stdout]   --> src/groupby.rs:55:17
[INFO] [stdout]    |
[INFO] [stdout] 55 |     fn group_by<'a, P>(self, pred: P) -> GroupBy<Self, P>
[INFO] [stdout]    |                 ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/groupby.rs:65:12
[INFO] [stdout]    |
[INFO] [stdout] 65 |         if !front.is_none() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^ help: try: `front.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `front` after checking its variant with `is_none`
[INFO] [stdout]   --> src/groupby.rs:66:22
[INFO] [stdout]    |
[INFO] [stdout] 65 |         if !front.is_none() {
[INFO] [stdout]    |             --------------- the check is happening here
[INFO] [stdout] 66 |             arr.push(front.unwrap());
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/groupby.rs:112:69
[INFO] [stdout]     |
[INFO] [stdout] 112 |         let val = range.into_iter().group_by(|a, b| a == b).map(|x| x.into_iter().nth(0).unwrap()).collect::<Vec<String>>();
[INFO] [stdout]     |                                                                     ^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `x.into_iter().next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/lib.rs:15:23
[INFO] [stdout]    |
[INFO] [stdout] 15 |         .split(|line| *line == "") // an iterator over groups of lines
[INFO] [stdout]    |                       ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]    = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/lib.rs:34:23
[INFO] [stdout]    |
[INFO] [stdout] 34 |         .split(|line| *line == "") // an iterator over groups of lines
[INFO] [stdout]    |                       ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `matchingNames` should have a snake case name
[INFO] [stdout]   --> src/types.rs:66:17
[INFO] [stdout]    |
[INFO] [stdout] 66 |             let matchingNames = self.names.iter()
[INFO] [stdout]    |                 ^^^^^^^^^^^^^ help: convert the identifier to snake case: `matching_names`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.86s
[INFO] running `Command { std: "docker" "inspect" "6ba399b6ee0162519f62b93134fa9c0947717574d042fa984ba30d2b8cbafca9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6ba399b6ee0162519f62b93134fa9c0947717574d042fa984ba30d2b8cbafca9", kill_on_drop: false }`
[INFO] [stdout] 6ba399b6ee0162519f62b93134fa9c0947717574d042fa984ba30d2b8cbafca9