[INFO] fetching crate n3agent 0.1.10... [INFO] linting n3agent-0.1.10 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate n3agent 0.1.10 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate n3agent 0.1.10 [INFO] finished tweaking crates.io crate n3agent 0.1.10 [INFO] tweaked toml for crates.io crate n3agent 0.1.10 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate n3agent 0.1.10 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate n3agent 0.1.10 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded debug_panic v0.2.1 [INFO] [stderr] Downloaded intrusive-collections v0.9.7 [INFO] [stderr] Downloaded n3io v0.1.5 [INFO] [stderr] Downloaded cooked-waker v5.0.0 [INFO] [stderr] Downloaded fslock v0.2.1 [INFO] [stderr] Downloaded n3quic v0.1.6 [INFO] [stderr] Downloaded n3-spawner v0.1.2 [INFO] [stderr] Downloaded timing-wheel v0.1.4 [INFO] [stderr] Downloaded octets v0.3.0 [INFO] [stderr] Downloaded boring v4.17.0 [INFO] [stderr] Downloaded quiche v0.24.4 [INFO] [stderr] Downloaded boring-sys v4.17.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e8e345e59a1734818133c5507d3f63bcbf90f503b730357ca926e6a728fc3e9 [INFO] running `Command { std: "docker" "start" "-a" "5e8e345e59a1734818133c5507d3f63bcbf90f503b730357ca926e6a728fc3e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e8e345e59a1734818133c5507d3f63bcbf90f503b730357ca926e6a728fc3e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e8e345e59a1734818133c5507d3f63bcbf90f503b730357ca926e6a728fc3e9", kill_on_drop: false }` [INFO] [stdout] 5e8e345e59a1734818133c5507d3f63bcbf90f503b730357ca926e6a728fc3e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9514eea945bfaf09c9865a6acb30bdec9f2805f20f2dd4a6b9e9a218d3a030fc [INFO] running `Command { std: "docker" "start" "-a" "9514eea945bfaf09c9865a6acb30bdec9f2805f20f2dd4a6b9e9a218d3a030fc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling bindgen v0.71.1 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling libloading v0.8.8 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling rustc-hash v2.1.1 [INFO] [stderr] Compiling bitflags v2.9.1 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling foreign-types-macros v0.2.3 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking debug_panic v0.2.1 [INFO] [stderr] Checking humantime v2.2.0 [INFO] [stderr] Checking intrusive-collections v0.9.7 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking octets v0.3.0 [INFO] [stderr] Checking timing-wheel v0.1.4 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Compiling quiche v0.24.4 [INFO] [stderr] Checking cooked-waker v5.0.0 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking foreign-types v0.5.0 [INFO] [stderr] Compiling fslock v0.2.1 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Checking clap v4.5.41 [INFO] [stderr] Compiling color-print-proc-macro v0.3.7 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Checking color-print v0.3.7 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking n3-spawner v0.1.2 [INFO] [stderr] Checking n3io v0.1.5 [INFO] [stderr] Compiling boring-sys v4.17.0 [INFO] [stderr] Checking boring v4.17.0 [INFO] [stderr] Checking n3quic v0.1.6 [INFO] [stderr] Checking n3agent v0.1.10 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/n3agent.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 35 | if !(to > from) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(to <= from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/n3agent.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | return Ok(port..port + 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return Ok(port..port + 1); [INFO] [stdout] 24 + Ok(port..port + 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/n3agent.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(from..to); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Ok(from..to); [INFO] [stdout] 39 + Ok(from..to) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/n3agent.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | return Err("Invalid port range, valid syntax: `xxx:xxx` or `xxx`".to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Err("Invalid port range, valid syntax: `xxx:xxx` or `xxx`".to_owned()); [INFO] [stdout] 42 + Err("Invalid port range, valid syntax: `xxx:xxx` or `xxx`".to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/bin/n3agent.rs:22:71 [INFO] [stdout] | [INFO] [stdout] 22 | .map_err(|err| format!("failed to parse port: {}", err.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/bin/n3agent.rs:29:77 [INFO] [stdout] | [INFO] [stdout] 29 | .map_err(|err| format!("failed to parse port(from): {}", err.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/bin/n3agent.rs:33:75 [INFO] [stdout] | [INFO] [stdout] 33 | .map_err(|err| format!("failed to parse port(to): {}", err.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/bin/n3agent.rs:36:28 [INFO] [stdout] | [INFO] [stdout] 36 | return Err(format!("failed to parse port range: ensure `to > from`")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to parse port range: ensure `to > from`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/n3agent.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 35 | if !(to > from) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(to <= from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/n3agent.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | return Ok(port..port + 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return Ok(port..port + 1); [INFO] [stdout] 24 + Ok(port..port + 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/n3agent.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(from..to); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Ok(from..to); [INFO] [stdout] 39 + Ok(from..to) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/n3agent.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | return Err("Invalid port range, valid syntax: `xxx:xxx` or `xxx`".to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Err("Invalid port range, valid syntax: `xxx:xxx` or `xxx`".to_owned()); [INFO] [stdout] 42 + Err("Invalid port range, valid syntax: `xxx:xxx` or `xxx`".to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/bin/n3agent.rs:22:71 [INFO] [stdout] | [INFO] [stdout] 22 | .map_err(|err| format!("failed to parse port: {}", err.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/bin/n3agent.rs:29:77 [INFO] [stdout] | [INFO] [stdout] 29 | .map_err(|err| format!("failed to parse port(from): {}", err.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/bin/n3agent.rs:33:75 [INFO] [stdout] | [INFO] [stdout] 33 | .map_err(|err| format!("failed to parse port(to): {}", err.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/bin/n3agent.rs:36:28 [INFO] [stdout] | [INFO] [stdout] 36 | return Err(format!("failed to parse port range: ensure `to > from`")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to parse port range: ensure `to > from`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 11s [INFO] running `Command { std: "docker" "inspect" "9514eea945bfaf09c9865a6acb30bdec9f2805f20f2dd4a6b9e9a218d3a030fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9514eea945bfaf09c9865a6acb30bdec9f2805f20f2dd4a6b9e9a218d3a030fc", kill_on_drop: false }` [INFO] [stdout] 9514eea945bfaf09c9865a6acb30bdec9f2805f20f2dd4a6b9e9a218d3a030fc