[INFO] fetching crate multivariate-optimization 0.0.2... [INFO] linting multivariate-optimization-0.0.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate multivariate-optimization 0.0.2 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate multivariate-optimization 0.0.2 [INFO] finished tweaking crates.io crate multivariate-optimization 0.0.2 [INFO] tweaked toml for crates.io crate multivariate-optimization 0.0.2 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate multivariate-optimization 0.0.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 85 packages to latest compatible versions [INFO] [stderr] Adding criterion v0.5.1 (available: v0.8.2) [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1f6c8f812933b57595800db8bc679da121929210ac2118d88e7068c8133a06e6 [INFO] running `Command { std: "docker" "start" "-a" "1f6c8f812933b57595800db8bc679da121929210ac2118d88e7068c8133a06e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1f6c8f812933b57595800db8bc679da121929210ac2118d88e7068c8133a06e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f6c8f812933b57595800db8bc679da121929210ac2118d88e7068c8133a06e6", kill_on_drop: false }` [INFO] [stdout] 1f6c8f812933b57595800db8bc679da121929210ac2118d88e7068c8133a06e6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e896ec246dde506ed28d19e9576d5b8fb87961e48e6a2824192df17849fecb03 [INFO] running `Command { std: "docker" "start" "-a" "e896ec246dde506ed28d19e9576d5b8fb87961e48e6a2824192df17849fecb03", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Checking anstyle v1.0.14 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking clap_lex v1.1.0 [INFO] [stderr] Compiling zerocopy-derive v0.8.42 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking clap_builder v4.6.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking clap v4.6.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking multivariate-optimization v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/optimize.rs:342:25 [INFO] [stdout] | [INFO] [stdout] 342 | async { () } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/optimize.rs:224:18 [INFO] [stdout] | [INFO] [stdout] 224 | .map(|search_range| SearchDist::from(search_range)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `SearchDist::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/optimize.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 279 | speed_factor >= 0.0 && speed_factor <= 1.0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&speed_factor)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/optimize.rs:433:23 [INFO] [stdout] | [INFO] [stdout] 433 | .map_init(|| rand::thread_rng(), |rng, _| self.random_specimen(rng)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rand::thread_rng` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/optimize.rs:498:17 [INFO] [stdout] | [INFO] [stdout] 498 | || rand::thread_rng(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rand::thread_rng` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/splitter.rs:32:45 [INFO] [stdout] | [INFO] [stdout] 32 | let mut assignments: Box<[usize]> = (0..source_len) [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 33 | | .into_iter() [INFO] [stdout] | |________________________^ help: consider removing `.into_iter()`: `(0..source_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/testfuncs.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | dim - sum / 418.982887272433800 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 50 - dim - sum / 418.982887272433800 [INFO] [stdout] 50 + dim - sum / 418.982_887_272_433_8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/triangular.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | if !(row < self.dim) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(row >= self.dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/triangular.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 75 | if !(col <= row) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(col > row)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/optimize.rs:342:25 [INFO] [stdout] | [INFO] [stdout] 342 | async { () } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `cov_goal` [INFO] [stdout] --> src/distributions.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 249 | let cov_goal = cov_goal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `cov_goal` is initially defined here [INFO] [stdout] --> src/distributions.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | let cov_goal = Triangular::::new(3, |idx| match idx { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `avg` [INFO] [stdout] --> src/distributions.rs:258:18 [INFO] [stdout] | [INFO] [stdout] 258 | for i in 0..3 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 258 - for i in 0..3 { [INFO] [stdout] 258 + for in avg.iter_mut().take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/optimize.rs:224:18 [INFO] [stdout] | [INFO] [stdout] 224 | .map(|search_range| SearchDist::from(search_range)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `SearchDist::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/optimize.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 279 | speed_factor >= 0.0 && speed_factor <= 1.0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&speed_factor)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/optimize.rs:433:23 [INFO] [stdout] | [INFO] [stdout] 433 | .map_init(|| rand::thread_rng(), |rng, _| self.random_specimen(rng)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rand::thread_rng` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/optimize.rs:498:17 [INFO] [stdout] | [INFO] [stdout] 498 | || rand::thread_rng(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rand::thread_rng` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/splitter.rs:32:45 [INFO] [stdout] | [INFO] [stdout] 32 | let mut assignments: Box<[usize]> = (0..source_len) [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 33 | | .into_iter() [INFO] [stdout] | |________________________^ help: consider removing `.into_iter()`: `(0..source_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/splitter.rs:85:21 [INFO] [stdout] | [INFO] [stdout] 85 | assert!(group_size >= 33 && group_size <= 34); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(33..=34).contains(&group_size)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/testfuncs.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | dim - sum / 418.982887272433800 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 50 - dim - sum / 418.982887272433800 [INFO] [stdout] 50 + dim - sum / 418.982_887_272_433_8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/triangular.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | if !(row < self.dim) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(row >= self.dim)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/triangular.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 75 | if !(col <= row) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(col > row)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> src/triangular.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | m[(3, 0)]; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] = note: `#[warn(clippy::no_effect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> src/triangular.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | m[(1, 2)]; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.91s [INFO] running `Command { std: "docker" "inspect" "e896ec246dde506ed28d19e9576d5b8fb87961e48e6a2824192df17849fecb03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e896ec246dde506ed28d19e9576d5b8fb87961e48e6a2824192df17849fecb03", kill_on_drop: false }` [INFO] [stdout] e896ec246dde506ed28d19e9576d5b8fb87961e48e6a2824192df17849fecb03