[INFO] fetching crate multimoon 0.1.2... [INFO] linting multimoon-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate multimoon 0.1.2 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate multimoon 0.1.2 [INFO] finished tweaking crates.io crate multimoon 0.1.2 [INFO] tweaked toml for crates.io crate multimoon 0.1.2 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate multimoon 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate multimoon 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zstd-safe v7.1.0 [INFO] [stderr] Downloaded serde_derive v1.0.201 [INFO] [stderr] Downloaded zstd v0.13.1 [INFO] [stderr] Downloaded proc-macro2 v1.0.82 [INFO] [stderr] Downloaded serde v1.0.201 [INFO] [stderr] Downloaded redox_syscall v0.5.1 [INFO] [stderr] Downloaded anyhow v1.0.83 [INFO] [stderr] Downloaded rustls-native-certs v0.7.0 [INFO] [stderr] Downloaded zip v2.1.1 [INFO] [stderr] Downloaded h2 v0.4.4 [INFO] [stderr] Downloaded syn v2.0.61 [INFO] [stderr] Downloaded libc v0.2.154 [INFO] [stderr] Downloaded zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Downloaded tokio v1.37.0 [INFO] [stderr] Downloaded libz-sys v1.1.16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8216537cd8a6324684714cb115c62bd75f7e8abc94eeb29cb285ef5f9281b2f6 [INFO] running `Command { std: "docker" "start" "-a" "8216537cd8a6324684714cb115c62bd75f7e8abc94eeb29cb285ef5f9281b2f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8216537cd8a6324684714cb115c62bd75f7e8abc94eeb29cb285ef5f9281b2f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8216537cd8a6324684714cb115c62bd75f7e8abc94eeb29cb285ef5f9281b2f6", kill_on_drop: false }` [INFO] [stdout] 8216537cd8a6324684714cb115c62bd75f7e8abc94eeb29cb285ef5f9281b2f6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e5ffd99a49be07a4d89ac0652da55045ffe346f476d5a260d2b6eeec9d2b8c01 [INFO] running `Command { std: "docker" "start" "-a" "e5ffd99a49be07a4d89ac0652da55045ffe346f476d5a260d2b6eeec9d2b8c01", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Compiling anyhow v1.0.83 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling zip v2.1.1 [INFO] [stderr] Checking lockfree-object-pool v0.1.6 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking zopfli v0.8.1 [INFO] [stderr] Checking rustls-native-certs v0.7.0 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Compiling libz-sys v1.1.16 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling serde_derive v1.0.201 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Compiling displaydoc v0.2.4 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking rustls-webpki v0.102.3 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking h2 v0.4.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-rustls v0.26.0 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking multimoon v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/cmdline.rs:136:28 [INFO] [stdout] | [INFO] [stdout] 136 | const CLAP_HELP_TEMPLATE: &'static str = "{before-help}{about-with-newline} [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/core.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | const CORRUPT: &'static str = "(current installation may be corrupted)"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/installer/inst_initial.rs:152:25 [INFO] [stdout] | [INFO] [stdout] 152 | const CORRUPT: &'static str = "(current installation may be corrupted)"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/installer/inst_initial.rs:267:28 [INFO] [stdout] | [INFO] [stdout] 267 | const ERR_DETECT: &'static str = "cannot detect current shell"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/installer/inst_initial.rs:278:26 [INFO] [stdout] | [INFO] [stdout] 278 | const ERR_READ: &'static str = "cannot read shell config file"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/installer/inst_initial.rs:285:31 [INFO] [stdout] | [INFO] [stdout] 285 | const ERR_WRITE: &'static str = "cannot write shell config file"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/cmdline.rs:136:28 [INFO] [stdout] | [INFO] [stdout] 136 | const CLAP_HELP_TEMPLATE: &'static str = "{before-help}{about-with-newline} [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/core.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | const CORRUPT: &'static str = "(current installation may be corrupted)"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/installer/inst_initial.rs:152:25 [INFO] [stdout] | [INFO] [stdout] 152 | const CORRUPT: &'static str = "(current installation may be corrupted)"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/installer/inst_initial.rs:267:28 [INFO] [stdout] | [INFO] [stdout] 267 | const ERR_DETECT: &'static str = "cannot detect current shell"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/installer/inst_initial.rs:278:26 [INFO] [stdout] | [INFO] [stdout] 278 | const ERR_READ: &'static str = "cannot read shell config file"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/installer/inst_initial.rs:285:31 [INFO] [stdout] | [INFO] [stdout] 285 | const ERR_WRITE: &'static str = "cannot write shell config file"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/core.rs:200:33 [INFO] [stdout] | [INFO] [stdout] 200 | let disp_name = format!("{}", backup_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `backup_name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/core.rs:220:5 [INFO] [stdout] | [INFO] [stdout] 220 | result.sort_by(|a, b| a.1.cmp(&b.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 220 - result.sort_by(|a, b| a.1.cmp(&b.1)); [INFO] [stdout] 220 + result.sort_by_key(|a| a.1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/global.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return GLOBAL.get().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return GLOBAL.get().unwrap() [INFO] [stdout] 17 + GLOBAL.get().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/installer/inst_initial.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return InstInitial(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return InstInitial(); [INFO] [stdout] 14 + InstInitial() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/installer/inst_initial.rs:46:16 [INFO] [stdout] | [INFO] [stdout] 46 | if !(binary.checksum == hash) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(binary.checksum != hash)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/installer/inst_initial.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return Ok(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return Ok(true); [INFO] [stdout] 51 + Ok(true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/installer/inst_initial.rs:182:16 [INFO] [stdout] | [INFO] [stdout] 182 | if !(err.kind() == std::io::ErrorKind::NotFound) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(err.kind() != std::io::ErrorKind::NotFound)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `toolchain.core.get(0)` [INFO] [stdout] --> src/installer/inst_initial.rs:117:24 [INFO] [stdout] | [INFO] [stdout] 117 | let core = toolchain.core.get(0).context("registry error: core not found")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `toolchain.core.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/core.rs:200:33 [INFO] [stdout] | [INFO] [stdout] 200 | let disp_name = format!("{}", backup_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `backup_name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/core.rs:220:5 [INFO] [stdout] | [INFO] [stdout] 220 | result.sort_by(|a, b| a.1.cmp(&b.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 220 - result.sort_by(|a, b| a.1.cmp(&b.1)); [INFO] [stdout] 220 + result.sort_by_key(|a| a.1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/global.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return GLOBAL.get().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return GLOBAL.get().unwrap() [INFO] [stdout] 17 + GLOBAL.get().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/installer/inst_initial.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return InstInitial(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return InstInitial(); [INFO] [stdout] 14 + InstInitial() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/installer/inst_initial.rs:46:16 [INFO] [stdout] | [INFO] [stdout] 46 | if !(binary.checksum == hash) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(binary.checksum != hash)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/installer/inst_initial.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return Ok(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return Ok(true); [INFO] [stdout] 51 + Ok(true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/installer/inst_initial.rs:182:16 [INFO] [stdout] | [INFO] [stdout] 182 | if !(err.kind() == std::io::ErrorKind::NotFound) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(err.kind() != std::io::ErrorKind::NotFound)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/installer/inst_initial.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 205 | r.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `r.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `toolchain.core.get(0)` [INFO] [stdout] --> src/installer/inst_initial.rs:117:24 [INFO] [stdout] | [INFO] [stdout] 117 | let core = toolchain.core.get(0).context("registry error: core not found")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `toolchain.core.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/installer/inst_initial.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 205 | r.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `r.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/subcommand/toolchain.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(registry.toolchains.len() <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/subcommand/toolchain.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return Ok(()); [INFO] [stdout] 28 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/subcommand/toolchain.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!registry.toolchains.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/subcommand/toolchain.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | toolchains.sort_by(|a, b| b.last_modified.cmp(&a.last_modified)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 17 - toolchains.sort_by(|a, b| b.last_modified.cmp(&a.last_modified)); [INFO] [stdout] 17 + toolchains.sort_by_key(|b| std::cmp::Reverse(b.last_modified)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/subcommand/toolchain.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(registry.toolchains.len() <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/subcommand/toolchain.rs:37:10 [INFO] [stdout] | [INFO] [stdout] 37 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!registry.toolchains.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/subcommand/toolchain.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | toolchains.sort_by(|a, b| a.last_modified.cmp(&b.last_modified)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 43 - toolchains.sort_by(|a, b| a.last_modified.cmp(&b.last_modified)); [INFO] [stdout] 43 + toolchains.sort_by_key(|a| a.last_modified); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/subcommand/toolchain.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(registry.toolchains.len() <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/subcommand/toolchain.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Ok(()); [INFO] [stdout] 79 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/subcommand/toolchain.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Ok(()); [INFO] [stdout] 83 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/subcommand/toolchain.rs:65:10 [INFO] [stdout] | [INFO] [stdout] 65 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!registry.toolchains.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/subcommand/toolchain.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | toolchains.sort_by(|a, b| b.last_modified.cmp(&a.last_modified)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 71 - toolchains.sort_by(|a, b| b.last_modified.cmp(&a.last_modified)); [INFO] [stdout] 71 + toolchains.sort_by_key(|b| std::cmp::Reverse(b.last_modified)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/subcommand/toolchain.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 93 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(registry.toolchains.len() <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/subcommand/toolchain.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return Ok(()); [INFO] [stdout] 108 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/subcommand/toolchain.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return Ok(()); [INFO] [stdout] 112 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/subcommand/toolchain.rs:93:10 [INFO] [stdout] | [INFO] [stdout] 93 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!registry.toolchains.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/subcommand/toolchain.rs:98:27 [INFO] [stdout] | [INFO] [stdout] 98 | let toolchain = match registry.toolchains.iter().filter(|&t| &t.name == &args.toolchain).next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `registry.toolchains.iter().find(|&t| &t.name == &args.toolchain)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/subcommand/toolchain.rs:98:66 [INFO] [stdout] | [INFO] [stdout] 98 | let toolchain = match registry.toolchains.iter().filter(|&t| &t.name == &args.toolchain).next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 98 - let toolchain = match registry.toolchains.iter().filter(|&t| &t.name == &args.toolchain).next() { [INFO] [stdout] 98 + let toolchain = match registry.toolchains.iter().filter(|&t| t.name == args.toolchain).next() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/main.rs:76:6 [INFO] [stdout] | [INFO] [stdout] 76 | }.map_err(|e| { [INFO] [stdout] | ______^ [INFO] [stdout] 77 | | // println!("Error backtrace: {:?}", e.backtrace()); [INFO] [stdout] 78 | | e [INFO] [stdout] 79 | | }) [INFO] [stdout] | |______^ help: remove the call to `map_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/subcommand/toolchain.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(registry.toolchains.len() <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/subcommand/toolchain.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return Ok(()); [INFO] [stdout] 28 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/subcommand/toolchain.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!registry.toolchains.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/subcommand/toolchain.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | toolchains.sort_by(|a, b| b.last_modified.cmp(&a.last_modified)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 17 - toolchains.sort_by(|a, b| b.last_modified.cmp(&a.last_modified)); [INFO] [stdout] 17 + toolchains.sort_by_key(|b| std::cmp::Reverse(b.last_modified)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return Ok(()); [INFO] [stdout] 88 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/subcommand/toolchain.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(registry.toolchains.len() <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/subcommand/toolchain.rs:37:10 [INFO] [stdout] | [INFO] [stdout] 37 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!registry.toolchains.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/subcommand/toolchain.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | toolchains.sort_by(|a, b| a.last_modified.cmp(&b.last_modified)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 43 - toolchains.sort_by(|a, b| a.last_modified.cmp(&b.last_modified)); [INFO] [stdout] 43 + toolchains.sort_by_key(|a| a.last_modified); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/subcommand/toolchain.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(registry.toolchains.len() <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/subcommand/toolchain.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Ok(()); [INFO] [stdout] 79 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/subcommand/toolchain.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Ok(()); [INFO] [stdout] 83 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/subcommand/toolchain.rs:65:10 [INFO] [stdout] | [INFO] [stdout] 65 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!registry.toolchains.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/subcommand/toolchain.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | toolchains.sort_by(|a, b| b.last_modified.cmp(&a.last_modified)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 71 - toolchains.sort_by(|a, b| b.last_modified.cmp(&a.last_modified)); [INFO] [stdout] 71 + toolchains.sort_by_key(|b| std::cmp::Reverse(b.last_modified)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/subcommand/toolchain.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 93 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(registry.toolchains.len() <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/subcommand/toolchain.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return Ok(()); [INFO] [stdout] 108 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/subcommand/toolchain.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return Ok(()); [INFO] [stdout] 112 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/subcommand/toolchain.rs:93:10 [INFO] [stdout] | [INFO] [stdout] 93 | if !(registry.toolchains.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!registry.toolchains.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/subcommand/toolchain.rs:98:27 [INFO] [stdout] | [INFO] [stdout] 98 | let toolchain = match registry.toolchains.iter().filter(|&t| &t.name == &args.toolchain).next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `registry.toolchains.iter().find(|&t| &t.name == &args.toolchain)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/subcommand/toolchain.rs:98:66 [INFO] [stdout] | [INFO] [stdout] 98 | let toolchain = match registry.toolchains.iter().filter(|&t| &t.name == &args.toolchain).next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 98 - let toolchain = match registry.toolchains.iter().filter(|&t| &t.name == &args.toolchain).next() { [INFO] [stdout] 98 + let toolchain = match registry.toolchains.iter().filter(|&t| t.name == args.toolchain).next() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/main.rs:76:6 [INFO] [stdout] | [INFO] [stdout] 76 | }.map_err(|e| { [INFO] [stdout] | ______^ [INFO] [stdout] 77 | | // println!("Error backtrace: {:?}", e.backtrace()); [INFO] [stdout] 78 | | e [INFO] [stdout] 79 | | }) [INFO] [stdout] | |______^ help: remove the call to `map_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return Ok(()); [INFO] [stdout] 88 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.73s [INFO] running `Command { std: "docker" "inspect" "e5ffd99a49be07a4d89ac0652da55045ffe346f476d5a260d2b6eeec9d2b8c01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5ffd99a49be07a4d89ac0652da55045ffe346f476d5a260d2b6eeec9d2b8c01", kill_on_drop: false }` [INFO] [stdout] e5ffd99a49be07a4d89ac0652da55045ffe346f476d5a260d2b6eeec9d2b8c01