[INFO] fetching crate msn-kit 0.2.5... [INFO] linting msn-kit-0.2.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate msn-kit 0.2.5 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate msn-kit 0.2.5 [INFO] finished tweaking crates.io crate msn-kit 0.2.5 [INFO] tweaked toml for crates.io crate msn-kit 0.2.5 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate msn-kit 0.2.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (available: v0.22.1) [INFO] [stderr] Adding quick-xml v0.22.0 (available: v0.39.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proc-macro-hack-impl v0.4.3 [INFO] [stderr] Downloaded structure v0.1.2 [INFO] [stderr] Downloaded proc-macro-hack v0.4.3 [INFO] [stderr] Downloaded structure-macro-impl v0.1.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9311b7f36e53df9e0730e7efe02181977f01d5530255b731ecd298ef50c20ac3 [INFO] running `Command { std: "docker" "start" "-a" "9311b7f36e53df9e0730e7efe02181977f01d5530255b731ecd298ef50c20ac3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9311b7f36e53df9e0730e7efe02181977f01d5530255b731ecd298ef50c20ac3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9311b7f36e53df9e0730e7efe02181977f01d5530255b731ecd298ef50c20ac3", kill_on_drop: false }` [INFO] [stdout] 9311b7f36e53df9e0730e7efe02181977f01d5530255b731ecd298ef50c20ac3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 422916fb18f9e7202dfad6e529b3a4a780a8e1b6b55a537c7c0ec4dda852d45c [INFO] running `Command { std: "docker" "start" "-a" "422916fb18f9e7202dfad6e529b3a4a780a8e1b6b55a537c7c0ec4dda852d45c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro-hack-impl v0.4.3 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Compiling proc-macro-hack v0.4.3 [INFO] [stderr] Compiling structure-macro-impl v0.1.2 [INFO] [stderr] Checking structure v0.1.2 [INFO] [stderr] Checking quick-xml v0.22.0 [INFO] [stderr] Checking msn-kit v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::io::Format` [INFO] [stdout] --> src/io/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | use crate::io::Format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> src/io/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `CVVectorMethods` is never used [INFO] [stdout] --> src/io/mzml_parser/types.rs:184:7 [INFO] [stdout] | [INFO] [stdout] 184 | trait CVVectorMethods {} [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:75:28 [INFO] [stdout] | [INFO] [stdout] 75 | return Err(std::io::Error::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 76 | | ErrorKind::Other, [INFO] [stdout] 77 | | format!("Expected 'BEGIN IONS' to start, got {}", line), [INFO] [stdout] 78 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 75 ~ return Err(std::io::Error::other( [INFO] [stdout] 76 ~ format!("Expected 'BEGIN IONS' to start, got {}", line), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:93:32 [INFO] [stdout] | [INFO] [stdout] 93 | return Err(Error::new( [INFO] [stdout] | ________________________________^ [INFO] [stdout] 94 | | ErrorKind::Other, [INFO] [stdout] 95 | | "Could parse key value metadata.", [INFO] [stdout] 96 | | )); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 93 ~ return Err(Error::other( [INFO] [stdout] 94 ~ "Could parse key value metadata.", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:107:32 [INFO] [stdout] | [INFO] [stdout] 107 | return Err(Error::new(ErrorKind::Other, "Vectors")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 107 - return Err(Error::new(ErrorKind::Other, "Vectors")); [INFO] [stdout] 107 + return Err(Error::other("Vectors")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:111:28 [INFO] [stdout] | [INFO] [stdout] 111 | return Err(Error::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 112 | | ErrorKind::Other, [INFO] [stdout] 113 | | format!("Error parsing data: {}", line), [INFO] [stdout] 114 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 111 ~ return Err(Error::other( [INFO] [stdout] 112 ~ format!("Error parsing data: {}", line), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:152:22 [INFO] [stdout] | [INFO] [stdout] 152 | e => Err(Error::new( [INFO] [stdout] | ______________________^ [INFO] [stdout] 153 | | ErrorKind::Other, [INFO] [stdout] 154 | | format!("Cannot parse, got output: {:?}", e), [INFO] [stdout] 155 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 152 ~ e => Err(Error::other( [INFO] [stdout] 153 ~ format!("Cannot parse, got output: {:?}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:171:27 [INFO] [stdout] | [INFO] [stdout] 171 | Err(_) => Err(Error::new( [INFO] [stdout] | ___________________________^ [INFO] [stdout] 172 | | ErrorKind::Other, [INFO] [stdout] 173 | | "Error writing json for spectrum.", [INFO] [stdout] 174 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 171 ~ Err(_) => Err(Error::other( [INFO] [stdout] 172 ~ "Error writing json for spectrum.", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:227:32 [INFO] [stdout] | [INFO] [stdout] 227 | Err(e) => Some(Err(std::io::Error::new(std::io::ErrorKind::Other, e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 227 - Err(e) => Some(Err(std::io::Error::new(std::io::ErrorKind::Other, e))), [INFO] [stdout] 227 + Err(e) => Some(Err(std::io::Error::other(e))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mzml_parser/parser.rs:68:44 [INFO] [stdout] | [INFO] [stdout] 68 | ... return Err(std::io::Error::new( [INFO] [stdout] | __________________________________^ [INFO] [stdout] 69 | | ... std::io::ErrorKind::Other, [INFO] [stdout] 70 | | ... "Unexpected Eof Event", [INFO] [stdout] 71 | | ... )) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 68 ~ return Err(std::io::Error::other( [INFO] [stdout] 69 ~ "Unexpected Eof Event", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mzml_parser/parser.rs:83:32 [INFO] [stdout] | [INFO] [stdout] 83 | return Err(std::io::Error::new( [INFO] [stdout] | ________________________________^ [INFO] [stdout] 84 | | std::io::ErrorKind::Other, [INFO] [stdout] 85 | | "Unexpected Eof Event", [INFO] [stdout] 86 | | )) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 83 ~ return Err(std::io::Error::other( [INFO] [stdout] 84 ~ "Unexpected Eof Event", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/io/mzml_parser/types.rs:132:16 [INFO] [stdout] | [INFO] [stdout] 132 | if !data_type.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `data_type.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data_type` after checking its variant with `is_err` [INFO] [stdout] --> src/io/mzml_parser/types.rs:133:27 [INFO] [stdout] | [INFO] [stdout] 132 | if !data_type.is_err() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 133 | return Ok(data_type.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/io/mzml_parser/types.rs:194:16 [INFO] [stdout] | [INFO] [stdout] 194 | if !compression_type.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `compression_type.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `compression_type` after checking its variant with `is_err` [INFO] [stdout] --> src/io/mzml_parser/types.rs:195:27 [INFO] [stdout] | [INFO] [stdout] 194 | if !compression_type.is_err() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 195 | return Ok(compression_type.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `decoded` after checking its variant with `is_ok` [INFO] [stdout] --> src/io/mzml_parser/types.rs:244:21 [INFO] [stdout] | [INFO] [stdout] 243 | if decoded.is_ok() { [INFO] [stdout] | ------------------ help: try: `if let Ok() = decoded` [INFO] [stdout] 244 | let v = decoded.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `CVVectorMethods` is never used [INFO] [stdout] --> src/io/mzml_parser/types.rs:184:7 [INFO] [stdout] | [INFO] [stdout] 184 | trait CVVectorMethods {} [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:75:28 [INFO] [stdout] | [INFO] [stdout] 75 | return Err(std::io::Error::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 76 | | ErrorKind::Other, [INFO] [stdout] 77 | | format!("Expected 'BEGIN IONS' to start, got {}", line), [INFO] [stdout] 78 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 75 ~ return Err(std::io::Error::other( [INFO] [stdout] 76 ~ format!("Expected 'BEGIN IONS' to start, got {}", line), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:93:32 [INFO] [stdout] | [INFO] [stdout] 93 | return Err(Error::new( [INFO] [stdout] | ________________________________^ [INFO] [stdout] 94 | | ErrorKind::Other, [INFO] [stdout] 95 | | "Could parse key value metadata.", [INFO] [stdout] 96 | | )); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 93 ~ return Err(Error::other( [INFO] [stdout] 94 ~ "Could parse key value metadata.", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:107:32 [INFO] [stdout] | [INFO] [stdout] 107 | return Err(Error::new(ErrorKind::Other, "Vectors")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 107 - return Err(Error::new(ErrorKind::Other, "Vectors")); [INFO] [stdout] 107 + return Err(Error::other("Vectors")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:111:28 [INFO] [stdout] | [INFO] [stdout] 111 | return Err(Error::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 112 | | ErrorKind::Other, [INFO] [stdout] 113 | | format!("Error parsing data: {}", line), [INFO] [stdout] 114 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 111 ~ return Err(Error::other( [INFO] [stdout] 112 ~ format!("Error parsing data: {}", line), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:152:22 [INFO] [stdout] | [INFO] [stdout] 152 | e => Err(Error::new( [INFO] [stdout] | ______________________^ [INFO] [stdout] 153 | | ErrorKind::Other, [INFO] [stdout] 154 | | format!("Cannot parse, got output: {:?}", e), [INFO] [stdout] 155 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 152 ~ e => Err(Error::other( [INFO] [stdout] 153 ~ format!("Cannot parse, got output: {:?}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:171:27 [INFO] [stdout] | [INFO] [stdout] 171 | Err(_) => Err(Error::new( [INFO] [stdout] | ___________________________^ [INFO] [stdout] 172 | | ErrorKind::Other, [INFO] [stdout] 173 | | "Error writing json for spectrum.", [INFO] [stdout] 174 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 171 ~ Err(_) => Err(Error::other( [INFO] [stdout] 172 ~ "Error writing json for spectrum.", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mgf_parser.rs:227:32 [INFO] [stdout] | [INFO] [stdout] 227 | Err(e) => Some(Err(std::io::Error::new(std::io::ErrorKind::Other, e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 227 - Err(e) => Some(Err(std::io::Error::new(std::io::ErrorKind::Other, e))), [INFO] [stdout] 227 + Err(e) => Some(Err(std::io::Error::other(e))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mzml_parser/parser.rs:68:44 [INFO] [stdout] | [INFO] [stdout] 68 | ... return Err(std::io::Error::new( [INFO] [stdout] | __________________________________^ [INFO] [stdout] 69 | | ... std::io::ErrorKind::Other, [INFO] [stdout] 70 | | ... "Unexpected Eof Event", [INFO] [stdout] 71 | | ... )) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 68 ~ return Err(std::io::Error::other( [INFO] [stdout] 69 ~ "Unexpected Eof Event", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/io/mzml_parser/parser.rs:83:32 [INFO] [stdout] | [INFO] [stdout] 83 | return Err(std::io::Error::new( [INFO] [stdout] | ________________________________^ [INFO] [stdout] 84 | | std::io::ErrorKind::Other, [INFO] [stdout] 85 | | "Unexpected Eof Event", [INFO] [stdout] 86 | | )) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 83 ~ return Err(std::io::Error::other( [INFO] [stdout] 84 ~ "Unexpected Eof Event", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/io/mzml_parser/types.rs:132:16 [INFO] [stdout] | [INFO] [stdout] 132 | if !data_type.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `data_type.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data_type` after checking its variant with `is_err` [INFO] [stdout] --> src/io/mzml_parser/types.rs:133:27 [INFO] [stdout] | [INFO] [stdout] 132 | if !data_type.is_err() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 133 | return Ok(data_type.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/io/mzml_parser/types.rs:194:16 [INFO] [stdout] | [INFO] [stdout] 194 | if !compression_type.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `compression_type.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `compression_type` after checking its variant with `is_err` [INFO] [stdout] --> src/io/mzml_parser/types.rs:195:27 [INFO] [stdout] | [INFO] [stdout] 194 | if !compression_type.is_err() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 195 | return Ok(compression_type.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `decoded` after checking its variant with `is_ok` [INFO] [stdout] --> src/io/mzml_parser/types.rs:244:21 [INFO] [stdout] | [INFO] [stdout] 243 | if decoded.is_ok() { [INFO] [stdout] | ------------------ help: try: `if let Ok() = decoded` [INFO] [stdout] 244 | let v = decoded.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/io/mzml_parser/binary_conversion.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | ... let tests = vec![ [INFO] [stdout] | ___________________^ [INFO] [stdout] 101 | | ... TestData::new(Binary::new(String::from("AAAAAAAALkAAAAAAAAAsQAAAAAAAACpAAAAAAAAAKEAAAAAAAAAmQAAAAAAAACRAAAAAAAAAIkAAAAA... [INFO] [stdout] 102 | | ... TestData::new(Binary::new(String::from("eJxjYEABDhBKAEpLQGkFKK0CpTWgtA6UNoDSRg4AZlQDYw==")), CompressionType::ZlibCompr... [INFO] [stdout] 103 | | ... ]; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 100 ~ let tests = [TestData::new(Binary::new(String::from("AAAAAAAALkAAAAAAAAAsQAAAAAAAACpAAAAAAAAAKEAAAAAAAAAmQAAAAAAAACRAAAAAAAAAIkAAAAAAAAAgQAAAAAAAABxAAAAAAAAAGEAAAAAAAAAUQAAAAAAAABBAAAAAAAAACEAAAAAAAAAAQAAAAAAAAPA/")), CompressionType::NoCompression, DataType::Float64Bit, vec![15.0, 14.0, 13.0, 12.0, 11.0, 10.0, 9.0, 8.0, 7.0, 6.0, 5.0, 4.0, 3.0, 2.0, 1.0]), [INFO] [stdout] 101 ~ TestData::new(Binary::new(String::from("eJxjYEABDhBKAEpLQGkFKK0CpTWgtA6UNoDSRg4AZlQDYw==")), CompressionType::ZlibCompression, DataType::Float64Bit, vec![0.0, 2.0, 4.0, 6.0, 8.0, 10.0, 12.0, 14.0, 16.0, 18.0])]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.56s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: quick-xml v0.22.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "422916fb18f9e7202dfad6e529b3a4a780a8e1b6b55a537c7c0ec4dda852d45c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "422916fb18f9e7202dfad6e529b3a4a780a8e1b6b55a537c7c0ec4dda852d45c", kill_on_drop: false }` [INFO] [stdout] 422916fb18f9e7202dfad6e529b3a4a780a8e1b6b55a537c7c0ec4dda852d45c