[INFO] fetching crate mrtreader 0.1.0... [INFO] linting mrtreader-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate mrtreader 0.1.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate mrtreader 0.1.0 [INFO] finished tweaking crates.io crate mrtreader 0.1.0 [INFO] tweaked toml for crates.io crate mrtreader 0.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate mrtreader 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f4b0582ba01f0c125a6086b71964eb32c6f0a065d8b5f368dc9b2f2aceda4a5 [INFO] running `Command { std: "docker" "start" "-a" "6f4b0582ba01f0c125a6086b71964eb32c6f0a065d8b5f368dc9b2f2aceda4a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f4b0582ba01f0c125a6086b71964eb32c6f0a065d8b5f368dc9b2f2aceda4a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f4b0582ba01f0c125a6086b71964eb32c6f0a065d8b5f368dc9b2f2aceda4a5", kill_on_drop: false }` [INFO] [stdout] 6f4b0582ba01f0c125a6086b71964eb32c6f0a065d8b5f368dc9b2f2aceda4a5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b572cf71e7453bcbbe623be15623e0eb40d1aaaeafb4e0129f142bfe06f07bdf [INFO] running `Command { std: "docker" "start" "-a" "b572cf71e7453bcbbe623be15623e0eb40d1aaaeafb4e0129f142bfe06f07bdf", kill_on_drop: false }` [INFO] [stderr] Checking mrtreader v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/mrt.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /** [INFO] [stdout] 2 | | * TODO: Add header here. [INFO] [stdout] 3 | | */ [INFO] [stdout] 4 | | [INFO] [stdout] | |_^ [INFO] [stdout] 5 | use std::fmt; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /** [INFO] [stdout] 1 + /*! [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/mrt.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /** [INFO] [stdout] 2 | | * TODO: Add header here. [INFO] [stdout] 3 | | */ [INFO] [stdout] 4 | | [INFO] [stdout] | |_^ [INFO] [stdout] 5 | use std::fmt; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /** [INFO] [stdout] 1 + /*! [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MRTReader` is never constructed [INFO] [stdout] --> src/mrt.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct MRTReader where T: Read [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MRTHeader` is never constructed [INFO] [stdout] --> src/mrt.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct MRTHeader [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Record` is never used [INFO] [stdout] --> src/mrt.rs:38:10 [INFO] [stdout] | [INFO] [stdout] 38 | pub enum Record [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read` is never used [INFO] [stdout] --> src/mrt.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 51 | impl MRTReader where T: ReadBytesExt [INFO] [stdout] | ------------------------------------------ method in this implementation [INFO] [stdout] 52 | { [INFO] [stdout] 53 | pub fn read(&mut self) -> Result [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ISIS` contains a capitalized acronym [INFO] [stdout] --> src/mrt.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | ISIS, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Isis` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/mrt.rs:77:26 [INFO] [stdout] | [INFO] [stdout] 77 | _ => Err(Error::new(ErrorKind::Other, "Unknown MRT record type found in MRTHeader")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 77 - _ => Err(Error::new(ErrorKind::Other, "Unknown MRT record type found in MRTHeader")) [INFO] [stdout] 77 + _ => Err(Error::other("Unknown MRT record type found in MRTHeader")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ISIS` contains a capitalized acronym [INFO] [stdout] --> src/mrt.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | ISIS, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Isis` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/mrt.rs:77:26 [INFO] [stdout] | [INFO] [stdout] 77 | _ => Err(Error::new(ErrorKind::Other, "Unknown MRT record type found in MRTHeader")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 77 - _ => Err(Error::new(ErrorKind::Other, "Unknown MRT record type found in MRTHeader")) [INFO] [stdout] 77 + _ => Err(Error::other("Unknown MRT record type found in MRTHeader")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | assert!(!reader.read().is_err(), "Could not read an MRT entry"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `reader.read().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.19s [INFO] running `Command { std: "docker" "inspect" "b572cf71e7453bcbbe623be15623e0eb40d1aaaeafb4e0129f142bfe06f07bdf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b572cf71e7453bcbbe623be15623e0eb40d1aaaeafb4e0129f142bfe06f07bdf", kill_on_drop: false }` [INFO] [stdout] b572cf71e7453bcbbe623be15623e0eb40d1aaaeafb4e0129f142bfe06f07bdf