[INFO] fetching crate mraphics-core 0.0.2... [INFO] linting mraphics-core-0.0.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate mraphics-core 0.0.2 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate mraphics-core 0.0.2 [INFO] finished tweaking crates.io crate mraphics-core 0.0.2 [INFO] tweaked toml for crates.io crate mraphics-core 0.0.2 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate mraphics-core 0.0.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate mraphics-core 0.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.106 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.106 [INFO] [stderr] Downloaded range-alloc v0.1.4 [INFO] [stderr] Downloaded gpu-descriptor-types v0.2.0 [INFO] [stderr] Downloaded core-graphics-types v0.2.0 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.106 [INFO] [stderr] Downloaded windows-implement v0.58.0 [INFO] [stderr] Downloaded windows-targets v0.52.6 [INFO] [stderr] Downloaded khronos-egl v6.0.0 [INFO] [stderr] Downloaded unicode-ident v1.0.22 [INFO] [stderr] Downloaded gpu-alloc-types v0.3.0 [INFO] [stderr] Downloaded quote v1.0.42 [INFO] [stderr] Downloaded crunchy v0.2.4 [INFO] [stderr] Downloaded lock_api v0.4.14 [INFO] [stderr] Downloaded renderdoc-sys v1.1.0 [INFO] [stderr] Downloaded parking_lot_core v0.9.12 [INFO] [stderr] Downloaded glutin_wgl_sys v0.6.1 [INFO] [stderr] Downloaded cfg_aliases v0.2.1 [INFO] [stderr] Downloaded equivalent v1.0.2 [INFO] [stderr] Downloaded gpu-alloc v0.6.0 [INFO] [stderr] Downloaded foreign-types-macros v0.2.3 [INFO] [stderr] Downloaded foreign-types-shared v0.3.1 [INFO] [stderr] Downloaded gl_generator v0.14.0 [INFO] [stderr] Downloaded approx v0.5.1 [INFO] [stderr] Downloaded wgpu-core-deps-apple v27.0.0 [INFO] [stderr] Downloaded zerocopy-derive v0.8.31 [INFO] [stderr] Downloaded rawpointer v0.2.1 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.56 [INFO] [stderr] Downloaded num-integer v0.1.46 [INFO] [stderr] Downloaded num-rational v0.4.2 [INFO] [stderr] Downloaded litrs v1.0.0 [INFO] [stderr] Downloaded slotmap v1.1.1 [INFO] [stderr] Downloaded matrixmultiply v0.3.10 [INFO] [stderr] Downloaded safe_arch v0.7.4 [INFO] [stderr] Downloaded serde v1.0.228 [INFO] [stderr] Downloaded glam v0.14.0 [INFO] [stderr] Downloaded glam v0.15.2 [INFO] [stderr] Downloaded glam v0.18.0 [INFO] [stderr] Downloaded glow v0.16.0 [INFO] [stderr] Downloaded portable-atomic v1.12.0 [INFO] [stderr] Downloaded syn v2.0.111 [INFO] [stderr] Downloaded glam v0.20.5 [INFO] [stderr] Downloaded glam v0.21.3 [INFO] [stderr] Downloaded unicode-width v0.2.2 [INFO] [stderr] Downloaded glam v0.22.0 [INFO] [stderr] Downloaded glam v0.23.0 [INFO] [stderr] Downloaded glam v0.24.2 [INFO] [stderr] Downloaded wgpu-core v27.0.3 [INFO] [stderr] Downloaded glam v0.25.0 [INFO] [stderr] Downloaded windows_aarch64_gnullvm v0.52.6 [INFO] [stderr] Downloaded glam v0.27.0 [INFO] [stderr] Downloaded nalgebra v0.34.1 [INFO] [stderr] Downloaded wgpu-hal v27.0.4 [INFO] [stderr] Downloaded glam v0.28.0 [INFO] [stderr] Downloaded windows_i686_gnullvm v0.52.6 [INFO] [stderr] Downloaded windows_x86_64_gnullvm v0.52.6 [INFO] [stderr] Downloaded ash v0.38.0+1.3.281 [INFO] [stderr] Downloaded glam v0.29.3 [INFO] [stderr] Downloaded khronos_api v3.1.0 [INFO] [stderr] Downloaded web-sys v0.3.83 [INFO] [stderr] Downloaded ndk-sys v0.6.0+11769913 [INFO] [stderr] Downloaded zerocopy v0.8.31 [INFO] [stderr] Downloaded libm v0.2.15 [INFO] [stderr] Downloaded glam v0.16.0 [INFO] [stderr] Downloaded glam v0.19.0 [INFO] [stderr] Downloaded num-bigint v0.4.6 [INFO] [stderr] Downloaded hashbrown v0.15.5 [INFO] [stderr] Downloaded hashbrown v0.16.1 [INFO] [stderr] Downloaded glam v0.17.3 [INFO] [stderr] Downloaded naga v27.0.3 [INFO] [stderr] Downloaded windows_x86_64_gnu v0.52.6 [INFO] [stderr] Downloaded glam v0.30.9 [INFO] [stderr] Downloaded windows_aarch64_msvc v0.52.6 [INFO] [stderr] Downloaded libc v0.2.178 [INFO] [stderr] Downloaded typenum v1.19.0 [INFO] [stderr] Downloaded windows_x86_64_msvc v0.52.6 [INFO] [stderr] Downloaded windows_i686_gnu v0.52.6 [INFO] [stderr] Downloaded windows_i686_msvc v0.52.6 [INFO] [stderr] Downloaded indexmap v2.12.1 [INFO] [stderr] Downloaded wide v0.7.33 [INFO] [stderr] Downloaded simba v0.9.1 [INFO] [stderr] Downloaded bitflags v2.10.0 [INFO] [stderr] Downloaded bumpalo v3.19.1 [INFO] [stderr] Downloaded serde_core v1.0.228 [INFO] [stderr] Downloaded serde_derive v1.0.228 [INFO] [stderr] Downloaded codespan-reporting v0.12.0 [INFO] [stderr] Downloaded parking_lot v0.12.5 [INFO] [stderr] Downloaded static_assertions v1.1.0 [INFO] [stderr] Downloaded document-features v0.2.12 [INFO] [stderr] Downloaded num-complex v0.4.6 [INFO] [stderr] Downloaded num-traits v0.2.19 [INFO] [stderr] Downloaded portable-atomic-util v0.2.4 [INFO] [stderr] Downloaded smallvec v1.15.1 [INFO] [stderr] Downloaded bytemuck_derive v1.10.2 [INFO] [stderr] Downloaded bytemuck v1.24.0 [INFO] [stderr] Downloaded once_cell v1.21.3 [INFO] [stderr] Downloaded proc-macro2 v1.0.103 [INFO] [stderr] Downloaded wgpu v27.0.1 [INFO] [stderr] Downloaded version_check v0.9.5 [INFO] [stderr] Downloaded xml-rs v0.8.28 [INFO] [stderr] Downloaded thiserror v1.0.69 [INFO] [stderr] Downloaded foldhash v0.1.5 [INFO] [stderr] Downloaded core-foundation-sys v0.8.7 [INFO] [stderr] Downloaded core-foundation v0.10.1 [INFO] [stderr] Downloaded arrayvec v0.7.6 [INFO] [stderr] Downloaded bit-vec v0.8.0 [INFO] [stderr] Downloaded termcolor v1.4.1 [INFO] [stderr] Downloaded half v2.7.1 [INFO] [stderr] Downloaded spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Downloaded objc v0.2.7 [INFO] [stderr] Downloaded ordered-float v5.1.0 [INFO] [stderr] Downloaded raw-window-handle v0.6.2 [INFO] [stderr] Downloaded thiserror-impl v2.0.17 [INFO] [stderr] Downloaded thiserror v2.0.17 [INFO] [stderr] Downloaded js-sys v0.3.83 [INFO] [stderr] Downloaded rustversion v1.0.22 [INFO] [stderr] Downloaded wgpu-types v27.0.1 [INFO] [stderr] Downloaded nalgebra-macros v0.3.0 [INFO] [stderr] Downloaded android_system_properties v0.1.5 [INFO] [stderr] Downloaded gpu-descriptor v0.3.2 [INFO] [stderr] Downloaded pkg-config v0.3.32 [INFO] [stderr] Downloaded libloading v0.8.9 [INFO] [stderr] Downloaded block v0.1.6 [INFO] [stderr] Downloaded foreign-types v0.5.0 [INFO] [stderr] Downloaded paste v1.0.15 [INFO] [stderr] Downloaded bit-set v0.8.0 [INFO] [stderr] Downloaded foldhash v0.2.0 [INFO] [stderr] Downloaded rustc-hash v1.1.0 [INFO] [stderr] Downloaded redox_syscall v0.5.18 [INFO] [stderr] Downloaded windows-link v0.2.1 [INFO] [stderr] Downloaded windows-interface v0.58.0 [INFO] [stderr] Downloaded jni-sys v0.3.0 [INFO] [stderr] Downloaded wgpu-core-deps-emscripten v27.0.0 [INFO] [stderr] Downloaded wgpu-core-deps-windows-linux-android v27.0.0 [INFO] [stderr] Downloaded gpu-allocator v0.27.0 [INFO] [stderr] Downloaded winapi-util v0.1.11 [INFO] [stderr] Downloaded profiling v1.0.17 [INFO] [stderr] Downloaded windows-strings v0.1.0 [INFO] [stderr] Downloaded cfg-if v1.0.4 [INFO] [stderr] Downloaded presser v0.3.1 [INFO] [stderr] Downloaded thiserror-impl v1.0.69 [INFO] [stderr] Downloaded hexf-parse v0.2.1 [INFO] [stderr] Downloaded malloc_buf v0.0.6 [INFO] [stderr] Downloaded scopeguard v1.2.0 [INFO] [stderr] Downloaded windows-result v0.2.0 [INFO] [stderr] Downloaded windows-core v0.58.0 [INFO] [stderr] Downloaded log v0.4.29 [INFO] [stderr] Downloaded wasm-bindgen v0.2.106 [INFO] [stderr] Downloaded autocfg v1.5.0 [INFO] [stderr] Downloaded windows-sys v0.61.2 [INFO] [stderr] Downloaded metal v0.32.0 [INFO] [stderr] Downloaded windows v0.58.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f644bf9df9a0c4a0a1576345064a126ed34dc3eef90abb1bb4a2e8fca55f315 [INFO] running `Command { std: "docker" "start" "-a" "6f644bf9df9a0c4a0a1576345064a126ed34dc3eef90abb1bb4a2e8fca55f315", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f644bf9df9a0c4a0a1576345064a126ed34dc3eef90abb1bb4a2e8fca55f315", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f644bf9df9a0c4a0a1576345064a126ed34dc3eef90abb1bb4a2e8fca55f315", kill_on_drop: false }` [INFO] [stdout] 6f644bf9df9a0c4a0a1576345064a126ed34dc3eef90abb1bb4a2e8fca55f315 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 70f99ab62ab06275450928ed6d61757dc4a842d61b37bf99ee68deea4d8d12f9 [INFO] running `Command { std: "docker" "start" "-a" "70f99ab62ab06275450928ed6d61757dc4a842d61b37bf99ee68deea4d8d12f9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling naga v27.0.3 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Compiling khronos-egl v6.0.0 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Compiling ash v0.38.0+1.3.281 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Compiling wgpu-hal v27.0.4 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking hexf-parse v0.2.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking codespan-reporting v0.12.0 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking renderdoc-sys v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Compiling wgpu-core v27.0.3 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Compiling wgpu v27.0.1 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking gpu-descriptor v0.3.2 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking ordered-float v5.1.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling nalgebra-macros v0.3.0 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking wgpu-types v27.0.1 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Checking simba v0.9.1 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking nalgebra v0.34.1 [INFO] [stderr] Checking wgpu-core-deps-windows-linux-android v27.0.0 [INFO] [stderr] Checking mraphics-core v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/render/conveyor.rs:160:17 [INFO] [stdout] | [INFO] [stdout] 160 | bind_group: bind_group, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bind_group` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/render/conveyor.rs:161:17 [INFO] [stdout] | [INFO] [stdout] 161 | bind_group_layout: bind_group_layout, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bind_group_layout` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/material/basic.rs:3:29 [INFO] [stdout] | [INFO] [stdout] 3 | const COLOR_UNIFORM_LABEL: &'static str = "mraphics-color-uniform"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/render/conveyor.rs:160:17 [INFO] [stdout] | [INFO] [stdout] 160 | bind_group: bind_group, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bind_group` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/render/conveyor.rs:161:17 [INFO] [stdout] | [INFO] [stdout] 161 | bind_group_layout: bind_group_layout, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bind_group_layout` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:1:19 [INFO] [stdout] | [INFO] [stdout] 1 | pub const WHITE: &'static str = "#ffffffff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | pub const BLACK: &'static str = "#000000ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:3:25 [INFO] [stdout] | [INFO] [stdout] 3 | pub const TRANSPARENT: &'static str = "#00000000"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | pub const RED_A: &'static str = "#ffccccff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:6:19 [INFO] [stdout] | [INFO] [stdout] 6 | pub const RED_B: &'static str = "#ff9999ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:7:19 [INFO] [stdout] | [INFO] [stdout] 7 | pub const RED_C: &'static str = "#ff6664ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | pub const RED_D: &'static str = "#da2b2bff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | pub const RED_E: &'static str = "#b82323ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | pub const RED: &'static str = RED_C; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | pub const BLUE_A: &'static str = "#99ccffff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | pub const BLUE_B: &'static str = "#66b3ffff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:14:20 [INFO] [stdout] | [INFO] [stdout] 14 | pub const BLUE_C: &'static str = "#3599fdff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | pub const BLUE_D: &'static str = "#007fffff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | pub const BLUE_E: &'static str = "#0f4ae1ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | pub const BLUE: &'static str = BLUE_C; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | pub const YELLOW_A: &'static str = "#fff0ccff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | pub const YELLOW_B: &'static str = "#ffdd99ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:21:22 [INFO] [stdout] | [INFO] [stdout] 21 | pub const YELLOW_C: &'static str = "#ffcc66ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | pub const YELLOW_D: &'static str = "#f0aa33ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:23:22 [INFO] [stdout] | [INFO] [stdout] 23 | pub const YELLOW_E: &'static str = "#d28c19ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub const YELLOW: &'static str = YELLOW_C; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 26 | pub const GREEN_A: &'static str = "#ccffccff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | pub const GREEN_B: &'static str = "#99ff99ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:28:21 [INFO] [stdout] | [INFO] [stdout] 28 | pub const GREEN_C: &'static str = "#64f25fff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | pub const GREEN_D: &'static str = "#32e232ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | pub const GREEN_E: &'static str = "#0cb00cff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | pub const GREEN: &'static str = GREEN_C; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | pub const GRAY_A: &'static str = "#f0f0f0ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:34:20 [INFO] [stdout] | [INFO] [stdout] 34 | pub const GRAY_B: &'static str = "#ccccccff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/material/basic.rs:3:29 [INFO] [stdout] | [INFO] [stdout] 3 | const COLOR_UNIFORM_LABEL: &'static str = "mraphics-color-uniform"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub const GRAY_C: &'static str = "#979797ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | pub const GRAY_D: &'static str = "#4b4b4bff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | pub const GRAY_E: &'static str = "#262628ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 38 | pub const GRAY: &'static str = GRAY_C; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | pub const COOPER_ORANGE: &'static str = "#ff936d"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:41:24 [INFO] [stdout] | [INFO] [stdout] 41 | pub const SEIYA_PINK: &'static str = "#f79ab9"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | pub const BINARY_GOLD: &'static str = "#fbce71"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/mod.rs:47:28 [INFO] [stdout] | [INFO] [stdout] 47 | pub const VIEW_MAT_LABEL: &'static str = "mraphics-view-mat"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/mod.rs:53:34 [INFO] [stdout] | [INFO] [stdout] 53 | pub const PROJECTION_MAT_LABEL: &'static str = "mraphics-projection-mat"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/mod.rs:59:29 [INFO] [stdout] | [INFO] [stdout] 59 | pub const MODEL_MAT_LABEL: &'static str = "mraphics-model-mat"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/mod.rs:65:33 [INFO] [stdout] | [INFO] [stdout] 65 | pub const POSITION_ATTR_LABEL: &'static str = "mraphics-position-attribute"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/mod.rs:71:32 [INFO] [stdout] | [INFO] [stdout] 71 | pub const INDEX_BUFFER_LABEL: &'static str = "mraphics-index-buffer"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/mod.rs:73:30 [INFO] [stdout] | [INFO] [stdout] 73 | pub const COLOR_ATTR_LABEL: &'static str = "mraphics-color-attribute"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:1:19 [INFO] [stdout] | [INFO] [stdout] 1 | pub const WHITE: &'static str = "#ffffffff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | pub const BLACK: &'static str = "#000000ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:3:25 [INFO] [stdout] | [INFO] [stdout] 3 | pub const TRANSPARENT: &'static str = "#00000000"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | pub const RED_A: &'static str = "#ffccccff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:6:19 [INFO] [stdout] | [INFO] [stdout] 6 | pub const RED_B: &'static str = "#ff9999ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:7:19 [INFO] [stdout] | [INFO] [stdout] 7 | pub const RED_C: &'static str = "#ff6664ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | pub const RED_D: &'static str = "#da2b2bff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | pub const RED_E: &'static str = "#b82323ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | pub const RED: &'static str = RED_C; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | pub const BLUE_A: &'static str = "#99ccffff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | pub const BLUE_B: &'static str = "#66b3ffff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:14:20 [INFO] [stdout] | [INFO] [stdout] 14 | pub const BLUE_C: &'static str = "#3599fdff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | pub const BLUE_D: &'static str = "#007fffff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | pub const BLUE_E: &'static str = "#0f4ae1ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | pub const BLUE: &'static str = BLUE_C; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | pub const YELLOW_A: &'static str = "#fff0ccff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | pub const YELLOW_B: &'static str = "#ffdd99ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:21:22 [INFO] [stdout] | [INFO] [stdout] 21 | pub const YELLOW_C: &'static str = "#ffcc66ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | pub const YELLOW_D: &'static str = "#f0aa33ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:23:22 [INFO] [stdout] | [INFO] [stdout] 23 | pub const YELLOW_E: &'static str = "#d28c19ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub const YELLOW: &'static str = YELLOW_C; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 26 | pub const GREEN_A: &'static str = "#ccffccff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | pub const GREEN_B: &'static str = "#99ff99ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:28:21 [INFO] [stdout] | [INFO] [stdout] 28 | pub const GREEN_C: &'static str = "#64f25fff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | pub const GREEN_D: &'static str = "#32e232ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | pub const GREEN_E: &'static str = "#0cb00cff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | pub const GREEN: &'static str = GREEN_C; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | pub const GRAY_A: &'static str = "#f0f0f0ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:34:20 [INFO] [stdout] | [INFO] [stdout] 34 | pub const GRAY_B: &'static str = "#ccccccff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub const GRAY_C: &'static str = "#979797ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | pub const GRAY_D: &'static str = "#4b4b4bff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | pub const GRAY_E: &'static str = "#262628ff"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 38 | pub const GRAY: &'static str = GRAY_C; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | pub const COOPER_ORANGE: &'static str = "#ff936d"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:41:24 [INFO] [stdout] | [INFO] [stdout] 41 | pub const SEIYA_PINK: &'static str = "#f79ab9"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/colors.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | pub const BINARY_GOLD: &'static str = "#fbce71"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/mod.rs:47:28 [INFO] [stdout] | [INFO] [stdout] 47 | pub const VIEW_MAT_LABEL: &'static str = "mraphics-view-mat"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/mod.rs:53:34 [INFO] [stdout] | [INFO] [stdout] 53 | pub const PROJECTION_MAT_LABEL: &'static str = "mraphics-projection-mat"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/mod.rs:59:29 [INFO] [stdout] | [INFO] [stdout] 59 | pub const MODEL_MAT_LABEL: &'static str = "mraphics-model-mat"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/mod.rs:65:33 [INFO] [stdout] | [INFO] [stdout] 65 | pub const POSITION_ATTR_LABEL: &'static str = "mraphics-position-attribute"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/mod.rs:71:32 [INFO] [stdout] | [INFO] [stdout] 71 | pub const INDEX_BUFFER_LABEL: &'static str = "mraphics-index-buffer"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants/mod.rs:73:30 [INFO] [stdout] | [INFO] [stdout] 73 | pub const COLOR_ATTR_LABEL: &'static str = "mraphics-color-attribute"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Scene` [INFO] [stdout] --> src/scene.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / pub fn new() -> Self { [INFO] [stdout] 11 | | Self { [INFO] [stdout] 12 | | instances: Vec::new(), [INFO] [stdout] 13 | | instance_map: HashMap::new(), [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl Default for Scene { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `update_instance` doesn't need a mutable reference [INFO] [stdout] --> src/mesh_pool.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | (&mut *(ptr as *mut M)).update_instance(instance); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 46 - (&mut *(ptr as *mut M)).update_instance(instance); [INFO] [stdout] 46 + (&*(ptr as *mut M)).update_instance(instance); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Scene` [INFO] [stdout] --> src/scene.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / pub fn new() -> Self { [INFO] [stdout] 11 | | Self { [INFO] [stdout] 12 | | instances: Vec::new(), [INFO] [stdout] 13 | | instance_map: HashMap::new(), [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl Default for Scene { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MeshPool` [INFO] [stdout] --> src/mesh_pool.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | / pub fn new() -> Self { [INFO] [stdout] 132 | | Self { [INFO] [stdout] 133 | | meshes: Vec::new(), [INFO] [stdout] 134 | | mesh_map: HashMap::new(), [INFO] [stdout] 135 | | } [INFO] [stdout] 136 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 130 + impl Default for MeshPool { [INFO] [stdout] 131 + fn default() -> Self { [INFO] [stdout] 132 + Self::new() [INFO] [stdout] 133 + } [INFO] [stdout] 134 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `update_instance` doesn't need a mutable reference [INFO] [stdout] --> src/mesh_pool.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | (&mut *(ptr as *mut M)).update_instance(instance); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 46 - (&mut *(ptr as *mut M)).update_instance(instance); [INFO] [stdout] 46 + (&*(ptr as *mut M)).update_instance(instance); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MeshPool` [INFO] [stdout] --> src/mesh_pool.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | / pub fn new() -> Self { [INFO] [stdout] 132 | | Self { [INFO] [stdout] 133 | | meshes: Vec::new(), [INFO] [stdout] 134 | | mesh_map: HashMap::new(), [INFO] [stdout] 135 | | } [INFO] [stdout] 136 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 130 + impl Default for MeshPool { [INFO] [stdout] 131 + fn default() -> Self { [INFO] [stdout] 132 + Self::new() [INFO] [stdout] 133 + } [INFO] [stdout] 134 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/renderer.rs:199:69 [INFO] [stdout] | [INFO] [stdout] 199 | render_recursive(this, texture_format, render_pass, &mut child); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/render/renderer.rs:287:38 [INFO] [stdout] | [INFO] [stdout] 287 | label: Some(&format!("Mraphics bind group layout placeholder",)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Mraphics bind group layout placeholder".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/render/renderer.rs:336:17 [INFO] [stdout] | [INFO] [stdout] 336 | / if indices.buffer.is_none() { [INFO] [stdout] 337 | | if indices.buffer.is_none() { [INFO] [stdout] 338 | | indices.buffer.replace(self.device.create_buffer_init( [INFO] [stdout] 339 | | &wgpu::util::BufferInitDescriptor { [INFO] [stdout] ... | [INFO] [stdout] 346 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 336 ~ if indices.buffer.is_none() [INFO] [stdout] 337 ~ && indices.buffer.is_none() { [INFO] [stdout] 338 | indices.buffer.replace(self.device.create_buffer_init( [INFO] [stdout] ... [INFO] [stdout] 344 | )); [INFO] [stdout] 345 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Conveyor` [INFO] [stdout] --> src/render/conveyor.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / pub fn new() -> Self { [INFO] [stdout] 53 | | Self { [INFO] [stdout] 54 | | gadgets: HashMap::new(), [INFO] [stdout] 55 | | bundles: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 51 + impl Default for Conveyor { [INFO] [stdout] 52 + fn default() -> Self { [INFO] [stdout] 53 + Self::new() [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/renderer.rs:199:69 [INFO] [stdout] | [INFO] [stdout] 199 | render_recursive(this, texture_format, render_pass, &mut child); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/render/renderer.rs:287:38 [INFO] [stdout] | [INFO] [stdout] 287 | label: Some(&format!("Mraphics bind group layout placeholder",)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Mraphics bind group layout placeholder".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/render/conveyor.rs:200:20 [INFO] [stdout] | [INFO] [stdout] 200 | if !bundles.get(i).is_none() && !bundles[i].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bundles.get(i).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/render/conveyor.rs:200:49 [INFO] [stdout] | [INFO] [stdout] 200 | if !bundles.get(i).is_none() && !bundles[i].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `bundles[i].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/render/renderer.rs:336:17 [INFO] [stdout] | [INFO] [stdout] 336 | / if indices.buffer.is_none() { [INFO] [stdout] 337 | | if indices.buffer.is_none() { [INFO] [stdout] 338 | | indices.buffer.replace(self.device.create_buffer_init( [INFO] [stdout] 339 | | &wgpu::util::BufferInitDescriptor { [INFO] [stdout] ... | [INFO] [stdout] 346 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 336 ~ if indices.buffer.is_none() [INFO] [stdout] 337 ~ && indices.buffer.is_none() { [INFO] [stdout] 338 | indices.buffer.replace(self.device.create_buffer_init( [INFO] [stdout] ... [INFO] [stdout] 344 | )); [INFO] [stdout] 345 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PipelineManager` [INFO] [stdout] --> src/render/pipeline_manager.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / pub fn new() -> Self { [INFO] [stdout] 10 | | Self { [INFO] [stdout] 11 | | pipeline_pool: HashMap::new(), [INFO] [stdout] 12 | | } [INFO] [stdout] 13 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 8 + impl Default for PipelineManager { [INFO] [stdout] 9 + fn default() -> Self { [INFO] [stdout] 10 + Self::new() [INFO] [stdout] 11 + } [INFO] [stdout] 12 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/pipeline_manager.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | &self.pipeline_pool.get(&pipeline_identifier).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.pipeline_pool.get(&pipeline_identifier).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/render/pipeline_manager.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 82 | / let render_pipeline = device.create_render_pipeline(&wgpu::RenderPipelineDescriptor { [INFO] [stdout] 83 | | label: Some("Mraphics Render Pipeline"), [INFO] [stdout] 84 | | layout: Some(&render_pipeline_layout), [INFO] [stdout] 85 | | vertex: wgpu::VertexState { [INFO] [stdout] ... | [INFO] [stdout] 113 | | cache: None, [INFO] [stdout] 114 | | }); [INFO] [stdout] | |___________- unnecessary `let` binding [INFO] [stdout] 115 | [INFO] [stdout] 116 | render_pipeline [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 82 ~ [INFO] [stdout] 83 | [INFO] [stdout] 84 ~ device.create_render_pipeline(&wgpu::RenderPipelineDescriptor { [INFO] [stdout] 85 + label: Some("Mraphics Render Pipeline"), [INFO] [stdout] 86 + layout: Some(&render_pipeline_layout), [INFO] [stdout] 87 + vertex: wgpu::VertexState { [INFO] [stdout] 88 + module: &shader_module, [INFO] [stdout] 89 + entry_point: Some("vs"), [INFO] [stdout] 90 + buffers: &[], [INFO] [stdout] 91 + compilation_options: wgpu::PipelineCompilationOptions::default(), [INFO] [stdout] 92 + }, [INFO] [stdout] 93 + fragment: Some(wgpu::FragmentState { [INFO] [stdout] 94 + module: &shader_module, [INFO] [stdout] 95 + entry_point: Some("fs"), [INFO] [stdout] 96 + targets: &[Some(wgpu::ColorTargetState { [INFO] [stdout] 97 + format: texture_format, [INFO] [stdout] 98 + blend: Some(wgpu::BlendState::REPLACE), [INFO] [stdout] 99 + write_mask: wgpu::ColorWrites::ALL, [INFO] [stdout] 100 + })], [INFO] [stdout] 101 + compilation_options: wgpu::PipelineCompilationOptions::default(), [INFO] [stdout] 102 + }), [INFO] [stdout] 103 + primitive: wgpu::PrimitiveState { [INFO] [stdout] 104 + topology: topology.to_wgpu(), [INFO] [stdout] 105 + strip_index_format: None, [INFO] [stdout] 106 + front_face: wgpu::FrontFace::Ccw, [INFO] [stdout] 107 + cull_mode: None, [INFO] [stdout] 108 + polygon_mode: wgpu::PolygonMode::Fill, [INFO] [stdout] 109 + unclipped_depth: false, [INFO] [stdout] 110 + conservative: false, [INFO] [stdout] 111 + }, [INFO] [stdout] 112 + depth_stencil: None, [INFO] [stdout] 113 + multisample: wgpu::MultisampleState::default(), [INFO] [stdout] 114 + multiview: None, [INFO] [stdout] 115 + cache: None, [INFO] [stdout] 116 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Conveyor` [INFO] [stdout] --> src/render/conveyor.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / pub fn new() -> Self { [INFO] [stdout] 53 | | Self { [INFO] [stdout] 54 | | gadgets: HashMap::new(), [INFO] [stdout] 55 | | bundles: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 51 + impl Default for Conveyor { [INFO] [stdout] 52 + fn default() -> Self { [INFO] [stdout] 53 + Self::new() [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ConveyorManager` [INFO] [stdout] --> src/render/conveyor_manager.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / pub fn new() -> Self { [INFO] [stdout] 11 | | Self { [INFO] [stdout] 12 | | conveyor_pool: HashMap::new(), [INFO] [stdout] 13 | | } [INFO] [stdout] 14 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl> Default for ConveyorManager { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/geometry/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod geometry; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GeometryView` [INFO] [stdout] --> src/geometry/geometry.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / pub fn new() -> Self { [INFO] [stdout] 60 | | let mut out = Self { [INFO] [stdout] 61 | | indices: GeometryIndices::Sequential(0), [INFO] [stdout] ... | [INFO] [stdout] 76 | | out [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 58 + impl Default for GeometryView { [INFO] [stdout] 59 + fn default() -> Self { [INFO] [stdout] 60 + Self::new() [INFO] [stdout] 61 + } [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/render/conveyor.rs:200:20 [INFO] [stdout] | [INFO] [stdout] 200 | if !bundles.get(i).is_none() && !bundles[i].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bundles.get(i).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/render/conveyor.rs:200:49 [INFO] [stdout] | [INFO] [stdout] 200 | if !bundles.get(i).is_none() && !bundles[i].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `bundles[i].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PipelineManager` [INFO] [stdout] --> src/render/pipeline_manager.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / pub fn new() -> Self { [INFO] [stdout] 10 | | Self { [INFO] [stdout] 11 | | pipeline_pool: HashMap::new(), [INFO] [stdout] 12 | | } [INFO] [stdout] 13 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 8 + impl Default for PipelineManager { [INFO] [stdout] 9 + fn default() -> Self { [INFO] [stdout] 10 + Self::new() [INFO] [stdout] 11 + } [INFO] [stdout] 12 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Vertices` [INFO] [stdout] --> src/geometry/geometry.rs:227:5 [INFO] [stdout] | [INFO] [stdout] 227 | / pub fn new() -> Self { [INFO] [stdout] 228 | | Self { data: Vec::new() } [INFO] [stdout] 229 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 225 + impl Default for Vertices { [INFO] [stdout] 226 + fn default() -> Self { [INFO] [stdout] 227 + Self::new() [INFO] [stdout] 228 + } [INFO] [stdout] 229 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/pipeline_manager.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | &self.pipeline_pool.get(&pipeline_identifier).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.pipeline_pool.get(&pipeline_identifier).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/render/pipeline_manager.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 82 | / let render_pipeline = device.create_render_pipeline(&wgpu::RenderPipelineDescriptor { [INFO] [stdout] 83 | | label: Some("Mraphics Render Pipeline"), [INFO] [stdout] 84 | | layout: Some(&render_pipeline_layout), [INFO] [stdout] 85 | | vertex: wgpu::VertexState { [INFO] [stdout] ... | [INFO] [stdout] 113 | | cache: None, [INFO] [stdout] 114 | | }); [INFO] [stdout] | |___________- unnecessary `let` binding [INFO] [stdout] 115 | [INFO] [stdout] 116 | render_pipeline [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 82 ~ [INFO] [stdout] 83 | [INFO] [stdout] 84 ~ device.create_render_pipeline(&wgpu::RenderPipelineDescriptor { [INFO] [stdout] 85 + label: Some("Mraphics Render Pipeline"), [INFO] [stdout] 86 + layout: Some(&render_pipeline_layout), [INFO] [stdout] 87 + vertex: wgpu::VertexState { [INFO] [stdout] 88 + module: &shader_module, [INFO] [stdout] 89 + entry_point: Some("vs"), [INFO] [stdout] 90 + buffers: &[], [INFO] [stdout] 91 + compilation_options: wgpu::PipelineCompilationOptions::default(), [INFO] [stdout] 92 + }, [INFO] [stdout] 93 + fragment: Some(wgpu::FragmentState { [INFO] [stdout] 94 + module: &shader_module, [INFO] [stdout] 95 + entry_point: Some("fs"), [INFO] [stdout] 96 + targets: &[Some(wgpu::ColorTargetState { [INFO] [stdout] 97 + format: texture_format, [INFO] [stdout] 98 + blend: Some(wgpu::BlendState::REPLACE), [INFO] [stdout] 99 + write_mask: wgpu::ColorWrites::ALL, [INFO] [stdout] 100 + })], [INFO] [stdout] 101 + compilation_options: wgpu::PipelineCompilationOptions::default(), [INFO] [stdout] 102 + }), [INFO] [stdout] 103 + primitive: wgpu::PrimitiveState { [INFO] [stdout] 104 + topology: topology.to_wgpu(), [INFO] [stdout] 105 + strip_index_format: None, [INFO] [stdout] 106 + front_face: wgpu::FrontFace::Ccw, [INFO] [stdout] 107 + cull_mode: None, [INFO] [stdout] 108 + polygon_mode: wgpu::PolygonMode::Fill, [INFO] [stdout] 109 + unclipped_depth: false, [INFO] [stdout] 110 + conservative: false, [INFO] [stdout] 111 + }, [INFO] [stdout] 112 + depth_stencil: None, [INFO] [stdout] 113 + multisample: wgpu::MultisampleState::default(), [INFO] [stdout] 114 + multiview: None, [INFO] [stdout] 115 + cache: None, [INFO] [stdout] 116 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ConveyorManager` [INFO] [stdout] --> src/render/conveyor_manager.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / pub fn new() -> Self { [INFO] [stdout] 11 | | Self { [INFO] [stdout] 12 | | conveyor_pool: HashMap::new(), [INFO] [stdout] 13 | | } [INFO] [stdout] 14 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl> Default for ConveyorManager { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/geometry/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod geometry; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GeometryView` [INFO] [stdout] --> src/geometry/geometry.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / pub fn new() -> Self { [INFO] [stdout] 60 | | let mut out = Self { [INFO] [stdout] 61 | | indices: GeometryIndices::Sequential(0), [INFO] [stdout] ... | [INFO] [stdout] 76 | | out [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 58 + impl Default for GeometryView { [INFO] [stdout] 59 + fn default() -> Self { [INFO] [stdout] 60 + Self::new() [INFO] [stdout] 61 + } [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Vertices` [INFO] [stdout] --> src/geometry/geometry.rs:227:5 [INFO] [stdout] | [INFO] [stdout] 227 | / pub fn new() -> Self { [INFO] [stdout] 228 | | Self { data: Vec::new() } [INFO] [stdout] 229 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 225 + impl Default for Vertices { [INFO] [stdout] 226 + fn default() -> Self { [INFO] [stdout] 227 + Self::new() [INFO] [stdout] 228 + } [INFO] [stdout] 229 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/geometry/sphere.rs:60:70 [INFO] [stdout] | [INFO] [stdout] 60 | view.indices = GeometryIndices::CustomU16(CustomIndices::new((&self.indices).to_owned())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `self.indices` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/material/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod material; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BasicMaterial` [INFO] [stdout] --> src/material/basic.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | Self { [INFO] [stdout] 17 | | color: Color::from_hex_str(crate::constants::SEIYA_PINK).unwrap(), [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for BasicMaterial { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MultiColoredMaterial` [INFO] [stdout] --> src/material/multi_colored.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / pub fn new() -> Self { [INFO] [stdout] 8 | | Self {} [INFO] [stdout] 9 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 6 + impl Default for MultiColoredMaterial { [INFO] [stdout] 7 + fn default() -> Self { [INFO] [stdout] 8 + Self::new() [INFO] [stdout] 9 + } [INFO] [stdout] 10 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Mobject2DMaterial` [INFO] [stdout] --> src/material/mobject_2d.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self {} [INFO] [stdout] 14 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for Mobject2DMaterial { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/geometry/sphere.rs:60:70 [INFO] [stdout] | [INFO] [stdout] 60 | view.indices = GeometryIndices::CustomU16(CustomIndices::new((&self.indices).to_owned())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `self.indices` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Matrix, Const<1>, ArrayStorage>` which implements the `Copy` trait [INFO] [stdout] --> src/math/camera.rs:33:68 [INFO] [stdout] | [INFO] [stdout] 33 | Isometry3::new(self.view_transform.translation.vector, rotarion.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*rotarion` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/math/camera.rs:85:33 [INFO] [stdout] | [INFO] [stdout] 85 | &Point3::from_slice(&self.center.as_slice()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.center.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/math/camera.rs:93:31 [INFO] [stdout] | [INFO] [stdout] 93 | self.center.copy_from(¢er); [INFO] [stdout] | ^^^^^^^ help: change this to: `center` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/material/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod material; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BasicMaterial` [INFO] [stdout] --> src/material/basic.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | Self { [INFO] [stdout] 17 | | color: Color::from_hex_str(crate::constants::SEIYA_PINK).unwrap(), [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for BasicMaterial { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MultiColoredMaterial` [INFO] [stdout] --> src/material/multi_colored.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / pub fn new() -> Self { [INFO] [stdout] 8 | | Self {} [INFO] [stdout] 9 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 6 + impl Default for MultiColoredMaterial { [INFO] [stdout] 7 + fn default() -> Self { [INFO] [stdout] 8 + Self::new() [INFO] [stdout] 9 + } [INFO] [stdout] 10 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Mobject2DMaterial` [INFO] [stdout] --> src/material/mobject_2d.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self {} [INFO] [stdout] 14 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for Mobject2DMaterial { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/math/color.rs:92:1 [INFO] [stdout] | [INFO] [stdout] 92 | impl Into> for [T; 4] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From<[T; 4]>` [INFO] [stdout] | [INFO] [stdout] 92 ~ impl From<[T; 4]> for Color { [INFO] [stdout] 93 ~ fn from(val: [T; 4]) -> Self { [INFO] [stdout] 94 ~ Color::new(val[0], val[1], val[2], val[3]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LogicalTimeline<'res>` [INFO] [stdout] --> src/animation/timeline.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | / pub fn new() -> Self { [INFO] [stdout] 55 | | Self { [INFO] [stdout] 56 | | state: TimelineState::WAITING, [INFO] [stdout] 57 | | logical_fps: 60.0, [INFO] [stdout] ... | [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 53 + impl<'res> Default for LogicalTimeline<'res> { [INFO] [stdout] 54 + fn default() -> Self { [INFO] [stdout] 55 + Self::new() [INFO] [stdout] 56 + } [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/animation/timeline.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / match self.state { [INFO] [stdout] 84 | | TimelineState::PLAYING => { [INFO] [stdout] 85 | | self.current_frame += 1; [INFO] [stdout] 86 | | self.process(); [INFO] [stdout] 87 | | } [INFO] [stdout] 88 | | _ => {} [INFO] [stdout] 89 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 83 ~ if let TimelineState::PLAYING = self.state { [INFO] [stdout] 84 + self.current_frame += 1; [INFO] [stdout] 85 + self.process(); [INFO] [stdout] 86 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PhysicalTimeline<'res>` [INFO] [stdout] --> src/animation/timeline.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | / pub fn new() -> Self { [INFO] [stdout] 121 | | Self { [INFO] [stdout] 122 | | state: TimelineState::WAITING, [INFO] [stdout] 123 | | current_time: 0.0, [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 119 + impl<'res> Default for PhysicalTimeline<'res> { [INFO] [stdout] 120 + fn default() -> Self { [INFO] [stdout] 121 + Self::new() [INFO] [stdout] 122 + } [INFO] [stdout] 123 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/animation/timeline.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | / match self.state { [INFO] [stdout] 160 | | TimelineState::PLAYING => { [INFO] [stdout] 161 | | self.current_time = self.time_at_pause + self.start_instant.elapsed().as_secs_f32(); [INFO] [stdout] 162 | | self.process(); [INFO] [stdout] 163 | | } [INFO] [stdout] 164 | | _ => {} [INFO] [stdout] 165 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 159 ~ if let TimelineState::PLAYING = self.state { [INFO] [stdout] 160 + self.current_time = self.time_at_pause + self.start_instant.elapsed().as_secs_f32(); [INFO] [stdout] 161 + self.process(); [INFO] [stdout] 162 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Action<'res>` [INFO] [stdout] --> src/animation/action.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | Self { [INFO] [stdout] 17 | | start_time: 0.0, [INFO] [stdout] 18 | | duration: 1.0, [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl<'res> Default for Action<'res> { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/animation/mod.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | mod animation; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/animation/predefined/basic.rs:213:22 [INFO] [stdout] | [INFO] [stdout] 213 | &(UnitQuaternion::from_axis_angle( [INFO] [stdout] | ______________________^ [INFO] [stdout] 214 | | &self.axis, [INFO] [stdout] 215 | | self.angle_rad * self.curve.sample(p), [INFO] [stdout] 216 | | ) * &*start_rotation.borrow()), [INFO] [stdout] | |_________________________-------------------------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `*start_rotation.borrow()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Matrix, Const<1>, ArrayStorage>` which implements the `Copy` trait [INFO] [stdout] --> src/math/camera.rs:33:68 [INFO] [stdout] | [INFO] [stdout] 33 | Isometry3::new(self.view_transform.translation.vector, rotarion.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*rotarion` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/animation/predefined/basic.rs:276:22 [INFO] [stdout] | [INFO] [stdout] 276 | &(*start_place.borrow() [INFO] [stdout] | ______________________^ [INFO] [stdout] 277 | | + &((self.target_place - *start_place.borrow()) * self.curve.sample(p))), [INFO] [stdout] | |___________________________---------------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `((self.target_place - *start_place.borrow()) * self.curve.sample(p))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/math/camera.rs:85:33 [INFO] [stdout] | [INFO] [stdout] 85 | &Point3::from_slice(&self.center.as_slice()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.center.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/animation/predefined/basic.rs:335:22 [INFO] [stdout] | [INFO] [stdout] 335 | &(*start_scale.borrow() [INFO] [stdout] | ______________________^ [INFO] [stdout] 336 | | + &((self.target_scale - *start_scale.borrow()) * self.curve.sample(p))), [INFO] [stdout] | |___________________________---------------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `((self.target_scale - *start_scale.borrow()) * self.curve.sample(p))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/math/camera.rs:93:31 [INFO] [stdout] | [INFO] [stdout] 93 | self.center.copy_from(¢er); [INFO] [stdout] | ^^^^^^^ help: change this to: `center` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/predefined/transform.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 111 | &transformed.borrow().as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `transformed.borrow().as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/predefined/transform.rs:115:25 [INFO] [stdout] | [INFO] [stdout] 115 | / &mut scene [INFO] [stdout] 116 | | .borrow_mut() [INFO] [stdout] 117 | | .acquire_instance_mut_unchecked(self.mesh_id), [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 115 ~ scene [INFO] [stdout] 116 + .borrow_mut() [INFO] [stdout] 117 ~ .acquire_instance_mut_unchecked(self.mesh_id), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/math/color.rs:92:1 [INFO] [stdout] | [INFO] [stdout] 92 | impl Into> for [T; 4] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From<[T; 4]>` [INFO] [stdout] | [INFO] [stdout] 92 ~ impl From<[T; 4]> for Color { [INFO] [stdout] 93 ~ fn from(val: [T; 4]) -> Self { [INFO] [stdout] 94 ~ Color::new(val[0], val[1], val[2], val[3]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animation/predefined/transform.rs:205:29 [INFO] [stdout] | [INFO] [stdout] 205 | ... return [transformed[0], transformed[1], transformed[2]]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 205 - return [transformed[0], transformed[1], transformed[2]]; [INFO] [stdout] 205 + [transformed[0], transformed[1], transformed[2]] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/animation/predefined/transform.rs:204:47 [INFO] [stdout] | [INFO] [stdout] 204 | ... let transformed = self.matrix * &Vector3::from_row_slice(point); [INFO] [stdout] | ^^^^^^^^^^^^^^------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `Vector3::from_row_slice(point)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/predefined/transform.rs:220:25 [INFO] [stdout] | [INFO] [stdout] 220 | &transformed.borrow().as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `transformed.borrow().as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/predefined/transform.rs:224:25 [INFO] [stdout] | [INFO] [stdout] 224 | / &mut scene [INFO] [stdout] 225 | | .borrow_mut() [INFO] [stdout] 226 | | .acquire_instance_mut_unchecked(self.mesh_id), [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 224 ~ scene [INFO] [stdout] 225 + .borrow_mut() [INFO] [stdout] 226 ~ .acquire_instance_mut_unchecked(self.mesh_id), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LogicalTimeline<'res>` [INFO] [stdout] --> src/animation/timeline.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | / pub fn new() -> Self { [INFO] [stdout] 55 | | Self { [INFO] [stdout] 56 | | state: TimelineState::WAITING, [INFO] [stdout] 57 | | logical_fps: 60.0, [INFO] [stdout] ... | [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 53 + impl<'res> Default for LogicalTimeline<'res> { [INFO] [stdout] 54 + fn default() -> Self { [INFO] [stdout] 55 + Self::new() [INFO] [stdout] 56 + } [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/animation/timeline.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / match self.state { [INFO] [stdout] 84 | | TimelineState::PLAYING => { [INFO] [stdout] 85 | | self.current_frame += 1; [INFO] [stdout] 86 | | self.process(); [INFO] [stdout] 87 | | } [INFO] [stdout] 88 | | _ => {} [INFO] [stdout] 89 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 83 ~ if let TimelineState::PLAYING = self.state { [INFO] [stdout] 84 + self.current_frame += 1; [INFO] [stdout] 85 + self.process(); [INFO] [stdout] 86 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PhysicalTimeline<'res>` [INFO] [stdout] --> src/animation/timeline.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | / pub fn new() -> Self { [INFO] [stdout] 121 | | Self { [INFO] [stdout] 122 | | state: TimelineState::WAITING, [INFO] [stdout] 123 | | current_time: 0.0, [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 119 + impl<'res> Default for PhysicalTimeline<'res> { [INFO] [stdout] 120 + fn default() -> Self { [INFO] [stdout] 121 + Self::new() [INFO] [stdout] 122 + } [INFO] [stdout] 123 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/animation/timeline.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | / match self.state { [INFO] [stdout] 160 | | TimelineState::PLAYING => { [INFO] [stdout] 161 | | self.current_time = self.time_at_pause + self.start_instant.elapsed().as_secs_f32(); [INFO] [stdout] 162 | | self.process(); [INFO] [stdout] 163 | | } [INFO] [stdout] 164 | | _ => {} [INFO] [stdout] 165 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 159 ~ if let TimelineState::PLAYING = self.state { [INFO] [stdout] 160 + self.current_time = self.time_at_pause + self.start_instant.elapsed().as_secs_f32(); [INFO] [stdout] 161 + self.process(); [INFO] [stdout] 162 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Action<'res>` [INFO] [stdout] --> src/animation/action.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | Self { [INFO] [stdout] 17 | | start_time: 0.0, [INFO] [stdout] 18 | | duration: 1.0, [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl<'res> Default for Action<'res> { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/animation/mod.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | mod animation; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/animation/predefined/basic.rs:213:22 [INFO] [stdout] | [INFO] [stdout] 213 | &(UnitQuaternion::from_axis_angle( [INFO] [stdout] | ______________________^ [INFO] [stdout] 214 | | &self.axis, [INFO] [stdout] 215 | | self.angle_rad * self.curve.sample(p), [INFO] [stdout] 216 | | ) * &*start_rotation.borrow()), [INFO] [stdout] | |_________________________-------------------------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `*start_rotation.borrow()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/animation/predefined/basic.rs:276:22 [INFO] [stdout] | [INFO] [stdout] 276 | &(*start_place.borrow() [INFO] [stdout] | ______________________^ [INFO] [stdout] 277 | | + &((self.target_place - *start_place.borrow()) * self.curve.sample(p))), [INFO] [stdout] | |___________________________---------------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `((self.target_place - *start_place.borrow()) * self.curve.sample(p))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/animation/predefined/basic.rs:335:22 [INFO] [stdout] | [INFO] [stdout] 335 | &(*start_scale.borrow() [INFO] [stdout] | ______________________^ [INFO] [stdout] 336 | | + &((self.target_scale - *start_scale.borrow()) * self.curve.sample(p))), [INFO] [stdout] | |___________________________---------------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `((self.target_scale - *start_scale.borrow()) * self.curve.sample(p))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/predefined/transform.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 111 | &transformed.borrow().as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `transformed.borrow().as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/predefined/transform.rs:115:25 [INFO] [stdout] | [INFO] [stdout] 115 | / &mut scene [INFO] [stdout] 116 | | .borrow_mut() [INFO] [stdout] 117 | | .acquire_instance_mut_unchecked(self.mesh_id), [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 115 ~ scene [INFO] [stdout] 116 + .borrow_mut() [INFO] [stdout] 117 ~ .acquire_instance_mut_unchecked(self.mesh_id), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animation/predefined/transform.rs:205:29 [INFO] [stdout] | [INFO] [stdout] 205 | ... return [transformed[0], transformed[1], transformed[2]]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 205 - return [transformed[0], transformed[1], transformed[2]]; [INFO] [stdout] 205 + [transformed[0], transformed[1], transformed[2]] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/animation/predefined/transform.rs:204:47 [INFO] [stdout] | [INFO] [stdout] 204 | ... let transformed = self.matrix * &Vector3::from_row_slice(point); [INFO] [stdout] | ^^^^^^^^^^^^^^------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `Vector3::from_row_slice(point)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/predefined/transform.rs:220:25 [INFO] [stdout] | [INFO] [stdout] 220 | &transformed.borrow().as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `transformed.borrow().as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/predefined/transform.rs:224:25 [INFO] [stdout] | [INFO] [stdout] 224 | / &mut scene [INFO] [stdout] 225 | | .borrow_mut() [INFO] [stdout] 226 | | .acquire_instance_mut_unchecked(self.mesh_id), [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 224 ~ scene [INFO] [stdout] 225 + .borrow_mut() [INFO] [stdout] 226 ~ .acquire_instance_mut_unchecked(self.mesh_id), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 35.84s [INFO] running `Command { std: "docker" "inspect" "70f99ab62ab06275450928ed6d61757dc4a842d61b37bf99ee68deea4d8d12f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70f99ab62ab06275450928ed6d61757dc4a842d61b37bf99ee68deea4d8d12f9", kill_on_drop: false }` [INFO] [stdout] 70f99ab62ab06275450928ed6d61757dc4a842d61b37bf99ee68deea4d8d12f9